Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-11-04 Thread Gerd Hoffmann
On Wed, Oct 31, 2018 at 03:06:04PM -0300, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: > > > > > > On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > > > Hi Gerd, > > > > > > On 30/10/18 12:13, Gerd Hoffmann wrote: > > >> Indicates support state for so

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-11-04 Thread Gerd Hoffmann
Hi, > > - Maintainers can deprecate stuffs > > - Orphan code can become Supported > > - Once scheduled for removal, there is no way back > > - 'Unknown' seems pretty similar to 'Orphan'. > > I'm still worried that the supported/unsupported distinction may > cause unnecessary hassle for every do

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-04 Thread Marc-André Lureau
Hi On Mon, Nov 5, 2018 at 11:22 AM Artem Pisarenko wrote: > > Sorry, I forgot to check unit tests. Although, it's very strange that this > specific test failed while things work functionally... > > > I am a bit reluctant to take patches that don't actually "fix" things. > > > > Could you add some

Re: [Qemu-devel] [PATCH 4/4] MAINTAINERS: s390/boot: the ipl code and the bios belong together

2018-11-04 Thread Thomas Huth
On 2018-10-29 16:42, Christian Borntraeger wrote: > The s390-ccw bios and the ipl code do work in lock-step. Let us merge > them in the maintainer file. > > Signed-off-by: Christian Borntraeger > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTA

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-04 Thread Artem Pisarenko
Sorry, I forgot to check unit tests. Although, it's very strange that this specific test failed while things work functionally... > I am a bit reluctant to take patches that don't actually "fix" things. > > Could you add some tests to demonstrate the problems? Ok >> @@ -257,6 +257,7 @@ void qemu

Re: [Qemu-devel] [PATCH v3 7/8] target-alpha: use HTTPS git URL for palcode

2018-11-04 Thread Richard Henderson
On 11/4/18 11:24 AM, Stefan Hajnoczi wrote: > When you clone the repository without previous commit history, 'git://' > doesn't protect from man-in-the-middle attacks. HTTPS is more secure > since the client verifies the server certificate. > > Cc: Richard Henderson > Suggested-by: Eric Blake >

Re: [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-04 Thread Gerd Hoffmann
> 2. Have a single function as follows: > > void spice_qxl_set_device_info(QXLInstance *instance, >const char *device_address, >uint32_t device_display_id_start, >uint32_t device_display_id_count); How

Re: [Qemu-devel] one issue about usb passsthrough devices

2018-11-04 Thread gerd hoffmann
On Thu, Nov 01, 2018 at 01:57:15AM +, linzhecheng wrote: > Hi, all > A found a problem about libusb, the reproducing steps are as followed: > 1. start up a vm with host-usb devices > 2. kill -9 `pgrep qemu` > We can not see the usb device on host any more, I think this is because qemu > has no

Re: [Qemu-devel] [PATCH v4 01/13] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-11-04 Thread Thomas Huth
On 2018-11-02 18:07, Steffen Görtz wrote: > Adds a new qtest command "set_irq_in" which allows > to set qemu gpio lines to a given level. > > Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html > which never got merged. > > Signed-off-by: Steffen Görtz > Originally-by: M

Re: [Qemu-devel] [PATCH RFC v7 0/9] qemu_thread_create: propagate errors to callers to check

2018-11-04 Thread Fei Li
Sorry that somehow forget the "#include "qemu/error-report.h" for hw/usb/ccid-card-emulated.c Have a nice day, thanks Fei On 11/04/2018 02:09 AM, no-re...@patchew.org wrote: Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you

[Qemu-devel] [Bug 1496384] Re: Error 0x5D in Qemu for Windows

2018-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1496384 Title: Error 0x5D

[Qemu-devel] [Bug 1497479] Re: memory corruption with migrate/savevm in TCG mode

2018-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1497479 Title: memory corr

[Qemu-devel] [Bug 1496712] Re: no bootable device after qemu-img convert parallels windows 2012 r2 to raw/qcow2

2018-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1496712 Title: no bootable

[Qemu-devel] [PATCH] blockdev: handle error on block latency histogram set error

2018-11-04 Thread zhenwei pi
Function block_latency_histogram_set may return error, but qapi ignore this. This can be reproduced easily by qmp command: virsh qemu-monitor-command INSTANCE '{"execute":"x-block-latency-histogram-set", "arguments":{"device":"drive-virtio-disk1","boundaries":[10,200,40]}}' In fact this command doe

Re: [Qemu-devel] [PATCH v4 00/23] ACPI reorganization for hardware-reduced support

2018-11-04 Thread Samuel Ortiz
Hi Igor, On Fri, Nov 02, 2018 at 01:29:25PM +0100, Igor Mammedov wrote: > On Thu, 1 Nov 2018 11:22:40 +0100 > Samuel Ortiz wrote: > > Thanks for looking at ACPI mess we have in QEMU and trying to make it better, Thanks for the initial review and feedback. > this series look a bit hackish proba

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-04 Thread Li Qiang
Kevin Wolf 于2018年11月2日周五 下午11:42写道: > Am 02.11.2018 um 16:22 hat Li Qiang geschrieben: > > Hello Kevin, > > > > Kevin Wolf 于2018年11月2日周五 下午6:54写道: > > > > > Am 02.11.2018 um 02:22 hat Li Qiang geschrieben: > > > > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > > > > This can l

[Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState

2018-11-04 Thread Samuel Ortiz
From: Sebastien Boeuf Instead of using the machine type specific method find_i440fx() to retrieve the PCI bus, this commit aims to rely on the fact that the PCI bus is known by the structure AcpiPciHpState. When the structure is initialized through acpi_pcihp_init() call, it saves the PCI bus, w

[Qemu-devel] [PATCH v5 17/24] hw: acpi: Export the PCI hotplug API

2018-11-04 Thread Samuel Ortiz
From: Sebastien Boeuf The ACPI hotplug support for PCI devices APIs are not x86 or even machine type specific. In order for future machine types to be able to re-use that code, we export it through the architecture agnostic hw/acpi folder. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-04 Thread Li Qiang
Keith Busch 于2018年11月2日周五 下午11:42写道: > On Thu, Nov 01, 2018 at 06:22:43PM -0700, Li Qiang wrote: > > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > > This can lead an oob access issue. This is triggerable in the guest. > > Add check to avoid this issue. > > > > Fixes CVE-2018-1

[Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT build method

2018-11-04 Thread Samuel Ortiz
It is going to be used by the PC machine type as the MADT table builder method and thus needs to be exported outside of acpi-build.c Also, now that the generic build_madt() API is exported, we have to rename the ARM static one in order to avoid build time conflicts. Reviewed-by: Philippe Mathieu-

[Qemu-devel] [PATCH v5 24/24] hw: i386: Refactor PCI host getter

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong Now that the ACPI builder methods are added, we can reach the ACPI configuration pointer from the MachineState pointer. From there we can get to the PCI host pointer and return it. This makes the PCI host getter an ACPI, architecture agnostic function. Signed-off-by: Yang Zhong

[Qemu-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong Most of the AML build routines under acpi-build are not even architecture specific. They can be moved to the more generic hw/acpi folder where they could be shared across machine types and architectures. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Sig

[Qemu-devel] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong When using the generated memory hotplug AML, the iasl compiler would give the following error: dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) Error 6080 - Called method returns no value ^ Signed-off-by: Yang Zhong --- hw/acpi/memory_hotplug.c | 10 +- 1 file cha

[Qemu-devel] [PATCH v5 21/24] hw: i386: Implement the ACPI builder interface for PC

2018-11-04 Thread Samuel Ortiz
All PC machine type derivatives will use the same ACPI table build methods. But with that change in place, any new x86 machine type will be able to re-use the acpi-build API and customize part of it by defining its own ACPI table build methods. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phili

[Qemu-devel] [PATCH v5 22/24] hw: pci-host: piix: Return PCI host pointer instead of PCI bus

2018-11-04 Thread Samuel Ortiz
For building the MCFG table, we need to track a given machine type PCI host pointer, and we can't get it from the bus pointer alone. As piix returns a PCI bus pointer, we simply modify its builder to return a PCI host pointer instead. Signed-off-by: Samuel Ortiz --- include/hw/i386/pc.h | 21 +++

[Qemu-devel] [PATCH v5 14/24] hw: i386: Make the hotpluggable memory size property more generic

2018-11-04 Thread Samuel Ortiz
This property is currently defined under i386/pc while it only describes a region size that's eventually fetched from the AML ACPI code. We can make it more generic and shareable across machine types by moving it to memory-device.h instead. Signed-off-by: Samuel Ortiz --- include/hw/i386/pc.h

[Qemu-devel] [PATCH v5 06/24] hw: acpi: Factorize the RSDP build API implementation

2018-11-04 Thread Samuel Ortiz
We can now share the RSDP build between the ARM and x86 architectures. Here we make the default RSDP build use XSDT and keep the existing x86 ACPI build implementation using the legacy RSDT version. Signed-off-by: Samuel Ortiz --- include/hw/acpi/aml-build.h | 8 hw/acpi/aml-build.c

[Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method

2018-11-04 Thread Samuel Ortiz
This is the standard way of building SRAT on x86 platfoms. But future machine types could decide to define their own custom SRAT build method through the ACPI builder methods. Moreover, we will also need to reach build_srat() from outside of acpi-build in order to use it as the ACPI builder SRAT bu

[Qemu-devel] [PATCH v5 23/24] hw: i386: Set ACPI configuration PCI host pointer

2018-11-04 Thread Samuel Ortiz
For both PC and Q35 machine types, we can set it at the PCI host bridge creation time. Signed-off-by: Samuel Ortiz --- hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f5b139a3eb..f1f0de3585 100644 --- a/

[Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-04 Thread Samuel Ortiz
XSDT is the 64-bit version of the legacy ACPI RSDT (Root System Description Table). RSDT only allow for 32-bit addressses and have thus been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and no longer RSDTs, although RSDTs are still supported for backward compatibility. Since ver

[Qemu-devel] [PATCH v5 12/24] hw: acpi: Export the MCFG getter

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong The ACPI MCFG getter is not x86 specific and could be called from anywhere within generic ACPI API, so let's export it. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Yang Zhong --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c

[Qemu-devel] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface

2018-11-04 Thread Samuel Ortiz
In order to decouple ACPI APIs from specific machine types, we are creating an ACPI builder interface that each ACPI platform can choose to implement. This way, a new machine type can re-use the high level ACPI APIs and define some custom table build methods, without having to duplicate most of the

[Qemu-devel] [PATCH v5 11/24] hw: acpi: Export and generalize the PCI host AML API

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi folder, and by carrying all the needed information through a new AcpiPciBus structure, we can mak

[Qemu-devel] [PATCH v5 04/24] hw: acpi: Export the RSDP build API

2018-11-04 Thread Samuel Ortiz
The hardware-reduced API will need to build RSDP as well, so we should export this routine. Signed-off-by: Samuel Ortiz --- include/hw/acpi/aml-build.h | 3 +++ hw/arm/virt-acpi-build.c| 2 +- hw/i386/acpi-build.c| 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH v5 13/24] hw: acpi: Do not create hotplug method when handler is not defined

2018-11-04 Thread Samuel Ortiz
CPU and memory ACPI hotplug are not necessarily handled through SCI events. For example, with Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, we make the CPU and memory specific events AML generation optional. The code will only be added when the method na

[Qemu-devel] [PATCH v5 08/24] hw: acpi: Factorize _OSC AML across architectures

2018-11-04 Thread Samuel Ortiz
From: Yang Zhong The _OSC AML table is almost identical between the i386 Q35 and arm virt machine types. We can make it slightly more generic and share it across all PCIe architectures. Signed-off-by: Yang Zhong --- include/hw/acpi/acpi-defs.h | 14 +++ include/hw/acpi/aml-build.h | 2 +-

[Qemu-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type

2018-11-04 Thread Samuel Ortiz
ACPI tables are platform and machine type and even architecture agnostic, and as such we want to provide an internal ACPI API that only depends on platform agnostic information. For the x86 architecture, in order to build ACPI tables independently from the PC or Q35 machine types, we are moving a

[Qemu-devel] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void

2018-11-04 Thread Samuel Ortiz
For both x86 and ARM architectures, the internal RSDP build API can return void as the current return value is unused. Signed-off-by: Samuel Ortiz --- hw/arm/virt-acpi-build.c | 4 +--- hw/i386/acpi-build.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/arm/virt-

[Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters

2018-11-04 Thread Samuel Ortiz
This is going to be needed by the hardware reduced implementation, so let's export it. Once the ACPI builder methods and getters will be implemented, the acpi_get_pci_host() implementation will become hardware agnostic. Signed-off-by: Samuel Ortiz --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi

[Qemu-devel] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h

2018-11-04 Thread Samuel Ortiz
The PCI hole properties are not pc or i386 specific. They belong to the PCI host header instead. Signed-off-by: Samuel Ortiz --- include/hw/i386/pc.h | 5 - include/hw/pci/pci_host.h | 6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/hw/i386/pc.h b/includ

[Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

2018-11-04 Thread Samuel Ortiz
This is going to be needed by the Hardware-reduced ACPI routines. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Samuel Ortiz --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi/aml-build.c | 8 hw/i386/acpi-build.c| 8 3 file

[Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-04 Thread Samuel Ortiz
This patch set provides an ACPI code reorganization in preparation for adding a shared hardware-reduced ACPI API to QEMU. The changes are coming from the NEMU [1] project where we're defining a new x86 machine type: i386/virt. This is an EFI only, ACPI hardware-reduced platform that is built on to

Re: [Qemu-devel] [PATCH v2 0/5] Various option help readability improvement suggestions

2018-11-04 Thread Max Reitz
Ping. I don't quite want the help output to change in 3.1 only to change it to something else in 3.2. (And at some point into freeze we have to consider just merging one of the many simple 082 reference output "fixes", which I really don't want, because I still consider the test "broken for a rea

Re: [Qemu-devel] [PATCH v4 5/8] block: Fix potential Null pointer dereferences in vvfat.c

2018-11-04 Thread Max Reitz
On 19.10.18 22:39, Liam Merwick wrote: > The calls to find_mapping_for_cluster() may return NULL but it > isn't always checked for before dereferencing the value returned. > Additionally, add some asserts to cover cases where NULL can't > be returned but which might not be obvious at first glance.

Re: [Qemu-devel] [PATCH v4 6/8] block: dump_qlist() may dereference a Null pointer

2018-11-04 Thread Max Reitz
On 19.10.18 22:39, Liam Merwick wrote: > A NULL 'list' passed into function dump_qlist() isn't correctly > validated and can be passed to qlist_first() where it is dereferenced. > > Given that dump_qlist() is static, and callers already do the right > thing, just add an assert to catch future pote

Re: [Qemu-devel] [PATCH v4 4/8] qemu-img: assert block_job_get() does not return NULL in img_commit()

2018-11-04 Thread Max Reitz
On 19.10.18 22:39, Liam Merwick wrote: > Although the function block_job_get() can return NULL, it would be a > serious bug if it did so (because the job yields before executing anything > (if it started successfully); but otherwise, commit_active_start() would > have returned an error). However,

Re: [Qemu-devel] [PATCH v4 3/8] block: Null pointer dereference in blk_root_get_parent_desc()

2018-11-04 Thread Max Reitz
On 19.10.18 22:39, Liam Merwick wrote: > The dev_id returned by the call to blk_get_attached_dev_id() in > blk_root_get_parent_desc() can be NULL (an internal call to > object_get_canonical_path may have returned NULL). > > Instead of just checking this case before before dereferencing, > adjust b

Re: [Qemu-devel] [PATCH] block: Make more block drivers compile-time configurable

2018-11-04 Thread Max Reitz
On 19.10.18 13:34, Markus Armbruster wrote: > From: Jeff Cody > > This adds configure options to control the following block drivers: > > * Bochs > * Cloop > * Dmg > * Qcow (V1) > * Vdi > * Vvfat > * qed > * parallels > * sheepdog > > Each of these defaults to being enabled. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 1/8] README: use 'https://' instead of 'git://'

2018-11-04 Thread Philippe Mathieu-Daudé
On 4/11/18 12:24, Stefan Hajnoczi wrote: When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Signed

Re: [Qemu-devel] [PATCH v3 2/8] get_maintainer: use 'https://' instead of 'git://'

2018-11-04 Thread Philippe Mathieu-Daudé
Hi Stefan, On 4/11/18 12:24, Stefan Hajnoczi wrote: When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berr

Re: [Qemu-devel] [PATCH v3 8/8] docker: use HTTPS git URL for virglrenderer

2018-11-04 Thread Philippe Mathieu-Daudé
On 4/11/18 12:24, Stefan Hajnoczi wrote: When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Philippe Mathieu-Daudé Suggested-by: Eric Blake Signed-of

Re: [Qemu-devel] [PATCH v3 7/8] target-alpha: use HTTPS git URL for palcode

2018-11-04 Thread Philippe Mathieu-Daudé
On 4/11/18 12:24, Stefan Hajnoczi wrote: When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Richard Henderson Suggested-by: Eric Blake Signed-off-by:

Re: [Qemu-devel] [PATCH v3 6/8] pc-testdev: use HTTPS git URL

2018-11-04 Thread Philippe Mathieu-Daudé
On 4/11/18 12:24, Stefan Hajnoczi wrote: When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Paolo Bonzini Suggested-by: Eric Blake Signed-off-by: Ste

Re: [Qemu-devel] [PATCH] qga-win: fix leaks of build_guest_disk_info()

2018-11-04 Thread Philippe Mathieu-Daudé
On 3/11/18 14:01, Marc-André Lureau wrote: Introduced in commit b1ba8890e63ce9432c41c5c3fc229f54c87c9c99, vol_h handle should be closed, and "out" cleanup should be done after DeviceIoControl() fails. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- qga/commands-w

[Qemu-devel] [qemu-web PATCH] Use 'https://' instead of 'git://'

2018-11-04 Thread Paolo Bonzini
Jeff Cody has enabled git smart HTTP support on qemu.org. From now on HTTPS is the preferred protocol because it adds some protection against man-in-the-middle when cloning a repo. This patch series updates git:// URLs and changes them to https://. The https:// URL format is: https://git.qem

Re: [Qemu-devel] [PATCH v3 0/8] Use 'https://' instead of 'git://'

2018-11-04 Thread Paolo Bonzini
On 04/11/2018 12:24, Stefan Hajnoczi wrote: > v3: > * Fix broken openhackware URL [Eric] > * Convert a few remaining URLs [Eric] > v2: > * Use HTTPS for repo.or.cz [Eric] > > Jeff Cody has enabled git smart HTTP support on qemu.org. From now on HTTPS > is > the preferred protocol because it a

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-04 Thread Paolo Bonzini
On 02/11/2018 13:35, Dr. David Alan Gilbert wrote: >> >> Personally, I would like to say that, starting from QEMU 3.2, enabling >> nested VMX requires a 4.20 kernel. It's a bit bold, but I think it's a >> good way to keep some sanity. Any opinions on that? > That seems a bit mean; there's a lot o

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-04 Thread Paolo Bonzini
On 02/11/2018 17:54, Daniel P. Berrangé wrote: > We have usually followed a rule that new machine types must not > affect runability of a VM on a host. IOW new machine types should > not introduce dependancies on specific kernels, or hardware features > such as CPU flags. > Anything that requires

Re: [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

2018-11-04 Thread Paolo Bonzini
On 02/11/2018 14:33, Peter Maydell wrote: > On 9 October 2018 at 12:16, Paolo Bonzini wrote: >> On 08/10/2018 18:40, Kevin Wolf wrote: I'm pretty confident this analysis of the problem is correct: unfortunately I have no idea what the right way to fix it is... >>> Yes, I agree with

Re: [Qemu-devel] [PATCH v2 1/1] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-04 Thread Stefan Weil
On 04.11.18 19:09, Leonid Bloch wrote: > If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled, > it will be embedded as a literal expression in the binary (as the > default value) because it is stringified to mark the size of the default > value. Now this is fixed by using a defin

[Qemu-devel] [PATCH v2 1/1] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-04 Thread Leonid Bloch
If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled, it will be embedded as a literal expression in the binary (as the default value) because it is stringified to mark the size of the default value. Now this is fixed by using a defined number to define this value. Signed-off-by:

[Qemu-devel] [PATCH v2 0/1] vdi: Use a literal number of bytes for

2018-11-04 Thread Leonid Bloch
Please see the commit message for the rationale. Difference from v1: * Format string is fixed. Leonid Bloch (1): vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE block/vdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1

[Qemu-devel] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-04 Thread Leonid Bloch
The lookup table for power-of-two sizes was added in commit 540b8492618eb for the purpose of having convenient shortcuts for these sizes in cases when the literal number has to be present at compile time, and expressions as '(1 * KiB)' can not be used. One such case is the stringification of sizes.

[Qemu-devel] [PATCH v2 0/1] include: Add a comment to explain the origin of

2018-11-04 Thread Leonid Bloch
Please see the commit message for the rationale. Difference from v1: * Tabs removed from the code indentation of the sample code in the comment, in order to pass checkpatch. Leonid Bloch (1): include: Add a comment to explain the origin of sizes' lookup table include/qemu/units.h | 18 +

Re: [Qemu-devel] [PATCH] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-04 Thread Leonid Bloch
> This changes the data type, so a fix is needed for a format string in > line 434. Yes, I saw, thanks! Will do. > > Regards > Stefan >

Re: [Qemu-devel] [PATCH] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-04 Thread Stefan Weil
On 03.11.18 02:48, Leonid Bloch wrote: > If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled, > it will be embedded as a literal expression in the binary (as the > default value) because it is stringified to mark the size of the default > value. Now this is fixed by using a defin

Re: [Qemu-devel] [PATCH] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-04 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181103014831.29889-1-lbl...@janustech.com Subject: [Qemu-devel] [PATCH] vdi: Use a lite

Re: [Qemu-devel] [PATCH 1/2] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1

2018-11-04 Thread Maciej W. Rozycki
On Sun, 4 Nov 2018, Fredrik Noring wrote: > It appears the correct function is tcg_gen_mov_tl because the TX79 manual > says > > MFHI: GPR[rd]63..0 <- HI63..0 > MFLO: GPR[rd]63..0 <- LO63..0 > MTHI: HI63..0 <- GPR[rs]63..0 > MTLO: LO63..0 <- GPR[rs]63..0 > MFHI1:

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-04 Thread Marc-André Lureau
Hi On Thu, Nov 1, 2018 at 6:55 PM Artem Pisarenko wrote: > > When chardev is multiplexed (mux=on) there are a lot of cases, when > CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from > frontend side) is broken. There are either generation of multiple > repeated or extra CHR_EVENT_OPENE

Re: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-04 Thread Mark Cave-Ayland
On 04/11/2018 06:53, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk > Subject: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Appl

Re: [Qemu-devel] [PATCH 1/2] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1

2018-11-04 Thread Fredrik Noring
Thank you for your reviews, Philippe and Richard, > > +switch (opc) { > > +case TX79_MMI_MFHI1: > > +#if defined(TARGET_MIPS64) > > +tcg_gen_ext32s_tl(cpu_gpr[reg], cpu_HI[1]); > > +#else > > +tcg_gen_mov_tl(cpu_gpr[reg], cpu_HI[1]); > > +#endif > > You do not need this if

[Qemu-devel] [Bug 1734810] Re: Windows guest virtual PC running abnormally slow

2018-11-04 Thread Jeb E.
Windows installs are still acting abnormally slow on the latest Gnome Boxes flatpaks in Ubuntu 18.10. I'll try to get my CLI parameters and add it to the bug. ** Changed in: qemu Status: Invalid => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml

Re: [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table

2018-11-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181103015821.30074-1-lbl...@janustech.com Subject: [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support

2018-11-04 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181102170730.12432-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v4 00/13] ar

[Qemu-devel] [PATCH v3 8/8] docker: use HTTPS git URL for virglrenderer

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Philippe Mathieu-Daudé Suggested-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- tests/docker/do

[Qemu-devel] [PATCH v3 7/8] target-alpha: use HTTPS git URL for palcode

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Richard Henderson Suggested-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- pc-bios/README | 2 +

[Qemu-devel] [PATCH v3 6/8] pc-testdev: use HTTPS git URL

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Paolo Bonzini Suggested-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- hw/misc/pc-testdev.c | 2

[Qemu-devel] [PATCH v3 5/8] git: use HTTPS git URLs for repo.or.cz

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Suggested-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- MAINTAINERS| 14 +++--- pc-bios

[Qemu-devel] [PATCH v3 2/8] get_maintainer: use 'https://' instead of 'git://'

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Signed-off-by: Stefan Hajnoczi --- scripts/get_

[Qemu-devel] [PATCH v3 1/8] README: use 'https://' instead of 'git://'

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Signed-off-by: Stefan Hajnoczi --- README

[Qemu-devel] [PATCH v3 0/8] Use 'https://' instead of 'git://'

2018-11-04 Thread Stefan Hajnoczi
v3: * Fix broken openhackware URL [Eric] * Convert a few remaining URLs [Eric] v2: * Use HTTPS for repo.or.cz [Eric] Jeff Cody has enabled git smart HTTP support on qemu.org. From now on HTTPS is the preferred protocol because it adds some protection against man-in-the-middle when cloning a re

[Qemu-devel] [PATCH v3 3/8] MAINTAINERS: use 'https://' instead of 'git://' for GitHub

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Reported-by: Jann Horn Reviewed-by: Daniel P. Berrangé Acked-by: Cornelia Huck Signed-off-by: Stefan Ha

[Qemu-devel] [PATCH v3 4/8] gitmodules: use 'https://' instead of 'git://'

2018-11-04 Thread Stefan Hajnoczi
When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Also change git.qemu-project.org to git.qemu.org (we control both domain names but qemu.org is used more w

Re: [Qemu-devel] [PATCH v2 0/5] target/arm: KVM vs ARMISARegisters

2018-11-04 Thread Marc Zyngier
Hi Richard, On Sun, 04 Nov 2018 09:50:29 +, Richard Henderson wrote: > > On 11/3/18 12:32 PM, Marc Zyngier wrote: > > We actively hide the LORegion feature from the guest since > > cc33c4e20185a391766ed5e78e2acc97e17ba511 (in the 4.17 time frame), so > > you shouldn't be able to obtain these

Re: [Qemu-devel] [PATCH] softfloat: don't execute ppc64 ISA 3.0B instruction if it is not supported

2018-11-04 Thread Laurent Vivier
On 03/11/2018 13:57, David Gibson wrote: > On Thu, Nov 01, 2018 at 06:54:59PM +0100, Laurent Vivier wrote: >> On 01/11/2018 18:49, Peter Maydell wrote: >>> On 1 November 2018 at 17:38, Laurent Vivier wrote: commit 27ae5109a2 has introduced an assembly instruction only supported by ISA 3.

[Qemu-devel] [PULL 0/1] softfloat: Don't execute divdeu without power7

2018-11-04 Thread Richard Henderson
tags/pull-softfloat-20181104 for you to fetch changes up to 7370981bd1ef58b3c20ba8b83cc342d1c61bc773: softfloat: Don't execute divdeu without power7 (2018-11-04 10:04:40 +) Only use divdeu insn with P

Re: [Qemu-devel] [PATCH 1/2] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1

2018-11-04 Thread Richard Henderson
On 11/2/18 4:08 PM, Fredrik Noring wrote: > +switch (opc) { > +case TX79_MMI_MFHI1: > +#if defined(TARGET_MIPS64) > +tcg_gen_ext32s_tl(cpu_gpr[reg], cpu_HI[1]); > +#else > +tcg_gen_mov_tl(cpu_gpr[reg], cpu_HI[1]); > +#endif You do not need this ifdef. This is already done

[Qemu-devel] [PULL 1/1] softfloat: Don't execute divdeu without power7

2018-11-04 Thread Richard Henderson
The divdeu instruction was added to ISA 2.06 (Power7). Exclude this block from older cpus. Fixes: 27ae5109a2ba (softfloat: Specialize udiv_qrnnd for ppc64) Reported-by: Laurent Vivier Signed-off-by: Richard Henderson --- include/fpu/softfloat-macros.h | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH v2 0/5] target/arm: KVM vs ARMISARegisters

2018-11-04 Thread Richard Henderson
On 11/3/18 12:32 PM, Marc Zyngier wrote: > We actively hide the LORegion feature from the guest since > cc33c4e20185a391766ed5e78e2acc97e17ba511 (in the 4.17 time frame), so > you shouldn't be able to obtain these on a recent host. I don't think that patch is ideal. In particular, LOR is a mandat

Re: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine === TEST SCRIPT BEGIN === #!/bin

Re: [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support

2018-11-04 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181102170730.12432-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v4 00/13] a