[Qemu-devel] QEMU/NEMU boot time with several x86 firmwares

2018-11-26 Thread Stefano Garzarella
Hi Samuel, Rob, I'm proceeding to compare several x86 firmwares in order to understand which suits better with -kernel option to have a fast boot with QEMU/NEMU. For your use cases, what boot time do you expect? I compared SeaBIOS, qboot, and OVMF. I started each test using this qemu

[Qemu-devel] [PATCH 6/8] hw: arm: Support both legacy and current RSDP build

2018-11-26 Thread Samuel Ortiz
We add the ability to build legacy or current RSDP tables, based on the AcpiRsdpData revision field passed to build_rsdp(). Although arm/virt only uses RSDP v2, adding that capability to build_rsdp will allow us to share the RSDP build code between ARM and x86. Signed-off-by: Samuel Ortiz ---

Re: [Qemu-devel] [PATCH] kvm: Use KVM_GET_MSR_INDEX_LIST for MSR_IA32_ARCH_CAPABILITIES support

2018-11-26 Thread Eduardo Habkost
On Sun, Nov 25, 2018 at 11:17:28PM -0500, Bandan Das wrote: > > When writing to guest's MSR_IA32_ARCH_CAPABILITIES, check whether it's > supported in the guest using the KVM_GET_MSR_INDEX_LIST ioctl. > > Fixes: d86f963694df27f11b3681ffd225c9362de1b634 > Suggested-by: Eduardo Habkost >

[Qemu-devel] [PATCH 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API

2018-11-26 Thread Samuel Ortiz
build_rsdp() is now closely following the ACPI spec instead of filling a mapped and packed C structure. With this change we will eventually be able to get rid of the AcpiRsdpDescriptor structure as we're just appending values to the RSDP file directly and not mapping this structure in memory any

[Qemu-devel] [PATCH 8/8] hw: acpi: Remove AcpiRsdpDescriptor and fix tests

2018-11-26 Thread Samuel Ortiz
We switched to the build_append_*() API for all RSDP callers, and this patch converts all existing tests depending on this structure. It is no longer needed and we can thus remove it. Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 13 -- tests/acpi-utils.h | 5

[Qemu-devel] [PATCH 7/8] hw: acpi: Export and share the ARM RSDP build

2018-11-26 Thread Samuel Ortiz
Now that build_rsdp() supports building both legacy and current RSDP tables, we can move it to a generic folder (hw/acpi) and have the i386 ACPI code reuse it in order to reduce code duplication. Signed-off-by: Samuel Ortiz --- include/hw/acpi/aml-build.h | 5 +++ hw/acpi/aml-build.c |

[Qemu-devel] [PATCH 3/8] hw: i386: Use correct RSDT length for checksum

2018-11-26 Thread Samuel Ortiz
From: Igor Mammedov AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) for checksum calculation isn't correct since we are adding extra 16 bytes. But acpi_data_push() zeroes out table, so just by luck we are summing up exta zeros which still yelds correct checksum. Fix it

[Qemu-devel] [PATCH 0/8] hw: acpi: RSDP fixes and refactoring

2018-11-26 Thread Samuel Ortiz
This patch serie fixes a couple of RSDP checksum related issues: - On RSDP rev2, we are not adding the extended checksum and computing the checksum on the full table instead of the first 20 bytes. - On RSDP rev1, we are computing the checksum on 36 bytes instead of 20. We're lucky enough that

[Qemu-devel] [PATCH 1/8] hw: acpi: The RSDP build API can return void

2018-11-26 Thread Samuel Ortiz
For both x86 and ARM architectures, the internal RSDP build API can return void as the current return value is unused. Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 4 +--- hw/i386/acpi-build.c | 4 +--- 2 files changed, 2 insertions(+), 6

[Qemu-devel] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-26 Thread Samuel Ortiz
That will allow us to generalize the ARM build_rsdp() routine to support both legacy RSDP (The current i386 implementation) and extended RSDP (The ARM implementation). Signed-off-by: Samuel Ortiz --- include/hw/acpi/acpi-defs.h | 11 +++ hw/arm/virt-acpi-build.c| 27

[Qemu-devel] [PATCH 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP

2018-11-26 Thread Samuel Ortiz
From: Igor Mammedov When RSDP table was introduced (d4bec5d87), we calculated only legacy checksum, and that was incorrect as it - specified rev=2 and forgot about extended checksum. - legacy checksum calculated on full table instead of the 1st 20 bytes Fix it by adding extended checksum

Re: [Qemu-devel] [PATCH for-3.1 v3 0/2] block: Fix crash on migration with explicit child nodes

2018-11-26 Thread Max Reitz
On 26.11.18 17:05, Kevin Wolf wrote: > v3: > - Checking whether there are still active parents only really works with > a single pass, so that's what we do now [Max] > - Test case polishing [Max] > > v2: > - Cover children that were created after their parents [Max] > > Kevin Wolf (2): >

Re: [Qemu-devel] [PATCH] nvme: Only generate interupt if warranted

2018-11-26 Thread Keith Busch
On Sun, Nov 25, 2018 at 03:03:55PM -0800, Guenter Roeck wrote: > So far the code generates interrupts even if it doesn't pass any new > information to the user. This can result in spurious interrupts as > sometimes observed with Linux. > > Only generate interrupts if warranted, ie if anything new

[Qemu-devel] [PATCH for-3.1 v3 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Kevin Wolf
bdrv_child_cb_inactivate() asserts that parents are already inactive when children get inactivated. This precondition is necessary because parents could still issue requests in their inactivation code. When block nodes are created individually with -blockdev, all of them are monitor owned and

[Qemu-devel] [PATCH for-3.1 v3 2/2] iotests: Test migration with -blockdev

2018-11-26 Thread Kevin Wolf
Check that block node activation and inactivation works with a block graph that is built with individually created nodes. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/234 | 121 + tests/qemu-iotests/234.out | 30 + tests/qemu-iotests/group

Re: [Qemu-devel] [PATCH] hw/hyperv: fix NULL dereference with pure-kvm SynIC

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 16:28, Roman Kagan wrote: > When started in compat configuration of SynIC, e.g. > > qemu-system-x86_64 -machine pc-i440fx-2.10,accel=kvm \ > -cpu host,-vmx,hv-relaxed,hv_spinlocks=0x1fff,hv-vpindex,hv-synic > > or explicitly > > qemu-system-x86_64 -enable-kvm -cpu

[Qemu-devel] [PATCH for-3.1 v3 0/2] block: Fix crash on migration with explicit child nodes

2018-11-26 Thread Kevin Wolf
v3: - Checking whether there are still active parents only really works with a single pass, so that's what we do now [Max] - Test case polishing [Max] v2: - Cover children that were created after their parents [Max] Kevin Wolf (2): block: Don't inactivate children before parents iotests:

Re: [Qemu-devel] [PATCH for-3.2 v7 0/6] Connect a PCIe host and graphics support to RISC-V

2018-11-26 Thread Alistair Francis
On Thu, Nov 22, 2018 at 2:59 AM Andrea Bolognani wrote: > > On Wed, 2018-11-21 at 17:02 +, Alistair Francis wrote: > > V7: > > - Fix the GPEX memory mapping thanks to Bin Meng > > - Fix the interrupt mapping thanks to Logan Gunthorpe > > > [...] > > > > Alistair Francis (6): > >

Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-26 Thread Alistair Francis
On Sun, Nov 25, 2018 at 7:21 PM Mao Zhongyi wrote: > > Signed-off-by: Mao Zhongyi Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index

Re: [Qemu-devel] [PATCH for-3.1 04/25] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

2018-11-26 Thread Alistair Francis
On Sun, Nov 25, 2018 at 12:54 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3b9996ab2c..007f89f126 100644 >

Re: [Qemu-devel] [RFC v2 00/28] vSMMUv3/pSMMUv3 2 stage VFIO integration

2018-11-26 Thread Auger Eric
Hi Shameer, On 11/23/18 5:28 PM, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: Qemu-devel [mailto:qemu-devel- >> bounces+shameerali.kolothum.thodi=huawei@nongnu.org] On Behalf Of >> Eric Auger >> Sent: 21 September 2018 09:18 >> To: eric.auger@gmail.com;

Re: [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method

2018-11-26 Thread Igor Mammedov
On Thu, 22 Nov 2018 00:27:33 +0100 Samuel Ortiz wrote: > On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:38 +0100 > > Samuel Ortiz wrote: > > > > > This is the standard way of building SRAT on x86 platfoms. But future > > > machine types could

[Qemu-devel] [PATCH for-3.1] hw/arm/virt-acpi-build: Fix SMMUv3 ACPI integration

2018-11-26 Thread Eric Auger
The AcpiIortSmmu3 misses 2 32b fields corresponding to the proximity domain and the device id mapping index. Also let's report IO-coherent access is supported for translation table walks, descriptor fetches and queues by setting the COHACC override flag. Without that, we observe wrong command

Re: [Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-26 Thread inactive
Ok, will do. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802684 Title: QEMU gui crashes on macOS Mojave Status in QEMU: New Bug description: QEMU release 3.0.0 as well as a recent head

[Qemu-devel] [PATCH] spice: Use new SpiceImageCompression definition

2018-11-26 Thread Frediano Ziglio
Definitions were updated by spice-server in patch de66161 included in 0.12.6 released on 12th June 2015. Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index

[Qemu-devel] [PATCH] hw/hyperv: fix NULL dereference with pure-kvm SynIC

2018-11-26 Thread Roman Kagan
When started in compat configuration of SynIC, e.g. qemu-system-x86_64 -machine pc-i440fx-2.10,accel=kvm \ -cpu host,-vmx,hv-relaxed,hv_spinlocks=0x1fff,hv-vpindex,hv-synic or explicitly qemu-system-x86_64 -enable-kvm -cpu host,hv-synic,x-hv-synic-kvm-only=on QEMU crashes in

Re: [Qemu-devel] [PATCH for-3.1] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

2018-11-26 Thread Anthony PERARD
On Mon, Nov 19, 2018 at 04:26:58PM +, Peter Maydell wrote: > Coverity (CID 796599) points out that xen_pt_setup_vga() trusts > the rom->size field in the BIOS ROM from a PCI passthrough VGA > device, and uses it as an index into the memory which contains > the BIOS image. A corrupt BIOS ROM

Re: [Qemu-devel] [RFC 38/48] translator: implement 2-pass translation

2018-11-26 Thread Alex Bennée
Emilio G. Cota writes: > The second pass only occurs when a plugin has subscribed to > TB translation events. > > Signed-off-by: Emilio G. Cota > --- > tcg/tcg.h | 8 > accel/tcg/translator.c | 91 +- > 2 files changed, 97

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-26 Thread Peter Maydell
Could I ask you to make a debug build of QEMU (configure with --enable- debug) of the current git master, and recreate the backtrace that you quoted in your report, but with the debug symbols? I'm trying to figure out exactly what we're doing on what threads right now, and it would be very helpful

Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command

2018-11-26 Thread Gerd Hoffmann
On Mon, Nov 26, 2018 at 03:01:42PM +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Add query-display-options command, which allows querying the qemu > > display configuration, and -- as an intentional side effect -- makes > > DisplayOptions discoverable via query-qmp-schema so

Re: [Qemu-devel] [PATCH 03/10] hyperv: only add SynIC in compatible configurations

2018-11-26 Thread Roman Kagan
On Mon, Nov 26, 2018 at 03:45:03PM +0100, Igor Mammedov wrote: > On Fri, 21 Sep 2018 11:22:10 +0300 > Roman Kagan wrote: > > > Certain configurations do not allow SynIC to be used in QEMU. In > > particular, > > > > - when hyperv_vpindex is off, SINT routes can't be used as they refer to > >

Re: [Qemu-devel] [RFC 23/48] translator: add plugin_insn argument to translate_insn

2018-11-26 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > include/exec/translator.h | 4 +++- > accel/tcg/translator.c | 4 ++-- > target/alpha/translate.c| 3 ++- > target/arm/translate-a64.c | 3 ++- > target/arm/translate.c | 6 -- > target/hppa/translate.c |

Re: [Qemu-devel] [PATCH 03/10] hyperv: only add SynIC in compatible configurations

2018-11-26 Thread Igor Mammedov
On Fri, 21 Sep 2018 11:22:10 +0300 Roman Kagan wrote: > Certain configurations do not allow SynIC to be used in QEMU. In > particular, > > - when hyperv_vpindex is off, SINT routes can't be used as they refer to > the destination vCPU by vp_index > > - older KVM (which doesn't expose

Re: [Qemu-devel] [PATCH for-3.1 v2 2/2] iotests: Test migration with -blockdev

2018-11-26 Thread Max Reitz
On 26.11.18 15:16, Kevin Wolf wrote: > Check that block node activation and inactivation works with a block > graph that is built with individually created nodes. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/234 | 115 + >

Re: [Qemu-devel] [PATCH v2 00/12] RFC: Fix/add vmstate handling in some I2C code

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 15:11, Corey Minyard wrote: > On 11/15/18 5:01 PM, Philippe Mathieu-Daudé wrote: >> Hi Corey, >> >> On 15/11/18 20:24, miny...@acm.org wrote: >>> These changes allow SMBus access while doing a state transfer. >>> Seems like a good idea to me in general. >>> >>> >>> >>> I'm primarily

Re: [Qemu-devel] [PATCH for-3.1 v2 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Max Reitz
On 26.11.18 15:16, Kevin Wolf wrote: > bdrv_child_cb_inactivate() asserts that parents are already inactive > when children get inactivated. This precondition is necessary because > parents could still issue requests in their inactivation code. > > When block nodes are created individually with

Re: [Qemu-devel] [PULL 0/3] target-arm queue

2018-11-26 Thread Peter Maydell
gt; (2018-11-26 11:46:04 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20181126 > > for you to fetch changes up to 58102ce7fbb2362aa53984aabcf684d164da2d9d: > > net: cadence_

Re: [Qemu-devel] [PATCH v2 20/21] xen_backend: remove xen_sysdev_init() function

2018-11-26 Thread Anthony PERARD
On Fri, Nov 23, 2018 at 11:30:39PM +0800, Mao Zhongyi wrote: > The init function doesn't do anything at all, so we > just omit it. > > Cc: sstabell...@kernel.org > Cc: anthony.per...@citrix.com > Cc: xen-de...@lists.xenproject.org > Cc: peter.mayd...@linaro.org > > Signed-off-by: Mao Zhongyi >

[Qemu-devel] [PATCH for-3.1 v2 0/2] block: Fix crash on migration with explicit child nodes

2018-11-26 Thread Kevin Wolf
v2: - Cover children that were created after their parents [Max] Kevin Wolf (2): block: Don't inactivate children before parents iotests: Test migration with -blockdev block.c| 32 ++- tests/qemu-iotests/234 | 115 +

[Qemu-devel] [PATCH for-3.1 v2 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Kevin Wolf
bdrv_child_cb_inactivate() asserts that parents are already inactive when children get inactivated. This precondition is necessary because parents could still issue requests in their inactivation code. When block nodes are created individually with -blockdev, all of them are monitor owned and

[Qemu-devel] [PATCH for-3.1 v2 2/2] iotests: Test migration with -blockdev

2018-11-26 Thread Kevin Wolf
Check that block node activation and inactivation works with a block graph that is built with individually created nodes. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/234 | 115 + tests/qemu-iotests/234.out | 27 + tests/qemu-iotests/group

Re: [Qemu-devel] [PATCH v2 00/12] RFC: Fix/add vmstate handling in some I2C code

2018-11-26 Thread Corey Minyard
On 11/15/18 5:01 PM, Philippe Mathieu-Daudé wrote: Hi Corey, On 15/11/18 20:24, miny...@acm.org wrote: These changes allow SMBus access while doing a state transfer. Seems like a good idea to me in general. I'm primarily submitting this to make sure I'm doing the backwards compatability

Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-26 Thread Philippe Mathieu-Daudé
Hi Samuel, On 20/11/18 1:57, Samuel Thibault wrote: > g_spawn_async_with_fds is portable on Windows, so we can now enable > fork_exec support there. > > Thanks Daniel P. Berrangé for the notice! On x86_64 you can build locally using Docker: $ make docker-test-build@debian-win32-cross BUILD

[Qemu-devel] Reminder: QEMU 3.1 rc3 tomorrow

2018-11-26 Thread Peter Maydell
Hi; this is a reminder that we are going to tag QEMU 3.1 rc3 tomorrow, and unless there are any last minute critical bugs this will be the final rc before we make the release. If there's anything that needs to be fixed for the release, please make sure it is in a pull request today or tomorrow

Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command

2018-11-26 Thread Markus Armbruster
Gerd Hoffmann writes: > Add query-display-options command, which allows querying the qemu > display configuration, and -- as an intentional side effect -- makes > DisplayOptions discoverable via query-qmp-schema so libvirt can go > figure which display options are supported. > > Use case: commit

[Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX and HV_CPUID_NESTED_FEATURES.EAX as feature words

2018-11-26 Thread Vitaly Kuznetsov
It was found that QMP users of QEMU (e.g. libvirt) may need HV_CPUID_ENLIGHTMENT_INFO.EAX/HV_CPUID_NESTED_FEATURES.EAX information. In particular, 'hv_tlbflush' and 'hv_evmcs' enlightenments are only exposed in HV_CPUID_ENLIGHTMENT_INFO.EAX. HV_CPUID_NESTED_FEATURES.EAX is exposed for two

[Qemu-devel] [PULL 2/3] MAINTAINERS: Add an ARM SMMU section

2018-11-26 Thread Peter Maydell
From: Eric Auger Add a new ARM SMMU section and set Eric Auger as the maintainer for ARM SMMU emulation sources. Signed-off-by: Eric Auger Message-id: 20181122180143.14237-1-eric.au...@redhat.com Suggested-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 7 +++ 1 file

[Qemu-devel] [PULL 0/3] target-arm queue

2018-11-26 Thread Peter Maydell
/people/pmaydell/qemu-arm.git tags/pull-target-arm-20181126 for you to fetch changes up to 58102ce7fbb2362aa53984aabcf684d164da2d9d: net: cadence_gem: Remove incorrect assert() (2018-11-26 13:41:42 +) target-arm queue: * some

[Qemu-devel] [PULL 1/3] MAINTAINERS: Assign some more files in the hw/arm/ directory

2018-11-26 Thread Peter Maydell
From: Thomas Huth I apparently missed some more files and even a complete machine (the "imx25-pdk") in my previous patch... but now we should hopefully have a completely coverage for all available ARM boards. Fixes: 95a5db3ae5698b49c63144610ad02913e780c828 Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH] ehci: fix fetch qtd race

2018-11-26 Thread Gerd Hoffmann
On Mon, Nov 26, 2018 at 10:34:13AM +, li qiang wrote: > > 在 2018/11/26 18:08, Gerd Hoffmann 写道: > > The token field contains the (guest-filled) state of the qtd, which > > indicates whenever the other fields are valid or not. So make sure > > we read the token first, otherwise we may end up

Re: [Qemu-devel] [PATCH for-3.2 v3 00/14] Generalize machine compatibility properties

2018-11-26 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:38 +0400 Marc-André Lureau wrote: > Hi, > > During "[PATCH v2 05/10] qom/globals: generalize > object_property_set_globals()" review, Eduardo suggested to rework the > GlobalProperty handling, so that -global is limited to QDev only and > we avoid mixing the machine

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2018-11-26 Thread Markus Armbruster
Thomas Huth writes: > On 2018-11-21 19:14, Markus Armbruster wrote: >> Time for another update. My HEAD is at v3.1.0-rc2. > > Thanks a lot for this, Markus, very appreciated! > > [...] >> Unmaintained files sorted by number of commits in the past year >> (v2.11.0-rc2): >> >> $ for i in `cat

Re: [Qemu-devel] [PATCH for-3.2 v3 11/14] qom: teach interfaces to implement post-init

2018-11-26 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:49 +0400 Marc-André Lureau wrote: > The following patches are going to implement post_init callbacks for > settings properties. The interface post_init are called before the > instance post_init, so the default interface behaviour can be > overriden if necessary.

Re: [Qemu-devel] [PATCH v3 1/2] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-26 Thread Marc-André Lureau
On Tue, Nov 6, 2018 at 4:41 PM Artem Pisarenko wrote: > > When chardev is multiplexed (mux=on) there are a lot of cases where > CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from > frontend side) is broken. There are either generation of multiple > repeated or extra CHR_EVENT_OPENED

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-26 Thread Peter Maydell
On Mon, 26 Nov 2018 at 12:52, Edgar E. Iglesias wrote: > > On Fri, Nov 23, 2018 at 05:09:35PM +, Peter Maydell wrote: > > On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias > > wrote: > > > Not sure if it's too late to even get the removal of the assert into this > > > release? Peter? > > > >

Re: [Qemu-devel] [PATCH v3 2/2] tests/test-char: add muxed chardev testing for open/close

2018-11-26 Thread Marc-André Lureau
On Tue, Nov 6, 2018 at 4:41 PM Artem Pisarenko wrote: > > Validate that frontend callbacks for CHR_EVENT_OPENED/CHR_EVENT_CLOSED > events are being issued when expected and in strictly pairing order. > > Signed-off-by: Artem Pisarenko Reviewed-by: Marc-André Lureau > --- > tests/test-char.c

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

2018-11-26 Thread Peter Maydell
On Thu, 22 Nov 2018 at 18:01, Eric Auger wrote: > > Add a new ARM SMMU section and set Eric Auger as the maintainer > for ARM SMMU emulation sources. > > Signed-off-by: Eric Auger > Suggested-by: Peter Maydell > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

2018-11-26 Thread Stefan Markovic
On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Markovic > diff --git a/MAINTAINERS b/MAINTAINERS > index aa17e9bbd3..81a22b2ccf 100644 > --- a/MAINTAINERS > +++

Re: [Qemu-devel] [PATCH for-3.1 05/25] MAINTAINERS: Add missing entries for the Jazz machine

2018-11-26 Thread Stefan Markovic
On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Markovic > diff --git a/MAINTAINERS b/MAINTAINERS > index 007f89f126..4e396cbe71 100644 > --- a/MAINTAINERS > +++

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-26 Thread Eduardo Habkost
On Sun, Nov 25, 2018 at 10:27:04PM +0100, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 23/11/18 19:10, Eduardo Habkost wrote: > > Hi, > > > > Sorry for not reviewing this series earlier. I just stumbled > > upon this part of the code: > > > > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc

Re: [Qemu-devel] [PATCH for-3.2 v3 10/14] qdev-props: call object_apply_global_props()

2018-11-26 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:48 +0400 Marc-André Lureau wrote: > It's now possible to use the common function. > > Teach object_apply_global_props() to warn if Error argument is NULL. > > Signed-off-by: Marc-André Lureau > --- > hw/core/qdev-properties.c | 24 ++-- >

[Qemu-devel] [PATCH 5/5] vhost-net: revamp configure logic

2018-11-26 Thread Paolo Bonzini
Detect all invalid configurations (e.g. mingw32 with vhost-user, non-Linux with vhost-kernel). As a collateral benefit, all vhost-kernel backends can be now disabled if one wants to reduce the attack surface. Signed-off-by: Paolo Bonzini --- configure | 88

[Qemu-devel] [PATCH 1/5] vhost-net: move stubs to a separate file

2018-11-26 Thread Paolo Bonzini
There is no reason for CONFIG_VHOST_NET to be specific to a single target; it is a host feature that can be add to all targets, as long as they support the virtio-net device. Currently CONFIG_VHOST_NET depends on CONFIG_KVM, but ioeventfd support is present in the core memory API and works with

Re: [Qemu-devel] KVM Forum VFIO BoF summary

2018-11-26 Thread Alexander Graf
On 11/26/2018 01:59 PM, Stefan Hajnoczi wrote: On Fri, Nov 23, 2018 at 10:09:53PM +, Felipe Franciosi wrote: Hi Alex, I'm also terribly sorry for the delay in responding to this. I'm only now having the time resources to come back to this topic and figure out a way forward with my

[Qemu-devel] [PATCH 4/5] vhost-net: compile it on all targets that have virtio-net.

2018-11-26 Thread Paolo Bonzini
This shows a preexisting bug: if a KVM target did not have virtio-net enabled, it would fail with undefined symbols when vhost was enabled. This must now be fixed, lest targets that have no virtio-net fail to compile. Signed-off-by: Paolo Bonzini --- configure | 11 ---

[Qemu-devel] [PATCH 2/5] vhost-net-user: add stubs for when no virtio-net device is present

2018-11-26 Thread Paolo Bonzini
hw/net/vhost_net.c needs functions that are declared in net/vhost-user.c: the vhost-user code is always compiled into QEMU, only the constructor net_init_vhost_user is unreachable. Also, net/vhost-user.c needs functions declared in hw/virtio/vhost-stub.c even if no virtio device exists. Break

[Qemu-devel] [PATCH 3/5] vhost: restrict Linux dependency to kernel vhost

2018-11-26 Thread Paolo Bonzini
vhost-user does not depend on Linux; it can run on any POSIX system. Restrict vhost-kernel to Linux in hw/virtio/vhost-backend.c, everything else can be compiled on all POSIX systems. Signed-off-by: Paolo Bonzini --- backends/Makefile.objs | 5 ++--- default-configs/virtio.mak | 4 ++--

[Qemu-devel] [PATCH 0/5] vhost: enable for all targets

2018-11-26 Thread Paolo Bonzini
vhost does not have to be supported only if KVM is present, in fact vhost-user does not even need any kind of kernel support. This series changes this. The rationale is that, when vhost-user-test.c will be converted to qgraph, it will be able to test vhost-user support for virtio-mmio backend

Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

2018-11-26 Thread Igor Mammedov
On Tue, 20 Nov 2018 15:48:06 +0800 Zhang Yi wrote: > object_get_canonical_path_component() returns a string which > must be freed using g_free(). > > Signed-off-by: Zhang Yi Reviewed-by: Igor Mammedov > --- > numa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/numa.c b/numa.c

Re: [Qemu-devel] [PATCH v5 24/24] docs: Update pvrdma device documentation

2018-11-26 Thread Yuval Shaia
On Mon, Nov 26, 2018 at 12:34:41PM +0200, Marcel Apfelbaum wrote: > Re-sending the comments, some of the recipients didn't get it, > > Thanks, > Marcel > > On 11/25/18 9:51 AM, Marcel Apfelbaum wrote: > > > > > > On 11/22/18 2:14 PM, Yuval Shaia wrote: > > > Interface with the device is

Re: [Qemu-devel] KVM Forum VFIO BoF summary

2018-11-26 Thread Stefan Hajnoczi
On Fri, Nov 23, 2018 at 10:09:53PM +, Felipe Franciosi wrote: > Hi Alex, > > I'm also terribly sorry for the delay in responding to this. I'm only now > having the time resources to come back to this topic and figure out a way > forward with my proposal. Please see my notes below (quoting

Re: [Qemu-devel] [PATCH v2] scripts/qemu.py: allow to launch the VM without a monitor

2018-11-26 Thread Caio Carrara
On Wed, Nov 21, 2018 at 01:39:00PM -0500, Wainer dos Santos Moschetta wrote: > QEMUMachine launches the VM with a monitor enabled, afterwards > a qmp connection is attempted on _post_launch(). In case > the QEMU process exits with an error, qmp.accept() reaches > timeout and raises an exception. >

[Qemu-devel] [PATCH for-3.2 11/11] contrib: add vhost-user-input

2018-11-26 Thread Marc-André Lureau
Add a vhost-user input backend example, based on virtio-input-host device. It takes an evdev path as argument, and can be associated with a vhost-user-backend object, for example via a unix socket: $ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock $ qemu ... -chardev

Re: [Qemu-devel] [PATCH v5 9/9] qapi: query-blockstat: add driver specific file-posix stats

2018-11-26 Thread Anton Nefedov
On 23/11/2018 10:21 PM, Vladimir Sementsov-Ogievskiy wrote: > 31.10.2018 14:35, Anton Nefedov wrote: >> A block driver can provide a callback to report driver-specific >> statistics. >> >> file-posix driver now reports discard statistics >> >> Signed-off-by: Anton Nefedov >> --- >>

[Qemu-devel] [PATCH for-3.2 10/11] Add vhost-user-input-pci

2018-11-26 Thread Marc-André Lureau
Add a new virtio-input device, which connects to a vhost-user backend. Usage: -object vhost-user-backend,id=vuid,chardev=... \ -device vhost-user-input-pci,vhost-user=vuid vhost-user-input is similar to virtio-input-host, it is wrapped by vhost-user-input-pci. Instead of reading configuration

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-26 Thread Edgar E. Iglesias
On Fri, Nov 23, 2018 at 05:09:35PM +, Peter Maydell wrote: > On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias > wrote: > > Not sure if it's too late to even get the removal of the assert into this > > release? Peter? > > If you're happy that removing the assert is the correct fix, > yes,

[Qemu-devel] [PATCH for-3.2 07/11] vhost-user: add vhost_user_input_get_config()

2018-11-26 Thread Marc-André Lureau
Ask vhost user input backend the list of virtio_input_config. Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.h | 1 + include/hw/virtio/vhost-backend.h | 4 ++ hw/virtio/vhost-user.c| 60 +++ docs/interop/vhost-user.txt

[Qemu-devel] [PATCH for-3.2 06/11] vhost-user: split vhost_user_read()

2018-11-26 Thread Marc-André Lureau
Split vhost_user_read(), so only header can be read with vhost_user_read_header(). Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- hw/virtio/vhost-user.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/hw/virtio/vhost-user.c

[Qemu-devel] [PATCH for-3.2 09/11] libvhost-user: add vu_queue_unpop()

2018-11-26 Thread Marc-André Lureau
vhost-user-input will make use of this function to undo some queue pop in case the virtio queue does not have enough room. Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.h | 14 ++ contrib/libvhost-user/libvhost-user.c | 16 2 files

Re: [Qemu-devel] [PATCH for-3.1 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Max Reitz
On 26.11.18 13:33, Kevin Wolf wrote: > Am 26.11.2018 um 13:05 hat Max Reitz geschrieben: >> On 26.11.18 12:28, Kevin Wolf wrote: >>> bdrv_child_cb_inactivate() asserts that parents are already inactive >>> when children get inactivated. This precondition is necessary because >>> parents could

[Qemu-devel] [PATCH for-3.2 08/11] libvhost-user-glib: export vug_source_new()

2018-11-26 Thread Marc-André Lureau
Simplify the creation of FD sources for other users. This is just convenience to avoid duplicating similar code elsewhere. Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user-glib.h | 3 +++ contrib/libvhost-user/libvhost-user-glib.c | 11 ++- 2 files changed, 9

[Qemu-devel] [PATCH for-3.2 04/11] vhost-user: wrap some read/write with retry handling

2018-11-26 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- hw/virtio/vhost-user.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 90a9492bcf..0131bbb0fc 100644 --- a/hw/virtio/vhost-user.c

[Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2018-11-26 Thread Marc-André Lureau
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU" review, let's define a common set of backend conventions to help with management layer implementation, and interoperability. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 1

[Qemu-devel] [PATCH for-3.2 05/11] Add vhost-user-backend

2018-11-26 Thread Marc-André Lureau
Create a vhost-user-backend object that holds a connection to a vhost-user backend and can be referenced from virtio devices that support it. See later patches for input & gpu usage. A chardev must be specified to communicate with the vhost-user backend, ex: -chardev

[Qemu-devel] [PATCH for-3.2 03/11] libvhost-user: exit by default on VHOST_USER_NONE

2018-11-26 Thread Marc-André Lureau
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user no longer panics on disconnect (rc == 0), and instead silently ignores an invalid VHOST_USER_NONE message. Without extra work from the API user, this will simply busy-loop on HUP events. The obvious thing to do is to exit(0)

[Qemu-devel] [PATCH for-3.2 02/11] vhost-user: simplify vhost_user_init/vhost_user_cleanup

2018-11-26 Thread Marc-André Lureau
Take a VhostUserState* that can be pre-allocated, and initialize it with the associated chardev. Signed-off-by: Marc-André Lureau Reviewed-by: Tiwei Bie --- include/hw/virtio/vhost-user-blk.h | 2 +- include/hw/virtio/vhost-user-scsi.h | 2 +- include/hw/virtio/vhost-user.h | 2 +-

[Qemu-devel] [PATCH for-3.2 00/11] vhost-user-backend & vhost-user-input

2018-11-26 Thread Marc-André Lureau
Hi, This series is based on previously discussed "[PATCH v4 00/29] vhost-user for input & GPU" and "vhost-user: define conventions for vhost-user backends" work. The GPU part is left off for now. This series introduces a "vhost-user-backend": a convenience object for vhost-user devices, for

Re: [Qemu-devel] [PULL 0/1] 9p fixes for v3.1.0-rc3

2018-11-26 Thread Peter Maydell
On Mon, 26 Nov 2018 at 09:57, Greg Kurz wrote: > > The following changes since commit 5298f4d67a911dd9cefa4c4185eed242074d64c2: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-11-23 08:54:52 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH for-3.1 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Max Reitz
On 26.11.18 13:05, Max Reitz wrote: > On 26.11.18 12:28, Kevin Wolf wrote: >> bdrv_child_cb_inactivate() asserts that parents are already inactive >> when children get inactivated. This precondition is necessary because >> parents could still issue requests in their inactivation code. >> >> When

Re: [Qemu-devel] [PATCH for-3.1 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Kevin Wolf
Am 26.11.2018 um 13:05 hat Max Reitz geschrieben: > On 26.11.18 12:28, Kevin Wolf wrote: > > bdrv_child_cb_inactivate() asserts that parents are already inactive > > when children get inactivated. This precondition is necessary because > > parents could still issue requests in their inactivation

Re: [Qemu-devel] [PATCH v5 7/9] scsi: account unmap operations

2018-11-26 Thread Anton Nefedov
On 23/11/2018 9:25 PM, Vladimir Sementsov-Ogievskiy wrote: > 31.10.2018 14:34, Anton Nefedov wrote: >> Signed-off-by: Anton Nefedov > > > Reviewed-by: Vladimir Sementsov-Ogievskiy > > but be careful: on git am, the chunk about read-only case goes into > scsi_disk_emulate_write_same instead

Re: [Qemu-devel] [PATCH v5 3/9] block: add empty account cookie type

2018-11-26 Thread Anton Nefedov
On 23/11/2018 7:04 PM, Vladimir Sementsov-Ogievskiy wrote: > 31.10.2018 14:34, Anton Nefedov wrote: >> This adds some protection from accounting unitialized cookie. > > uninitialized > fixed >> That is, block_acct_failed/done without previous block_acct_start; >> in that case, cookie

Re: [Qemu-devel] [Bug 1804961] Re: qemu-system-aarch64: Windows 10 ARM64 BSoD on boot while using virt-3.0

2018-11-26 Thread Igor Mammedov
On Sat, 24 Nov 2018 20:36:54 - GH Cao <1804...@bugs.launchpad.net> wrote: > ** Description changed: > > When I emulate a virt-3.0 machine, Windows 10 BSoD on boot, with the > error code being ACPI_BIOS_ERROR(0x00A5), virt-2.12 boots fine. > > Windows Build: 10.0.17134.1 > QEMU

Re: [Qemu-devel] [PATCH for-3.1 1/2] block: Don't inactivate children before parents

2018-11-26 Thread Max Reitz
On 26.11.18 12:28, Kevin Wolf wrote: > bdrv_child_cb_inactivate() asserts that parents are already inactive > when children get inactivated. This precondition is necessary because > parents could still issue requests in their inactivation code. > > When block nodes are created individually with

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

2018-11-26 Thread Alex Bennée
Li Qiang writes: > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang Reviewed-by: Alex Bennée > --- > target/i386/hax-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index 502ce6f0af..464744a406 100644 >

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-26 Thread Alex Bennée
Peter Maydell writes: > On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote: >> >> Hi Peter, >> Thanks for the review and comments. >> >> > >> > On 8 November 2018 at 10:29, Dongjiu Geng wrote: >> > > +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset) >> > >> > What is this

Re: [Qemu-devel] [PULL 0/4] target/xtensa fixes for 3.1

2018-11-26 Thread Peter Maydell
On Sun, 25 Nov 2018 at 23:12, Max Filippov wrote: > > Hi Peter, > > please pull the following batch of fixes for target/xtensa. > > The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16: > > Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +) > > are

[Qemu-devel] [PATCH V9 8/9] hw/misc/pvpanic: realize the configure interface

2018-11-26 Thread Peng Hao
Add configure interface for pvpanic-mmio. In qemu command line use -device pvpanic-mmio to enable the device. Signed-off-by: Peng Hao --- hw/arm/virt-acpi-build.c | 4 +++- hw/arm/virt.c| 9 - hw/misc/pvpanic.c| 1 + 3 files changed, 8 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH V9 9/9] pvpanic : update pvpanic document

2018-11-26 Thread Peng Hao
Add mmio support info in docs/specs/pvpanic.txt. Signed-off-by: Peng Hao --- docs/specs/pvpanic.txt | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt index c7bbacc..67f5591 100644 --- a/docs/specs/pvpanic.txt +++

[Qemu-devel] [PATCH V9 6/9] hw/misc/pvpanic: add configure query interface

2018-11-26 Thread Peng Hao
Add configure query interface for pvpanic-mmio. Signed-off-by: Peng Hao --- include/hw/misc/pvpanic.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/misc/pvpanic.h b/include/hw/misc/pvpanic.h index f1a05b2..2f0e9f4 100644 --- a/include/hw/misc/pvpanic.h +++

<    1   2   3   4   >