Re: [Qemu-devel] [PATCH v7 04/19] replay: don't drain/flush bdrv queue while RR is working

2018-11-29 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.10.2018 um 15:33 hat Pavel Dovgalyuk geschrieben: > > In record/replay mode bdrv queue is controlled by replay mechanism. > > It does not allow saving or loading the snapshots > > when bdrv queue is not empty. Stopping the VM is not blocked by no

Re: [Qemu-devel] Hot-pluggable device without ->unrealize() is highly suspect

2018-11-29 Thread Markus Armbruster
Juan, David, there's a migration bit for you towards the end. Peter Maydell writes: > On Thu, 29 Nov 2018 at 19:03, Markus Armbruster wrote: >> >> Li Qiang writes: >> >> > Currently the dc390 device has no unrealize function. This >> > can cause memory leak when hotplug/unplug device. Also mor

Re: [Qemu-devel] [PATCH v2 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-29 Thread Igor Mammedov
On Thu, 29 Nov 2018 14:24:24 +0100 Samuel Ortiz wrote: > That will allow us to generalize the ARM build_rsdp() routine to support > both legacy RSDP (The current i386 implementation) and extended RSDP > (The ARM implementation). > > Signed-off-by: Samuel Ortiz Reviewed-by: Igor Mammedov > --

Re: [Qemu-devel] [PATCH v2 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData

2018-11-29 Thread Igor Mammedov
On Thu, 29 Nov 2018 15:26:27 +0100 Samuel Ortiz wrote: > On Thu, Nov 29, 2018 at 03:09:32PM +0100, Andrew Jones wrote: > > On Thu, Nov 29, 2018 at 02:24:24PM +0100, Samuel Ortiz wrote: > > > That will allow us to generalize the ARM build_rsdp() routine to support > > > both legacy RSDP (The cur

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-29 Thread Thomas Huth
On 2018-11-29 21:43, Eric Blake wrote: > On 11/29/18 11:45 AM, Paolo Bonzini wrote: >> gtester is deprecated by upstream glib and it does not support tests >> that call g_test_skip in some glib stable releases. >> >> glib suggests instead using Automake's TAP support.  We do not support >> Automake

Re: [Qemu-devel] [PATCH 00/12] tcg: Improve register allocation for calls

2018-11-29 Thread Laurent Desnogues
On Fri, Nov 30, 2018 at 4:00 AM Emilio G. Cota wrote: > > On Thu, Nov 29, 2018 at 19:39:15 -0500, Emilio G. Cota wrote: > > A64 and POWER9 host numbers: > > > > https://imgur.com/a/m6Pss99 > > > > There's quite a bit of noise in the P9 measurements, but it's > > a shared machine so I can't do mu

Re: [Qemu-devel] [PATCH 1/2] test: execute g_test_run when tests are skipped

2018-11-29 Thread Thomas Huth
On 2018-11-29 18:45, Paolo Bonzini wrote: > Sometimes a test's main() function recognizes that the environment > does not support the test, and therefore exits. In this case, we > still should run g_test_run() so that a TAP harness will print the > test plan ("1..0") and the test will be marked as

Re: [Qemu-devel] [PATCH v5 11/36] spapr/xive: use the VCPU id as a NVT identifier

2018-11-29 Thread Cédric Le Goater
On 11/30/18 2:11 AM, David Gibson wrote: > On Thu, Nov 29, 2018 at 04:27:31PM +0100, Cédric Le Goater wrote: >> [ ... ] >> >> +/* >> + * The allocation of VP blocks is a complex operation in OPAL and the >> + * VP identifiers have a relation with the number of HW chips, the >> + *

[Qemu-devel] What's our ABI promise for externally visible QOM?

2018-11-29 Thread Markus Armbruster
QOM types and the QOM graph are externally visible: * qom-list-types returns QOM type names and parents. Fine print: the result is limited to concrete types by default. Aside: that's the only way to figure out whether a type is abstract. Interface design fail. The result can optionally be

Re: [Qemu-devel] [PATCH v5 23/36] spapr/xive: add migration support for KVM

2018-11-29 Thread Cédric Le Goater
[ ... ] +/* + * The sPAPRXive KVM model migration priority is higher to make sure >>> >>> Higher than what? >> >> Than the XiveTCTX and XiveSource models. >> + * its 'pre_save' method runs before all the other XIVE models. It >>> >>> If the other XIVE components are children of sPAP

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-29 Thread Wei Wang
On 11/30/2018 01:57 PM, Peter Xu wrote: Or you can introduce migration_bitmap_sync_precopy() and let precopy code call that one instead. Agree, thanks. PS. I'm a bit unsure on why we need to sync bitmap in ram_init_bitmaps. I feel like it can be removed... Seems it was added in early days

[Qemu-devel] [PATCH] usb-host: reset and close libusb_device_handle before qemu exit

2018-11-29 Thread linzhecheng
we should perform these things as same as usb_host_close. Signed-off-by: linzhecheng diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index b6602ded4e..2016375e6b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -988,7 +988,9 @@ static void usb_host_exit_notifier(struct No

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-11-29 Thread Cédric Le Goater
On 11/30/18 2:04 AM, David Gibson wrote: > On Thu, Nov 29, 2018 at 11:06:13PM +0100, Cédric Le Goater wrote: >> On 11/22/18 6:13 AM, David Gibson wrote: >>> On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: The Event Notification Descriptor also contains two Event State Bu

Re: [Qemu-devel] [PATCH for-3.1? RFC v2 0/5] fix some segmentation faults and migration issues

2018-11-29 Thread Fei Li
On 11/29/2018 10:20 PM, Eric Blake wrote: On 11/29/18 4:03 AM, Fei Li wrote: These five patches almost get the Reviewed-by and are extracted from previous "[PATCH RFC v7 0/9] qemu_thread_create: propagate errors to callers to check."  The mentioned patch series have waited on one multifd issu

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-29 Thread Peter Xu
On Fri, Nov 30, 2018 at 01:05:51PM +0800, Wei Wang wrote: > On 11/29/2018 01:10 PM, Peter Xu wrote: > > On Thu, Nov 29, 2018 at 11:40:57AM +0800, Wei Wang wrote: > > I think this precopy notifier callchain is expected to be used only for > > the precopy mode. Postcopy has its dedicated notifier cal

Re: [Qemu-devel] [PATCH RFC v2 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup

2018-11-29 Thread Fei Li
On 11/29/2018 10:50 PM, Philippe Mathieu-Daudé wrote: On 29/11/18 11:03, Fei Li wrote: Always call migrate_set_error() to set the error state without relying on whether multifd_save_cleanup() succeeds. As the passed &local_err is never used in multifd_save_cleanup(), remove it. And make the

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-29 Thread Wei Wang
On 11/29/2018 01:10 PM, Peter Xu wrote: On Thu, Nov 29, 2018 at 11:40:57AM +0800, Wei Wang wrote: I think this precopy notifier callchain is expected to be used only for the precopy mode. Postcopy has its dedicated notifier callchain that users could use. How about changing the migrate_postcopy(

Re: [Qemu-devel] [PATCH v3 1/1] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2018-11-29 Thread David Gibson
On Mon, Jul 30, 2018 at 07:17:48PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > This is a model of the PCIe Host Bridge (PHB3) found on a Power8 > processor. It includes the PowerBus logic interface (PBCQ), IOMMU > support, a single PCIe Gen.3 Root Complex, and support for MS

Re: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets

2018-11-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets Message-id: 20181129031230.31082-1-jasow...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=ba

Re: [Qemu-devel] [PATCH RFC v2 3/5] migration: fix the multifd code when receiving less channels

2018-11-29 Thread Fei Li
On 11/29/2018 10:46 PM, Philippe Mathieu-Daudé wrote: Hi Fei, On 29/11/18 11:03, Fei Li wrote: In our current code, when multifd is used during migration, if there is an error before the destination receives all new channels, the source keeps running, however the destination does not exit bu

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-11-29 Thread Guenter Roeck
On 11/29/18 6:42 PM, BALATON Zoltan wrote: On Thu, 29 Nov 2018, Guenter Roeck wrote: On 11/29/18 4:43 PM, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 29/11/18 21:29, BALATON Zoltan wrote: Hello, I could not boot Raspbian on QEMU's raspi emulation and I'm not sure why it fails. So question is

Re: [Qemu-devel] [PATCH RFC v2 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-29 Thread Fei Li
On 11/29/2018 08:49 PM, Markus Armbruster wrote: You neglected to cc the maintainer. I'm doing that for you now. Cc'ing maintainers is important to maximize your chances at getting your patches picked up. Use scripts/get_maintainer.pl to find them. Got it, thanks so much for this tip! :)

Re: [Qemu-devel] [PATCH 00/12] tcg: Improve register allocation for calls

2018-11-29 Thread Emilio G. Cota
On Thu, Nov 29, 2018 at 19:39:15 -0500, Emilio G. Cota wrote: > A64 and POWER9 host numbers: > > https://imgur.com/a/m6Pss99 > > There's quite a bit of noise in the P9 measurements, but it's > a shared machine so I can't do much about that. > > I'll update the A64 results with error bars later

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-11-29 Thread BALATON Zoltan
On Thu, 29 Nov 2018, Guenter Roeck wrote: On 11/29/18 4:43 PM, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 29/11/18 21:29, BALATON Zoltan wrote: Hello, I could not boot Raspbian on QEMU's raspi emulation and I'm not sure why it fails. So question is if this is supposed to work or am I doing s

[Qemu-devel] [PATCH 3/3] nbd/client: Send NBD_CMD_DISC if open fails after connect

2018-11-29 Thread Eric Blake
If nbd_client_init() fails after we are already connected, then the server will spam logs with: Disconnect client, due to: Unexpected end-of-file before all bytes were read unless we gracefully disconnect before closing the connection. Ways to trigger this: $ opts=driver=nbd,export=foo,server.

[Qemu-devel] [PATCH 1/3] nbd/server: Advertise all contexts in response to bare LIST

2018-11-29 Thread Eric Blake
The NBD spec, and even our code comment, says that if the client asks for NBD_OPT_LIST_META_CONTEXT with 0 queries, then we should reply with (a possibly-compressed representation of) ALL contexts that we are willing to let them try. But commit 3d068aff forgot to advertise qemu:dirty-bitmap:FOO.

[Qemu-devel] [PATCH 2/3] nbd/client: Make x-dirty-bitmap more reliable

2018-11-29 Thread Eric Blake
The implementation of x-dirty-bitmap in qemu 3.0 silently falls back to treating the server as not supporting NBD_CMD_BLOCK_STATUS if a requested meta_context name was not negotiated, which in turn means treating the _entire_ image as data. Since our hack relied on using 'qemu-img map' to view whic

[Qemu-devel] [PATCH for-3.1? 0/3] NBD dirty bitmap cleanups

2018-11-29 Thread Eric Blake
I'm working on a larger series for 4.0 that will add 'qemu-nbd --list' to show all possible information about a server's exports, to make it easier to diagnose if the right exports and bitmaps are present. But in the process, I found a few bugs that may be worth fixing in 3.1. By itself, this ser

Re: [Qemu-devel] [RFC/PATCH] i386: Atomically update PTEs with mttcg

2018-11-29 Thread Benjamin Herrenschmidt
On Thu, 2018-11-29 at 16:12 -0800, Richard Henderson wrote: > > You mean translating once for the load and for the udpate ? Do you > > expect that translation to have such a significant cost considering > > that all it needs should be in L1 at that point ? > > I guess if the update is rare-ish, th

Re: [Qemu-devel] [RFC/PATCH] i386: Atomically update PTEs with mttcg

2018-11-29 Thread Benjamin Herrenschmidt
On Thu, 2018-11-29 at 16:12 -0800, Richard Henderson wrote: > On 11/29/18 2:54 PM, Benjamin Herrenschmidt wrote: > > > pdpe_addr = (pml4e & PG_ADDRESS_MASK) + > > > (((gphys >> 30) & 0x1ff) << 3); > > > pdpe = x86_ldq_phys(cs, pdpe_addr); > > > do { > > > if

Re: [Qemu-devel] [PATCH for-3.1? 0/2] NBD dirty bitmap cleanups

2018-11-29 Thread Eric Blake
On 11/29/18 7:11 PM, Eric Blake wrote: I'm working on a bigger series to add 'qemu-nbd --list' that shows all details about all exports of a given server. In the process, it turned up a couple of bugs. By themselves, these are not enough to cause -rc4 (the bugs already existed in 3.0; this is not

Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-29 Thread xiezhide
> > Eric Blake writes: > > > On 11/28/18 3:25 AM, Markus Armbruster wrote: > >> xiezhide writes: > >> > >>> Rename the ThrottleLimits member names and modify related code > >>> > >>> Signed-off-by: xiezhide > >>> --- > >>> qapi/block-core.json | 70 +++--- > >>> util/thrott

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 11:06:13PM +0100, Cédric Le Goater wrote: > On 11/22/18 6:13 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: > >> The Event Notification Descriptor also contains two Event State > >> Buffers providing further coalescing of interr

Re: [Qemu-devel] [PATCH v5 11/36] spapr/xive: use the VCPU id as a NVT identifier

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 04:27:31PM +0100, Cédric Le Goater wrote: > [ ... ] > > +/* > + * The allocation of VP blocks is a complex operation in OPAL and the > + * VP identifiers have a relation with the number of HW chips, the > + * size of the VP blocks, VP grouping, etc. The

Re: [Qemu-devel] [PATCH v5 16/36] spapr: add hcalls support for the XIVE exploitation interrupt mode

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 05:04:50PM +0100, Cédric Le Goater wrote: > On 11/29/18 2:23 AM, David Gibson wrote: > > On Wed, Nov 28, 2018 at 11:21:37PM +0100, Cédric Le Goater wrote: > >> On 11/28/18 5:25 AM, David Gibson wrote: > >>> On Fri, Nov 16, 2018 at 11:57:09AM +0100, Cédric Le Goater wrote: >

Re: [Qemu-devel] [PATCH v5 23/36] spapr/xive: add migration support for KVM

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 05:19:51PM +0100, Cédric Le Goater wrote: > David, > > Could you tell what you think about the KVM interfaces for migration, > the ones capturing and restoring the states ? > > On 11/29/18 4:43 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:16AM +0100, Cédric L

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 06:51:53PM +0100, Cédric Le Goater wrote: > On 11/29/18 4:39 AM, Benjamin Herrenschmidt wrote: > > On Thu, 2018-11-29 at 11:47 +1100, David Gibson wrote: > >> > >> 1) read/write accessors which take a word number > > ok for single word updates of the structures. > > >> 2)

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-11-29 Thread Guenter Roeck
On 11/29/18 4:43 PM, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 29/11/18 21:29, BALATON Zoltan wrote: Hello, I could not boot Raspbian on QEMU's raspi emulation and I'm not sure why it fails. So question is if this is supposed to work or am I doing something wrong or any clues what may be mis

[Qemu-devel] [PATCH for-3.1? 0/2] NBD dirty bitmap cleanups

2018-11-29 Thread Eric Blake
I'm working on a bigger series to add 'qemu-nbd --list' that shows all details about all exports of a given server. In the process, it turned up a couple of bugs. By themselves, these are not enough to cause -rc4 (the bugs already existed in 3.0; this is not a regression fix), but if we have -rc4 f

Re: [Qemu-devel] [PATCH v2] glib-compat: work around g_test_message bug with subprocess tests

2018-11-29 Thread Eric Blake
On 11/29/18 6:08 PM, Paolo Bonzini wrote: On 29/11/18 19:00, Paolo Bonzini wrote: Subprocesses are created by glib without leaving the file descriptors open. Therefore, g_test_message (and assertion failures, but those trigger when things are going bad anyway) will think that it is writing to t

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-11-29 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 29/11/18 21:29, BALATON Zoltan wrote: > Hello, > > I could not boot Raspbian on QEMU's raspi emulation and I'm not sure why > it fails. So question is if this is supposed to work or am I doing > something wrong or any clues what may be missing? I'm trying with this > command line wi

Re: [Qemu-devel] [PATCH 00/12] tcg: Improve register allocation for calls

2018-11-29 Thread Emilio G. Cota
On Thu, Nov 29, 2018 at 11:23:09 -0800, Richard Henderson wrote: > On 11/28/18 2:15 PM, Emilio G. Cota wrote: > > Unfortunately, it doesn't seem to help, performance-wise. > > That is really disappointing, considering the size gains are huge -- even more > dramatically for non-x86 hosts. I will s

[Qemu-devel] [Bug 1805913] [NEW] readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2018-11-29 Thread Ke Liu
Public bug reported: This can be simply reproduced by compiling and running the attached C code (readdir-bug.c) under 32-bit user-static qemu, such as qemu-arm- static: # Setup docker for user-static binfmt docker run --rm --privileged multiarch/qemu-user-static:register --reset # Compile the cod

Re: [Qemu-devel] [RFC/PATCH] i386: Atomically update PTEs with mttcg

2018-11-29 Thread Richard Henderson
On 11/29/18 2:54 PM, Benjamin Herrenschmidt wrote: >> pdpe_addr = (pml4e & PG_ADDRESS_MASK) + >> (((gphys >> 30) & 0x1ff) << 3); >> pdpe = x86_ldq_phys(cs, pdpe_addr); >> do { >> if (!(pdpe & PG_PRESENT_MASK)) { >> goto do_fault; >> } >>

Re: [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-11-29 Thread David Gibson
On Wed, Nov 28, 2018 at 08:27:06PM +0100, BALATON Zoltan wrote: > Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and > bitbang_i2c.h an error even if they are identical. Move it to a common > place to allow building with this clang version. > > Reported-by: Thomas Huth > Signed-off-by: BAL

Re: [Qemu-devel] [PATCH v2] glib-compat: work around g_test_message bug with subprocess tests

2018-11-29 Thread Paolo Bonzini
On 29/11/18 19:00, Paolo Bonzini wrote: > Subprocesses are created by glib without leaving the file descriptors > open. Therefore, g_test_message (and assertion failures, but those > trigger when things are going bad anyway) will think that it is writing > to the log file descriptor, but while act

Re: [Qemu-devel] [PATCH v1 4/4] hw/arm: versal: Correct the nr of IRQs to 192

2018-11-29 Thread Alistair Francis
On Thu, Nov 29, 2018 at 8:40 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Correct the nr of IRQs to 192. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > include/hw/arm/xlnx-versal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [RFC/PATCH] i386: Atomically update PTEs with mttcg

2018-11-29 Thread Benjamin Herrenschmidt
On Thu, 2018-11-29 at 11:04 -0800, Richard Henderson wrote: > On 11/28/18 3:15 PM, Benjamin Herrenschmidt wrote: > > +static inline uint64_t update_entry(CPUState *cs, target_ulong addr, > > +uint64_t orig_entry, uint32_t bits) > > +{ > > +uint64_t new_entry

Re: [Qemu-devel] [PATCH v5 32/36] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 05:40:18PM +0100, Cédric Le Goater wrote: > On 11/29/18 5:12 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:25AM +0100, Cédric Le Goater wrote: > >> Removing RTAS handlers will become necessary when the new pseries > >> machine supporting multiple interrupt mode i

Re: [Qemu-devel] [PATCH v5 28/36] ppc/xics: introduce a icp_kvm_init() routine

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 05:36:19PM +0100, Cédric Le Goater wrote: > On 11/29/18 5:08 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:21AM +0100, Cédric Le Goater wrote: > >> This routine gathers all the KVM initialization of the XICS KVM > >> presenter. It will be useful when the initiali

Re: [Qemu-devel] [PATCH v5 15/36] spapr: introdude a new machine IRQ backend for XIVE

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 04:34:51PM +0100, Cédric Le Goater wrote: > On 11/29/18 2:07 AM, David Gibson wrote: > > On Wed, Nov 28, 2018 at 06:16:58PM +0100, Cédric Le Goater wrote: > >> On 11/28/18 4:28 AM, David Gibson wrote: > >>> On Fri, Nov 16, 2018 at 11:57:08AM +0100, Cédric Le Goater wrote: >

Re: [Qemu-devel] [PATCH v5 10/36] spapr/xive: introduce a XIVE interrupt controller

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 03:37:12PM +0100, Cédric Le Goater wrote: > [ ... ] > > >>> With that approach it might make sense to embed it > >>> here, rather than subclassing it > >> > >> ah. why not indeed. I have to think about it. > >> > >>> (the old composition vs. inheritance debate). > >> > >

[Qemu-devel] [PATCH v6 23/23] docs: Update pvrdma device documentation

2018-11-29 Thread Yuval Shaia
Interface with the device is changed with the addition of support for MAD packets. Adjust documentation accordingly. While there fix a minor mistake which may lead to think that there is a relation between using RXE on host and the compatibility with bare-metal peers. Signed-off-by: Yuval Shaia

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-29 Thread Paolo Bonzini
On 29/11/18 22:06, Eric Blake wrote: > On 11/29/18 11:45 AM, Paolo Bonzini wrote: >> gtester is deprecated by upstream glib and it does not support tests >> that call g_test_skip in some glib stable releases. >> >> glib suggests instead using Automake's TAP support.  We do not support >> Automake,

[Qemu-devel] [PATCH v6 17/23] hw/pvrdma: Fill error code in command's response

2018-11-29 Thread Yuval Shaia
Driver checks error code let's set it. In addition, for code simplification purposes, set response's fields ack, response and err outside of the scope of command handlers. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 202 ++-

[Qemu-devel] [PATCH v6 18/23] hw/rdma: Remove unneeded code that handles more that one port

2018-11-29 Thread Yuval Shaia
Device supports only one port, let's remove a dead code that handles more than one port. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 34 -- hw/rdma/rdma_rm.h | 2 +- hw/rdma/rdma_rm_defs.h | 4 ++-- 3 files changed

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

2018-11-29 Thread Cédric Le Goater
On 11/22/18 6:13 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: >> The Event Notification Descriptor also contains two Event State >> Buffers providing further coalescing of interrupts, one for the >> notification event (ESn) and one for the escalation e

Re: [Qemu-devel] [PATCH v2 6/6] s390x/vfio: ap: Implementing AP Queue Interrupt Control

2018-11-29 Thread Tony Krowiak
On 11/22/18 11:35 AM, Pierre Morel wrote: We intercept the PQAP(AQIC) instruction and transform the guest's AQIC command parameters for the host AQIC parameters. Doing this we use the standard adapter interface to provide the adapter NIB, indicator and ISC. We define new structures, APCard and

[Qemu-devel] [PATCH v6 16/23] hw/pvrdma: Fill all CQE fields

2018-11-29 Thread Yuval Shaia
Add ability to pass specific WC attributes to CQE such as GRH_BIT flag. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 59 +++-- hw/rdma/rdma_backend.h | 4 +-- hw/rdma/vmw/pvrdma_qp_ops.c | 31 +++

[Qemu-devel] [PATCH v6 22/23] hw/rdma: Do not call rdma_backend_del_gid on an empty gid

2018-11-29 Thread Yuval Shaia
When device goes down the function fini_ports loops over all entries in gid table regardless of the fact whether entry is valid or not. In case that entry is not valid we'd like to skip from any further processing in backend device. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- h

[Qemu-devel] [PATCH v6 13/23] hw/pvrdma: Make sure PCI function 0 is vmxnet3

2018-11-29 Thread Yuval Shaia
Guest driver enforces it, we should also. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 12 2 files changed, 14 insertions(+) diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index b019cb843a..10

[Qemu-devel] [PATCH v6 20/23] hw/pvrdma: Clean device's resource when system is shutdown

2018-11-29 Thread Yuval Shaia
In order to clean some external resources such as GIDs, QPs etc, register to receive notification when VM is shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 15 +++ 2 files changed, 17 insertions(+

[Qemu-devel] [PATCH v6 12/23] vmxnet3: Move some definitions to header file

2018-11-29 Thread Yuval Shaia
pvrdma setup requires vmxnet3 device on PCI function 0 and PVRDMA device on PCI function 1. pvrdma device needs to access vmxnet3 device object for several reasons: 1. Make sure PCI function 0 is vmxnet3. 2. To monitor vmxnet3 device state. 3. To configure node_guid accoring to vmxnet3 device's MAC

[Qemu-devel] [PATCH v6 08/23] hw/pvrdma: Set the correct opcode for recv completion

2018-11-29 Thread Yuval Shaia
The function pvrdma_post_cqe populates CQE entry with opcode from the given completion element. For receive operation value was not set. Fix it by setting it to IBV_WC_RECV. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_qp_ops.c | 3 ++- 1 file changed, 2 inser

[Qemu-devel] [PATCH v6 19/23] vl: Introduce shutdown_notifiers

2018-11-29 Thread Yuval Shaia
Notifier will be used for signaling shutdown event to inform system is shutdown. This will allow devices and other component to run some cleanup code needed before VM is shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Cornelia Huck --- include/sysemu/sysemu.h | 1 + vl.c|

[Qemu-devel] [PATCH v6 07/23] hw/pvrdma: Make default pkey 0xFFFF

2018-11-29 Thread Yuval Shaia
Commit 6e7dba23af ("hw/pvrdma: Make default pkey 0x") exports default pkey as external definition but omit the change from 0x7FFF to 0x. Fixes: 6e7dba23af ("hw/pvrdma: Make default pkey 0x") Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 2 +- 1

[Qemu-devel] [PATCH v6 11/23] hw/pvrdma: Add support to allow guest to configure GID table

2018-11-29 Thread Yuval Shaia
The control over the RDMA device's GID table is done by updating the device's Ethernet function addresses. Usually the first GID entry is determined by the MAC address, the second by the first IPv6 address and the third by the IPv4 address. Other entries can be added by adding more IP addresses. Th

[Qemu-devel] [PATCH v6 21/23] hw/rdma: Do not use bitmap_zero_extend to free bitmap

2018-11-29 Thread Yuval Shaia
bitmap_zero_extend is designed to work for extending, not for shrinking. Using g_free instead. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index b7d4ebe97

[Qemu-devel] [PATCH v6 15/23] hw/pvrdma: Make device state depend on Ethernet function state

2018-11-29 Thread Yuval Shaia
User should be able to control the device by changing Ethernet function state so if user runs 'ifconfig ens3 down' the PVRDMA function should be down as well. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[Qemu-devel] [PATCH v6 09/23] hw/pvrdma: Set the correct opcode for send completion

2018-11-29 Thread Yuval Shaia
opcode for WC should be set by the device and not taken from work element. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index

[Qemu-devel] [PATCH v6 03/23] hw/rdma: Return qpn 1 if ibqp is NULL

2018-11-29 Thread Yuval Shaia
Device is not supporting QP0, only QP1. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index 86e8fe8ab6..3ccc9a2494 100644 --- a/hw/rdma/rdma_

[Qemu-devel] [PATCH v6 14/23] hw/rdma: Initialize node_guid from vmxnet3 mac address

2018-11-29 Thread Yuval Shaia
node_guid should be set once device is load. Make node_guid be GID format (32 bit) of PCI function 0 vmxnet3 device's MAC. A new function was added to do the conversion. So for example the MAC 56:b6:44:e9:62:dc will be converted to GID 54b6:44ff:fee9:62dc. Signed-off-by: Yuval Shaia Reviewed-by:

[Qemu-devel] [PATCH v6 10/23] qapi: Define new QMP message for pvrdma

2018-11-29 Thread Yuval Shaia
pvrdma requires that the same GID attached to it will be attached to the backend device in the host. A new QMP messages is defined so pvrdma device can broadcast any change made to its GID table. This event is captured by libvirt which in turn will update the GID table in the backend device. Dep

[Qemu-devel] [PATCH v6 06/23] hw/pvrdma: Make function reset_device return void

2018-11-29 Thread Yuval Shaia
This function cannot fail - fix it to return void Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 6c8c0154fa..fc2abd34af 1006

[Qemu-devel] [PATCH v6 02/23] hw/rdma: Add ability to force notification without re-arm

2018-11-29 Thread Yuval Shaia
Upon completion of incoming packet the device pushes CQE to driver's RX ring and notify the driver (msix). While for data-path incoming packets the driver needs the ability to control whether it wished to receive interrupts or not, for control-path packets such as incoming MAD the driver needs to b

[Qemu-devel] [PATCH v6 04/23] hw/rdma: Abort send-op if fail to create addr handler

2018-11-29 Thread Yuval Shaia
Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index d7a4bbd91f..1e148398a2 100644 --- a/h

[Qemu-devel] [PATCH v6 05/23] hw/rdma: Add support for MAD packets

2018-11-29 Thread Yuval Shaia
MAD (Management Datagram) packets are widely used by various modules both in kernel and in user space for example the rdma_* API which is used to create and maintain "connection" layer on top of RDMA uses several types of MAD packets. For more information please refer to chapter 13.4 in Volume 1 A

[Qemu-devel] [PATCH v6 00/23] Add support for RDMA MAD

2018-11-29 Thread Yuval Shaia
Hi all. This is a major enhancement to the pvrdma device to allow it to work with state of the art applications such as MPI. As described in patch #5, MAD packets are management packets that are used for many purposes including but not limited to communication layer above IB verbs API. Patch 1 e

[Qemu-devel] [PATCH v6 01/23] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

2018-11-29 Thread Yuval Shaia
RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a given MAD class. This does not go hand-by-hand with qemu pvrdma device's requirements where each VM is MAD agent. Fix it by adding implementation of RDMA MAD multiplexer service which on one hand register as a sole MAD agent with

Re: [Qemu-devel] qemu-iotests 232 fails when running the test as root user

2018-11-29 Thread Farhan Ali
On 11/29/2018 04:07 PM, Eric Blake wrote: On 11/29/18 3:03 PM, Farhan Ali wrote: Hi, I am seeing a failure of the qemu-iotest number 232 when running the test as a root user. Is this the expected behavior? Here is the output of the failure: -QEMU_PROG: -drive driver=file,file=TEST_DIR

Re: [Qemu-devel] [PATCH for-3.2 v4 16/28] hw: apply machine compat properties without touching globals

2018-11-29 Thread Marc-André Lureau
Hi On Thu, Nov 29, 2018 at 9:51 PM Eduardo Habkost wrote: > > On Thu, Nov 29, 2018 at 02:32:18PM +0400, Marc-André Lureau wrote: > > Hi > > On Wed, Nov 28, 2018 at 9:53 PM Igor Mammedov wrote: > > > > > > On Tue, 27 Nov 2018 11:35:27 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Tue, Nov

Re: [Qemu-devel] [PATCH for-3.2 v4 16/28] hw: apply machine compat properties without touching globals

2018-11-29 Thread Marc-André Lureau
Hi On Thu, Nov 29, 2018 at 8:11 PM Eduardo Habkost wrote: > > On Tue, Nov 27, 2018 at 01:27:49PM +0400, Marc-André Lureau wrote: > > Similarly to accel properties, move compat properties out of globals > > registration, and apply the machine compat properties during > > device_post_init(). > > >

Re: [Qemu-devel] [PATCH 2/2] scsi: esp: Improve consistency of RSTAT, RSEQ, and RINTR

2018-11-29 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 07:33:15PM +, Mark Cave-Ayland wrote: > On 29/11/2018 19:00, Guenter Roeck wrote: > > >> Thanks for the patch. I just gave it a quick test, and unfortunately my > >> NextSTEP ISO > >> still hangs in the same place on boot :( > >> > > Too bad. Is it "same place" as with

Re: [Qemu-devel] qemu-iotests 232 fails when running the test as root user

2018-11-29 Thread Eric Blake
On 11/29/18 3:03 PM, Farhan Ali wrote: Hi, I am seeing a failure of the qemu-iotest number 232 when running the test as a root user. Is this the expected behavior? Here is the output of the failure: -QEMU_PROG: -drive driver=file,file=TEST_DIR/t.IMGFMT,if=none,read-only=off,auto-read-only

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-29 Thread Eric Blake
On 11/29/18 11:45 AM, Paolo Bonzini wrote: gtester is deprecated by upstream glib and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support. We do not support Automake, but we can copy the code that beautifies the TAP ou

[Qemu-devel] qemu-iotests 232 fails when running the test as root user

2018-11-29 Thread Farhan Ali
Hi, I am seeing a failure of the qemu-iotest number 232 when running the test as a root user. Is this the expected behavior? Here is the output of the failure: sudo ./check -qcow2 232 QEMU -- "/home/alifm/kvmdev/qemu/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nod

Re: [Qemu-devel] [PATCH v1 2/4] hw/arm: versal: Reduce number of virtio-mmio instances

2018-11-29 Thread Alistair Francis
On Thu, Nov 29, 2018 at 8:37 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Reduce number of virtio-mmio instances. This is in preparation > for correcting the interrupt setup for Versal. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/a

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] target: hax: fix errors in comment

2018-11-29 Thread Laurent Vivier
On 27/11/2018 11:00, Li Qiang wrote: > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > target/i386/hax-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index 502ce6f0af..b978a9b821 100644 > --- a/targe

Re: [Qemu-devel] [PATCH v1 1/4] hw/arm: versal: Remove bogus virtio-mmio creation

2018-11-29 Thread Alistair Francis
On Thu, Nov 29, 2018 at 8:37 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Remove bogus virtio-mmio creation. This was an accidental > left-over an experiment. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xlnx-versal-virt.c | 1 -

Re: [Qemu-devel] [PATCH 1/2] test: execute g_test_run when tests are skipped

2018-11-29 Thread Eric Blake
On 11/29/18 11:45 AM, Paolo Bonzini wrote: Sometimes a test's main() function recognizes that the environment does not support the test, and therefore exits. In this case, we still should run g_test_run() so that a TAP harness will print the test plan ("1..0") and the test will be marked as skip

Re: [Qemu-devel] [RFC 48/48] plugin: add a couple of very simple examples

2018-11-29 Thread Roman Bolshakov
On Thu, Oct 25, 2018 at 01:20:57PM -0400, Emilio G. Cota wrote: > + > +lib%.so: %.o > + $(CC) -shared -Wl,-soname,$@ -o $@ $^ $(LDLIBS) The rule should be a bit different for macOS: %.bundle: %.o $(CC) -bundle -Wl,-bundle_loader,PATH_TO_QEMU_EXE -o $@ $^ $(LDLIBS) "-bundle" flag is nee

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-29 Thread Eric Blake
On 11/29/18 11:45 AM, Paolo Bonzini wrote: gtester is deprecated by upstream glib and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support. We do not support Automake, but we can copy the code that beautifies the TAP ou

Re: [Qemu-devel] [PATCH v2 4/6] s390x/cpumodel: Set up CPU model for AQIC interception

2018-11-29 Thread Tony Krowiak
On 11/22/18 11:35 AM, Pierre Morel wrote: A new CPU model facilities is introduced to support AP devices interruption interception for a KVM guest. CPU model facility: The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CPU facility indicates whether AP interruption interception is available to the guest

[Qemu-devel] Booting Raspbian on RPi emulation

2018-11-29 Thread BALATON Zoltan
Hello, I could not boot Raspbian on QEMU's raspi emulation and I'm not sure why it fails. So question is if this is supposed to work or am I doing something wrong or any clues what may be missing? I'm trying with this command line with v3.1.0-rc3: qemu-system-arm -M raspi2 -serial stdio \ -k

Re: [Qemu-devel] [PATCH v2 1/6] s390x/vfio: ap: Finding the AP bridge

2018-11-29 Thread Tony Krowiak
On 11/22/18 11:35 AM, Pierre Morel wrote: In the case we will enter QEMU through interception of instructions, we will need to retrieve the AP devices. The base device is the AP bridge. Let us implement a way to retrieve the AP Bridge from qtree. Signed-off-by: Pierre Morel --- hw/s390x/ap-b

Re: [Qemu-devel] [PATCH v2 2/6] s390x/vfio: ap: Use the APdevice as a child of the APBus

2018-11-29 Thread Tony Krowiak
On 11/22/18 11:35 AM, Pierre Morel wrote: Two good reasons to use the base device as a child of the AP BUS: - We can easily find the device without traversing the qtree. - In case we have different APdevice instantiation, VFIO with interception or emulation, we will need the APDevice as a p

[Qemu-devel] [PATCH v2] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2018-11-29 Thread Nick Hudson
noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point. Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately. The bootloader fits in the space that the uboot header would have

Re: [Qemu-devel] [PATCH 2/2] scsi: esp: Improve consistency of RSTAT, RSEQ, and RINTR

2018-11-29 Thread Mark Cave-Ayland
On 29/11/2018 19:07, Guenter Roeck wrote: >> I've now completed a boot test of all my SPARC32 OpenBIOS CDROM images with >> this >> patch, and whilst it doesn't solve my NextSTEP issue, I don't see any obvious >> regressions. >> >> Note that NetBSD SPARC32 tends to spit out the occasional "!TC on

Re: [Qemu-devel] [RFC 41/48] configure: add --enable-plugins

2018-11-29 Thread Roman Bolshakov
On Thu, Nov 29, 2018 at 12:49:27PM -0500, Emilio G. Cota wrote: > On Thu, Nov 29, 2018 at 12:00:55 -0500, Emilio G. Cota wrote: > > On Thu, Nov 29, 2018 at 12:57:16 +0300, Roman Bolshakov wrote: > > > Hi Emilio, > > > > > > I think there's an issue with "\s" character class, it's not recognized >

Re: [Qemu-devel] [PATCH 00/12] tcg: Improve register allocation for calls

2018-11-29 Thread Richard Henderson
On 11/28/18 2:15 PM, Emilio G. Cota wrote: > Unfortunately, it doesn't seem to help, performance-wise. That is really disappointing, considering the size gains are huge -- even more dramatically for non-x86 hosts. I will see about some more benchmarking on this for other host/guest combinations.

  1   2   3   4   >