[Qemu-devel] [PULL 17/30] MAINTAINERS: Add missing entries to the PC Chipset section

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20181125205000.10324-13-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bfd4ddd93b..a

[Qemu-devel] [PULL 09/30] target: hax: replace g_malloc with g_new0

2018-12-11 Thread Laurent Vivier
From: Li Qiang And also the g_malloc doesn't need check return value, remove it. Cc: qemu-triv...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Li Qiang Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Message-Id: <1543226179-5135-1-git-se

[Qemu-devel] [PULL 23/30] MAINTAINERS: Add a missing entry for the NVDIMM device

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20181125205000.10324-22-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4251c5edd3..84e

[Qemu-devel] [PULL 10/30] MAINTAINERS: Fix ACPI tests data files path

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Missed while moving those files in 438c78dab75. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Thomas Huth Message-Id: <20181125205000.10324-2-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 3 +-- 1 file changed

[Qemu-devel] [PULL 07/30] MAINTAINERS: Add missing hw/pci-host entries

2018-12-11 Thread Laurent Vivier
From: Thomas Huth Bonito belongs to Fulong-2E, Sabre belongs to Sun4u, and Mac-Newworld and Mips-Boston were missing the header files. Signed-off-by: Thomas Huth Reviewed-by: Aleksandar Markovic Acked-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1542891760-13937-1-git-sen

[Qemu-devel] [PULL 20/30] MAINTAINERS: Add missing entries for the MPS2 machine

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Missed in de343bb632a. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20181125205000.10324-17-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINT

Re: [Qemu-devel] [PATCH 01/26] target/arm: Add state for the ARMv8.3-PAuth extension

2018-12-11 Thread Richard Henderson
On 12/11/18 8:50 AM, Peter Maydell wrote: > What's the rationale for migrating these "by hand" rather > than relying on the usual sysreg migration code ? Um... perhaps fluff where brain should be. Definitely no good reason. r~

[Qemu-devel] [PULL 21/24] qom: make user_creatable_complete() specific to UserCreatable

2018-12-11 Thread Eduardo Habkost
From: Marc-André Lureau Instead of accepting any Object*, change user_creatable_complete() to require a UserCreatable*. Modify the callers to pass the appropriate argument, removing redundant dynamic cast checks in object creation. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Re

[Qemu-devel] [PULL 24/30] MAINTAINERS: Use my work email to review Build and test automation patches

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20181125205000.10324-25-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PULL 04/30] hw: set_netdev: remove useless code

2018-12-11 Thread Laurent Vivier
From: Li Qiang In set_netdev(), the peers[i] is initialized qemu_find_net_clients_except() when i is in 0 between 'queues' it can't be NULL. Signed-off-by: Li Qiang Reviewed-by: Laurent Vivier Reviewed-by: Thomas Huth Reviewed-by: Paolo Bonzini Message-Id: <1541751214-17515-1-git-send-email-

[Qemu-devel] [PULL 22/30] MAINTAINERS: Add a missing entry to the QMP section

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Message-Id: <20181125205000.10324-20-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20096dad0

[Qemu-devel] [PULL 29/30] maint: Grammar fix to mailmap

2018-12-11 Thread Laurent Vivier
From: Eric Blake Make the sentence read better. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrangé Message-Id: <20181207170733.129532-1-ebl...@redhat.com> Signed-off-by: Laurent Vivier --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap

[Qemu-devel] [PULL 19/24] tests: qdev_prop_check_globals() doesn't return "all_used"

2018-12-11 Thread Eduardo Habkost
From: Marc-André Lureau Instead, it returns 1 if an error was detected, which is the case for: /qdev/properties/dynamic/global/subprocess: warning: global dynamic-prop-type-bad.prop3 has invalid class name warning: global nohotplug-type.prop5=105 not used warning: global nondevice-type.prop6 has

[Qemu-devel] [PULL 24/24] qom: remove unimplemented class_finalize

2018-12-11 Thread Eduardo Habkost
From: Marc-André Lureau Instead of trying to implement something that isn't well specified, remove it. (it would be tricky to implement, since a class struct is memcpy on children types...) Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <2

[Qemu-devel] [PULL 15/24] spapr: Use default_machine_opts to set use_hotplug_event_source

2018-12-11 Thread Eduardo Habkost
Instead of setting use_hotplug_event_source at instance_init time, set default_machine_opts on spapr_machine_2_7_class_options() to implement equivalent behavior. This will let us eliminate the need for separate instance_init functions for each spapr machine-type. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 25/30] target: hax: fix errors in comment

2018-12-11 Thread Laurent Vivier
From: Li Qiang Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1543312812-2929-1-git-send-email-liq...@gmail.com> Signed-off-by: Laurent Vivier --- target/i386/hax-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t

[Qemu-devel] [PULL 26/30] util: vfio-helpers: use ARRAY_SIZE in qemu_vfio_init_pci()

2018-12-11 Thread Laurent Vivier
From: Li Qiang Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1543571638-2892-1-git-send-email-liq...@gmail.com> Signed-off-by: Laurent Vivier --- util/vfio-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uti

[Qemu-devel] [PULL 23/24] qdev: move qdev_prop_register_global_list() to tests

2018-12-11 Thread Eduardo Habkost
From: Marc-André Lureau The function is only used by a test, move it there. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181204142023.15982-6-marcandre.lur...@redhat.com> Signed-off-by: Eduardo Hab

[Qemu-devel] [PULL 14/30] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20181125205000.10324-7-phi...@redhat.com> [lv: added the missing 'F:' field] Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5c20fed

[Qemu-devel] [PULL 13/24] q35/440fx/arm/spapr: Add QEMU 4.0 machine type

2018-12-11 Thread Eduardo Habkost
From: Alex Williamson Including all machine types that might have a pcie-root-port. Cc: Peter Maydell Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Acked-by: David Gibson Signed-off-by: Alex Williamson Message-Id: <154394083644.28

[Qemu-devel] [PULL 16/30] MAINTAINERS: Add a missing entry for the sun4m machines

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: <20181125205000.10324-10-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 581832b257

[Qemu-devel] [PULL 22/24] accel: register global_props like machine globals

2018-12-11 Thread Eduardo Habkost
From: Marc-André Lureau global_props is only used for Xen xen_compat_props. It's a static array of GlobalProperty, like machine globals in SET_MACHINE_COMPAT(). Let's register the globals the same way, without extra copy allocation. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov M

[Qemu-devel] [PULL 14/24] virt: Eliminate separate instance_init functions

2018-12-11 Thread Eduardo Habkost
All instance_init functions for all virt machine-types run exactly the same code, so we don't need separate functions. We only need to set instance_init for TYPE_VIRT_MACHINE. Signed-off-by: Eduardo Habkost Message-Id: <20181205205827.19387-2-ehabk...@redhat.com> Reviewed-by: Peter Maydell Sign

[Qemu-devel] [PULL 03/30] misc: fix spelling

2018-12-11 Thread Laurent Vivier
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier Message-Id: <20181105135400.18366-1-marcandre.lur...@redhat.com> Signed-off-by: Laurent Vivier --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/tar

[Qemu-devel] [PULL 02/30] virtio: pass argument by value for virtqueue_map_iovec()

2018-12-11 Thread Laurent Vivier
From: Dongli Zhang Pass num_sg by value instead of by pointer, as num_sg is never modified in virtqueue_map_iovec(). Signed-off-by: Dongli Zhang Reviewed-by: Paolo Bonzini Message-Id: <1541139396-4727-1-git-send-email-dongli.zh...@oracle.com> Signed-off-by: Laurent Vivier --- hw/virtio/virti

[Qemu-devel] [PULL 16/24] spapr: Use default_machine_opts to set suppress_vmdesc

2018-12-11 Thread Eduardo Habkost
Instead of setting suppress_vmdesc at instance_init time, set default_machine_opts on spapr_machine_2_2_class_options() to implement equivalent behavior. This will let us eliminate the need for separate instance_init functions for each spapr machine-type. Signed-off-by: Eduardo Habkost Message-I

[Qemu-devel] [PULL 18/24] pc: Use default_machine_opts to set suppress_vmdesc

2018-12-11 Thread Eduardo Habkost
Instead of setting suppress_vmdesc at instance_init time, set default_machine_opts on pc_i440fx_2_2_machine_options() to implement equivalent behavior. This will let us eliminate the need for pc_compat_*() functions for PC machine-types. Signed-off-by: Eduardo Habkost Message-Id: <20181205205827

[Qemu-devel] [PULL 13/30] MAINTAINERS: Add missing entries for the Jazz machine

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Markovic Message-Id: <20181125205000.10324-6-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b32cd139a7

[Qemu-devel] [PULL 11/30] MAINTAINERS: Add a missing entry to the SPARC CPU

2018-12-11 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: <20181125205000.10324-3-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 59233c2139.

[Qemu-devel] [PULL 12/24] hostmem: Validate host-nodes before setting bitmap

2018-12-11 Thread Eduardo Habkost
host_memory_backend_set_host_nodes() was not validating host-nodes before writing to backend->host_nodes, making QEMU write beyond the end of the bitmap. Fix the crash and add a simple regression test for the fix. While at it, fix memory leak of the list returned by visit_type_uint16List(). Repo

[Qemu-devel] [PULL 06/30] misc: Avoid UTF-8 in error messages

2018-12-11 Thread Laurent Vivier
From: Eric Blake While most developers are now using UTF-8 environments, it's harder to guarantee that error messages will be output to a multibyte locale. Rather than risking error messages that get corrupted into mojibake when the user runs qemu in a non-multibyte locale, let's stick to straigh

[Qemu-devel] [PULL 08/24] memory-device: avoid overflows on very huge devices

2018-12-11 Thread Eduardo Habkost
From: David Hildenbrand Should not be a problem right now, but it could theoretically happen in the future. Signed-off-by: David Hildenbrand Message-Id: <20181023152306.3123-7-da...@redhat.com> Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- hw/mem/me

[Qemu-devel] [PULL 00/30] Trivial patches

2018-12-11 Thread Laurent Vivier
The following changes since commit 32a1a94dd324d33578dca1dc96d7896a0244d768: Update version for v3.1.0 release (2018-12-11 17:18:37 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-patches-pull-request for you to fetch changes up to 82c48fb79df559

[Qemu-devel] [PULL 11/24] numa: Match struct to typedef name

2018-12-11 Thread Eduardo Habkost
From: Eric Blake There's no reason to violate our naming conventions by having a struct with a different name than its typedef. Messed up since its introduction in commit 8c85901e, but made more obvious when commit 3bfe5716 promoted it to typedefs.h. Signed-off-by: Eric Blake Message-Id: <2018

[Qemu-devel] [PULL 05/24] Deprecate HMP `cpu-add`

2018-12-11 Thread Eduardo Habkost
From: Kashyap Chamarthy Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP equivalent, too. Suggested-by: Thomas Huth Signed-off-by: Kashyap Chamarthy Message-Id: <20181030123526.26415-3-kcham...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- h

[Qemu-devel] [PULL 20/24] qom: make interface types abstract

2018-12-11 Thread Eduardo Habkost
From: Marc-André Lureau Interfaces don't have instance, let's make the interface type really abstract to avoid confusion. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <20181204142023.15982-3-marcandre.lur...@redhat.com> Signed-off-by: Ed

[Qemu-devel] [PULL 09/24] move ObjectClass to typedefs.h

2018-12-11 Thread Eduardo Habkost
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Message-Id: <20181106102335.20027-2-kra...@redhat.com> Reviewed-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- include/qemu/typedefs.h | 1 + include/qom/object.h|

[Qemu-devel] [PULL 17/24] spapr: Delete instance_options functions

2018-12-11 Thread Eduardo Habkost
Now that all instance_options functions for spapr are empty, delete them. Signed-off-by: Eduardo Habkost Message-Id: <20181205205827.19387-5-ehabk...@redhat.com> Acked-by: David Gibson Signed-off-by: Eduardo Habkost --- hw/ppc/spapr.c | 85 -- 1

[Qemu-devel] [PULL 04/24] Deprecate QMP `cpu-add`

2018-12-11 Thread Eduardo Habkost
From: Kashyap Chamarthy The intended functionality of QMP `cpu-add` is replaced with `device_add` (and `query-hotpluggable-cpus`). So let's deprecate `cpu-add`. A complete example of vCPU hotplug with the recommended way (using `device_add`) is provided as part of a seperate docs patch. Sugges

[Qemu-devel] [PULL 10/24] i386: Rename bools in PCMachineState to end in _enabled

2018-12-11 Thread Eduardo Habkost
From: Corey Minyard This makes their function more clear and prevents conflicts when adding the actual devices to the machine state, if necessary. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Message-Id: <20181107152434.22219-1-miny...@acm.org> Rev

[Qemu-devel] [PULL 00/24] Machine queue post-3.1.0 (including 4.0 machine-types)

2018-12-11 Thread Eduardo Habkost
The following changes since commit 32a1a94dd324d33578dca1dc96d7896a0244d768: Update version for v3.1.0 release (2018-12-11 17:18:37 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pull-request for you to fetch changes up to 37fdb2c56c60337

[Qemu-devel] [PULL 06/24] range: pass const pointer where possible

2018-12-11 Thread Eduardo Habkost
From: David Hildenbrand If there are no changes, let's use a const pointer. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: David Hildenbrand Message-Id: <20181023152306.3123-4-da...@redhat.com> Reviewed-by: David Gibson Signed-off-by: Eduardo Habkost --- include/qemu/range.h | 6 +++---

[Qemu-devel] [PULL 01/24] hostmem-file: remove object id from pmem error message

2018-12-11 Thread Eduardo Habkost
From: Zhang Yi We will never get the canonical path from the object before object_property_add_child. Signed-off-by: Zhang Yi Message-Id: [ehabkost: reword commit message] Signed-off-by: Eduardo Habkost --- backends/hostmem-file.c | 14 -- 1 file changed, 4 insertions(+), 10 del

[Qemu-devel] [PULL 07/24] memory-device: use QEMU_IS_ALIGNED

2018-12-11 Thread Eduardo Habkost
From: David Hildenbrand Shorter and easier to read. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: David Hildenbrand Message-Id: <20181023152306.3123-6-da...@redhat.com> Reviewed-by: David Gibson Signed-off-by: Eduardo Habkost --- hw/mem/memory-device.c | 6 +++--- 1 file changed, 3 ins

[Qemu-devel] [PULL 03/24] docs: Document vCPU hotplug procedure

2018-12-11 Thread Eduardo Habkost
From: Kashyap Chamarthy Signed-off-by: Kashyap Chamarthy Message-Id: <20181030123526.26415-4-kcham...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- docs/cpu-hotplug.rst | 142 +++ 1 file changed, 142 insertions(+) create

[Qemu-devel] [PULL 02/24] hw/timer/sun4v-rtc: Fix tracing at sun4v_rtc_write()

2018-12-11 Thread Eduardo Habkost
The code was converted to use sun4v_rtc_read() by mistake, fix it. Reported-by: David Gibson Cc: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost Message-Id: <20181031001843.12892-1-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/timer/sun4v-rtc.c | 2 +- 1 file changed, 1 ins

Re: [Qemu-devel] [RFC PATCH] contrib: add a basic gitdm config

2018-12-11 Thread Daniel P . Berrangé
On Tue, Dec 11, 2018 at 05:42:53PM +, Alex Bennée wrote: > This is a QEMU specific version of a gitdm config for generating > reports on the contributor base of the project. I've added enough > group maps and domain aliases to ensure the current top ten is as > reflective as it can be. As of th

Re: [Qemu-devel] [RFC PATCH 09/13] tests/tcg: split cris tests into system and user mode

2018-12-11 Thread Alex Bennée
Alex Bennée writes: > This will help with the make system as we build a different set of > tests for each qemu binary. Hmm actually they are all userspace tests. Perhaps the split should be bare (as in not needing libc) and libc based tests? We can only build the bare tests at the moment as th

Re: [Qemu-devel] [PATCH for-3.2 v5 08/19] hw: apply machine compat properties without touching globals

2018-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2018 at 04:52:29PM +0100, Igor Mammedov wrote: > On Tue, 11 Dec 2018 18:30:32 +0400 > Marc-André Lureau wrote: > > > Hi > > > > On Tue, Dec 11, 2018 at 6:24 PM Eduardo Habkost wrote: > > > > > > I have specific questions about the approach we are using to > > > eliminate the mac

[Qemu-devel] [RFC PATCH] contrib: add a basic gitdm config

2018-12-11 Thread Alex Bennée
This is a QEMU specific version of a gitdm config for generating reports on the contributor base of the project. I've added enough group maps and domain aliases to ensure the current top ten is as reflective as it can be. As of this commit running: git log --numstat --since "Last Year" | gitdm -

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test

2018-12-11 Thread Laurent Vivier
Le 10/12/2018 à 20:42, Richard Henderson a écrit : > On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote: >> Hi Fabrice, >> >> On Fri, Dec 7, 2018 at 5:06 PM wrote: >>> >>> As "xchg" reads and writes both operands, the "+m" is required to avoid >>> undefined behavior on -O2 compilation. >>> >>> Sign

Re: [Qemu-devel] [PATCH v4 0/3] target/arm: ARMv8.1-LOR

2018-12-11 Thread Peter Maydell
On Mon, 10 Dec 2018 at 15:05, Richard Henderson wrote: > > Changes since v3: > * Removed the extra VI/VF/VSE change. > > Changes since v2: > * Rebased on target-arm.next, which now includes 7 of the 10 patches. > * Fixes based on patch review. > Applied to target-arm.next, thanks. -- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] maint: Grammar fix to mailmap

2018-12-11 Thread Laurent Vivier
Le 07/12/2018 à 18:07, Eric Blake a écrit : > Make the sentence read better. > > Signed-off-by: Eric Blake > --- > .mailmap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.mailmap b/.mailmap > index ed8faa57192..b8e08297c90 100644 > --- a/.mailmap > +++ b/.mailmap > @@

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-11 Thread Yuval Shaia
On Tue, Dec 11, 2018 at 06:47:43PM +0200, Yuval Shaia wrote: > On Tue, Dec 11, 2018 at 06:56:41PM +0530, P J P wrote: > > From: Prasad J Pandit > > > > create_cq and create_qp routines allocate ring object, but it's > > not released in case of an error, leading to memory leakage. > > > > Reporte

Re: [Qemu-devel] [PATCH for-4.0 v7 27/27] qapi: add conditions to REPLICATION type/commands on the schema

2018-12-11 Thread Marc-André Lureau
Hi On Tue, Dec 11, 2018 at 9:15 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Add #if defined(CONFIG_REPLICATION) in generated code, and adjust the > > code accordingly. > > > > Made conditional: > > > > * xen-set-replication, query-xen-replication-status, > > xen-colo-do-che

Re: [Qemu-devel] [PATCH 5/5] pvrdma: check return value from pvrdma_idx_ring_has_ routines

2018-12-11 Thread Yuval Shaia
On Tue, Dec 11, 2018 at 06:56:42PM +0530, P J P wrote: > From: Prasad J Pandit > > pvrdma_idx_ring_has_[data/space] routines also return invalid > index PVRDMA_INVALID_IDX[=-1], if ring has no data/space. Check > return value from these routines to avoid plausible infinite loops. > > Reported-by

Re: [Qemu-devel] [PATCH v2] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Eric Blake
On 12/11/18 10:28 AM, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unnamed features as well as duplicated names. For example, the qmp "query-cpu-definitions

Re: [Qemu-devel] [PATCH for-4.0 v7 27/27] qapi: add conditions to REPLICATION type/commands on the schema

2018-12-11 Thread Markus Armbruster
Marc-André Lureau writes: > Add #if defined(CONFIG_REPLICATION) in generated code, and adjust the > code accordingly. > > Made conditional: > > * xen-set-replication, query-xen-replication-status, > xen-colo-do-checkpoint > > Before the patch, we first register the commands unconditionally in

Re: [Qemu-devel] [PATCH v1] xen_disk: fix memory leak

2018-12-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181211160224.22181-1-o...@aepfle.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181211160224.22181-1-o...@aepfle.de Subject: [Qemu-devel] [PATCH v1] xen_disk: fix memory leak Type: serie

Re: [Qemu-devel] [RFC 3/3] pvh: Boot uncompressed kernel using direct boot ABI

2018-12-11 Thread Stefano Garzarella
Hi Liam, in order to support PVH also with SeaBIOS, I'm going to work on a new option rom (like linuxboot/multiboot) that can be used in this case. I'll keep you updated on it! Cheers, Stefano On Wed, Dec 5, 2018 at 11:38 PM Liam Merwick wrote: > > These changes (along with corresponding qboot a

Re: [Qemu-devel] [PATCH for-4.0 v7 26/27] qapi: add more conditions to SPICE

2018-12-11 Thread Markus Armbruster
Marc-André Lureau writes: > Now that member can be made conditional, let's make SPICE chardev > conditional: > > * spiceport, spicevmc > > Before and after the patch for !CONFIG_SPICE, the error is the > same ('spiceport' is not a valid char driver name). > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-11 Thread Denis Plotnikov
On 07.12.2018 15:26, Kevin Wolf wrote: > Am 05.12.2018 um 13:23 hat Denis Plotnikov geschrieben: >> At the time, the "drained section" doesn't protect Block Driver State >> from the requests appearing in the vCPU threads. >> This could lead to the data loss because of request coming to >> an unex

Re: [Qemu-devel] [for-4.0 PATCH v4 4/9] qapi: Define PCIe link speed and width properties

2018-12-11 Thread Alex Williamson
On Tue, 11 Dec 2018 09:48:37 +0100 Markus Armbruster wrote: > Eric Blake writes: > > > On 12/7/18 10:41 AM, Alex Williamson wrote: > >> Create properties to be able to define speeds and widths for PCIe > >> links. The only tricky bit here is that our get and set callbacks > >> translate from

Re: [Qemu-devel] [PATCH v4 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-11 Thread Anthony PERARD
On Tue, Dec 11, 2018 at 03:57:39PM +, Paul Durrant wrote: > ...that maintains compatibility with existing Xen toolstacks. > > Xen toolstacks instantiate PV backends by simply writing information into > xenstore and expecting a backend implementation to be watching for this. > > This patch add

Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error

2018-12-11 Thread Yuval Shaia
On Tue, Dec 11, 2018 at 06:56:41PM +0530, P J P wrote: > From: Prasad J Pandit > > create_cq and create_qp routines allocate ring object, but it's > not released in case of an error, leading to memory leakage. > > Reported-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/rdma/vmw/pvrd

Re: [Qemu-devel] [PATCH 18/26] target/arm: Export aa64_va_parameters to internals.h

2018-12-11 Thread Peter Maydell
On Fri, 7 Dec 2018 at 10:37, Richard Henderson wrote: > > We need to reuse this from helper-a64.c. Provide a stub > definition for CONFIG_USER_ONLY. This matches the stub > definitions that we removed for arm_regime_tbi{0,1} before. > > Signed-off-by: Richard Henderson > --- > target/arm/inter

Re: [Qemu-devel] [PATCH v2 0/8] qcow2: encryption threads

2018-12-11 Thread Daniel P . Berrangé
On Tue, Dec 11, 2018 at 07:43:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > The series brings threads to qcow2 encryption/decryption path, > like it is already done for compression. > > v2: - multiple cipher inside QCryptoBlock instead of multiple > blocks inside qcow2, as s

[Qemu-devel] [PATCH v2 2/8] qcow2: add separate file for threaded data processing functions

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Move compression-on-threads to separate file. Encryption will be in it too. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 7 ++ block/qcow2-threads.c | 197 ++ block/qcow2.c | 169 bl

Re: [Qemu-devel] [PATCH v4 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-11 Thread Anthony PERARD
On Tue, Dec 11, 2018 at 03:57:38PM +, Paul Durrant wrote: > ...and wire in the dataplane. > > This patch adds the remaining code to make the xen-block XenDevice > functional. The parameters that a block frontend expects to find are > populated in the backend xenstore area, and the 'ring-ref' a

[Qemu-devel] [PATCH v2 7/8] qcow2: bdrv_co_pwritev: move encryption code out of the lock

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Encryption will be done in threads, to take benefit of it, we should move it out of the lock first. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.

[Qemu-devel] [PATCH v2 1/8] qcow2.h: add missing include

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
qcow2.h depends on block_int.h. Compilation isn't broken currently only due to block_int.h always included before qcow2.h. Though, it seems better to directly include block_int.h in qcow2.h. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2018 at 02:40:33PM -0200, Wainer dos Santos Moschetta wrote: [...] > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > > index f81d35e1f9..2502a3adda 100644 > > > --- a/target/i386/cpu.c > > > +++ b/target/i386/cpu.c > > > @@ -3615,19 +3615,29 @@ static void > > > x86_cpu_

[Qemu-devel] [PATCH v2 0/8] qcow2: encryption threads

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Hi all! The series brings threads to qcow2 encryption/decryption path, like it is already done for compression. v2: - multiple cipher inside QCryptoBlock instead of multiple blocks inside qcow2, as suggested by Daniel, and it is done in separate series - use threaded encryption in

Re: [Qemu-devel] [PATCH 17/26] target/arm: Reuse aa64_va_parameters for setting tbflags

2018-12-11 Thread Peter Maydell
On Fri, 7 Dec 2018 at 10:37, Richard Henderson wrote: > > The arm_regime_tbi{0,1} functions are replacable with the new function > by giving the lowest and highest address. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h| 35 - > target/arm/helper.c

[Qemu-devel] [PATCH v2 5/8] qcow2: qcow2_co_preadv: improve locking

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Background: decryption will be done in threads, to take benefit of it, we should move it out of the lock first. But let's go further: it turns out, that for locking around switch cases we have only two variants: when we just do memset(0) not releasing the lock (it is useless) and when we actually

Re: [Qemu-devel] [PATCH 16/26] target/arm: Create ARMVAParameters and helpers

2018-12-11 Thread Peter Maydell
On Fri, 7 Dec 2018 at 10:37, Richard Henderson wrote: > > Split out functions to extract the virtual address parameters. > Let the functions choose T0 or T1 address space half, if present. > Extract (most of) the control bits that vary between EL or Tx. > > Signed-off-by: Richard Henderson > ---

Re: [Qemu-devel] [PATCH v7 18/19] spapr: add a 'pseries-4.0-xive' machine type

2018-12-11 Thread Cédric Le Goater
On 12/11/18 11:42 AM, Cédric Le Goater wrote: > On 12/11/18 3:06 AM, David Gibson wrote: >> On Mon, Dec 10, 2018 at 11:17:33PM +0100, Cédric Le Goater wrote: >>> On 12/9/18 8:46 PM, Cédric Le Goater wrote: This pseries machine makes use of a new sPAPR IRQ backend supporting the XIVE inter

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/3] s390: cpu feature for diagnose 318 andlimit max VCPUs to 247

2018-12-11 Thread Collin Walling
On 12/7/18 7:08 AM, Cornelia Huck wrote: > On Thu, 6 Dec 2018 17:24:17 -0500 > Collin Walling wrote: > >> Diagnose 318 is a new z14.2 CPU feature. Since we are able to emulate >> it entirely via KVM, we can add guest support for earlier models. A >> new CPU feature for diagnose 318 (shortened to

[Qemu-devel] [PATCH v2 6/8] qcow2: qcow2_co_preadv: skip using hd_qiov when possible

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
qemu_iovec_memset has @offset parameter, so using hd_qiov for it is not needed. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 2a49314e42..4e217ee918 100644 --- a/b

[Qemu-devel] [PATCH v2 3/8] qcow2-threads: use thread_pool_submit_co

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Use thread_pool_submit_co, instead of reinventing it here. Note, that thread_pool_submit_aio() never returns an error, so checking it was an extra thing. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-threads.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-)

[Qemu-devel] [PATCH v2 8/8] qcow2: do encryption in threads

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Do encryption/decryption in threads, like it is already done for compression. This improves asynchronous encrypted io. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 8 ++ block/qcow2-cluster.c | 7 ++--- block/qcow2-threads.c | 65 +

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Wainer dos Santos Moschetta
On 12/10/2018 02:46 PM, Eduardo Habkost wrote: On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as w

[Qemu-devel] [PATCH v2 3/4] hw/smbios: Remove "smbios_ipmi.h"

2018-12-11 Thread Philippe Mathieu-Daudé
This header only declare a single function: smbios_build_type_38_table(). We already have a header that declares such functions: "smbios_build.h". Move the declaration and remove the header. Reviewed-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Signed-off-by: Phil

[Qemu-devel] [PATCH v2 4/8] qcow2-threads: split out generic path

2018-12-11 Thread Vladimir Sementsov-Ogievskiy
Move generic part out of qcow2_co_do_compress, to reuse it for encryption and rename things that would be shared with encryption path. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 4 ++-- block/qcow2-threads.c | 39 +++ block/qcow2.

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu 2/3] ppc/spapr: Receive and store device tree blob from SLOF

2018-12-11 Thread Greg Kurz
On Tue, 11 Dec 2018 16:49:25 +1100 Alexey Kardashevskiy wrote: > SLOF receives a device tree and updates it with various properties > before switching to the guest kernel and QEMU is not aware of any changes > made by SLOF. Since there is no real RTAS (QEMU implements it), it makes > sense to pas

[Qemu-devel] [PATCH v2 2/4] hw/smbios: Restrict access to "hw/smbios/ipmi.h"

2018-12-11 Thread Philippe Mathieu-Daudé
All the consumers of "hw/smbios/ipmi.h" are located in hw/smbios/. There is no need to have this include publicly exposed, reduce the visibility by moving it in hw/smbios/. Reviewed-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c

[Qemu-devel] [PATCH v2 1/4] tests: Remove unused include

2018-12-11 Thread Philippe Mathieu-Daudé
The "hw/smbios/smbios.h" include is not used, remove it. Reviewed-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- tests/acpi-utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c index 41dc1ea9b4..297af55d3

[Qemu-devel] [PATCH v2 4/4] hw/smbios: Move to the hw/firmware/ subdirectory

2018-12-11 Thread Philippe Mathieu-Daudé
SMBIOS is just another firmware interface used by some QEMU models. We will later introduce more firmware interfaces in this subdirectory. Reviewed-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/arm

Re: [Qemu-devel] [PATCH v2 3/3] fw_cfg: make qemu_extra_params_fw locally

2018-12-11 Thread Philippe Mathieu-Daudé
Hi Li, On 11/21/18 6:10 AM, Li Qiang wrote: > qemu_extra_params_fw[] has external linkage, but is used > only in fw_cfg_bootsplash(), it makes sense to make it > locally. > > Signed-off-by: Li Qiang > Reviewed-by: Markus Armbruster > --- > hw/nvram/fw_cfg.c | 1 + > include/sysemu/sysemu

[Qemu-devel] [PATCH v2 0/4] Introduce the hw/firmware/ namespace

2018-12-11 Thread Philippe Mathieu-Daudé
Hi, QEMU interacts with various firmwares. We already have some helpers for some firmwares. Later we will add UEFI helpers. This series introduce the hw/firmware namespace for this. There is no need to move hw/smbios sources into a specific directory, we only focus on the headers. Since v1 https

[Qemu-devel] [PATCH v2 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-11 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- Notes: v2: call directly trace_scsi_disk_new_request(), don't pass it in the arguments hw/scsi/scsi-disk.c | 103 +-- hw/scsi/trace-even

[Qemu-devel] [PATCH v2 2/2] scsi-generic: Convert from DPRINTF() macro to trace events

2018-12-11 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-generic.c | 56 -- hw/scsi/trace-events | 11 + 2 files changed, 37 insertions(+), 30 deletions(-) diff --git a/hw/scsi/scsi-ge

Re: [Qemu-devel] [PATCH v2 2/3] fw_cfg: fix -boot reboot-timeout error checking

2018-12-11 Thread Philippe Mathieu-Daudé
On 11/21/18 6:10 AM, Li Qiang wrote: > fw_cfg_reboot() gets option parameter "reboot-timeout" with > qemu_opt_get(), then converts it to an integer by hand. It neglects to > check that conversion for errors, and fails to reject negative values. > Positive values above the limit get reported and rep

[Qemu-devel] [PATCH] target-i386: Reenable RDTSCP support on Opteron_G[345] CPU models

2018-12-11 Thread Borislav Petkov via Qemu-devel
+ qemu-devel. On Tue, Dec 11, 2018 at 03:30:17PM +, Daniel P. Berrangé wrote: > Great, then, this is a non-issue - we just need to mention that fact > in the commit that sets the min version for the kernel Ok, here's a first draft ontop of Eduardo's machine-next branch from http://github.com/

[Qemu-devel] [PATCH v2 0/2] scsi: Convert from DPRINTF() macro to trace events

2018-12-11 Thread Laurent Vivier
Convert the last two files in hw/scsi. v2: call directly trace_scsi_disk_new_request(), don't pass it in the argument Laurent Vivier (2): scsi-disk: Convert from DPRINTF() macro to trace events scsi-generic: Convert from DPRINTF() macro to trace events hw/scsi/scsi-disk.c| 103 +

[Qemu-devel] [PATCH v2] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Wainer dos Santos Moschetta
The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unnamed features as well as duplicated names. For example, the qmp "query-cpu-definitions" below shows one empty string and repeated "mpx" entries:

Re: [Qemu-devel] [PATCH v3 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-11 Thread Anthony PERARD
On Tue, Dec 11, 2018 at 10:47:14AM +, Paul Durrant wrote: > ...and wire in the dataplane. > > This patch adds the remaining code to make the xen-block XenDevice > functional. The parameters that a block frontend expects to find are > populated in the backend xenstore area, and the 'ring-ref' a

Re: [Qemu-devel] [PATCH for-4.0 v7 22/27] qapi: add 'If:' condition to enum values documentation

2018-12-11 Thread Marc-André Lureau
Hi On Tue, Dec 11, 2018 at 8:00 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Use a common function to generate the "If:..." line. > > > > While at it, get rid of the existing \n\n (no idea why it was > > there). Use a line-break in member description, this seems to look > > sl

Re: [Qemu-devel] [Xen-devel] memory leak in block/xen_disk in qemu-3.x

2018-12-11 Thread Olaf Hering
On Tue, Dec 11, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > Of Olaf Hering > > Sent: 11 December 2018 15:31 > > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > > Subject: [Xen-devel] memory leak in

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu 1/3] configure/fdt: Use more strict test for libfdt version

2018-12-11 Thread Greg Kurz
On Tue, 11 Dec 2018 16:49:24 +1100 Alexey Kardashevskiy wrote: > The libfdt installed in the system is preferred to the dtc submodule by > default. The recent libfdt update added a new symbol - fdt_check_full - > and this breaks compile if there is an older libfdt installed in > the system. > >

<    1   2   3   4   >