[Qemu-devel] Passing NFS volume on host to win7 guest

2018-12-29 Thread liebrecht
Hope I dont have to use samba for this. From reading online searches, it seems the following could work where backup is the nfs exported volume to be shared. -virtfs local,path=/backup,mount_tag=host0,security_model=passthrough,id=host0 qemu boots into win7 with this string added so it

[Qemu-devel] Patchew down?

2018-12-29 Thread Philippe Mathieu-Daudé
Hi, I think patchew is having some trouble since at least 1 week: new series aren't added. Regards, Phil.

Re: [Qemu-devel] [PATCH v4 5/5] migration: Use strnlen() for fixed-size string

2018-12-29 Thread Richard Henderson
On 12/29/18 4:33 AM, Philippe Mathieu-Daudé wrote: > GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow > by string-modifying functions declared in , such strncpy(), > used in global_state_store_running(). > > GCC indeed found an incorrect use of strlen(), because this array >

Re: [Qemu-devel] [PATCH v4 1/5] qemu/compiler: Define QEMU_NONSTRING

2018-12-29 Thread Richard Henderson
On 12/29/18 4:33 AM, Philippe Mathieu-Daudé wrote: > GCC 8 introduced the -Wstringop-truncation checker to detect truncation by > the strncat and strncpy functions (closely related to -Wstringop-overflow, > which detect buffer overflow by string-modifying functions declared in > ). > > In tandem

Re: [Qemu-devel] [PATCH 4/5 v2] RISC-V: Add debug support for accessing CSRs.

2018-12-29 Thread Richard Henderson
On 12/29/18 9:10 AM, Jim Wilson wrote: > Adds a debugger parameter to csr_read_helper and csr_write_helper. When > this is true, we disable illegal instruction checks. > > Signed-off-by: Jim Wilson > --- > linux-user/riscv/signal.c | 5 ++- > target/riscv/cpu.h| 7 +++- >

Re: [Qemu-devel] [PATCH 1/5 v2] RISC-V: Add 32-bit gdb xml files.

2018-12-29 Thread Richard Henderson
On 12/29/18 9:07 AM, Jim Wilson wrote: > Signed-off-by: Jim Wilson > --- > configure | 1 + > gdb-xml/riscv-32bit-cpu.xml | 43 > gdb-xml/riscv-32bit-csr.xml | 250 > > gdb-xml/riscv-32bit-fpu.xml | 46 > 4

Re: [Qemu-devel] [PATCH 3/5 v2] RISC-V: Map gdb CSR reg numbers to hw reg numbers.

2018-12-29 Thread Richard Henderson
On 12/29/18 9:09 AM, Jim Wilson wrote: > +++ b/target/riscv/csr-map.h > @@ -0,0 +1,248 @@ > +/* > + * The GDB CSR xml files list them in documentation order, not numerical > order, > + * and are missing entries for unnamed CSRs. So we need to map the gdb > numbers > + * to the hardware numbers.

Re: [Qemu-devel] [PATCH v2 8/8] target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in int_helper.c

2018-12-29 Thread Richard Henderson
On 12/29/18 12:52 AM, Mark Cave-Ayland wrote: > Following on from the previous work, there are numerous endian-related hacks > in int_helper.c that can now be replaced with Vsr* macros. > > There are also a few places where the VECTOR_FOR_INORDER_I macro can be > replaced with a normal iterator

Re: [Qemu-devel] [PATCH v2 7/8] target/ppc: remove ROTRu32 and ROTRu64 macros from int_helper.c

2018-12-29 Thread Richard Henderson
On 12/29/18 12:52 AM, Mark Cave-Ayland wrote: > Richard points out that these macros suffer from a -fsanitize=shift bug in > that > they improperly handle n == 0 turning it into a shift by 32/64 respectively. > Replace them with QEMU's existing ror32() and ror64() functions instead. > >

Re: [Qemu-devel] [PATCH v2 6/8] target/ppc: simplify VEXT_SIGNED macro in int_helper.c

2018-12-29 Thread Richard Henderson
On 12/29/18 12:52 AM, Mark Cave-Ayland wrote: > As pointed out by Richard: it does not need the mask argument, nor does it > need > the recast argument. The masking is implied by the cast argument, and the > recast is implied by the assignment. > > Signed-off-by: Mark Cave-Ayland > --- >

Re: [Qemu-devel] AVX support for TCG

2018-12-29 Thread Richard Henderson
On 12/29/18 12:43 AM, Nick Renieris wrote: >>> Do you think this could work as a GSoC project? I'm potentially >>> interested in working on it this summer. > >> Could be. My first guess is something like 4 months work for this. > > Four months full-time? If so I would say it's not viable for a

[Qemu-devel] [Bug 1810000] Re: qemu system emulator crashed with the attachment of usb-bt-dongle device

2018-12-29 Thread PH
** Description changed: -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/181 Title: qemu system emulator crashed with the attachment of usb-bt-dongle device Status in QEMU: New Bug

Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation

2018-12-29 Thread Andy Lutomirski
> On Dec 28, 2018, at 6:54 PM, Matthew Wilcox wrote: > >> On Sat, Dec 29, 2018 at 12:12:27AM +, Peter Maydell wrote: >> On Fri, 28 Dec 2018 at 23:16, Andreas Dilger wrot >>> On Dec 28, 2018, at 4:18 AM, Peter Maydell wrote: The problem is that there is no 32-bit API in some cases

Re: [Qemu-devel] [PATCH 2/4] Add CET SHSTK and IBT CPUID feature-word definitions.

2018-12-29 Thread Yang Weijiang
On Fri, Dec 28, 2018 at 03:25:10PM +0100, Paolo Bonzini wrote: Thanks a lot Paolo for the comments! I'll fix the issue in next version. > On 26/12/18 09:25, Yang Weijiang wrote: > > @@ -1233,6 +1252,14 @@ static const ExtSaveArea x86_ext_save_areas[] = { > >{ .feature = FEAT_7_0_ECX,

[Qemu-devel] [PATCH v5 01/11] block/backup: simplify backup_incremental_init_copy_bitmap

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Simplify backup_incremental_init_copy_bitmap using the function bdrv_dirty_bitmap_next_dirty_area. Note: move to job->len instead of bitmap size: it should not matter but less code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 40 1

[Qemu-devel] [PATCH v5 04/11] iotests: handle -f argument correctly for qemu_io_silent

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Correctly rewrite default argument. After the patch, the function can be used for other (not only default test-chosen) image format. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v5 03/11] block: improve should_update_child

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
As it already said in the comment, we don't want to create loops in parent->child relations. So, when we try to append @to to @c, we should check that @c is not in @to children subtree, and we should check it recursively, not only the first level. The patch provides BFS-based search, to check the

[Qemu-devel] [PATCH v5 05/11] iotests: allow resume_drive by node name

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
After node graph changes, we may not be able to resume_drive by device name (backing files are not recursively searched). So, lets allow to resume by node-name. Set constant name for breakpoints, to avoid introducing extra parameters. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH v5 08/11] block/io: refactor wait_serialising_requests

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Split out do_wait_serialising_requests with additional possibility to not actually wait but just check, that there is something to wait for. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v5 09/11] block: add lock/unlock range functions

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Introduce lock/unlock range functionality, based on serialized requests. This is needed to refactor backup, dropping local tracked-request-like synchronization. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 4 block/io.c

[Qemu-devel] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Drop write notifiers and use filter node instead. Changes: 1. copy-before-writes now handled by filter node, so, drop all is_write_notifier arguments. 2. we don't have intersecting requests, so their handling is dropped. Instead, synchronization works as follows: when backup or backup-top

[Qemu-devel] [PATCH v5 06/11] iotests: prepare 055 to graph changes during backup job

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Backup will append fleecing-hook node above source node, so, we can't resume by device name (because resume don't search recursively through backing chain). Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/055 | 23 +-- 1 file changed, 13 insertions(+), 10

[Qemu-devel] [PATCH v5 02/11] block/backup: move to copy_bitmap with granularity

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
We are going to share this bitmap between backup and backup-top filter driver, so let's share something more meaningful. It also simplifies some calculations. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 48 +++- 1 file changed, 23

[Qemu-devel] [PATCH v5 10/11] block/backup: tiny refactor backup_job_create

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Move copy-bitmap find/create code. It's needed for the following commit, as we'll need copy_bitmap before actual block job creation. Do it in a separate commit to simplify review. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 69

[Qemu-devel] [PATCH v5 00/11] backup-top filter driver for backup

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Hi all! These series introduce backup-top driver. It's a filter-node, which do copy-before-write operation. Mirror uses filter-node for handling guest writes, let's move to filter-node (from write-notifiers) for backup too v5: Now, based on John's bitmaps branch patch "block: allow serialized

[Qemu-devel] [PATCH v5 07/11] block: introduce backup-top filter driver

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Backup-top filter does copy-before-write operation. It should be inserted above active disk and has a target node for CBW, like the following: +---+ | Guest | +---+---+ |r,w v +---+---+ target +---+ | backup_top|-->|

[Qemu-devel] ping3 Re: [PATCH v4 00/10] NBD reconnect

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
ping 31.07.2018 20:30, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of

[Qemu-devel] [PATCH] chardev: Allow for pty path passing.

2018-12-29 Thread Paulo Neves
If a user requires a virtual serial device like provided by the pty char device, the user needs to accept the returned device name. This makes the program need to have smarts to parse or communicate with qemu to get the pty device. With this patch the program can pass the path where a symlink to

[Qemu-devel] [PATCH] chardev: Allow for pty path passing.

2018-12-29 Thread Paulo Neves
Hello all. I am trying to get qemu to spawn a pty terminal in a location which I control without needing to retrieve information of the PTY device a-posteriori from qemu. To this end i inspired myself in the functionality of socat, which allows PTY terminals to be spawned in a location specified

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-12-29 Thread Hongbo Zhang
well, checked it again, creating an generic xhci may take much efforts and it is far beyond than my main task of creating an arm server platform, so I'll create a generic system ehci, it satisfies our requirements very well, will send it out separately. On Wed, 21 Nov 2018 at 16:35, Hongbo Zhang

[Qemu-devel] [PATCH] hw/usb: Add generic sys-bus EHCI controller

2018-12-29 Thread Hongbo Zhang
This patch introduces a new system bus generic EHCI controller. For the system bus EHCI controller, we've already had "xlnx", "exynos4210", "tegra2", "ppc4xx" and "fusbh200", they are specific and only suitable for their own platforms, platforms such as an Arm server, may need a generic system bus