Re: [Qemu-devel] [PATCH] spice: Remove unused include

2019-01-09 Thread Gerd Hoffmann
On Mon, Jan 07, 2019 at 06:44:04PM +, Frediano Ziglio wrote: > The definitions in the header are not used. > Also this fixes porting SPICE to Windows where the header is not > available. Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation

2019-01-09 Thread Gerd Hoffmann
Hi, > I was thinking about creating an Audiodev (the qapi type) directly would > be better, then somehow print it with reflection. While this is not a > typical use of qapi, at least qmp_qom_list creates qapi objects > directly, so I assume it's ok. Yes, it's perfectly fine. > The second

[Qemu-devel] [PATCH v2 3/6] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-09 Thread Eric Blake
With the experimental x-nbd-server-add-bitmap command, there was a window of time where an NBD client could see the export but not the associated dirty bitmap, which can cause a client that planned on using the dirty bitmap to be forced to treat the entire image as dirty as a safety fallback.

[Qemu-devel] [PATCH v2 1/6] nbd: Only require disabled bitmap for read-only exports

2019-01-09 Thread Eric Blake
Our initial implementation of x-nbd-server-add-bitmap put in a restriction because of incremental backups: in that usage, we are exporting one qcow2 file (the temporary overlay target of a blockdev-backup sync:none job) and a dirty bitmap owned by a second qcow2 file (the source of the

[Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-09 Thread Eric Blake
The existing NBD code had a weird split where nbd_export_new() created an export but did not add it to the list of exported names until a later nbd_export_set_name() came along and grabbed a second reference on the object; later, nbd_export_close() drops the second reference. But since we never

[Qemu-devel] [PATCH v2 4/6] nbd: Remove x-nbd-server-add-bitmap

2019-01-09 Thread Eric Blake
Now that nbd-server-add can do the same functionality, we no longer need the experimental separate command. Signed-off-by: Eric Blake --- qapi/block.json | 23 --- blockdev-nbd.c | 23 --- 2 files changed, 46 deletions(-) diff --git a/qapi/block.json

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2019-01-09 Thread Eric Blake
On 1/9/19 1:21 PM, Eric Blake wrote: > Revisiting an older thread: > > On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> Handle new NBD meta namespace: "qemu", and corresponding queries: >> "qemu:dirty-bitmap:". >> >> With new metadata context negotiated, BLOCK_STATUS query will reply >>

[Qemu-devel] [PATCH v2 5/6] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-01-09 Thread Eric Blake
We only have one caller that wants to export a bitmap name, which it does right after creation of the export. But there is still a brief window of time where an NBD client could see the export but not the dirty bitmap, which a robust client would have to interpret as meaning the entire image

[Qemu-devel] [PATCH v2 0/6] Promote x-nbd-server-add-bitmap to stable

2019-01-09 Thread Eric Blake
Or rather, move its functionality into nbd-server-add. And as a side effect, teach qemu-nbd how to export a persistent bitmap without having to go through a qemu process and several QMP commands. Based-on: <20181221093529.23855-1-js...@redhat.com> [0/11 bitmaps: remove x- prefix from QMP api]

[Qemu-devel] [PATCH v2 6/6] qemu-nbd: Add --bitmap=NAME option

2019-01-09 Thread Eric Blake
Having to fire up qemu, then use QMP commands for nbd-server-start and nbd-server-add, just to expose a persistent dirty bitmap, is rather tedious. Make it possible to expose a dirty bitmap using just qemu-nbd (of course, for now this only works when qemu-nbd is visiting a BDS formatted as

Re: [Qemu-devel] [PATCH] target-i386: hvf: remove MPX support

2019-01-09 Thread Roman Bolshakov
On Thu, Dec 20, 2018 at 01:11:12PM +0100, Paolo Bonzini wrote: > MPX support is being phased out by Intel and actually I am not sure that > OS X has ever enabled it in XCR0. Drop it from the Hypervisor.framework > acceleration. > I also doubt if OS X enabled it, but I can't confirm that as I

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-09 Thread Rik van Riel
On Thu, 2019-01-10 at 12:26 +1100, Dave Chinner wrote: > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > This patch series has implementation for "virtio pmem". > > "virtio pmem" is fake persistent memory(nvdimm) in guest > > which allows to bypass the guest page cache. This

Re: [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 22:26, Paolo Bonzini wrote: > On 09/01/19 19:10, Philippe Mathieu-Daudé wrote: >> Using '-std=gnu++98' for g++ v4.8 looks like a good compromise to the >> issues Daniel mentioned (still 'experimental'). >> >> Reviewed-by: Philippe Mathieu-Daudé > > C++11 has many new features that

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 18:47, Greg Kurz wrote: > On Wed, 9 Jan 2019 18:40:48 +0100 > Cédric Le Goater wrote: > >> On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: >>> On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: On 1/9/19 5:39 PM, Thomas Huth wrote: > When compiling with

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 22:20, Paolo Bonzini wrote: > On 09/01/19 18:28, Daniel P. Berrangé wrote: >>> so both files include each other, how nice ... >> If the header files are mutually dependent it makes me wonder what the >> point of having them split up is ? >> >> Feels like either they need to be

Re: [Qemu-devel] [PATCH] target/arm: Allow to switch from MON->HYP on AArch32

2019-01-09 Thread Alexander Graf
On 10.01.19 00:08, Peter Maydell wrote: > On Wed, 9 Jan 2019 at 17:14, Alexander Graf wrote: >> >> On 01/09/2019 05:59 PM, Peter Maydell wrote: >>> On Wed, 9 Jan 2019 at 16:52, Peter Maydell wrote: On Wed, 9 Jan 2019 at 15:26, Alexander Graf wrote: > In U-boot, we switch from S-SVC

Re: [Qemu-devel] [PATCH 2/5] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-09 Thread Eric Blake
On 1/8/19 10:14 PM, Eric Blake wrote: > With the experimental x-nbd-server-add-bitmap command, there was > a window of time where a client could see the export but not the > associated dirty bitmap, which can cause a client that planned > on using the dirty bitmap to be forced to treat the entire

Re: [Qemu-devel] [PATCH] vfio/common: Work around kernel overflow bug in DMA unmap

2019-01-09 Thread Peter Xu
On Wed, Jan 09, 2019 at 04:10:51PM -0700, Alex Williamson wrote: > A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which > adds a test for address space wrap-around in the vfio DMA unmap path. > Unfortunately due to overflow, the kernel detects an unmap of the last > page in the

Re: [Qemu-devel] [PATCH] ppc/xive: fix remaining XiveFabric names

2019-01-09 Thread David Gibson
On Wed, Jan 09, 2019 at 04:15:32PM +0100, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > include/hw/ppc/xive.h | 2 +- > hw/intc/xive.c| 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/hw/ppc/xive.h

Re: [Qemu-devel] [PATCH 3/4] nvme: check msix_init_exclusive_bar return value

2019-01-09 Thread Li Qiang
Max Reitz 于2019年1月9日周三 下午10:52写道: > On 30.10.18 06:18, Li Qiang wrote: > > As this function can fail. > > > > Signed-off-by: Li Qiang > > --- > > hw/block/nvme.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > index

Re: [Qemu-devel] [PATCH 2/4] nvme: ensure the num_queues is not zero

2019-01-09 Thread Li Qiang
Max Reitz 于2019年1月9日周三 下午10:38写道: > On 30.10.18 06:18, Li Qiang wrote: > > When it is zero, it causes segv. Backtrack: > > Thread 5 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > > [Switching to Thread 0x7fffc6c17700 (LWP 51808)] > > 0x55acbd90 in nvme_start_ctrl

Re: [Qemu-devel] [PATCH v2 03/52] qapi: qapi for audio backends

2019-01-09 Thread Eric Blake
On 12/23/18 2:51 PM, Kővágó, Zoltán wrote: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables based config).

Re: [Qemu-devel] [PATCH v2 1/3] qom: Don't keep error value between object_property_parse() calls

2019-01-09 Thread Eric Blake
On 1/9/19 8:02 PM, Eduardo Habkost wrote: > When handling errp==NULL at object_apply_global_props(), we are > leaving the old error value in `err` after printing a warning. > This makes QEMU crash if two global properties generate warnings: > > $ echo device_add rtl8139 | qemu-system-x86_64

[Qemu-devel] [PATCH v2 2/3] globals: Allow global properties to be optional

2019-01-09 Thread Eduardo Habkost
Making some global properties optional will let us simplify compat code when a given property works on most (but not all) subclasses of a given type. Device types will be able to opt out from optional compat properties by simply not registering those properties, or by making the property setter

[Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-09 Thread Eduardo Habkost
The disable-legacy and disable-modern properties apply only to some virtio-pci devices. Make those properties optional. This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide version-specific variants of virtio PCI devices"): $ qemu-system-x86_64 -machine pc-i440fx-2.6 \

[Qemu-devel] [PATCH v2 1/3] qom: Don't keep error value between object_property_parse() calls

2019-01-09 Thread Eduardo Habkost
When handling errp==NULL at object_apply_global_props(), we are leaving the old error value in `err` after printing a warning. This makes QEMU crash if two global properties generate warnings: $ echo device_add rtl8139 | qemu-system-x86_64 -monitor stdio -global rtl8139.xxx=yyy -global

[Qemu-devel] [PATCH v2 0/3] Fix virtio-*(-non)-transitional crash on 2.6 machine-types

2019-01-09 Thread Eduardo Habkost
This is a second attempt to fix the crash reported by Thomas[1]. This keeps the compat property array simple, different from my first attempt[2]. This also avoids extra complexity on the device code: we don't need interface name, inheritance tricks, or devices overriding a compat property after

Re: [Qemu-devel] [PATCH v2 43/52] audio: add mixeng option (documentation)

2019-01-09 Thread Eric Blake
On 12/23/18 2:52 PM, Kővágó, Zoltán wrote: > This will allow us to disable mixeng when we use a decent backend. > > Disabling mixeng have a few advantages: > * we no longer convert the audio output from one format to another, when > the underlying audio system would just convert it to a third

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-09 Thread Dave Chinner
On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > This patch series has implementation for "virtio pmem". > "virtio pmem" is fake persistent memory(nvdimm) in guest > which allows to bypass the guest page cache. This also > implements a VIRTIO based asynchronous flush

Re: [Qemu-devel] [PATCH] vfio: assign idstr for VFIO's mmaped regions for migration

2019-01-09 Thread Zhao Yan
On Tue, Jan 08, 2019 at 10:09:11AM -0700, Alex Williamson wrote: > On Tue, 8 Jan 2019 01:03:48 -0500 > Zhao Yan wrote: > > > if multiple regions in vfio are mmaped, their corresponding ramblocks > > are like below, i.e. their idstrs are "". > > > > (qemu) info ramblock > > Block Name PSize

Re: [Qemu-devel] [SPDK] Qemu migration with vhost-user-blk on top of local storage

2019-01-09 Thread wuzhouhui
> -Original Messages- > From: "Wodkowski, PawelX" > Sent Time: 2019-01-10 00:19:48 (Thursday) > To: "stefa...@gmail.com" , "s...@lists.01.org" > > Cc: "libvir-l...@redhat.com" , "xieyon...@baidu.com" > , "qemu-devel@nongnu.org" , > "lili...@baidu.com" > Subject: Re: [SPDK]

Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

2019-01-09 Thread Eduardo Habkost
On Tue, Jan 08, 2019 at 11:20:12AM +0100, Cornelia Huck wrote: > On Tue, 8 Jan 2019 07:45:43 +0100 > Gerd Hoffmann wrote: > > > Hi, > > > > > +{ "migration", "decompress-error-check", "off" }, > > > +{ "hda-audio", "use-timer", "false" }, > > > +{ "cirrus-vga", "global-vmstate",

Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation

2019-01-09 Thread Zoltán Kővágó
On 2019-01-08 04:42, Markus Armbruster wrote: > "Zoltán Kővágó" writes: > >> On 2019-01-07 14:13, Markus Armbruster wrote: >>> "Kővágó, Zoltán" writes: >>> Audio drivers now get an Audiodev * as config paramters, instead of the global audio_option structs. There is some code in

[Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines

2019-01-09 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/riscv32-softmmu.mak | 1 + default-configs/riscv64-softmmu.mak | 1 + 2 files changed, 2 insertions(+) diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak index dbc9398284..c9c5971409 100644 ---

Re: [Qemu-devel] [PULL 00/29] ppc-for-4.0 queue 20190109

2019-01-09 Thread Peter Maydell
are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20190109 > > for you to fetch changes up to 3a8eb78e6c135422017888380db091793039b6dd: > > spapr: enable XIVE MMIOs at reset (2019-01-09 09:28:14 +1100) > >

Re: [Qemu-devel] [PATCH QEMU v5] hw/arm/sysbus-fdt: Add support for instantiating generic devices

2019-01-09 Thread Peter Maydell
So I should start out upfront by saying that I'm aware that the reality is that people do want to do passthrough with this kind of hardware, and that's not an unreasonable thing to do. I just don't really like the way that pushes the software into having to do ugly things... Overall I'll let Eric

[Qemu-devel] [PATCH] vfio/common: Work around kernel overflow bug in DMA unmap

2019-01-09 Thread Alex Williamson
A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which adds a test for address space wrap-around in the vfio DMA unmap path. Unfortunately due to overflow, the kernel detects an unmap of the last page in the 64-bit address space as a wrap-around. In QEMU, a Q35 guest with VT-d

Re: [Qemu-devel] [PATCH] target/arm: Allow to switch from MON->HYP on AArch32

2019-01-09 Thread Peter Maydell
On Wed, 9 Jan 2019 at 17:14, Alexander Graf wrote: > > On 01/09/2019 05:59 PM, Peter Maydell wrote: > > On Wed, 9 Jan 2019 at 16:52, Peter Maydell wrote: > >> On Wed, 9 Jan 2019 at 15:26, Alexander Graf wrote: > >>> In U-boot, we switch from S-SVC -> MON -> HYP when we want to enter > >>> HYP

Re: [Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-09 Thread David Kozub
On Mon, 7 Jan 2019, Stefan Hajnoczi wrote: QEMU supports LUKS encrypted disk images so no new code is needed for the actual encryption. Thanks for the feedback, Stefan. I know very little about qemu internals (I looked around a bit). One issue is: OPAL needs some persistent data outside of

[Qemu-devel] [PATCH] ppc440: Avoid reporting error when reading non-existent RAM slot

2019-01-09 Thread BALATON Zoltan
When reading base register of RAM slot with no RAM we should not try to calculate register value because that will result printing an error due to invalid RAM size. Just return 0 without the error in this case. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 6 -- 1 file changed, 4

Re: [Qemu-devel] [PATCH v1 0/3] gitdm updates

2019-01-09 Thread Aleksandar Markovic
On Tuesday, January 8, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Monday, January 7, 2019, Alex Bennée wrote: > >> >> Hi, >> >> Added a few more updates mostly of IBMers with non corporate emails. > > > Hi, Alex, could you please add > > leon.al...@imgtec.com > > to

Re: [Qemu-devel] [PATCH v1 1/3] contrib/gitdm: add Nokia and Proxmox to the domain-map

2019-01-09 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > contrib/gitdm/domain-map | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map > index 8cbbcfe93d..0ab41ee27a 100644 > --- a/contrib/gitdm/domain-map >

Re: [Qemu-devel] [PATCH v1 2/3] contrib/gitdm: Add other IBMers

2019-01-09 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > From: Joel Stanley > > Here are some IBMers who use their personal addresses when submitting > patches. > > Signed-off-by: Joel Stanley > Acked-by: Andrew Jeffery > Signed-off-by: Alex Bennée > --- > contrib/gitdm/group-map-ibm | 5 + > 1

Re: [Qemu-devel] [PATCH v1 3/3] contrib/gitdm: add two more IBM'ers to group-map-ibm

2019-01-09 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > contrib/gitdm/group-map-ibm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/gitdm/group-map-ibm b/contrib/gitdm/group-map-ibm > index 6c0570107d..22727319b3 100644 > ---

[Qemu-devel] [PULL v6 00/35] Misc patches for 2018-12-18

2019-01-09 Thread Paolo Bonzini
The following changes since commit c102d9471f8f02d9fbea72ec4505d7089173f470: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190107' into staging (2019-01-07 16:56:33 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PULL 23/35] test: replace gtester with a TAP driver

2019-01-09 Thread Paolo Bonzini
gtester is deprecated by upstream glib (see for example the announcement at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support, which gtest itself supports since

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Paolo Bonzini
On 09/01/19 22:25, Eric Blake wrote: > On 1/9/19 3:20 PM, Paolo Bonzini wrote: >> On 09/01/19 18:28, Daniel P. Berrangé wrote: so both files include each other, how nice ... >>> If the header files are mutually dependent it makes me wonder what the >>> point of having them split up is ? >>>

Re: [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99

2019-01-09 Thread Paolo Bonzini
On 09/01/19 19:10, Philippe Mathieu-Daudé wrote: > Using '-std=gnu++98' for g++ v4.8 looks like a good compromise to the > issues Daniel mentioned (still 'experimental'). > > Reviewed-by: Philippe Mathieu-Daudé C++11 has many new features that almost make it an entirely different language (the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Eric Blake
On 1/9/19 3:20 PM, Paolo Bonzini wrote: > On 09/01/19 18:28, Daniel P. Berrangé wrote: >>> so both files include each other, how nice ... >> If the header files are mutually dependent it makes me wonder what the >> point of having them split up is ? >> >> Feels like either they need to be merged,

Re: [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99

2019-01-09 Thread Richard Henderson
On 1/10/19 3:39 AM, Thomas Huth wrote: > Different versions of GCC and Clang use different versions of the C standard. > This repeatedly caused problems already, e.g. with duplicated typedefs: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html > > or with for-loop variable

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Paolo Bonzini
On 09/01/19 18:28, Daniel P. Berrangé wrote: >> so both files include each other, how nice ... > If the header files are mutually dependent it makes me wonder what the > point of having them split up is ? > > Feels like either they need to be merged, or they need to be split up > and refactored

Re: [Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-09 Thread Maran Wilson
On 1/9/2019 11:53 AM, Boris Ostrovsky wrote: On 1/9/19 6:53 AM, Stefano Garzarella wrote: Hi Liam, On Tue, Jan 8, 2019 at 3:47 PM Liam Merwick wrote: QEMU sets the hvm_modlist_entry in load_linux() after the call to load_elfboot() and then qboot loads it in boot_pvh_from_fw_cfg() But the

Re: [Qemu-devel] Internship idea: I2C passthrough

2019-01-09 Thread Paolo Bonzini
On 09/01/19 19:23, BALATON Zoltan wrote: >> '''Summary:''' Implement I2C bus passthrough on Linux hosts so that >> emulated Raspberry Pi or micro:bit boards can talk to real I2C >> devices. > > How about implementing USB for raspi boards instead? Or is there a > project proposal (or even some

Re: [Qemu-devel] [PATCH v1 5/6] scripts/archive-source: include softfloat tests

2019-01-09 Thread Richard Henderson
On 1/9/19 3:21 AM, Alex Bennée wrote: > We need these if we want to run unit/softfloat tests in our docker > containers. > > Signed-off-by: Alex Bennée > --- > scripts/archive-source.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 4/6] tests/Makefile: add floating point tests

2019-01-09 Thread Richard Henderson
On 1/9/19 3:21 AM, Alex Bennée wrote: > + le_quite) quiet. Several instances. r~

Re: [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2019-01-09 Thread Marc-André Lureau
Hi On Wed, Jan 9, 2019 at 12:45 PM Hoffmann, Gerd wrote: > > Hi, > > > Unfortunately, vdev is not set before vhost_dev_start(). > > > > We could add the migration blocker there somehow? > > Sure. Just use migrate_add_blocker() to do that at any time (see qxl.c > for an example).

Re: [Qemu-devel] [PATCH 0/4] tcg: support heterogenous CPU clusters

2019-01-09 Thread Richard Henderson
On 1/9/19 3:30 AM, Peter Maydell wrote: > Peter Maydell (4): > hw/arm/xlx-zynqmp: Realize cluster after putting RPUs in it > qom/cpu: Add cluster_index to CPUState > accel/tcg: Add cluster number to TCG TB hash > gdbstub: Simplify gdb_get_cpu_pid() to use cpu->cluster_index Reviewed-by:

[Qemu-devel] [PATCH] hw/pvrdma: Make function pvrdma_qp_send/recv return void.

2019-01-09 Thread Yuval Shaia
The functions handles errors internaly, callers have nothing to do with the return value. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 14 ++ hw/rdma/vmw/pvrdma_qp_ops.h | 4 ++-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH] hw/rdma: Delete unused struct member

2019-01-09 Thread Yuval Shaia
This member is used only in init_device_caps function, make it local. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 26 ++ hw/rdma/rdma_backend_defs.h | 1 - 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/hw/rdma/rdma_backend.c

[Qemu-devel] [PATCH] hw/pvrdma: Post CQE when receive invalid gid index

2019-01-09 Thread Yuval Shaia
This error should propagate back to guest. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.h | 1 + hw/rdma/vmw/pvrdma_qp_ops.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index a9ba40ae48..5114c90e67 100644

Re: [Qemu-devel] [qemu-s390x] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-09 Thread Jason J. Herne
On 1/9/19 1:34 PM, Cornelia Huck wrote: On Wed, 9 Jan 2019 13:10:26 -0500 "Jason J. Herne" wrote: On 1/7/19 2:02 PM, Jason J. Herne wrote: +   /*    * sense-id response buffer layout    */ @@ -205,6 +265,61 @@ typedef struct senseid {   struct ciw ciw[62];   }  __attribute__ 

Re: [Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-09 Thread Boris Ostrovsky
On 1/9/19 6:53 AM, Stefano Garzarella wrote: > Hi Liam, > > On Tue, Jan 8, 2019 at 3:47 PM Liam Merwick wrote: >> QEMU sets the hvm_modlist_entry in load_linux() after the call to >> load_elfboot() and then qboot loads it in boot_pvh_from_fw_cfg() >> >> But the current PVH patches don't handle

[Qemu-devel] [PATCH] hw/pvrdma: Remove max-sge command-line param

2019-01-09 Thread Yuval Shaia
This parameter has no effect, fix it. The function init_dev_caps sets the front-end's max-sge to MAX_SGE. Then it checks backend's max-sge and adjust it accordingly (we can't send more than what the device supports). On send and recv we need to make sure the num_sge in the WQE does not exceeds

Re: [Qemu-devel] Wiki Account Creation [Was Re: [PULL] RISC-V Changes for 3.2, Part 1]

2019-01-09 Thread Palmer Dabbelt
On Tue, 08 Jan 2019 12:35:17 PST (-0800), jcmvb...@gmail.com wrote: Hi Palmer, On Tue, Jan 8, 2019 at 11:37 AM Palmer Dabbelt wrote: It looks like I don't have an account and I'm supposed to ask on qemu-devel for one. I've created an account for you. Will send details in private e-mail.

[Qemu-devel] [PATCH v16 4/6] acpi: build TPM Physical Presence interface

2019-01-09 Thread Marc-André Lureau
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the

[Qemu-devel] [PATCH v16 5/6] acpi: add ACPI memory clear interface

2019-01-09 Thread Marc-André Lureau
The interface is described in the "TCG Platform Reset Attack Mitigation Specification", chapter 6 "ACPI _DSM Function". According to Laszlo, it's not so easy to implement in OVMF, he suggested to do it in qemu instead. See specification documentation for more details, and next commit for memory

[Qemu-devel] [PATCH v16 6/6] tpm: clear RAM when "memory overwrite" requested

2019-01-09 Thread Marc-André Lureau
Note: the "Platform Reset Attack Mitigation" specification isn't explicit about NVDIMM, since they could have different usages. It uses the term "system memory" generally (and also "volatile memory RAM" in its introduction). For initial support, I propose to consider non-volatile memory as not

[Qemu-devel] [PATCH v16 2/6] tpm: allocate/map buffer for TPM Physical Presence interface

2019-01-09 Thread Marc-André Lureau
From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xFED45000 and used by ACPI to send messages to the firmware (BIOS) and by the firmware to provide parameters for each one of the supported codes. This interface should be

[Qemu-devel] [PATCH v16 3/6] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg

2019-01-09 Thread Marc-André Lureau
From: Stefan Berger To avoid having to hard code the base address of the PPI virtual memory device we introduce a fw_cfg file etc/tpm/config that holds the base address of the PPI device, the version of the PPI interface and the version of the attached TPM. Signed-off-by: Stefan Berger [

[Qemu-devel] [PATCH v16 1/6] tpm: add a "ppi" boolean property

2019-01-09 Thread Marc-André Lureau
The following patches implement the TPM Physical Presence Interface, make use of a new memory region and a fw_cfg entry. Enable PPI by default with >=4.0 machine type, to avoid migration issues. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v16 0/6] Add support for TPM Physical Presence interface

2019-01-09 Thread Marc-André Lureau
Hi, The following patches implement the TPM Physical Presence Interface that allows a user to set a command via ACPI (sysfs entry in Linux) that, upon the next reboot, the firmware looks for and acts upon by sending sequences of commands to the TPM. A dedicated memory region is added to the TPM

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2019-01-09 Thread Eric Blake
Revisiting an older thread: On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: > Handle new NBD meta namespace: "qemu", and corresponding queries: > "qemu:dirty-bitmap:". > > With new metadata context negotiated, BLOCK_STATUS query will reply > with dirty-bitmap data, converted to extents.

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 18:52 hat Eric Blake geschrieben: > On 1/9/19 11:38 AM, Max Reitz wrote: > > > > > > > Actually, to me what you're saying sounds more like "Our deprecation > > policy is useless" to which I wholeheartedly agree. If you restrict it to "Our deprecation policy is useless for

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Eric Blake
On 1/9/19 12:51 PM, Kevin Wolf wrote: >> Indeed, and libvirt IS using 'savevm' via HMP via QMP's >> human-monitor-command, since there is no QMP counterpart for internal >> snapshot. Even though lately we consistently tell people that internal >> snapshots are underdeveloped and you should use

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 18:55 hat Eric Blake geschrieben: > On 1/9/19 11:38 AM, Max Reitz wrote: > > > I do think it affects users of HMP, because right now you can delete > > snapshots with their ID, and after this series you cannot. > > > >> This. Is. HMP. > >> > >> Not a stable ABI, no

Re: [Qemu-devel] [PATCH v3 5/5] xfs: disable map_sync for virtio pmem

2019-01-09 Thread Darrick J. Wong
On Wed, Jan 09, 2019 at 08:17:36PM +0530, Pankaj Gupta wrote: > Virtio pmem provides asynchronous host page cache flush > mechanism. we don't support 'MAP_SYNC' with virtio pmem > and xfs. > > Signed-off-by: Pankaj Gupta > --- > fs/xfs/xfs_file.c | 8 > 1 file changed, 8 insertions(+)

Re: [Qemu-devel] [qemu-s390x] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-09 Thread Cornelia Huck
On Wed, 9 Jan 2019 13:10:26 -0500 "Jason J. Herne" wrote: > On 1/7/19 2:02 PM, Jason J. Herne wrote: > >>> + > >>>   /* > >>>    * sense-id response buffer layout > >>>    */ > >>> @@ -205,6 +265,61 @@ typedef struct senseid { > >>>   struct ciw ciw[62]; > >>>   }  __attribute__ ((packed, 

Re: [Qemu-devel] [PATCH 5/5] qemu-nbd: Add --bitmap=NAME option

2019-01-09 Thread Eric Blake
On 1/8/19 10:14 PM, Eric Blake wrote: > Having to fire up qemu, then use QMP commands for nbd-server-start > and nbd-server-add, just to expose a persistent dirty bitmap, is > rather tedious. Make it possible to expose a dirty bitmap using > just qemu-nbd (of course, for now this only works when

Re: [Qemu-devel] Internship idea: I2C passthrough

2019-01-09 Thread BALATON Zoltan
On Wed, 9 Jan 2019, Stefan Hajnoczi wrote: Hi folks, You may be interested in I2C passthrough support in QEMU. Paolo and I brainstormed the idea and I've written up a rough project summary below. It still needs some work to make this a solid internship project idea. Any thoughts? Would you

Re: [Qemu-devel] [PATCH v3 3/5] libnvdimm: add nd_region buffered dax_dev flag

2019-01-09 Thread Pankaj Gupta
> > > > This patch adds 'DAXDEV_BUFFERED' flag which is set > > for virtio pmem corresponding nd_region. This later > > is used to disable MAP_SYNC functionality for ext4 > > & xfs filesystem. > > > > Signed-off-by: Pankaj Gupta > > --- > > drivers/dax/super.c | 17 + >

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Denis V . Lunev
On 1/9/19 8:09 PM, Kevin Wolf wrote: > Am 09.01.2019 um 17:55 hat Paolo Bonzini geschrieben: >> On 09/01/19 17:51, Kevin Wolf wrote: >>> Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben: On 09/01/19 12:23, Kevin Wolf wrote: > Also note that this is only metadata preallocation; full

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Daniel Henrique Barboza
On 1/9/19 12:21 PM, Kevin Wolf wrote: Am 09.01.2019 um 15:10 hat Max Reitz geschrieben: On 06.09.18 13:11, Daniel Henrique Barboza wrote: changes in v2: - removed the "RFC" marker; - added a new patch (patch 2) that removes bdrv_snapshot_delete_by_id_or_name from the code; - made changes in

Re: [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99

2019-01-09 Thread Philippe Mathieu-Daudé
On 1/9/19 5:39 PM, Thomas Huth wrote: > Different versions of GCC and Clang use different versions of the C standard. > This repeatedly caused problems already, e.g. with duplicated typedefs: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html > > or with for-loop variable

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] smbus: Add a helper to generate SPD EEPROM data

2019-01-09 Thread BALATON Zoltan
On Wed, 9 Jan 2019, BALATON Zoltan wrote: On Wed, 9 Jan 2019, Philippe Mathieu-Daudé wrote: On 1/9/19 1:15 PM, BALATON Zoltan wrote: On Wed, 9 Jan 2019, Philippe Mathieu-Daudé wrote: On 1/3/19 5:27 PM, BALATON Zoltan wrote: There are several boards with SPD EEPROMs that are now using

Re: [Qemu-devel] [PATCH v3 5/5] xfs: disable map_sync for virtio pmem

2019-01-09 Thread Pankaj Gupta
> > Virtio pmem provides asynchronous host page cache flush > > mechanism. we don't support 'MAP_SYNC' with virtio pmem > > and xfs. > > > > Signed-off-by: Pankaj Gupta > > --- > > fs/xfs/xfs_file.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/fs/xfs/xfs_file.c

Re: [Qemu-devel] [qemu-s390x] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-09 Thread Jason J. Herne
On 1/7/19 2:02 PM, Jason J. Herne wrote: +   /*    * sense-id response buffer layout    */ @@ -205,6 +265,61 @@ typedef struct senseid {   struct ciw ciw[62];   }  __attribute__ ((packed, aligned(4))) SenseId; +/* architected values for first sense byte */ +#define SNS0_CMD_REJECT 

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] smbus: Add a helper to generate SPD EEPROM data

2019-01-09 Thread Philippe Mathieu-Daudé
On 1/9/19 7:05 PM, BALATON Zoltan wrote: > On Wed, 9 Jan 2019, BALATON Zoltan wrote: >> On Wed, 9 Jan 2019, Philippe Mathieu-Daudé wrote: >>> On 1/9/19 1:15 PM, BALATON Zoltan wrote: On Wed, 9 Jan 2019, Philippe Mathieu-Daudé wrote: > On 1/3/19 5:27 PM, BALATON Zoltan wrote: >> There

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Eric Blake
On 1/9/19 11:38 AM, Max Reitz wrote: > I do think it affects users of HMP, because right now you can delete > snapshots with their ID, and after this series you cannot. >> This. Is. HMP. >> >> Not a stable ABI, no deprecation period of two releases. > > Well, if you want to do it.

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Eric Blake
On 1/9/19 11:38 AM, Max Reitz wrote: > > > Actually, to me what you're saying sounds more like "Our deprecation > policy is useless" to which I wholeheartedly agree. I think we should > only remove things in major releases, and only if it was deprecated in > the previous major release already.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Greg Kurz
On Wed, 9 Jan 2019 18:40:48 +0100 Cédric Le Goater wrote: > On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: > > On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: > >> On 1/9/19 5:39 PM, Thomas Huth wrote: > >>> When compiling with Clang and -std=gnu99, I get the following

Re: [Qemu-devel] [Spice-devel] [PATCH spice 2/3] QXL interface: deprecate spice_qxl_set_max_monitors

2019-01-09 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote: > Replace it by spice_qxl_set_device_info. Note we can't use > monitors_count for what's stored in max_monitors, because > monitors_count > denotes the length of the device_display_ids array, which >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Cédric Le Goater
On 1/9/19 5:39 PM, Thomas Huth wrote: > When compiling with Clang and -std=gnu99, I get the following errors: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from hw/intc/xics_spapr.c:34: > include/hw/ppc/xics.h:46:25: error: redefinition of typedef 'ICSState' is a > C11

Re: [Qemu-devel] [Spice-devel] [PATCH spice 1/3] QXL interface: add a function to identify monitors in the guest

2019-01-09 Thread Jonathon Jongsma
On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote: > Adds a function to let QEMU provide information to identify graphics > devices and their monitors in the guest. The function > (spice_qxl_set_device_info) sets the device address (e.g. a PCI path) > and monitor ID -> device display ID

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Cédric Le Goater
On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: >> On 1/9/19 5:39 PM, Thomas Huth wrote: >>> When compiling with Clang and -std=gnu99, I get the following errors: >>> >>> CC ppc64-softmmu/hw/intc/xics_spapr.o >>> In file

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Max Reitz
On 09.01.19 18:20, Kevin Wolf wrote: > Am 09.01.2019 um 18:05 hat Max Reitz geschrieben: >> On 09.01.19 17:57, Daniel Henrique Barboza wrote: >>> >>> >>> On 1/9/19 12:10 PM, Max Reitz wrote: On 06.09.18 13:11, Daniel Henrique Barboza wrote: > changes in v2: > - removed the "RFC"

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-09 Thread Halil Pasic
On Wed, 9 Jan 2019 10:36:11 -0500 Tony Krowiak wrote: > On 1/9/19 5:14 AM, Cornelia Huck wrote: > > On Tue, 8 Jan 2019 15:34:37 -0500 > > Tony Krowiak wrote: > > > >> On 1/8/19 12:06 PM, Cornelia Huck wrote: > >>> On Tue, 8 Jan 2019 17:50:21 +0100 > >>> Halil Pasic wrote: > >>> > On

[Qemu-devel] Internship idea: virtio-blk oss-fuzz support

2019-01-09 Thread Stefan Hajnoczi
Hi folks, I'd like to start fuzzing emulated devices in QEMU. Here is an internship project idea I'm proposing to do this. Any thoughts? Want to co-mentor this in Google Summer of Code or Outreachy? Stefan '''Summary:''' Integrate oss-fuzz into QEMU so that the virtio-blk device can be fuzz

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Daniel Henrique Barboza
On 1/9/19 3:05 PM, Max Reitz wrote: On 09.01.19 17:57, Daniel Henrique Barboza wrote: On 1/9/19 12:10 PM, Max Reitz wrote: On 06.09.18 13:11, Daniel Henrique Barboza wrote: changes in v2: - removed the "RFC" marker; - added a new patch (patch 2) that removes

Re: [Qemu-devel] [PATCH v3 1/6] smbus: Add a helper to generate SPD EEPROM data

2019-01-09 Thread BALATON Zoltan
On Wed, 9 Jan 2019, Philippe Mathieu-Daudé wrote: On 1/9/19 1:15 PM, BALATON Zoltan wrote: On Wed, 9 Jan 2019, Philippe Mathieu-Daudé wrote: On 1/3/19 5:27 PM, BALATON Zoltan wrote: There are several boards with SPD EEPROMs that are now using duplicated or slightly different hard coded data.

Re: [Qemu-devel] [PATCH] block: Acquire the AioContext in guess_disk_lchs()

2019-01-09 Thread Alberto Garcia
On Wed 09 Jan 2019 04:07:33 PM CET, Kevin Wolf wrote: > This looks like the same thing that I talked about with Markus > yesterday. He asked me where to put the acquire/release pair. My > answer was that there is more than one way to do it, but I suspect > that the realize functions of the devices

  1   2   3   4   >