Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Markus Armbruster
Leonid Bloch writes: > On 1/10/19 2:51 PM, wrote: >> Leonid Bloch writes: >> >>> Hi, >>> >>> On 1/8/19 2:20 PM, Kevin Wolf wrote: Am 03.01.2019 um 22:33 hat Leonid Bloch geschrieben: > The lookup table for power-of-two sizes is now auto-generated during the > build, and not

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-10 Thread Yongji Xie
On Fri, 11 Jan 2019 at 00:41, Daniel P. Berrangé wrote: > > On Thu, Jan 10, 2019 at 10:29:20PM +0800, Yongji Xie wrote: > > On Thu, 10 Jan 2019 at 22:11, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 10, 2019 at 10:08:54PM +0800, Yongji Xie wrote: > > > > On Thu, 10 Jan 2019 at 21:24,

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-10 Thread Pankaj Gupta
> > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > This patch series has implementation for "virtio pmem". > > "virtio pmem" is fake persistent memory(nvdimm) in guest > > which allows to bypass the guest page cache. This also > > implements a VIRTIO based asynchronous

Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c

2019-01-10 Thread Laurent Vivier
On 11/01/2019 01:37, David Gibson wrote: On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote: Hi Jon, please cc: qemu-devel and MAINTAINERS when you send a patch. You can have the list of maintainers using a script in qemu directory: ./scripts/get_maintainer.pl .patch

Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice

2019-01-10 Thread Laurent Vivier
On 11/01/2019 01:35, David Gibson wrote: On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote: David, will you take this through your ppc branch? Somehow I missed this one, sorry. Even when I look back through my mail archives I can't see the original message of this thread. Can

Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.

2019-01-10 Thread David Hildenbrand
On 10.01.19 22:03, David Hildenbrand wrote: > Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode") > changed the initial state of zPCI devices from ZPCI_FS_STANDBY to > ZPCI_FS_DISABLED (a.k.a. configured). However we still only send a > HP_EVENT_RESERVED_TO_STANDBY event to

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread si-wei liu
On 01/10/2019 07:20 PM, Michael S. Tsirkin wrote: On Thu, Jan 10, 2019 at 06:09:23PM -0800, si-wei liu wrote: On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-10 Thread si-wei liu
On 01/09/2019 05:39 AM, Michael S. Tsirkin wrote: On Tue, Jan 08, 2019 at 08:55:35PM -0800, si-wei liu wrote: On 1/7/2019 6:25 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:45:22PM -0800, si-wei liu wrote: On 01/07/2019 03:32 PM, Michael S. Tsirkin wrote:

Re: [Qemu-devel] Internship idea: virtio-blk oss-fuzz support

2019-01-10 Thread Stefan Hajnoczi
On Thu, Jan 10, 2019 at 11:25 PM Paolo Bonzini wrote: > On 10/01/19 17:07, Max Moroz via Qemu-devel wrote: > > +Oliver and Jonathan > > > > I'm a little confused. Do you want to fuzz QEMU or to fuzz something else > > using QEMU? In case of the latter, there was some discussion on OSS-Fuzz > >

Re: [Qemu-devel] [PATCH v4 2/3] ppc: Drop duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-10 Thread Thomas Huth
On 2019-01-11 01:17, David Gibson wrote: > On Thu, Jan 10, 2019 at 03:07:59PM +0100, Thomas Huth wrote: >> On 2019-01-10 14:15, Greg Kurz wrote: >>> On Thu, 10 Jan 2019 10:15:35 +0100 >>> Thomas Huth wrote: >>> When compiling the ppc code with clang and -std=gnu99, there are a couple of

[Qemu-devel] [PATCH v2 3/3] migration: introduce adaptive model for waiting thread

2019-01-10 Thread guangrong . xiao
From: Xiao Guangrong Currently we have two behaviors if all threads are busy to do compression, the main thread mush wait one of them becoming free if @compress-wait-thread set to on or the main thread can directly return without wait and post the page out as normal one Both of them have its

[Qemu-devel] [PATCH v2 1/3] migration: introduce pages-per-second

2019-01-10 Thread guangrong . xiao
From: Xiao Guangrong It introduces a new statistic, pages-per-second, as bandwidth or mbps is not enough to measure the performance of posting pages out as we have compression, xbzrle, which can significantly reduce the amount of the data size, instead, pages-per-second is the one we want

[Qemu-devel] [PATCH v2 2/3] migration: fix memory leak when updating tls-creds and tls-hostname

2019-01-10 Thread guangrong . xiao
From: Xiao Guangrong If we update parameter, tls-creds and tls-hostname, these string values are duplicated to local variables in migrate_params_test_apply() by using g_strdup(), however these new allocated memory are missed to be freed Actually, they are not used to check anything, we can

[Qemu-devel] [PATCH v2 0/3] optimize waiting for free thread to do compression

2019-01-10 Thread guangrong . xiao
From: Xiao Guangrong Changelog in v2: squash 'compress-wait-thread-adaptive' into 'compress-wait-thread' based on peter's suggestion Currently we have two behaviors if all threads are busy to do compression, the main thread mush wait one of them becoming free if @compress-wait-thread set to on

Re: [Qemu-devel] [PATCH v2 2/2] tests/microbit-test: add TWI stub device test

2019-01-10 Thread Stefan Hajnoczi
On Thu, Jan 10, 2019 at 10:12 AM Julia Suvorova via Qemu-devel wrote: > On 10.01.2019 12:48, Thomas Huth wrote: > > On 2019-01-10 10:40, Stefan Hajnoczi wrote: > > Any chance that you could use qemu_writel() right from the start here? > > That will make it easier to finally get rid of

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-10 Thread Yongji Xie
On Fri, 11 Jan 2019 at 11:56, Jason Wang wrote: > > > On 2019/1/9 下午7:27, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patch adds support for VHOST_USER_GET_INFLIGHT_FD and > > VHOST_USER_SET_INFLIGHT_FD message to set/get shared memory > > to/from qemu. Then we maintain a

Re: [Qemu-devel] If Qemu support NVMe over Fabrics ?y

2019-01-10 Thread Yang Zhong
On Thu, Jan 10, 2019 at 10:36:37AM +, Stefan Hajnoczi wrote: > On Thu, Jan 10, 2019 at 04:37:53PM +0800, Yang Zhong wrote: > > Do you know if Qemu support NVMe over Fabrics(NVMe-oF)? > > https://nvmexpress.org/wp-content/uploads/NVMe_Over_Fabrics.pdf > > > > The Qemu has enabled RDMA in last

Re: [Qemu-devel] [PATCH v2 1/3] ui: install logo icons to $prefix/share/icons

2019-01-10 Thread Gerd Hoffmann
On Thu, Jan 10, 2019 at 09:00:27AM -0600, Eric Blake wrote: > On 1/10/19 6:00 AM, Daniel P. Berrangé wrote: > > QEMU currently installs loogs to $prefix/share/qemu/ which means no GUI > > s/loogs/logos/ > > > toolkit or applications can find them by default. > > > > The accepted standards for

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-10 Thread Jason Wang
On 2019/1/9 下午7:27, elohi...@gmail.com wrote: From: Xie Yongji This patch adds support for VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD message to set/get shared memory to/from qemu. Then we maintain a "bitmap" of all descriptors in the shared memory for each queue to track

Re: [Qemu-devel] [PATCH 2/5] intel_iommu: reset intr_enabled when system reset

2019-01-10 Thread Jason Wang
On 2019/1/8 下午7:47, Peter Xu wrote: This is found when I was debugging another problem. Until now no bug is reported with this but we'd better reset the IR status correctly after a system reset. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH 1/5] intel_iommu: fix operator in vtd_switch_address_space

2019-01-10 Thread Jason Wang
On 2019/1/8 下午7:47, Peter Xu wrote: When calculating use_iommu, we wanted to first detect whether DMAR is enabled, then check whether PT is enabled if DMAR is enabled. However in the current code we used "&" rather than "&&" so the ordering requirement is lost (instead it'll be an "AND"

Re: [Qemu-devel] [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2019 at 06:09:23PM -0800, si-wei liu wrote: > > > On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: > > > diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c > > > index 80d42e1..2a3ffd3 100644 > > > ---

Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-10 Thread Yang Zhong
On Tue, Jan 08, 2019 at 12:42:06PM +0100, Paolo Bonzini wrote: > On 08/01/19 09:04, Yang Zhong wrote: > > On Fri, Jan 04, 2019 at 02:39:50PM +0100, Thomas Huth wrote: > >> On 2018-12-27 07:34, Yang Zhong wrote: > >>> From: Paolo Bonzini > >>> > >>> This lets you disable SCSI altogether with

Re: [Qemu-devel] [PATCH v2 03/22] maint: Allow for EXAMPLES in texi2pod

2019-01-10 Thread Eric Blake
On 1/4/19 5:45 PM, Eric Blake wrote: > On 12/18/18 7:46 AM, Vladimir Sementsov-Ogievskiy wrote: >> 15.12.2018 16:53, Eric Blake wrote: >>> The next commit will add an EXAMPLES section to qemu-nbd.8; >>> for that to work, we need to recognize EXAMPLES in texi2pod, >>> and we need to make all man

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-10 Thread Peter Xu
On Thu, Jan 10, 2019 at 09:29:38PM +0800, Fei Li wrote: > > 在 2019/1/8 下午4:43, Markus Armbruster 写道: > > Peter Xu writes: > > > > > On Tue, Jan 08, 2019 at 07:14:11AM +0100, Jiri Slaby wrote: > > > > On 07. 01. 19, 18:29, Markus Armbruster wrote: > > > > > static void

Re: [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-10 Thread Yang Zhong
On Tue, Jan 08, 2019 at 12:48:47PM +0100, Paolo Bonzini wrote: > On 08/01/19 11:53, Yang Zhong wrote: > > Thanks for detailed comments, i will change this one by one. > > The previous plan put all "selects" into hw/i386/Kconfig file, which > > can easily config board if we want to optimize i440fx

[Qemu-devel] [PATCH v2 3/3] nvme: use pci_dev directly in nvme_realize

2019-01-10 Thread Li Qiang
There is no need to make another reference. Signed-off-by: Li Qiang Reviewed-by: Max Reitz --- hw/block/nvme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 0ded74fa9a..0a1da749fc 100644 --- a/hw/block/nvme.c +++

[Qemu-devel] [PATCH v2 2/3] nvme: ensure the num_queues is not zero

2019-01-10 Thread Li Qiang
When it is zero, it causes segv. Backtrack: Thread 5 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffc6c17700 (LWP 51808)] 0x55acbd90 in nvme_start_ctrl (n=0x624c8100) at hw/block/nvme.c:820 warning: Source file is more recent than executable.

Re: [Qemu-devel] [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread si-wei liu
On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 80d42e1..2a3ffd3 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -176,6 +176,25 @@ static void

[Qemu-devel] [PATCH v2 1/3] nvme: use TYPE_NVME instead of constant string

2019-01-10 Thread Li Qiang
Signed-off-by: Li Qiang Reviewed-by: Max Reitz --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 7c8c63e8f5..f206391e8e 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1381,7 +1381,7 @@ static void

[Qemu-devel] [PATCH v2 0/3] nvme small fix

2019-01-10 Thread Li Qiang
This patchset contains small fix. Change since v1: 1. drop the patch of checking return value of msix_init_exclusive_bar 2. return when nvme's num_queues configuration is 0 Li Qiang (3): nvme: use TYPE_NVME instead of constant string nvme: ensure the num_queues is not zero nvme: use

[Qemu-devel] [PATCH 4/5] ide: Get rid of CMD646BAR struct

2019-01-10 Thread BALATON Zoltan
Now that no CMD646 specific parts are left in CMD646BAR (all remaining members are really PCI IDE specific) this struct can be deleted moving the memory regions for PCI IDE BARs to PCIIDEState where they better belong. The CMD646 PCI IDE model is adjusted accordingly. Signed-off-by: BALATON

[Qemu-devel] [PATCH 3/5] cmd646: Move PCI IDE specific functions to ide/pci.c

2019-01-10 Thread BALATON Zoltan
The io mem ops callbacks are not specific to CMD646 but really follow the PCI IDE spec so move these from cmd646.c to pci.c to allow other PCI IDE implementations to use them. Signed-off-by: BALATON Zoltan --- hw/ide/cmd646.c | 71 ++--

[Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-10 Thread BALATON Zoltan
Hello, This series is a small refactoring that moves some common PCI IDE io mem ops functions from the CMD646 model to the PCI IDE model so a CMD646 specific type can be dropped from PCIIDEState, removes code duplication from SiI3112 model (also fixing a bug) and allows these functions to be used

[Qemu-devel] [PATCH 2/5] cmd646: Remove IDEBus from CMD646BAR

2019-01-10 Thread BALATON Zoltan
The cmd646 io mem ops callbacks only need the IDEBus which is currently passed via a CMD646BAR struct. No need to wrap it up like that, we can pass it directly to these callbacks which then allows to drop the IDEBus from the CMD646BAR. Signed-off-by: BALATON Zoltan --- hw/ide/cmd646.c | 29

[Qemu-devel] [PATCH 5/5] sii3112: Remove duplicated code and use PCI IDE ops instead

2019-01-10 Thread BALATON Zoltan
Parts of the SiI3112 mmio are identical to PCI IDE registers so we can use the corresponding functions that were factored out into ide/pci.c. This removes code duplication and simplifies the SiI3112 model which also helped to spot a copy paste error where reading status of the 2nd channel read the

[Qemu-devel] [PATCH 1/5] cmd646: Remove unused variable

2019-01-10 Thread BALATON Zoltan
There was a pointer to PCIIDEState in CMD646BAR which was set but not used afterwards. Get rid of this unused variable. Signed-off-by: BALATON Zoltan --- hw/ide/cmd646.c | 1 - include/hw/ide/pci.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index

Re: [Qemu-devel] [PATCH 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-10 Thread David Gibson
On Fri, Jan 04, 2019 at 05:56:53PM -0200, Fabiano Rosas wrote: > These will be used to let GDB know about PPC's Special Purpose > Registers (SPR). > > They take an index based on the order the registers appear in the XML > file sent by QEMU to GDB. This index does not match the actual > location

Re: [Qemu-devel] [PATCH v4 2/3] ppc: Drop duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-10 Thread David Gibson
On Thu, Jan 10, 2019 at 03:07:59PM +0100, Thomas Huth wrote: > On 2019-01-10 14:15, Greg Kurz wrote: > > On Thu, 10 Jan 2019 10:15:35 +0100 > > Thomas Huth wrote: > > > >> When compiling the ppc code with clang and -std=gnu99, there are a > >> couple of warnings/errors like this one: > >> > >>

Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive

2019-01-10 Thread David Gibson
On Thu, Jan 10, 2019 at 03:23:58PM +0100, Greg Kurz wrote: > It has been there since the enablement of PR KVM for PAPR, ie, commit > f61b4bedaf35 in 2011. Not sure why at that time, but it is definitely > not needed with the current code. > > Signed-off-by: Greg Kurz Applied to ppc-for-4.0,

Re: [Qemu-devel] [PATCH] ppc440: Avoid reporting error when reading non-existent RAM slot

2019-01-10 Thread David Gibson
On Wed, Jan 09, 2019 at 11:37:33PM +0100, BALATON Zoltan wrote: > When reading base register of RAM slot with no RAM we should not try > to calculate register value because that will result printing an error > due to invalid RAM size. Just return 0 without the error in this case. > >

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Encode the SCSI channel (bus) in the SRP LUNs

2019-01-10 Thread David Gibson
On Wed, Jan 09, 2019 at 03:03:23PM +0100, Thomas Huth wrote: > In hw/scsi/spapr_vio.c we declare that the controller supports multiple > buses by specifying "max_channel = 7" there. So in the code that fixes > up the device tree nodes, we must encode the channel number (a.k.a. bus > number in the

Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice

2019-01-10 Thread David Gibson
On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote: > David, > > will you take this through your ppc branch? Somehow I missed this one, sorry. Even when I look back through my mail archives I can't see the original message of this thread. Can you resend please? > > Thanks, >

Re: [Qemu-devel] [PATCH v2] spapr/vio: remove the "irq" property"

2019-01-10 Thread David Gibson
On Wed, Jan 09, 2019 at 03:31:19PM +0100, Cédric Le Goater wrote: > commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property") was > merged in QEMU version 3.0. The "irq" property" can be removed for > QEMU version 4.0. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Thomas Huth >

Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c

2019-01-10 Thread David Gibson
On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote: > Hi Jon, > > please cc: qemu-devel and MAINTAINERS when you send a patch. > > You can have the list of maintainers using a script in qemu directory: > >./scripts/get_maintainer.pl .patch > > Thanks, > Laurent Hrm. Like

Re: [Qemu-devel] KVM serial8250: too much work for irq3

2019-01-10 Thread hpa
On January 10, 2019 3:44:54 PM PST, Paolo Bonzini wrote: >On 22/09/17 15:28, Denys Zagorui wrote: >> Hello >> >> This is known issue, it was mentioned at first time about 9 years >ago. >> >> https://lkml.org/lkml/2008/2/5/401 >> >> https://bugzilla.redhat.com/show_bug.cgi?id=986761 > >The

Re: [Qemu-devel] KVM serial8250: too much work for irq3

2019-01-10 Thread Paolo Bonzini
On 22/09/17 15:28, Denys Zagorui wrote: > Hello > > This is known issue, it was mentioned at first time about 9 years ago. > > https://lkml.org/lkml/2008/2/5/401 > > https://bugzilla.redhat.com/show_bug.cgi?id=986761 The issue is simply that QEMU disregards the baud rate that the guest

Re: [Qemu-devel] Internship idea: virtio-blk oss-fuzz support

2019-01-10 Thread Paolo Bonzini
On 10/01/19 17:07, Max Moroz via Qemu-devel wrote: > +Oliver and Jonathan > > I'm a little confused. Do you want to fuzz QEMU or to fuzz something else > using QEMU? In case of the latter, there was some discussion on OSS-Fuzz > and (I think) even a build support was (sort of) added: >

Re: [Qemu-devel] [PATCH v2 3/6] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-10 Thread Eric Blake
On 1/10/19 9:11 AM, Nikolay Shirokovskiy wrote: >>> The experimental command included an optional 'bitmap-export-name' >>> field for remapping the name exposed over NBD to be different from >>> the bitmap name stored on disk. >> >> >> Nikolay, do you have comments on this? >> >> >>However, my

Re: [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines

2019-01-10 Thread Alistair Francis
On Thu, Jan 10, 2019 at 8:53 AM Palmer Dabbelt wrote: > > On Wed, 09 Jan 2019 16:01:34 PST (-0800), Alistair Francis wrote: > > Signed-off-by: Alistair Francis > > --- > > default-configs/riscv32-softmmu.mak | 1 + > > default-configs/riscv64-softmmu.mak | 1 + > > 2 files changed, 2

[Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.

2019-01-10 Thread David Hildenbrand
Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode") changed the initial state of zPCI devices from ZPCI_FS_STANDBY to ZPCI_FS_DISABLED (a.k.a. configured). However we still only send a HP_EVENT_RESERVED_TO_STANDBY event to the guest, indicating a wrong state. Let's send a

Re: [Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-10 Thread Marc-André Lureau
On Thu, Jan 10, 2019 at 10:07 PM Eduardo Habkost wrote: > > On Thu, Jan 10, 2019 at 03:01:25PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, Jan 10, 2019 at 11:31:23AM -0200, Eduardo Habkost wrote: > > > > On Thu, Jan 10, 2019 at 12:35:26PM

Re: [Qemu-devel] Help needed: test-qht-par hangs on Travis

2019-01-10 Thread Eduardo Habkost
On Mon, Dec 10, 2018 at 05:09:42PM -0200, Eduardo Habkost wrote: > On Mon, Dec 10, 2018 at 03:34:27PM -0200, Eduardo Habkost wrote: > > On Mon, Dec 10, 2018 at 12:07:20PM -0500, Emilio G. Cota wrote: > > > On Mon, Dec 10, 2018 at 14:36:01 -0200, Eduardo Habkost wrote: > > > > On Sun, Dec 09, 2018

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-10 Thread Eric Blake
On 1/10/19 7:20 AM, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. s/region, reported/regions reported/ > > This accuracy is not free: assume we have qcow2 disk.

[Qemu-devel] [PULL v7 00/35] Misc patches for 2018-12-18

2019-01-10 Thread Paolo Bonzini
The following changes since commit 147923b1a901a0370f83a0f4c58ec1baffef22f0: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190108-pull-request' into staging (2019-01-08 16:07:32 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [PATCH v4 2/3] ppc: Drop duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-10 Thread Paolo Bonzini
On 10/01/19 17:00, Greg Kurz wrote: >>> Hmm... so the choice here is to simply ignore the official coding >>> style ? >> >> Are typedefs really our "official coding style"? It's mentioned in >> HACKING, not in CODING_STYLE, so I rather see this as a recommendation > > Indeed. > >> only.

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-10 Thread Eric Blake
On 1/10/19 2:21 PM, Eric Blake wrote: > On 1/10/19 1:26 PM, Eric Blake wrote: >> On 1/10/19 1:18 PM, Eric Blake wrote: >>> Patches speak louder than words. This is my counter-proposal to >>> Leonid's thread on how best to respresent the S_*iB macros in units.h, >>> where my proposal is that we

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-10 Thread Eric Blake
On 1/10/19 1:26 PM, Eric Blake wrote: > On 1/10/19 1:18 PM, Eric Blake wrote: >> Patches speak louder than words. This is my counter-proposal to >> Leonid's thread on how best to respresent the S_*iB macros in units.h, >> where my proposal is that we don't need them at all. (hence my subject >>

Re: [Qemu-devel] [PATCH 2/4] exec: add RAM_EXTERNAL flag to mark non-QEMU allocated blocks

2019-01-10 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > This flag allows to determine whether RAM block is available from the outside. > E.g. when we use -object memory-backend-file or -mem-path options we have > a RAM block which is mapped to shared file. > > We need this flag in the following

Re: [Qemu-devel] [PATCH 1/4] migration: add RAMBlock's offset validation

2019-01-10 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > RAM migration has a RAMBlock validation stage (flag RAM_SAVE_FLAG_MEM_SIZE). > In this stage QEMU checks further information about RAMBlock: > 1. Presence (by idstr), > 2. Length (trying to resize, when differs), > 3. Optional page size. > > This

Re: [Qemu-devel] [PATCH 0/4] Add ignore-external migration capability

2019-01-10 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Hi, > > The series adds migration capability which allows to skip 'external' RAM > blocks > during migration. External block is a RAMBlock which available from the > outside > of current QEMU process (e.g. file in /dev/shm). It's useful for fast

Re: [Qemu-devel] [PATCH 1/4] hw/arm/xlx-zynqmp: Realize cluster after putting RPUs in it

2019-01-10 Thread Alistair Francis
On Tue, Jan 8, 2019 at 8:30 AM Peter Maydell wrote: > > Currently the cluster implementation doesn't have any constraints > on the ordering of realizing the TYPE_CPU_CLUSTER and populating it > with child objects. We want to impose a constraint that realize > must happen only after all the child

Re: [Qemu-devel] [PATCH v2 2/2] tests: Disable qht-bench parallel test when using gprof

2019-01-10 Thread Eduardo Habkost
On Thu, Jan 10, 2019 at 04:25:17PM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > This test is failing on the Travis CI [*] since some time now, > > disable it until it get fixed. > > > > [*] https://travis-ci.org/qemu/qemu/builds/474821674 > > > > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v3 3/6] Revert "vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE"

2019-01-10 Thread Eric Blake
On 1/10/19 1:18 PM, Eric Blake wrote: > This reverts commit 3dd5b8f4718c6ca1eadb16dd67a8cad76455ddb0. > > Now that we can express QemuOpts values as an integer, we don't have > to be careful about how we spell our macro. Signed-off-by: Eric Blake > --- > block/vdi.c | 4 ++-- > 1 file

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Eric Blake
On 1/10/19 7:33 AM, Eric Blake wrote: >> Eric - thanks for the comment about 'local' - I will get rid of it if we >> decide to include this patch. > > I'm still not convinced we need it. I would much rather see a patch > that makes QemuOpt accept default integer values as integers rather than

[Qemu-devel] qemu-user-linux: how could I measure performance for aarch64 and arm?

2019-01-10 Thread Matwey V. Kornilov
Hello, I am running the same application compiled for aarch64 and armv7l on x86_64 platform using qemu-user-linux tools. I see dramatic performance difference (30 times) between emulated architectures: aarch64 runs for ~4 minutes, armv7l runs for ~2 hours. I do understand that CPU architecture

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-10 Thread Eric Blake
On 1/10/19 1:18 PM, Eric Blake wrote: > Patches speak louder than words. This is my counter-proposal to > Leonid's thread on how best to respresent the S_*iB macros in units.h, > where my proposal is that we don't need them at all. (hence my subject > line, even though it is completely unrelated

[Qemu-devel] [PATCH v3 4/6] qemu: Prefer '(x * MiB)' over 'S_xiB'

2019-01-10 Thread Eric Blake
Now that QemuOpts can accept true integer defaults, we no longer have to be careful about the spelling of our default macros because we are no longer applying stringify() to any of the macros. Although it is slightly more verbose to call out an integer times a scale, it avoids the need to have a

[Qemu-devel] [PATCH v3 2/6] block: Take advantage of QemuOpt default integers

2019-01-10 Thread Eric Blake
Instead of defining an integer to a default string value (where we have to be careful how we spelled the integer because of the use of stringify), populate a default integer value instead. Drop a useless stringify(0); a missing default is just as easy to interpret as 0 as an explicit string 0.

[Qemu-devel] [PATCH v3 3/6] Revert "vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE"

2019-01-10 Thread Eric Blake
This reverts commit 3dd5b8f4718c6ca1eadb16dd67a8cad76455ddb0. Now that we can express QemuOpts values as an integer, we don't have to be careful about how we spell our macro. --- block/vdi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index

[Qemu-devel] [PATCH v3 6/6] Revert "include: Add a lookup table of sizes"

2019-01-10 Thread Eric Blake
This reverts commit 540b8492618ebbe98e7462bd7d31361b8cb10a05. Now that QemuOpts can accept default values as integers, there are no more clients of the S_*iB macros, and no longer a reason to have a list of macros that contain a specific spelling of special values merely for the sake of

[Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-10 Thread Eric Blake
Patches speak louder than words. This is my counter-proposal to Leonid's thread on how best to respresent the S_*iB macros in units.h, where my proposal is that we don't need them at all. (hence my subject line, even though it is completely unrelated to the series) True, my diffstat is even

[Qemu-devel] [PATCH v3 5/6] Revert "include: Add a comment to explain the origin of sizes' lookup table"

2019-01-10 Thread Eric Blake
This reverts commit 1240ac558d348f6c7a5752b1a57c1da58e4efe3e. The table itself is about to be reverted, now that it has no clients. Signed-off-by: Eric Blake --- include/qemu/units.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/qemu/units.h

[Qemu-devel] [PATCH v3 1/6] qemu-option: Allow integer defaults

2019-01-10 Thread Eric Blake
Set the framework up for declaring integer options with an integer default, instead of our current insane approach of requiring the default value to be given as a string (which then has to be reparsed at every use that wants a number). git grep '[^.]def_value_str' says that we have done a good

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Markus Armbruster
Leonid Bloch writes: > On 1/10/19 2:40 PM, Markus Armbruster wrote: >> Leonid Bloch writes: >> >>> Hi, >>> >>> On 1/8/19 11:31 AM, Markus Armbruster wrote: I'd leave it hard-coded. Replacing a few trivial defines by an arguably less trivial script doesn't feel like an improvement.

Re: [Qemu-devel] [PULL 0/2] Linux user for 4.0 patches

2019-01-10 Thread Peter Maydell
On Thu, 10 Jan 2019 at 09:01, Laurent Vivier wrote: > > The following changes since commit 147923b1a901a0370f83a0f4c58ec1baffef22f0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20190108-pull-request' into staging (2019-01-08 > 16:07:32 +) > > are available in the Git

Re: [Qemu-devel] [PATCH 3/4] accel/tcg: Add cluster number to TCG TB hash

2019-01-10 Thread Peter Maydell
On Tue, 8 Jan 2019 at 16:30, Peter Maydell wrote: > > Include the cluster number in the hash we use to look > up TBs. This is important because a TB that is valid > for one cluster at a given physical address and set > of CPU flags is not necessarily valid for another: > the two clusters may have

Re: [Qemu-devel] [PATCH v1 11/19] travis: use homebrew addon for MacOSX

2019-01-10 Thread Daniel P . Berrangé
On Thu, Jan 10, 2019 at 05:45:08PM +, Alex Bennée wrote: > Rather than poking homebrew manually we can specify the packages > needed via the homebrew addon. These are only installed on MacOS based > builds. > > Signed-off-by: Alex Bennée > Signed-off-by: Alex Bennée Dupe > --- >

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-10 Thread Eric Blake
On 1/10/19 11:06 AM, Dr. David Alan Gilbert wrote: >>> savevm [-t] [-i] [tag|id] >>> >>> then: >>> a) with neither -t or -i it would behave in the same roulette way >>> as it does in the moment, and it might be a tag or id >>> >>> b) with -t we'd explicitly treat the parameter as a tag

Re: [Qemu-devel] [PATCH v1 02/19] tests: run ldconfig after installing extra software

2019-01-10 Thread Philippe Mathieu-Daudé
On 1/10/19 6:44 PM, Alex Bennée wrote: > From: Daniel P. Berrangé > > The docker file builds and installs software into /usr/local but does > not run ldconfig. As a result QEMU links to libvirglrenderer.so, but > then crashes in "make check" unable to find the library. Wow. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-10 Thread Eduardo Habkost
On Thu, Jan 10, 2019 at 03:01:25PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Jan 10, 2019 at 11:31:23AM -0200, Eduardo Habkost wrote: > > > On Thu, Jan 10, 2019 at 12:35:26PM +0400, Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Thu,

[Qemu-devel] [PATCH v3 1/2] globals: Allow global properties to be optional

2019-01-10 Thread Eduardo Habkost
Making some global properties optional will let us simplify compat code when a given property works on most (but not all) subclasses of a given type. Device types will be able to opt out from optional compat properties by simply not registering those properties. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH v3 2/2] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-10 Thread Eduardo Habkost
The disable-legacy and disable-modern properties apply only to some virtio-pci devices. Make those properties optional. This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide version-specific variants of virtio PCI devices"): $ qemu-system-x86_64 -machine pc-i440fx-2.6 \

Re: [Qemu-devel] [PATCH v1 15/19] travis: remove matrix settings that duplicate global settings

2019-01-10 Thread Philippe Mathieu-Daudé
On 1/10/19 6:45 PM, Alex Bennée wrote: > From: Daniel P. Berrangé > > The global defaults request "trusty" and "gcc", so matrix entries do not > need to repeat this. > > Signed-off-by: Daniel P. Berrangé > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé > --- > .travis.yml

[Qemu-devel] [PATCH v3 0/2] Fix virtio-*(-non)-transitional crash on 2.6 machine-types

2019-01-10 Thread Eduardo Habkost
Changes v2 -> v3: * Don't ignore all errors: only ignore optional properties if they don't exist * Patch 1/3 from v2 was already merged on machine-next Description of v2: This is a second attempt to fix the crash reported by Thomas[1]. This keeps the compat property array simple, different

Re: [Qemu-devel] [PATCH v1 06/19] tests: use in-place sed magic for enabling deb-src in travis image

2019-01-10 Thread Philippe Mathieu-Daudé
On 1/10/19 6:45 PM, Alex Bennée wrote: > This avoids potential problems with duplicates. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/travis.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/travis.docker >

Re: [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to Fedora 29

2019-01-10 Thread Daniel P . Berrangé
On Thu, Jan 10, 2019 at 06:54:24PM +0100, Philippe Mathieu-Daudé wrote: > On 1/10/19 6:45 PM, Alex Bennée wrote: > > From: Daniel P. Berrangé > > > > Using the "latest" tag is not a good idea because this changes what > > release it points to every 6 months. Together with caching of docker > >

Re: [Qemu-devel] [PATCH v1 03/19] tests: remove obsolete 'debian' dockerfile

2019-01-10 Thread Philippe Mathieu-Daudé
On 1/10/19 6:45 PM, Alex Bennée wrote: > From: Daniel P. Berrangé > > The 'debian' dockerfile was deprecated in favour of versioned > dockerfiles in July 2017. That is enough time for developers to > be warned about the rename. > > Signed-off-by: Daniel P. Berrangé > Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v1 16/19] docker: Use a stable snapshot for Debian Sid

2019-01-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé The Debian Sid repository is not garanteed to be stable, as his 'unstable' name suggest :) To allow quick testing, packages are pushed various time a day, which my be annoying when trying to use it for stable development (which is not recommended, but Sid provides

[Qemu-devel] [PATCH v1 17/19] travis: bump to Xenial baseline

2019-01-10 Thread Alex Bennée
Travis is slowly catching up. Move to Xenial based images for our current builds. These are now all proper VMs. Signed-off-by: Alex Bennée --- .travis.yml | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index 79da3a495a..93fd0164a0

Re: [Qemu-devel] [PATCH v1 01/19] docker: Use stable git tag for virglrenderer

2019-01-10 Thread Philippe Mathieu-Daudé
On 1/10/19 6:44 PM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Use a stable tag instead of some random commit from mainstream > development, to avoid unexpected build failures. > > This fixes: > > CC virglrenderer.lo > virglrenderer.c: In function

[Qemu-devel] [PATCH v1 02/19] tests: run ldconfig after installing extra software

2019-01-10 Thread Alex Bennée
From: Daniel P. Berrangé The docker file builds and installs software into /usr/local but does not run ldconfig. As a result QEMU links to libvirglrenderer.so, but then crashes in "make check" unable to find the library. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH v1 19/19] tests/docker: remove SID_AGE test hack

2019-01-10 Thread Alex Bennée
Now we are using "named" snapshots of debian-sid we can rely on the existing checksum mechanism for detecting changes. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 13 - 1 file changed, 13 deletions(-) diff --git a/tests/docker/Makefile.include

[Qemu-devel] [PATCH v1 15/19] travis: remove matrix settings that duplicate global settings

2019-01-10 Thread Alex Bennée
From: Daniel P. Berrangé The global defaults request "trusty" and "gcc", so matrix entries do not need to repeat this. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée --- .travis.yml | 8 1 file changed, 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index

Re: [Qemu-devel] [PULL 0/8] Ui 20190110 patches

2019-01-10 Thread Peter Maydell
are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20190110-pull-request > > for you to fetch changes up to 766a0a54faa97b8d4cbc7a6bd47f7ea78e625c19: > > spice: Remove unused include (2019-01-10 08:55:36 +0100) > > ---

[Qemu-devel] [PATCH v1 01/19] docker: Use stable git tag for virglrenderer

2019-01-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé Use a stable tag instead of some random commit from mainstream development, to avoid unexpected build failures. This fixes: CC virglrenderer.lo virglrenderer.c: In function 'virgl_has_gl_colorspace': virglrenderer.c:208:11: error: implicit declaration

[Qemu-devel] [PATCH v1 13/19] travis: stop using container based envs

2019-01-10 Thread Alex Bennée
From: Daniel P. Berrangé The Travis container based envs are deprecated: https://docs.travis-ci.com/user/reference/trusty/ "Container-based infrastructure is currently being deprecated. Please remove any sudo: false keys in your .travis.yml file to use the default fully-virtualized

Re: [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to Fedora 29

2019-01-10 Thread Philippe Mathieu-Daudé
On 1/10/19 6:45 PM, Alex Bennée wrote: > From: Daniel P. Berrangé > > Using the "latest" tag is not a good idea because this changes what > release it points to every 6 months. Together with caching of docker > builds this can cause confusion where CI has cached & built with Fedora > N, while a

[Qemu-devel] [PATCH v1 07/19] travis: add whitespace between each major section & matrix entry

2019-01-10 Thread Alex Bennée
From: Daniel P. Berrangé Improve the readability of the travis config by adding two blank lines between each major section and matrix entry. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée --- .travis.yml | 42 ++ 1 file changed, 42

[Qemu-devel] [PATCH v1 03/19] tests: remove obsolete 'debian' dockerfile

2019-01-10 Thread Alex Bennée
From: Daniel P. Berrangé The 'debian' dockerfile was deprecated in favour of versioned dockerfiles in July 2017. That is enough time for developers to be warned about the rename. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian.docker | 13

  1   2   3   4   >