Re: [Qemu-devel] [PATCH v2 3/4] configure: Let SDL support be optional on OpenBSD

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 12:44 PM, Peter Maydell wrote: > On Thu, 24 Jan 2019 at 01:16, Philippe Mathieu-Daudé > wrote: >> --- a/configure >> +++ b/configure >> @@ -3379,7 +3379,8 @@ for drv in $audio_drv_list; do >> >> sdl) >> if test "$sdl" = "no"; then >> -error_exit "sdl not found or d

Re: [Qemu-devel] m68k gdb has stopped single stepping correctly

2019-01-24 Thread Laurent Vivier
On 24/01/2019 13:59, Lucien Anti-Spam wrote: > > >> On Thursday, January 24, 2019, 3:08:07 AM GMT+9, Emilio G. Cota > wrote: >> > On Wed, Jan 23, 2019 at 15:58:27 +, Lucien Anti-Spam via > Qemu-devel wrote: >> > Hi folks, >> > I noticed that with 3.x release that the GDB options (-S -s) for

Re: [Qemu-devel] [PATCH v2 0/5] arm: microbit Non-Volatile Memory Controller

2019-01-24 Thread Peter Maydell
On Wed, 23 Jan 2019 at 21:23, Stefan Hajnoczi wrote: > > v2: > * Add Patch 2 to call memory_region_flush_rom_device() from pflash devices >[Peter] > > This series adds the Non-Volatile Memory Controller, which controls access to > the User Information Control Registers (UICR), Factory Informa

Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 12:43 PM, Gerd Hoffmann wrote: > On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote: >> Move the complexity of milkymist_tmu2_create() into the >> source file. Doing so we avoid to include the X11/OpenGL >> headers in all LM32 devices, and we also avoid the duplicate

Re: [Qemu-devel] m68k gdb has stopped single stepping correctly

2019-01-24 Thread Alex Bennée
Lucien Anti-Spam via Qemu-devel writes: > > >> On Thursday, January 24, 2019, 3:08:07 AM GMT+9, Emilio G. Cota > wrote: > > On Wed, Jan 23, 2019 at 15:58:27 +, Lucien > Anti-Spam via Qemu-devel wrote:> > Hi folks, >> > I noticed that with 3.x release that the GDB options (-S -s) for

Re: [Qemu-devel] [PATCH 1/2] qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATE

2019-01-24 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > qmp_cont in RUN_STATE_FINISH_MIGRATE may lead to moving vm to > RUN_STATE_RUNNING, before actual migration finish. So, when migration > thread will try to go to RUN_STATE_POSTMIGRATE, assuming transition > RUN_STATE_FINISH_MIGRATE->

[Qemu-devel] unknown keycodes `(unnamed)', please report to qemu-devel@nongnu.org

2019-01-24 Thread Burgess, Alison E
I am running Ubuntu 18.04 and I am sending this email because when I try to run these series of commands in an executable file in arm-none-eabi-as -mcpu=arm926ej-s -g ts.s -o ts.o arm-none-eabi-gcc -c -mcpu=arm926ej-s -g t.c -o t.o arm-none-eabi-ld -T t.ld ts.o t.o -o t.elf arm-none-eabi-objcopy

[Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-01-24 Thread Gerd Hoffmann
Get rid of the pcspk_state global, allow pc speaker be added using "-device isa-pcspk". Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190124110810.1040-1-kra...@redhat.com --- hw/audio/pcspk.c | 35 +++ 1 file changed, 15 insertio

[Qemu-devel] [PULL 0/7] Audio 20190124 patches

2019-01-24 Thread Gerd Hoffmann
The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request' into staging (2019-01-23 17:57:47 +) are available in the git repository at: git://git.kraxel.org/qemu tags/audio-201

[Qemu-devel] [PULL 2/7] audio: use pkg-config

2019-01-24 Thread Gerd Hoffmann
Use pkg-config to probe for alsa and pulseaudio. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190124112055.547-2-kra...@redhat.com --- configure | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/config

[Qemu-devel] [PULL 3/7] audio: allow optional audio drivers.

2019-01-24 Thread Gerd Hoffmann
For those audio drivers which can be probed (sdl, alsa, pulse) add a try-$name variants. Unlike the variants without try- prefix they will not error out on probe failure, the driver will be dropped from the list instead. Mainly useful for the audio_drv_list default values. Signed-off-by: Gerd Ho

[Qemu-devel] [PULL 6/7] audio: error message tweak

2019-01-24 Thread Gerd Hoffmann
Only print a message about the failed driver initialization in case it was the driver explicitly requested by the user via QEMU_AUDIO_DRV=$drv. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190124112055.547-6-kra...@redhat.com --- audio/audio.c | 12 +++-

[Qemu-devel] [PULL 5/7] audio: check for pulseaudio daemon pidfile

2019-01-24 Thread Gerd Hoffmann
Check whenever the pulseaudio daemon pidfile is present before trying to initialize the pulseaudio backend. Just return NULL if that is not the case, so qemu will check the next backend in line. In case the user explicitly configured a non-default pulseaudio server skip the check. Signed-off-by:

[Qemu-devel] [PULL 4/7] audio: use try-sdl for openbsd

2019-01-24 Thread Gerd Hoffmann
Fixes the openbsd build failure with SDL disabled. Signed-off-by: Gerd Hoffmann Message-id: 20190124112055.547-4-kra...@redhat.com --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6a2aa3b533..1eff5946f6 100755 --- a/configure +++ b/con

[Qemu-devel] [PULL 7/7] audio: probe audio drivers by default

2019-01-24 Thread Gerd Hoffmann
Add the drivers listed in audio_possible_drivers to audio_drv_list, using the try-* variants. That way the probable drivers are compiled by default if possible. Additioal tweaks: linux: reorder to: pa alsa sdl oss. *bsd: drop pa. Signed-off-by: Gerd Hoffmann Message-id: 20190124112055.547-7

Re: [Qemu-devel] [PATCH] gdbstub: shutdown guest when the target is killed

2019-01-24 Thread Peter Maydell
On Thu, 24 Jan 2019 at 12:47, KONRAD Frederic wrote: > > Under MinGW when the target is killed no "W00" packet are received by GDB > because gdbstub takes the "exit(0)" path. Why is this a problem? The gdb protocol documentation for the 'k' packet says: # If the target system immediately closes

Re: [Qemu-devel] m68k gdb has stopped single stepping correctly

2019-01-24 Thread Lucien Anti-Spam via Qemu-devel
> On Thursday, January 24, 2019, 3:08:07 AM GMT+9, Emilio G. Cota wrote: > > On Wed, Jan 23, 2019 at 15:58:27 +, Lucien Anti-Spam via Qemu-devel wrote:> > Hi folks, > > I noticed that with 3.x release that the GDB options (-S -s) for certain > > CPU results in very weird stepping.Usua

[Qemu-devel] [PATCH] trace: improve runstate tracing

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
Trace previous state, move tracepoint to runstate_set start (to cover all cases for debugging), add string representations of traced states. Signed-off-by: Vladimir Sementsov-Ogievskiy --- vl.c | 7 +-- trace-events | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH] i386: extended the cpuid level when Intel PT is enabled

2019-01-24 Thread Luwei Kang
Intel Processor Trace required CPUID[0x14] but the cpuid level is 0xd when create a kvm guest with e.g. "-cpu qemu64,+intel-pt". Signed-off-by: Luwei Kang --- target/i386/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 2f54125..da477b3

[Qemu-devel] [PULL 5/5] hw/i386/pc.c: fix one typo in function name

2019-01-24 Thread Laurent Vivier
From: Wei Yang Rename pc_get_hotpug_handler to pc_get_hotplug_handler. No functional change. Signed-off-by: Wei Yang Reviewed-by: Stefano Garzarella Message-Id: <20190124073626.20534-1-richardw.y...@linux.intel.com> Signed-off-by: Laurent Vivier --- hw/i386/pc.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [PULL 3/5] ppc: e6500 registers SPR 604 twice

2019-01-24 Thread Laurent Vivier
From: Jon Diekema When using the e6500 CPU, QEMU generates a fatal error after complaining about registering SPR 604 twice. Building and testing with commit 9b2e891ec5ccdb4a7d583b77988848282606fdea shows the issue: qemu-system-ppc64 --version QEMU emulator version 3.1.50 (v3.1.0-456-g9b2e891ec5

[Qemu-devel] [PULL 1/5] MAINTAINERS: Fix utf-8 mangling

2019-01-24 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch incorrectly applied as 15ffb43cbf4. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190117161355.18204-1-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/M

Re: [Qemu-devel] [RFC PATCH v4 41/44] virtio: make virtio dependencies with Kconfig

2019-01-24 Thread Thomas Huth
On 2019-01-23 07:56, Yang Zhong wrote: > Signed-off-by: Yang Zhong > Reviewed-by: Thomas Huth > --- > default-configs/i386-softmmu.mak | 1 - > default-configs/s390x-softmmu.mak | 1 - > default-configs/virtio.mak| 15 --- > hw/9pfs/Kconfig | 2 ++ > hw/

[Qemu-devel] [PULL 2/5] contrib/gitdm: Fix a typo

2019-01-24 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Typo comes from upstream git://git.lwn.net/gitdm.git. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <201905.8270-1-phi...@redhat.com> Signed-off-by: Laurent Vivier --- contrib/gitdm/filetypes.txt | 2 +- 1 file changed

[Qemu-devel] [PULL 0/5] Trivial patches patches

2019-01-24 Thread Laurent Vivier
The following changes since commit 6d809e7da943bb4b95b408fbf3d80d097c0f7d38: Merge remote-tracking branch 'remotes/xtensa/tags/20190122-xtensa' into staging (2019-01-23 21:50:49 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-patches-pull-request

[Qemu-devel] [PULL 4/5] virtio-net: Fix a typo

2019-01-24 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Fixes: 2974e916df8 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20190121181335.3326-1-phi...@redhat.com> Signed-off-by: Laurent Vivier --- include/hw/virtio/virtio-net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[Qemu-devel] [PATCH] gdbstub: shutdown guest when the target is killed

2019-01-24 Thread KONRAD Frederic
Under MinGW when the target is killed no "W00" packet are received by GDB because gdbstub takes the "exit(0)" path. So replace the "exit(0)" call by a normal guest shutdown so the "W00" packet has a chance to be sent in "gdb_cleanup". Signed-off-by: KONRAD Frederic --- gdbstub.c | 5 + 1 fil

Re: [Qemu-devel] [PATCH v5] log: Make glib logging go through QEMU

2019-01-24 Thread Christophe Fergeau
Hey, On Thu, Jan 24, 2019 at 10:38:37AM +0100, Markus Armbruster wrote: > Christophe Fergeau writes: > > > This commit adds a qemu_init_logging() helper which calls > > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > > are handled similarly to other QEMU logs. This means

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-24 Thread Christophe Fergeau
Hey, On Thu, Jan 24, 2019 at 10:35:52AM +0100, Markus Armbruster wrote: > Markus Armbruster writes: > > > Eric Blake writes: > > > >> On 1/2/19 12:01 PM, Christophe Fergeau wrote: > >>> Adding Markus to cc: list, I forgot to do it when sending the patch. > >> > >> Also worth backporting via qem

[Qemu-devel] [PATCH 1/2] qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATE

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
qmp_cont in RUN_STATE_FINISH_MIGRATE may lead to moving vm to RUN_STATE_RUNNING, before actual migration finish. So, when migration thread will try to go to RUN_STATE_POSTMIGRATE, assuming transition RUN_STATE_FINISH_MIGRATE->RUN_STATE_POSTMIGRATE, it will crash, as current state is RUN_STATE_RUNNI

[Qemu-devel] [PULL 1/1] io: ensure UNIX client doesn't unlink server socket

2019-01-24 Thread Daniel P . Berrangé
The qio_channel_socket_close method for was mistakenly unlinking the UNIX server socket, even if the channel was a client connection. This was not noticed with chardevs, since they never call close, but with the VNC server, this caused the VNC server socket to be deleted after the first client quit

[Qemu-devel] [PULL 0/1] Qio next patches

2019-01-24 Thread Daniel P . Berrangé
The following changes since commit 6d809e7da943bb4b95b408fbf3d80d097c0f7d38: Merge remote-tracking branch 'remotes/xtensa/tags/20190122-xtensa' into staging (2019-01-23 21:50:49 +) are available in the Git repository at: https://github.com/berrange/qemu tags/qio-next-pull-request for y

[Qemu-devel] [PATCH 0/2] fix qmp-cont vs migration-finish race-crash

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
Hi. It's a simple fix for problems reported in "Aborts in iotest 169" by Max: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05907.html In thread Kevin described that a problem itself is bigger and needs more effort: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06136.html S

[Qemu-devel] [PATCH 2/2] iotest: fix 169: do not run qmp_cont in RUN_STATE_FINISH_MIGRATE

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
qmp_cont fails if vm in RUN_STATE_FINISH_MIGRATE, so let's wait for final RUN_STATE_POSTMIGRATE. Also, while being here, check qmp_cont result. Reported-by: Max Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/169 | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(

Re: [Qemu-devel] [RFC PATCH v4 35/44] isa: express dependencies with kconfig

2019-01-24 Thread Thomas Huth
On 2019-01-23 07:56, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 9 - > hw/audio/Kconfig | 2 ++ > hw/block/Kconfig | 2 ++ > hw/char/Kconfig

Re: [Qemu-devel] [PULL v2 00/51] Misc patches for 2019-01-23

2019-01-24 Thread Peter Maydell
On Wed, 23 Jan 2019 at 01:04, Paolo Bonzini wrote: > > The following changes since commit cce871c504694cf1034adf525556e3ca3c7eebb6: > > hw/block/xen: use proper format string for printing sectors (2019-01-21 > 14:45:49 +) > > are available in the git repository at: > > git://github.com/bo

Re: [Qemu-devel] [PULL 49/49] docker: disable Xen on CentOS 7

2019-01-24 Thread Daniel P . Berrangé
On Mon, Jan 21, 2019 at 07:06:20PM +0100, Paolo Bonzini wrote: > The Xen repository is failing to install, disable it. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/centos7.docker | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tests/docker/dock

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Kevin Wolf
Am 24.01.2019 um 11:49 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 24.01.2019 um 10:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 23.01.2019 18:48, Max Reitz wrote: > > > > Hi, > > > > > > > > When running 169 in parallel (e.g. like so: > > > >

Re: [Qemu-devel] [PATCH]gtk-egl: Blend cursor buffer within a scaled viewport

2019-01-24 Thread Gerd Hoffmann
> diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h > index 3fc656a..63ffc2d 100644 > --- a/include/ui/egl-helpers.h > +++ b/include/ui/egl-helpers.h > @@ -28,6 +28,8 @@ void egl_fb_read(void *dst, egl_fb *src); > void egl_texture_blit(QemuGLShader *gls, egl_fb *dst, egl_fb *src, bo

Re: [Qemu-devel] [PULL v2 00/51] Misc patches for 2019-01-23

2019-01-24 Thread Peter Maydell
On Wed, 23 Jan 2019 at 01:04, Paolo Bonzini wrote: > > The following changes since commit cce871c504694cf1034adf525556e3ca3c7eebb6: > > hw/block/xen: use proper format string for printing sectors (2019-01-21 > 14:45:49 +) > > are available in the git repository at: > > git://github.com/bo

[Qemu-devel] [PATCH v2] tests/vm: move images to $HOME/.cache/qemu-vm/images

2019-01-24 Thread Gerd Hoffmann
It's easier to move around the images then, by replacing the subdirectory with a symlink. Allows to share the images between multiple qemu checkouts for example. Signed-off-by: Gerd Hoffmann --- Notes: v2: use $HOME/.cache/qemu-vm/images as location tests/vm/Makefile.include | 12 +++-

Re: [Qemu-devel] [PATCH v3 18/31] target/arm: Create ARMVAParameters and helpers

2019-01-24 Thread Peter Maydell
On Tue, 8 Jan 2019 at 22:32, Richard Henderson wrote: > > Split out functions to extract the virtual address parameters. > Let the functions choose T0 or T1 address space half, if present. > Extract (most of) the control bits that vary between EL or Tx. > > Signed-off-by: Richard Henderson > +

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
24.01.2019 13:15, Kevin Wolf wrote: > Am 24.01.2019 um 10:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 23.01.2019 18:48, Max Reitz wrote: >>> Hi, >>> >>> When running 169 in parallel (e.g. like so: >>> >>> $ while TEST_DIR=/tmp/t0 ./check -T -qcow2 169; do; done >>> $ while TEST_DIR=/tmp/t1

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Halil Pasic
On Thu, 24 Jan 2019 11:19:34 +0100 Cornelia Huck wrote: > On Thu, 24 Jan 2019 11:08:02 +0100 > Pierre Morel wrote: > > > On 23/01/2019 11:21, Cornelia Huck wrote: > > > On Tue, 22 Jan 2019 19:33:46 +0100 > > > Halil Pasic wrote: > > > > > >> On Mon, 21 Jan 2019 12:03:51 +0100 > > >> Corneli

Re: [Qemu-devel] [PATCH v2 3/4] configure: Let SDL support be optional on OpenBSD

2019-01-24 Thread Peter Maydell
On Thu, 24 Jan 2019 at 01:16, Philippe Mathieu-Daudé wrote: > --- a/configure > +++ b/configure > @@ -3379,7 +3379,8 @@ for drv in $audio_drv_list; do > > sdl) > if test "$sdl" = "no"; then > -error_exit "sdl not found or disabled, can not use sdl audio driver" > +echo "W

Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source

2019-01-24 Thread Gerd Hoffmann
On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote: > Move the complexity of milkymist_tmu2_create() into the > source file. Doing so we avoid to include the X11/OpenGL > headers in all LM32 devices, and we also avoid the duplicate > declaration of glx_fbconfig_attr[] (it is alr

Re: [Qemu-devel] [PATCH v3 5/6] audio: error message tweak

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 12:20 PM, Gerd Hoffmann wrote: > Only print a message about the failed driver initialization in case it > was the driver explicitly requested by the user via QEMU_AUDIO_DRV=$drv. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé > --- > audio/audio.c | 12 +++

Re: [Qemu-devel] [PATCH v3 1/6] audio: use pkg-config

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 12:20 PM, Gerd Hoffmann wrote: > Use pkg-config to probe for alsa and pulseaudio. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 39 +-- > 1 file changed, 13 insertions(+), 26 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2] audio: fix pc speaker init

2019-01-24 Thread Philippe Mathieu-Daudé
Hi Gerd, On 1/24/19 12:08 PM, Gerd Hoffmann wrote: > Get rid of the pcspk_state global, allow pc speaker > be added using "-device isa-pcspk". It was not easy to figure what you changed since the discussion on the v1, but I finally got it: 2 spaces were removed to please checkpatch/patchew. > Si

Re: [Qemu-devel] [PATCH v2 3/4] configure: Let SDL support be optional on OpenBSD

2019-01-24 Thread Gerd Hoffmann
> sdl) > if test "$sdl" = "no"; then > -error_exit "sdl not found or disabled, can not use sdl audio driver" > +echo "WARN: sdl not found or disabled, can not use sdl audio driver" > +audio_drv_list=$(echo "$audio_drv_list" | sed -e 's/sdl *//g') Busy tackling tha

[Qemu-devel] [PATCH v3 3/6] audio: use try-sdl for openbsd

2019-01-24 Thread Gerd Hoffmann
Fixes the openbsd build failure with SDL disabled. Signed-off-by: Gerd Hoffmann --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6a2aa3b533..1eff5946f6 100755 --- a/configure +++ b/configure @@ -829,7 +829,7 @@ NetBSD) OpenBSD) bsd

[Qemu-devel] [PATCH v3 5/6] audio: error message tweak

2019-01-24 Thread Gerd Hoffmann
Only print a message about the failed driver initialization in case it was the driver explicitly requested by the user via QEMU_AUDIO_DRV=$drv. Signed-off-by: Gerd Hoffmann --- audio/audio.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/audio/audio.c b/audio/au

[Qemu-devel] [PATCH v3 4/6] audio: check for pulseaudio daemon pidfile

2019-01-24 Thread Gerd Hoffmann
Check whenever the pulseaudio daemon pidfile is present before trying to initialize the pulseaudio backend. Just return NULL if that is not the case, so qemu will check the next backend in line. In case the user explicitly configured a non-default pulseaudio server skip the check. Signed-off-by:

[Qemu-devel] [PATCH v3 1/6] audio: use pkg-config

2019-01-24 Thread Gerd Hoffmann
Use pkg-config to probe for alsa and pulseaudio. Signed-off-by: Gerd Hoffmann --- configure | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/configure b/configure index 8f312ac3e2..5fcd0f4795 100755 --- a/configure +++ b/configure @@ -

[Qemu-devel] [PATCH v3 6/6] audio: probe audio drivers by default

2019-01-24 Thread Gerd Hoffmann
Add the drivers listed in audio_possible_drivers to audio_drv_list, using the try-* variants. That way the probable drivers are compiled by default if possible. Additioal tweaks: linux: reorder to: pa alsa sdl oss. *bsd: drop pa. Signed-off-by: Gerd Hoffmann --- configure | 14 +++-

[Qemu-devel] [PATCH v3 2/6] audio: allow optional audio drivers.

2019-01-24 Thread Gerd Hoffmann
For those audio drivers which can be probed (sdl, alsa, pulse) add a try-$name variants. Unlike the variants without try- prefix they will not error out on probe failure, the driver will be dropped from the list instead. Mainly useful for the audio_drv_list default values. Signed-off-by: Gerd Ho

[Qemu-devel] [PATCH v3 0/6] audio: rework driver probing.

2019-01-24 Thread Gerd Hoffmann
v3: * drop pa driver for *bsd. * codestyle fixes. Gerd Hoffmann (6): audio: use pkg-config audio: allow optional audio drivers. audio: use try-sdl for openbsd audio: check for pulseaudio daemon pidfile audio: error message tweak audio: probe audio drivers by default configure

Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage

2019-01-24 Thread Gerd Hoffmann
Hi, > So, I think with the first part the only open issue is whenever we go > with the nested types (i.e. patch #1 as-is) or not. Given that the > one-element-structs added in that patch will get additional fields I > think the nesting makes sense. Spoke too soon: scripts/checkpatch.pl flags a

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Pierre Morel
On 24/01/2019 11:19, Cornelia Huck wrote: On Thu, 24 Jan 2019 11:08:02 +0100 Pierre Morel wrote: On 23/01/2019 11:21, Cornelia Huck wrote: On Tue, 22 Jan 2019 19:33:46 +0100 Halil Pasic wrote: On Mon, 21 Jan 2019 12:03:51 +0100 Cornelia Huck wrote: --- a/drivers/s390/cio/vfio_ccw_p

[Qemu-devel] [PATCH v2] audio: fix pc speaker init

2019-01-24 Thread Gerd Hoffmann
Get rid of the pcspk_state global, allow pc speaker be added using "-device isa-pcspk". Signed-off-by: Gerd Hoffmann --- hw/audio/pcspk.c | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index 908696d483

Re: [Qemu-devel] [PATCH v2 2/5] pflash: flush rom device memory region

2019-01-24 Thread Philippe Mathieu-Daudé
Hi Stefan, On 1/23/19 10:22 PM, Stefan Hajnoczi wrote: > pflash devices should mark the memory region dirty and invalidate TBs > after directly writing to the RAM backing the ROM device. > > Note that pflash_cfi01_get_memory() is used by several machine types to > populate ROM contents directly.

[Qemu-devel] [PATCH v2 2/3] KVM: MMU: introduce kvm_mmu_write_protect_all_pages

2019-01-24 Thread Zhuangyanying
From: Xiao Guangrong The original idea is from Avi. kvm_mmu_write_protect_all_pages() is extremely fast to write protect all the guest memory. Comparing with the ordinary algorithm which write protects last level sptes based on the rmap one by one, it just simply updates the generation number to

[Qemu-devel] [PATCH v2 3/3] KVM: MMU: fast cleanup D bit based on fast write protect

2019-01-24 Thread Zhuangyanying
From: Zhuang Yanying When live-migration with large-memory guests, vcpu may hang for a long time while starting migration, such as 9s for 2T (linux-5.0.0-rc2+qemu-3.1.0). The reason is memory_global_dirty_log_start() taking too long, and the vcpu is waiting for BQL. The page-by-page D bit clearup

[Qemu-devel] [PATCH v2 1/3] KVM: MMU: introduce possible_writable_spte_bitmap

2019-01-24 Thread Zhuangyanying
From: Xiao Guangrong It is used to track possible writable sptes on the shadow page on which the bit is set to 1 for the sptes that are already writable or can be locklessly updated to writable on the fast_page_fault path, also a counter for the number of possible writable sptes is introduced to

[Qemu-devel] [PATCH v2 0/3] KVM: MMU: fast cleanup D bit based on fast write protect

2019-01-24 Thread Zhuangyanying
From: Zhuang yanying When live-migration with large-memory guests, vcpu may hang for a long time while starting migration, such as 9s for 2T (linux-5.0.0-rc2+qemu-3.1.0). The reason is memory_global_dirty_log_start() taking too long, and the vcpu is waiting for BQL. The page-by-page D bit clearup

Re: [Qemu-devel] Aborts in iotest 169

2019-01-24 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 24.01.2019 13:10, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > >> 24.01.2019 12:29, Vladimir Sementsov-Ogievskiy wrote: > >>> 23.01.2019 18:48, Max Reitz wrote: > Hi, > >>

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Daniel P . Berrangé
On Thu, Jan 24, 2019 at 10:30:23AM +, Daniel P. Berrangé wrote: > On Thu, Jan 24, 2019 at 10:11:55AM +, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 07:53:46PM +, Dr. David Alan Gilbert wrote: > > > Do you mean the: > > > > > > /* send a qmp command to guarantee that 'conn

Re: [Qemu-devel] [RFC PATCH v4 16/44] hw/alpha/Makefile.objs: Create CONFIG_* for alpha

2019-01-24 Thread Paolo Bonzini
On 24/01/19 10:09, Thomas Huth wrote: > 2) Since this series is about adding a Kconfig-style system to QEMU, > there might be other CONFIG switches that depend on this one later, e.g. > for the x86 machines, a later patch adds: > > config ACPI_NVDIMM > bool > default y > depends on

Re: [Qemu-devel] [PATCH] tests/vm: move images to subdirectory

2019-01-24 Thread Philippe Mathieu-Daudé
Hi Gerd, On 1/24/19 11:25 AM, Gerd Hoffmann wrote: > It's easier to move around the images then, by replacing the > subdirectory with a symlink. Allows to share the images between > multiple qemu checkouts for example. Good idea! > > Signed-off-by: Gerd Hoffmann > --- > tests/vm/.gitignore

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 24.01.2019 um 10:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 23.01.2019 18:48, Max Reitz wrote: > > > Hi, > > > > > > When running 169 in parallel (e.g. like so: > > > > > > $ while TEST_DIR=/tmp/t0 ./check -T -qcow2 169; do; done > > > $ while

Re: [Qemu-devel] 'sys_rawio' selinux alarm triggered while doing SCSI reservation inside the guest

2019-01-24 Thread Paolo Bonzini
On 24/01/19 11:26, Stefan Hajnoczi wrote: > On Thu, Jan 24, 2019 at 01:32:49AM +, Zhangbo (Oscar) wrote: >> When performing SCSI reservation inside the guest, 'sys_rawio' selinux alarm >> is triggered, shown as below: >> "type=AVC msg=audit(1548231520.416:8086): avc: denied { sys_rawio } for

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Kevin Wolf
Am 24.01.2019 um 11:32 hat Vladimir Sementsov-Ogievskiy geschrieben: > 24.01.2019 13:15, Kevin Wolf wrote: > > Am 24.01.2019 um 10:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 23.01.2019 18:48, Max Reitz wrote: > >>> Hi, > >>> > >>> When running 169 in parallel (e.g. like so: > >>> > >>> $

Re: [Qemu-devel] [PATCH] audio: fix pc speaker init

2019-01-24 Thread Gerd Hoffmann
> > +static int pcspk_audio_init(ISABus *bus) > > +{ > > +isa_create_simple (bus, TYPE_PC_SPEAKER); > > +return 0; > > Previously we had soundhw_init() calling pcspk_audio_init() and ignore > failures. Now since you use isa_create_simple() which calls > qdev_init_nofail(), failure will dir

[Qemu-devel] [PATCH] target/m68k: Fix LGPL information in the file headers

2019-01-24 Thread Thomas Huth
It's either "GNU *Library* General Public version 2" or "GNU Lesser General Public version *2.1*", but there was no "version 2.0" of the "Lesser" library. So assume that version 2.1 is meant here. Also some files mentioned the GPL instead of the LGPL after declaring that the files are licensed unde

Re: [Qemu-devel] [PATCH] scsi-generic: avoid possible out-of-bounds access to r->buf

2019-01-24 Thread Kevin Wolf
Am 11.01.2019 um 17:45 hat Paolo Bonzini geschrieben: > Whenever the allocation length of a SCSI request is shorter than the size of > the > VPD page list, page_idx is used blindly to index into r->buf. Even though > the stores in the insertion sort are protected against overflows, the same is >

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
24.01.2019 13:15, Kevin Wolf wrote: > Am 24.01.2019 um 10:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 23.01.2019 18:48, Max Reitz wrote: >>> Hi, >>> >>> When running 169 in parallel (e.g. like so: >>> >>> $ while TEST_DIR=/tmp/t0 ./check -T -qcow2 169; do; done >>> $ while TEST_DIR=/tmp/t1

[Qemu-devel] [PULL 3/3] qemu-coroutine-sleep: drop CoSleepCB

2019-01-24 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Drop CoSleepCB structure. It's actually unused. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20190122143113.20331-1-vsement...@virtuozzo.com Signed-off-by: Stefan Hajnoczi --- util/qemu-coroutine-sleep.c | 27 ++- 1 file ch

Re: [Qemu-devel] [PATCH] hw/i386/pc.c: fix one typo in function name

2019-01-24 Thread Laurent Vivier
On 24/01/2019 08:36, Wei Yang wrote: > Rename pc_get_hotpug_handler to pc_get_hotplug_handler. > > No functional change. > > Signed-off-by: Wei Yang > --- > hw/i386/pc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 115bc2825c.

Re: [Qemu-devel] [PATCH v2 5/5] vfio-ccw: add handling for async channel instructions

2019-01-24 Thread Halil Pasic
On Thu, 24 Jan 2019 11:06:37 +0100 Cornelia Huck wrote: > On Wed, 23 Jan 2019 16:51:48 +0100 > Halil Pasic wrote: > > > On Mon, 21 Jan 2019 12:03:54 +0100 > > Cornelia Huck wrote: > > > > > Add a region to the vfio-ccw device that can be used to submit > > > asynchronous I/O instructions. ssc

[Qemu-devel] [PULL 0/1] Ui 20190124 patches

2019-01-24 Thread Gerd Hoffmann
The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request' into staging (2019-01-23 17:57:47 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20190124-pu

Re: [Qemu-devel] 'sys_rawio' selinux alarm triggered while doing SCSI reservation inside the guest

2019-01-24 Thread Stefan Hajnoczi
On Thu, Jan 24, 2019 at 01:32:49AM +, Zhangbo (Oscar) wrote: > When performing SCSI reservation inside the guest, 'sys_rawio' selinux alarm > is triggered, shown as below: > "type=AVC msg=audit(1548231520.416:8086): avc: denied { sys_rawio } for > pid=30357 comm="worker" capability=17 > scon

Re: [Qemu-devel] [RFC PATCH] ui/egl: Silent '__HAIKU__ undefined' warnings on OpenBSD 6.1

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 3:00 AM, Kamil Rytarowski wrote: > On 24.01.2019 02:36, Philippe Mathieu-Daudé wrote: >> OpenBSD display various warnings about the use of an undefined __HAIKU__: >> > > Please report it to OpenBSD and/or 3rd party libs. It's just a warning > in public headers, not an issue on the qemu

[Qemu-devel] [PATCH] tests/vm: move images to subdirectory

2019-01-24 Thread Gerd Hoffmann
It's easier to move around the images then, by replacing the subdirectory with a symlink. Allows to share the images between multiple qemu checkouts for example. Signed-off-by: Gerd Hoffmann --- tests/vm/.gitignore | 1 + tests/vm/Makefile.include | 11 ++- 2 files changed, 7 ins

Re: [Qemu-devel] [RFC PATCH] ui/egl: Silent '__HAIKU__ undefined' warnings on OpenBSD 6.1

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 11:11 AM, Peter Maydell wrote: > On Thu, 24 Jan 2019 at 02:03, Brad Smith wrote: >> >> https://cgit.freedesktop.org/mesa/mesa/commit/include/EGL/eglplatform.h?id=f744c6c1e28fe363474550b94af42a8b7fc1c755 >> >> Unfortunately that issue has only been fixed very recently. >> >> There is a p

[Qemu-devel] [PULL 1/3] throttle-groups: fix restart coroutine iothread race

2019-01-24 Thread Stefan Hajnoczi
The following QMP command leads to a crash when iothreads are used: { 'execute': 'device_del', 'arguments': {'id': 'data'} } The backtrace involves the queue restart coroutine where tgm->throttle_state is a NULL pointer because throttle_group_unregister_tgm() has already been called: (gdb) b

[Qemu-devel] [PULL 0/3] Block patches

2019-01-24 Thread Stefan Hajnoczi
The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request' into staging (2019-01-23 17:57:47 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-reques

[Qemu-devel] [PULL 1/1] input-linux: customizable grab toggle keys

2019-01-24 Thread Gerd Hoffmann
From: Ryan El Kochta This patch adds a new option to the input-linux object: grab-toggle=[key-combo] The key combination can be one of the following: * ctrl-ctrl * alt-alt * meta-meta * scrolllock * ctrl-scrolllock The user can pick any of these key combinations. The VM's grab of the evdev de

Re: [Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-24 Thread David Kozub
On Wed, 23 Jan 2019, John Snow wrote: On 1/23/19 5:39 PM, David Kozub wrote: On Thu, 17 Jan 2019, John Snow wrote: I think SG_IO IOCTL allows one to send a single ATA command and the call blocks until the request is processed. The problem(?) with this is that you don't get to choose the AT

Re: [Qemu-devel] [PATCH] qemu-coroutine-sleep: drop CoSleepCB

2019-01-24 Thread Stefan Hajnoczi
On Tue, Jan 22, 2019 at 05:31:13PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Drop CoSleepCB structure. It's actually unused. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > util/qemu-coroutine-sleep.c | 27 ++- > 1 file changed, 10 insertions(+), 17 deletions(-

Re: [Qemu-devel] [PATCH 4/4] [RfC] audio: probe audio drivers by default

2019-01-24 Thread Kamil Rytarowski
On 24.01.2019 07:38, Gerd Hoffmann wrote: > Hi, > >>> https://xkcd.com/927/ >> >> There is a different context on BSD than on Linux. We can choose one >> solution and switch to it literally all the software keeping everything >> in a single ports tree. >> >> This is what happened on OpenBSD. >>

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Daniel P . Berrangé
On Thu, Jan 24, 2019 at 10:11:55AM +, Daniel P. Berrangé wrote: > On Wed, Jan 23, 2019 at 07:53:46PM +, Dr. David Alan Gilbert wrote: > > * Jason Wang (jasow...@redhat.com) wrote: > > > > > > On 2019/1/22 上午2:56, Peter Maydell wrote: > > > > On Thu, 17 Jan 2019 at 09:46, Jason Wang wrote:

Re: [Qemu-devel] [PULL 0/8] target/xtensa queue

2019-01-24 Thread Peter Maydell
On Tue, 22 Jan 2019 at 18:50, Max Filippov wrote: > > Hi Peter, > > please pull the following batch of updates for target/xtensa: > > The following changes since commit 32a1a94dd324d33578dca1dc96d7896a0244d768: > > Update version for v3.1.0 release (2018-12-11 17:18:37 +) > > are available i

Re: [Qemu-devel] [PULL] RISC-V Updates for 3.2, Part 2

2019-01-24 Thread Peter Maydell
On Thu, 24 Jan 2019 at 02:53, Palmer Dabbelt wrote: > > On Mon, 14 Jan 2019 04:40:06 PST (-0800), Peter Maydell wrote: > > Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 > > for any user-visible changes. > > Thanks for the reminder :). I have an account now so the update shoul

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Pierre Morel
On 23/01/2019 11:21, Cornelia Huck wrote: On Tue, 22 Jan 2019 19:33:46 +0100 Halil Pasic wrote: On Mon, 21 Jan 2019 12:03:51 +0100 Cornelia Huck wrote: --- a/drivers/s390/cio/vfio_ccw_private.h +++ b/drivers/s390/cio/vfio_ccw_private.h @@ -28,6 +28,7 @@ * @mdev: pointer to the mediated d

[Qemu-devel] [PULL 2/3] iotests: add 238 for throttling tgm unregister iothread segfault

2019-01-24 Thread Stefan Hajnoczi
Hot-unplug a scsi-hd using an iothread. The previous patch fixes a segfault in this scenario. This patch adds a regression test. Suggested-by: Alberto Garcia Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Message-id: 20190114133257.30299-3-stefa...@redhat

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Cornelia Huck
On Wed, 23 Jan 2019 14:30:51 +0100 Halil Pasic wrote: > On Wed, 23 Jan 2019 11:21:12 +0100 > Cornelia Huck wrote: > > > On Tue, 22 Jan 2019 19:33:46 +0100 > > Halil Pasic wrote: > > > > > On Mon, 21 Jan 2019 12:03:51 +0100 > > > Cornelia Huck wrote: > > > > > > > --- a/drivers/s390/cio/

Re: [Qemu-devel] [PATCH] block: Apply auto-read-only for ro-whitelist drivers

2019-01-24 Thread Stefan Hajnoczi
On Tue, Jan 22, 2019 at 01:19:26PM +0100, Kevin Wolf wrote: > If QEMU was configured with a driver in --block-drv-ro-whitelist, trying > to use that driver read-write resulted in an error message even if > auto-read-only=on was set. > > Consider auto-read-only=on for the whitelist checking and use

Re: [Qemu-devel] Aborts in iotest 169

2019-01-24 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 24.01.2019 12:29, Vladimir Sementsov-Ogievskiy wrote: > > 23.01.2019 18:48, Max Reitz wrote: > >> Hi, > >> > >> When running 169 in parallel (e.g. like so: > >> > >> $ while TEST_DIR=/tmp/t0 ./check -T -qcow2 169; do; done > >> $ wh

Re: [Qemu-devel] Aborts in iotest 169

2019-01-24 Thread Vladimir Sementsov-Ogievskiy
24.01.2019 13:10, Dr. David Alan Gilbert wrote: > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: >> 24.01.2019 12:29, Vladimir Sementsov-Ogievskiy wrote: >>> 23.01.2019 18:48, Max Reitz wrote: Hi, When running 169 in parallel (e.g. like so: $ while TEST_DI

Re: [Qemu-devel] [PATCH v2 5/5] vfio-ccw: add handling for async channel instructions

2019-01-24 Thread Cornelia Huck
On Wed, 23 Jan 2019 16:51:48 +0100 Halil Pasic wrote: > On Mon, 21 Jan 2019 12:03:54 +0100 > Cornelia Huck wrote: > > > Add a region to the vfio-ccw device that can be used to submit > > asynchronous I/O instructions. ssch continues to be handled by the > > existing I/O region; the new region h

<    1   2   3   4   >