[Qemu-devel] [Bug 1525123] Re: USB assert failure on hcd-uhci.c

2019-01-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525123 Title: USB assert

[Qemu-devel] [Bug 1523811] Re: USB assert failure on dev-storage.c

2019-01-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1523811 Title: USB assert

Re: [Qemu-devel] [PATCH 2/4] target/openrisc: Fix LGPL version number

2019-01-26 Thread Stafford Horne
On Wed, Jan 23, 2019 at 03:08:54PM +0100, Thomas Huth wrote: > It's either "GNU *Library* General Public version 2" or "GNU Lesser > General Public version *2.1*", but there was no "version 2.0" of the > "Lesser" library. So assume that version 2.1 is meant here. > > Cc: Stafford Horne >

[Qemu-devel] [PATCH] target/riscv: fix counter-enable checks in ctr()

2019-01-26 Thread Xi Wang
Access to a counter in U-mode is permitted only if the corresponding bit is set in both mcounteren and scounteren. The current code ignores mcounteren and checks scounteren only for U-mode access. Signed-off-by: Xi Wang --- target/riscv/csr.c | 12 +--- 1 file changed, 9 insertions(+),

[Qemu-devel] [PATCH] target/xtensa: drop function xtensa_timer_irq

2019-01-26 Thread Max Filippov
It's a one-liner used in a single place, move its implementation there and remove its declaration. Signed-off-by: Max Filippov --- hw/xtensa/pic_cpu.c | 7 +-- target/xtensa/cpu.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/xtensa/pic_cpu.c b/hw/xtensa/pic_cpu.c

[Qemu-devel] [PATCH] target/xtensa: rearrange access to external interrupts

2019-01-26 Thread Max Filippov
Replace xtensa_get_extint that returns single external IRQ descriptor with xtensa_get_extints that returns a vector of all external IRQs. Signed-off-by: Max Filippov --- hw/xtensa/pic_cpu.c | 24 +++- hw/xtensa/xtfpga.c | 8 +--- target/xtensa/cpu.h | 5 +++-- 3 files

Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-26 Thread Samuel Thibault
(Which I'll fold as appropriate within Marc-André's patch series) Samuel Thibault, le dim. 27 janv. 2019 02:51:13 +0100, a ecrit: > Signed-off-by: Samuel Thibault > --- > slirp/ip.h | 6 -- > slirp/ip6.h | 6 -- > slirp/ip6_icmp.h | 12 +++- > slirp/util.h | 25

[Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-26 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/ip.h | 6 -- slirp/ip6.h | 6 -- slirp/ip6_icmp.h | 12 +++- slirp/util.h | 25 + 4 files changed, 40 insertions(+), 9 deletions(-) diff --git a/slirp/ip.h b/slirp/ip.h index 2baeeb9a3a..77182e61a9

Re: [Qemu-devel] [PATCH 1/4] xive: add a get_tctx() method to the XiveRouter

2019-01-26 Thread David Gibson
On Thu, Jan 17, 2019 at 09:12:36AM +0100, Greg Kurz wrote: 65;5403;1c> On Thu, 17 Jan 2019 08:53:24 +0100 > Cédric Le Goater wrote: > > > It provides a mean to retrieve the XiveTCTX of a CPU. This will become > > necessary with future changes which move the interrupt presenter > > object

Re: [Qemu-devel] [PATCH v2 0/8] target/ppc: remove various endian hacks from int_helper.c

2019-01-26 Thread David Gibson
On Mon, Jan 21, 2019 at 05:15:20AM +, Mark Cave-Ayland wrote: > On 20/01/2019 20:28, David Gibson wrote: > > On Fri, Jan 18, 2019 at 01:25:37PM +, Mark Cave-Ayland wrote: > >> On 02/01/2019 02:59, David Gibson wrote: > >> > >>> On Fri, Dec 28, 2018 at 01:52:27PM +, Mark Cave-Ayland

Re: [Qemu-devel] [PATCH 2/4] ppc/pnv: introduce a CPU machine_data

2019-01-26 Thread David Gibson
On Thu, Jan 17, 2019 at 09:13:02AM +0100, Greg Kurz wrote: > On Thu, 17 Jan 2019 08:53:25 +0100 > Cédric Le Goater wrote: > > > Include the interrupt presenter under the machine_data as we plan to > > remove it from under PowerPCCPU > > > > Signed-off-by: Cédric Le Goater > > --- > >

Re: [Qemu-devel] [PATCH 3/4] spapr: move the interrupt presenters under machine_data

2019-01-26 Thread David Gibson
On Thu, Jan 17, 2019 at 09:14:26AM +0100, Greg Kurz wrote: > On Thu, 17 Jan 2019 08:53:26 +0100 > Cédric Le Goater wrote: > > > Next step is to remove them from under the PowerPCCPU > > > > Signed-off-by: Cédric Le Goater > > --- > > Reviewed-by: Greg Kurz Applied, thanks. > > >

Re: [Qemu-devel] [PATCH v1] spapr/pci: Fix primary bus number for PCI bridges

2019-01-26 Thread David Gibson
On Thu, Jan 24, 2019 at 01:48:36PM +1100, Alexey Kardashevskiy wrote: > > > On 23/01/2019 19:24, David Hildenbrand wrote: > > While looking at the s390x implementation, looks like spapr has a > > similar BUG when building the topology. > > > > The primary bus number corresponds always to the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-26 Thread David Gibson
On Thu, Jan 24, 2019 at 06:20:02PM +1100, Alexey Kardashevskiy wrote: > > > On 23/01/2019 04:01, Fabiano Rosas wrote: > > These will be used to let GDB know about PPC's Special Purpose > > Registers (SPR). > > > > They take an index based on the order the registers appear in the XML > > file

Re: [Qemu-devel] [PATCH 26/27] slirp: pass opaque to all callbacks

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:58 +0400, a ecrit: > This is friendlier for FFI bindings. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 27/27] slirp: API is extern C

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:59 +0400, a ecrit: > Make it possible to use headers easily with C++ projects. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 00/27] slirp: make it again a standalone project (part 2)

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le ven. 18 janv. 2019 15:02:46 +0400, a ecrit: > > may want to change the API (nobody can do something perfect at first > > try), and when that breaks qemu build it would nasty if people couldn't > > just disable libslirp usage to get qemu built for needs which don't > > require

Re: [Qemu-devel] [PATCH 25/27] slirp: use polling callbacks, drop glib requirement

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:57 +0400, a ecrit: > It would be legitimate to use libslirp without glib. Let's > add_poll/get_revents pair of callbacks to provide the same > functionality. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 24/27] slirp: remove slirp_instances list

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:56 +0400, a ecrit: > Now that polling is done per-instance, we don't need a global list of > slirp instances. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 23/27] slirp: replace global polling with per-instance & notifier

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:55 +0400, a ecrit: > Remove hard-coded dependency on slirp in main-loop, and use a "poll" > notifier instead. The notifier is registered per slirp instance. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 22/27] slirp: improve send_packet() callback

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:54 +0400, a ecrit: > Use a more descriptive name for the callback. > > Reuse the SlirpWriteCb type. Wrap it to check that all data has been written. > > Return a ssize_t for potential error handling and data-loss reporting. > Signed-off-by:

Re: [Qemu-devel] [PATCH 21/27] slirp: prefer c99 types over BSD kind

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:53 +0400, a ecrit: > Replace: > - u_char -> uint8_t > - u_short -> uint16_t > - u_long -> uint32_t > - u_int -> unsigned > - caddr_t -> char * > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 20/27] slirp: replace remaining qemu headers dependency

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:52 +0400, a ecrit: > Except for the migration code which is gated by WITH_QEMU, only > include our own headers, so libslirp can be built standalone. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 19/27] slirp: replace qemu qtailq with slirp own copy

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:51 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 18/27] slirp: replace net/eth.h inclusion with own defines

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:50 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 17/27] slirp: remove now useless QEMU headers inclusions

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:49 +0400, a ecrit: > Some of those could have been squashed earlier, but it is easier to do > it all here. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 16/27] slirp: remove qemu timer.h dependency

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:48 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 14/27] slirp: improve windows headers inclusion

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:46 +0400, a ecrit: > Our API usage requires Vista, set WIN32_LEAN_AND_MEAN to fix a number > of issues (winsock2.h include order for ex, which is better to include > first for legacy reasons). > > While at it, group redundants #ifndef _WIN32 blocks.

Re: [Qemu-devel] [PATCH 15/27] slirp: add slirp own version of pstrcpy

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:47 +0400, a ecrit: > Remove a dependency on qemu util. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 13/27] slirp: do not include qemu headers in libslirp.h public API header

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:45 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 12/27] slirp: move QEMU state saving to a separate unit

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:44 +0400, a ecrit: > Make state saving optional: this will allow to build SLIRP without > QEMU. (eventually, the vmstate helpers will be extracted, so an > external project & process could save its state) > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 11/27] slirp: replace qemu_notify_event() with a callback

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:43 +0400, a ecrit: > Introduce a SlirpCb callback to kick the main io-thread. > > Add an intermediary sodrop() function that will call SlirpCb.notify > callback when sbdrop() returns true. > > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 10/27] slirp: add unregister_poll_fd() callback

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:42 +0400, a ecrit: > Add a counter-part to register_poll_fd() for completeness. > > (so far, register_poll_fd() is called only on struct socket fd) > > Suggested-by: Paolo Bonzini > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 09/27] slirp: replace qemu_set_nonblock()

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:41 +0400, a ecrit: > Replace qemu_set_nonblock() with slirp_set_nonblock() > > qemu_set_nonblock() does some event registration with the main > loop. Add a new callback register_poll_fd() for that reason. > > Always build the fd-register stub, to

Re: [Qemu-devel] [PATCH 08/27] slirp: replace most qemu socket utilities with slirp own version

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:40 +0400, a ecrit: > qemu_set_nonblock() is slightly more problematic and will be dealt > with in a separate patch. > > Signed-off-by: Marc-André Lureau Applied, I just added a -DWITH_QEMU in the Makefile, for inet_aton, thanks!

Re: [Qemu-devel] [PATCH 06/27] slirp: replace trace functions with DEBUG calls

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:38 +0400, a ecrit: > Remove a dependency on QEMU. Use the existing logging facilities. > Set SLIRP_DEBUG=tftp to get tftp log. > > Signed-off-by: Marc-André Lureau Applied with just an additional G_UNLIKELY, thanks!

Re: [Qemu-devel] [PATCH 07/27] slirp: replace QEMU_PACKED with SLIRP_PACKED

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:39 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied except the ones which are removed in the other thread, thanks!

Re: [Qemu-devel] [PATCH 05/27] slirp: add callbacks for timer

2019-01-26 Thread Samuel Thibault
Applied too, but Marc-André Lureau, le jeu. 17 janv. 2019 15:43:37 +0400, a ecrit: > +/* Create a new timer with the given callback and opaque data */ > +void *(*timer_new)(SlirpTimerCb cb, void *opaque); > +/* Remove and free a timer */ > +void (*timer_free)(void *timer); > +

Re: [Qemu-devel] [PATCH 04/27] net/slirp: fix leaks on forwaring rule registration error

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:36 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 03/27] net/slirp: free forwarding rules on cleanup

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:35 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied, thanks!

Re: [Qemu-devel] [PATCH 02/27] net/slirp: simplify checking for cmd: prefix

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:34 +0400, a ecrit: > Signed-off-by: Marc-André Lureau It's not strictly the same (g_str_has_prefix doesn't test that there are characters after the prefix), but that should be fine, applied, thanks!

Re: [Qemu-devel] [PATCH 01/27] slirp: generalize guestfwd with a callback based approach

2019-01-26 Thread Samuel Thibault
Marc-André Lureau, le jeu. 17 janv. 2019 15:43:33 +0400, a ecrit: > Instead of calling into QEMU chardev directly, and mixing it with > slirp_add_exec() handling, add a new function slirp_add_guestfwd() > which takes a write callback. > > Signed-off-by: Marc-André Lureau applied, thanks!

[Qemu-devel] Crash when booting KDE Neon using qxl-vga

2019-01-26 Thread Leonardo Soares Müller
With QEMU version 3.1.50 (v3.1.0-1218-gad7a21e812-dirty) (commit ad7a21e81231ae64540310384fb0f87ac8758b02) on Xubuntu 18.04 host, a KDE Neon guest is crashing on boot. The QEMU command line is: gdb -q -ex "set pagination off" -ex "set print thread-events off" -ex "handle SIGUSR1 nostop nopass

[Qemu-devel] [PULL 2/3] slirp: Avoid marking naturally packed structs as QEMU_PACKED

2019-01-26 Thread Samuel Thibault
From: Peter Maydell Various ipv6 structs in the slirp headers are marked QEMU_PACKED, but they are actually naturally aligned and will have no padding in them. Instead of marking them with the 'packed' attribute, assert at compile time that they are the size we expect. This allows us to take the

[Qemu-devel] [PULL 0/3] slirp updates

2019-01-26 Thread Samuel Thibault
The following changes since commit ad7a21e81231ae64540310384fb0f87ac8758b02: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-01-25 17:22:20 +) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git

[Qemu-devel] [PULL 3/3] slirp: Don't mark struct ipq or struct ipasfrag as packed

2019-01-26 Thread Samuel Thibault
From: Peter Maydell There is no reason to mark the struct ipq and struct ipasfrag as packed: they are naturally aligned anyway, and are not representing any on-the-wire packet format. Indeed they vary in size depending on the size of pointers on the host system, because the 'struct qlink'

[Qemu-devel] [PULL 1/3] slirp: Avoid unaligned 16bit memory access

2019-01-26 Thread Samuel Thibault
pkt parameter may be unaligned, so we must access it byte-wise. This fixes sparc64 host SIGBUS during pxe boot. Signed-off-by: Samuel Thibault Reviewed-by: Richard Henderson --- slirp/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/slirp.c b/slirp/slirp.c

Re: [Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings

2019-01-26 Thread Samuel Thibault
Hello, Peter Maydell, le mar. 22 janv. 2019 18:18:20 +, a ecrit: > These patches fix the clang -Waddress-of-packed-member warnings > in the slirp code. Applied to my tree, thanks! Eric Blake, le mar. 22 janv. 2019 13:27:32 -0600, a ecrit: > How does this series play with the ongoing effort

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/3] target/arm: fix AArch64 virtual address space size

2019-01-26 Thread Richard Henderson
On 1/25/19 10:36 PM, Rémi Denis-Courmont wrote: > Hi, > > Le lauantaina 26. tammikuuta 2019, 1.29.27 EET Richard Henderson a écrit : >> On 1/25/19 1:49 PM, Rémi Denis-Courmont wrote: >>> From: Remi Denis-Courmont >>> >>> Since QEMU does not support the ARMv8.2-LVA, Large Virtual Address,

Re: [Qemu-devel] [PATCH v15 23/26] sched: early boot clock

2019-01-26 Thread Pavel Tatashin
On 19-01-25 21:04:10, Jon DeVree wrote: > > * KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is always set by the hypervisor > starting with Linux v2.6.35 - 371bcf646d17 ("KVM: x86: Tell the guest > we'll warn it about tsc stability") > * PVCLOCK_TSC_STABLE_BIT is set starting in Linux v3.8 but only if

[Qemu-devel] [Bug 1813406] [NEW] qemu-img convert malfunction on macOS

2019-01-26 Thread Chen Zhang
Public bug reported: On macOS 10.13.6, `qemu-img convert` failed to convert a qcow2 into a new qcow2 (for the purpose of shrinking the image). A 50GB (3.7GB allocated) qcow2 image was used as source. The qemu-img convert output was a 3.4MB file. qemu-img from HomeBrew were tested. Both 2.11.1

[Qemu-devel] [PATCH] target/ppc: Fix msync to do what hardware does

2019-01-26 Thread BALATON Zoltan
According to BookE docs, invalid bits (while undefined behaviour) should not raise exception but be ignored. This seems to be implementation dependent though and QEMU currently does what e500 CPUs do and raise exception for invalid bits. Unfortunately some versions of libstdc++ (and so all

[Qemu-devel] [Bug 1813398] Re: qemu user calls malloc after fork in multi-threaded process

2019-01-26 Thread Szabolcs Nagy
** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1813398 Title: qemu user calls malloc after

[Qemu-devel] [PATCH v3] chardev: Allow for pty path passing.

2019-01-26 Thread Paulo Neves
If a user requires a virtual serial device like provided by the pty char device, the user needs to accept the returned device name. This makes the program need to have smarts to parse or communicate with qemu to get the pty device. With this patch the program can pass the path where a symlink to

Re: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree

2019-01-26 Thread Bastian Koppelmann
On 1/26/19 12:54 AM, Palmer Dabbelt wrote: > On Tue, 22 Jan 2019 13:38:52 PST (-0800), richard.hender...@linaro.org wrote: >> On 1/22/19 1:28 AM, Bastian Koppelmann wrote: >>> Hi, >>> >>> this patchset converts the RISC-V decoder to decodetree in four major steps: >>> >>> 1) Convert 32-bit