This patch fixes shutdown of the replay process, which is terminated with
the assert when shutdown event is read from the log.
replay_finish_event reads new data_kind and therefore the value of data_kind
should be preserved to be valid at qemu_system_shutdown_request call.
Signed-off-by: Pavel
Most of IO instructions can be executed only at the end of the block in
icount mode. Therefore translator can set cpu_can_io flag when translating
the last instruction.
But when the blocks are chained, then this flag is not reset and may
remain set at the beginning of the next block.
This patch
On 31/01/19 14:21, Thomas Huth wrote:
> On 2019-01-25 11:06, Paolo Bonzini wrote:
> [...]
>> diff --git a/hw/misc/macio/Kconfig b/hw/misc/macio/Kconfig
>> new file mode 100644
>> index 000..c6caeb6
>> --- /dev/null
>> +++ b/hw/misc/macio/Kconfig
>> @@ -0,0 +1,11 @@
>> +config CUDA
>> +bool
GDB remote protocol supports two reverse debugging commands:
reverse step and reverse continue.
This patch adds support of the first one to the gdbstub.
Reverse step is intended to step one instruction in the backwards
direction. This is not possible in regular execution.
But replayed execution is
This patch introduces docs/devel/replay.txt which describes the rules
that should be followed to make virtual devices usable in record/replay mode.
Signed-off-by: Pavel Dovgalyuk
--
v9: fixed external virtual clock description (reported by Artem Pisarenko)
---
docs/devel/replay.txt | 46
This patch renames replay_get_current_step() and related variables
to make these names consistent with hmp/qmp commands.
Signed-off-by: Pavel Dovgalyuk
---
blockdev.c|2 +-
include/sysemu/replay.h |2 +-
migration/savevm.c|2 +-
replay/replay-debugging.c |
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed
the execution to the specified instruction count.
The command automatically loads nearest snapshot and replays the execution
to find the desired instruction count.
Signed-off-by: Pavel Dovgalyuk
Acked-by: Markus Armbruster
icount-based record/replay uses qemu_clock_deadline_ns_all to measure
the period until vCPU may be interrupted.
This function takes in account the virtual timers, because they belong
to the virtual devices that may generate interrupt request or affect
the virtual machine state.
However, there are
Replay is capable of recording normal BH events, but sometimes
there are single use callbacks scheduled with aio_bh_schedule_oneshot
function. This patch enables recording and replaying such callbacks.
Block layer uses these events for calling the completion function.
Replaying these calls makes
This patch removes refactoring artifacts from the replay/replay-time.c
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-time.c | 36
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/replay/replay-time.c b/replay/replay-time.c
index
On 1/31/19 7:08 AM, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia
> ---
> hmp-commands-info.hx | 14 ++
> monitor.c| 6 ++
> 2 files changed, 20 insertions(+)
Commit message should state WHY this is being added as an HMP-only
command, and does not have a QMP
This patch updates the documentation and describes usage of the reverse
debugging in QEMU+GDB.
Signed-off-by: Pavel Dovgalyuk
---
docs/replay.txt | 33 +
1 file changed, 33 insertions(+)
diff --git a/docs/replay.txt b/docs/replay.txt
index 2c2c5f6..8447fdd
This patch adds replay.json file. It will be
used for adding record/replay-related data structures and commands.
Signed-off-by: Pavel Dovgalyuk
Reviewed-by: Markus Armbruster
--
v10:
- minor changes
---
MAINTAINERS |1 +
Makefile.objs |4 ++--
This patch introduces 'info replay' monitor command and
corresponding qmp request.
These commands request the current record/replay mode, replay log file
name, and the instruction count (number of recorded/replayed
instructions). The instruction count can be used with the
replay_seek/replay_break
This patch postpones the call of 'configure_rtc' function. This call
uses host clock to configure the rtc, but host clock access should be
recorded when using icount record/replay mode. Therefore now rtc
is configured after switching record/replay mode on.
Signed-off-by: Pavel Dovgalyuk
---
This patch adds support of the reverse continue operation for gdbstub.
Reverse continue finds the last breakpoint that would happen in normal
execution from the beginning to the current moment.
Implementation of the reverse continue replays the execution twice:
to find the breakpoints that were
This patch adds an accessor function for the name of the record/replay
log file. Adding an accessor instead of making variable global,
prevents accidental modification of this variable by other modules.
Signed-off-by: Pavel Dovgalyuk
---
include/sysemu/replay.h |2 ++
replay/replay.c
Saving icount as a parameters of the snapshot allows navigation between
them in the execution replay scenario.
This information can be used for finding a specific snapshot for proceeding
the recorded execution to the specific moment of the time.
E.g., 'reverse step' action (introduced in one of
Non-empty record/replay queue prevents saving and loading the VM state,
because it includes pending bottom halves and block coroutines.
But when the new VM state is loaded, we don't have to preserve the consistency
of the current state anymore. Therefore this patch just flushes the queue
allowing
In record/replay mode bdrv queue is controlled by replay mechanism.
It does not allow saving or loading the snapshots
when bdrv queue is not empty. Stopping the VM is not blocked by nonempty
queue, but flushing the queue is still impossible there,
because it may cause deadlocks in replay mode.
After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay.c |2 ++
vl.c
This patch introduces the icount field for saving within the snapshot.
It is required for navigation between the snapshots in record/replay mode.
Signed-off-by: Pavel Dovgalyuk
Acked-by: Kevin Wolf
--
v2:
- documented format changes in docs/interop/qcow2.txt
(suggested by Eric Blake)
v10:
GDB remote protocol supports reverse debugging of the targets.
It includes 'reverse step' and 'reverse continue' operations.
The first one finds the previous step of the execution,
and the second one is intended to stop at the last breakpoint that
would happen when the program is executed
This patch introduces replay_break, replay_delete_break
qmp and hmp commands.
These commands allow stopping at the specified instruction.
It may be useful for debugging when there are some known
events that should be investigated.
replay_break command has one argument - number of instructions
The function argument rdma_dev_res is not needed as it is stored in the
backend_dev object at init.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 13 ++---
hw/rdma/rdma_backend.h | 1 -
hw/rdma/vmw/pvrdma_qp_ops.c | 3 +--
3 files changed, 7 insertions(+), 10
From: Pavel Dovgalyuk
This patch enables making snapshots with blkreplay used in
block devices.
This function is required to make bdrv_snapshot_goto without
calling .bdrv_open which is not implemented.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c |8
1 file changed, 8
From: pbonz...@redhat.com
This is a fix which was missed by patch
74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step
parameter to the replay_advance_current_step function.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-internal.c |2 +-
1 file changed, 1 insertion(+), 1
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 1 +
hw/rdma/vmw/pvrdma_main.c | 72 +++
2 files changed, 73 insertions(+)
diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h
index 167706ec2c..dc10f21ca0 100644
--- a/hw/rdma/vmw/pvrdma.h
+++
Utilize error_report for all pr_err calls and some pr_dbg that are
considered as errors.
For the remaining pr_dbg calls, the important ones were replaced by
trace points while other deleted.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c| 336 ++
From: Pavel Dovgalyuk
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk
---
vl.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
This patch updates the description of the command lines for using
record/replay with attached block devices.
Signed-off-by: Pavel Dovgalyuk
---
docs/replay.txt | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/docs/replay.txt b/docs/replay.txt
index
When device is going down free all saved MAD buffers.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 32
hw/rdma/rdma_backend.h | 1 +
2 files changed, 33 insertions(+)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index
To make code more readable move handling of locked list to a generic
functions.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 20 +--
hw/rdma/rdma_backend_defs.h | 8 ++--
hw/rdma/rdma_utils.c| 39 +
Signed-off-by: Yuval Shaia
---
hmp-commands-info.hx | 14 ++
monitor.c| 6 ++
2 files changed, 20 insertions(+)
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index cbee8b944d..32f6215619 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c| 53 ---
hw/rdma/rdma_rm.c | 6 +
hw/rdma/rdma_rm_defs.h| 21
hw/rdma/vmw/pvrdma.h | 5
hw/rdma/vmw/pvrdma_main.c | 3 +++
5 files changed, 74
Hi,
Please review the following patch-set which consist of cosmetics fixes to
device's user interface (traces, error_report and monitor) and some bug
fixes.
Thanks,
Yuval
Yuval Shaia (10):
hw/rdma: Switch to generic error reporting way
hw/rdma: Introduce locked qlist
hw/rdma: Warn when too
When QP is destroyed the backend QP is destroyed as well. This ensures
we clean all received buffer we posted to it.
However, a contexts of these buffers are still remain in the device.
Fix it by maintaining a list of buffer's context and free them when QP
is destroyed.
Signed-off-by: Yuval Shaia
To protect against CPU over utilization when guest performs unneeded
busy waiting loop on an empty CQ.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 11 +++
hw/rdma/rdma_backend.h | 2 +-
hw/rdma/rdma_rm.c | 1 +
hw/rdma/rdma_rm_defs.h | 6 +-
The function rdma_poll_cq is called from two contexts - completion
handler thread which sense new completion on backend channel and
explicitly as result of guest issuing poll_cq command.
Add lock to protect against concurrent executions.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c |
Use git archive to create tarballs of qemu and submodules instead of
cloning the repository and the submodules. This is a order of magnitude
faster because it doesn't fetch the submodules from the internet each
time the script runs.
Signed-off-by: Gerd Hoffmann
---
scripts/archive-source.sh |
The {IOE, DZE, OFE, UFE, IXE, IDE} bits in the FPSCR/FPCR are for
enabling trapped IEEE floating point exceptions (where IEEE exception
conditions cause a CPU exception rather than updating the FPSR status
bits). QEMU doesn't implement this (and nor does the hardware we're
modelling), but for
On 1/30/19 10:48 PM, Lucien Murray-Pitts wrote:
> The result is that vCont now does not recognise the case where no
> process/thread is provided after the action.
Thanks for re-sending; this one came through a lot nicer! Welcome to
the community; while a first submission can always be a bit
On Wed, 30 Jan 2019 at 03:18, Stefan Hajnoczi wrote:
>
> The following changes since commit f6b06fcceef465de0cf2514c9f76fe0192896781:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190121-pull-request'
> into staging (2019-01-23 17:57:47 +)
>
> are available in the Git
Paolo Bonzini writes:
> On 31/01/19 10:37, Markus Armbruster wrote:
>>>
Hmm, why is it okay to treat all pfl->cmd values the same when
secure=on?
>>> But doesn't matter. You just don't want MMIO mode to be active outside
>>> SMM: all that non-SMM code want to do with the flash is read
On Thu, Jan 31, 2019 at 12:12 PM Programmingkid
wrote:
> After testing a recent commit of QEMU I noticed that 256 color support is
> missing in Mac OS 9's color options. A lot of games refuse to run without
> being able to set the monitor to 256 colors. Could we have this option
> added?
>
>
The cmd() method of the QEMUQtestProtocol class sends a qtest command
to QEMU but doesn't wait for the return message ("OK", "FAIL", "ERR").
Because of this, it can return control to the caller before the
command has actually finished.
In cases like clock_step or clock_set this means that cmd()
On Thu, 31 Jan 2019 12:52:20 +0100
Cornelia Huck wrote:
> On Wed, 30 Jan 2019 19:51:27 +0100
> Halil Pasic wrote:
>
> > On Wed, 30 Jan 2019 14:22:07 +0100
> > Cornelia Huck wrote:
> >
> > > When we get a solicited interrupt, the start function may have
> > > been cleared by a csch, but we
From: mahaocong
This patch adds possibility to start mirroring with user-created-bitmap.
On full mode, mirror create a non-named-bitmap by scanning whole block-chain,
and on top mode, mirror create a bitmap by scanning the top block layer. So I
think I can copy a user-created-bitmap and use it
Paolo Bonzini writes:
> On 31/01/19 10:41, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 31/01/19 09:40, Markus Armbruster wrote:
> Maybe we should just add pflash block properties to the machine? And
> then it can create the devices if the properties are set to a
On 31/01/19 10:37, Markus Armbruster wrote:
>>
>>> Hmm, why is it okay to treat all pfl->cmd values the same when
>>> secure=on?
>> But doesn't matter. You just don't want MMIO mode to be active outside
>> SMM: all that non-SMM code want to do with the flash is read and execute
>> it, as far as
Peter Maydell writes:
> On Thu, 31 Jan 2019 at 10:24, Markus Armbruster wrote:
>> 1. Make the device model default to some "correct" configuration, even
>> if that setting is kind of arbitrary. That way, any code using new
>> style gets an "incorrect" configuration only if it actively selects
On Mon, 28 Jan 2019 at 19:43, Eduardo Habkost wrote:
>
> The following changes since commit 5f39a91dbd9a186edb999afd4d17524f4b1da14f:
>
> Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
> staging (2019-01-28 12:54:06 +)
>
> are available in the Git repository at:
>
On 01/31/19 10:37, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 31/01/19 09:33, Markus Armbruster wrote:
>>> I thought secure=on affected only writes (and so wouldn't matter with
>>> readonly=on), but I was wrong:
>>>
>>> static MemTxResult pflash_mem_read_with_attrs(void
On Wed, 30 Jan 2019 at 08:59, Hongbo Zhang wrote:
>
> On Tue, 22 Jan 2019 at 19:42, Peter Maydell wrote:
> >
> > On Fri, 7 Dec 2018 at 09:08, Hongbo Zhang wrote:
> > > +[VIRT_SECURE_MEM] = { 0x2000, 0x2000 },
> > > +[VIRT_CPUPERIPHS] = { 0x4000, 0x0008 },
On 01/31/19 10:19, Paolo Bonzini wrote:
> On 31/01/19 09:40, Markus Armbruster wrote:
>>> Maybe we should just add pflash block properties to the machine? And
>>> then it can create the devices if the properties are set to a non-empty
>>> value.
>> What exactly do you have in mind? Something
On Wed, 30 Jan 2019 18:09:31 +0100
Halil Pasic wrote:
> On Wed, 30 Jan 2019 14:22:12 +0100
> Cornelia Huck wrote:
>
> > +static void fsm_async_retry(struct vfio_ccw_private *private,
> > + enum vfio_ccw_event event)
> > +{
> > + private->cmd_region->ret_code = -EAGAIN;
On Wed, 30 Jan 2019 19:51:27 +0100
Halil Pasic wrote:
> On Wed, 30 Jan 2019 14:22:07 +0100
> Cornelia Huck wrote:
>
> > When we get a solicited interrupt, the start function may have
> > been cleared by a csch, but we still have a channel program
> > structure allocated. Make it safe to call
Hi,
Sorry for resurrecting this thread after so long but I just upgraded the host
to Qemu 3.1 and libvirt 4.10 and I'm still facing this problem.
At the moment I cannot use virtio disks (virtio-blk nor virtio-scsi) with my
guests in order to avoid this issue so as a workaround I'm using SATA
On Thu, Jan 31, 2019 at 11:19:04AM +, Peter Maydell wrote:
> On Thu, 31 Jan 2019 at 10:50, Daniel P. Berrangé wrote:
> >
> > On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> > > Hi,
> > > How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> > > installer?
The code path for booting firmware doesn't set env->boot_info. At
first sight this looks odd, so add a comment saying why we don't.
Signed-off-by: Peter Maydell
---
hw/arm/boot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index
Factor out the "boot via firmware" code path from arm_load_kernel()
into its own function.
This commit only moves code around; no semantic changes.
Signed-off-by: Peter Maydell
---
hw/arm/boot.c | 92 +++
1 file changed, 49 insertions(+), 43
Factor out the "direct kernel boot" code path from arm_load_kernel()
into its own function; this function is getting long enough that
the code flow is a bit confusing.
This commit only moves code around; no semantic changes.
We leave the "load the dtb" code in arm_load_kernel() -- this
is
The arm_boot_info struct has a skip_dtb_autoload flag: if this is
set to true by the board code then arm_load_kernel() will not
load the DTB itself, but will leave this for the board code to
do itself later. However, the check for this is done in a
code path which is only executed for the case
Fix the block comment style in arm_load_kernel() to QEMU's
current style preferences. This will allow us to do some
refactoring of this function without checkpatch complaining
about the code-motion patches.
Signed-off-by: Peter Maydell
---
hw/arm/boot.c | 30 --
1
The arm_boot_info struct has a skip_dtb_autoload flag: if this is
set to true by the board code then arm_load_kernel() will not
load the DTB itself, but will leave this for the board code to
do itself later. However, the check for this is done in a
code path which is only executed for the case
On Thu, 31 Jan 2019 at 10:50, Daniel P. Berrangé wrote:
>
> On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> > Hi,
> > How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> > installer? (and also in a standalone build to be zipped up, but that's less
> >
On Mon, 28 Jan 2019 at 19:38, Eduardo Habkost wrote:
>
> The following changes since commit 5f39a91dbd9a186edb999afd4d17524f4b1da14f:
>
> Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
> staging (2019-01-28 12:54:06 +)
>
> are available in the Git repository at:
>
After testing a recent commit of QEMU I noticed that 256 color support is
missing in Mac OS 9's color options. A lot of games refuse to run without being
able to set the monitor to 256 colors. Could we have this option added?
Thank you.
On 1/25/19 3:00 PM, Alex Bennée wrote:
> The "make check" target calls check-qtest which has the appropriate
> system binaries as dependencies so we shouldn't need to do two steps
> of make invocation. Doing it in two steps was a hangover from when our
> make check couldn't run tests in parallel.
On 1/25/19 3:00 PM, Alex Bennée wrote:
> Now the underlying basevm support passes these along we can expose
> some additional variables to our Makefile to allow more customised
> tweaking of the build. For example:
>
> make vm-build-freebsd TARGET_LIST=aarch64-softmmu \
>
On 1/25/19 3:00 PM, Alex Bennée wrote:
> This allows us to invoke the build with a custom target (for the VMs
> that use the {target} format string specifier). Currently OpenBSD is
> still hardwired due to problems running check.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe
My extremely embarassing script for getting the DLLs is as follows,
but at least it avoids a WINE dependency:
STAGING=/tmp/myqemu/
make install prefix=$STAGING
#todo: probably better to walk these dependencies in a loop, and not
use grep (but seriously, where's the mingw dumpbin)
FIRST=$(strings
On Thu, Jan 31, 2019 at 02:45:13PM +1100, Adam Baxter wrote:
> Hi,
> How do I gather and include the required DLLs (SDL, zlib etc) in the NSIS
> installer? (and also in a standalone build to be zipped up, but that's less
> important)
>
> I noticed the wiki doesn't really mention bundling
On Thu, 31 Jan 2019 at 10:24, Markus Armbruster wrote:
> 1. Make the device model default to some "correct" configuration, even
> if that setting is kind of arbitrary. That way, any code using new
> style gets an "incorrect" configuration only if it actively selects one.
I don't think that's
On 1/31/19 3:53 AM, Cleber Rosa wrote:
> On 1/22/19 5:52 AM, Philippe Mathieu-Daudé wrote:
>> On 1/17/19 7:56 PM, Cleber Rosa wrote:
>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
>>> board and verify the serial is working. One extra command added to
>>> the QEMU command
On Thu, Jan 31, 2019 at 08:41:43AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > +git archive --format tar $HEAD > "$tar_file"
> > > +test $? -ne 0 && error "failed to archive qemu"
> > > for sm in $submodules; do
> > > -git submodule update --init $sm
> > > -test $? -ne 0 && error "failed
On 1/31/19 2:34 AM, Cleber Rosa wrote:
> On 1/22/19 5:57 AM, Philippe Mathieu-Daudé wrote:
>> On 1/17/19 7:56 PM, Cleber Rosa wrote:
>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
>>> board and verify the serial is working.
>>>
>>> If mips64el is a target being built,
Peter Maydell writes:
> On Thu, 31 Jan 2019 at 08:52, Markus Armbruster wrote:
>> Lesson for the future: when we correct something, but don't dare to
>> touch (some) existing uses (being not "reasonably sure it doesn't
>> actually break guests that used to work"), we should at least have
>>
On 1/31/19 2:26 AM, Cleber Rosa wrote:
> On 1/22/19 5:19 AM, Philippe Mathieu-Daudé wrote:
>> Hi Cleber,
>>
>> On 1/17/19 7:56 PM, Cleber Rosa wrote:
>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta
>>> board and verify the serial is working.
>>>
>>> If mips64el is a target
On 1/31/19 3:37 AM, Cleber Rosa wrote:
> On 1/22/19 11:07 AM, Alex Bennée wrote:
>> Cleber Rosa writes:
>>
>>> Just like the previous tests, boots a Linux kernel on a ppc64 target
>>> using the pseries machine.
>>
>> So running this on my rather slow SynQuacer I get:
>>
>> (04/16)
>>
31.01.2019 5:26, John Snow wrote:
> It's not enough to order the kwargs for consistent QMP log output,
> we must also sort any sub-dictionaries in lists that appear as values.
>
> Reported-by: Kevin Wolf
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/236.out| 56
On 31/01/19 10:41, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 31/01/19 09:40, Markus Armbruster wrote:
Maybe we should just add pflash block properties to the machine? And
then it can create the devices if the properties are set to a non-empty
value.
>>> What
On Thu, 31 Jan 2019 at 08:52, Markus Armbruster wrote:
> Lesson for the future: when we correct something, but don't dare to
> touch (some) existing uses (being not "reasonably sure it doesn't
> actually break guests that used to work"), we should at least have
> enough sense to make "incorrect"
On Wed, 30 Jan 2019 21:36:05 -0200
Murilo Opsfelder Araujo wrote:
> The commit 7197fb4058bcb68986bae2bb2c04d6370f3e7218 ("util/mmap-alloc:
> fix hugetlb support on ppc64") fixed Huge TLB mappings on ppc64.
>
> However, we still need to consider the underlying huge page size
> during munmap()
On Thu, 31 Jan 2019 at 06:39, Thomas Huth wrote:
>
> On 2019-01-30 20:01, Palmer Dabbelt wrote:
> > On Wed, 30 Jan 2019 09:45:33 PST (-0800), ebl...@redhat.com wrote:
> >> On 1/30/19 11:35 AM, Palmer Dabbelt wrote:
> >>> The following changes since commit
> >>>
On Wed, 30 Jan 2019 21:36:04 -0200
Murilo Opsfelder Araujo wrote:
> Unfold parts of qemu_ram_mmap() for the sake of understanding, moving
> declarations to the top, and keeping architecture-specifics in the
> ifdef-else blocks. No changes in the function behaviour.
>
> Give ptr and ptr1
On Wed, 30 Jan 2019 at 08:23, Igor Mammedov wrote:
>
> On Tue, 29 Jan 2019 15:26:29 +
> Peter Maydell wrote:
> > Oh, I see now. I think this is a bug in boot.c and we should
> > fix it by making the "this is a firmware boot" code path also
> > do the arm_load_dtb() call. I'll send a patch.
>
30.01.2019 22:26, Andrey Shinkevich wrote:
>
>
> On 30/01/2019 21:24, Eric Blake wrote:
>> On 1/30/19 11:51 AM, Andrey Shinkevich wrote:
>>> In the 'Format specific information' section of the 'qemu-img info'
>>> command output, the supplemental information about existing QCOW2
[...]
>>> +##
Paolo Bonzini writes:
> On 31/01/19 09:40, Markus Armbruster wrote:
>>> Maybe we should just add pflash block properties to the machine? And
>>> then it can create the devices if the properties are set to a non-empty
>>> value.
>> What exactly do you have in mind? Something like
>>
>>
Paolo Bonzini writes:
> On 31/01/19 09:33, Markus Armbruster wrote:
>> I thought secure=on affected only writes (and so wouldn't matter with
>> readonly=on), but I was wrong:
>>
>> static MemTxResult pflash_mem_read_with_attrs(void *opaque, hwaddr addr,
>> uint64_t *value,
>>
On 30.01.19 20:52, Collin Walling wrote:
> On 1/21/19 8:42 AM, David Hildenbrand wrote:
>> PCI on s390x is really weird and how it was modeled in QEMU might not have
>> been the right choice. Anyhow, right now it is the case that:
>> - Hotplugging a PCI device will silently create a zPCI device
>>
On 31/01/19 09:40, Markus Armbruster wrote:
>> Maybe we should just add pflash block properties to the machine? And
>> then it can create the devices if the properties are set to a non-empty
>> value.
> What exactly do you have in mind? Something like
>
> -machine
On 31/01/19 09:33, Markus Armbruster wrote:
> I thought secure=on affected only writes (and so wouldn't matter with
> readonly=on), but I was wrong:
>
> static MemTxResult pflash_mem_read_with_attrs(void *opaque, hwaddr addr,
> uint64_t *value,
>
On 30.01.19 23:10, Michael S. Tsirkin wrote:
> On Wed, Jan 30, 2019 at 04:07:06PM +0100, David Hildenbrand wrote:
>> On 30.01.19 14:09, Paolo Bonzini wrote:
>>> On 30/01/19 13:35, David Hildenbrand wrote:
On 14.12.18 10:58, Paolo Bonzini wrote:
> On 12/12/18 10:57, David Hildenbrand
Am 31.01.2019 um 03:26 hat John Snow geschrieben:
> It's not enough to order the kwargs for consistent QMP log output,
> we must also sort any sub-dictionaries in lists that appear as values.
>
> Reported-by: Kevin Wolf
> Signed-off-by: John Snow
Thanks, applied to the block branch.
Kevin
Am 31.01.2019 um 00:52 hat Max Reitz geschrieben:
> Without this filter, this test sometimes fails.
>
> Signed-off-by: Max Reitz
Thanks, applied to the block branch.
Kevin
Am 31.01.2019 um 03:03 hat John Snow geschrieben:
> On 1/30/19 12:27 PM, Kevin Wolf wrote:
> > Am 14.01.2019 um 17:25 hat Eric Blake geschrieben:
> >> From: John Snow
> >>
> >> New interface, new smoke test.
> >>
> >> Signed-off-by: John Snow
> >> Reviewed-by: Vladimir Sementsov-Ogievskiy
> >>
Peter Maydell writes:
> On Wed, 30 Jan 2019 at 16:44, Laszlo Ersek wrote:
>>
>> On 01/30/19 16:24, Peter Maydell wrote:
>>
>> > Well, nobody who does anything with x86 has cared enough to
>> > make the pflash implementation actually correct.
>>
>> I feel sort of included under this umbrella,
On 2019-01-31 08:32, Yang Zhong wrote:
> From: Paolo Bonzini
>
> Make hw/vfio configurable and add new CONFIG_VFIO_* to the
> default-configs/s390x*-softmmu.mak. This allow a finer-grain
> selection of the various VFIO backends.
>
> Signed-off-by: Paolo Bonzini
> ---
>
On Thu, Jan 31, 2019 at 09:36:01AM +0100, Thomas Huth wrote:
> On 2019-01-31 08:32, Yang Zhong wrote:
> > make virt code configurable and the new CONFIG_VIRT definitions
> > added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI
> > in arm board.
>
> I think the patch description
301 - 400 of 413 matches
Mail list logo
