I haven't seend any problem about using 64 or 128. And it make much
less contention on the locks. Just change it.
Signed-off-by: Juan Quintela
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index ef1d5
On Wed 06 Feb 2019 02:00:03 PM CET, Paolo Bonzini wrote:
> On 06/02/19 13:43, Alberto Garcia wrote:
>> }
>> @@ -449,7 +451,9 @@ static void tcp_chr_disconnect(Chardev *chr)
>> SocketChardev *s = SOCKET_CHARDEV(chr);
>> bool emit_close = s->connected;
>>
>> +qemu_mutex_lock(
On 06.02.19 14:18, Igor Mammedov wrote:
> On Thu, 31 Jan 2019 15:52:25 +0100
> David Hildenbrand wrote:
>
>> On 28.01.19 15:18, Igor Mammedov wrote:
>>> On Wed, 23 Jan 2019 20:55:18 +0100
>>> David Hildenbrand wrote:
>>>
This series implements supprt for hotplug handler chaining (proposed
>
We make it supported from now on.
Signed-off-by: Juan Quintela
---
hmp.c | 10 +-
migration/migration.c | 26 +-
qapi/migration.json | 34 +-
3 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/hmp.c b
This series:
- Change page_count default to 128.
16 was really small, and it makes much less contention on mutexes to
just have bigger packets.
- Drop multifd-page_count parameter
This parameter was useful for testing, but in all my testing 128 is
good enough, no need to have an extra k
Libvirt don't want to expose (and explain it). And testing looks like
128 is good for all use cases, so just drop it.
Signed-off-by: Juan Quintela
---
hmp.c | 7 ---
migration/migration.c | 30 --
migration/migration.h | 1 -
migration/ram.c
On Wed, 23 Jan 2019 20:55:27 +0100
David Hildenbrand wrote:
> Override the device hotplug handler to properly handle the memory device
> part via virtio-pmem-pci callbacks from the machine hotplug handler and
> forward to the actual PCI bus hotplug handler.
>
> As PCI hotplug has not been proper
On Thu, 31 Jan 2019 15:52:25 +0100
David Hildenbrand wrote:
> On 28.01.19 15:18, Igor Mammedov wrote:
> > On Wed, 23 Jan 2019 20:55:18 +0100
> > David Hildenbrand wrote:
> >
> >> This series implements supprt for hotplug handler chaining (proposed
> >> by Igor), something that is necessary to t
On 2019-02-06 13:58, Cornelia Huck wrote:
> On Wed, 6 Feb 2019 13:41:33 +0100
> Thomas Huth wrote:
>
>> The license information in these files is rather confusing. The text
>> declares LGPL first, but then says that contributions after 2012 are
>> licensed under the GPL instead. How should the a
On 06/02/2019 14:15, Cornelia Huck wrote:
> On Wed, 6 Feb 2019 14:09:40 +0100
> Thomas Huth wrote:
>
>> On 2019-02-06 13:58, Cornelia Huck wrote:
>>> On Wed, 6 Feb 2019 13:41:33 +0100
>>> Thomas Huth wrote:
>>>
The license information in these files is rather confusing. The text
de
On 06.02.19 14:01, Igor Mammedov wrote:
> On Wed, 23 Jan 2019 20:55:27 +0100
> David Hildenbrand wrote:
>
>> Override the device hotplug handler to properly handle the memory device
>> part via virtio-pmem-pci callbacks from the machine hotplug handler and
>> forward to the actual PCI bus hotplug
On Wed 06 Feb 2019 01:49:02 PM CET, Daniel P. Berrangé wrote:
>> (gdb) bt
>> #0 0x5558b842902d in object_get_class (obj=0x0) at qom/object.c:860
>> #1 0x5558b84f92db in qio_channel_writev_full (ioc=0x0,
>> iov=0x7ffc355decf0, niov=1, fds=0x0, nfds=0, errp=0x0) at io/channel.c:76
>> #
On 06/02/2019 13:58, Cornelia Huck wrote:
> On Wed, 6 Feb 2019 13:41:33 +0100
> Thomas Huth wrote:
>
>> The license information in these files is rather confusing. The text
>> declares LGPL first, but then says that contributions after 2012 are
>> licensed under the GPL instead. How should the a
On Wed, Feb 06, 2019 at 01:52:59PM +0100, Paolo Bonzini wrote:
> On 06/02/19 13:49, Daniel P. Berrangé wrote:
> > On Wed, Feb 06, 2019 at 02:43:45PM +0200, Alberto Garcia wrote:
> >> There's a race condition in which the tcp_chr_read() ioc handler can
> >> close a connection that is being written t
On Wed, 6 Feb 2019 14:09:40 +0100
Thomas Huth wrote:
> On 2019-02-06 13:58, Cornelia Huck wrote:
> > On Wed, 6 Feb 2019 13:41:33 +0100
> > Thomas Huth wrote:
> >
> >> The license information in these files is rather confusing. The text
> >> declares LGPL first, but then says that contributio
On 06/02/19 13:43, Alberto Garcia wrote:
> }
> @@ -449,7 +451,9 @@ static void tcp_chr_disconnect(Chardev *chr)
> SocketChardev *s = SOCKET_CHARDEV(chr);
> bool emit_close = s->connected;
>
> +qemu_mutex_lock(&chr->chr_write_lock);
> tcp_chr_free_connection(chr);
> +
On Wed, 6 Feb 2019 13:41:33 +0100
Thomas Huth wrote:
> The license information in these files is rather confusing. The text
> declares LGPL first, but then says that contributions after 2012 are
> licensed under the GPL instead. How should the average user who just
> downloaded the release tarba
On 06/02/19 13:49, Daniel P. Berrangé wrote:
> On Wed, Feb 06, 2019 at 02:43:45PM +0200, Alberto Garcia wrote:
>> There's a race condition in which the tcp_chr_read() ioc handler can
>> close a connection that is being written to from another thread.
> Isn't the chardev only ever supposed to be rea
On Wed, Feb 06, 2019 at 02:43:45PM +0200, Alberto Garcia wrote:
> There's a race condition in which the tcp_chr_read() ioc handler can
> close a connection that is being written to from another thread.
Isn't the chardev only ever supposed to be read/written from a
single thread.
>
> Running iote
There's a race condition in which the tcp_chr_read() ioc handler can
close a connection that is being written to from another thread.
Running iotest 136 in a loop triggers this problem and crashes QEMU.
(gdb) bt
#0 0x5558b842902d in object_get_class (obj=0x0) at qom/object.c:860
#1 0x000
The license information in these files is rather confusing. The text
declares LGPL first, but then says that contributions after 2012 are
licensed under the GPL instead. How should the average user who just
downloaded the release tarball know which part is now GPL and which
is LGPL?
Looking at the
Eric Blake wrote:
> On 1/30/19 6:06 AM, Juan Quintela wrote:
>> It will be used to store the uri parameters. We want this only for
>> tcp, so we don't set it for other uris. We need it to know what port
>> is migration running.
>>
>> Signed-off-by: Juan Quintela
>>
>> +return g_strdup_
It will be used to store the uri parameters. We want this only for
tcp, so we don't set it for other uris. We need it to know what port
is migration running.
Signed-off-by: Juan Quintela
--
This used to be uri parameter, but it has so many troubles to
reproduce that it don't just make sense.
Not sharing code from precopy/unix because we have to read back the
tcp parameter.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 109 +++--
1 file changed, 104 insertions(+), 5 deletions(-
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 64 ++
1 file changed, 64 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 8352612364..b0670efde7 100644
--- a/tests/migration-test.c
+++ b/tes
In v12:
- drop multifd case (caming in next series)
- fix leak of socketaddress (eric)
- handle vsock printing correctly (eric)
Iv v11:
- Rebase to lastest
- Remove the compress test. It didin't worked really.
See my next series.
- Only patch missing review-by is the second one.
Please, consid
ping.
Finally, what about this?
25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote:
> drv_co_block_status digs bs->file for additional, more accurate search
> for hole inside region, reported as DATA by bs since 5daa74a6ebc.
>
> This accuracy is not free: assume we have qcow2 disk. Actually, q
On Wed, 6 Feb 2019 at 07:29, Gerd Hoffmann wrote:
> There also is a patch floating around to auto-install openbsd:
> https://patchwork.kernel.org/patch/10749459/
>
> Not fully sure why this wasn't merged yet. One problem is that this
> patch depends on a new slirp feature (added in the 3.
On 06/02/2019 13:23, Andrey Shinkevich wrote:
> A new test file 242 added to the qemu-iotests set. It checks
> the format of qcow2 specific information for the new added
> section that lists details of bitmaps.
>
> Signed-off-by: Andrey Shinkevich
> Reviewed-by: Eric Blake
> Reviewed-by: Vladi
On Fri, 1 Feb 2019 09:08:37 +0800
Wei Yang wrote:
> [get|set]_addr are two counterpart to access PCDIMMDevice.addr.
>
> Since we have already set up a property PC_DIMM_ADDR_PROP for this
> field and use this mechanism in set_addr, it would be more proper to use
> the same mechanism in set_addr.
On 2019-02-06 12:27, Stefano Garzarella wrote:
> If the WRITE_ZEROES feature is enabled, we check this command
> in the test_basic().
>
> Reviewed-by: Michael S. Tsirkin
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: Stefano Garzarella
> ---
> tests/virtio-blk-test.c | 60
This series adds the support of DISCARD and WRITE_ZEROES commands
and extends the virtio-blk-test to test WRITE_ZEROES command when
the feature is enabled.
v3:
- rebased on master (I removed Based-on tag since the new virtio headers from
linux v5.0-rc1 are merged)
- added patch 2 to add host_fea
If the WRITE_ZEROES feature is enabled, we check this command
in the test_basic().
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
tests/virtio-blk-test.c | 60 +
1 file changed, 60 insertions(+)
diff -
On 2019-02-06 12:27, Stefano Garzarella wrote:
> The size of data in the virtio_blk_request must be a multiple
> of 512 bytes for IN and OUT requests, or a multiple of the size
> of struct virtio_blk_discard_write_zeroes for DISCARD and
> WRITE_ZEROES requests.
>
> Reviewed-by: Michael S. Tsirkin
This patch adds the support of DISCARD and WRITE_ZEROES commands,
that have been introduced in the virtio-blk protocol to have
better performance when using SSD backend.
We support only one segment per request since multiple segments
are not widely used and there are no userspace APIs that allow
a
On 2019-01-29 14:29, Jason J. Herne wrote:
> Add bootindex property and iplb data for vfio-ccw devices. This allows us to
> forward boot information into the bios for vfio-ccw devices.
>
> Signed-off-by: Jason J. Herne
> Acked-by: Halil Pasic
> ---
> hw/s390x/ipl.c | 14 +++
The size of data in the virtio_blk_request must be a multiple
of 512 bytes for IN and OUT requests, or a multiple of the size
of struct virtio_blk_discard_write_zeroes for DISCARD and
WRITE_ZEROES requests.
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garza
Since configurable features for virtio-blk are growing, this patch
adds host_features field in the struct VirtIOBlock. (as in virtio-net)
In this way, we can avoid to add new fields for new properties and
we can directly set VIRTIO_BLK_F* flags in the host_features.
We update "config-wce" and "scs
We add acct_failed param in order to use virtio_blk_handle_rw_error()
also when is not required to call block_acct_failed(). (eg. a discard
operation is failed)
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
hw/block/virtio-blk.c | 10 ++-
In order to avoid migration issues, we enable DISCARD and
WRITE_ZEROES features only for machine type >= 4.0
As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the
list [1], DISCARD operation should not have security implications
(eg. page cache attacks), so we can enable it by default.
On Wed, Feb 06, 2019 at 11:48:51AM +0100, Kashyap Chamarthy wrote:
> On Tue, Feb 05, 2019 at 08:44:12PM -0500, John Snow wrote:
> > On 2/5/19 8:49 AM, Marc-André Lureau wrote:
[...]
> > > < command-name > [ arg-name1=arg1 ] ... [ arg-nameN=argN ]
> > > """
> > > -cmd
From: "Dr. David Alan Gilbert"
The 'announce timer' will be used by migration, and explicit
requests for qemu to perform network announces.
Based on the work by Germano Veit Michel
and Vlad Yasevich
Signed-off-by: Dr. David Alan Gilbert
---
include/net/announce.h | 39
From: "Dr. David Alan Gilbert"
Switch virtio's self announcement to use the AnnounceTimer.
It keeps it's own AnnounceTimer (per device), and starts running it
using a migration post-load and a virtual clock; that way the
announce happens once the guest is actually running.
The timer uses the migr
From: "Dr. David Alan Gilbert"
Some network devices have a capability to do self announcements
(ex: virtio-net). Add infrastructure that would allow devices
to expose this ability.
Signed-off-by: Vladislav Yasevich
Signed-off-by: Dr. David Alan Gilbert
---
include/net/net.h | 2 ++
net/annou
From: "Dr. David Alan Gilbert"
Hi,
This is a reworking of a few sets of patches from 2017
that were put together by myself, Germano and Vlad that make
the network announce system more flexible.
Firstly, it's parameterised, so that you can change the number
of packets and the gap between them
On 2/6/19 10:53 AM, David Hildenbrand wrote:
> Handling it just like float128_to_uint32_round_to_zero, that hopefully
> is free of bugs :)
>
> Documentation basically copied from float128_to_uint64
>
> Signed-off-by: David Hildenbrand
> ---
> fpu/softfloat.c | 29 +++
From: "Dr. David Alan Gilbert"
Add migration parameters that control RARP/GARP announcement timeouts.
Based on earlier patches by myself and
Vladislav Yasevich
Signed-off-by: Dr. David Alan Gilbert
Acked-by: Markus Armbruster
---
hmp.c| 28 +++
include/migrati
From: "Dr. David Alan Gilbert"
Expose the virtio-net self announcement capability and allow
qemu_announce_self() to call it.
These announces are caused by something external (i.e. the
announce-self command); they won't trigger if the migration
counter is triggering announces at the same time.
S
From: "Dr. David Alan Gilbert"
Add an HMP command to trigger self annocements.
Unlike the QMP command (which takes a set of parameters), the HMP
command reuses the set of parameters used for migration.
Signend-off-by: Vladislav Yasevich
Signed-off-by: Dr. David Alan Gilbert
---
hmp-commands.h
From: "Dr. David Alan Gilbert"
Switch the announcements to using the new announce timer.
Move the code that does it to announce.c rather than savevm
because it really has nothing to do with the actual migration.
Migration starts the announce from bh's and so they're all
in the main thread/bql, a
On 2019-01-28 12:10, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
>
> On 1/28/19 9:37 AM, Thomas Huth wrote:
>> Hi,
>>
>> On 2019-01-27 11:18, kumar sourav wrote:
>>> Sets the category of lm832x as DEVICE_CATEGORY_INPUT
>>> Devices should be assigned to one of DEVICE_CATEGORY_
>>>
>>> Signed-of
From: "Dr. David Alan Gilbert"
We now expose qemu_announce_self through QMP and HMP. Add a test
with some very basic packet validation (make sure we get a RARP).
Signed-off-by: Vlad Yasevich
Signed-off-by: Dr. David Alan Gilbert
---
tests/Makefile.include | 2 +
tests/test-announce-self
From: "Dr. David Alan Gilbert"
Add a qmp command that can trigger guest announcements.
It uses its own announce-timer instance, and parameters
passed to it explicitly in the command.
Like most qmp commands, it's in the main thread/bql, so
there's no racing with any outstanding timer.
Based on
Handling it just like float128_to_uint32_round_to_zero, that hopefully
is free of bugs :)
Documentation basically copied from float128_to_uint64
Signed-off-by: David Hildenbrand
---
fpu/softfloat.c | 29 +
include/fpu/softfloat.h | 1 +
2 files changed, 30 i
From: Sven Schnelle
While doing 'set $pcoqh=0xf000' i triggered the assertion below.
The argument order for deposit64() is wrong, and val needs to be
moved to the end.
Signed-off-by: Sven Schnelle
Message-Id: <20190128165333.3814-1-sv...@stackframe.org>
Reviewed-by: Richard Henderson
Signe
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Message-Id: <1518663946-2326-1-git-send-email-c...@braap.org>
Signed-off-by: Richard Henderson
---
target/hppa/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
From: Sven Schnelle
PA-RISC specification says: "Setting the PSW Q-bit, PSW{28}, to 1
with this instruction, if it was not already 1, is an undefined
operation." However, at least HP-UX 10.20 sets the Q bit from 0 to 1
with the SSM instruction. Tested this both on HP9000/712 and
HP9000/785/C3750,
ailable in the Git repository at:
https://github.com/rth7680/qemu.git tags/pull-hppa-20190206
for you to fetch changes up to 68aa851aa21741ab0a3c019b641d6ce72f68b3d5:
target/hppa: fix PSW Q bit behaviour to match hardware (2019-02-06 10:49
On Thu, 31 Jan 2019 15:16:50 +0800
Tao Xu wrote:
> This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
> according to the command line. The ACPI HMAT describes the memory attributes,
> such as memory side cache attributes and bandwidth and latency details,
> related to t
On Thu, 31 Jan 2019 15:16:57 +0800
Tao Xu wrote:
> Per Igor comments,
there is no need to mention me in main commit message
as it carries 0 useful information.
> these function is used only once,
> move its body inside of the caller
review comment's generally addressed in the patch to which th
On Tue, Feb 05, 2019 at 08:44:12PM -0500, John Snow wrote:
> On 2/5/19 8:49 AM, Marc-André Lureau wrote:
[...]
> > Replace with a regexp to split while respecting quoted strings and
> > preserving quotes:
> >
> > re.findall(r'''(?:[^\s"']|"(?:\\.|[^"])*"|'(?:\\.|[^'])*')+''', cmd)
> > ['blockde
On Tue, 5 Feb 2019 16:19:50 +0100
Laszlo Ersek wrote:
> On 02/05/19 16:07, Igor Mammedov wrote:
> > On Mon, 4 Feb 2019 17:03:20 +0100
> > Laszlo Ersek wrote:
> >
> > Am I to greedy to ask for prebuilt AVMF image in QEMU repo on top of
> > this App (while you still remember all Makefile magic f
On 06/02/2019 10:42, Vladimir Sementsov-Ogievskiy wrote:
> 05.02.2019 23:14, Andrey Shinkevich wrote:
>> A new test file 242 added to the qemu-iotests set. It checks
>> the format of qcow2 specific information for the new added
>> section that lists details of bitmaps.
>>
>> Signed-off-by: Andrey
On 05/02/2019 23:33, Eric Blake wrote:
> On 2/5/19 2:14 PM, Andrey Shinkevich wrote:
>> In the 'Format specific information' section of the 'qemu-img info'
>> command output, the supplemental information about existing QCOW2
>> bitmaps will be shown, such as a bitmap name, flags and granularity:
Inform a user in case qcow2_get_specific_info fails to obtain
QCOW2 image specific information. This patch is preliminary to
the one "qcow2: Add list of bitmaps to ImageInfoSpecificQCow2".
Signed-off-by: Andrey Shinkevich
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewe
v13:
The enhancement of the Python code style for fopen() in the new test 242.
The 'unknown flag' was actually removed from the structure Qcow2BitmapInfo.
v12:
In the function block_crypto_get_specific_info_luks(),
checking the format was replaced with assertion.
The 'unknown flag' was removed fro
A new test file 242 added to the qemu-iotests set. It checks
the format of qcow2 specific information for the new added
section that lists details of bitmaps.
Signed-off-by: Andrey Shinkevich
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/242 | 99
In the 'Format specific information' section of the 'qemu-img info'
command output, the supplemental information about existing QCOW2
bitmaps will be shown, such as a bitmap name, flags and granularity:
image: /vz/vmprivate/VM1/harddisk.hdd
file format: qcow2
virtual size: 64G (68719476736 bytes)
On 1/31/19 3:08 PM, Yuval Shaia wrote:
When QP is destroyed the backend QP is destroyed as well. This ensures
we clean all received buffer we posted to it.
However, a contexts of these buffers are still remain in the device.
I think without 'a' and without 'are'
Fix it by maintaining a lis
On 1/31/19 3:08 PM, Yuval Shaia wrote:
When device is going down free all saved MAD buffers.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 32
hw/rdma/rdma_backend.h | 1 +
2 files changed, 33 insertions(+)
diff --git a/hw/rdma/rdma_backend.c
On 1/31/19 3:08 PM, Yuval Shaia wrote:
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c| 53 ---
hw/rdma/rdma_rm.c | 6 +
hw/rdma/rdma_rm_defs.h| 21
hw/rdma/vmw/pvrdma.h | 5
hw/rdma/vmw/pvrdma_ma
We had an --sve switch, which would also enable sve,
but no way to turn sve off.
Signed-off-by: Richard Henderson
---
risugen | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/risugen b/risugen
index de3f5ea..e690b18 100755
--- a/risugen
+++ b/risugen
@@ -308,6 +308,7 @@ Vali
On Mon, 4 Feb 2019 17:03:20 +0100
Laszlo Ersek wrote:
> Previous version (v2):
> http://mid.mail-archive.com/20190124203959.30875-1-lersek@redhat.com
>
> Updates in v3 have been noted on each patch in the series.
>
> Cc: "Michael S. Tsirkin"
> Cc: Ard Biesheuvel
> Cc: Gerd Hoffmann
> Cc: Ig
In the process of noticing what the problem was,
add fp regs to the aarch64 smoke test.
r~
Richard Henderson (2):
aarch64: Fill in fp regs for test_aarch64.s
risugen: Default to sve off
risugen| 3 ++-
test_aarch64.s | 34 ++
2 files changed, 36 i
Signed-off-by: Richard Henderson
---
test_aarch64.s | 34 ++
1 file changed, 34 insertions(+)
diff --git a/test_aarch64.s b/test_aarch64.s
index d5a8495..f75d588 100644
--- a/test_aarch64.s
+++ b/test_aarch64.s
@@ -43,6 +43,40 @@ mov w28, 28
mov w29, 29
mov w30,
Hi Yuval,
On 1/31/19 3:08 PM, Yuval Shaia wrote:
To protect against CPU over utilization when guest performs unneeded
busy waiting loop on an empty CQ.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 11 +++
hw/rdma/rdma_backend.h | 2 +-
hw/rdma/rdma_rm.c
On Thu, 31 Jan 2019 15:16:54 +0800
Tao Xu wrote:
> From: Liu Jingqi
>
> Add -numa hmat-lb option to provide System Locality Latency and
> Bandwidth Information. These memory attributes help to build
> System Locality Latency and Bandwidth Information Structure(s)
> in ACPI Heterogeneous Memory
On 05/02/2019 18:42, Peter Maydell wrote:
> Coverity warns (CID 1390634) that open_net_route() is not
> checking the return value from sscanf(), which means that
> it might then use values that aren't initialized.
>
> Errors here should in general not happen since we're passing
> an assumed-good /
On 05/02/2019 18:42, Peter Maydell wrote:
> Coverity warns (CID 1390634) that open_net_route() is not
> checking the return value from sscanf(), which means that
> it might then use values that aren't initialized.
>
> Errors here should in general not happen since we're passing
> an assumed-good /
On Tue, Feb 05, 2019 at 05:42:07PM +, Peter Maydell wrote:
> Coverity warns (CID 1390634) that open_net_route() is not
> checking the return value from sscanf(), which means that
> it might then use values that aren't initialized.
>
> Errors here should in general not happen since we're passin
On Thu, 31 Jan 2019 15:16:58 +0800
Tao Xu wrote:
> Per Igor's comment, rewrite NFIT code to build _HMA method.
>
> We rewirte the function nvdimm_build_common_dsm(Aml *dev) and
> nvdimm_build_fit(Aml *dev) in hw/acpi/nvdimm.c so that we can use
> method_number as input to decide to generate _FIT
On 2/6/19 9:10 AM, David Hildenbrand wrote:
> Needed on s390x, to test for the data class of a number. So it will
> gain soon a user.
>
> A number is considered normal if the exponent is neither 0 nor all 1's.
> That can be checked by adding 1 to the exponent, and comparing against
>> = 2 after dr
On Mon, Feb 04, 2019 at 09:45:17PM +0100, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of co
On Tue, Feb 05, 2019 at 05:24:02PM -0500, Brad Smith wrote:
> On 2/5/2019 9:23 AM, Philippe Mathieu-Daudé wrote:
>
> > Hi Brad,
> >
> > On 2/5/19 2:57 PM, Brad Smith wrote:
> > > If someone could point me in the right direction as to how the image is
> > > created
> > > I could look at coming up
On Thu, 31 Jan 2019 15:16:52 +0800
Tao Xu wrote:
> From: Liu Jingqi
>
> This structure describes the memory access latency and bandwidth
> information from various memory access initiator proximity domains.
> The latency and bandwidth numbers represented in this structure
> correspond to rated
Needed on s390x, to test for the data class of a number. So it will
gain soon a user.
A number is considered normal if the exponent is neither 0 nor all 1's.
That can be checked by adding 1 to the exponent, and comparing against
>= 2 after dropping an eventual overflow into the sign bit.
While at
On Wed, Feb 06, 2019 at 07:37:29AM +, Mark Cave-Ayland wrote:
> On 06/02/2019 07:28, Corentin Labbe wrote:
>
> >>> Hello
> >>>
> >>> Sorry even with the patch I still hit the issue.
> >>>
> >>> I have added some debug and at least qemu set initrd_size correctly now.
> >>>
> >>> I have tried to
On 06.02.19 04:08, Richard Henderson wrote:
> On 2/5/19 4:22 PM, David Hildenbrand wrote:
>> +static inline bool float128_is_normal(float128 a)
>> +{
>> +return ((a.high + (1ULL << 47)) & -1ULL >> 1) >= 1ULL << 48;
>
> I believe this is off by one: 1 << 48 and >= 1 << 49.
>
> The exponent is
05.02.2019 19:35, Vladimir Sementsov-Ogievskiy wrote:
> 16.01.2019 19:58, Daniel P. Berrangé wrote:
>> On Wed, Jan 16, 2019 at 10:25:03AM -0600, Eric Blake wrote:
>>> [adding Dan]
>>>
>>> On 7/31/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote:
To implement reconnect we need several states for
On Thu, 31 Jan 2019 15:16:51 +0800
Tao Xu wrote:
> From: Liu Jingqi
>
> HMAT is defined in ACPI 6.2: 5.2.27 Heterogeneous Memory Attribute Table
> (HMAT).
> The specification references below link:
> http://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf
>
> It describes the memory at
From: Zhang Yi
Add linux/mman.h,asm/mman.h,asm/mman-common.h to linux-headers,
So we can use more mmap2 flags.
Signed-off-by: Zhang Yi
---
scripts/update-linux-headers.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/update-linux-headers.sh b/scripts/update-
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to
guarantee the write persistence to mmap'ed files supporting DAX (e.g.,
files on ext4/xfs file system mounted with '-o dax').
A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at
https://patchwork.kernel.org/patch
From: Zhang Yi
besides the existing 'shared' flags, we are going to add
'is_pmem' to qemu_ram_mmap(), which indicated the memory backend
file is a persist memory.
Signed-off-by: Haozhong Zhang
Signed-off-by: Zhang Yi
---
exec.c| 2 +-
include/qemu/mmap-alloc.h | 21 ++
From: Zhang Yi
Update it to 4.20-rc1
Signed-off-by: Zhang Yi
---
linux-headers/asm-arm/mman.h | 4 ++
linux-headers/asm-arm64/mman.h | 1 +
linux-headers/asm-generic/hugetlb_encode.h | 36 ++
linux-headers/asm-generic/mman-common.h| 77 ++
From: Zhang Yi
Signed-off-by: Zhang Yi
---
docs/nvdimm.txt | 25 ++---
qemu-options.hx | 4
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
index 5f158a6..e2bf89f 100644
--- a/docs/nvdimm.txt
+++ b/docs/nvdimm.txt
@@ -1
From: Zhang Yi
When a file supporting DAX is used as vNVDIMM backend, mmap it with
MAP_SYNC flag in addition which can ensure file system metadata
synced in each guest writes to the backend file, without other QEMU
actions (e.g., periodic fsync() by QEMU).
Current, We have below different possib
On Mon, 28 Jan 2019 15:35:09 -0500
Tony Krowiak wrote:
> On 12/17/18 10:57 AM, Tony Krowiak wrote:
> > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the
> > max_index
> > value of the BusState structure with the max_dev value of the BusClass
> > structure
> > to determine w
201 - 297 of 297 matches
Mail list logo
