Re: [Qemu-devel] Maintainers, please git-am -m

2019-02-07 Thread Thomas Huth
On 2019-02-08 08:30, Markus Armbruster wrote: > Short story: please add > > [am] > messageid = true > > to your .gitconfig. > > Long story. git-am can add a Message-id: tag. Looks like this: > > commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c > Author: Thomas Huth >

Re: [Qemu-devel] [PATCH] qemugdb/coroutine: fix arch_prctl has unknown return type

2019-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2019 at 06:14:25PM +0300, Vladimir Sementsov-Ogievskiy wrote: > qemu coroutine command results in following error output: > > Python Exception 'arch_prctl' has unknown return > type; cast the call to its declared return type: Error occurred in > Python command: 'arch_prctl' has un

[Qemu-devel] Maintainers, please git-am -m

2019-02-07 Thread Markus Armbruster
Short story: please add [am] messageid = true to your .gitconfig. Long story. git-am can add a Message-id: tag. Looks like this: commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c Author: Thomas Huth Date: Mon Feb 4 09:25:43 2019 +0100 Commit: Peter Maydell

Re: [Qemu-devel] [PATCH 01/19] ppc/xive: hardwire the Physical CAM line of the thread context

2019-02-07 Thread Cédric Le Goater
On 2/8/19 6:44 AM, David Gibson wrote: > On Mon, Jan 28, 2019 at 10:46:07AM +0100, Cédric Le Goater wrote: >> By default on P9, the HW CAM line (23bits) is hardwired to : >> >> 0x000||0b1||4Bit chip number||7Bit Thread number. >> >> When the block group mode is enabled at the controller level

[Qemu-devel] [PATCH] sdl2: drop qemu_input_event_send_key_qcode call

2019-02-07 Thread Gerd Hoffmann
qkbd_state_key_event() does that for us. Fixes: 07333e1ca3 kbd-state: use state tracker for sdl2 Reported-by: BALATON Zoltan Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index 664364a5e5..fb345f45fb 1006

Re: [Qemu-devel] [PULL 15/25] contrib: compile vhost-user-blk tool by default

2019-02-07 Thread Stefan Hajnoczi
On Mon, Feb 04, 2019 at 08:48:14PM -0500, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2019 at 03:29:21PM +, Daniel P. Berrangé wrote: > > On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote: > > > Hmm I do think we want to build the contrib tools, > > > otherwise they bitrot too

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-07 Thread Cédric Le Goater
On 2/8/19 6:36 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: >> When the thread interrupt management state is retrieved from the KVM >> VCPU, word2 is saved under the QEMU XIVE thread context to print out >> the OS CAM line under the QEMU monitor. >> >>

Re: [Qemu-devel] [regression] Clock jump on VM migration

2019-02-07 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 05:33:25PM -0500, Neil Skrypuch wrote: Thanks for your email! Please post your QEMU command-line. > The clock jump numbers above are from NTP, but you can see that they are > quite > close to the amount of time spent in raw_co_invalidate_cache. So, it looks > like flus

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-07 Thread David Gibson
On Thu, Feb 07, 2019 at 08:26:20PM -0700, Alex Williamson wrote: > On Fri, 8 Feb 2019 13:29:37 +1100 > Alexey Kardashevskiy wrote: > > > On 08/02/2019 02:18, Alex Williamson wrote: > > > On Thu, 7 Feb 2019 15:43:18 +1100 > > > Alexey Kardashevskiy wrote: > > > > > >> On 07/02/2019 04:22, Dani

Re: [Qemu-devel] [PATCH v5 1/1] target/ppc: Enable reporting of SPRs to GDB

2019-02-07 Thread David Gibson
On Wed, Feb 06, 2019 at 02:51:33PM -0200, Fabiano Rosas wrote: > This allows reading and writing of SPRs via GDB: > > (gdb) p/x $srr1 > $1 = 0x82803033 > > (gdb) p/x $pvr > $2 = 0x4b0201 > (gdb) set $pvr=0x4b > (gdb) p/x $pvr > $3 = 0x4b > > The `info` command can also be used: >

Re: [Qemu-devel] [PATCH 01/19] ppc/xive: hardwire the Physical CAM line of the thread context

2019-02-07 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:07AM +0100, Cédric Le Goater wrote: > By default on P9, the HW CAM line (23bits) is hardwired to : > > 0x000||0b1||4Bit chip number||7Bit Thread number. > > When the block group mode is enabled at the controller level (PowerNV), > the CAM line is changed for CA

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-07 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: > When the thread interrupt management state is retrieved from the KVM > VCPU, word2 is saved under the QEMU XIVE thread context to print out > the OS CAM line under the QEMU monitor. > > This breaks the migration of a TCG guest (an

Re: [Qemu-devel] [PATCH] target/ppc: Fix msync to do what hardware does

2019-02-07 Thread David Gibson
On Sat, Jan 26, 2019 at 03:50:28PM +0100, BALATON Zoltan wrote: > According to BookE docs, invalid bits (while undefined behaviour) should > not raise exception but be ignored. This seems to be implementation > dependent though and QEMU currently does what e500 CPUs do and raise > exception for inv

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote: > This series adds the support of DISCARD and WRITE_ZEROES commands > and extends the virtio-blk-test to test WRITE_ZEROES command when > the feature is enabled. > > v3: > - rebased on master (I removed Based-on tag since the new

Re: [Qemu-devel] [PATCH V13 0/5] support MAP_SYNC for memory-backend-file

2019-02-07 Thread Pankaj Gupta
> > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). > > A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at > https://patchwor

[Qemu-devel] [Bug 1815143] Re: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-07 Thread Thomas Huth
Which version of QEMU are you using here? I think this should be working fine with the latest version of QEMU (>= v2.10). ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 22 +++--- qemu-options.hx | 5 + 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a6..e70f28b 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @@ -143

Re: [Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Yi Zhang
On 2019-02-07 at 22:00:46 -0500, Michael S. Tsirkin wrote: > On Fri, Feb 08, 2019 at 06:11:23PM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 25 ++--- > > qemu-options.hx | 5 + > > 2 files changed, 27 insertio

Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig

2019-02-07 Thread Thomas Huth
On 2019-02-08 00:16, BALATON Zoltan wrote: > On Thu, 7 Feb 2019, Paolo Bonzini wrote: >> From: Thomas Huth >> >> Most of the dependencies are now directly selected by the SAM460EX >> switch. We can drop CONFIG_VGA_CIRRUS since this device is already >> selected automatically when CONFIG_PCI_DEVICE

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Message-id: 2019

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Mes

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Type: series Mes

[Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread Richard Henderson
Currently, a jump to a label that is not defined anywhere will be emitted not be relocated. This results in a jump to a random jump target. With tcg debugging, print a diagnostic to the -d op file and abort. This could help debug or detect errors like c2d9644e6d ("target/arm: Fix crash on condit

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-07 Thread Alex Williamson
On Fri, 8 Feb 2019 13:29:37 +1100 Alexey Kardashevskiy wrote: > On 08/02/2019 02:18, Alex Williamson wrote: > > On Thu, 7 Feb 2019 15:43:18 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 07/02/2019 04:22, Daniel Henrique Barboza wrote: > >>> Based on this series, I've sent a Libvirt patc

Re: [Qemu-devel] [PATCH V13 0/5] support MAP_SYNC for memory-backend-file

2019-02-07 Thread Michael S. Tsirkin
On Fri, Feb 08, 2019 at 06:10:23PM +0800, Zhang, Yi wrote: > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). > > A description of MAP_SYNC and MAP_S

Re: [Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Michael S. Tsirkin
On Fri, Feb 08, 2019 at 06:11:23PM +0800, Zhang, Yi wrote: > From: Zhang Yi > > Signed-off-by: Zhang Yi > --- > docs/nvdimm.txt | 25 ++--- > qemu-options.hx | 5 + > 2 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt >

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-07 Thread Alexey Kardashevskiy
On 08/02/2019 02:18, Alex Williamson wrote: > On Thu, 7 Feb 2019 15:43:18 +1100 > Alexey Kardashevskiy wrote: > >> On 07/02/2019 04:22, Daniel Henrique Barboza wrote: >>> Based on this series, I've sent a Libvirt patch to allow a QEMU process >>> to inherit IPC_LOCK when using VFIO passthrough

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] Querying the size of devdax devices from userspace

2019-02-07 Thread Stefan Hajnoczi
On Mon, Feb 04, 2019 at 12:06:32AM -0800, Dan Williams wrote: > On Sun, Feb 3, 2019 at 11:56 PM Stefan Hajnoczi wrote: > > > > How can userspace applications query the size of devdax character > > devices? > > > > stat(1) doesn't know how large the device is: > > > > # stat /dev/dax0.0 > > F

[Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 25 ++--- qemu-options.hx | 5 + 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a6..a168429 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @@ -

[Qemu-devel] [PATCH V13 4/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-02-07 Thread Zhang, Yi
From: Zhang Yi When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Current, We have below different possib

[Qemu-devel] [PATCH V13 2/5] scripts/update-linux-headers: add linux/mman.h

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Add linux/mman.h,asm/mman.h,asm/mman-common.h to linux-headers, So we can use more mmap2 flags. Signed-off-by: Zhang Yi --- scripts/update-linux-headers.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-

[Qemu-devel] [PATCH V13 1/5] util/mmap-alloc: Add a 'is_pmem' parameter to qemu_ram_mmap

2019-02-07 Thread Zhang, Yi
From: Zhang Yi besides the existing 'shared' flags, we are going to add 'is_pmem' to qemu_ram_mmap(), which indicated the memory backend file is a persist memory. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi Reviewed-by: Pankaj Gupta --- exec.c| 2 +- include/qe

[Qemu-devel] [PATCH V13 3/5] linux-headers: add linux/mman.h.

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Update it to 4.20-rc1 Signed-off-by: Zhang Yi --- linux-headers/asm-arm/mman.h | 4 ++ linux-headers/asm-arm64/mman.h | 1 + linux-headers/asm-generic/hugetlb_encode.h | 36 ++ linux-headers/asm-generic/mman-common.h| 77 ++

[Qemu-devel] [PATCH V13 0/5] support MAP_SYNC for memory-backend-file

2019-02-07 Thread Zhang, Yi
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at https://patchwork.kernel.org/patch

Re: [Qemu-devel] [PATCH V12 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Yi Zhang
On 2019-02-07 at 09:30:12 -0500, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2019 at 11:16:05PM +0800, Yi Zhang wrote: > > On 2019-02-06 at 13:29:37 -0500, Michael S. Tsirkin wrote: > > > On Thu, Feb 07, 2019 at 01:27:29AM +0800, Zhang, Yi wrote: > > > > From: Zhang Yi > > > > > > > > Signed-off-

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [Bug 1815078] [NEW] Qemu 3.1.0 risc-v mie.MEIE

2019-02-07 Thread Alistair Francis
On Thu, Feb 7, 2019 at 8:19 AM RTOS Pharos <1815...@bugs.launchpad.net> wrote: > > Public bug reported: > > Hello all, > > There is a bug in qemu for Risc-v, related to the mie register: when we > try to set the MEIE bit (11) nothing is done, even when we are running > at machine mode. > > Li a0

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH] configure: Add HAX support in NetBSD

2019-02-07 Thread Kamil Rytarowski
The NetBSD support in Intel HAXM has beem merged upstream and is functional. Signed-off-by: Kamil Rytarowski --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index b18281c61f..89b889072d 100755 --- a/configure +++ b/configure @@ -819,6 +819,7 @@ DragonFly)

Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig

2019-02-07 Thread BALATON Zoltan
On Thu, 7 Feb 2019, Paolo Bonzini wrote: From: Thomas Huth Most of the dependencies are now directly selected by the SAM460EX switch. We can drop CONFIG_VGA_CIRRUS since this device is already selected automatically when CONFIG_PCI_DEVICES is set. Reviewed-by: BALATON Zoltan Reviewed-by: Paol

Re: [Qemu-devel] [PATCH] spapr_pci: Fix interrupt leak in rtas_ibm_change_msi() error path

2019-02-07 Thread David Gibson
On Thu, Feb 07, 2019 at 06:28:37PM +0100, Greg Kurz wrote: > Now that IRQ allocation has been split in two (first allocate IRQ numbers, > then claim them), if the claiming fails, we must release the IRQs. > > Fixes: 4fe75a8ccd80 "spapr: split the IRQ allocation sequence" > Signed-off-by: Greg Kurz

[Qemu-devel] [regression] Clock jump on VM migration

2019-02-07 Thread Neil Skrypuch
We (ab)use migration + block mirroring to perform transparent zero downtime VM backups. Basically: 1) do a block mirror of the source VM's disk 2) migrate the source VM to a destination VM using the disk copy 3) cancel the block mirroring 4) resume the source VM 5) shut down the destination VM gr

[Qemu-devel] [PATCH] tcg/i386: fix unsigned vector saturating arithmetic

2019-02-07 Thread Mark Cave-Ayland
Due to a cut/paste error in the original implementation, the unsigned vector saturating arithmetic was erroneously being calculated as signed vector saturating arithmetic. Fixes: 8ffafbcec2 ("tcg/i386: Implement vector saturating arithmetic") Signed-off-by: Mark Cave-Ayland --- tcg/i386/tcg-tar

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-07 Thread Mark Cave-Ayland
On 05/02/2019 21:29, Mark Cave-Ayland wrote: > Now that this and the other pre-requisite patches have been merged into > master, I've > rebased the outstanding PPC parts of your "tcg, target/ppc vector > improvements" on > master including the above fix and pushed the result to > https://github.

[Qemu-devel] [Bug 1815143] [NEW] qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-07 Thread liang yan
Public bug reported: just wondering if TCG implements instruction prefix 0x7f4 server3:~ # zcat /boot/vmlinux-4.4.162-94.72-default.gz > /tmp/kernel --> starting qemu with kvm enabled works fine server3:~ # qemu-system-s390x -nographic -kernel /tmp/kernel -initrd /boot/initrd -enable-kvm Initia

Re: [Qemu-devel] [PATCH v2 01/18] tests/vm: Be verbose while extracting compressed images

2019-02-07 Thread Philippe Mathieu-Daudé
Hi Alex, Can you queue this patch? On 1/29/19 6:53 PM, Philippe Mathieu-Daudé wrote: > Depending of the host hardware, copying and extracting VM images can > take up to few minutes. Add verbosity to avoid the user to worry about > VMs hanging. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Remove Peter Crosthwaite from various entries

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 7:14 PM, Peter Maydell wrote: > Peter Crosthwaite hasn't had the bandwidth to do code review or > other QEMU work for some time now -- remove his email address > from MAINTAINERS file entries so we don't bombard him with > patch emails. > > Signed-off-by: Peter Maydell > --- > Peter C a

Re: [Qemu-devel] [PATCH v2 00/16] current testing/next queue (with build fixes)

2019-02-07 Thread Philippe Mathieu-Daudé
Cc'ing Michael. On 2/7/19 7:37 PM, Alex Bennée wrote: > > Hi, > > There are a few more additions from the last iteration including some > more fixes to try and get Travis green again. It's nice to see our ARM > features are now catching up we need a newer toolchain to build > things. I did try u

Re: [Qemu-devel] should we try to stop using variable length arrays?

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 8:30 PM, Peter Maydell wrote: > Currently QEMU has 9 uses of variable length arrays > (found using -Wvla): > > hw/block/dataplane/virtio-blk.c:62:25: warning: variable length array > used [-Wvla] > unsigned long bitmap[BITS_TO_LONGS(nvqs)]; > ^ > hw/i386/multi

Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 9:11 PM, Laurent Vivier wrote: > On 07/02/2019 20:36, Cleber Rosa wrote: >> Signed-off-by: Cleber Rosa >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index ff55e2273e..c8fc1647fe 100755 >> --- a/configure >> +++ b

Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 8:36 PM, Cleber Rosa wrote: > This looks like a leftover that was never implemented. > > Signed-off-by: Cleber Rosa > --- > configure | 4 > 1 file changed, 4 deletions(-) > > diff --git a/configure b/configure > index fbd0825488..ff55e2273e 100755 > --- a/configure > +++ b/confi

Re: [Qemu-devel] [PATCH v6 38/73] arm: convert to cpu_interrupt_request

2019-02-07 Thread Alex Bennée
Emilio G. Cota writes: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > > -/* Hooks may change global state so BQL should be held, also the > - * BQL needs to be held for any modification of > - * cs->interrupt_requ

Re: [Qemu-devel] [PATCH v6 31/73] cpu: convert to cpu_halted

2019-02-07 Thread Alex Bennée
Emilio G. Cota writes: > This finishes the conversion to cpu_halted. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > cpus.c| 8 > qom/cpu.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/cpus.c b/cpus.c > index c4fa3cc876..aee129

Re: [Qemu-devel] [PATCH v4 04/14] audio: -audiodev command line option basic implementation

2019-02-07 Thread Zoltán Kővágó
On 2019-01-29 16:56, Markus Armbruster wrote: > "Kővágó, Zoltán" writes: > >> Audio drivers now get an Audiodev * as config paramters, instead of the >> global audio_option structs. There is some code in audio/audio_legacy.c >> that converts the old environment variables to audiodev options (thi

Re: [Qemu-devel] should we try to stop using variable length arrays?

2019-02-07 Thread Eric Blake
On 2/7/19 1:30 PM, Peter Maydell wrote: > Currently QEMU has 9 uses of variable length arrays > (found using -Wvla): > > > Should we be looking to get rid of these and turn on the -Wvla > warning? I know the Linux kernel has recently decided to do this > (some rationale at the start of https://l

Re: [Qemu-devel] [PATCH v4 01/14] qapi: qapi for audio backends

2019-02-07 Thread Zoltán Kővágó
On 2019-01-29 14:33, Markus Armbruster wrote: > "Kővágó, Zoltán" writes: [...] >> + >> +## >> +# @AudiodevPaOptions: >> +# >> +# Options of the pa (PulseAudio) audio backend. >> +# >> +# @server: PulseAudio server address (default: let PulseAudio choose) >> +# >> +# @sink: name of the sink to use

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread Stefano Garzarella
On Thu, Feb 7, 2019 at 8:30 PM Michael S. Tsirkin wrote: > > On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote: > > This series adds the support of DISCARD and WRITE_ZEROES commands > > and extends the virtio-blk-test to test WRITE_ZEROES command when > > the feature is enabled. >

Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

2019-02-07 Thread Laurent Vivier
On 07/02/2019 20:36, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ff55e2273e..c8fc1647fe 100755 > --- a/configure > +++ b/configure > @@ -1768,7 +1768,7 @@ disabled with --

Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

2019-02-07 Thread Laurent Vivier
On 07/02/2019 20:36, Cleber Rosa wrote: > This looks like a leftover that was never implemented. > > Signed-off-by: Cleber Rosa > --- > configure | 4 > 1 file changed, 4 deletions(-) > > diff --git a/configure b/configure > index fbd0825488..ff55e2273e 100755 > --- a/configure > +++ b/con

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU Message-id: 1549562254-41157-1-git-send-

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU Type: series Message-id: 1549562254-4115

Re: [Qemu-devel] should we try to stop using variable length arrays?

2019-02-07 Thread Eric Blake
On 2/7/19 1:30 PM, Peter Maydell wrote: > Currently QEMU has 9 uses of variable length arrays > (found using -Wvla): > > > Should we be looking to get rid of these and turn on the -Wvla > warning? I know the Linux kernel has recently decided to do this > (some rationale at the start of https://l

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2019 at 06:56:43PM +0100, Paolo Bonzini wrote: > Now dropping RFC... Documentation is still lacking, but all targets except > ARM and MIPS are converted. I'll let the respective maintainers decide what > timeframe they prefer. > > defconfig and allnoconfig are supported as configu

[Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

2019-02-07 Thread Cleber Rosa
Signed-off-by: Cleber Rosa --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index ff55e2273e..c8fc1647fe 100755 --- a/configure +++ b/configure @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available: virglr

[Qemu-devel] [PATCH 3/4] scripts/render_block_graph.py: add a missing import

2019-02-07 Thread Cleber Rosa
The handle to QMP may be one of two classes, one implemented locally, and the other one, which seems to be from "qmp.qmp", but of which an import is missing. CC: Vladimir Sementsov-Ogievskiy Signed-off-by: Cleber Rosa --- scripts/render_block_graph.py | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PATCH 4/4] tests/migration/guestperf/engine.py: remove unused import

2019-02-07 Thread Cleber Rosa
Signed-off-by: Cleber Rosa --- tests/migration/guestperf/engine.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py index 398e3f2706..1daf09c6f2 100644 --- a/tests/migration/guestperf/engine.py +++ b/tests/migration/gues

[Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

2019-02-07 Thread Cleber Rosa
This looks like a leftover that was never implemented. Signed-off-by: Cleber Rosa --- configure | 4 1 file changed, 4 deletions(-) diff --git a/configure b/configure index fbd0825488..ff55e2273e 100755 --- a/configure +++ b/configure @@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do

[Qemu-devel] [PATCH 0/4] Trivial fixes for configure and Python scripts

2019-02-07 Thread Cleber Rosa
This is just a small collection of trivial fixes for configure and some Python scripts (missing/unused import statements). Cleber Rosa (4): configure: remove handling of "wav" audio driver configure: fix qemu-img name scripts/render_block_graph.py: add a missing import tests/migration/gues

[Qemu-devel] should we try to stop using variable length arrays?

2019-02-07 Thread Peter Maydell
Currently QEMU has 9 uses of variable length arrays (found using -Wvla): hw/block/dataplane/virtio-blk.c:62:25: warning: variable length array used [-Wvla] unsigned long bitmap[BITS_TO_LONGS(nvqs)]; ^ hw/i386/multiboot.c:364:18: warning: variable length array used [-Wvl

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread Michael S. Tsirkin
On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote: > This series adds the support of DISCARD and WRITE_ZEROES commands > and extends the virtio-blk-test to test WRITE_ZEROES command when > the feature is enabled. pls note and fix patchew errors: https://patchew.org/QEMU/201902061

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PULL 0/1] Dump patches

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206145831.656-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [Qemu-devel] [PATCH v2 05/12] Add vhost-user-backend

2019-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2019 at 07:29:20PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Feb 7, 2019 at 6:36 PM Michael S. Tsirkin wrote: > > > > On Thu, Feb 07, 2019 at 05:54:42PM +0100, Marc-André Lureau wrote: > > > Create a vhost-user-backend object that holds a connection to a > > > vhost-user ba

[Qemu-devel] [PATCH] nbd/server: Kill pointless shadowed variable

2019-02-07 Thread Eric Blake
lgtm.com pointed out that commit 678ba275 introduced a shadowed declaration of local variable 'bs'; thankfully, the inner 'bs' obtained by 'blk_bs(blk)' matches the outer one given that we had 'blk_insert_bs(blk, bs, errp)' a few lines earlier, and there are no later uses of 'bs' beyond the scope o

Re: [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Eric Blake
On 2/7/19 1:05 PM, Peter Maydell wrote: > On Thu, 7 Feb 2019 at 19:00, Eric Blake wrote: >> (Someday, it would be >> nice to turn -Wshadow on, to catch stuff like this sooner) > > Yes; unfortunately -Wshadow currently generates a ton of > warnings in existing code which we'd need to fix to get >

Re: [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Peter Maydell
On Thu, 7 Feb 2019 at 19:00, Eric Blake wrote: > (Someday, it would be > nice to turn -Wshadow on, to catch stuff like this sooner) Yes; unfortunately -Wshadow currently generates a ton of warnings in existing code which we'd need to fix to get the noise level down... thanks -- PMM

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU Message-id: 1549562254-41157-1-git-send-

Re: [Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback

2019-02-07 Thread Samuel Thibault
Philippe Mathieu-Daudé, le jeu. 07 févr. 2019 19:31:49 +0100, a ecrit: > > +if (ret < 0) { > > +g_critical("Failed to send packet, ret: %ld", (long) ret); > > From the v3 discussion [*] I thought send_packet() would return a > gssize, then we'd use G_GSSIZE_FORMAT here (and similarly u

Re: [Qemu-devel] [PATCH v3 1/8] ahci-test: Add dependency to qemu-img tool

2019-02-07 Thread Thomas Huth
On 2019-02-07 17:50, Philippe Mathieu-Daudé wrote: > On 2/5/19 1:18 AM, Philippe Mathieu-Daudé wrote: >> Since the ahci-test uses qemu-img, add a dependency to build it >> before using it. >> This fixes: >> >> $ gmake check-qtest V=1 >> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 >> QT

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU Type: series Message-id: 1549562254-4115

[Qemu-devel] [PATCH v2 15/16] tests/vm: expose BUILD_TARGET, TARGET_LIST and EXTRA_CONFIGURE_OPTS

2019-02-07 Thread Alex Bennée
Now the underlying basevm support passes these along we can expose some additional variables to our Makefile to allow more customised tweaking of the build. For example: make vm-build-freebsd TARGET_LIST=aarch64-softmmu \ EXTRA_CONFIGURE_OPTS="--disable-tools --disable-docs" \ BUILD_TARG

[Qemu-devel] [PATCH] docs/devel/testing: Add -a option to usermod command on docker setup

2019-02-07 Thread Murilo Opsfelder Araujo
The option -G of usermod command will remove user from other groups not listed, i.e.: $USER will belong only to group 'docker' after following the documentation as is. >From usermod(8) manual page: If the user is currently a member of a group which is not listed, the user will be removed

Re: [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Eric Blake
On 2/7/19 12:40 PM, Peter Maydell wrote: > >> NBDExport *nbd_export_new(BlockDriverState *bs, off_t dev_offset, off_t >> size, >>const char *name, const char *description, >> - uint16_t nbdflags, void (*close)(NBDExport *), >> -

Re: [Qemu-devel] [PULL v2 0/3] Linux user for 4.0 patches

2019-02-07 Thread Peter Maydell
On Thu, 7 Feb 2019 at 13:20, Laurent Vivier wrote: > > The following changes since commit 47994e16b1d66411953623e7c0bf0cdcd50bd507: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190205' into staging (2019-02-05 > 18:25:07 +) > > are available in the Git reposi

[Qemu-devel] [PATCH v2 07/16] docker: add debian-buster-arm64-cross

2019-02-07 Thread Alex Bennée
We can't build QEMU with this but we can use this image to build newer arm64 testcases which need more up to date tools. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 + .../debian-buster-arm64-cross.docker | 15 + tests/docker/dockerfiles/deb

[Qemu-devel] [PATCH v2 13/16] tests/vm: call make check directly for netbsd/freebsd/ubuntu.i386

2019-02-07 Thread Alex Bennée
The "make check" target calls check-qtest which has the appropriate system binaries as dependencies so we shouldn't need to do two steps of make invocation. Doing it in two steps was a hangover from when our make check couldn't run tests in parallel. Signed-off-by: Alex Bennée Reviewed-by: Philip

Re: [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Peter Maydell
On Mon, 14 Jan 2019 at 16:47, Eric Blake wrote: > > We only have one caller that wants to export a bitmap name, > which it does right after creation of the export. But there is > still a brief window of time where an NBD client could see the > export but not the dirty bitmap, which a robust client

Re: [Qemu-devel] [PATCH v2 01/12] vhost-user: define conventions for vhost-user backends

2019-02-07 Thread Marc-André Lureau
Hi On Thu, Feb 7, 2019 at 6:42 PM Eric Blake wrote: > > On 2/7/19 10:54 AM, Marc-André Lureau wrote: > > As discussed during "[PATCH v4 00/29] vhost-user for input & GPU" > > review, let's define a common set of backend conventions to help with > > management layer implementation, and interoperab

[Qemu-devel] [PATCH v2 12/16] tests/vm: move images to $HOME/.cache/qemu-vm/images

2019-02-07 Thread Alex Bennée
From: Gerd Hoffmann It's easier to move around the images then, by replacing the subdirectory with a symlink. Allows to share the images between multiple qemu checkouts for example. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-

[Qemu-devel] [PATCH v2 11/16] tests: PEP8 cleanup of docker.py, mostly white space

2019-02-07 Thread Alex Bennée
My editor keeps putting squiggly lines under a bunch of the python lines to remind me how non-PEP8 compliant it is. Clean that up so it's easier to spot new errors. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 48 ++ 1 file changed, 35 insertion

[Qemu-devel] [PATCH v2 16/16] scripts/qemu.py: allow arches use KVM for their 32bit cousins

2019-02-07 Thread Alex Bennée
A lot of architectures can run their 32 bit cousins on KVM so the kvm_available function needs to be a little less restricting when deciding if KVM is available. Signed-off-by: Alex Bennée --- scripts/qemu.py | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scrip

[Qemu-devel] [PATCH v2 14/16] tests/vm: add --build-target option

2019-02-07 Thread Alex Bennée
This allows us to invoke the build with a custom target (for the VMs that use the {target} format string specifier). Currently OpenBSD is still hardwired due to problems running check. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/vm

[Qemu-devel] [PATCH v2 03/16] .travis.yml: separate tools and docs into another entry

2019-02-07 Thread Alex Bennée
Re-building the tools and documents by default is a little wasteful as they are not really affected by the main build options. Split tools and documents into their own task with a minimal softmmu and linux-user target list just to check they don't interact badly. Signed-off-by: Alex Bennée Review

[Qemu-devel] [PATCH v2 09/16] tests: make docker.py check for persistent configs

2019-02-07 Thread Alex Bennée
binfmt_misc configured with the "F" flag opens the interpreter at config time. This means it can use an already open file-descriptor to run QEMU so there is no point trying to copy the binary into a container. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 5 + 1 file changed, 5 ins

[Qemu-devel] [PATCH v2 10/16] tests: docker.py be even smarter with persistent binfmt_misc

2019-02-07 Thread Alex Bennée
If we have a persistent mapping we don't need the QEMU binary copied into the container as the kernel has already opened the file and will pass the fd in. However the support libraries will still need to be there. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 56 +++

[Qemu-devel] [PATCH v2 05/16] MAINTAINERS: Add an entry for scripts/archive-source.sh

2019-02-07 Thread Alex Bennée
From: Philippe Mathieu-Daudé The scripts/archive-source.sh is used by the VM tests, it makes sense to add it in the "Build and test automation" section. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAI

[Qemu-devel] [PATCH v2 06/16] archive-source.sh: Clone the submodules locally

2019-02-07 Thread Alex Bennée
From: Philippe Mathieu-Daudé We cloned the QEMU repository from the local storage. Since the submodules are also available there, clone them too. This is quicker and reduce network use. Signed-off-by: Philippe Mathieu-Daudé [AJB: incorporated review suggestions from danpb] Signed-off-by: Alex B

[Qemu-devel] [PATCH v2 00/16] current testing/next queue (with build fixes)

2019-02-07 Thread Alex Bennée
Hi, There are a few more additions from the last iteration including some more fixes to try and get Travis green again. It's nice to see our ARM features are now catching up we need a newer toolchain to build things. I did try upgrading to debian 10 for the cross build but there are some upstrea

  1   2   3   4   5   >