The "background region" for a v8M MPU is a default which will be used
(if enabled, and if the access is privileged) if the access does
not match any specific MPU region. We were incorrectly using it
always (by putting the condition at the wrong nesting level). This
meant that we would always
On Wed, 13 Feb 2019 15:40:57 +0800
"Liu, Jing2" wrote:
> Hi Igor,
>
> Thanks for your reply!
>
> On 2/5/2019 11:47 PM, Igor Mammedov wrote:
> > On Wed, 30 Jan 2019 21:02:10 +0800
> > "Liu, Jing2" wrote:
> >
> >> Hi everyone,
> >>
> >> I have two questions.
> >> 1. PCI hotplug on pci.0 must
Hi Peter,
On 2/14/19 11:04 AM, Peter Maydell wrote:
> On Wed, 13 Feb 2019 at 18:40, Philippe Mathieu-Daudé
> wrote:
>> What Clang version is that?
>>
>> I can not reproduce using:
>>
>> clang version 7.0.1 (Fedora 7.0.1-1.fc29)
>
> OSX: Apple LLVM version 10.0.0 (clang-1000.11.45.5)> and
On Thu, 14 Feb 2019 08:52:25 +0800
Wei Yang wrote:
> Currently we do device realization like below:
>
>hotplug_handler_pre_plug()
>dc->realize()
>hotplug_handler_plug()
>
> Before we do device realization and plug, we would allocate necessary
> resources and check the capacity.
Ping! Thanks to Alex for doing low-level review of this patchset.
I'm particularly interested in high-level review:
* is this the right way to be going?
* if we committed this and then did a release with the
docs as they are like this, would that be ok?
* what's the most important next step
From: Aleksandar Markovic
Add tests for MSA interleave instructions. This includes following
instructions:
* ILVEV.B - interleave even (bytes)
* ILVEV.H - interleave even (halfwords)
* ILVEV.W - interleave even (words)
* ILVEV.D - interleave even (doublewords)
* ILVOD.B - interleave odd (bytes)
From: Aleksandar Markovic
Add tests for MSA logic instructions. This includes following
instructions:
* AND.V - logical AND
* NOR.V - logical NOR
* OR.V - logical OR
* XOR.V - logical XOR
Each test consists of 80 test cases, so altogether there are 320
test cases.
Signed-off-by: Aleksandar
From: Aleksandar Markovic
The file tests/tcg/mips/include/test_inputs.h is planned to
contain various test inputs. For now, it contains 64 128-bit
pattern inputs (alternating groups od ones and zeroes) and
16 128-bit random inputs.
Signed-off-by: Aleksandar Markovic
---
From: Aleksandar Markovic
Add a header that contains wrappers around MSA instructions assembler
invocations. For now, only bit counting instructions (NLOC, NLZC, and
PCNT; each in four data format flavors) are supported.
Signed-off-by: Aleksandar Markovic
---
From: Aleksandar Markovic
Add a header that contains test utilities. For now, it contains
only a function for checking and printing test results for bit
counting and similar MSA instructions.
Signed-off-by: Aleksandar Markovic
---
tests/tcg/mips/include/test_utils.h | 84
From: Aleksandar Markovic
Add wrappers for MSA interleave instructions.
Signed-off-by: Aleksandar Markovic
---
tests/tcg/mips/include/wrappers_msa.h | 39 +++
1 file changed, 39 insertions(+)
diff --git a/tests/tcg/mips/include/wrappers_msa.h
From: Aleksandar Markovic
Add wrappers for MSA logic instructions.
Signed-off-by: Aleksandar Markovic
---
tests/tcg/mips/include/wrappers_msa.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/tcg/mips/include/wrappers_msa.h
b/tests/tcg/mips/include/wrappers_msa.h
index
From: Aleksandar Markovic
Remove a file that was added long time ago by mistake. The commit
that introduced this file was commit d70080c4 (from 2012).
Acked-by: Alex Bennée
Reviewed-by: Eric Blake
Signed-off-by: Aleksandar Markovic
---
tests/tcg/mips/mips64-dspr2/.directory | 2 --
1 file
From: Aleksandar Markovic
Add tests for MSA bit counting instructions. This includes following
instructions:
* NLOC.B - number of leading ones (bytes)
* NLOC.H - number of leading ones (halfwords)
* NLOC.W - number of leading ones (words)
* NLOC.D - number of leading ones (doublewords)
* NLZC.B
From: Aleksandar Markovic
v2->v3:
- minor cosmetic changes
- added wrappers and tests for MSA logic instructions
v1->v2:
- added refference to the original commit in patch #1
- corrected copy-and-paste error in comments in 12 new source files
- renamed "bit_counting" subdirectory to
QEMU will crashes with
qapi/qobject-output-visitor.c:210: qobject_output_complete: Assertion
`qov->root && ((>stack)->slh_first == ((void *)0))' failed
when trying to get value of not set hostmem's "host-nodes"
property, HostMemoryBackend::host_nodes bitmap doesn't have
any bits set in it, which
Richard Henderson writes:
> Previously this was only supported for roundAndPackFloat64.
> Include support in round_canonical, round_to_int, roundAndPackFloat32,
> roundAndPackInt32, roundAndPackInt64, roundAndPackUint64.
If we extend the fp-test case we can exercise these routines:
Patchew URL:
https://patchew.org/QEMU/20190214102816.3393-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Message-id:
Hi
On Thu, Feb 14, 2019 at 10:44 AM Markus Armbruster wrote:
>
> Adding QAPI's .o to util-obj-y, common-obj-y and obj-y is spread over
> three places: Makefile.objs takes care of target-independent generated
> code, Makefile.target of target-dependent generated code, and
> qapi/Makefile.objs of
On Wed, 13 Feb 2019 14:30:55 +0100
Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > QEMU will crashes with
> > qapi/qobject-output-visitor.c:210: qobject_output_complete: Assertion
> > `qov->root && ((>stack)->slh_first == ((void *)0))' failed
> > when trying to get value of empty
On Thu, 14 Feb 2019 11:10:04 +0800
Stefan Hajnoczi wrote:
> Guests started with NVDIMMs larger than the underlying host file produce
> confusing errors inside the guest. This happens because the guest
> accesses pages beyond the end of the file.
>
> Check the pmem file size on startup and
Hi
On Thu, Feb 14, 2019 at 10:50 AM Markus Armbruster wrote:
>
> We can't add appropriate target-specific conditionals to misc.json,
> because that would make all of misc.json unusable in
> target-independent code. To keep misc.json target-independent, we
> need to split off target-dependent
Richard Henderson writes:
> We've talked about this before, caching state to reduce the
> amount of computation that happens looking up each TB.
>
> I know that Peter has been concerned that we would not be able to
> reliably maintain all of the places that need to be updates to
> keep this
From: Thomas Huth
The option is only a dummy since a long time. We've finally deprecated
it in QEMU v3.0, so it's time to remove it now.
Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <1549545296-18903-3-git-send-email-th...@redhat.com>
Signed-off-by: Laurent
From: "Dr. David Alan Gilbert"
Kill off a pile of monitor_printf's and cur_mon usage.
The only one left in wavcapture.c is the info case.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Gerd Hoffmann
Reviewed-by: Michael S. Tsirkin
Message-Id: <20170320173840.3626-3-dgilb...@redhat.com>
From: Thomas Huth
The sun4uv_init() function expects vga_interface_type to be either
VGA_STD or VGA_NONE and sets up a stdvga device or no vga card
accordingly.
However, the code in vl.c prefers the Cirrus VGA card to stdvga if
it is available and the user and the machine did not specify
The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2019-02-12 10:53:37 +)
are available in the Git repository at:
git://github.com/vivier/qemu.git
From: Kamil Rytarowski
The NetBSD support in Intel HAXM has beem merged upstream and is functional.
Signed-off-by: Kamil Rytarowski
Message-Id: <20190207233704.29978-1-...@gmx.com>
Signed-off-by: Laurent Vivier
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure
From: Eric Blake
Present since commit b25b387f (2.10).
Signed-off-by: Eric Blake
Reviewed-by: Thomas Huth
Message-Id: <20190206202848.16999-1-ebl...@redhat.com>
Signed-off-by: Laurent Vivier
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: "Dr. David Alan Gilbert"
Add a couple of traces around the kvm_set_ioeventfd* calls.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cornelia Huck
Reviewed-by: Michael S. Tsirkin
Message-Id: <20190212134758.10514-4-dgilb...@redhat.com>
From: Thomas Huth
The two sections have accidentally been added again during the
merge of Paolo's and Gerd's trees.
Fixes: 3e29da9fd81002a0c03041aaa26dea6d9dd9bd65
Signed-off-by: Thomas Huth
Reviewed-by: Peter Maydell
Message-Id: <1549545296-18903-2-git-send-email-th...@redhat.com>
From: Cleber Rosa
Signed-off-by: Cleber Rosa
Reviewed-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190207193605.25676-3-cr...@redhat.com>
Signed-off-by: Laurent Vivier
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure
From: Thomas Petazzoni
The current check to test if usbfs support should be compiled or not
solely relies on the presence of , without
actually checking that all definition used by Qemu are provided by
this header file.
With sufficiently old kernel headers, may be
present, but some of the
From: "Dr. David Alan Gilbert"
Always make error messages start with 'Error:' as a fallback
to make sure that anything parsing them can tell it failed.
Note: Some places don't use hmp_handle_error
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael
From: Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d unimp):
$ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
dma: command df not supported
dma: command df not supported
dma: command df not supported
dma: command df not supported
Signed-off-by:
From: Peter Maydell
We have now managed to eradicate all the places in the codebase
that triggered clang's -Waddress-of-packed-member warning. Remove
the compiler flag that exempted it from our usual -Werror policy.
This will prevent any new problematic code being added in future.
From: Cleber Rosa
This looks like a leftover that was never implemented.
Signed-off-by: Cleber Rosa
Reviewed-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190207193605.25676-2-cr...@redhat.com>
Signed-off-by: Laurent Vivier
---
configure | 4
1 file changed, 4
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Message-Id: <20181016112232.23241-1-dgilb...@redhat.com>
Signed-off-by: Laurent Vivier
---
hw/input/pckbd.c | 19
On Tue, 12 Feb 2019 16:30:25 +0100
Cornelia Huck wrote:
> Trace when assigning/unassigning.
>
> Signed-off-by: Cornelia Huck
> ---
> target/s390x/kvm.c| 2 ++
> target/s390x/trace-events | 1 +
> 2 files changed, 3 insertions(+)
Queued to s390-next (without the 's390' infix).
The OSX Mojave release is more picky about enforcing the Cocoa API
restriction that only the main thread may perform UI calls. To
accommodate this we need to restructure the Cocoa code:
* the special OSX main() creates a second thread and uses
that to call the vl.c qemu_main(); the original
* Leonardo Soares Müller (leozinho29...@hotmail.com) wrote:
> I can confirm this, KDE Neon using the command line similar to yours
> crashes QEMU to me too. I will test with Mageia 7 later to see if it
> behaves differently.
>
> But this is a completely different crash. This crash is happening
>
This set of patches rearranges how we handle events on
the OSX Cocoa UI so that we use the main thread to run
the OSX event loop, and we don't do a long blocking
operation from the applicationDidFinishLaunching callback.
Instead we create a second thread which runs qemu_main()
and becomes the QEMU
Move the console/device menu creation code functions
further up in the source file, next to the code which
creates the initial menus. We're going to want to
change the location we call these functions from in
the next patch.
This commit is a pure code move with no other changes.
Signed-off-by:
Factor out the long code sequence in main() which creates
the initial set of menus. This will make later patches
which move initialization code around a bit clearer.
Signed-off-by: Peter Maydell
---
ui/cocoa.m | 78 --
1 file changed, 41
Currently the handleEvent method will directly call the NSApp
sendEvent method for any events that we want to let OSX deal
with. When we rearrange the event handling code, the way that
we say "let OSX have this event" is going to change. Prepare
for that by refactoring so that handleEvent returns
The Cocoa UI should run on the main thread; this is enforced
in OSX Mojave. In order to be able to run on the main thread,
we need to make sure we hold the iothread lock whenever we
call into various QEMU UI midlayer functions.
Signed-off-by: Peter Maydell
---
ui/cocoa.m | 83
Hi Richard,
On Thu, Feb 14, 2019 at 5:07 AM Richard Henderson
wrote:
>
> We've talked about this before, caching state to reduce the
> amount of computation that happens looking up each TB.
>
> I know that Peter has been concerned that we would not be able to
> reliably maintain all of the
Currently the switchSurface method takes a DisplaySurface. We want
to change our DisplayChangeListener's dpy_gfx_switch callback
to do this work asynchronously on a different thread. The caller
of the switch callback will free the old DisplaySurface
immediately the callback returns, so to ensure
When we switch away from our custom event handling, we still want to
be able to have first go at any events our application receives,
because in full-screen mode we want to send key events to the guest,
even if they would be menu item activation events. There are several
ways we could do that, but
On 14.02.19 06:25, Richard Henderson wrote:
> On 2/13/19 11:53 AM, David Hildenbrand wrote:
>> On 13.02.19 20:31, Richard Henderson wrote:
>>> On 2/13/19 6:33 AM, David Hildenbrand wrote:
With the floating-point extension facility
- CONVERT FROM LOGICAL
- CONVERT TO LOGICAL
-
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Kill off a pile of monitor_printf's and cur_mon usage.
You also switch from the two line error format
Reason:
to the more common
:
Suggest to mention that you're changing error messages in the commit
On 14/02/2019 08:00, Thomas Huth wrote:
> On 2019-02-13 22:18, Thomas Petazzoni wrote:
>> The current check to test if usbfs support should be compiled or not
>> solely relies on the presence of , without
>> actually checking that all definition used by Qemu are provided by
>> this header file.
>>
On 12/02/2019 14:47, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Kill off a pile of monitor_printf's and cur_mon usage.
> The only one left in wavcapture.c is the info case.
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> audio/wavcapture.c | 39
On Wed, 13 Feb 2019 at 18:40, Philippe Mathieu-Daudé wrote:
> What Clang version is that?
>
> I can not reproduce using:
>
> clang version 7.0.1 (Fedora 7.0.1-1.fc29)
OSX: Apple LLVM version 10.0.0 (clang-1000.11.45.5)
and Ubuntu bionic: clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
"Dr. David Alan Gilbert (git)" writes:
> From: "Dr. David Alan Gilbert"
>
> Always make error messages start with 'Error:' as a fallback
> to make sure that anything parsing them can tell it failed.
Feeding HMP output to programs is a bad idea to begin with.
> Note: Some places don't use
On 13/02/2019 08:07, Thomas Huth wrote:
> The sun4uv_init() function expects vga_interface_type to be either
> VGA_STD or VGA_NONE and sets up a stdvga device or no vga card
> accordingly.
> However, the code in vl.c prefers the Cirrus VGA card to stdvga if
> it is available and the user and the
On 12/02/2019 15:53, Philippe Mathieu-Daudé wrote:
> Avoid to clutter stdout until explicitly requested (with -d unimp):
>
> $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin
> dma: command df not supported
> dma: command df not supported
> dma: command df not supported
> dma:
On 07/02/2019 20:36, Cleber Rosa wrote:
> This is just a small collection of trivial fixes for configure
> and some Python scripts (missing/unused import statements).
>
> Cleber Rosa (4):
> configure: remove handling of "wav" audio driver
> configure: fix qemu-img name
>
On 07/02/2019 20:36, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ff55e2273e..c8fc1647fe 100755
> --- a/configure
> +++ b/configure
> @@ -1768,7 +1768,7 @@ disabled with
On 06/02/2019 21:28, Eric Blake wrote:
> Present since commit b25b387f (2.10).
>
> Signed-off-by: Eric Blake
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0f349d46033..ee1ab7a8a25 100644
On 12/02/2019 15:10, Philippe Mathieu-Daudé wrote:
> On 2/12/19 2:47 PM, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert"
>>
>> Signed-off-by: Dr. David Alan Gilbert
>
> Per https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03186.html
> this one already has:
>
>
On 07/02/2019 20:36, Cleber Rosa wrote:
> This looks like a leftover that was never implemented.
>
> Signed-off-by: Cleber Rosa
> ---
> configure | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/configure b/configure
> index fbd0825488..ff55e2273e 100755
> --- a/configure
> +++
On 12/02/2019 14:47, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Always make error messages start with 'Error:' as a fallback
> to make sure that anything parsing them can tell it failed.
>
> Note: Some places don't use hmp_handle_error
>
> Signed-off-by: Dr. David
We neglect to call .visit_module() for the special module we use for
built-ins. Harmless, but clean it up anyway. The
tests/qapi-schema/*.out now show the built-in module as 'module None'.
Subclasses of QAPISchemaModularCVisitor need to ._add_module() this
special module to enable code
On 08/02/2019 14:33, Thomas Huth wrote:
> On 2019-02-08 14:21, Peter Maydell wrote:
>> We have now managed to eradicate all the places in the codebase
>> that triggered clang's -Waddress-of-packed-member warning. Remove
>> the compiler flag that exempted it from our usual -Werror policy.
>> This
query-events doesn't reflect compile-time configuration. Instead of
fixing that, deprecate the command in favor of query-qmp-schema.
Libvirt prefers query-qmp-schema as of commit 22d7222ec0 "qemu: caps:
Don't call 'query-events' when we probe events from QMP schema".
It'll be in the next
On 14.02.19 07:11, Richard Henderson wrote:
> Previously this was only supported for roundAndPackFloat64.
> Include support in round_canonical, round_to_int, roundAndPackFloat32,
> roundAndPackInt32, roundAndPackInt64, roundAndPackUint64.
>
> This does not include any of the floatx80 routines, as
On 08/02/2019 00:37, Kamil Rytarowski wrote:
> The NetBSD support in Intel HAXM has beem merged upstream and is functional.
>
> Signed-off-by: Kamil Rytarowski
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index b18281c61f..89b889072d 100755
We can't add appropriate target-specific conditionals to misc.json,
because that would make all of misc.json unusable in
target-independent code. To keep misc.json target-independent, we
need to split off target-dependent target.json.
This commit doesn't actually split off anything, it merely
On 07/02/2019 14:14, Thomas Huth wrote:
> The two sections have accidentally been added again during the
> merge of Paolo's and Gerd's trees.
>
> Fixes: 3e29da9fd81002a0c03041aaa26dea6d9dd9bd65
> Signed-off-by: Thomas Huth
> ---
> qemu-deprecated.texi | 12
> 1 file changed, 12
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Eduardo Habkost
Acked-by: Cornelia Huck
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
include/sysemu/arch_init.h | 3 --
monitor.c | 3 --
qapi/misc.json
From: Marc-André Lureau
It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eduardo Habkost
Acked-by: Cornelia Huck
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
include/sysemu/arch_init.h | 1 -
Adding QAPI's .o to util-obj-y, common-obj-y and obj-y is spread over
three places: Makefile.objs takes care of target-independent generated
code, Makefile.target of target-dependent generated code, and
qapi/Makefile.objs of (target-independent) hand-written code.
Do everything in
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
monitor.c| 11 ---
qapi/misc.json | 43 --
qapi/target.json | 45
From: Marc-André Lureau
The following patches are going to introduce per-target #ifdef in the
schemas.
The introspection data is statically generated once, and must thus be
built per-target to reflect target-specific configuration.
Drop "do_test_visitor_in_qmp_introspect(_schema_qlit)" since
On 07/02/2019 14:14, Thomas Huth wrote:
> The option is only a dummy since a long time. We've finally deprecated
> it in QEMU v3.0, so it's time to remove it now.
>
> Signed-off-by: Thomas Huth
> ---
> qemu-deprecated.texi | 5 -
> qemu-options.hx | 3 ---
> vl.c | 6
From: Marc-André Lureau
Move rtc-reset-reinjection and SEV in target.json and make them
conditional on TARGET_I386.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
hw/timer/mc146818rtc.c | 2 +-
monitor.c | 31
Hello,
On Thu, Feb 14, 2019 at 5:00 AM Richard Henderson
wrote:
>
> Note that float16_to_float32 rightly squashes SNaN to QNaN.
> But of course pickNaNMulAdd, for ARM, selects SNaNs first.
> So we have to preserve SNaN long enough for the correct NaN
> to be selected. Thus
We generate code for built-ins and sub-modules into separate files
since commit cdb6610ae42 and 252dc3105fc (v2.12.0). Both commits
neglected to update documentation. Do that now.
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
docs/devel/qapi-code-gen.txt | 38
The next commit wants to generate qapi-emit-events.{c.h}. To enable
that, extend QAPISchemaModularCVisitor to support additional "system
modules", i.e. modules that don't correspond to a (user-defined) QAPI
schema module.
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
On 07/02/2019 15:51, Andreas Schwab wrote:
> System calls that return a socket address do so by writing the (possibly
> truncated) address into the provided buffer space, but setting the addrlen
> parameter to the actual size of the address. To determine how much to
> copy back to the target
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Acked-by: Cornelia Huck
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
hw/s390x/s390-skeys.c | 2 +-
include/sysemu/arch_init.h | 7 --
monitor.c |
Having to include qapi-events.h just for QAPIEvent is suboptimal, but
quite tolerable now. It'll become problematic when we have events
conditional on the target, because then qapi-events.h won't be usable
from target-independent code anymore. Avoid that by generating it
into separate files.
From: Marc-André Lureau
This command is no longer needed, the schema has compile-time
configuration conditions.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/dispatch.h | 1 -
qapi/qmp-registry.c | 8
2
On 08/02/2019 19:33, Laurent Vivier wrote:
> On 08/02/2019 18:35, Rémi Denis-Courmont wrote:
>> This works around the LTP crash, but there are problably better ways to
>> go about it.
>>
>> Signed-off-by: Rémi Denis-Courmont
>> Cc:
>> ---
>> linux-user/qemu.h | 3 ++-
>> 1 file changed, 2
Marc-André posted a v1 that relies on a QAPI schema language extension
'top-unit' to permit splitting the generated code. Here is his cover
letter:
The thrid and last part (of "[PATCH v2 00/54] qapi: add #if
pre-processor conditions to generated code") is about adding schema
This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c.
The commit applied the events' conditions to the members of enum
QAPIEvent. Awkward, because it renders QAPIEvent unusable in
target-independent code as soon as we make an event target-dependent.
Reverting this has the following
On 12/02/2019 17:34, Andreas Schwab wrote:
> Set msg_flags in the returned struct msghdr.
>
> Signed-off-by: Andreas Schwab
> ---
> linux-user/syscall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 90bfda3563..b6b566a6fa 100644
>
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Acked-by: Cornelia Huck
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/target.json | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qapi/target.json b/qapi/target.json
index 17671d77c1..010df35ebb
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
docs/devel/qapi-code-gen.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index b91bde647c..c9ba8ddb2e 100644
--- a/docs/devel/qapi-code-gen.txt
+++
From: Marc-André Lureau
A few targets don't emit RTC_CHANGE, we could restrict the event to
the tagets that do emit it.
Note: There is a lot more of events & commands that we could restrict
to capable targets, with the cost of some additional complexity, but
the benefit of added correctness and
On 12/02/2019 08:48, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> linux-user/elfload.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index d796d51ec6..5aa0628ae9 100644
> ---
On 12/02/2019 08:48, Richard Henderson wrote:
> The 32-bit kernel has strings for v4, v5, v6, v7, v7m.
> The 64-bit kernel, in compat mode, has strings for v8.
>
> Fixes: https://bugs.launchpad.net/bugs/1813034
> Signed-off-by: Richard Henderson
> ---
> v2: Include v8.
> ---
>
On 14/02/2019 09:51, Wei Yang wrote:
> On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>> On 14/02/2019 09:18, Wei Yang wrote:
>>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
On 14/02/2019 08:57, Laurent Vivier wrote:
> On 14/02/2019 01:03, Wei Yang
On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>On 14/02/2019 09:18, Wei Yang wrote:
>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>>> On 14/02/2019 08:57, Laurent Vivier wrote:
On 14/02/2019 01:03, Wei Yang wrote:
> On Wed, Feb 13, 2019 at 02:45:01PM
acpi_table_builtin is now always false, it is not necessary to check it
again.
This patch just removes it.
Signed-off-by: Wei Yang
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
---
hw/acpi/core.c | 4 +---
1 file changed, 1 insertion(+), 3
Function pc_acpi_init() is not used anymore.
Remove the definition and declaration.
Signed-off-by: Wei Yang
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
Reviewed-by: Thomas Huth
---
hw/i386/pc.c | 27 ---
Function acpi_table_add_builtin() is not used anymore.
Remove the definition and declaration.
Signed-off-by: Wei Yang
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
---
hw/acpi/core.c | 6 --
include/hw/acpi/acpi.h | 1 -
2 files
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
v4: fix reviewed-by tags
v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"
Wei Yang (3):
hw/i386/pc.c:
>
> v3:
> * Added Patch 1 by Igor [Wei]
> * Moved pmem size check after mem_path check [Wei]
>
> Guests started with NVDIMMs larger than the underlying host file produce
> confusing errors inside the guest. This happens because the guest
> accesses pages beyond the end of the file.
>
>
301 - 400 of 413 matches
Mail list logo
