[Qemu-devel] [PULL 01/15] kbd-state: don't block auto-repeat events

2019-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20190220100235.20914-1-kra...@redhat.com --- ui/kbd-state.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ui/kbd-state.c b/ui/kbd-state.c index ac14add70eab..f3ab2d7a665d 100644 ---

[Qemu-devel] [PULL 05/15] char/spice: trigger HUP event

2019-02-21 Thread Gerd Hoffmann
From: Marc-André Lureau Inform the front-end of disconnected state (spice client disconnected). This will wakeup the source handler immediately, so it can detect the disconnection asap. Signed-off-by: Marc-André Lureau Tested-by: Victor Toso Message-id:

[Qemu-devel] [PULL 02/15] spice: set device address and device display ID in QXL interface

2019-02-21 Thread Gerd Hoffmann
From: Lukáš Hrázký Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also

[Qemu-devel] [PULL 12/15] build-sys: add gio-2.0 check

2019-02-21 Thread Gerd Hoffmann
From: Marc-André Lureau GIO is required for the "-display spice-app" backend. Signed-off-by: Marc-André Lureau Tested-by: Victor Toso Message-id: 20190221110703.5775-9-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 13 + 1 file changed, 13 insertions(+)

[Qemu-devel] [PULL 07/15] spice: avoid spice runtime assert

2019-02-21 Thread Gerd Hoffmann
From: Marc-André Lureau The Spice server doesn't like to be started or stopped twice . It aborts with: (process:6191): Spice-ERROR **: 19:29:35.912: red-worker.c:623:handle_dev_start: assertion `!worker->running' failed It's easy to avoid that situation since qemu spice_display_is_running

[Qemu-devel] [PULL 09/15] spice: do not stop spice if VM is paused

2019-02-21 Thread Gerd Hoffmann
From: Marc-André Lureau spice_server_vm_start/stop() was added to help migration state (commit f5bb039c6d97ef3e664094eab3c9a4dc1824ed73). However, a paused VM could keep running the spice server. This will allow a Spice client to keep sending commands to a spice chardev. This allows to

[Qemu-devel] [PULL 00/15] Ui 20190222 patches

2019-02-21 Thread Gerd Hoffmann
The following changes since commit 2e68b8620637a4ee8c79b5724144b726af1e261b: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20190219' into staging (2019-02-18 16:20:13 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20190222-pull-request

[Qemu-devel] [PULL 13/15] qapi: document DisplayType enum

2019-02-21 Thread Gerd Hoffmann
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Tested-by: Victor Toso Message-id: 20190221110703.5775-10-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 25 + 1 file changed, 25 insertions(+) diff --git a/qapi/ui.json

Re: [Qemu-devel] Testing sysbus devices

2019-02-21 Thread Markus Armbruster
Stephen Checkoway writes: >> On Feb 20, 2019, at 03:55, Laszlo Ersek wrote: >> >> I would strongly prefer if the guest-side view wouldn't change at all. > > It sounds like sector protection isn't something you want and it's not László is content with the status quo, but I'm not. > something

Re: [Qemu-devel] [Bug 1817239] [NEW] add '--targets' option to qemu-binfmt-conf.sh

2019-02-21 Thread Laurent Vivier
On 22/02/2019 04:31, Launchpad Bug Tracker wrote: > I'd like to ask for the addition of option '--targets' to scripts/qemu- > binfmt-conf.sh, in order to allow registering the interpreters for the > given list of architectures only, instead of using all of the ones > defined in qemu_target_list.

Re: [Qemu-devel] [PATCH v7 03/17] hw/arm/virt: Split the memory map description

2019-02-21 Thread Heyi Guo
Hi Eric, Can't we still use one single memory map and update the base of every entry following VIRT_MEM? So that we don't need to split memory map or the enumeration definition, neither do we need to copy a15memmap into the extended memmap. Thanks, Heyi On 2019/2/21 6:39, Eric Auger

Re: [Qemu-devel] [PATCH 05/10] ppc405_boards: Don't size flash memory to match backing image

2019-02-21 Thread Markus Armbruster
David Gibson writes: > On Thu, Feb 21, 2019 at 05:31:30PM +0100, Markus Armbruster wrote: >> Alex Bennée writes: >> >> > Markus Armbruster writes: >> > >> >> Machine "ref405ep" maps its flash memory at address 2^32 - image size. >> >> Image size is rounded up to the next multiple of 64KiB.

Re: [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand

2019-02-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/21/19 10:38 AM, Peter Maydell wrote: >> On Thu, 21 Feb 2019 at 09:22, Markus Armbruster wrote: >>> Double-checking... you want me to keep goto reset_flash, like this: >>> >>> @@ -623,8 +617,8 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr >>> offset,

Re: [Qemu-devel] [PATCH v6 1/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-02-21 Thread Yongji Xie
On Fri, 22 Feb 2019 at 14:21, Michael S. Tsirkin wrote: > > On Fri, Feb 22, 2019 at 10:47:03AM +0800, Yongji Xie wrote: > > > > + > > > > +To track inflight I/O, the queue region should be processed as follows: > > > > + > > > > +When receiving available buffers from the driver: > > > > + > > > >

Re: [Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn

2019-02-21 Thread Peter Xu
On Fri, Feb 22, 2019 at 07:37:02AM +0100, Marc-André Lureau wrote: > Hi > > On Fri, Feb 22, 2019 at 4:14 AM Peter Xu wrote: > > > > We were pushing the context until right before running the gmainloop. > > Now since we have everything unconditionally, we can move this > > earlier. > > > > One

Re: [Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally

2019-02-21 Thread Peter Xu
On Fri, Feb 22, 2019 at 07:29:09AM +0100, Marc-André Lureau wrote: [...] > > diff --git a/iothread.c b/iothread.c > > index 6e297e9ef1..6fa87876e0 100644 > > --- a/iothread.c > > +++ b/iothread.c > > @@ -65,7 +65,7 @@ static void *iothread_run(void *opaque) > > * We must check the

Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore

2019-02-21 Thread Peter Xu
On Fri, Feb 22, 2019 at 07:25:16AM +0100, Marc-André Lureau wrote: > Hi > > On Fri, Feb 22, 2019 at 4:14 AM Peter Xu wrote: > > > > Only sending an init-done message using lock+cond seems an overkill to > > me. Replacing it with a simpler semaphore. > > > > Meanwhile, init the semaphore

Re: [Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn

2019-02-21 Thread Marc-André Lureau
Hi On Fri, Feb 22, 2019 at 4:14 AM Peter Xu wrote: > > We were pushing the context until right before running the gmainloop. > Now since we have everything unconditionally, we can move this > earlier. > > One benefit is that now it's done even before init_done_sem, so as > long as the iothread

Re: [Qemu-devel] [PATCH 3/4] iothread: create main loop unconditionally

2019-02-21 Thread Marc-André Lureau
On Fri, Feb 22, 2019 at 4:14 AM Peter Xu wrote: > > Since we've have the gcontext always there, create the main loop > altogether. The iothread_run() is even cleaner. > > Signed-off-by: Peter Xu Reviewed-by: Marc-André Lureau > --- > iothread.c | 12 +++- > 1 file changed, 3

Re: [Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally

2019-02-21 Thread Marc-André Lureau
Hi On Fri, Feb 22, 2019 at 4:14 AM Peter Xu wrote: > > In existing code we create the gcontext dynamically at the first > access of the gcontext from caller. That can bring some complexity > and potential races during using iothread. Since the context itself > is not that big a resource, and

Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore

2019-02-21 Thread Marc-André Lureau
Hi On Fri, Feb 22, 2019 at 4:14 AM Peter Xu wrote: > > Only sending an init-done message using lock+cond seems an overkill to > me. Replacing it with a simpler semaphore. > > Meanwhile, init the semaphore unconditionally, then we can destroy it > unconditionally too in finalize which seems

[Qemu-devel] [PATCH 1/2] target/hppa: Do not return freed temporary

2019-02-21 Thread Richard Henderson
For priv levels 1 & 2, we were doing so from do_ibranch_priv. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b4fd307b77..dad8ce563c 100644 ---

Re: [Qemu-devel] [PATCH v6 1/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-02-21 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 10:47:03AM +0800, Yongji Xie wrote: > > > + > > > +To track inflight I/O, the queue region should be processed as follows: > > > + > > > +When receiving available buffers from the driver: > > > + > > > +1. Get the next available head-descriptor index from available

Re: [Qemu-devel] [PATCH] hw/ppc: Use object_initialize_child for correct reference counting

2019-02-21 Thread Thomas Huth
On 21/02/2019 19.14, Philippe Mathieu-Daudé wrote: > On 2/21/19 12:24 PM, Thomas Huth wrote: >> Both functions, object_initialize() and object_property_add_child() increase >> the reference counter of the new object, so one of the references has to be >> dropped afterwards to get the reference

[Qemu-devel] [PATCH 0/2] target/hppa: Minor fix and improvement

2019-02-21 Thread Richard Henderson
The first patch is via inspection. Linux only uses priv levels 0 and 3, and I suspect that HP-UX is the same. The second patch comes from examining traces. r~ Richard Henderson (2): target/hppa: Do not return freed temporary target/hppa: Optimize blr r0,rn target/hppa/translate.c | 21

[Qemu-devel] [PATCH] fixup! display: add -display spice-app launching a Spice client

2019-02-21 Thread Marc-André Lureau
--- ui/spice-app.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-app.c b/ui/spice-app.c index 4f5229f3ee..925b27b708 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -181,6 +181,8 @@ static void spice_app_display_init(DisplayState *ds, DisplayOptions *opts)

[Qemu-devel] [PATCH 2/2] target/hppa: Optimize blr r0,rn

2019-02-21 Thread Richard Henderson
We can eliminate an extra TB in this case, which merely loads a "return address" into rn. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

[Qemu-devel] [PATCH] tcg/ppc: Add vector opcodes

2019-02-21 Thread Richard Henderson
This requires VSX, not just Altivec, so Power7 or later. Signed-off-by: Richard Henderson --- At present there are no tunables that can avoid the 64-bit element load/store requirement. As with requiring AVX1 for x86 hosts, I'm not sure it's worth inventing such a tunable for pre-power7 hosts.

Re: [Qemu-devel] [PATCH] hw/arm: Use object_initialize_child for correct reference counting

2019-02-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > As Thomas Huth explained: > "Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference counting > right. Otherwise the child

Re: [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client

2019-02-21 Thread Gerd Hoffmann
Hi, > Would something like that be helpful? > > diff --git a/ui/spice-app.c b/ui/spice-app.c > index 4f5229f3ee..69f92e440c 100644 > --- a/ui/spice-app.c > +++ b/ui/spice-app.c > @@ -181,6 +181,7 @@ static void spice_app_display_init(DisplayState > *ds, DisplayOptions *opts) >

[Qemu-devel] [PATCH v3 2/3] vfio/display: add xres + yres properties

2019-02-21 Thread Gerd Hoffmann
This allows configure the display resolution which the vgpu should use. The information will be passed to the guest using EDID, so the mdev driver must support the vfio edid region for this to work. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 2 ++ hw/vfio/display.c | 12 ++--

[Qemu-devel] [PATCH v3 1/3] vfio/display: add edid support.

2019-02-21 Thread Gerd Hoffmann
This patch adds EDID support to the vfio display (aka vgpu) code. When supported by the mdev driver qemu will generate a EDID blob and pass it on using the new vfio edid region. The EDID blob will be updated on UI changes (i.e. window resize), so the guest can adapt. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH v3 3/3] vfio/display: delay link up event

2019-02-21 Thread Gerd Hoffmann
Kick the display link up event with a 0.1 sec delay, so the guest has a chance to notice the link down first. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/display.c | 26 +++--- 2 files changed, 24 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH v3 0/3] vfio/display: add edid support.

2019-02-21 Thread Gerd Hoffmann
The 5.0 linux kernel header update finally landed in master. So this series has no unmerged dependencies any more. Rebasing and re-sending for merge. This series adds EDID support to the qemu vfio display code. Various display-reladed information -- most importantly the display resolution

Re: [Qemu-devel] [PATCH v2 1/3] vfio/display: add edid support.

2019-02-21 Thread Gerd Hoffmann
Hi, > This is the vdagent using installation like this: > > https://www.ovirt.org/develop/infra/testing/spice.html > > ie. vdservice install, net start vdservice? If the page says so, probably. I've tested the agent setup with linux only, where everything happens automatically, you only

[Qemu-devel] [PULL 2/2] hw/vfio/common: Refactor container initialization

2019-02-21 Thread Alex Williamson
From: Eric Auger We introduce the vfio_init_container_type() helper. It computes the highest usable iommu type and then set the container and the iommu type. Its usage in vfio_connect_container() makes the code ready for addition of new iommu types. Signed-off-by: Eric Auger Reviewed-by: Greg

[Qemu-devel] [PULL 1/2] vfio/common: Work around kernel overflow bug in DMA unmap

2019-02-21 Thread Alex Williamson
A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which adds a test for address space wrap-around in the vfio DMA unmap path. Unfortunately due to overflow, the kernel detects an unmap of the last page in the 64-bit address space as a wrap-around. In QEMU, a Q35 guest with VT-d

[Qemu-devel] [PULL 0/2] vfio updates 2019-02-21

2019-02-21 Thread Alex Williamson
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git

Re: [Qemu-devel] [PATCH] hw/arm: Use object_initialize_child for correct reference counting

2019-02-21 Thread Thomas Huth
On 21/02/2019 19.38, Philippe Mathieu-Daudé wrote: > As Thomas Huth explained: > "Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference counting > right.

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Michael S. Tsirkin
On Thu, Feb 21, 2019 at 10:10:08PM -0500, Michael S. Tsirkin wrote: > On Fri, Feb 22, 2019 at 11:04:05AM +0800, Jason Wang wrote: > > > > On 2019/2/22 上午9:35, Michael S. Tsirkin wrote: > > > On Thu, Feb 21, 2019 at 05:40:22PM +0800, Jason Wang wrote: > > > > On 2019/2/21 下午4:18, Yuri Benditovich

[Qemu-devel] [Bug 1817239] [NEW] add '--targets' option to qemu-binfmt-conf.sh

2019-02-21 Thread umarcor
Public bug reported: I'd like to ask for the addition of option '--targets' to scripts/qemu- binfmt-conf.sh, in order to allow registering the interpreters for the given list of architectures only, instead of using all of the ones defined in qemu_target_list. The following is a possible patch

Re: [Qemu-devel] [PATCH 1/4] iothread: wait until the glib context is acquired

2019-02-21 Thread Peter Xu
On Thu, Feb 21, 2019 at 11:39:32AM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Feb 21, 2019 at 9:00 AM Peter Xu wrote: > > > > On Wed, Feb 20, 2019 at 05:06:25PM +0100, Marc-André Lureau wrote: > > > Another thread may acquire the glib context (temporarily) before > > >

[Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn

2019-02-21 Thread Peter Xu
We were pushing the context until right before running the gmainloop. Now since we have everything unconditionally, we can move this earlier. One benefit is that now it's done even before init_done_sem, so as long as the iothread user calls iothread_create() and completes, we know that the thread

[Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally

2019-02-21 Thread Peter Xu
When I first read the iothread code, the gcontext confused me for quite a while. Meanwhile, I've been tackling with some races due to this complexity as well. How much we'll pay for creating the gcontext unconditionally? Do we really need this flexibitily (or is it really a flexibility after

[Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally

2019-02-21 Thread Peter Xu
In existing code we create the gcontext dynamically at the first access of the gcontext from caller. That can bring some complexity and potential races during using iothread. Since the context itself is not that big a resource, and we won't have millions of iothread, let's simply create the

[Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore

2019-02-21 Thread Peter Xu
Only sending an init-done message using lock+cond seems an overkill to me. Replacing it with a simpler semaphore. Meanwhile, init the semaphore unconditionally, then we can destroy it unconditionally too in finalize which seems cleaner. Signed-off-by: Peter Xu --- include/sysemu/iothread.h |

[Qemu-devel] [PATCH 3/4] iothread: create main loop unconditionally

2019-02-21 Thread Peter Xu
Since we've have the gcontext always there, create the main loop altogether. The iothread_run() is even cleaner. Signed-off-by: Peter Xu --- iothread.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/iothread.c b/iothread.c index 6fa87876e0..9abdbace66 100644

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 11:04:05AM +0800, Jason Wang wrote: > > On 2019/2/22 上午9:35, Michael S. Tsirkin wrote: > > On Thu, Feb 21, 2019 at 05:40:22PM +0800, Jason Wang wrote: > > > On 2019/2/21 下午4:18, Yuri Benditovich wrote: > > > > > > For 1.0 device, we can fix the queue_enable, but

[Qemu-devel] [PULL 17/26] contrib/vhost-user-blk: fix the compilation issue

2019-02-21 Thread Michael S. Tsirkin
From: Changpeng Liu Signed-off-by: Changpeng Liu Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin Message-Id: <1547615970-23545-2-git-send-email-changpeng@intel.com> [PMD: this patch was first (incorrectly) introduced as a56de056c91f8]

[Qemu-devel] [PULL 10/26] roms: add the edk2 project as a git submodule

2019-02-21 Thread Michael S. Tsirkin
From: Laszlo Ersek The roms/edk2 submodule can help with three goals: - build the OVMF and ArmVirtQemu virtual UEFI firmware platforms (to be implemented later), - build the EfiRom tool on the fly, which is used in roms/Makefile, for building the "efirom" target, - build UEFI test

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Jason Wang
On 2019/2/22 上午9:35, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 05:40:22PM +0800, Jason Wang wrote: On 2019/2/21 下午4:18, Yuri Benditovich wrote: For 1.0 device, we can fix the queue_enable, but for 0.9x device how do you enable one specific queue in this case?

[Qemu-devel] [PULL 13/26] tests/uefi-test-tools: add build scripts

2019-02-21 Thread Michael S. Tsirkin
From: Laszlo Ersek Introduce the following build scripts under "tests/uefi-test-tools": * "build.sh" builds a single module (a UEFI application) from UefiTestToolsPkg, for a single QEMU emulation target. "build.sh" relies on cross-compilers when the emulation target and the build host

[Qemu-devel] [PULL 12/26] tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI app

2019-02-21 Thread Michael S. Tsirkin
From: Laszlo Ersek The "bios-tables-test" program in QEMU's test suite locates the RSD PTR ACPI table in guest RAM, and (chasing pointers to other ACPI tables) performs various sanity checks on the QEMU-generated and firmware-installed tables. Currently this set of test cases doesn't work with

[Qemu-devel] [PATCH v3 2/3] target/arm: Rebuild hflags at el changes and MSR writes

2019-02-21 Thread Richard Henderson
Now setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Fixed partial conversion to assignment to env->hflags. --- target/arm/internals.h | 1 + linux-user/syscall.c | 1 + target/arm/cpu.c | 1 +

[Qemu-devel] [PATCH v3 3/3] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

2019-02-21 Thread Richard Henderson
This is the payoff. >From perf record -g data of ubuntu 18 boot and shutdown: BEFORE: - 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr - 20.22% helper_lookup_tb_ptr + 10.05% tb_htable_lookup - 9.13% cpu_get_tb_cpu_state 3.20% aa64_va_parameters_both

Re: [Qemu-devel] [PATCH v6 1/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-02-21 Thread Yongji Xie
On Fri, 22 Feb 2019 at 01:27, Michael S. Tsirkin wrote: > > On Mon, Feb 18, 2019 at 06:27:42PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD > > and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared > >

[Qemu-devel] [PULL 14/26] tests/data: introduce "uefi-boot-images" with the "bios-tables-test" ISOs

2019-02-21 Thread Michael S. Tsirkin
From: Laszlo Ersek Add UEFI-bootable qcow2-compressed ISO images built from: tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest Cc: "Michael S. Tsirkin" Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Philippe Mathieu-Daudé Cc: Shannon Zhao Signed-off-by: Laszlo Ersek

[Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests

2019-02-21 Thread Michael S. Tsirkin
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PATCH v3 1/3] target/arm: Split out recompute_hflags et al

2019-02-21 Thread Richard Henderson
We will use these to minimize the computation for every call to cpu_get_tb_cpu_state. For now, the env->hflags variable is not used. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v3: Do not cache VECLEN, VECSTRIDE, VFPEN. Move HANDLER and STACKCHECK to rebuild_hflags_a32.

[Qemu-devel] [PATCH v3 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-02-21 Thread Richard Henderson
Changes since v2: * Do not cache VECLEN, VECSTRIDE, VFPEN. These variables come from VFP_FPSCR and VFP_FPEXC, not from system control registers. * Move HANDLER and STACKCHECK to rebuild_hflags_a32, instead of building them in rebuild_hflags_common. Changes since v1: * Apparently

[Qemu-devel] [PULL 16/26] Revert "contrib/vhost-user-blk: fix the compilation issue"

2019-02-21 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Commit a56de056c91f8 squashed the following two unrelated commits at once: - "contrib/vhost-user-blk: fix the compilation issue" (Message-Id: 1547615970-23545-2-git-send-email-changpeng@intel.com) - "i386/kvm: ignore masked irqs when update msi routes"

[Qemu-devel] [PULL 15/26] pc-dimm: use same mechanism for [get|set]_addr

2019-02-21 Thread Michael S. Tsirkin
From: Wei Yang [get|set]_addr are two counterpart to access PCDIMMDevice.addr. Since we have already set up a property PC_DIMM_ADDR_PROP for this field and use this mechanism in set_addr, it would be more proper to use the same mechanism in get_addr. This patch uses object_property_get_uint()

[Qemu-devel] [PULL 11/26] roms: build the EfiRom utility from the roms/edk2 submodule

2019-02-21 Thread Michael S. Tsirkin
From: Laszlo Ersek Building the EfiRom utility from "roms/edk2/BaseTools" should make "roms/Makefile" more self-contained. Otherwise, we'd call the system-wide EfiRom for building the combined iPXE option ROMs, but call the sibling utilities from "roms/edk2/BaseTools" for building "roms/edk2"

[Qemu-devel] [PULL 18/26] i386/kvm: ignore masked irqs when update msi routes

2019-02-21 Thread Michael S. Tsirkin
From: Peter Xu When we are with intel-iommu device and with IR on, KVM will register an IEC notifier to detect interrupt updates from the guest and we'll kick off kvm_update_msi_routes_all() when it happens to make sure kernel IRQ cache is matching the latest. Though,

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Michael S. Tsirkin
On Thu, Feb 21, 2019 at 05:40:22PM +0800, Jason Wang wrote: > > On 2019/2/21 下午4:18, Yuri Benditovich wrote: > > For 1.0 device, we can fix the queue_enable, but for 0.9x device how > do > you enable one specific queue in this case? (setting status?) > > > Do I understand

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-02-21 Thread Wei Wang
On 02/21/2019 06:18 PM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: On 02/20/2019 09:12 PM, Dr. David Alan Gilbert wrote: * Wang, Wei W (wei.w.w...@intel.com) wrote: On Friday, December 14, 2018 7:17 PM, Dr. David Alan Gilbert wrote: On 12/14/2018 05:56 PM, Dr.

Re: [Qemu-devel] [PATCH v3 02/25] chardev: Assert IOCanReadHandler can not be negative

2019-02-21 Thread Philippe Mathieu-Daudé
On 2/20/19 12:13 PM, Philippe Mathieu-Daudé wrote: > On 2/20/19 11:03 AM, Marc-André Lureau wrote: >> Hi >> >> On Wed, Feb 20, 2019 at 2:03 AM Philippe Mathieu-Daudé >> wrote: >>> >>> The backend should not return a negative length to read. >>> We will later change the prototype of

Re: [Qemu-devel] [PATCH v8 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2019-02-21 Thread Philippe Mathieu-Daudé
Hi Daniel, On 2/15/19 4:57 PM, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > Add an authorization backend that talks to PAM to check whether the user > identity is allowed. This only uses the PAM account validation facility, > which is essentially just a check to see if the

Re: [Qemu-devel] [PULL 8/9] usb: add device checks before redirector calls to usb_ep_get()

2019-02-21 Thread Liam Merwick
On 20/02/2019 11:24, Yuval Shaia wrote: On Wed, Feb 20, 2019 at 12:13:45PM +0100, Gerd Hoffmann wrote: From: Liam Merwick Add an assert and an explicit check before the two callers to usb_ep_get() in the USB redirector code to ensure the device passed in is not NULL. Signed-off-by: Liam

Re: [Qemu-devel] [PATCH] iotests: handle TypeError for Python3 in test 242

2019-02-21 Thread Cleber Rosa
On 2/18/19 4:25 PM, Philippe Mathieu-Daudé wrote: > On 2/18/19 9:05 PM, Eric Blake wrote: >> [adding Eduardo for some python 2-vs-3 advice] > > And Cleber. > >> >> On 2/18/19 1:59 PM, Andrey Shinkevich wrote: >>> To write one byte to disk, Python2 may use 'chr' type. >>> In Python3,

Re: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-02-21 Thread Richard Henderson
On 2/21/19 2:59 PM, Emilio G. Cota wrote: > Should have done so the first time. Here it is: > > (gdb) r > Starting program: /data/src/qemu/build/arm-softmmu/qemu-system-arm -machine > type=virt -nographic -m 4096 -netdev

Re: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-02-21 Thread Emilio G. Cota
On Thu, Feb 21, 2019 at 22:36:25 +, Alex Bennée wrote: > Emilio G. Cota writes: > > This brings my arm-softmmu bootup+shutdown test to an early death: > > Can you retry with --enable-tcg-debug? Should have done so the first time. Here it is: (gdb) r

Re: [Qemu-devel] [PATCH] hw/ppc: Use object_initialize_child for correct reference counting

2019-02-21 Thread David Gibson
On Thu, Feb 21, 2019 at 12:24:48PM +0100, Thomas Huth wrote: > Both functions, object_initialize() and object_property_add_child() increase > the reference counter of the new object, so one of the references has to be > dropped afterwards to get the reference counting right. Otherwise the child >

Re: [Qemu-devel] [PATCH v4] ppc: add host-serial and host-model machine attributes

2019-02-21 Thread David Gibson
On Thu, Feb 21, 2019 at 09:25:46AM +, Daniel P. Berrangé wrote: > On Tue, Feb 19, 2019 at 01:55:01PM +1100, David Gibson wrote: > > On Mon, Feb 18, 2019 at 11:43:49PM +0530, P J P wrote: > > > From: Prasad J Pandit > > > > > > On ppc hosts, hypervisor shares following system attributes > > >

Re: [Qemu-devel] [PATCH v3 3/5] Add migration functions for VFIO devices

2019-02-21 Thread Alex Williamson
On Wed, 20 Feb 2019 02:53:18 +0530 Kirti Wankhede wrote: > - Migration function are implemented for VFIO_DEVICE_TYPE_PCI device. > - Added SaveVMHandlers and implemented all basic functions required for live > migration. > - Added VM state change handler to know running or stopped state of VM.

Re: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-02-21 Thread Alex Bennée
Emilio G. Cota writes: > On Tue, Feb 19, 2019 at 15:34:18 -0800, Richard Henderson wrote: >> Changes since v1: >> * Apparently I had started a last-minute API change, and failed to >> covert all of the users, and also failed to re-test afterward. >> * Retain assertions for

Re: [Qemu-devel] [PATCH 05/10] ppc405_boards: Don't size flash memory to match backing image

2019-02-21 Thread David Gibson
On Thu, Feb 21, 2019 at 05:31:30PM +0100, Markus Armbruster wrote: > Alex Bennée writes: > > > Markus Armbruster writes: > > > >> Machine "ref405ep" maps its flash memory at address 2^32 - image size. > >> Image size is rounded up to the next multiple of 64KiB. Useless, > >> because

Re: [Qemu-devel] [PATCH v3 1/5] VFIO KABI for migration interface

2019-02-21 Thread Alex Williamson
On Wed, 20 Feb 2019 02:53:16 +0530 Kirti Wankhede wrote: > - Defined MIGRATION region type and sub-type. > - Used 2 bits to define VFIO device states. > Bit 0 => 0/1 => _STOPPED/_RUNNING > Bit 1 => 0/1 => _RESUMING/_SAVING > Combination of these bits defines VFIO device's state

Re: [Qemu-devel] [PATCH v6 2/2] gen_pcie_root_port: Add ACS (Access Control Services) capability

2019-02-21 Thread Alex Williamson
On Thu, 21 Feb 2019 19:13:23 +0100 Knut Omang wrote: > Claim ACS support in the generic PCIe root port to allow > passthrough of individual functions of a device to different > guests (in a nested virt.setting) with VFIO. > Without this patch, all functions of a device, such as all VFs of > an

Re: [Qemu-devel] [PATCH v6 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-21 Thread Alex Williamson
On Thu, 21 Feb 2019 19:13:22 +0100 Knut Omang wrote: > Implementing an ACS capability on downstream ports and multifunction > endpoints indicates isolation and IOMMU visibility to a finer > granularity. This creates smaller IOMMU groups in the guest and thus > more flexibility in assigning

Re: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-02-21 Thread Emilio G. Cota
On Tue, Feb 19, 2019 at 15:34:18 -0800, Richard Henderson wrote: > Changes since v1: > * Apparently I had started a last-minute API change, and failed to > covert all of the users, and also failed to re-test afterward. > * Retain assertions for --enable-debug-tcg. This brings my

Re: [Qemu-devel] [PATCH 0/1] snip my name and email

2019-02-21 Thread David Kiarie
On Thu, Feb 21, 2019 at 7:09 PM Jan Kiszka wrote: > On 21.02.19 17:05, Eric Blake wrote: > > On 2/21/19 9:53 AM, David Kiarie wrote: > >> the occurrence of my name and email on the files below may have led to > >> some confusion in the reporting of a few recent bugs. > >> > >> i have therefore

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Philippe Mathieu-Daudé
Hi Alex, On 2/21/19 7:48 PM, Alex Bennée wrote: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-21 Thread Alex Williamson
Hi Yan, Thanks for working on this! On Tue, 19 Feb 2019 16:50:54 +0800 Yan Zhao wrote: > This patchset enables VFIO devices to have live migration capability. > Currently it does not support post-copy phase. > > It follows Alex's comments on last version of VFIO live migration patches, >

Re: [Qemu-devel] [PATCH 06/51] build: switch to Kconfig

2019-02-21 Thread Stefano Garzarella
Il giorno gio 21 feb 2019 alle 19:00 Paolo Bonzini ha scritto: > On 21/02/19 16:44, Stefano Garzarella wrote: > >> + > > Hi Paolo, > > I'm playing with Kconfig but with a simple configuration > > (./configure --target-list=x86_64-softmmu --disable-docs) the build > fails: > > /usr/bin/ld:

Re: [Qemu-devel] [PULL 0/3] Bitmaps patches

2019-02-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190213234907.24173-1-js...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Alex Bennée
Laszlo Ersek writes: > On 02/21/19 19:48, Alex Bennée wrote: >> It looks like there was going to be code to check we had some sort of >> alignment so lets replace it with an actual check. This is a bit more >> useful than the enigmatic "failed to read the initial flash content" >> when we

Re: [Qemu-devel] Testing sysbus devices

2019-02-21 Thread Stephen Checkoway
> On Feb 20, 2019, at 03:55, Laszlo Ersek wrote: > > I would strongly prefer if the guest-side view wouldn't change at all. It sounds like sector protection isn't something you want and it's not something I currently need so unless that changes, I probably won't do anything with it. My

Re: [Qemu-devel] [PATCH] qemu-img: implement copy offload (-C) for dd

2019-02-21 Thread Sergio Lopez
On Thu, Feb 21, 2019 at 12:08:12PM -0600, Eric Blake wrote: > On 2/21/19 11:37 AM, Sergio Lopez wrote: > > This parameter is analogous to convert's "-C", making use of > > bdrv_co_copy_range(). > > The last time I tried to patch 'qemu-img dd', it was pointed out that it > already has several bugs

[Qemu-devel] [PULL 0/1] target/hppa patch queue

2019-02-21 Thread Richard Henderson
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-hppa-20190221

[Qemu-devel] [PULL 1/2] tcg: Remove TODO file

2019-02-21 Thread Richard Henderson
The last update to this file was 9 years ago. In the meantime, 4 of the 6 ideas have actually been completed. The lat two do not actually make sense anymore. Suggested-by: Thomas Huth Signed-off-by: Richard Henderson --- tcg/TODO | 14 -- 1 file changed, 14 deletions(-) delete

[Qemu-devel] [PULL 17/21] hw/arm/musca: Add PPCs

2019-02-21 Thread Peter Maydell
Many of the devices on the Musca board live behind TrustZone Peripheral Protection Controllers (PPCs); add models of the PPCs, using a similar scheme to the MPS2 board models. This commit wires up the PPCs with "unimplemented device" stubs behind them in the correct places in the address map.

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Laszlo Ersek
On 02/21/19 19:48, Alex Bennée wrote: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the number of bytes

[Qemu-devel] [PULL 16/21] hw/arm/musca.c: Implement models of the Musca-A and -B1 boards

2019-02-21 Thread Peter Maydell
The Musca-A and Musca-B1 development boards are based on the SSE-200 subsystem for embedded. Implement an initial skeleton model of these boards, which are similar but not identical. This commit creates the board model with the SSE and the IRQ splitters to wire IRQs up to its two CPUs. As yet

[Qemu-devel] [PULL 2/2] include/exec/helper-head.h: support "const void *" in helper calls

2019-02-21 Thread Richard Henderson
From: David Hildenbrand Especially when dealing with out-of-line gvec helpers, it is often helpful to specify some vector pointers as constant. E.g. when we have two inputs and one output, marking the two inputs as consts pointers helps to avoid bugs. Const pointers can be specified via "cptr",

[Qemu-devel] [PULL 20/21] hw/arm/musca: Wire up PL011 UARTs

2019-02-21 Thread Peter Maydell
Wire up the two PL011 UARTs in the Musca board. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- hw/arm/musca.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/arm/musca.c b/hw/arm/musca.c index 378912b7385..23aff43f4bc

[Qemu-devel] [PULL 07/21] target/arm: Implement ARMv8.3-JSConv

2019-02-21 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20190215192302.27855-5-richard.hender...@linaro.org Reviewed-by: Peter Maydell [PMM: fixed a couple of comment typos] Signed-off-by: Peter Maydell --- target/arm/cpu.h | 10 + target/arm/helper.h| 3

[Qemu-devel] [PULL 0/2] tcg patch queue

2019-02-21 Thread Richard Henderson
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20190221

Re: [Qemu-devel] [libvirt] Libvirt upstream CI efforts

2019-02-21 Thread Cleber Rosa
On 2/21/19 12:56 PM, Daniel P. Berrangé wrote: > On Thu, Feb 21, 2019 at 03:39:15PM +0100, Erik Skultety wrote: >> Hi, >> I'm starting this thread in order to continue with the ongoing efforts to >> bring actual integration testing to libvirt. Currently, the status quo is >> that >> we build

[Qemu-devel] [PULL 21/21] hw/arm/armsse: Make 0x5... alias region work for per-CPU devices

2019-02-21 Thread Peter Maydell
The region 0x4001 .. 0x4001 and its secure-only alias at 0x5001... are for per-CPU devices. We implement this by giving each CPU its own container memory region, where the per-CPU devices live. Unfortunately, the alias region which makes devices mapped at 0x4... addresses also appear

  1   2   3   4   >