Re: [Qemu-devel] [PATCH] qemu-img: implement copy offload (-C) for dd

2019-02-25 Thread Kevin Wolf
Am 25.02.2019 um 14:40 hat Sergio Lopez geschrieben: > On Fri, Feb 22, 2019 at 11:04:25AM +0100, Kevin Wolf wrote: > > Am 21.02.2019 um 20:32 hat Sergio Lopez geschrieben: > > > On Thu, Feb 21, 2019 at 12:08:12PM -0600, Eric Blake wrote: > > > > On 2/21/19 11:37 AM, Sergio Lopez wrote: > > > > > Th

[Qemu-devel] can we disable the migration-test for TCG targets ?

2019-02-25 Thread Peter Maydell
Hi; the migration-test is failing really frequently for me for TCG targets (usually on sparc64 host) -- can we just disable it from the test set until we've figured out and implemented a fix for the underlying TCG bug, please? thanks -- PMM

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-25 Thread Eric Blake
On 2/22/19 6:22 PM, John Snow wrote: > Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as > persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 > that have been marked as "in use". > > Signed-off-by: John Snow > --- > block/dirty-bitmap.c

Re: [Qemu-devel] [PATCH] qemu-img: implement copy offload (-C) for dd

2019-02-25 Thread Sergio Lopez
On Fri, Feb 22, 2019 at 11:04:25AM +0100, Kevin Wolf wrote: > Am 21.02.2019 um 20:32 hat Sergio Lopez geschrieben: > > On Thu, Feb 21, 2019 at 12:08:12PM -0600, Eric Blake wrote: > > > On 2/21/19 11:37 AM, Sergio Lopez wrote: > > > > This parameter is analogous to convert's "-C", making use of > >

Re: [Qemu-devel] [PATCH v2 0/2] block/ssh: Implement .bdrv_refresh_filename()

2019-02-25 Thread Max Reitz
On 06.02.19 16:29, Max Reitz wrote: > This series implements .bdrv_refresh_filename() for the ssh block > driver, along with an appropriate .bdrv_dirname() so we don't chop off > query strings for backing files with relative filenames. > > This series depends on my "block: Fix some filename genera

Re: [Qemu-devel] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bitmap_check function

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:22, John Snow wrote: > Instead of checking against busy, inconsistent, or read only directly, > use a check function with permissions bits that let us streamline the > checks without reproducing them in many places. > > As a side effect, this adds consistency checks to all the QMP > i

Re: [Qemu-devel] [PATCH] iotests: Skip 211 on insufficient memory

2019-02-25 Thread Max Reitz
On 18.02.19 19:06, Max Reitz wrote: > VDI keeps the whole bitmap in memory, and the maximum size (which is > tested here) is 2 GB. This may not be available on all machines, and it > rarely is available when running a 32 bit build. > > Fix this by making VM.run_job() return the error string if an

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Fernando Casas Schössow
Thanks Natanael. Is the new package ready? I will update as soon as the package is available, try to repro and report back. Thanks everyone for looking into this! On lun, feb 25, 2019 at 2:25 PM, Natanael Copa wrote: On Mon, 25 Feb 2019 13:06:16 + Peter Maydell mailto:peter.mayd...@linaro.

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Natanael Copa
On Mon, 25 Feb 2019 13:06:16 + Peter Maydell wrote: > On Mon, 25 Feb 2019 at 12:22, Natanael Copa wrote: > > > > On Mon, 25 Feb 2019 10:34:23 + > > Peter Maydell wrote: > > > The short term fix is to fix your toolchain/compilation > > > environment options so that it isn't trying to o

Re: [Qemu-devel] [PATCH v1 3/7] s390x/tcg: Clarify terminology in vec_reg_offset()

2019-02-25 Thread David Hildenbrand
On 25.02.19 13:30, Thomas Huth wrote: > On 25/02/2019 12.55, David Hildenbrand wrote: >> We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1 >> ... Simple rename of variables. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/translate.c | 10 +- >> 1 file ch

Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread David Hildenbrand
On 25.02.19 13:21, Cornelia Huck wrote: > On Mon, 25 Feb 2019 12:55:47 +0100 > David Hildenbrand wrote: > >> Let's simply initialization to 0. > > "Let's simply zero-initialize the structure." ? Or "s/simply/simplify/", whatever you prefer. > >> >> Signed-off-by: David Hildenbrand >> --- >>

Re: [Qemu-devel] [Qemu-block] [PATCH] vmdk: false positive of compat6 with hwversion not set

2019-02-25 Thread Max Reitz
On 21.02.19 12:08, yuchen...@synology.com wrote: > From: yuchenlin > > In vmdk_co_create_opts, when it finds hw_version is undefined, it will > set it to 4, which misleading the compat6 and hwversion in > vmdk_co_do_create. Simply set hw_version to NULL after free, let > the logic in vmdk_co_do_c

Re: [Qemu-devel] [PATCH 12/15] s390-bios: Refactor virtio to run channel programs via cio

2019-02-25 Thread Jason J. Herne
On 2/4/19 6:44 AM, Cornelia Huck wrote: On Tue, 29 Jan 2019 08:29:19 -0500 "Jason J. Herne" wrote: Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/virtio.c | 48 +

Re: [Qemu-devel] [PATCH] qcow2: Assert that L2 table offsets fit in the L1 table

2019-02-25 Thread Alberto Garcia
ping On Fri 08 Feb 2019 04:44:53 PM CET, Alberto Garcia wrote: > L1 table entries have a field to store the offset of an L2 table. > The rest of the bits of the entry are currently reserved except from > bit 63, which stores the COPIED flag. > > The offset is always taken from the entry using L1E_

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Peter Maydell
On Mon, 25 Feb 2019 at 12:22, Natanael Copa wrote: > > On Mon, 25 Feb 2019 10:34:23 + > Peter Maydell wrote: > > The short term fix is to fix your toolchain/compilation > > environment options so that it isn't trying to override > > the definition of memcpy(). > > The easiest workaround is to

Re: [Qemu-devel] [PATCH] block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct

2019-02-25 Thread Peter Maydell
On Mon, 25 Feb 2019 at 11:59, Thomas Huth wrote: > > The QEMU_PACKED is causing a compiler warning/error with GCC 9: > > CC block/nvme.o > block/nvme.c: In function ‘nvme_create_queue_pair’: > block/nvme.c:209:22: error: taking address of packed member of > ‘struct ’ may result in an unali

Re: [Qemu-devel] [PULL 00/15] Ui 20190222 patches

2019-02-25 Thread Peter Maydell
On Fri, 22 Feb 2019 at 07:55, Gerd Hoffmann wrote: > > The following changes since commit 2e68b8620637a4ee8c79b5724144b726af1e261b: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20190219' > into staging (2019-02-18 16:20:13 +) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH v3 0/2] s390x/vfio-ap: hot plug/unplug vfio-ap device

2019-02-25 Thread Cornelia Huck
On Mon, 18 Feb 2019 14:49:55 -0500 Tony Krowiak wrote: > This patch series introduces hot plug/unplug of a vfio-ap device. > > To hot plug a vfio-ap device, the QEMU device_add function may be used: > >(qemu) device_add vfio-ap,sysfsdev=$path-to-mdev > >Where $path-to-mdev is the absol

Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup

2019-02-25 Thread Wei Yang
On Mon, Feb 25, 2019 at 09:05:37AM +0100, Igor Mammedov wrote: >On Sat, 23 Feb 2019 00:02:49 + >Wei Yang wrote: > >> On Thu, Feb 21, 2019 at 03:50:04PM +0100, Igor Mammedov wrote: >> >On Wed, 20 Feb 2019 08:51:21 +0800 >> >Wei Yang wrote: >> > >> >> Three trivial cleanup for pc-dimm. >> >> >

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-25 Thread Michael S. Tsirkin
On Mon, Feb 25, 2019 at 03:47:48PM +0800, Jason Wang wrote: > > On 2019/2/22 下午12:22, Michael S. Tsirkin wrote: > > On Thu, Feb 21, 2019 at 10:10:08PM -0500, Michael S. Tsirkin wrote: > > > On Fri, Feb 22, 2019 at 11:04:05AM +0800, Jason Wang wrote: > > > > On 2019/2/22 上午9:35, Michael S. Tsirkin

[Qemu-devel] [PULL 11/11] authz: delete existing ACL implementation

2019-02-25 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulate it. The new QAuthZ subclasses provide a supe

Re: [Qemu-devel] [PATCH v1 4/7] s390x/tcg: Factor out vec_full_reg_offset()

2019-02-25 Thread Thomas Huth
On 25/02/2019 12.55, David Hildenbrand wrote: > We'll use that a lot along with gvec helpers, to calculate the start > address of a vector. > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tar

[Qemu-devel] [PULL 06/11] authz: add QAuthZ object as an authorization base class

2019-02-25 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server) wer

[Qemu-devel] [PULL 09/11] authz: add QAuthZListFile object type for a file access control list

2019-02-25 Thread Daniel P . Berrangé
Add a QAuthZListFile object type that implements the QAuthZ interface. This built-in implementation is a proxy around the QAuthZList object type, initializing it from an external file, and optionally, automatically reloading it whenever it changes. To create an instance of this object via the QMP

[Qemu-devel] [PULL 05/11] hw/usb: switch MTP to use new inotify APIs

2019-02-25 Thread Daniel P . Berrangé
The internal inotify APIs allow a lot of conditional statements to be cleared out, and provide a simpler callback for handling events. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c| 274 ++-- hw/usb/trace-events

[Qemu-devel] [PULL 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2019-02-25 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Add an authorization backend that talks to PAM to check whether the user identity is allowed. This only uses the PAM account validation facility, which is essentially just a check to see if the provided username is permitted access. It doesn't use the authentication or

[Qemu-devel] [PULL 01/11] util: add helper APIs for dealing with inotify in portable manner

2019-02-25 Thread Daniel P . Berrangé
The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Wrapping it also allows introduction of a platform portability layer, so that we can add impls for non-Linux based equivalents in fu

[Qemu-devel] [PULL 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver

2019-02-25 Thread Daniel P . Berrangé
IN_ISDIR is not a bit that one can request when registering a watch with inotify_add_watch. Rather it is a bit that is set automatically when reading events from the kernel. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.

[Qemu-devel] [PULL 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks

2019-02-25 Thread Daniel P . Berrangé
In many cases a single VM will just need to whitelist a single identity as the allowed user of network services. This is especially the case for TLS live migration (optionally with NBD storage) where we just need to whitelist the x509 certificate distinguished name of the source QEMU host. Via QMP

[Qemu-devel] [PULL 02/11] qom: don't require user creatable objects to be registered

2019-02-25 Thread Daniel P . Berrangé
When an object is in turn owned by another user object, it is not desirable to expose this in the QOM object hierarchy. It is just an internal implementation detail, we should be free to change without exposure to apps managing QEMU. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Da

[Qemu-devel] [PULL 00/11] Merge authz core patches

2019-02-25 Thread Daniel P . Berrangé
The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190221.0' into staging (2019-02-22 15:48:04 +) are available in the Git repository at: https://github.com/berrange/qemu tags/authz-core-pull-re

[Qemu-devel] [PULL 08/11] authz: add QAuthZList object type for an access control list

2019-02-25 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Add a QAuthZList object type that implements the QAuthZ interface. This built-in implementation maintains a trivial access control list with a sequence of match rules and a final default policy. This replicates the functionality currently provided by the qemu_acl module

[Qemu-devel] [PULL 04/11] hw/usb: fix const-ness for string params in MTP driver

2019-02-25 Thread Daniel P . Berrangé
Various functions accepting 'char *' string parameters were missing 'const' qualifiers. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb/d

Re: [Qemu-devel] [PATCH v1 3/7] s390x/tcg: Clarify terminology in vec_reg_offset()

2019-02-25 Thread Thomas Huth
On 25/02/2019 12.55, David Hildenbrand wrote: > We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1 > ... Simple rename of variables. > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > di

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Natanael Copa
On Mon, 25 Feb 2019 10:34:23 + Peter Maydell wrote: > On Mon, 25 Feb 2019 at 10:24, Natanael Copa wrote: > > > > On Sat, 23 Feb 2019 16:18:15 + > > Peter Maydell wrote: > > > > > On Sat, 23 Feb 2019 at 16:05, Natanael Copa > > > wrote: > > > > I was thinking of something in the li

Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread Cornelia Huck
On Mon, 25 Feb 2019 12:55:47 +0100 David Hildenbrand wrote: > Let's simply initialization to 0. "Let's simply zero-initialize the structure." ? > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH v3 09/10] blockdev: remove unused paio parameter documentation

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > This field isn't present anymore. > > Signed-off-by: John Snow > --- > blockdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index 1aaadb6128..cbce44877d 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1255,7 +1255,

Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread Thomas Huth
On 25/02/2019 12.55, David Hildenbrand wrote: > Let's simply initialization to 0. > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 190

Re: [Qemu-devel] [PATCH v1 1/7] s390x/tcg: RXE has an optional M3 field

2019-02-25 Thread Thomas Huth
On 25/02/2019 12.55, David Hildenbrand wrote: > Will be needed, so add it to the format description. > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-format.def | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/insn-format.def b/target/s390x/ins

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Fernando Casas Schössow
I’m running the test guest on another host for the last three days and so far so good. Yet because of the nature of this bug/issue it can take a few hours or a few days more to fail. The failure is unpredictable. Does it make sense to continue running the guest on this different host to try to

Re: [Qemu-devel] [PATCH v3 08/10] block/dirty-bitmaps: move comment block

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > Simply move the big status enum comment block to above the status > function, and document it as being deprecated. The whole confusing > block can get deleted in three releases time. > > Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- B

[Qemu-devel] [PATCH v1 0/7] s390x/tcg: Cleanups and refactorings for Vector

2019-02-25 Thread David Hildenbrand
Before we start with the real magic, some more cleanups and refactorings. This series does not depend on other patches not yet in master. Also add a variant of "LOAD LENGTHENED" that is used along with vector instructions in linux (HFP instructions that can be used without HFP :) ). Implement "LOA

[Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread David Hildenbrand
Let's simply initialization to 0. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 19072efec6..c646e50eb3 100644 --- a/target/s390x/translate.c +++ b/

[Qemu-devel] [PATCH v1 3/7] s390x/tcg: Clarify terminology in vec_reg_offset()

2019-02-25 Thread David Hildenbrand
We will use s390x speak "Element Size" (es) for MO_8 == 0, MO_16 == 1 ... Simple rename of variables. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c i

[Qemu-devel] [PATCH v1 4/7] s390x/tcg: Factor out vec_full_reg_offset()

2019-02-25 Thread David Hildenbrand
We'll use that a lot along with gvec helpers, to calculate the start address of a vector. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 916508b56

[Qemu-devel] [PATCH v1 1/7] s390x/tcg: RXE has an optional M3 field

2019-02-25 Thread David Hildenbrand
Will be needed, so add it to the format description. Signed-off-by: David Hildenbrand --- target/s390x/insn-format.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/insn-format.def b/target/s390x/insn-format.def index a412d90fb7..4297ff4165 100644 --- a/target/

Re: [Qemu-devel] [PATCH v3 07/10] block/dirty-bitmaps: unify qmp_locked and user_locked calls

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > These mean the same thing now. Unify them and rename the merged call > bdrv_dirty_bitmap_busy to indicate semantically what we are describing, > as well as help disambiguate from the various _locked and _unlocked > versions of bitmap helpers that refer to mutex l

[Qemu-devel] [PATCH] block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct

2019-02-25 Thread Thomas Huth
The QEMU_PACKED is causing a compiler warning/error with GCC 9: CC block/nvme.o block/nvme.c: In function ‘nvme_create_queue_pair’: block/nvme.c:209:22: error: taking address of packed member of ‘struct ’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 209 |

[Qemu-devel] [PATCH v1 6/7] s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP

2019-02-25 Thread David Hildenbrand
Nice trick to load a 32 bit value into vector element 0 (32 bit element size) from memory, zeroing out element1. The short HFP to long HFP conversion really only is a shift. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate.c | 6 ++ 2 files cha

[Qemu-devel] [PATCH v1 5/7] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()

2019-02-25 Thread David Hildenbrand
Also properly wrap in 24bit mode. While at it, convert the comment (and drop the comment about fundamental TCG optimizations). Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 41 +--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --gi

[Qemu-devel] [PATCH v1 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

2019-02-25 Thread David Hildenbrand
Use a new CC helper to calculate the CC lazily if needed. While the PoP mentions that "A 32-bit unsigned binary integer" is placed into the first operand, there is no word telling that the other 32 bits (high part) are left untouched. Maybe the other 32-bit are unpredictable. So store 64 bit for no

Re: [Qemu-devel] [PATCH 0/3] block: fix graph modification

2019-02-25 Thread Kevin Wolf
Am 23.02.2019 um 20:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all. > > I've found two problems during my developing of backup-top filter. > The first one was already discussed in context of backup-top series, > so, here is patch 01 taken from it, previously it was > 03 of [PATCH v5 00/

Re: [Qemu-devel] [PATCH v1 0/3] s390x: SIGP + IRQ preparations for TCG vector register support

2019-02-25 Thread Cornelia Huck
On Fri, 22 Feb 2019 09:11:50 +0100 David Hildenbrand wrote: > These are minor preparations for vector instruction support for TCG, also > touching KVM code. > > During SIGP STORE ADDITIONAL STATUS we have to properly convert the > endianess. On machine checks, we have to also store the vector re

Re: [Qemu-devel] [RFC] multi phase reset

2019-02-25 Thread Peter Maydell
On Mon, 25 Feb 2019 at 10:49, Damien Hedde wrote: > > Hi, > > I had more thought about the reset problem and what we want to achieve > (add power gating and clock support). > Feel free to comment. I'll start to implement this and send a first > version with a reroll of everything when it's ready.

[Qemu-devel] [RFC] multi phase reset

2019-02-25 Thread Damien Hedde
Hi, I had more thought about the reset problem and what we want to achieve (add power gating and clock support). Feel free to comment. I'll start to implement this and send a first version with a reroll of everything when it's ready. # CONTEXT We want to model the clock distribution between devi

Re: [Qemu-devel] [PATCH 2/2] qcow2: mark image as corrupt if failing during create

2019-02-25 Thread Daniel P . Berrangé
On Fri, Feb 22, 2019 at 08:21:26PM +0100, Max Reitz wrote: > On 19.02.19 13:50, Daniel P. Berrangé wrote: > > During creation we write a minimal qcow2 header and then update it with > > extra features. If the updating fails for some reason we might still be > > left with a valid qcow2 image that wi

Re: [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes

2019-02-25 Thread Kevin Wolf
Am 20.02.2019 um 18:48 hat Kevin Wolf geschrieben: > Background for this series is the following bug report, which is about a > crash with virtio-blk + iothread and request resubmission for werror/rerror: > > https://bugzilla.redhat.com/show_bug.cgi?id=1671173 > > The reason is that bdrv_set_aio_

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Natanael Copa
On Sat, 23 Feb 2019 16:18:15 + Peter Maydell wrote: > On Sat, 23 Feb 2019 at 16:05, Natanael Copa wrote: > > I was thinking of something in the lines of: > > > > typedef volatile uint16_t __attribute__((__may_alias__)) volatile_uint16_t; > > static inline int lduw_he_p(const void *ptr) > > {

Re: [Qemu-devel] [PATCH 1/1] hw/i386: update copyright notice

2019-02-25 Thread Daniel P . Berrangé
On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote: > Signed-off-by: David Kiarie > --- > hw/i386/amd_iommu.c | 2 +- > hw/i386/amd_iommu.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [Qemu-devel] [PATCH 1/2] qcow2: fail if encryption opts are provided to non-encrypted image

2019-02-25 Thread Daniel P . Berrangé
On Fri, Feb 22, 2019 at 08:17:40PM +0100, Max Reitz wrote: > On 19.02.19 13:50, Daniel P. Berrangé wrote: > > If the qcow2 image does not have any encryption method specified in its > > header, the user should not be providing any encryption options when > > opening it. We already detect this if th

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Stefan Hajnoczi
On Mon, Feb 25, 2019 at 10:30 AM Stefan Hajnoczi wrote: > On Sat, Feb 23, 2019 at 3:55 PM Natanael Copa wrote: > > On Fri, 22 Feb 2019 14:04:20 + > > Stefan Hajnoczi wrote: > > > On Fri, Feb 22, 2019 at 12:57 PM Fernando Casas Schössow > > > wrote: > > I tried to find this section. How do y

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Stefan Hajnoczi
On Sat, Feb 23, 2019 at 3:55 PM Natanael Copa wrote: > On Fri, 22 Feb 2019 14:04:20 + > Stefan Hajnoczi wrote: > > On Fri, Feb 22, 2019 at 12:57 PM Fernando Casas Schössow > > wrote: > I tried to find this section. How do you get the assembly listing of > relevant secion? I tried to do "disa

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-25 Thread Peter Maydell
On Mon, 25 Feb 2019 at 10:24, Natanael Copa wrote: > > On Sat, 23 Feb 2019 16:18:15 + > Peter Maydell wrote: > > > On Sat, 23 Feb 2019 at 16:05, Natanael Copa wrote: > > > I was thinking of something in the lines of: > > > > > > typedef volatile uint16_t __attribute__((__may_alias__)) > > >

Re: [Qemu-devel] [PATCH v3 0/7] ui/cocoa: Use OSX's main loop

2019-02-25 Thread Peter Maydell
...oops, looks like I got Roman's email address wrong (I cut-n-pasted it from the one reviewed-by tag that happened to typo it :-( ). Sorry about that. -- PMM On Mon, 25 Feb 2019 at 10:24, Peter Maydell wrote: > > This set of patches rearranges how we handle events on > the OSX Cocoa UI so that

[Qemu-devel] [PATCH v3 6/7] ui/cocoa: Subclass NSApplication so we can implement sendEvent

2019-02-25 Thread Peter Maydell
When we switch away from our custom event handling, we still want to be able to have first go at any events our application receives, because in full-screen mode we want to send key events to the guest, even if they would be menu item activation events. There are several ways we could do that, but

[Qemu-devel] [PATCH v3 7/7] ui/cocoa: Perform UI operations only on the main thread

2019-02-25 Thread Peter Maydell
The OSX Mojave release is more picky about enforcing the Cocoa API restriction that only the main thread may perform UI calls. To accommodate this we need to restructure the Cocoa code: * the special OSX main() creates a second thread and uses that to call the vl.c qemu_main(); the original mai

[Qemu-devel] [PATCH v3 5/7] ui/cocoa: Don't call NSApp sendEvent directly from handleEvent

2019-02-25 Thread Peter Maydell
Currently the handleEvent method will directly call the NSApp sendEvent method for any events that we want to let OSX deal with. When we rearrange the event handling code, the way that we say "let OSX have this event" is going to change. Prepare for that by refactoring so that handleEvent returns a

[Qemu-devel] [PATCH v3 1/7] ui/cocoa: Ensure we have the iothread lock when calling into QEMU

2019-02-25 Thread Peter Maydell
The Cocoa UI should run on the main thread; this is enforced in OSX Mojave. In order to be able to run on the main thread, we need to make sure we hold the iothread lock whenever we call into various QEMU UI midlayer functions. Signed-off-by: Peter Maydell Reviewed-by: Roman Bolshakov Tested-by:

[Qemu-devel] [PATCH v3 3/7] ui/cocoa: Factor out initial menu creation

2019-02-25 Thread Peter Maydell
Factor out the long code sequence in main() which creates the initial set of menus. This will make later patches which move initialization code around a bit clearer. Signed-off-by: Peter Maydell Reviewed-by: BALATON Zoltan Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Message-id: 201

[Qemu-devel] [PATCH v3 2/7] ui/cocoa: Use the pixman image directly in switchSurface

2019-02-25 Thread Peter Maydell
Currently the switchSurface method takes a DisplaySurface. We want to change our DisplayChangeListener's dpy_gfx_switch callback to do this work asynchronously on a different thread. The caller of the switch callback will free the old DisplaySurface immediately the callback returns, so to ensure th

[Qemu-devel] [PATCH v3 4/7] ui/cocoa: Move console/device menu creation code up in file

2019-02-25 Thread Peter Maydell
Move the console/device menu creation code functions further up in the source file, next to the code which creates the initial menus. We're going to want to change the location we call these functions from in the next patch. This commit is a pure code move with no other changes. Signed-off-by: Pe

[Qemu-devel] [PATCH v3 0/7] ui/cocoa: Use OSX's main loop

2019-02-25 Thread Peter Maydell
This set of patches rearranges how we handle events on the OSX Cocoa UI so that we use the main thread to run the OSX event loop, and we don't do a long blocking operation from the applicationDidFinishLaunching callback. Instead we create a second thread which runs qemu_main() and becomes the QEMU

Re: [Qemu-devel] [PATCH] Fix breakpoint support in Nios II user-mode emulation.

2019-02-25 Thread Laurent Vivier
On 13/02/2019 17:50, Sandra Loosemore wrote: Nios II user-mode emulation was missing handling for EXCP_DEBUG, making the gdb stub essentially useless. This patch adds the missing piece. The new code was copied from the existing EXCP_TRAP handling and is also similar to what other targets (e.g.,

Re: [Qemu-devel] [PATCH v7 00/17] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support

2019-02-25 Thread Shameerali Kolothum Thodi
Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 25 February 2019 09:42 > To: Auger Eric > Cc: peter.mayd...@linaro.org; drjo...@redhat.com; da...@redhat.com; > qemu-devel@nongnu.org; Shameerali Kolothum Thodi > ; dgilb...@redhat.com; > qemu-...@non

Re: [Qemu-devel] [PATCH 4/5] decodetree: Do not unconditionaly return from Pattern.output_code

2019-02-25 Thread Bastian Koppelmann
On 2/24/19 12:29 AM, Richard Henderson wrote: As a consequence, the 'return false' gets pushed up one level. This will allow us to perform some other action when the translator returns failure. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 7 --- 1 file changed, 4 inserti

Re: [Qemu-devel] [PATCH 3/5] decodetree: Ensure build_tree does not include values outside insnmask

2019-02-25 Thread Bastian Koppelmann
On 2/24/19 12:29 AM, Richard Henderson wrote: From: Philippe Mathieu-Daudé Reproduced with "scripts/decodetree.py /dev/null". Reviewed-by: Eduardo Habkost Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- scripts/decodetree.py | 2 +- 1 file changed, 1 insertio

Re: [Qemu-devel] [PATCH 2/5] decodetree: Move documentation to docs/decodetree.rst

2019-02-25 Thread Bastian Koppelmann
On 2/24/19 12:29 AM, Richard Henderson wrote: + +Argument Sets += + +Syntax:: + + args_def:= '&' identifier ( args_elt )+ ( !extern )? + args_elt:= identifier + +Each *args_elt* defines an argument within the argument set. +Each argument set will be rendered as a C structu

Re: [Qemu-devel] [PATCH 0/2] target/arm: Implement ARMv8.5-FRINT

2019-02-25 Thread Laurent Desnogues
Hi Richard, On Sat, Feb 23, 2019 at 2:23 AM Richard Henderson wrote: > > Based-on: the ARMv8.2-FHM patch set, although I don't know that > this is an actual dependency; it's just the tree I started with. > > There is not yet support for this extension within FVP, so I've > self-tested it against

Re: [Qemu-devel] [RFC PATCH 0/4] ARM virt: ACPI memory hotplug support

2019-02-25 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 22 February 2019 19:11 > To: Auger Eric ; Shameerali Kolothum Thodi > ; shannon.zha...@gmail.com; > peter.mayd...@linaro.org; imamm...@redhat.com; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: xuwei (O) ; Li

[Qemu-devel] [Bug 1817525] Re: qemu fails to compile on gcc 9 "block/nvme.c:209:22: error: taking address of packed member of 'struct ' may result in an unaligned pointer value [-Werror=add

2019-02-25 Thread Peter Maydell
The fields of the struct are naturally aligned, so this should be easy enough to fix just by dropping QEMU_PACKED (we already have a compile- time assert that the doorbells field is at the expected address). NB: I notice also the struct is marked 'volatile' -- this is a bit of a red flag that the

Re: [Qemu-devel] [RFC PATCH 0/4] ARM virt: ACPI memory hotplug support

2019-02-25 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 22 February 2019 16:03 > To: Shameerali Kolothum Thodi ; > shannon.zha...@gmail.com; peter.mayd...@linaro.org; > imamm...@redhat.com; qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: xuwei (O) ; Linuxar

Re: [Qemu-devel] [PATCH v7 00/17] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support

2019-02-25 Thread Igor Mammedov
On Fri, 22 Feb 2019 18:35:26 +0100 Auger Eric wrote: > Hi Igor, > > On 2/22/19 5:27 PM, Igor Mammedov wrote: > > On Wed, 20 Feb 2019 23:39:46 +0100 > > Eric Auger wrote: > > > >> This series aims to bump the 255GB RAM limit in machvirt and to > >> support device memory in general, and especial

Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

2019-02-25 Thread Peter Krempa
On Mon, Feb 25, 2019 at 09:50:26 +0100, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > QMP clients can usually detect the presence of features via schema > > introspection. There are rare features that do not involve schema > > changes and are therefore impossible to detect with schema

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] virtio-balloon: Corrections to address verification

2019-02-25 Thread Greg Kurz
On Mon, 25 Feb 2019 10:37:11 +1100 David Gibson wrote: > On Fri, Feb 22, 2019 at 10:08:22AM +0100, Greg Kurz wrote: > > On Thu, 14 Feb 2019 15:39:13 +1100 > > David Gibson wrote: > > > > > The virtio-balloon device's verification of the address given to it by the > > > guest has a number of f

[Qemu-devel] [Bug 1817525] [NEW] qemu fails to compile on gcc 9 "block/nvme.c:209:22: error: taking address of packed member of 'struct ' may result in an unaligned pointer value [-Werror=a

2019-02-25 Thread Satheesh Rajendran
Public bug reported: Issue: Qemu compilation fails with below error on ppc64le host with gcc 9, repo(https://github.com/dgibson/qemu.git), branch(ppc-for-4.0), Commit (0483e90393bac8546a1fbc95ab912a1e78e92b00)  CHK version_gen.h   CC block/nvme.o block/nvme.c: In function ‘nvme_create_queu

Re: [Qemu-devel] [PATCH] Fix breakpoint support in Nios II user-mode emulation.

2019-02-25 Thread Peter Maydell
On Wed, 13 Feb 2019 at 17:19, Sandra Loosemore wrote: > > Nios II user-mode emulation was missing handling for EXCP_DEBUG, > making the gdb stub essentially useless. This patch adds the missing > piece. The new code was copied from the existing EXCP_TRAP handling > and is also similar to what ot

Re: [Qemu-devel] [PATCH v2 01/13] spapr/xive: add KVM support

2019-02-25 Thread David Gibson
On Fri, Feb 22, 2019 at 02:13:10PM +0100, Cédric Le Goater wrote: > This introduces a set of helpers when KVM is in use, which create the > KVM XIVE device, initialize the interrupt sources at a KVM level and > connect the interrupt presenters to the vCPU. > > They also handle the initialization o

Re: [Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-25 Thread Andrey Shinkevich
On 22/02/2019 18:20, Cleber Rosa wrote: > > > On 2/22/19 6:26 AM, Andrey Shinkevich wrote: >> The data type for bytes in Python3 differs from the one in Python2. >> Those cases should be managed separately. >> >> v1: >> In the first version, the TypeError in Python3 was handled as the >> except

Re: [Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-25 Thread Andrey Shinkevich
On 22/02/2019 17:53, Eric Blake wrote: > On 2/22/19 5:26 AM, Andrey Shinkevich wrote: >> The data type for bytes in Python3 differs from the one in Python2. >> Those cases should be managed separately. >> >> v1: >> In the first version, the TypeError in Python3 was handled as the >> exception. >>

Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

2019-02-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > QMP clients can usually detect the presence of features via schema > introspection. There are rare features that do not involve schema > changes and are therefore impossible to detect with schema > introspection. > > This patch adds the query-qemu-capabilities command.

Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig

2019-02-25 Thread Stefano Garzarella
On Thu, Feb 07, 2019 at 06:57:00PM +0100, Paolo Bonzini wrote: > This way, the default-configs file only need to specify the boards > and any optional devices. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-37-yang.zh...@intel.com> > Signed-off-by

Re: [Qemu-devel] [PATCH] target-i386: Enhance the stub for kvm_arch_get_supported_cpuid()

2019-02-25 Thread Kamil Rytarowski
On 25.02.2019 08:10, Paolo Bonzini wrote: > I have replied already. > Sorry, I don't have this mail in my mailbox for some reason. The issue is gone with the following patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg598417.html Tested-by: Kamil Rytarowski Please merge with qem

Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup

2019-02-25 Thread Igor Mammedov
On Sat, 23 Feb 2019 00:02:49 + Wei Yang wrote: > On Thu, Feb 21, 2019 at 03:50:04PM +0100, Igor Mammedov wrote: > >On Wed, 20 Feb 2019 08:51:21 +0800 > >Wei Yang wrote: > > > >> Three trivial cleanup for pc-dimm. > >> > >> Patch [1] remove the check on class->hotpluggable since pc-dimm is a

<    1   2   3   4