[Qemu-devel] [PULL 09/25] virtio-scsi: Fix build with gcc 9

From: Greg Kurz Build fails with gcc 9: CC ppc64-softmmu/hw/scsi/virtio-scsi.o hw/scsi/virtio-scsi.c: In function ‘virtio_scsi_do_tmf’: hw/scsi/virtio-scsi.c:265:39: error: taking address of packed member of ‘struct virtio_scsi_ctrl_tmf_req’ may result in an unaligned pointer val

[Qemu-devel] [PULL 21/25] lsi: use enum type for s->waiting

From: Sven Schnelle This makes the code easier to read - no functional change. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190305195519.24303-3-sv...@stackframe.org> --- hw/scsi/lsi53c895a.c | 42 +++--- 1 file changed, 2

[Qemu-devel] [PULL 06/25] configure: Enable werror for git worktrees

From: Alexey Kardashevskiy The configure script checks multiple times whether it works in a git repository and it does this by "test -e "${source_path}/.git" in 4 cases but in one case where it tries to enable werror "-d" is used there which fails on git worktrees as .git is a file then and not a

[Qemu-devel] [PULL 17/25] oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

From: Philippe Mathieu-Daudé Previous to OpenBSD 6.3 [1], fcntl(F_SETFL) is not permitted on memory devices. Trying this call sets errno to ENODEV ("not a memory device"): 19 ENODEV Operation not supported by device. An attempt was made to apply an inappropriate function to a device, f

[Qemu-devel] [PULL 14/25] build: remove unnecessary assignments from Makefile.target

It is only necessary to clear block-obj-y because Makefile.objs uses "+=" instead of "="; fix that and remove the assignment. The other variables need not be cleared at all. Signed-off-by: Paolo Bonzini --- Makefile.objs | 2 +- Makefile.target | 3 --- 2 files changed, 1 insertion(+), 4 delet

[Qemu-devel] [PULL 10/25] lsi: implement basic SBCL functionality

From: Sven Schnelle HP-UX checks this register after sending data to the target. If there's no valid information present, it assumes the client disconnected because the kernel sent to much data. Implement at least some of the SBCL functionality that is possible without having a real SCSI bus. Si

[Qemu-devel] [PULL 07/25] target-i386: add kvm stubs to user-mode emulators

The CPUID code will call kvm_arch_get_supported_cpuid() and, even though it is undef kvm_enabled() so it never runs for user-mode emulators, sometimes clang will not optimize it out at -O0. That could be considered a compiler bug, however at -O0 we give it a pass and just add the stubs. Reported-

[Qemu-devel] [PULL 15/25] build: clean trace/generated-helpers.c

Signed-off-by: Paolo Bonzini --- Makefile.target | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.target b/Makefile.target index 441ace6..d8048aa 100644 --- a/Makefile.target +++ b/Makefile.target @@ -222,6 +222,7 @@ clean: clean-target rm -f *.a *~ $(PROGS) rm -f $(sh

[Qemu-devel] [PULL 08/25] i386: extended the cpuid_level when Intel PT is enabled

From: Luwei Kang Intel Processor Trace required CPUID[0x14] but the cpuid_level have no change when create a kvm guest with e.g. "-cpu qemu64,+intel-pt". Signed-off-by: Eduardo Habkost Signed-off-by: Luwei Kang Message-Id: <1548805979-12321-1-git-send-email-luwei.k...@intel.com> Signed-off-by:

[Qemu-devel] [PULL 05/25] contrib/elf2dmp: add kernel start address checking

From: Viktor Prutyanov Before this patch, if elf2dmp failed to find NT kernel PE magic in allowed virtual address range, then it assumes NULL as NT kernel address and cause segfault. This patch fix the problem described above by checking NT kernel address before futher processing. Signed-off-by

[Qemu-devel] [PULL 04/25] block/iscsi: Restrict Linux-specific code

From: Philippe Mathieu-Daudé Some Linux specific code is missing guards, leading to build failure on OSX: $ sudo brew install libiscsi $ ./configure && make [...] CC block/iscsi.o qemu/block/iscsi.c:338:24: error: 'iscsi_aiocb_info' defined but not used [-Werror=unused-const-va

[Qemu-devel] [PULL 13/25] build: get rid of target-obj-y

It is possible to specify the trace/ directory already in objs-y; there is no need to have a separate unnest-vars invocation. Signed-off-by: Paolo Bonzini --- Makefile.objs | 1 - Makefile.target | 7 ++- trace/Makefile.objs | 4 ++-- 3 files changed, 4 insertions(+), 8 deletions(-

[Qemu-devel] [PULL 01/25] memory: Do not update coalesced IO range in the case of NOP

From: Jagannathan Raman Do not add/del coalesced IO ranges in the case where the same FlatRanges are present in both old and new FlatViews Fixes: 3ac7d43a6fbb ("memory: update coalesced_range on transaction_commit") Signed-off-by: Jagannathan Raman Message-Id: <59572a7353830be4b7aa57d79ccb7ad6

[Qemu-devel] [PULL 02/25] vfio-pci: enable by default

CONFIG_VFIO_PCI was not "default y" - and once you do that, it is also important to disable it if PCI is not there. Reported-by: Alex Williamson Tested-by: Alex Williamson Signed-off-by: Paolo Bonzini --- hw/vfio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PULL 03/25] hw/i386/pc: run the multiboot loader before the PVH loader

From: Stefano Garzarella Some multiboot images could be in the ELF format. In the current implementation QEMU fails because we try to load these images as a PVH image. In order to fix this issue, we should try multiboot first (we already check the multiboot magic header before to load it). If it

[Qemu-devel] [PULL 00/25] Misc patches for QEMU 4.0 soft freeze

The following changes since commit 62cfabb52210139843e26c95434356f73a0631b9: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20190307' into staging (2019-03-08 15:17:01 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to f

[Qemu-devel] 'make check' error

Hi all, Today I ‘git clone’ && configure && make && make check And get following error, fp-test.c:50:10: fatal error: fail.h: No such file or directory #include "fail.h" ^~~~ I look at the commit: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=3ac1f81329f4dfdc10a51e180f9cf28d

[Qemu-devel] [Bug 1535497] Re: Guest can not boot up when assigned more than 20 vcpus with option "-no-acpi"

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1535497 Title: Guest can n

[Qemu-devel] [Bug 1530386] Re: command.com on win95 throws video mode out

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1530386 Title: command.com

[Qemu-devel] [Bug 1534382] Re: loadvm makes Windows 7 x86 guest crash with some CPUs

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1534382 Title: loadvm make

Re: [Qemu-devel] [PATCH v4 1/2] hw/arm/acpi: simplify AML bit and/or statement

On 2019/3/7 0:34, Igor Mammedov wrote: On Wed, 6 Mar 2019 21:36:56 +0800 Heyi Guo wrote: The last argument of AML bit and/or statement is the target variable, so we don't need to use a NULL target and then an additional store operation; a single bit and/or statement is enough. s: a single

[Qemu-devel] [PATCH v5 2/2] hw/arm/acpi: enable SHPC native hot plug

After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have SHPC controller on ARM, so just enable SHPC native hot plug. Cc: Shannon Zhao Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Signed

[Qemu-devel] [PATCH v5 1/2] hw/arm/acpi: simplify AML bit and/or statement

The last argument of AML bit and/or statement is the target variable, so we don't need to use a NULL target and then an additional store operation; using just aml_and() or aml_or() statement is enough. Cc: Shannon Zhao Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Suggested-by:

[Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have SHPC controller on ARM, and we don't support ACPI hot plug, so just enable SHPC native hot plug. Igor also spotted the store operation outside of bit and/or is not necessary, so simply the code at first. v5: -

Re: [Qemu-devel] [PATCH 06/10] roms/Makefile: replace the $(EFIROM) target with "edk2-basetools"

On 3/9/19 2:32 AM, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 3/9/19 1:48 AM, Laszlo Ersek wrote: >> We don't (can't) have a recipe for building just $(EFIROM); therefore, >> while we call the target $(EFIROM), we actually build all of the edk2 >> BaseTools. Rename the target to edk2-baseto

Re: [Qemu-devel] [Qemu-block] [PATCH] tcmu: Introduce qemu-tcmu utility

> > I'm not sure what check you mean. Case 2 would need to find an existing > export with the given name, of course, and would return an error if no > such export exists yet. > > But for care 1, isn't the image explicitly opened when the target is > configured? And if it can't be opened, -1 is re

[Qemu-devel] [Bug 1817239] Re: add '--targets' option to qemu-binfmt-conf.sh

I submitted a first version some days ago, which homogeneized the implementation, as suggested by Laurent Vivier. It received some feedback from Eric Blake. A patchset (v3) is ready for review: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/# The feature requested in this issue is inclu

Re: [Qemu-devel] [PATCH 06/10] roms/Makefile: replace the $(EFIROM) target with "edk2-basetools"

Hi Laszlo, On 3/9/19 1:48 AM, Laszlo Ersek wrote: > We don't (can't) have a recipe for building just $(EFIROM); therefore, > while we call the target $(EFIROM), we actually build all of the edk2 > BaseTools. Rename the target to edk2-basetools, and update the iPXE > prerequisite accordingly. This

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Repo: https://github.com/lersek/qemu.git > Branch: edk2_build > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > release, and builds and captures platform firmware binaries from that > release. At this point they are meant to be

Re: [Qemu-devel] [PATCH] Added periodic IRQ support for bcm2836_control local timer

Hi, Thanks for your answers. If I don't clear the INTENABLE flag, then the IRQ would keep firing constantly. This is not how the real hardware works: it triggers the IRQ once, and then it inhibits. The timer won't trigger the IRQ again until you acknowledge it by writing the INTFLAG into the ack r

Re: [Qemu-devel] [PATCH 3/9] tcg: Use extract2 in tcg_gen_shifti_i64

Hi Richard, On 3/7/19 3:41 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 47 --- > 1 file changed, 24 insertions(+), 23 deletions(-) > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index deacc63e3b..34e0dbc6e0 1

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190307144126.31847-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

Patchew URL: https://patchew.org/QEMU/20190307172401.29451-1-arm...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[Qemu-devel] [PATCH 07/10] roms: build edk2 firmware binaries and variable store templates

Add the "efi" target to "Makefile". Introduce "Makefile.edk2" for building and cleaning the firmware images and varstore templates. Collect the common bits from the recipes in the helper script "edk2-build.sh". Signed-off-by: Laszlo Ersek --- roms/Makefile | 5 + roms/Makefile.edk2 | 13

[Qemu-devel] [PATCH 08/10] pc-bios: add edk2 firmware binaries and variable store templates

Add the files built by the last patch: binaries, and the cumulative license text that covers them. Signed-off-by: Laszlo Ersek --- pc-bios/edk2-licenses.txt | 209 pc-bios/edk2-aarch64-code.fd | Bin 0 -> 67108864 bytes pc-bios/edk2-arm-code.fd | Bin

[Qemu-devel] [PATCH 05/10] roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function

The edk2 "build" utility natively supports building modules (that is, INF files) in parallel. The feature is not useful when building a single module (with the "-m" option), but it is useful for platform firmware builds (which include many modules). Add a function that determines the "-n" option ar

[Qemu-devel] [PATCH 10/10] Makefile: install the edk2 firmware images and their descriptors

Signed-off-by: Laszlo Ersek --- Makefile | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d2463c92371f..a29dc5f87a3d 100644 --- a/Makefile +++ b/Makefile @@ -714,9 +714,16 @@ spapr-rtas.bin slof.bin skiboot.lid \ palcode-clipper \ u

[Qemu-devel] [PATCH 04/10] roms/edk2: advance to tag edk2-stable201903

Update the roms/edk2 submodule hash from edk2-stable201811 to edk2-stable201903. The release notes are available at . $ git shortlog edk2-stable201811..edk2-stable201903 Achin Gupta (9): ArmPkg: Add PCDs needed for MM communi

[Qemu-devel] [PATCH 06/10] roms/Makefile: replace the $(EFIROM) target with "edk2-basetools"

We don't (can't) have a recipe for building just $(EFIROM); therefore, while we call the target $(EFIROM), we actually build all of the edk2 BaseTools. Rename the target to edk2-basetools, and update the iPXE prerequisite accordingly. This will let other targets depend on "edk2-basetools", where an

[Qemu-devel] [PATCH 09/10] pc-bios: document the edk2 firmware images; add firmware descriptors

Update the README file with information on the images added previously, and provide firmware descriptor documents that conform to "docs/interop/firmware.json". Signed-off-by: Laszlo Ersek --- pc-bios/descriptors/50-edk2-i386-secure.json | 34 +++ pc-bios/descriptors/50-edk2-x86

[Qemu-devel] [PATCH 02/10] roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64

Adapt the qemu_edk2_get_toolchain() function in "roms/edk2-funcs.sh" in advance to edk2 commit 8d7cdfae8cb8 ("OvmfPkg: require GCC48 or later", 2019-01-08), which is part of the "edk2-stable201903" tag. Signed-off-by: Laszlo Ersek --- roms/edk2-funcs.sh | 14 +- 1 file changed, 1 ins

[Qemu-devel] [PATCH 03/10] tests/uefi-test-tools/build.sh: work around TianoCore#1607

The edk2-stabe201903 release introduced Python3 support to edk2's BaseTools; however the Python3 enablement breaks in a corner case (which is nevertheless supported by the edk2 community), namely the in-module parallelization that we utilize. This is tracked under

[Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

Repo: https://github.com/lersek/qemu.git Branch: edk2_build This series advances the roms/edk2 submodule to the "edk2-stable201903" release, and builds and captures platform firmware binaries from that release. At this point they are meant to be used by both end-users and by Igor's ACPI unit tes

[Qemu-devel] [PATCH 01/10] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh"

Extract the dense logic for architecture and toolchain massaging from "tests/uefi-test-tools/build.sh", to a set of small functions. We'll reuse these functions for building full platform firmware images. Signed-off-by: Laszlo Ersek --- roms/edk2-funcs.sh | 240

Re: [Qemu-devel] [Qemu-arm] [PATCH 9/9] target/arm: Simplify BFXIL expansion

On 3/7/19 3:41 PM, Richard Henderson wrote: > The mask implied by the extract is redundant with the one > implied by the deposit. Also, fix spelling of BFXIL. This spelling fix also help understanding the context! > > Cc: qemu-...@nongnu.org > Cc: Peter Maydell > Signed-off-by: Richard Hende

Re: [Qemu-devel] [PATCH 4/9] tcg: Use extract2 in tcg_gen_deposit_{i32, i64}

On 3/7/19 3:41 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 28 ++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index 34e0dbc6e0..caee80235e 100644 > --- a/tcg/tcg-op.c > +++

Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps

On 3/6/19 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.03.2019 18:41, John Snow wrote: >> >> >> On 3/6/19 10:33 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 06.03.2019 2:43, John Snow wrote: Since we now load all bitmaps into memory anyway, we can just truncate them in-memory and

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190307144126.31847-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH 6/9] tcg/arm: Support INDEX_op_extract2_i32

On 3/7/19 3:41 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.h | 2 +- > tcg/arm/tcg-target.inc.c | 25 + > 2 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h > in

Re: [Qemu-devel] [PATCH v5 1/2] Add generic Nios II board.

On 3/7/19 7:57 AM, Peter Maydell wrote: diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c index 5f0ab2f..c697047 100644 --- a/hw/nios2/boot.c +++ b/hw/nios2/boot.c @@ -140,6 +140,7 @@ void nios2_load_kernel(Nios2CPU *cpu, hwaddr ddr_base, uint64_t entry, low, high; uint32_t base3

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190307144126.31847-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH 7/9] tcg/aarch64: Support INDEX_op_extract2_{i32, i64}

On 3/7/19 3:41 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 4 ++-- > tcg/aarch64/tcg-target.inc.c | 11 +++ > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h

Re: [Qemu-devel] [PATCH 2/9] tcg: Add INDEX_op_extract2_{i32,i64}

Hi Richard, On 3/7/19 3:41 PM, Richard Henderson wrote: > This will let backends implement the double-word shift operation. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 2 ++ > tcg/arm/tcg-target.h | 1 + > tcg/i386/tcg-target.h| 2 ++ > tcg/mips/tcg-target

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190307144126.31847-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH 1/9] tcg: Implement tcg_gen_extract2_{i32, i64}

On 3/7/19 3:41 PM, Richard Henderson wrote: > From: David Hildenbrand > > Will be helpful for s390x. Input 128 bit and output 64 bit only, > which is sufficient for now. > > Reviewed-by: Richard Henderson > Signed-off-by: David Hildenbrand > Message-Id: <20190225154204.26751-1-da...@redhat.com

Re: [Qemu-devel] [PATCH] qmp-shell: fix nested json regression

On 2/5/19 8:49 AM, Marc-André Lureau wrote: > Commit fcfab7541 ("qmp-shell: learn to send commands with quoted > arguments") introduces the usage of Python 'shlex' to handle quoted > arguments, but it accidentally broke generation of nested JSON > structs. > > shlex drops quotes, which breaks p

Re: [Qemu-devel] [PATCH v6 00/14] Audio patches

Patchew URL: https://patchew.org/QEMU/cover.1552083282.git.dirty.ice...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1552083282.git.dirty.ice...@gmail.com Subject: [Qemu-devel] [PATCH v6 00/14] Audio

[Qemu-devel] [PATCH v6 14/14] audio: -audiodev command line option: cleanup

Remove no longer needed code. Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 17 - audio/audio.c | 186 +- 2 files changed, 4 insertions(+), 199 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index 7bf5dfc0b5..3f148427

[Qemu-devel] [PATCH v6 12/14] spiceaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/spiceaudio.c | 5 - 1 file changed, 5 deletions(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index affc3df17f..4f7873af5a 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@ -373,10 +373,6 @@ static int line_in_ctl (HWVoiceIn *hw, in

[Qemu-devel] [PATCH v6 11/14] sdlaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 12 audio/sdlaudio.c | 22 -- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 8d7f1475b5..478cf76d5f 100644 --- a/audio/audio_legacy.c +

[Qemu-devel] [PATCH v6 13/14] wavaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 16 audio/wavaudio.c | 58 +++- 2 files changed, 25 insertions(+), 49 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 478cf76d5f..6d140119d9 100644 --- a/

[Qemu-devel] [PATCH v6 10/14] paaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 38 + audio/paaudio.c | 81 2 files changed, 67 insertions(+), 52 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 94f95bbc73..8d7f1475b5 1006

[Qemu-devel] [PATCH v6 04/14] audio: -audiodev command line option basic implementation

Audio drivers now get an Audiodev * as config paramters, instead of the global audio_option structs. There is some code in audio/audio_legacy.c that converts the old environment variables to audiodev options (this way backends do not have to worry about legacy options). It also contains a replace

[Qemu-devel] [PATCH v6 05/14] alsaaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c| 329 +-- audio/audio_legacy.c | 84 ++- 2 files changed, 181 insertions(+), 232 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 8302f3e882..49e6884309 100644 --- a/audi

[Qemu-devel] [PATCH v6 08/14] noaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/noaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 79690af1ea..ccc611fc84 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -163,7 +163,6 @@ static struct audio_pcm_ops no_pcm_ops = { static struct audi

[Qemu-devel] [PATCH v6 09/14] ossaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 32 + audio/ossaudio.c | 161 ++- 2 files changed, 83 insertions(+), 110 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index bf326bd360..94f95bbc73 100644 --- a/a

[Qemu-devel] [PATCH v6 02/14] audio: use qapi AudioFormat instead of audfmt_e

I had to include an enum for audio sampling formats into qapi, but that meant duplicating the audfmt_e enum. This patch replaces audfmt_e and associated values with the qapi generated AudioFormat enum. This patch is mostly a search-and-replace, except for switches where the qapi generated AUDIO_F

[Qemu-devel] [PATCH v6 06/14] coreaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 28 + audio/coreaudio.c| 49 ++-- 2 files changed, 39 insertions(+), 38 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index f58c8b6aee..5f557a2de9

[Qemu-devel] [PATCH v6 07/14] dsoundaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán --- audio/dsound_template.h | 6 ++--- audio/audio_legacy.c| 43 ++ audio/dsoundaudio.c | 59 - 3 files changed, 63 insertions(+), 45 deletions(-) diff --git a/audio/dsound_template.h b/aud

[Qemu-devel] [PATCH v6 03/14] audio: -audiodev command line option: documentation

This patch adds documentation of an -audiodev command line option, that deprecates the old QEMU_* environment variables for audio backend configuration. It's syntax is similar to existing options (-netdev, -device, etc): -audiodev driver_name,property=value,... Although now it's possible to sp

[Qemu-devel] [PATCH v6 00/14] Audio patches

Hi, Here's an updated version of my audio patches. Changes from v5: * small qapi fixes * fixed a bug in audio_create_pdos [1] Regards, Zoltan [1]: https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg06842.html Kővágó, Zoltán (14): qapi: qapi for audio backends audio: use qapi Audi

[Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

This patch adds structures into qapi to replace the existing configuration structures used by audio backends currently. This qapi will be the base of the -audiodev command line parameter (that replaces the old environment variables based config). This is not a 1:1 translation of the old options, I

Re: [Qemu-devel] [PATCH v4 2/6] vfio-ccw: rework ssch state handling

On 03/01/2019 04:38 AM, Cornelia Huck wrote: The flow for processing ssch requests can be improved by splitting the BUSY state: - CP_PROCESSING: We reject any user space requests while we are in the process of translating a channel program and submitting it to the hardware. Use -EAGAIN

[Qemu-devel] [PATCH] usb-mtp: fix return status of delete

Spotted by Coverity: CID 1399414 mtp delete allows the a return status of delete succeeded, partial_delete or readonly - when none of the objects could be deleted. Some initiators recurse over the objects themselves. In that case, only READ_ONLY can be returned. Signed-off-by: Bandan Das ---

Re: [Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing

On 3/6/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.03.2019 18:59, John Snow wrote: >> >> >> On 3/6/19 7:58 AM, Eric Blake wrote: >>> On 3/5/19 5:43 PM, John Snow wrote: Usually, we only write out bitmaps when we're about to close out the file, so we always remove the bitmaps

Re: [Qemu-devel] [PATCH 1/5] block/qcow2-bitmap: Skip length check in some cases

On 3/6/19 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.03.2019 2:43, John Snow wrote: >> If we were to allow resizes, the length check that happens when we load >> bitmap headers from disk when we read or store bitmaps would begin to >> fail: >> >> Imagine the circumstance where we've resi

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

On Fri, 8 Mar 2019 16:21:46 + "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Thu, 7 Mar 2019 23:20:36 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > > Sent: Friday, March 8, 2019 1:

Re: [Qemu-devel] [PATCH] bitmaps: Fix typo in function name

On 3/8/19 3:58 PM, Eric Blake wrote: > Commit a88b179f introduced the ability to set and query bitmap > persistence, but with an atypical spelling. > > Signed-off-by: Eric Blake > --- > > Based-on: <20190308202858.26636-1-js...@redhat.com> > [PULL 00/17 Bitmaps patches] > (Don't know if John

Re: [Qemu-devel] [PULL 00/17] Bitmaps patches

On 3/8/19 2:28 PM, John Snow wrote: > The following changes since commit 234afe78281b10a798fb97c584e1b677844aaab8: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-03-08' into staging (2019-03-08 > 16:31:34 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v3 3/3] vfio/display: delay link up event

On Fri, 22 Feb 2019 11:19:11 + Liam Merwick wrote: > On 22/02/2019 05:49, Gerd Hoffmann wrote: > > Kick the display link up event with a 0.1 sec delay, > > so the guest has a chance to notice the link down first. > > > > Signed-off-by: Gerd Hoffmann > > Depending on your thoughts on the

[Qemu-devel] [RFC PATCH] docs/booting.rst: start documenting the boot process

While working on some test cases I realised there was quite a lot of assumed knowledge about how things boot up. I thought it would be worth gathering this together in a user facing document where we could pour in the details and background to the boot process. As it's quite wordy I thought it shou

Re: [Qemu-devel] [PATCH v3 1/3] vfio/display: add edid support.

On Fri, 22 Feb 2019 11:09:06 + Liam Merwick wrote: > On 22/02/2019 05:49, Gerd Hoffmann wrote: > > This patch adds EDID support to the vfio display (aka vgpu) code. > > When supported by the mdev driver qemu will generate a EDID blob > > and pass it on using the new vfio edid region. The EDI

Re: [Qemu-devel] [PULL 00/17] Bitmaps patches

Guess I'll fix these first, sorry for the noise. On 3/8/19 3:53 PM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-js...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > T

Re: [Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

On Fri, Mar 8, 2019 at 7:16 PM Auger Eric wrote: > Hi Philippe, > On 3/8/19 7:02 PM, Philippe Mathieu-Daudé wrote: > > hi Eric, > > > > On 3/8/19 4:25 PM, Eric Auger wrote: > >> As NVDIMM support is looming for ARM and SPAPR, let's > >> move the acpi_nvdimm_state to the generic machine struct > >>

[Qemu-devel] [PATCH] bitmaps: Fix typo in function name

Commit a88b179f introduced the ability to set and query bitmap persistence, but with an atypical spelling. Signed-off-by: Eric Blake --- Based-on: <20190308202858.26636-1-js...@redhat.com> [PULL 00/17 Bitmaps patches] (Don't know if John wants to do a v2 pull request to silence some checkpatch w

Re: [Qemu-devel] [PULL 00/17] Bitmaps patches

Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190308202858.26636-1-js...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches =

Re: [Qemu-devel] [PULL 00/54] Kconfig conversion, excluding ARM and MIPS

On 3/6/19 4:12 AM, Thomas Huth wrote: > On 05/03/2019 21.08, Eric Blake wrote: > [...] >> 'make distclean' is a heavy hammer, is there anything smaller in scope >> that will fix the problem without nuking everything, such as a strategic >> touch or rm of one particular file? > > Try this in the to

Re: [Qemu-devel] [PULL 00/17] Bitmaps patches

Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190308202858.26636-1-js...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches =

Re: [Qemu-devel] [PULL 00/17] Bitmaps patches

Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190308202858.26636-1-js...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches =

[Qemu-devel] [PULL 13/17] block/dirty-bitmaps: add block_dirty_bitmap_check function

Instead of checking against busy, inconsistent, or read only directly, use a check function with permissions bits that let us streamline the checks without reproducing them in many places. Included in this patch are permissions changes that simply add the inconsistent check to existing permissions

[Qemu-devel] [PULL 12/17] block/dirty-bitmap: add inconsistent status

Even though the status field is deprecated, we still have to support it for a few more releases. Since this is a very new kind of bitmap state, it makes sense for it to have its own status field. Reviewed-by: Eric Blake Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Message-

[Qemu-devel] [PULL 17/17] block/dirty-bitmaps: implement inconsistent bit

Set the inconsistent bit on load instead of rejecting such bitmaps. There is no way to un-set it; the only option is to delete the bitmap. Obvervations: - bitmap loading does not need to update the header for in_use bitmaps. - inconsistent bitmaps don't need to have their data loaded; they're gl

Re: [Qemu-devel] [PATCH v4 2/2] machine: Move nvdimms state into struct MachineState

On Fri, Mar 08, 2019 at 07:20:53PM +0100, Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state and becomes a pointer. >

[Qemu-devel] [PULL 15/17] block/dirty-bitmaps: prohibit removing readonly bitmaps

Remove is an inherently RW operation, so this will fail anyway, but we can fail it very quickly instead of trying and failing, so do so. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 20190301191545.8728-6-js...@redhat.com Signed-off-by: J

[Qemu-devel] [PULL 11/17] block/dirty-bitmaps: add inconsistent bit

Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 that have been marked as "in use". Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 201

[Qemu-devel] [PULL 09/17] blockdev: remove unused paio parameter documentation

This field isn't present anymore. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 20190223000614.13894-10-js...@redhat.com Signed-off-by: John Snow --- blockdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/blockdev.c b/blockdev.c

[Qemu-devel] [PULL 10/17] iotests: add busy/recording bit test to 124

This adds a simple test that ensures the busy bit works for push backups, as well as doubling as bonus test for incremental backups that get interrupted by EIO errors. Recording bit tests are already handled sufficiently by 236. Signed-off-by: John Snow Reviewed-by: Eric Blake Tested-by: Eric B

[Qemu-devel] [PULL 07/17] block/dirty-bitmaps: unify qmp_locked and user_locked calls

These mean the same thing now. Unify them and rename the merged call bdrv_dirty_bitmap_busy to indicate semantically what we are describing, as well as help disambiguate from the various _locked and _unlocked versions of bitmap helpers that refer to mutex locks. Signed-off-by: John Snow Reviewed-

[Qemu-devel] [PULL 06/17] block/dirty-bitmap: explicitly lock bitmaps with successors

Instead of implying a user_locked/busy status, make it explicit. Now, bitmaps in use by migration, NBD or backup operations are all treated the same way with the same code paths. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id: 2019022300061

[Qemu-devel] [PULL 14/17] block/dirty-bitmaps: prohibit readonly bitmaps for backups

drive and blockdev backup cannot use readonly bitmaps, because the sync=incremental mechanism actually edits the bitmaps on success. If you really want to do this operation, use a copied bitmap. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-

  1   2   3   4   5   >