Re: [Qemu-devel] [PATCH 3/9] tcg: Use extract2 in tcg_gen_shifti_i64

On 3/9/19 12:30 PM, Aleksandar Markovic wrote: > > > On Thursday, March 7, 2019, Richard Henderson > wrote: > > Signed-off-by: Richard Henderson > > --- >  tcg/tcg-op.c | 47

Re: [Qemu-devel] [PATCH 0/2] target/ppc: Optimize VSX instructions using deposit_i64()

On Sat, Mar 09, 2019 at 10:42:53PM +0100, Philippe Mathieu-Daudé wrote: > Hi David, Richard. > > I found these two patches while cleaning dangling branches on my > previous laptop... Original commits date is 2017-07-21 05:24:05... > I simply rebased them. > > It doesn't have to be merged for

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

On Sat, Mar 09, 2019 at 01:48:16AM +0100, Laszlo Ersek wrote: > Repo: https://github.com/lersek/qemu.git > Branch: edk2_build > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > release, and builds and captures platform firmware binaries from that > release. At this

Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

Oh~ Okay! On Sun, Mar 10, 2019, 02:30 Peter Maydell wrote: > Deepika: the tricky part is the makefiles, not the configure script... > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1817345 > > Title: > configure

[Qemu-devel] [PATCH] Replace calls to object_child_foreach() with object_child_foreach_recursive()

Replace calls to object_child_foreach() with object_child_foreach_recursive() when applicable: nvdimm_device_list, nmi_monitor_handle, find_sysbus_device, pc_dimm_slot2bitmap, build_dimm_list. Signed-off-by: Ernest Esene --- hw/acpi/nvdimm.c | 5 +++-- hw/core/sysbus.c | 2

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

Hi Lukas, On Mon, Feb 11, 2019 at 6:13 AM Lukas Auer wrote: > > Re-add the previous compatible string "riscv-virtio-soc" to the soc > device tree node to allow U-Boot and Linux to bind machine-specific > drivers to it. The current compatible string "simple-bus" is retained. > > This is required

[Qemu-devel] [PATCH v3 3/4] hw/i386: Use edk2_add_host_crypto_policy()

Enable the EDK2 Crypto Policy features on the PC machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 42128183e9..00dc377df0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -38,6 +38,7 @@

[Qemu-devel] [PATCH v3 4/4] hw/arm/virt: Use edk2_add_host_crypto_policy()

Enable the EDK2 Crypto Policy features on the Virt machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7f66ddad89..940f41056a 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -55,6 +55,7

[Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

Add a function to read the full content of file on the host, and add a new 'file' name item to the fw_cfg device. Signed-off-by: Philippe Mathieu-Daudé --- v2: s/ptr/data, corrected documentation (Laszlo) v3: inverted the if() logic --- hw/nvram/fw_cfg.c | 21 +

[Qemu-devel] [PATCH v3 0/4] fw_cfg: Add edk2_add_host_crypto_policy()

Hi, This series consists of: - add fw_cfg_add_file_from_host() - add edk2_add_host_crypto_policy() and the Edk2Crypto object The Edk2Crypto object is used to hold configuration values specific to EDK2. The edk2_add_host_crypto_policy() function loads crypto policies from the host, and register

[Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

The Edk2Crypto object is used to hold configuration values specific to EDK2. The edk2_add_host_crypto_policy() function loads crypto policies from the host, and register them as fw_cfg named file items. So far only the 'https' policy is supported. A usercase example is the 'HTTPS Boof' feature

[Qemu-devel] [PATCH 6/6] target/m68k: Reduce the scope of the 'zero' tcg_temp

Reduce the scope of the 'zero' tcg_temp. Since this tcg_temp is allocated with tcg_const_i32(), free it using tcg_temp_free_i32(). Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c

[Qemu-devel] [PATCH 3/6] target/m68k: Fix a tcg_temp leak

The function gen_get_ccr() returns a tcg_temp created with tcg_temp_new(). Free it with tcg_temp_free(). Signed-off-by: Philippe Mathieu-Daudé --- Laurent/Richard, feel free to squash this with the next patch, but IMHO having it split as a previous step makes the next patch easier to review. ---

[Qemu-devel] [PATCH 5/6] target/m68k: Optimize rotate_x() using extract_i32()

Optimize rotate_x() using tcg_gen_extract_i32(). We can now free the 'sz' tcg_temp earlier. Since it is allocated with tcg_const_i32(), free it with tcg_temp_free_i32(). Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 1/6] target/m68k: Reduce the l1 TCGLabel scope

Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 6217a683f1..ab801b6ceb 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -3019,7

[Qemu-devel] [PATCH 0/6] target/m68k: Optimize few instructions using deposit/extraxt_i32()

Hi Laurent, Richard. I found these patches while cleaning dangling branches on my previous laptop... Original commits date is 2017-07-21 09:31:32... I simply had to rebase them. It doesn't have to be merged for soft freeze, but since I'm doing housekeeping I rather send it to keep archived by

[Qemu-devel] [PATCH 4/6] target/m68k: Optimize get_sr() using deposit_i32()

Doing so we free one tcg_temp. Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/translate.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ea95d55a11..f43ac07b7f 100644 --- a/target/m68k/translate.c

[Qemu-devel] [PATCH 2/6] target/m68k: Optimize the partset instruction using deposit_i32()

Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ab801b6ceb..55766fd7ef 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -720,17

[Qemu-devel] [PATCH 2/2] target/ppc: Optimize x[sv]xsigdp using deposit_i64()

Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/translate/vsx-impl.inc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index 48c58deb14..3203165f49 100644 ---

[Qemu-devel] [PATCH 0/2] target/ppc: Optimize VSX instructions using deposit_i64()

Hi David, Richard. I found these two patches while cleaning dangling branches on my previous laptop... Original commits date is 2017-07-21 05:24:05... I simply rebased them. It doesn't have to be merged for soft freeze, but since I'm doing housekeeping I rather send it to keep archived by the

[Qemu-devel] [PATCH 1/2] target/ppc: Optimize xviexpdp() using deposit_i64()

The t0 tcg_temp register is now unused, remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/translate/vsx-impl.inc.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index

Re: [Qemu-devel] [PATCH v4 00/29] Kconfig dependencies for ARM machines

Patchew URL: https://patchew.org/QEMU/1551968334-18982-1-git-send-email-th...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

Deepika: the tricky part is the makefiles, not the configure script... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817345 Title: configure script breaks when $source_path contains white spaces

Re: [Qemu-devel] [PULL 0/7] Block patches

On Fri, 8 Mar 2019 at 16:53, Stefan Hajnoczi wrote: > > The following changes since commit 6cb4f6db4f4367faa33da85b15f75bbbd2bed2a6: > > Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' > into staging (2019-03-07 16:16:02 +) > > are available in the Git

Re: [Qemu-devel] [PATCH 3/9] tcg: Use extract2 in tcg_gen_shifti_i64

On Thursday, March 7, 2019, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 47 --- > 1 file changed, 24 insertions(+), 23 deletions(-) > > Extract2 is not a good name for this new function, IMHO. > diff --git

[Qemu-devel] [Bug 1819289] [NEW] Windows 95 and Windows 98 will not install or run

Public bug reported: The last version of QEMU I have been able to run Windows 95 or Windows 98 on was 2.7 or 2.8. Recent versions since then even up to 3.1 will either not install or will not run 95 or 98 at all. I have tried every combination of options like isapc or no isapc, cpu pentium or

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

If calling from any Unix shell, and the parameter has spaces, then we need to quote it.we can also use single quotes, these are more powerful. They stop the shell from interpreting anything ($, !, \, *, ", etc, except '). can't we use this approach here?? -- You received this bug notification

[Qemu-devel] [PATCH v3 2/2] hw/nvram/fw_cfg: Use the ldst API

The load/store API eases code review. Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 7fdf04adc9..3d8859e333 100644 --- a/hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH v3 0/2] fw_cfg: Trivial cleanups

Hi Laurent, These 2 patches are trivial cleanups extracted from a bigger fw_cfg series. Please consider for your next Trivial pull request. Regards, Phil. v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html v1:

[Qemu-devel] [PATCH v3 1/2] hw/arm/virt: Remove null-check in virt_build_smbios()

Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board", 2014-12-22), the machvirt_init() unconditionally creates the fw_cfg object. Later, commit c30e15658b1b ("smbios: implement smbios support for mach-virt", 2015-09-07) added a superfluous null-check on it. Remove this superfluous check.

Re: [Qemu-devel] [PATCH v2 16/18] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

Hi Eric, On 3/8/19 3:16 AM, Eric Blake wrote: > On 3/7/19 7:32 PM, Philippe Mathieu-Daudé wrote: >> The Edk2Crypto object is used to hold configuration values specific >> to EDK2. >> >> The edk2_add_host_crypto_policy() function loads crypto policies >> from the host, and register them as fw_cfg

Re: [Qemu-devel] 'make check' error

On Sat, Mar 09, 2019 at 13:53:32 +0800, Li Qiang wrote: > Hi all, > > Today I ‘git clone’ && configure && make && make check > > And get following error, > > fp-test.c:50:10: fatal error: fail.h: No such file or directory > #include "fail.h" > ^~~~ > > I look at the commit: >

Re: [Qemu-devel] [PULL 00/33] Block layer patches

On Fri, 8 Mar 2019 at 12:58, Kevin Wolf wrote: > > The following changes since commit c4e0780ed1ffd056f205348d387a61b4136a45df: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.0-pull-request' into staging > (2019-03-07 18:40:43 +) > > are available in the Git

Re: [Qemu-devel] [PULL 05/21] migration: Introduce ignore-shared capability

"Dr. David Alan Gilbert (git)" writes: > From: Yury Kotov > > We want to use local migration to update QEMU for running guests. > In this case we don't need to migrate shared (file backed) RAM. > So, add a capability to ignore such blocks during live migration. > > Signed-off-by: Yury Kotov >

Re: [Qemu-devel] [PATCH v3 7/8] multifd: Drop x-

Juan Quintela writes: > We make it supported from now on. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > hmp.c | 10 +- > migration/migration.c | 26 +- > qapi/migration.json | 34

Re: [Qemu-devel] [PATCH v3 4/8] multifd: Drop x-multifd-page-count parameter

Juan Quintela writes: > Libvirt don't want to expose (and explain it). From now on we measure > the number of packages in bytes instead of pages, so it is the same > independently of architecture. We choose the page size of x86. > Notice that in the following patch we make this variable. > >

Re: [Qemu-devel] [PATCH V3 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state

Zhang Chen writes: > From: Zhang Chen > > In this patch we add the processing state for COLOExitReason, > because we have to identify COLO in the failover processing state or > failover error state. In the way, we can handle all the failover state. > We have improved the description of the

Re: [Qemu-devel] [PATCH 07/10] roms: build edk2 firmware binaries and variable store templates

Hi Laszlo, On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Add the "efi" target to "Makefile". > > Introduce "Makefile.edk2" for building and cleaning the firmware images > and varstore templates. > > Collect the common bits from the recipes in the helper script > "edk2-build.sh". > > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/9] tcg: Add INDEX_op_extract2_{i32,i64}

On 3/8/19 3:28 PM, Philippe Mathieu-Daudé wrote: >> +CASE_OP_32_64(extract2): >> +if (arg_is_const(op->args[1]) && arg_is_const(op->args[2])) { >> +TCGArg v1 = arg_info(op->args[1])->val; >> +TCGArg v2 = arg_info(op->args[2])->val; >> +

Re: [Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

On 2019-03-09 10:27, Markus Armbruster wrote: > "Kővágó, Zoltán" writes: > >> This patch adds structures into qapi to replace the existing >> configuration structures used by audio backends currently. This qapi >> will be the base of the -audiodev command line parameter (that replaces >> the old

Re: [Qemu-devel] [PATCH v2 07/18] hw/nvram/fw_cfg: Add fw_cfg_common_unrealize()

Philippe Mathieu-Daudé writes: > Back in abe147e0ce4 when fw_cfg_add_file() was introduced, there > was no QOM design, object where not created and released at runtime. > Later 38f3adc34d finished the QOM conversion of the fw_cfg device, > adding the fw_cfg_common_realize() method. > The time

Re: [Qemu-devel] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command

The subject "Add QMP 'info fw_cfg' command" misspells query-fw_cfg-items :) Eric Blake writes: > On 3/7/19 7:32 PM, Philippe Mathieu-Daudé wrote: >> When debugging a paravirtualized guest firmware, it results very >> useful to dump the fw_cfg table. >> Add a QMP command which returns the most

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 06/18] hw/nvram/fw_cfg: Remove the unnecessary boot_splash_filedata_size

On 08/03/2019 07:49, Thomas Huth wrote: > On 08/03/2019 02.32, Philippe Mathieu-Daudé wrote: >> The 'boot_splash_filedata_size' was introduced as a global variable >> in 3d3b8303c6f. This variable is used as a 'size' argument to the >> fw_cfg_add_file(). This function has an interface contract

Re: [Qemu-devel] [Qemu-trivial] [Qemu-ppc] [PATCH v2 02/18] hw/i386: Remove unused include

On 08/03/2019 12:32, Thomas Huth wrote: > On 08/03/2019 02.32, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v2: Drop files that do use fw_cfg (Michael): >> - hw/i386/acpi-build.c >> - hw/i386/pc.c >> --- >> hw/acpi/piix4.c | 1 - >> 1 file changed, 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH] thunk: improve readability of allocation loop

On 08/03/2019 20:43, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > thunk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/thunk.c b/thunk.c > index 17f3d320bb..7f31cffe09 100644 > --- a/thunk.c > +++ b/thunk.c > @@ -86,7 +86,7 @@ void

Re: [Qemu-devel] [PATCH v2 07/18] hw/nvram/fw_cfg: Add fw_cfg_common_unrealize()

Laszlo Ersek writes: > On 03/08/19 07:55, Thomas Huth wrote: >> On 08/03/2019 02.32, Philippe Mathieu-Daudé wrote: >>> Back in abe147e0ce4 when fw_cfg_add_file() was introduced, there Suggest to say "commit abe147e0ce4". >>> was no QOM design, object where not created and released at runtime.

Re: [Qemu-devel] [PULL 0/5] Vga 20190308 patches

On Fri, 8 Mar 2019 at 12:42, Gerd Hoffmann wrote: > > The following changes since commit 32694e98b8d7a246345448a8f707d2e11d6c65e2: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-03-06 > 18:52:19 +) > > are available in the Git

Re: [Qemu-devel] [PATCH] Added periodic IRQ support for bcm2836_control local timer

On Sat, 9 Mar 2019 at 01:03, bzt wrote: > Thanks for your answers. If I don't clear the INTENABLE flag, then the > IRQ would keep firing constantly. This is not how the real hardware > works: it triggers the IRQ once, and then it inhibits. The timer won't > trigger the IRQ again until you

Re: [Qemu-devel] [PATCH v2 03/18] cutils: Add qemu_strdup_hexlify() and qemu_strdup_unhexlify()

Laszlo Ersek writes: > Hi Phil, > > most important comment at the bottom. > > On 03/08/19 02:32, Philippe Mathieu-Daudé wrote: >> Add two helpers: one to represent a binary data as a string of >> hexadecimal values, and one to restore a such string into its >> original binary data. >> >>

Re: [Qemu-devel] [PATCH] thunk: improve readability of allocation loop

On Fri, Mar 8, 2019 at 7:43 PM Aarushi Mehta wrote: > > Signed-off-by: Aarushi Mehta > --- > thunk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v5 1/2] Add generic Nios II board.

On Fri, 8 Mar 2019 at 23:51, Sandra Loosemore wrote: > > On 3/7/19 7:57 AM, Peter Maydell wrote: > >> diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c > >> index 5f0ab2f..c697047 100644 > >> --- a/hw/nios2/boot.c > >> +++ b/hw/nios2/boot.c > >> @@ -140,6 +140,7 @@ void nios2_load_kernel(Nios2CPU

Re: [Qemu-devel] [PATCH] usb-mtp: fix return status of delete

On Fri, 8 Mar 2019 at 22:14, Bandan Das wrote: > > > Spotted by Coverity: CID 1399414 > > mtp delete allows the a return status of delete succeeded, > partial_delete or readonly - when none of the objects could be > deleted. > > Some initiators recurse over the objects themselves. In that case, >

Re: [Qemu-devel] [RFC PATCH] docs/booting.rst: start documenting the boot process

On Fri, 8 Mar 2019 at 21:16, Alex Bennée wrote: > > While working on some test cases I realised there was quite a lot of > assumed knowledge about how things boot up. I thought it would be > worth gathering this together in a user facing document where we could > pour in the details and

Re: [Qemu-devel] [PATCH v2 01/18] hw/arm/virt: Remove null-check in virt_build_smbios()

Philippe Mathieu-Daudé writes: > Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board", > 2014-12-22), the machvirt_init() unconditionally creates the > fw_cfg object. Later, commit c30e15658b1b ("smbios: implement > smbios support for mach-virt", 2015-09-07) added a superfluous >

Re: [Qemu-devel] [PULL 3/4] usb-mtp: prevent null dereference while deleting objects

On Fri, 8 Mar 2019 at 19:46, Bandan Das wrote: > This is very broken! I think something like this should work: > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index 06e376bcd2..87a4bfb415 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -1138,8 +1138,8 @@ static MTPData

Re: [Qemu-devel] [PULL 0/2] tricore patches

On Fri, 8 Mar 2019 at 09:59, Bastian Koppelmann wrote: > > The following changes since commit 6cb4f6db4f4367faa33da85b15f75bbbd2bed2a6: > > Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' > into staging (2019-03-07 16:16:02 +) > > are available in the Git

Re: [Qemu-devel] [PATCH v3 00/14] pflash: Fixes and cleanups

Patchew URL: https://patchew.org/QEMU/20190307130323.9353-1-arm...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

On 3/9/19 1:48 AM, Laszlo Ersek wrote: > Repo: https://github.com/lersek/qemu.git > Branch: edk2_build > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > release, and builds and captures platform firmware binaries from that > release. At this point they are meant to

Re: [Qemu-devel] [PULL 19/22] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

On 03/09/2019 02:30 AM, Dr. David Alan Gilbert wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: On Wed, 6 Mar 2019 at 11:55, Dr. David Alan Gilbert (git) wrote: From: Wei Wang Wei: Can you look at this Sure, I'll send a followup patch to fix this. The new feature enables

Re: [Qemu-devel] [PATCH v3 5/10] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX

2019/3/9 10:46, Laurent Vivier: > On 06/03/2019 05:49, Unai Martinez-Corral wrote: > > -QEMU_PATH=/usr/local/bin > > - > > +QEMU_PATH="${QEMU_PATH:-/usr/local/bin}" > > +QEMU_SUFFIX="${QEMU_SUFFIX:-}" > > QEMU_CREDENTIAL="${QEMU_CREDENTIAL:-no}" > > QEMU_PERSISTENT="${QEMU_PERSISTENT:-no}" > > >

Re: [Qemu-devel] [PATCH v3 3/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

2019/3/9 10:42, Laurent Vivier: > On 06/03/2019 05:46, Unai Martinez-Corral wrote: > > Allow to set options '--persistent' and/or '--credential' through > > environment variables. If not defined, defaults are used ('no'). > > Anyway, command-line arguments have priority over environment variables.

Re: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh

Patchew URL: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190306031221.GA53@03612eec87fc Subject: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh ===

Re: [Qemu-devel] [PATCH v3 5/10] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX

On 06/03/2019 05:49, Unai Martinez-Corral wrote: > Allow to set 'path' or 'suffix' through environment variables, > consistently with 'persistent' and 'credential'. > > Signed-off-by: Unai Martinez-Corral > --- > scripts/qemu-binfmt-conf.sh | 7 +++ > 1 file changed, 3 insertions(+), 4

Re: [Qemu-devel] [PATCH v3 4/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options

On 06/03/2019 05:49, Unai Martinez-Corral wrote: > This breaks backward compatibility. > > Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is > not present in other option names ('debian', 'systemd', 'persistent', > 'credential'...). In order to keep consistency, the prefix

Re: [Qemu-devel] [PATCH v3 3/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

On 06/03/2019 05:46, Unai Martinez-Corral wrote: > Allow to set options '--persistent' and/or '--credential' through > environment variables. If not defined, defaults are used ('no'). > Anyway, command-line arguments have priority over environment variables. > Could you explain why we could need

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] block: Gluster 6 compatibility

On Fri, Mar 08, 2019 at 02:11:51PM +0100, Kevin Wolf wrote: > Am 05.03.2019 um 16:46 hat Niels de Vos geschrieben: > > Gluster 6 is currently available as release candidate. There have been a > > few changes to libgfapi.so that need to be adapted by consuming projects > > like QEMU. Fedora Rawhide

Re: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh

Patchew URL: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190306031221.GA53@03612eec87fc Subject: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh ===

Re: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh

Patchew URL: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190306031221.GA53@03612eec87fc Subject: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh ===

Re: [Qemu-devel] [PATCH v3 2/10] qemu-binfmt-conf.sh: make opts -p and -c boolean

On 06/03/2019 05:42, Unai Martinez-Corral wrote: > This patch breaks backward compatibility. > > Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' > or '-c no' are reduntant. Overall, accepting an argument might be > misleading because options are, indeed, boolean. This patch

Re: [Qemu-devel] [PATCH v3 1/10] qemu-binfmt-conf.sh: enforce safe style consistency

On 06/03/2019 05:36, Unai Martinez-Corral wrote: > Spaces are added before '; then', for consistency. > > All the tests are prefixed with 'x', in order to avoid risky comparisons > (i.e. a user deliberately trying to provoke a syntax error). > > Signed-off-by: Unai Martinez-Corral > --- >

Re: [Qemu-devel] [PATCH v6 01/14] qapi: qapi for audio backends

"Kővágó, Zoltán" writes: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables based config). > > This is not

Re: [Qemu-devel] [PATCH v7] pflash: Require backend size to match device, improve errors

Philippe Mathieu-Daudé writes: > On 3/8/19 4:40 PM, Kevin Wolf wrote: >> Am 08.03.2019 um 15:29 hat Markus Armbruster geschrieben: >>> Kevin Wolf writes: >>> Am 08.03.2019 um 13:28 hat Markus Armbruster geschrieben: > Laszlo Ersek writes: >> This one has got to be one of the

Re: [Qemu-devel] [PATCH] qmp-shell: fix nested json regression

John Snow writes: > On 2/5/19 8:49 AM, Marc-André Lureau wrote: >> Commit fcfab7541 ("qmp-shell: learn to send commands with quoted >> arguments") introduces the usage of Python 'shlex' to handle quoted >> arguments, but it accidentally broke generation of nested JSON >> structs. >> >> shlex

Re: [Qemu-devel] [PATCH] hw/char/parallel: Make it possible to compile also without CONFIG_PARALLEL

On 09/03/2019 09.12, Thomas Huth wrote: > For the downstream distribution of QEMU, we want to compile without > CONFIG_PARALLEL. Commit 9157eee1b1c076ff3 already moved the function > parallel_hds_isa_init() (which is still required for linking) into a file > that is included anyway, but commit

[Qemu-devel] [PATCH] hw/char/parallel: Make it possible to compile also without CONFIG_PARALLEL

For the downstream distribution of QEMU, we want to compile without CONFIG_PARALLEL. Commit 9157eee1b1c076ff3 already moved the function parallel_hds_isa_init() (which is still required for linking) into a file that is included anyway, but commit bb3d5ea858e7f888563a moved it to a separate file

[Qemu-devel] [PULL 19/25] scsi-disk: Fix crash if request is invaild or disk is no medium

From: Zhengui Li Qemu will crash with the assertion error that "assert(r->req.aiocb != NULL)" in scsi_read_complete if request is invaild or disk is no medium. The error is below: qemu-kvm: hw/scsi/scsi_disk.c:299: scsi_read_complete: Assertion `r->req.aiocb != NULL' failed. This patch add a

Re: [Qemu-devel] [PATCH] contrib/elf2dmp: add kernel start address checking

On 08/03/19 18:55, Peter Maydell wrote: > On Wed, 20 Feb 2019 at 11:30, Paolo Bonzini wrote: >> >> On 19/02/19 22:19, Viktor Prutyanov wrote: >>> Before this patch, if elf2dmp failed to find NT kernel PE magic in >>> allowed virtual address range, then it assumes NULL as NT kernel >>> address and

[Qemu-devel] [PULL 18/25] configure: Disable W^X on OpenBSD

From: Philippe Mathieu-Daudé Since OpenBSD 6.0 [1], W^X is enforced by default [2]. TCG requires WX access. Disable W^X if it is available. This fixes: # lm32-softmmu/qemu-system-lm32 Could not allocate dynamic translator buffer # sysctl kern.wxabort=1 kern.wxabort: 0 -> 1 #

[Qemu-devel] [PULL 22/25] lsi: use enum type for s->msg_action

From: Sven Schnelle This makes the code easier to read - no functional change. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190305195519.24303-4-sv...@stackframe.org> --- hw/scsi/lsi53c895a.c | 27 --- 1 file changed, 16

[Qemu-devel] [PULL 23/25] lsi: use SCSI phase names instead of numbers in trace

From: Sven Schnelle This makes trace logs much easier to read, especially for people who are not fluent in SCSI. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190305195519.24303-5-sv...@stackframe.org> --- hw/scsi/lsi53c895a.c | 31

[Qemu-devel] [PULL 11/25] lsi: check if SIGP bit is already set in Wait reselect

From: Sven Schnelle If SIGP is set, the 'Wait for Reselection' command should jump immediately to the address stored in the second DWORD of the instruction. This fixes spurious hangs in the HP-UX 11.11 installer when the SIGP bit gets set by the kernel before the 'Wait for Reselection' command

[Qemu-devel] [PULL 16/25] accel: Allow to build QEMU without TCG or KVM support

From: Anthony PERARD Instead of deny build of QEMU without a default accelerator, simply report an error when the user haven't passed -accel or -machine accel= and TCG and KVM isn't builtin. ./configure already check that at least one accelerator is available. Signed-off-by: Anthony PERARD

[Qemu-devel] [PULL 24/25] lsi: return dfifo value

From: Sven Schnelle Code was assigning DFIFO, but didn't return the value to users. Signed-off-by: Sven Schnelle Message-Id: <20190305195519.24303-6-sv...@stackframe.org> --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c

[Qemu-devel] [PULL 12/25] update copyright notice

From: David Kiarie Signed-off-by: David Kiarie Message-Id: <20190304151827.1813-2-davidkiar...@gmail.com> Signed-off-by: Paolo Bonzini --- hw/i386/amd_iommu.c | 2 +- hw/i386/amd_iommu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/amd_iommu.c

[Qemu-devel] [PULL 25/25] exec: streamline flatview_add_to_dispatch

The while loop in flatview_add_to_dispatch can only be executed twice and it will go through different paths on each execution (in fact one of the "if" branches is dead). Remove the loop completely, the code becomes clearer at the cost of a handful of duplicated lines. Reported-by: Wei Yang

[Qemu-devel] [PULL 20/25] lsi: use ldn_le_p()/stn_le_p()

From: Sven Schnelle Instead of using the open-coded versions, use the helper already present as this makes the code easier to read and less error-prone. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190305195519.24303-2-sv...@stackframe.org> ---