In commit b94b330e2333 ("tests: add missing dependency to build
QTEST_QEMU_BINARY", 2017-07-31), Phil fixed the dependency list of make
target "check-qtest-%". Namely, the recipe would set QTEST_QEMU_BINARY to
the softmmu emulator for the emulation target, but the prerequisites
didn't include the e
Patchew URL:
https://patchew.org/QEMU/20190321104745.28068-1-shameerali.kolothum.th...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190321104745.28068-1-shameerali.kolothum.th...@huawei.com
Subject: [Qemu-devel] [PA
From: Eric Auger
This patch adds the the memory hot-plug/hot-unplug infrastructure
in machvirt. It is still not enabled as device memory is not yet
reported to guest.
Signed-off-by: Eric Auger
Signed-off-by: Kwangwoo Lee
Signed-off-by: Shameer Kolothum
---
default-configs/arm-softmmu.mak |
Am 20.03.2019 um 18:02 hat Alberto Garcia geschrieben:
> On Wed 20 Mar 2019 10:16:10 AM CET, Kevin Wolf wrote:
> >> Oh, I see. Let's use a shorter chain for simplicity:
> >>
> >>A <- B <- C <- D <- E
> >
> > Written from right to left, i.e. E being the base and A the top layer?
> > We usually
From: Samuel Ortiz
This adds the skeleton to support an acpi device interface
for HW-reduced acpi platforms via ACPI GED - Generic Event
Device (ACPI v6.1 5.6.9).
This will be used by Arm/Virt to add hotplug support.
Signed-off-by: Samuel Ortiz
Signed-off-by: Shameer Kolothum
---
hw/acpi/Kco
This series is an attempt to provide device memory hotplug support
on ARM virt platform. This is based on Eric's recent works here[1]
and carries some of the pc-dimm related patches dropped from his
series.
The kernel support for arm64 memory hot add was added recently by
Robin and hence the gues
On 20/03/19 15:07, Zhengui li wrote:
> The function fcntl maybe return -1, which is not a unsigned type.
> Unsigned type or Negative values should not do bitwise operator with
> O_ACCMODE.
Did you actually find a case in which the fcntl can fail?
Paolo
> Signed-off-by: Zhengui li
> ---
> scsi/
This is to disable/enable populating DT nodes in case
any conflict with acpi tables. The default is "off".
This will be used in subsequent patch where cold plug
device-memory support is added for DT boot.
If DT memory node support is added for cold-plugged device
memory, those memory will be visi
On Wed, 20 Mar 2019 at 16:58, Daniel P. Berrangé wrote:
>
> The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2:
>
> Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +)
>
> are available in the Git repository at:
>
> https://github.com/berrange/qemu tags/q
This is in preparation for adding support for ARM64 platforms
where it doesn't use port mapped IO for ACPI IO space.
Also move the MEMORY_SLOT_SCAN_METHOD/MEMORY_DEVICES_CONTAINER
definitions to header so that other memory hotplug event
signalling mechanisms (eg. Generic Event Device on HW-reduced
This adds support to build the aml code so that Guest(ACPI boot)
can see the cold-plugged device memory. Memory cold plug support
with DT boot is not yet enabled.
Signed-off-by: Shameer Kolothum
---
default-configs/arm-softmmu.mak| 2 ++
hw/acpi/generic_event_device.c | 23 +
From: Samuel Ortiz
With Hardware-reduced ACPI, the GED device will manage ACPI
hotplug entirely. As a consequence, make the memory specific
events AML generation optional. The code will only be added
when the method name is not NULL.
Signed-off-by: Samuel Ortiz
Signed-off-by: Shameer Kolothum
This patch adds memory nodes corresponding to PC-DIMM regions.
This is an opt-in feature and needs to be enabled("fdt=on") when
Guest is booted with DT.
NVDIMM and ACPI_NVDIMM configs are not yet set for ARM so we
don't need to care about NVDIMM at this stage.
Signed-off-by: Shameer Kolothum
Sig
From: Samuel Ortiz
The ACPI Generic Event Device (GED) is a hardware-reduced specific
device that handles all platform events, including the hotplug ones.
This patch generates the AML code that defines GEDs.
Platforms need to specify their own GedEvent array to describe what
kind of events they
This initializes the GED device with base memory and irq,
configures ged memory hotplug event and builds the
corresponding aml code.
GED irq routing to Guest is also enabled. Memory hotplug
should now work.
Signed-off-by: Shameer Kolothum
---
hw/acpi/generic_event_device.c | 18
Generate Memory Affinity Structures for PC-DIMM ranges.
Signed-off-by: Shameer Kolothum
Signed-off-by: Eric Auger
Reviewed-by: Igor Mammedov
---
hw/arm/virt-acpi-build.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 20d3c
On Thu, 21 Mar 2019, Laurent Vivier wrote:
On 21/03/2019 11:15, BALATON Zoltan wrote:
On Thu, 21 Mar 2019, Laurent Vivier wrote:
Stop processing the descriptor list instead. The next frame timer tick
will
resume the work
Shoud this log something when the limit is reached to let the user know
On Thu, 21 Mar 2019, Laurent Vivier wrote:
Stop processing the descriptor list instead. The next frame timer tick will
resume the work
Shoud this log something when the limit is reached to let the user know
why USB stopped working instead of silently ignoring frames?
Regards,
BALATON Zoltan
On 21/03/2019 - 09:30:24, Peter Maydell wrote:
> On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo wrote:
> >
> > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2:
> >
> > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +)
> >
> > are available in the Git repo
On 21/03/2019 11:15, BALATON Zoltan wrote:
> On Thu, 21 Mar 2019, Laurent Vivier wrote:
>> Stop processing the descriptor list instead. The next frame timer tick
>> will
>> resume the work
>
> Shoud this log something when the limit is reached to let the user know
> why USB stopped working instead
Obviously NACK to applying this PULL given the patchew reported
mess up I did with tests. Not sure why patchew never gave any
complaint when the original patch was posted & reviewed :-(
On Wed, Mar 20, 2019 at 05:41:47PM +, Daniel P. Berrangé wrote:
> The following changes since commit 62a172
IEC binary prefixes are defined in "qemu/units.h", so we
can remove redundant definitions in "block/vhdx.h".
Signed-off-by: Stefano Garzarella
---
block/vhdx-log.c | 1 +
block/vhdx.c | 4 +++-
block/vhdx.h | 5 -
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/block/v
Wainer dos Santos Moschetta writes:
> Hi all,
>> Conclusion
>> ==
>>
>> I think generally the state of QEMU's CI has improved over the last few
>> years but we still have a number of challenges caused by its distributed
>> nature and test stability. We are still re-active to failures r
Cleber Rosa writes:
> On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote:
>>
>> Hi,
>>
>> As we approach stabilisation for 4.0 I thought it would be worth doing a
>> review of the current state of CI and stimulate some discussion of where
>> it is working for us and what could be impro
Le mar. 19 mars 2019 17:35, Markus Armbruster a écrit :
> We reject undersized backends with a rather enigmatic "failed to read
> the initial flash content" error. For instance:
>
> $ qemu-system-ppc64 -S -display none -M sam460ex -drive
> if=pflash,format=raw,file=eins.img
> qemu-system
Ok！
-邮件原件-
发件人: Stefano Garzarella [mailto:sgarz...@redhat.com]
发送时间: 2019年3月21日 17:28
收件人: lizhengui
抄送: pbonz...@redhat.com; stefa...@redhat.com; mre...@redhat.com;
kw...@redhat.com; wangjie (P); qemu-devel@nongnu.org; qemu-bl...@nongnu.org;
Fangyi (C)
主题: Re: [Qemu-devel] [PATCH] qem
On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo wrote:
>
> The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2:
>
> Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +)
>
> are available in the Git repository at:
>
> https://github.com/otubo/qemu.git tags/pull-
Hi Zhengui,
thanks for this patch!
For the next patches, please add a version tag when resending.
"git format-patch" and "git send-email" both understand the
"-v2" option.
On Wed, Mar 20, 2019 at 10:07:27PM +0800, Zhengui li wrote:
> The function fcntl maybe return -1, which is not a unsigned typ
On 13/03/2019 17.28, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
>
> contrib/libvh
Markus Armbruster writes:
> We reject undersized backends with a rather enigmatic "failed to read
> the initial flash content" error. For instance:
>
> $ qemu-system-ppc64 -S -display none -M sam460ex -drive
> if=pflash,format=raw,file=eins.img
> qemu-system-ppc64: Initialization of d
Stop processing the descriptor list instead. The next frame timer tick will
resume the work
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1686705
Suggested-by: Gerd Hoffmann
Signed-off-by: Laurent Vivier
---
hw/usb/hcd-ohci.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
d
On 14/03/2019 14.10, Marc-André Lureau wrote:
> In order to make slirp a standalone project, the project must have a
> clear license, and be compatible with the GPL or LGPL.
>
> Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the
> advertising clause from the slirp license"), slirp
On 14/03/2019 14.34, Eric Blake wrote:
> On 3/14/19 8:10 AM, Marc-André Lureau wrote:
>> According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove
>> the advertising clause from the slirp license"), Danny Gasparovski
>> gave permission to license slirp code under 3-clause BSD license:
>
20.03.2019 20:25, Alberto Garcia wrote:
> On Wed 20 Mar 2019 10:35:27 AM CET, Vladimir Sementsov-Ogievskiy wrote:
>>> Maybe at least this kind of freezing isn't the right tool for block
>>> jobs, after all.
>>
>> I think, the correct way, which will support these correct cases
>> (which however don
On Thu, Mar 14, 2019 at 10:45:25PM +0800, Jason Wang wrote:
>
> On 2019/2/25 下午8:33, Michael S. Tsirkin wrote:
> > On Mon, Feb 25, 2019 at 03:47:48PM +0800, Jason Wang wrote:
> > > On 2019/2/22 下午12:22, Michael S. Tsirkin wrote:
> > > > On Thu, Feb 21, 2019 at 10:10:08PM -0500, Michael S. Tsirkin
The maximum level is defined as P_L2_LEVELS and skip is defined with 6
bits, which means if P_L2_LEVELS < (1 << 6), skip never exceeds the
boundary.
Since this check is between two constants, which leverages compiler
to optimize the code based on different configuration.
Signed-off-by: Wei Yang
In subpage_init(), we will set subpage->sub_section to
PHYS_SECTION_UNASSIGNED by subpage_register. Since
PHYS_SECTION_UNASSIGNED is defined to be 0, and we allocate subpage with
g_malloc0, this means subpage->sub_section is already initialized to 0.
This patch removes the redundant setup for a ne
skip is defined with 6 bits. So the maximum value should be (1 << 6).
Signed-off-by: Wei Yang
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 788a8c3f69..6c660f656c 100644
--- a/exec.c
+++ b/exec.c
@@ -322,7 +322,7 @@ static void phys_page_com
This serial refine exec a little.
Wei Yang (6):
exec.c: replace hwaddr with uint64_t for better understanding
exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in
phys_map_node_alloc()
exec.c: get nodes_nb_alloc with one MAX calculation
exec.c: subpage->sub_section is already i
The purpose of these two MAX here is to get the maximum of these three
variables:
A: map->nodes_nb + nodes
B: map->nodes_nb_alloc
C: alloc_hint
We can write it like MAX(A, B, C). Since the if condition says A > B,
this means MAX(A, B, C) = MAX(A, C).
This patch just simplify the calc
Function phys_page_set() and phys_page_set_level() 's argument *nb*
stands for number of pages to set instead of hardware address.
This would be more proper to use uint64_t instead of hwaddr for its
type.
Signed-off-by: Wei Yang
---
exec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(
PHYS_MAP_NODE_NIL is assigned to PhysPageEntry.ptr in case this is not a
leaf entry, while map->nodes_nb range in [0, nodes_nb_alloc).
Seems we are asserting on two different things, just remove it.
Signed-off-by: Wei Yang
---
exec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/exec.c b/e
On 20/03/2019 16.11, Jason J. Herne wrote:
> On 3/13/19 12:31 PM, Jason J. Herne wrote:
>> This is to support booting from vfio-ccw dasd devices. We basically
>> implement
>> the real hardware ipl procedure. This allows for booting Linux guests on
>> vfio-ccw devices.
>>
>> vfio-ccw's channel progr
On 20/03/2019 18.32, John Snow wrote:
>
>
> On 3/1/19 7:20 AM, Thomas Huth wrote:
>> iotest 235 currently only works with KVM - this is bad for systems where
>> it is not available, e.g. CI pipelines. The test also works when using
>> "tcg" as accelerator, so we can simply add that to the list of
vhost-scsi doesn’t takes into account whether the vm is running or not in
order to decide if it should start/stop vhost processing.
This would lead to vhost processing still being active when VM the RunState
suddenly change to stopped.
An example of when this issue is encountered is when Live-Migr
From: Liran Alon
Originally migration was not possible with vhost-scsi because
as part of migration, the source host target SCSI device state
needs to be saved and loaded into the destination host target SCSI
device. This cannot be done by QEMU.
As this can be handled either by external orchestr
Originally migration was not possible with vhost-scsi because
as part of migration, the source host target SCSI device state
needs to be saved and loaded into the destination host target SCSI
device. This cannot be done by QEMU.
As this can be handled either by external orchestrator or by having
s
As preparation of enabling migration of vhost-scsi device,
define it’s VMState. Note, we keep the convention of
verifying in the pre_save() method that the vhost backend
must be stopped before attempting to save the device
state. Similar to how it is done for vhost-vsock.
Reviewed-by: Bijan Mottah
On Wed, 20 Mar 2019 at 19:42, Laszlo Ersek wrote:
> An alternative to rebasing / reworking the series in-place (for
> xz-->bz2) and to missing the 4.0 bus consequently, would be to merge the
> PULL req as is, and for me to submit an incremental update, for the
> xz-->bz2 replacement. I think that
Wainer dos Santos Moschetta writes:
> The script generated from QEMU_SRC/.travis.yml uses BUILD_DIR and
> SRC_DIR path relative to the current dir, unless these variables
> are exported in environment.
>
> Since commit 05790dafef1 BUILD_DIR is exported in the runner script,
> although SRC_DIR i
Wainer dos Santos Moschetta writes:
> Fixed the travis.py script that has failed to parse the current
> QEMU_SRC/.travis.yml file. It no longer makes combinations from
> env/matrix, instead it uses explicit includes. Also the compiler
> can be omitted from matrix/include, so that Travis chooses
Wainer dos Santos Moschetta writes:
> The `make docker-travis@IMAGE` is broken because:
> 1) travis.py fails to parse the current .travis.yml
> 2) The travis script does not get the correct reference
> to the source directory. It is a regression introduced on
> commit 05790dafef1.
>
> Tested wi
Patchew URL:
https://patchew.org/QEMU/176e53d9-50b8-405c-82ff-524734226...@me.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 176e53d9-50b8-405c-82ff-524734226...@me.com
Subject: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbin
In fullscreen mode, the window property of cocoaView may not be the key
window, and the current implementation would not grab mouse in
fullscreen mode after left clicks on relative input devices.
This patch used isFullscreen value as a short-cirtuit condition for
relative input device grabbing.
N
201 - 254 of 254 matches
Mail list logo
