Re: [Qemu-devel] [PATCH v6 16/16] s390-bios: Use control unit type to find bootable devices

2019-04-04 Thread Thomas Huth
On 04/04/2019 16.34, Jason J. Herne wrote: > When the user does not specify which device to boot from then we end > up guessing. Instead of simply grabbing the first available device let's > be a little bit smarter and only choose devices that might be bootable > like disk, and not console

Re: [Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse()

2019-04-04 Thread Markus Armbruster
Wei Yang writes: > On Thu, Apr 04, 2019 at 06:05:25PM +0200, Markus Armbruster wrote: >>Wei Yang writes: >> >>> On Tue, Apr 02, 2019 at 03:26:50PM +0200, Markus Armbruster wrote: Exploit that argument @name is nerver null. Check is_help_option() first, because that's what we do

Re: [Qemu-devel] [PATCH for-4.1 4/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-04 Thread Thomas Huth
On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: > ISA Super I/O are already modeled by the ISASuperIODevice abstract > device. > Since this board uses a generic ISA Super I/O chipset, refactor it > as the TYPE_R4K_SUPERIO device, child of ISASuperIODevice. Good idea! > Signed-off-by: Philippe

[Qemu-devel] [Bug 1823169] Re: qemu displays message "Setup failed, please check external storage is available and has enough room."

2019-04-04 Thread Thomas Huth
If you only want to use the package that is provided with your Linux distribution, you should report bugs to the distribution bug tracker instead, i.e. set Target -> Distribution = Ubuntu, Package = QEMU. Please don't use Project = qemu in that case. Thanks! -- You received this bug notification

Re: [Qemu-devel] [PATCH for-4.1 3/4] hw/isa/superio: Support chipsets with no Floppy Disk controller

2019-04-04 Thread Thomas Huth
On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: > Not all Super I/O chipsets provide a Floppy Disk Controller. > > Without this change, using a Super I/O with no FDC would abort QEMU with: > > Initialization of device isa-fdc failed: ISA controller does not support DMA > > Signed-off-by:

Re: [Qemu-devel] [PATCH for-4.1 1/4] hw/isa/superio: Rename a variable

2019-04-04 Thread Thomas Huth
On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: > This patch is purely cosmetic. No functional change. > This will ease the next patch where we re-indent an if() statement. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/isa/isa-superio.c | 69

Re: [Qemu-devel] [PULL 0/2] xen queue for 4.0-rc3

2019-04-04 Thread Peter Maydell
in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > tags/pull-xen-20190404 > > for you to fetch changes up to 2bcd05cf24a7de34e7e265247c010977e43f40bc: > > xen-block: scale sector based quantiti

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-04 Thread Peter Maydell
On Fri, 5 Apr 2019 at 01:59, Helge Deller wrote: > If a non-release architecture is found, and it's known that there is no > native TCG support for that CPU, automatically fall back to the TCI > implementation instead of requesting the user to run configure again > with the

[Qemu-devel] QUESTION: How to measure performance of the emulation of a single target instruction?

2019-04-04 Thread Aleksandar Markovic
Hello, folks. There is some optimization activity in MIPS target, and we have some simple micro-benchmarks for measuring speed of emulation of a single target instruction, but I am not particulary happy with them. They are just a single instruction assembly within a “for“ loop. I tried some other

[Qemu-devel] [PULL 1/2] riscv: plic: Fix incorrect irq calculation

2019-04-04 Thread Palmer Dabbelt
From: Alistair Francis This patch fixes four different things, to maintain bisectability they have been merged into a single patch. The following fixes are below: sifive_plic: Fix incorrect irq calculation The irq is incorrectly calculated to be off by one. It has worked in the past as the

[Qemu-devel] [PULL 2/2] riscv: plic: Log guest errors

2019-04-04 Thread Palmer Dabbelt
From: Alistair Francis Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- hw/riscv/sifive_plic.c | 12 +--- 1 file changed, 9 insertions(+), 3

[Qemu-devel] [PULL] RISC-V Patches for 4.0-rc3, v2

2019-04-04 Thread Palmer Dabbelt
The following changes since commit 061b51e9195670e9d190cdec46fabcb3c77763fb: Update version for v4.0.0-rc2 release (2019-04-02 17:01:20 +0100) are available in the Git repository at: git://github.com/palmer-dabbelt/qemu.git tags/riscv-for-master-4.0-rc3-v2 for you to fetch changes up to

Re: [Qemu-devel] [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA instructions

2019-04-04 Thread Aleksandar Markovic
On Apr 4, 2019 9:17 PM, "Philippe Mathieu-Daudé" wrote: > > Hi Aleksandar, > > On 4/4/19 8:19 PM, Aleksandar Markovic wrote: > >> From: Philippe Mathieu-Daudé > >> Subject: Re: [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA instructions > >> > >> Hi Mateja, > >> > >> On 4/4/19 3:14 PM, Mateja

Re: [Qemu-devel] [PULL] RISC-V Patches for 4.0-rc3

2019-04-04 Thread Palmer Dabbelt
On Thu, 04 Apr 2019 11:18:52 PDT (-0700), alistai...@gmail.com wrote: On Thu, Apr 4, 2019 at 1:45 AM Peter Maydell wrote: On Thu, 4 Apr 2019 at 08:00, Palmer Dabbelt wrote: > > The following changes since commit 49fc899f8d673dd9e73f3db0d9e9ea60b77c331b: > > Update version for v4.0.0-rc1

Re: [Qemu-devel] [PATCH v7 3/6] target/ppc: Handle NMI guest exit

2019-04-04 Thread David Gibson
On Thu, Apr 04, 2019 at 02:40:45PM +0530, Aravinda Prasad wrote: > > > On Monday 25 March 2019 11:52 AM, David Gibson wrote: > > On Fri, Mar 22, 2019 at 12:03:58PM +0530, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the

Re: [Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse()

2019-04-04 Thread Wei Yang
On Thu, Apr 04, 2019 at 06:05:25PM +0200, Markus Armbruster wrote: >Wei Yang writes: > >> On Tue, Apr 02, 2019 at 03:26:50PM +0200, Markus Armbruster wrote: >>>Exploit that argument @name is nerver null. Check is_help_option() >>>first, because that's what we do elsewhere. >>> >>>Signed-off-by:

Re: [Qemu-devel] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-04 Thread Philippe Mathieu-Daudé
On 4/1/19 10:58 PM, Michael Roth wrote: > Hi everyone, > > > The following new patches are queued for QEMU stable v3.0.1: > > https://github.com/mdroth/qemu/commits/stable-3.0-staging > > The

[Qemu-devel] [PATCH for-4.1 1/4] hw/isa/superio: Rename a variable

2019-04-04 Thread Philippe Mathieu-Daudé
This patch is purely cosmetic. No functional change. This will ease the next patch where we re-indent an if() statement. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-superio.c | 69 ++-- 1 file changed, 34 insertions(+), 35 deletions(-) diff

[Qemu-devel] [PATCH for-4.1 2/4] hw/isa/superio: Support more than one IDE bus

2019-04-04 Thread Philippe Mathieu-Daudé
The current code is limited to a single IDE bus (supporting two IDE drives). Some Super I/O chipset provide two IDE buses (four IDE drives). Modify the model to support more that one IDE bus. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-superio.c | 43

[Qemu-devel] [PATCH for-4.1 3/4] hw/isa/superio: Support chipsets with no Floppy Disk controller

2019-04-04 Thread Philippe Mathieu-Daudé
Not all Super I/O chipsets provide a Floppy Disk Controller. Without this change, using a Super I/O with no FDC would abort QEMU with: Initialization of device isa-fdc failed: ISA controller does not support DMA Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-superio.c | 3 ++- 1 file

[Qemu-devel] [PATCH for-4.1 0/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-04 Thread Philippe Mathieu-Daudé
Hi, This series refactor the superio code used in the mips_r4k machine, adding the TYPE_R4K_SUPERIO device. Doing so we improve the ISASuperIODevice, fixing an easy bug. This series also demonstrate that no machine access a I8042 ISA device out of a Super I/O chipset. Regards, Phil.

[Qemu-devel] [PATCH for-4.1 4/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-04 Thread Philippe Mathieu-Daudé
ISA Super I/O are already modeled by the ISASuperIODevice abstract device. Since this board uses a generic ISA Super I/O chipset, refactor it as the TYPE_R4K_SUPERIO device, child of ISASuperIODevice. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_r4k.c | 61

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-04 Thread Michael Roth
Quoting Cole Robinson (2019-04-02 11:22:59) > On 4/1/19 4:58 PM, Michael Roth wrote: > > Hi everyone, > > > > > > The following new patches are queued for QEMU stable v3.0.1: > > > >

Re: [Qemu-devel] [PATCH] hw/input/pckbd: The i8042 device should not be user_creatable

2019-04-04 Thread Philippe Mathieu-Daudé
On 4/4/19 6:40 PM, Philippe Mathieu-Daudé wrote: > On 4/4/19 4:19 PM, Thomas Huth wrote: >> On 04/04/2019 15.29, Philippe Mathieu-Daudé wrote: >>> On 4/4/19 12:07 PM, Paolo Bonzini wrote: On 04/04/19 09:14, Thomas Huth wrote: > The i8042 PS/2 controller is part of the chipset on the

Re: [Qemu-devel] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability

2019-04-04 Thread Fabiano Rosas
Aravinda Prasad writes: (...) > diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h > index df5e85f..cf7b24f 100644 > --- a/target/ppc/kvm_ppc.h > +++ b/target/ppc/kvm_ppc.h > @@ -27,6 +27,7 @@ void kvmppc_enable_h_page_init(void); > void kvmppc_set_papr(PowerPCCPU *cpu); > int

Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp

2019-04-04 Thread Thomas Huth
On 04/04/2019 20.39, Helge Deller wrote: > All major distributions do support libseccomp version >= 2.3.0, so there > is no need to special-case on various architectures any longer. > > Signed-off-by: Helge Deller > > diff --git a/configure b/configure > index 1c563a7027..8fe4fc84d8 100755 >

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-04 Thread Philippe Mathieu-Daudé
Hi Helge, On 4/4/19 8:57 PM, Helge Deller wrote: > If a non-release architecture is found, and it's known that there is no > native TCG support for that CPU, automatically fall back to the TCI > implementation instead of requesting the user to run configure again > with the

Re: [Qemu-devel] [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA instructions

2019-04-04 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 4/4/19 8:19 PM, Aleksandar Markovic wrote: >> From: Philippe Mathieu-Daudé >> Subject: Re: [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA >> instructions >> >> Hi Mateja, >> >> On 4/4/19 3:14 PM, Mateja Marjanovic wrote: >>> From: Mateja Marjanovic >>> >>> Optimize set of

[Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-04 Thread Helge Deller
If a non-release architecture is found, and it's known that there is no native TCG support for that CPU, automatically fall back to the TCI implementation instead of requesting the user to run configure again with the --enable-tcg-interpreter option. This change simplifies building qemu in

[Qemu-devel] [PATCH v2] configure: Relax check for libseccomp

2019-04-04 Thread Helge Deller
All major distributions do support libseccomp version >= 2.3.0, so there is no need to special-case on various architectures any longer. Signed-off-by: Helge Deller diff --git a/configure b/configure index 1c563a7027..8fe4fc84d8 100755 --- a/configure +++ b/configure @@ -2377,36 +2369,16 @@ fi

Re: [Qemu-devel] [PATCH v2 2/2] target/mips: add or remove space to fix checkpatch errors

2019-04-04 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH v2 2/2] target/mips: add or remove space to fix checkpatch > errors > > Add or remove space to fix errors issued by checkpatch.pl tool > "ERROR: spaces required around ..." > "ERROR: space required after that" > "ERROR: space required before the open

[Qemu-devel] [PATCH for 4.0 v3 0/2] Update the QEMU PLIC addresses

2019-04-04 Thread Alistair Francis
This series updates the PLIC address to match the documentation. This fixes: https://github.com/riscv/opensbi/issues/97 V3: - Fix SiFive U crash V2: - Squash patches to ensure biesctability Alistair Francis (2): riscv: plic: Fix incorrect irq calculation riscv: plic: Log guest errors

Re: [Qemu-devel] [PATCH v2 1/2] target/mips: realign comments to fix checkpatch warnings

2019-04-04 Thread Aleksandar Markovic
> From: Jules Irenge > Sent: Thursday, April 4, 2019 7:39 PM > To: Aleksandar Markovic > Cc: Aleksandar Rikalo; qemu-devel@nongnu.org > Subject: [PATCH v2 1/2] target/mips: realign comments to fix checkpatch > warnings > > Realign comments to fix warnings issued by checkpatch.pl tool >

[Qemu-devel] [PATCH for 4.0 v3 2/2] riscv: plic: Log guest errors

2019-04-04 Thread Alistair Francis
Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/riscv/sifive_plic.c

Re: [Qemu-devel] [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA instructions

2019-04-04 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé > Subject: Re: [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA > instructions > > Hi Mateja, > > On 4/4/19 3:14 PM, Mateja Marjanovic wrote: > > From: Mateja Marjanovic > > > > Optimize set of MSA instructions ILVEV., using > > directly tcg registers and

[Qemu-devel] [PATCH for 4.0 v3 1/2] riscv: plic: Fix incorrect irq calculation

2019-04-04 Thread Alistair Francis
This patch fixes four different things, to maintain bisectability they have been merged into a single patch. The following fixes are below: sifive_plic: Fix incorrect irq calculation The irq is incorrectly calculated to be off by one. It has worked in the past as the priority_base offset has also

Re: [Qemu-devel] [PULL] RISC-V Patches for 4.0-rc3

2019-04-04 Thread Alistair Francis
On Thu, Apr 4, 2019 at 1:45 AM Peter Maydell wrote: > > On Thu, 4 Apr 2019 at 08:00, Palmer Dabbelt wrote: > > > > The following changes since commit 49fc899f8d673dd9e73f3db0d9e9ea60b77c331b: > > > > Update version for v4.0.0-rc1 release (2019-03-26 17:02:29 +) > > > > are available in the

[Qemu-devel] [GSOC] Support for AVX within TCG

2019-04-04 Thread Jan Bobek
Hi everyone! My name is Jan Bobek, I am a graduate student at Georgia Institute of Technology (Atlanta, GA), currently finishing the first year of M.S. program in Computer Science (Computing Systems). I would like to announce that I will be submitting a QEMU project proposal to this year's

Re: [Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups

2019-04-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190404173921.30841-1-jbi.oct...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups Message-id:

[Qemu-devel] [PATCH v2 1/2] target/mips: realign comments to fix checkpatch warnings

2019-04-04 Thread Jules Irenge
Realign comments to fix warnings issued by checkpatch.pl tool "WARNING: Block comments use a leading /* on a separate line" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 34 ++ 1 file changed, 22 insertions(+), 12

[Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups

2019-04-04 Thread Jules Irenge
This v2 series combines previous two patches into one and removes some left trailing spaces Jules Irenge (2): target/mips: realign comments to fix checkpatch warnings target/mips: add or remove space to fix checkpatch errors target/mips/cpu.h | 60

[Qemu-devel] [PATCH v2 2/2] target/mips: add or remove space to fix checkpatch errors

2019-04-04 Thread Jules Irenge
Add or remove space to fix errors issued by checkpatch.pl tool "ERROR: spaces required around ..." "ERROR: space required after that" "ERROR: space required before the open parenthesis" "ERROR: space prohibited between function name and open parenthesis" within "target/mips/cpu.h" file.

[Qemu-devel] [PULL 1/2] xen-block: only advertize discard to the frontend when it is enabled...

2019-04-04 Thread Anthony PERARD
From: Paul Durrant ...and properly enable it when synthesizing a drive. The Xen toolstack sets 'discard-enable' to '1' in xenstore when it wants to enable discard on a specified image. The code in xen_block_drive_create() correctly parses this and uses it to set 'discard' to 'unmap' for the

[Qemu-devel] [PULL 2/2] xen-block: scale sector based quantities correctly

2019-04-04 Thread Anthony PERARD
From: Paul Durrant The Xen blkif protocol requires that sector based quantities should be interpreted strictly as multiples of 512 bytes. Specifically: "first_sect and last_sect in blkif_request_segment, as well as sector_number in blkif_request, are always expressed in 512-byte units." Commit

[Qemu-devel] [PULL 0/2] xen queue for 4.0-rc3

2019-04-04 Thread Anthony PERARD
/pull-xen-20190404 for you to fetch changes up to 2bcd05cf24a7de34e7e265247c010977e43f40bc: xen-block: scale sector based quantities correctly (2019-04-04 18:00:07 +0100) Xen queue xen-block fixes

Re: [Qemu-devel] [Bug 1823169] Re: qemu displays message "Setup failed, please check external storage is available and has enough room."

2019-04-04 Thread Robert Uomini
Thanks, Thomas. I know that qemu 3.0 is out now, but when I tried to update qemu on my system, I only got the following: ruomini@ruomini-XPS-13-9370:~/Downloads$ sudo apt-get install qemu Reading package lists... Done Building dependency tree Reading state information... Done qemu is already the

Re: [Qemu-devel] Proof of concept for GPU forwarding for Linux guest on Linux host

2019-04-04 Thread Dr. David Alan Gilbert
cc'ing in Gerd and Marc-André * Andrew Randrianasulu (randrianas...@gmail.com) wrote: > В сообщении от Thursday 04 April 2019 10:33:55 Tao Wu(吴涛@Eng) написал(а): > > On Thu, Apr 4, 2019 at 12:15 AM Andrew Randrianasulu < > > randrianas...@gmail.com> wrote: > > > > > Hi! > > > > > > I recall I

Re: [Qemu-devel] [PATCH] hw/input/pckbd: The i8042 device should not be user_creatable

2019-04-04 Thread Philippe Mathieu-Daudé
On 4/4/19 4:19 PM, Thomas Huth wrote: > On 04/04/2019 15.29, Philippe Mathieu-Daudé wrote: >> On 4/4/19 12:07 PM, Paolo Bonzini wrote: >>> On 04/04/19 09:14, Thomas Huth wrote: The i8042 PS/2 controller is part of the chipset on the motherboard. It is instantiated by the machine init

Re: [Qemu-devel] [PATCH] hw/input/pckbd: The i8042 device should not be user_creatable

2019-04-04 Thread Markus Armbruster
Thomas Huth writes: > On 04/04/2019 15.29, Philippe Mathieu-Daudé wrote: >> On 4/4/19 12:07 PM, Paolo Bonzini wrote: >>> On 04/04/19 09:14, Thomas Huth wrote: The i8042 PS/2 controller is part of the chipset on the motherboard. It is instantiated by the machine init code, and it does

Re: [Qemu-devel] [PATCH 2/9] cpu/topology: add general support for machine properties

2019-04-04 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Fri, 29 Mar 2019 16:48:38 +0800 > Like Xu wrote: > > > Signed-off-by: Like Xu > > --- > > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c > > index e2aa57a..ae92f6e 100644 > > --- a/migration/postcopy-ram.c > > +++

Re: [Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse()

2019-04-04 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 03:26:50PM +0200, Markus Armbruster wrote: >>Exploit that argument @name is nerver null. Check is_help_option() >>first, because that's what we do elsewhere. >> >>Signed-off-by: Markus Armbruster >>--- >> vl.c | 24 +++- >> 1 file

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-04 Thread Pankaj Gupta
> > > > > > So I would put the helper in include/linux/dax.h and have it like: > > > > > > bool daxdev_mapping_supported(struct vm_area_struct *vma, > > Should this be static inline if you're putting it in the header file? yes. Thanks. > > A comment ought to be added to describe what this

Re: [Qemu-devel] [PATCH 3/4] vl: Clean up after previous commit

2019-04-04 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 03:26:49PM +0200, Markus Armbruster wrote: >>Since the previous commit, find_machine() and find_default_machine() >>don't have to deallocate on return. This permits further >>simplifications. >> >>Signed-off-by: Markus Armbruster >>--- >> vl.c | 25

Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2019-04-04 Thread KONRAD Frederic
Le 4/4/19 à 5:44 PM, Marc-André Lureau a écrit : Hi On Thu, Apr 4, 2019 at 5:18 PM KONRAD Frederic wrote: Hi guys, We have some random delays with gdbstub since this commit under Windows. Basically while debugging the next command can sometimes take more than 5 seconds while it usually

Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2019-04-04 Thread Marc-André Lureau
Hi On Thu, Apr 4, 2019 at 5:18 PM KONRAD Frederic wrote: > > Hi guys, > > We have some random delays with gdbstub since this commit under Windows. > Basically while debugging the next command can sometimes take more than 5 > seconds while it usually tooks 30ms before. It is not target dependent

Re: [Qemu-devel] [PATCH for-4.0] block: Forward 'discard' to temporary overlay

2019-04-04 Thread Stefano Garzarella
On Thu, Apr 04, 2019 at 05:07:46PM +0200, Kevin Wolf wrote: > When bdrv_temp_snapshot_options() is called for snapshot=on, the > 'discard' option in the options QDict hasn't been parsed and merged into > the flags yet. So copy the dict entry to make sure that the temporary > overlay enables

Re: [Qemu-devel] [PATCH for-4.0] block: Forward 'discard' to temporary overlay

2019-04-04 Thread Eric Blake
On 4/4/19 10:07 AM, Kevin Wolf wrote: > When bdrv_temp_snapshot_options() is called for snapshot=on, the > 'discard' option in the options QDict hasn't been parsed and merged into > the flags yet. So copy the dict entry to make sure that the temporary > overlay enables discard when it was

Re: [Qemu-devel] [Qemu-block] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing

2019-04-04 Thread Kevin Wolf
Am 04.04.2019 um 16:52 hat Eric Blake geschrieben: > Add a missing space to the error message used when giving up on a > server that insists on an alignment which renders the last few bytes > of the export unreadable. > > Fixes: 3add3ab78 > Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1554388475-18329-1-git-send-email-jjhe...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1554388475-18329-1-git-send-email-jjhe...@linux.ibm.com Subject: [Qemu-devel] [PATCH v6

[Qemu-devel] [PATCH] e1000: Never increment the RX undersize count register

2019-04-04 Thread Mark Kanda
From: Chris Kenna In situations where e1000 receives an undersized Ethernet frame, QEMU increments the emulated "Receive Undersize Count (RUC)" register when padding the frame. This is incorrect because this an expected scenario (e.g. with VLAN tag stripping) and not an error. As such, QEMU

[Qemu-devel] [PATCH] target/mips: realign comments to fix checkpatch warnings

2019-04-04 Thread Jules Irenge
Realign comments to fix warnings issued by checkpatch.pl tool "WARNING: Block comments use a leading /* on a separate line" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 34 ++ 1 file changed, 22 insertions(+), 12

Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source

2019-04-04 Thread KONRAD Frederic
Hi guys, We have some random delays with gdbstub since this commit under Windows. Basically while debugging the next command can sometimes take more than 5 seconds while it usually tooks 30ms before. It is not target dependent I see that happening with sparc, ppc, riscv, etc.. but only on

Re: [Qemu-devel] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1554388475-18329-1-git-send-email-jjhe...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1554388475-18329-1-git-send-email-jjhe...@linux.ibm.com Subject: [Qemu-devel] [PATCH v6

[Qemu-devel] [PATCH for-4.0] block: Forward 'discard' to temporary overlay

2019-04-04 Thread Kevin Wolf
When bdrv_temp_snapshot_options() is called for snapshot=on, the 'discard' option in the options QDict hasn't been parsed and merged into the flags yet. So copy the dict entry to make sure that the temporary overlay enables discard when it was requested for the drive. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-04 Thread Darrick J. Wong
On Thu, Apr 04, 2019 at 06:08:44AM -0400, Pankaj Gupta wrote: > > > On Thu 04-04-19 05:09:10, Pankaj Gupta wrote: > > > > > > > > On Thu, Apr 04, 2019 at 09:09:12AM +1100, Dave Chinner wrote: > > > > > > On Wed, Apr 03, 2019 at 04:10:18PM +0530, Pankaj Gupta wrote: > > > > > > > Virtio pmem

[Qemu-devel] [Bug 1823152] Re: QEMU not able to boot ubuntu 18.04 as a guest

2019-04-04 Thread Thomas Huth
** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823152 Title: QEMU not able to boot ubuntu 18.04 as a guest Status in qemu package in Ubuntu: New Bug description:

[Qemu-devel] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing

2019-04-04 Thread Eric Blake
Add a missing space to the error message used when giving up on a server that insists on an alignment which renders the last few bytes of the export unreadable. Fixes: 3add3ab78 Signed-off-by: Eric Blake --- We've already concluded that 5-7 are too risky for 4.0 (so qemu 4.0 NBD servers will

[Qemu-devel] [Bug 1823169] Re: qemu displays message "Setup failed, please check external storage is available and has enough room."

2019-04-04 Thread Thomas Huth
This is the upstream QEMU bug tracker. Upstream QEMU does not support Android apps. Did you maybe wanted to report a bug to the Android emulator fork instead? Then please report the problem in their bug tracker. Otherwise, version 2.5.0 is also very old already and not supported anymore (at

[Qemu-devel] [PATCH v6 15/16] s390-bios: Support booting from real dasd device

2019-04-04 Thread Jason J. Herne
Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- MAINTAINERS | 1 + docs/devel/s390-dasd-ipl.txt | 133 pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c |

[Qemu-devel] [PATCH v6 12/16] s390-bios: Refactor virtio to run channel programs via cio

2019-04-04 Thread Jason J. Herne
Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Acked-by: Thomas Huth --- pc-bios/s390-ccw/virtio.c | 57 ++- 1 file

[Qemu-devel] [Bug 1823152] Re: QEMU not able to boot ubuntu 18.04 as a guest

2019-04-04 Thread flumm
maybe this is just this issue? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1795857 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823152 Title: QEMU not able to boot ubuntu 18.04 as a

[Qemu-devel] [PATCH v6 09/16] s390-bios: cio error handling

2019-04-04 Thread Jason J. Herne
Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: cio device error ssid : 0x cssid :

[Qemu-devel] [PATCH v6 16/16] s390-bios: Use control unit type to find bootable devices

2019-04-04 Thread Jason J. Herne
When the user does not specify which device to boot from then we end up guessing. Instead of simply grabbing the first available device let's be a little bit smarter and only choose devices that might be bootable like disk, and not console devices. Signed-off-by: Jason J. Herne ---

[Qemu-devel] [PATCH v6 13/16] s390-bios: Use control unit type to determine boot method

2019-04-04 Thread Jason J. Herne
The boot method is different depending on which device type we are booting from. Let's examine the control unit type to determine if we're a virtio device. We'll eventually add a case to check for a real dasd device here as well. Since we have to call enable_subchannel() in main now, might as

[Qemu-devel] [PATCH v6 07/16] s390-bios: ptr2u32 and u32toptr

2019-04-04 Thread Jason J. Herne
Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/helper.h | 31

[Qemu-devel] [PATCH v6 11/16] s390-bios: Factor finding boot device out of virtio code path

2019-04-04 Thread Jason J. Herne
Make a new routine find_boot_device to locate the boot device for all cases, not just virtio. The error message for the case where no boot device has been specified and a suitable boot device cannot be auto detected was specific to virtio devices. We update this message to remove virtio specific

[Qemu-devel] [PATCH v6 14/16] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-04-04 Thread Jason J. Herne
The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Acked-by: Thomas Huth --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file changed, 23

[Qemu-devel] [PATCH v6 05/16] s390-bios: Decouple channel i/o logic from virtio

2019-04-04 Thread Jason J. Herne
Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile| 2 +-

[Qemu-devel] [PATCH v6 08/16] s390-bios: Support for running format-0/1 channel programs

2019-04-04 Thread Jason J. Herne
Introduce a library function for executing format-0 and format-1 channel programs and waiting for their completion before continuing execution. Add cu_type() to channel io library. This will be used to query control unit type which is used to determine if we are booting a virtio device or a real

[Qemu-devel] [PATCH v6 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-04-04 Thread Jason J. Herne
Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic in several places. Signed-off-by: Jason J. Herne

[Qemu-devel] [PATCH v6 03/16] s390-bios: decouple common boot logic from virtio

2019-04-04 Thread Jason J. Herne
Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin

[Qemu-devel] [PATCH v6 06/16] s390-bios: Map low core memory

2019-04-04 Thread Jason J. Herne
Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 2 +

[Qemu-devel] [PATCH v6 10/16] s390-bios: Extend find_dev() for non-virtio devices

2019-04-04 Thread Jason J. Herne
We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Cornelia Huck ---

[Qemu-devel] [PATCH v6 04/16] s390-bios: Clean up cio.h

2019-04-04 Thread Jason J. Herne
Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/cio.h | 114

[Qemu-devel] [PATCH v6 02/16] s390-bios: decouple cio setup from virtio

2019-04-04 Thread Jason J. Herne
Move channel i/o setup code out to a separate function. This decouples cio setup from the virtio code path and allows us to make use of it for booting dasd devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-04 Thread Jason J. Herne
This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channel programs dynamically modify themselves.

Re: [Qemu-devel] [PATCH] megasas: fix mapped frame size

2019-04-04 Thread Hannes Reinecke
On 4/4/19 2:10 PM, Peter Lieven wrote: the current value of 1024 bytes (16 * MFI_FRAME_SIZE) we map is not enough to hold the maximum number of scatter gather elements we advertise. We actually need a maximum of 2048 bytes. This is 128 max sg elements * 16 bytes (sizeof (union mfi_sgl)). Cc:

Re: [Qemu-devel] [PATCH 2/9] cpu/topology: add general support for machine properties

2019-04-04 Thread Igor Mammedov
On Fri, 29 Mar 2019 16:48:38 +0800 Like Xu wrote: > Signed-off-by: Like Xu > --- > accel/kvm/kvm-all.c | 3 +++ > backends/hostmem.c | 4 > cpus.c | 4 > exec.c | 2 ++ > gdbstub.c| 7 ++- > hw/cpu/core.c

Re: [Qemu-devel] [PATCH 3/3] acpi/pcihp: Add a few more trace points related to unplug

2019-04-04 Thread Igor Mammedov
On Thu, 4 Apr 2019 14:54:51 +0200 Laszlo Ersek wrote: > Hi Igor, > > On 04/04/19 12:14, Igor Mammedov wrote: > > On Tue, 2 Apr 2019 18:19:00 +0200 > > Markus Armbruster wrote: > > > >> Signed-off-by: Markus Armbruster > > > > Reviewed-by: Markus Armbruster > > did you mean: "R-b:

Re: [Qemu-devel] [PATCH] hw/input/pckbd: The i8042 device should not be user_creatable

2019-04-04 Thread Thomas Huth
On 04/04/2019 15.29, Philippe Mathieu-Daudé wrote: > On 4/4/19 12:07 PM, Paolo Bonzini wrote: >> On 04/04/19 09:14, Thomas Huth wrote: >>> The i8042 PS/2 controller is part of the chipset on the motherboard. >>> It is instantiated by the machine init code, and it does not make sense >>> to allow

[Qemu-devel] [Bug 1823152] Re: QEMU not able to boot ubuntu 18.04 as a guest

2019-04-04 Thread Christian Ehrhardt 
$ ll /usr/bin/qemu-system-x86_64-spice lrwxrwxrwx 1 root root 18 Mär 25 13:32 /usr/bin/qemu-system-x86_64-spice -> qemu-system-x86_64* This is just a compat symlink for a very old history. It should not be used directly anymore, but then also not matter. I have not seen the same with Ubuntu

Re: [Qemu-devel] [PATCH] configure: fix pam test warning

2019-04-04 Thread Philippe Mathieu-Daudé
On 4/4/19 11:17 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The pam test generates a warning on Fedora 29 with -O3 compilation > because the headers declare that the pam_conversation pointer to > pam_start must be non-NULL. Change it to use the same 0

Re: [Qemu-devel] [PATCH v6 1/4] target/mips: Optimize ILVOD. MSA instructions

2019-04-04 Thread Philippe Mathieu-Daudé
On 4/4/19 3:14 PM, Mateja Marjanovic wrote: > From: Mateja Marjanovic > > Optimize set of MSA instructions ILVOD., using > directly tcg registers and performing logic on them instead > of using helpers. > > In the following table, the first column is the performance > before this patch. The

Re: [Qemu-devel] [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA instructions

2019-04-04 Thread Philippe Mathieu-Daudé
Hi Mateja, On 4/4/19 3:14 PM, Mateja Marjanovic wrote: > From: Mateja Marjanovic > > Optimize set of MSA instructions ILVEV., using > directly tcg registers and performing logic on them > instead of using helpers. > > In the following table, the first column is the performance > before this

Re: [Qemu-devel] [PATCH] hw/input/pckbd: The i8042 device should not be user_creatable

2019-04-04 Thread Philippe Mathieu-Daudé
On 4/4/19 12:07 PM, Paolo Bonzini wrote: > On 04/04/19 09:14, Thomas Huth wrote: >> The i8042 PS/2 controller is part of the chipset on the motherboard. >> It is instantiated by the machine init code, and it does not make sense >> to allow the user to plug an additional i8042 in any of the free

Re: [Qemu-devel] [RFC PATCH 0/7] virtio-fs: shared file system for virtual machines3

2019-04-04 Thread Greg Kurz
On Mon, 10 Dec 2018 17:31:44 + "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is the first RFC for the QEMU side of 'virtio-fs'; > a new mechanism for mounting host directories into the guest > in a fast, consistent and secure manner. Our primary

[Qemu-devel] [PATCH v6 0/4] target/mips: Optimize MSA interleave instructions

2019-04-04 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize MSA instructions ILVEV., ILVOD., ILVL. and ILVR. using the hybrid approach, MSA helpers in some cases and directly tcg registers in other cases, so the performance would be better. v6: - Add ILVL. and ILVR. MSA instructions with mixed approaches (with

[Qemu-devel] [PATCH v6 2/4] target/mips: Optimize ILVEV. MSA instructions

2019-04-04 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVEV., using directly tcg registers and performing logic on them instead of using helpers. In the following table, the first column is the performance before this patch. The second represents the performance, after converting from

[Qemu-devel] [PATCH v6 1/4] target/mips: Optimize ILVOD. MSA instructions

2019-04-04 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimize set of MSA instructions ILVOD., using directly tcg registers and performing logic on them instead of using helpers. In the following table, the first column is the performance before this patch. The second represents the performance, after converting from

[Qemu-devel] [PATCH v6 3/4] target/mips: Optimize ILVL. MSA instructions

2019-04-04 Thread Mateja Marjanovic
From: Mateja Marjanovic Optimized ILVL. instructions, using a hybrid approach. For byte data elements, use a helper with an unrolled loop (much better performance), for halfword, word and doubleword data elements use directly tcg registers and logic performed on them. Performance measurement is

  1   2   >