[Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

2019-04-05 Thread Aruna Jayasena
Removed unwanted includes from cpu-common.h This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks Signed-off-by: Aruna Jayasena --- include/exec/cpu-common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index cef8b88a2a.

Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device

2019-04-05 Thread Chen Zhang via Qemu-devel
ping http://patchwork.ozlabs.org/patch/1059842/ > On Mar 27, 2019, at 10:00 AM, Chen Zhang wrote: > > > >> On Mar 27, 2019, at 12:20 AM, Peter Maydell wrote: >> >> On Thu, 21 Mar 2019 at 07:10, Chen Zhang wrote: >>> >>> In fullscreen mode, the window property of cocoaView may not be the k

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Fix absolute input device grabbing issues on Mojave

2019-04-05 Thread Chen Zhang via Qemu-devel
ping http://patchwork.ozlabs.org/patch/1058186/ > On Mar 28, 2019, at 10:05 AM, Chen Zhang wrote: > > > >> On Mar 27, 2019, at 7:37 PM, Peter Maydell wrote: >> >> On Wed, 27 Mar 2019 at 01:09, Chen Zhang wrote: >>> Just double-checked on a MacMini mid 2011 with macOS 10.13.6, Xcode 10.1.

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-04-05 Thread Eduardo Habkost
On Fri, Apr 05, 2019 at 07:22:35PM -0400, Michael S. Tsirkin wrote: > On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: > > * Jens Freimann (jfreim...@redhat.com) wrote: > > > On Fri, Mar 22, 2019 at 02:44:45PM +0100, Jens Freimann wrote: [...] > > > > 3. Management layer soft

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-04-05 Thread Michael S. Tsirkin
On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: > * Jens Freimann (jfreim...@redhat.com) wrote: > > ping > > > > FYI: I'm also working on a few related tools to detect driver behaviour when > > assigning a MAC to the vf device. Code is at > > https://github.com/jensfr/netf

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

2019-04-05 Thread Michael S. Tsirkin
On Fri, Apr 05, 2019 at 03:14:30PM +0200, Philippe Mathieu-Daudé wrote: > On 4/5/19 3:04 PM, Olaf Hering wrote: > > Am Fri, 5 Apr 2019 14:59:16 +0200 > > schrieb Philippe Mathieu-Daudé : > >> On 4/5/19 2:09 PM, Olaf Hering wrote: > >>> Am Fri, 5 Apr 2019 13:55:29 +0200 > >>> schrieb Philippe Mathi

[Qemu-devel] [PULL 0/5] pci, pc, virtio: fixes

2019-04-05 Thread Michael S. Tsirkin
The following changes since commit 436960c95946007aca713330e7a488a6f2e0696f: Merge remote-tracking branch 'remotes/berrange/tags/filemon-next-pull-request' into staging (2019-04-02 14:52:17 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git ta

Re: [Qemu-devel] [Qemu-block] [PATCH] block/io.c: fix for the allocation failure

2019-04-05 Thread John Snow
On 4/5/19 10:24 AM, Andrey Shinkevich wrote: > On a file system used by the customer, fallocate() returns an error > if the block is not properly aligned. So, bdrv_co_pwrite_zeroes() > fails. We can handle that case the same way as it is done for the > unsupported cases, namely, call to bdrv_dri

Re: [Qemu-devel] [Qemu-block] [PATCH] Fixed dump_buffer function parameter offset does not take effect

2019-04-05 Thread John Snow
Hi! Thank you for this patch. Some notes follow: On 4/4/19 7:46 AM, lichun wrote: > Signed-off-by: lichun <706701...@qq.com> You should write a commit message explaining the problem being fixed by this patch, even if it's very brief. In the future, try wording subject lines in terms of what the

[Qemu-devel] [PATCH for-4.1] qemu-nbd: Look up flag names in array

2019-04-05 Thread Max Reitz
The existing code to convert flag bits into strings looks a bit strange now, and if we ever add more flags, it will look even stranger. Prevent that from happening by making it look up the flag names in an array. Signed-off-by: Max Reitz --- Looking at the diff stat I can't claim this patch real

[Qemu-devel] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-04-05 Thread Kenneth Heitke
Signed-off-by: Kenneth Heitke --- hw/block/nvme.c | 120 +- hw/block/nvme.h | 3 ++ hw/block/trace-events | 2 + include/block/nvme.h | 2 + 4 files changed, 125 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-05 Thread Eduardo Habkost
Hi, Thanks for the patch, comments below: On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > The main goal is to add an example device to Qemu to be used as template or > guideline for contributors when they wish to create a new virtio device. > > Another reason for this device is to

Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-05 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert (git), le ven. 05 avril 2019 19:46:48 +0100, a ecrit: > From: "Dr. David Alan Gilbert" > > Gcc 9 needs some convincing that sopreprbuf really is going to fill > in iov in the call from soreadbuf, even though the failure case > shouldn't happen; so swing the check ar

Re: [Qemu-devel] [PATCH] test qgraph.c: Fix segs due to out of scope default

2019-04-05 Thread Paolo Bonzini
On 05/04/19 20:40, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The test uses the trick: >if (!opts) { > opts = &(QOSGraph...Options) { }; >} > > in a couple of places, however the temporary created > by the &() {} goes out of scope at the bottom of th

Re: [Qemu-devel] Following up questions related to QEMU and I/O Thread

2019-04-05 Thread Wei Li
Thanks Stefan for your quick response! Hi Paolo, Could you please send us a link related to the multiqueue feature which you are working on so that we could start getting some details about the feature. Thanks again, Wei On 4/1/19, 3:54 AM, "Stefan Hajnoczi" wrote: On Fri, Mar 29, 2019

Re: [Qemu-devel] [PATCH for-4.0] test qgraph.c: Fix segs due to out of scope default

2019-04-05 Thread Eric Blake
On 4/5/19 1:40 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The test uses the trick: >if (!opts) { > opts = &(QOSGraph...Options) { }; >} > > in a couple of places, however the temporary created > by the &() {} goes out of scope at the bottom of th

Re: [Qemu-devel] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-05 Thread Michael Roth
Quoting Philippe Mathieu-Daudé (2019-04-04 17:31:31) > On 4/1/19 10:58 PM, Michael Roth wrote: > > Hi everyone, > > > > > > The following new patches are queued for QEMU stable v3.0.1: > > > > https:/

Re: [Qemu-devel] [PATCH for-4.1] qemu-nbd: Look up flag names in array

2019-04-05 Thread Eric Blake
On 4/5/19 2:16 PM, Max Reitz wrote: > The existing code to convert flag bits into strings looks a bit strange > now, and if we ever add more flags, it will look even stranger. Prevent > that from happening by making it look up the flag names in an array. At one point, I even considered using a QA

Re: [Qemu-devel] [PATCH 2/7] nbd/server: Trace server noncompliance on unaligned requests

2019-04-05 Thread Eric Blake
On 4/5/19 9:39 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.04.2019 6:05, Eric Blake wrote: >> We've recently added traces for clients to flag server non-compliance; >> let's do the same for servers to flag client non-compliance. According Thus, s/Trace server/Trace client/ in the subject line. >

[Qemu-devel] [PATCH] test qgraph.c: Fix segs due to out of scope default

2019-04-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The test uses the trick: if (!opts) { opts = &(QOSGraph...Options) { }; } in a couple of places, however the temporary created by the &() {} goes out of scope at the bottom of the if, and results in a seg or assert when opts-> fields are used (on fedo

Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190405184648.17029-1-dgilb...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190405184648.17029-1-dgilb...@redhat.com Subject: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix Type: se

[Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Gcc 9 needs some convincing that sopreprbuf really is going to fill in iov in the call from soreadbuf, even though the failure case shouldn't happen; so swing the check around initialising the fields. Signed-off-by: Dr. David Alan Gilbert --- slirp/src/socket.c |

[Qemu-devel] [PATCH v3 1/3] block: include base when checking image chain for block allocation

2019-04-05 Thread Andrey Shinkevich
This patch is used in the 'block/stream: introduce a bottom node' that is following. Instead of the base node, the caller may pass the node that has the base as its backing image to the new function bdrv_is_allocated_above_inclusive() and get rid of the dependency on the base that may change during

[Qemu-devel] [PATCH v3 0/3] block/stream: get rid of the base

2019-04-05 Thread Andrey Shinkevich
This series introduces a bottom intermediate node that eliminates the dependency on the base that may change while stream job is running. It happens when stream/commit parallel jobs are running on the same backing chain. The base node of the stream job may be a top node of the parallel commit job a

[Qemu-devel] [PATCH v3 3/3] block/stream: introduce a bottom node

2019-04-05 Thread Andrey Shinkevich
The bottom node is the intermediate block device that has the base as its backing image. It is used instead of the base node while a block stream job is running to avoid dependency on the base that may change due to the parallel jobs. The change may take place due to a filter node as well that is i

[Qemu-devel] [PATCH v3 2/3] block/stream: refactor stream_run: drop goto

2019-04-05 Thread Andrey Shinkevich
The goto is unnecessary in the stream_run() since the common exit code was removed in the commit eb23654dbe43b549ea2a9ebff9d8e: "jobs: utilize job_exit shim". Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Reviewed-by: Alberto Garcia --- block/stream.c | 13 --

Re: [Qemu-devel] [PATCH 4/8] i386/kvm: implement 'hv-all' pass-through mode

2019-04-05 Thread Vitaly Kuznetsov
Roman Kagan writes: > On Fri, Mar 29, 2019 at 03:18:28PM +0100, Vitaly Kuznetsov wrote: >> In many case we just want to give Windows guests all currently supported >> Hyper-V enlightenments and that's where this new mode may come handy. We >> pass through what was returned by KVM_GET_SUPPORTED_HV

Re: [Qemu-devel] QEMU event loop optimizations

2019-04-05 Thread Sergio Lopez
Paolo Bonzini writes: > On 26/03/19 14:18, Stefan Hajnoczi wrote: >> Hi Sergio, >> Here are the forgotten event loop optimizations I mentioned: >> >> https://github.com/stefanha/qemu/commits/event-loop-optimizations >> >> The goal was to eliminate or reorder syscalls so that useful work (like

Re: [Qemu-devel] How to correctly use more than 2 floppy drives?

2019-04-05 Thread Hervé Poussineau
Le 05/04/2019 à 12:29, Philippe Mathieu-Daudé a écrit : Hi, I am trying to understand the possible values for the MAX_FD variable used by the floppy controller model (hw/block/fdc.c). Looking at git history: - 2004-01-05 7138fcfbf7dd + 8977f3c107ef (Jocelyn Mayer): FDC introduced with "#def

[Qemu-devel] [PATCH for-4.1 1/2] spapr_pci: Get rid of duplicate code for node name creation

2019-04-05 Thread Greg Kurz
According to the changelog of 298a971024534, SpaprPhbState::dtbusname was introduced to "make it easier to relate the guest and qemu views of memory to each other", hence its name. Use it when creating the PHB node to avoid code duplication. Signed-off-by: Greg Kurz --- hw/ppc/spapr_pci.c |

[Qemu-devel] [PATCH for-4.1 2/2] spapr: Drop duplicate code in LSI mapping

2019-04-05 Thread Greg Kurz
LSI mapping in spapr currently open-codes standard PCI swizzling. It thus duplicates the code of pci_swizzle_map_irq_fn(). Expose the swizzling formula so that it can be used with a slot number when building the device tree. Simply drop pci_spapr_map_irq() and call pci_swizzle_map_irq_fn() instead

Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Kevin Wolf
Am 05.04.2019 um 18:11 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > > > drive_new() returns null without setting an error when it provided > > > help. add_init_drive() assumes null means failure, an

Re: [Qemu-devel] QEMU event loop optimizations

2019-04-05 Thread Sergio Lopez
Stefan Hajnoczi writes: > Hi Sergio, > Here are the forgotten event loop optimizations I mentioned: > > https://github.com/stefanha/qemu/commits/event-loop-optimizations > > The goal was to eliminate or reorder syscalls so that useful work (like > executing BHs) occurs as soon as possible after

Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > > drive_new() returns null without setting an error when it provided > > help. add_init_drive() assumes null means failure, and crashes trying > > to report a null error. > > > > Fixes: c4f26c9f37

Re: [Qemu-devel] [PATCH v3 0/4] target/mips: errors and warnings cleanups

2019-04-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190405160938.27494-1-jbi.oct...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190405160938.27494-1-jbi.oct...@gmail.com Subject: [Qemu-devel] [PATCH v3 0/4] target/mips: errors

[Qemu-devel] [PATCH v3 4/4] target/mips: replace tab code indent with spaces to fix checkpatch errors

2019-04-05 Thread Jules Irenge
Replace tab code indent with spaces to fix errors issued by checkpatch.pl tool "ERROR: code indent should never use tabs" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 138 +++--- 1 file changed, 69 insertions(+), 69

[Qemu-devel] [PATCH v3 1/4] target/mips: realign comments to fix checkpatch warnings

2019-04-05 Thread Jules Irenge
Realign comments to fix warnings issued by checkpatch.pl tool "WARNING: Block comments use a leading /* on a separate line" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-

[Qemu-devel] [PATCH v3 2/4] target/mips: add or remove space to fix checkpatch errors

2019-04-05 Thread Jules Irenge
Add or remove space to fix errors issued by checkpatch.pl tool "ERROR: spaces required around ..." "ERROR: space required after that" "ERROR: space required before the open parenthesis" "ERROR: space prohibited between function name and open parenthesis" within "target/mips/cpu.h" file. Signed-off

[Qemu-devel] [PATCH v3 3/4] target/mips: wrap lines to fix checkpatch errors

2019-04-05 Thread Jules Irenge
Wrap lines to fix errors issued by checkpatch.pl tool "ERROR: line over 90 characters" within "target/mips/cpu.h" file. Signed-off-by: Jules Irenge --- target/mips/cpu.h | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/target/mips/cpu.h b/target/mips

[Qemu-devel] [PATCH v3 0/4] target/mips: errors and warnings cleanups

2019-04-05 Thread Jules Irenge
This v3 improves on code alignments Jules Irenge (4): target/mips: realign comments to fix checkpatch warnings target/mips: add or remove space to fix checkpatch errors target/mips: wrap lines to fix checkpatch errors target/mips: replace tab code indent with spaces to fix checkpatch e

[Qemu-devel] [PULL 2/2] migration: Fix migrate_set_parameter

2019-04-05 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela Otherwise we are setting err twice, what is wrong and causes an abort. Signed-off-by: Juan Quintela Message-Id: <20190403114958.3705-2-quint...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 6 -- 1 file changed, 4 in

[Qemu-devel] [PULL 0/2] migration queue

2019-04-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 10546e09e174e0bb185b66a4c397aa845efcd36e: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.0-rc3-v2' into staging (2019-04-05 04:50:30 +0100) are available in the Git repository at: git://github.com/dag

[Qemu-devel] [PULL 1/2] migration/ram.c: Fix codes conflict about bitmap_mutex

2019-04-05 Thread Dr. David Alan Gilbert (git)
From: Zhang Chen I found upstream codes conflict with COLO and lead to crash, and I located to this patch: commit 386a907b37a9321bc5d699bc37104d6ffba1b34d Author: Wei Wang Date: Tue Dec 11 16:24:49 2018 +0800 migration: use bitmap_mutex in migration_bitmap_clear_dirty My colleague Wei's pat

Re: [Qemu-devel] [PATCH 0/2] tests: fw_cfg: add reboot-timeout test case

2019-04-05 Thread Philippe Mathieu-Daudé
On 3/28/19 11:45 AM, 李强 wrote: > Ping... > > What's your opinion, Philippe? Eh sorry my email client tagged this series as reviewed since your previous v1 was reviewed by Laszlo. I'll review your patches, but please increase the version between series next time so I won't miss it that easily ;)

Re: [Qemu-devel] [PATCH] hw/char: Move multi-serial devices into separate file

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/1/19 7:39 AM, Thomas Huth wrote: > In our downstream distribution of QEMU, we'd like to ship the binary > without the multi-serial PCI devices. To make this disablement easier, > let's move the devices into a separate file and add a proper Kconfig- > switch for these devices. > > Signed-off-b

Re: [Qemu-devel] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources

2019-04-05 Thread Vladimir Sementsov-Ogievskiy
03.04.2019 6:05, Eric Blake wrote: > In commit 0c1d50bd, I added a couple of TODO comments about whether we > consult bl.request_alignment when responding to NBD_OPT_INFO. At the > time, qemu as server was hard-coding an advertised alignment of 512 to > clients that promised to obey constraints, an

[Qemu-devel] [PATCH for-4.0 v2 2/2] roms: Allow the EDK2_EFIROM variable to be overridden

2019-04-05 Thread Philippe Mathieu-Daudé
Since commit f590a812c210 we build the EDK2 EfiRom utility unconditionally. This has been tested on all the Linux distribution providing continuous integration (namely Debian and Fedora). Not all distributions are able to build the EfiRom without specific patches (In particular SUSE which enforces

[Qemu-devel] [PATCH for-4.0 v2 0/2] roms: Rename the EFIROM variable and let it be overridable

2019-04-05 Thread Philippe Mathieu-Daudé
Hi, Two trivial fixes to avoid the latest EDK2 testing series to cause trouble to downstream distributions (in particular if they have PIE enforced). Regards, Phil. Philippe Mathieu-Daudé (2): roms: Rename the EFIROM variable to avoid clashing with iPXE roms: Allow the EDK2_EFIROM variable

[Qemu-devel] [PATCH for-4.0 v2 1/2] roms: Rename the EFIROM variable to avoid clashing with iPXE

2019-04-05 Thread Philippe Mathieu-Daudé
The iPXE project already uses the EFIROM for a tool named 'efirom' which is not the Intel EfiRom used by the EDK2 project. To make the difference obvious, rename the variable. This fixes a long standing issue which is now masked since commit f590a812c21 "roms: build the EfiRom utility from the rom

Re: [Qemu-devel] [PATCH] hw/char: Move multi-serial devices into separate file

2019-04-05 Thread Marc-André Lureau
Hi On Mon, Apr 1, 2019 at 7:40 AM Thomas Huth wrote: > > In our downstream distribution of QEMU, we'd like to ship the binary > without the multi-serial PCI devices. To make this disablement easier, > let's move the devices into a separate file and add a proper Kconfig- > switch for these devices

Re: [Qemu-devel] [PATCH 4/8] i386/kvm: implement 'hv-all' pass-through mode

2019-04-05 Thread Roman Kagan
On Fri, Mar 29, 2019 at 03:18:28PM +0100, Vitaly Kuznetsov wrote: > In many case we just want to give Windows guests all currently supported > Hyper-V enlightenments and that's where this new mode may come handy. We > pass through what was returned by KVM_GET_SUPPORTED_HV_CPUID. The only one out o

Re: [Qemu-devel] [PATCH 3/8] i386/kvm: document existing Hyper-V enlightenments

2019-04-05 Thread Vitaly Kuznetsov
Roman Kagan writes: > On Fri, Mar 29, 2019 at 03:18:27PM +0100, Vitaly Kuznetsov wrote: >> Currently, there is no doc describing hv-* CPU flags, people are >> encouraged to get the information from Microsoft Hyper-V Top Level >> Functional specification (TLFS). There is, however, a bit of QEMU >>

Re: [Qemu-devel] [PATCH v2 1/8] migration: Fix migrate_set_parameter

2019-04-05 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Otherwise we are setting err twice, what is wrong and causes an abort. > > Signed-off-by: Juan Quintela Queued just this one. > --- > hmp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 92941

Re: [Qemu-devel] [PATCH] migration/ram.c: Fix codes conflict about bitmap_mutex

2019-04-05 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > From: Zhang Chen > > I found upstream codes conflict with COLO and lead to crash, > and I located to this patch: Queued. > > commit 386a907b37a9321bc5d699bc37104d6ffba1b34d > Author: Wei Wang > Date: Tue Dec 11 16:24:49 2018 +0800 > > migration:

Re: [Qemu-devel] [PATCH 2/7] nbd/server: Trace server noncompliance on unaligned requests

2019-04-05 Thread Vladimir Sementsov-Ogievskiy
03.04.2019 6:05, Eric Blake wrote: > We've recently added traces for clients to flag server non-compliance; > let's do the same for servers to flag client non-compliance. According > to the spec, if the client requests NBD_INFO_BLOCK_SIZE, it is > promising to send all requests aligned to those bou

[Qemu-devel] [PATCH] block/io.c: fix for the allocation failure

2019-04-05 Thread Andrey Shinkevich
On a file system used by the customer, fallocate() returns an error if the block is not properly aligned. So, bdrv_co_pwrite_zeroes() fails. We can handle that case the same way as it is done for the unsupported cases, namely, call to bdrv_driver_pwritev() that writes zeroes to an image for the una

Re: [Qemu-devel] [PATCH 2/2] target/ppc/kvm: Convert DPRINTF to traces

2019-04-05 Thread Greg Kurz
On Fri, 05 Apr 2019 10:12:42 -0300 "Murilo Opsfelder Araújo" wrote: > Hi, Greg. > Hi Murilo, > Greg Kurz writes: > > > Signed-off-by: Greg Kurz > > --- > > target/ppc/kvm.c| 68 > > +++ > > target/ppc/trace-events | 25 ++

[Qemu-devel] [PATCH] Fixed dump_buffer function parameter offset does not take effect

2019-04-05 Thread lichun
Signed-off-by: lichun <706701...@qq.com> --- qemu-io-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 09750a2..8d93dc6 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -357,7 +357,7 @@ static void dump_buffer(const void *buffer, in

Re: [Qemu-devel] [PATCH 1/7] nbd/server: Fix blockstatus trace

2019-04-05 Thread Vladimir Sementsov-Ogievskiy
03.04.2019 6:05, Eric Blake wrote: > Don't increment remaining_bytes until we know that we will actually be > including the current block status extent in the reply; otherwise, the > value traced will include a bytes value that is oversized by the > length of the next block status extent which did

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-05 Thread Jason J. Herne
On 4/5/19 9:26 AM, Thomas Huth wrote: On 05/04/2019 15.11, Jason J. Herne wrote: On 4/5/19 3:52 AM, Thomas Huth wrote: On 05/04/2019 08.58, Thomas Huth wrote: [...] while running my s390-ccw bios tests, I noticed that network booting seems to be broken now. This used to work before: s390x-so

[Qemu-devel] hvf: fix "bad size" panic for 64-bit operands

2019-04-05 Thread Max Khon
Hello, Attached patch fixes "bad size" panic for 64-bit operands when "-accel hvf" is enabled. Max fix-64bit-hvf.patch Description: Binary data

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-05 Thread Cornelia Huck
On Fri, 5 Apr 2019 15:26:24 +0200 Thomas Huth wrote: > On 05/04/2019 15.11, Jason J. Herne wrote: > > Your analysis of the problem matches what I'm seeing as well. Here is > > what I'm proposing to fix it. If you like it, let me know if you want me > > to re-send just the final patch, or the ent

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-05 Thread Thomas Huth
On 05/04/2019 15.11, Jason J. Herne wrote: > On 4/5/19 3:52 AM, Thomas Huth wrote: >> On 05/04/2019 08.58, Thomas Huth wrote: [...] >>> while running my s390-ccw bios tests, I noticed that network booting >>> seems to be broken now. This used to work before: >>> >>> s390x-softmmu/qemu-system-s390x

Re: [Qemu-devel] [PATCH 3/8] i386/kvm: document existing Hyper-V enlightenments

2019-04-05 Thread Roman Kagan
On Fri, Mar 29, 2019 at 03:18:27PM +0100, Vitaly Kuznetsov wrote: > Currently, there is no doc describing hv-* CPU flags, people are > encouraged to get the information from Microsoft Hyper-V Top Level > Functional specification (TLFS). There is, however, a bit of QEMU > specifics. This is appreci

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 3:04 PM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 14:59:16 +0200 > schrieb Philippe Mathieu-Daudé : >> On 4/5/19 2:09 PM, Olaf Hering wrote: >>> Am Fri, 5 Apr 2019 13:55:29 +0200 >>> schrieb Philippe Mathieu-Daudé : >>> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom >>> >>> This

Re: [Qemu-devel] [PATCH 2/2] target/ppc/kvm: Convert DPRINTF to traces

2019-04-05 Thread Murilo Opsfelder Araújo
Hi, Greg. Greg Kurz writes: > Signed-off-by: Greg Kurz > --- > target/ppc/kvm.c| 68 > +++ > target/ppc/trace-events | 25 + > 2 files changed, 52 insertions(+), 41 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-05 Thread Jason J. Herne
On 4/5/19 3:52 AM, Thomas Huth wrote: On 05/04/2019 08.58, Thomas Huth wrote: On 04/04/2019 16.34, Jason J. Herne wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio

Re: [Qemu-devel] [PATCH 1/8] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID

2019-04-05 Thread Roman Kagan
On Fri, Mar 29, 2019 at 03:18:25PM +0100, Vitaly Kuznetsov wrote: > KVM now supports reporting supported Hyper-V features through CPUID > (KVM_GET_SUPPORTED_HV_CPUID ioctl). Going forward, this is going to be > the only way to announce new functionality and this has already happened > with Direct M

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

2019-04-05 Thread Olaf Hering
Am Fri, 5 Apr 2019 14:59:16 +0200 schrieb Philippe Mathieu-Daudé : > On 4/5/19 2:09 PM, Olaf Hering wrote: > > Am Fri, 5 Apr 2019 13:55:29 +0200 > > schrieb Philippe Mathieu-Daudé : > > > >> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom > > > > This name is too generic and will conflict wit

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 2:09 PM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 13:55:29 +0200 > schrieb Philippe Mathieu-Daudé : > >> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom > > This name is too generic and will conflict with ipxe.git if any of "bios > seavgabios pxerom" is used for 'make -C roms'. This is

Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Kevin Wolf
Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > drive_new() returns null without setting an error when it provided > help. add_init_drive() assumes null means failure, and crashes trying > to report a null error. > > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 > Cc: qemu-sta...@no

Re: [Qemu-devel] [PATCH for-4.0 0/2] file-posix: query-qemu-features for auto-read-only

2019-04-05 Thread Kevin Wolf
Am 05.04.2019 um 12:32 hat Stefan Hajnoczi geschrieben: > On Thu, Mar 28, 2019 at 07:28:08PM +0100, Kevin Wolf wrote: > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > release. This change cannot be detected through the usual mechanisms > > like schema introspection. > > >

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

2019-04-05 Thread Olaf Hering
Am Fri, 5 Apr 2019 13:55:29 +0200 schrieb Philippe Mathieu-Daudé : > +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom This name is too generic and will conflict with ipxe.git if any of "bios seavgabios pxerom" is used for 'make -C roms'. Olaf pgpFSdFcL3tvf.pgp Description: Digitale Signatur von

[Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

2019-04-05 Thread Philippe Mathieu-Daudé
Since commit f590a812c210 we build the EfiRom utility unconditionally. This has been tested on all the Linux distribution providing continuous integration (namely Debian and Fedora). Not all distributions are able to build the EfiRom without specific patches (In particular SUSE which enforces the P

[Qemu-devel] [PINGl] [PATCH 0/3] migration: add sztd compression

2019-04-05 Thread Denis Plotnikov
ping! On 26.03.2019 18:51, Denis Plotnikov wrote: > ping ping ping ping ping! > > On 18.03.2019 10:53, Denis Plotnikov wrote: >> ping ping ping ping! >> >> On 11.03.2019 11:20, Denis Plotnikov wrote: >>> ping ping ping! >>> >>> On 04.03.2019 18:10, Denis Plotnikov wrote: ping! On 2

[Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Markus Armbruster
drive_new() returns null without setting an error when it provided help. add_init_drive() assumes null means failure, and crashes trying to report a null error. Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- device-hotplug.c | 2 +

[Qemu-devel] [PING] [PATCH 0/3] migration: add sztd compression

2019-04-05 Thread Denis Plotnikov
ping! On 26.03.2019 18:51, Denis Plotnikov wrote: > ping ping ping ping ping! > > On 18.03.2019 10:53, Denis Plotnikov wrote: >> ping ping ping ping! >> >> On 11.03.2019 11:20, Denis Plotnikov wrote: >>> ping ping ping! >>> >>> On 04.03.2019 18:10, Denis Plotnikov wrote: ping! On 2

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 1:16 PM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 12:59:18 +0200 > schrieb Olaf Hering : > >> This used to work still in January with >> c9d18c1c150c84e7a976df989ad04ddf01083f46. > > It is not possible to just override EFIROM=$(type -P EfiRom) because this > variable is also used by ip

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 1:14 PM, Philippe Mathieu-Daudé wrote: > On 4/5/19 12:59 PM, Olaf Hering wrote: >> Am Fri, 5 Apr 2019 12:49:15 +0200 >> schrieb Philippe Mathieu-Daudé : >> >>> The EDK2 submodule was added for UEFI testing, you don't need to compile >>> it to build/use QEMU. >>> >>> How did you end up com

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Olaf Hering
Am Fri, 5 Apr 2019 13:14:35 +0200 schrieb Philippe Mathieu-Daudé : > On 4/5/19 12:59 PM, Olaf Hering wrote: > > Am Fri, 5 Apr 2019 12:49:15 +0200 > > schrieb Philippe Mathieu-Daudé : > > > >> The EDK2 submodule was added for UEFI testing, you don't need to compile > >> it to build/use QEMU. > >

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Olaf Hering
Am Fri, 5 Apr 2019 13:29:44 +0200 schrieb Philippe Mathieu-Daudé : > I'll submit that patch. Can this actually work? It does not remove the naming conflict. Olaf pgpL9MyUiEtmy.pgp Description: Digitale Signatur von OpenPGP

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Olaf Hering
Am Fri, 5 Apr 2019 12:59:18 +0200 schrieb Olaf Hering : > This used to work still in January with > c9d18c1c150c84e7a976df989ad04ddf01083f46. It is not possible to just override EFIROM=$(type -P EfiRom) because this variable is also used by ipxe.git. Olaf pgp6kq871XR2n.pgp Description: Digit

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 12:59 PM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 12:49:15 +0200 > schrieb Philippe Mathieu-Daudé : > >> The EDK2 submodule was added for UEFI testing, you don't need to compile >> it to build/use QEMU. >> >> How did you end up compiling it? > > The qemu.spec file has this since a very

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Olaf Hering
Am Fri, 5 Apr 2019 12:49:15 +0200 schrieb Philippe Mathieu-Daudé : > The EDK2 submodule was added for UEFI testing, you don't need to compile > it to build/use QEMU. > > How did you end up compiling it? The qemu.spec file has this since a very long time: make -C roms efirom ${unrelated_settings}

Re: [Qemu-devel] [PATCH] hw/input/pckbd: The i8042 device should not be user_creatable

2019-04-05 Thread Thomas Huth
On 04/04/2019 18.30, Markus Armbruster wrote: > Thomas Huth writes: > >> On 04/04/2019 15.29, Philippe Mathieu-Daudé wrote: >>> On 4/4/19 12:07 PM, Paolo Bonzini wrote: On 04/04/19 09:14, Thomas Huth wrote: > The i8042 PS/2 controller is part of the chipset on the motherboard. > It i

Re: [Qemu-devel] How to correctly use more than 2 floppy drives?

2019-04-05 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Hi, > > I am trying to understand the possible values for the MAX_FD variable > used by the floppy controller model (hw/block/fdc.c). > > Looking at git history: > > - 2004-01-05 7138fcfbf7dd + 8977f3c107ef (Jocelyn Mayer): > FDC introduced

Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Philippe Mathieu-Daudé
Hi Olaf, On 4/5/19 12:39 PM, Olaf Hering wrote: > It seems in qemu.git#master the edk2.git submodule is now mandatory. The EDK2 submodule was added for UEFI testing, you don't need to compile it to build/use QEMU. How did you end up compiling it? > For me it fails to compile. This is not a new

[Qemu-devel] edk2 fails to compile in v4.0.0-rc2

2019-04-05 Thread Olaf Hering
It seems in qemu.git#master the edk2.git submodule is now mandatory. For me it fails to compile. This is not a new error. It needs to be compiled with -fPIC since essentially forever. But I wonder, why does it fail to compile only for me?! Example of failure: $ grep -h CommonLib.o /dev/shm/*/.b

Re: [Qemu-devel] [PATCH for-4.0 0/2] file-posix: query-qemu-features for auto-read-only

2019-04-05 Thread Stefan Hajnoczi
On Thu, Mar 28, 2019 at 07:28:08PM +0100, Kevin Wolf wrote: > auto-read-only=on changed its behaviour in file-posix for the 4.0 > release. This change cannot be detected through the usual mechanisms > like schema introspection. > > I took Stefan's patch 'qmp: add query-qemu-capabilities', removed

Re: [Qemu-devel] [PATCH] e1000: Never increment the RX undersize count register

2019-04-05 Thread Stefano Garzarella
On Thu, Apr 04, 2019 at 10:21:26AM -0500, Mark Kanda wrote: > From: Chris Kenna > > In situations where e1000 receives an undersized Ethernet frame, > QEMU increments the emulated "Receive Undersize Count (RUC)" > register when padding the frame. > > This is incorrect because this an expected sc

[Qemu-devel] How to correctly use more than 2 floppy drives?

2019-04-05 Thread Philippe Mathieu-Daudé
Hi, I am trying to understand the possible values for the MAX_FD variable used by the floppy controller model (hw/block/fdc.c). Looking at git history: - 2004-01-05 7138fcfbf7dd + 8977f3c107ef (Jocelyn Mayer): FDC introduced with "#define MAX_FD 2" - 2008-04-29 78ae820cfeb0 (Hervé Poussineau)

Re: [Qemu-devel] [PATCH for-4.1 4/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 6:51 AM, Thomas Huth wrote: > On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: >> ISA Super I/O are already modeled by the ISASuperIODevice abstract >> device. >> Since this board uses a generic ISA Super I/O chipset, refactor it >> as the TYPE_R4K_SUPERIO device, child of ISASuperIODev

Re: [Qemu-devel] [PATCH for-4.1 1/4] hw/isa/superio: Rename a variable

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 6:14 AM, Thomas Huth wrote: > On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: >> This patch is purely cosmetic. No functional change. >> This will ease the next patch where we re-indent an if() statement. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/isa/isa-superio.c | 69

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-04-05 Thread Jens Freimann
On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: [...] > To summarize concerns/feedback from previous discussion: > 1.- guest OS can reject or worse _delay_ unplug by any amount of time. > Migration might get stuck for unpred

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 11:02 AM, Daniel P. Berrangé wrote: > On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote: >> Hi Helge, >> >> On 4/5/19 9:56 AM, Helge Deller wrote: >>> On 05.04.19 03:34, Peter Maydell wrote: On Fri, 5 Apr 2019 at 01:59, Helge Deller wrote: > If a non-release

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Daniel P . Berrangé
On Fri, Apr 05, 2019 at 11:02:52AM +0200, Helge Deller wrote: > On 05.04.19 10:26, Daniel P. Berrangé wrote: > > On Fri, Apr 05, 2019 at 09:56:46AM +0200, Helge Deller wrote: > >> Hi Peter, > >> > >> On 05.04.19 03:34, Peter Maydell wrote: > >>> On Fri, 5 Apr 2019 at 01:59, Helge Deller wrote: > >

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Peter Maydell
On Fri, 5 Apr 2019 at 16:02, Helge Deller wrote: > Sadly such special treatment by projects makes life for me > as an architecture maintainer much harder :-( It's kind of inevitable for programs that aren't straightforwardly architecture agnostic. gcc doesn't work for architectures which don't ha

Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/4/19 8:39 PM, Helge Deller wrote: > All major distributions do support libseccomp version >= 2.3.0, so there > is no need to special-case on various architectures any longer. > > Signed-off-by: Helge Deller > > diff --git a/configure b/configure > index 1c563a7027..8fe4fc84d8 100755 > --- a

Re: [Qemu-devel] [PATCH 1/2] target/ppc/trace-events: Fix trivial typo

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 10:05 AM, Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > target/ppc/trace-events |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/trace-events b/target/ppc/trace-events > index 3858f97dff54..ed4d57c6d9c1 100644 > --- a/target/ppc/trace-eve

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Philippe Mathieu-Daudé
Cc'ing qemu-block. On 4/5/19 11:02 AM, Helge Deller wrote: [...] > As another example, even if I only want to build "qemu-img", I still need > to manually give the --enable-tcg-interpreter configure option. You found a bug :)

  1   2   >