Re: [Qemu-devel] How to correctly use more than 2 floppy drives?

2019-04-07 Thread Markus Armbruster
Hervé Poussineau writes: > Le 05/04/2019 à 12:29, Philippe Mathieu-Daudé a écrit : >> Hi, >> >> I am trying to understand the possible values for the MAX_FD variable >> used by the floppy controller model (hw/block/fdc.c). >> >> Looking at git history: >> >> - 2004-01-05 7138fcfbf7dd +

[Qemu-devel] [Bug 1807073] Re: qemu-guest-agent stop work when fsfreeze

2019-04-07 Thread Hongquan Zhu
But it happens in some times, this problem dose not occur 100 percent。I can not reproduce when I want to find WHY。So it‘s dangerous in my production environment。 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-04-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Apr 05, 2019 at 07:22:35PM -0400, Michael S. Tsirkin wrote: >> On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: >> > * Jens Freimann (jfreim...@redhat.com) wrote: >> > > On Fri, Mar 22, 2019 at 02:44:45PM +0100, Jens Freimann wrote: >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-04-07 Thread David Gibson
On Fri, Mar 29, 2019 at 01:29:51PM +0100, Greg Kurz wrote: > On Thu, 28 Mar 2019 15:39:45 -0300 > "Maxiwell S. Garcia" wrote: > > > Hi, > > > > On Thu, Mar 28, 2019 at 02:21:51PM +0100, Greg Kurz wrote: > > > On Wed, 27 Mar 2019 17:41:00 -0300 > > > "Maxiwell S. Garcia" wrote: > > > > > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-04-07 Thread David Gibson
On Tue, Apr 02, 2019 at 12:28:07PM +0200, Greg Kurz wrote: > On Mon, 1 Apr 2019 12:01:48 -0300 > "Maxiwell S. Garcia" wrote: > > > Hi Greg, > > > > Thanks for your review. I added some comments below... > > > > On Fri, Mar 29, 2019 at 01:29:51PM +0100, Greg Kurz wrote: > > > On Thu, 28 Mar

Re: [Qemu-devel] [PATCH for-4.1 2/2] spapr: Drop duplicate code in LSI mapping

2019-04-07 Thread David Gibson
On Fri, Apr 05, 2019 at 06:30:48PM +0200, Greg Kurz wrote: > LSI mapping in spapr currently open-codes standard PCI swizzling. It thus > duplicates the code of pci_swizzle_map_irq_fn(). > > Expose the swizzling formula so that it can be used with a slot number > when building the device tree.

Re: [Qemu-devel] [PATCH] powerpc: fix denorm float->double conversion

2019-04-07 Thread David Gibson
On Sat, Mar 23, 2019 at 10:24:11PM +, Sergei Trofimovich wrote: > The bug is initially discovered in GHC test suite. Here is minimal reproducer: > > ```c > > int main() { > volatile float f; > volatile double d; > > *(volatile uint32_t*) = 0xc0de; > d = f; > printf("f =

Re: [Qemu-devel] [PATCH for-4.1 1/2] spapr_pci: Get rid of duplicate code for node name creation

2019-04-07 Thread David Gibson
On Fri, Apr 05, 2019 at 06:30:43PM +0200, Greg Kurz wrote: > According to the changelog of 298a971024534, SpaprPhbState::dtbusname was > introduced to "make it easier to relate the guest and qemu views of memory > to each other", hence its name. > > Use it when creating the PHB node to avoid code

Re: [Qemu-devel] [PATCH 1/2] target/ppc/trace-events: Fix trivial typo

2019-04-07 Thread David Gibson
On Fri, Apr 05, 2019 at 10:05:19AM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied to ppc-for-4.1, thanks. > --- > target/ppc/trace-events |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/trace-events b/target/ppc/trace-events > index

Re: [Qemu-devel] [PATCH 2/2] target/ppc/kvm: Convert DPRINTF to traces

2019-04-07 Thread David Gibson
On Fri, Apr 05, 2019 at 10:05:24AM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied to ppc-for-4.1, thanks. I did have to fix up a small conflict because I've now merged my style fixups for target/ppc into ppc-for-4.1. > --- > target/ppc/kvm.c| 68 >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.0 0/2] spapr: Fix extended config space accesses

2019-04-07 Thread David Gibson
On Tue, Apr 02, 2019 at 09:52:14AM +1100, David Gibson wrote: > On Mon, Apr 01, 2019 at 07:54:57PM +0200, Greg Kurz wrote: > > Recent commit c2077e2ca0da7 added stricter checks that now prevent > > a guest to access the extended config space of a PCIe device connected > > attached to a PHB on a

Re: [Qemu-devel] [PATCH v3] migration: do not rom_reset() during incoming migration

2019-04-07 Thread Peter Xu
On Sun, Apr 07, 2019 at 09:56:56PM -0400, Catherine Ho wrote: > Commit 18269069c310 ("migration: Introduce ignore-shared capability") > addes ignore-shared capability to bypass the shared ramblock (e,g, > membackend + numa node). It does good to live migration. > > As told by Yury,this commit

Re: [Qemu-devel] [PATCH] hostmem-file: warn when memory-backend-file, share=on and in incoming migration

2019-04-07 Thread Peter Xu
On Sun, Apr 07, 2019 at 10:19:05PM -0400, Catherine Ho wrote: > Currently it is not forbidden to use "-object memory-backend-file,share=on" > and together with "-incoming". But after incoming migration is finished, > the memory-backend-file will be definitely written if share=on. So the >

Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix absolute and relative input issues on Mojave

2019-04-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/b786f00d-5518-405b-b0ac-c5bf2d728...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: b786f00d-5518-405b-b0ac-c5bf2d728...@me.com Subject: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix absolute

[Qemu-devel] [PATCH] hostmem-file: warn when memory-backend-file, share=on and in incoming migration

2019-04-07 Thread Catherine Ho
Currently it is not forbidden to use "-object memory-backend-file,share=on" and together with "-incoming". But after incoming migration is finished, the memory-backend-file will be definitely written if share=on. So the memory-backend-file can only be used once, but failed in the 2nd time

[Qemu-devel] [PATCH 1/2] ui/cocoa: Fix absolute input device grabbing issue on

2019-04-07 Thread Chen Zhang via Qemu-devel
This patches fixed boundary check methods for cursor in normal and fullscreen modes with/without Zoom-to-Fit on Mojave. On Mojave, absolute input device, i.e. tablet, had trouble re-grabbing the cursor in re-entry into the virtual screen area. In some cases, the `window` property of NSEvent

[Qemu-devel] [PATCH 2/2] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device

2019-04-07 Thread Chen Zhang via Qemu-devel
In fullscreen mode, the window property of cocoaView may not be the key window, and the current implementation would not grab mouse in fullscreen mode after user ungrabs cursor in fullscreen mode with hot-key, and left clicks the relative input devices to re-grab it. This patch used value of

[Qemu-devel] [PATCH 0/2] ui/cocoa: Fix absolute and relative input issues on Mojave

2019-04-07 Thread Chen Zhang via Qemu-devel
The following patches fixed absolute and relative input device issues on macOS Mojave. Chen Zhang (2): ui/cocoa: Fix absolute input device grabbing issue on Mojave ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device ui/cocoa.m | 50

[Qemu-devel] [PATCH v3] migration: do not rom_reset() during incoming migration

2019-04-07 Thread Catherine Ho
Commit 18269069c310 ("migration: Introduce ignore-shared capability") addes ignore-shared capability to bypass the shared ramblock (e,g, membackend + numa node). It does good to live migration. As told by Yury,this commit expectes that QEMU doesn't write to guest RAM until VM starts, but it does

Re: [Qemu-devel] [RFC] arm/virt: add one more uart for UEFI runtime debug

2019-04-07 Thread Heyi Guo
On 2019/4/7 21:16, Peter Maydell wrote: On Sun, 7 Apr 2019 at 09:19, Heyi Guo wrote: This patch is based on the discussion in TianoCore edk2-devel mailing list: https://lists.01.org/pipermail/edk2-devel/2019-March/037986.html The conclusion is that we need an individual UART for UEFI

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-07 Thread Tian, Kevin
> From: Elijah Shakkour [mailto:elija...@mellanox.com] > Sent: Sunday, April 7, 2019 9:47 PM > > > > -Original Message- > > From: Tian, Kevin > > Sent: Thursday, April 4, 2019 10:58 AM > > To: Peter Xu ; Elijah Shakkour > > > > Cc: Knut Omang ; Michael S. Tsirkin > > ; Alex Williamson

[Qemu-devel] [PATCH 1/5] Device Models

2019-04-07 Thread sohailalvi2236
From: Sohail Alvi Signed-off-by: SohailAlvi --- hw/block/xen-block.c | 4 +++- hw/dma/i82374.c| 3 ++- hw/i386/amd_iommu.c| 9 + hw/i386/intel_iommu.c | 1 + hw/i386/pc_piix.c | 1 + hw/i386/xen/xen_pvdevice.c | 1 + hw/ipmi/ipmi_bmc_extern.c |

Re: [Qemu-devel] [PATCH] set_bit() function added to the source code of uncategorized devices and categorizes have been assigne to them.

2019-04-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190407185042.7624-1-sohailalvi2...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] set_bit() function added to the source code of uncategorized devices and

[Qemu-devel] [PATCH] set_bit() function added to the source code of uncategorized devices and categorizes have been assigne to them.

2019-04-07 Thread sohailalvi2236
From: Sohail Alvi a seperate class_init function has also been added for AMDVI-PCI. Signed-off-by:SohailAlvi --- hw/block/xen-block.c | 4 +++- hw/dma/i82374.c| 3 ++- hw/i386/amd_iommu.c| 9 + hw/i386/intel_iommu.c | 1 + hw/i386/pc_piix.c | 1

Re: [Qemu-devel] [PULL 0/2] migration queue

2019-04-07 Thread Peter Maydell
On Fri, 5 Apr 2019 at 16:51, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 10546e09e174e0bb185b66a4c397aa845efcd36e: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-4.0-rc3-v2' into staging (2019-04-05 >

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-07 Thread Elijah Shakkour
> -Original Message- > From: Tian, Kevin > Sent: Thursday, April 4, 2019 10:58 AM > To: Peter Xu ; Elijah Shakkour > > Cc: Knut Omang ; Michael S. Tsirkin > ; Alex Williamson ; > Marcel Apfelbaum ; Stefan Hajnoczi > ; qemu-devel@nongnu.org > Subject: RE: QEMU and vIOMMU support for

Re: [Qemu-devel] [RFC] arm/virt: add one more uart for UEFI runtime debug

2019-04-07 Thread Peter Maydell
On Sun, 7 Apr 2019 at 09:19, Heyi Guo wrote: > > This patch is based on the discussion in TianoCore edk2-devel mailing > list: > https://lists.01.org/pipermail/edk2-devel/2019-March/037986.html > > The conclusion is that we need an individual UART for UEFI runtime > services to print debug

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Fix absolute input device grabbing issues on Mojave

2019-04-07 Thread Peter Maydell
On Sat, 6 Apr 2019 at 04:04, Chen Zhang wrote: > > ping > > http://patchwork.ozlabs.org/patch/1058186/ This needs changes to be able to compile with OSX 10.10. thanks -- PMM

Re: [Qemu-devel] [PATCH RESEND v2 0/2] Move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-07 Thread Sukrit Bhatnagar
Hi, Are the patches in good enough shape to be merged? Thanks, Sukrit

[Qemu-devel] [PATCH RESEND v2 0/2] Move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-07 Thread Sukrit Bhatnagar
Changes made in v2: - added a patch to declare hvf_handle_io only if NEED_CPU_H is defined so that the poisoned type CPUArchState does not produce an error when include/sysemu/hvf.h is included for common object compilation Link to v1:

[Qemu-devel] [PATCH RESEND v2 1/2] hvf: declare hvf_handle_io if NEED_CPU_H is defined

2019-04-07 Thread Sukrit Bhatnagar
hvf_handle_io needs the poisoned type CPUArchState as its argument. Declaring it if NEED_CPU_H is defined enables include/sysemu/hvf.h to be included for common object compilation as well. Cc: Roman Bolshakov Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- include/sysemu/hvf.h | 4

[Qemu-devel] [PATCH RESEND v2 2/2] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-07 Thread Sukrit Bhatnagar
Keep the calls made to synchronize cpu by all hypervisors in one place inside cpu_synchronize_* functions in include/sysemu/hw_accel.h Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- cpus.c| 12 include/sysemu/hw_accel.h | 10

[Qemu-devel] [PATCH for-4.0] hw/i386/pc: Fix crash when hot-plugging nvdimm on older machine types

2019-04-07 Thread Thomas Huth
QEMU currently crashes when you try to hot-plug an "nvdimm" device on older machine types: $ qemu-system-x86_64 -monitor stdio -M pc-1.1 QEMU 3.1.92 monitor - type 'help' for more information (qemu) device_add nvdimm,id=nvdimmn1 qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57:

Re: [Qemu-devel] [PATCH v3 0/4] pvrdma: Add support for SRQ

2019-04-07 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 09:19:38PM +0300, Yuval Shaia wrote: > On Wed, Apr 03, 2019 at 02:33:39PM +0300, Kamal Heib wrote: > > This series implements the SRQ (Shared Receive Queue) for the pvrdma > > device, It also includes all the needed functions and definitions for > > support SRQ in the

Re: [Qemu-devel] [PATCH v3 1/4] hw/rdma: Add SRQ support to backend layer

2019-04-07 Thread Yuval Shaia
On Sun, Apr 07, 2019 at 11:13:15AM +0300, Kamal Heib wrote: > > > On 4/3/19 9:05 PM, Yuval Shaia wrote: > > On Wed, Apr 03, 2019 at 02:33:40PM +0300, Kamal Heib wrote: > >> Add the required functions and definitions to support shared receive > >> queues (SRQs) in the backend layer. > >> > >>

[Qemu-devel] [Bug 1807073] Re: qemu-guest-agent stop work when fsfreeze

2019-04-07 Thread sles
btw,I run OEL7 VM on the same host and Ubuntu 18.04 VM, both have newer qemu-guest-agent: 18.04: qemu-guest-age 1:2.11+dfsg- OEL7: rpm -qi qemu-guest-agent Name: qemu-guest-agent Epoch : 10 Version : 2.12.0 Release : 2.el7 Never had this problem on both oh these. -- You

[Qemu-devel] [Bug 1807073] Re: qemu-guest-agent stop work when fsfreeze

2019-04-07 Thread sles
Just got almost the same Ubuntu 16.04 as guest on Centos 7 host, all will latest updates. Execute of virsh qemu-agent-command inetgw2 '{"execute":"guest-fsfreeze-freeze"}' failed with agent not available ( or something like this), but fsfreeze executed in OS Apr 7 02:28:54 inetgw2 qemu-ga:

[Qemu-devel] [RFC] arm/virt: add one more uart for UEFI runtime debug

2019-04-07 Thread Heyi Guo
This patch is based on the discussion in TianoCore edk2-devel mailing list: https://lists.01.org/pipermail/edk2-devel/2019-March/037986.html The conclusion is that we need an individual UART for UEFI runtime services to print debug message at runtime, to avoid conflicting with the system UART. We

Re: [Qemu-devel] [PATCH v3 1/4] hw/rdma: Add SRQ support to backend layer

2019-04-07 Thread Kamal Heib
On 4/3/19 9:05 PM, Yuval Shaia wrote: > On Wed, Apr 03, 2019 at 02:33:40PM +0300, Kamal Heib wrote: >> Add the required functions and definitions to support shared receive >> queues (SRQs) in the backend layer. >> >> Signed-off-by: Kamal Heib >> --- >> hw/rdma/rdma_backend.c | 116