Add Kconfig dependencies for the Strongarm collie machine.
This patch is based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 3 +--
hw/arm/Kconfig | 7 +++
hw/arm/Makefile.o
Dependencies have been determined with trial-and-error and by
looking at the musca.c source file.
Signed-off-by: Thomas Huth
---
hw/arm/Kconfig | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 22be1e1231..eca8387050 100644
--- a/h
Dependencies have been determined with trial-and-error and by
looking at the xlnx-versal.c source file.
Signed-off-by: Thomas Huth
---
hw/arm/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 32e4cc50e5..22be1e1231 100644
--- a/hw/arm/Kconfig
+
Most of the code is directly controlled by the CONFIG_RASPI switch,
so not much to add here additionally.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 4 +---
hw/arm/Kconfig | 3 +++
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/default-confi
Add Kconfig dependencies for the Sabrelite / iMX6 machine.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 4 +---
hw/arm/Kconfig | 7 +++
hw/arm/Makefile.objs| 3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/default-config
Add dependencies for the Cubitech Cubieboard.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 6 +-
hw/arm/Kconfig | 9 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.ma
Add Kconfig dependencies for the NRF51 / microbit machine.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 3 +--
hw/arm/Kconfig | 6 ++
hw/arm/Makefile.objs| 3 ++-
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/default-configs/a
Dependencies have been determined by looking at hw/arm/virt.c
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 11 +--
hw/arm/Kconfig | 19 +++
hw/arm/Makefile.objs| 3 ++-
3 files changed, 22 insertions(+), 11 deletions(-)
d
Thomas Huth writes:
> On 18/04/2019 16.53, Markus Armbruster wrote:
>> atoui() and get_index() pass char values to isdigit(). With a
>> standard isdigit(), we'd get undefined behavior when the value is
>> negative. But we're using isdigit() from pc-bios/s390-ccw/libc.h
>> here, which behaves ni
IMX25, IMX7 and IMX6UL were still missing the Kconfig dependencies.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 2 --
hw/arm/Kconfig | 19 +++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/default-configs/arm-softmmu.mak b/
Add Kconfig dependencies for the xilinx-zynq-a9 board.
This patch is based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 7 +--
hw/arm/Kconfig | 12
2 files ch
Add Kconfig dependencies for the fsl-imx31 / kzm machine.
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 3 +--
hw/arm/Kconfig | 4
hw/misc/Kcon
This cleans up most settings in default-configs/aarch64-softmmu.mak.
Signed-off-by: Thomas Huth
---
default-configs/aarch64-softmmu.mak | 4
hw/arm/Kconfig | 11 +++
hw/display/Kconfig | 1 +
3 files changed, 12 insertions(+), 4 deletions(-)
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 24 -
hw/arm/Kconfig | 48 +
hw/arm/Makefile.objs
Add Kconfig dependencies for the mps2-an* machines.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 20 +---
hw/arm/Kconfig | 18 ++
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/default-configs/arm-softmmu.mak
Add Kconfig dependencies for the highbank machine (and the midway
machine).
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 9 +
hw/arm/Kconfig
Add Kconfig dependencies for the emcraft-sf2 machine - we also
distinguish between the machine (CONFIG_EMCRAFT_SF2) and the SoC
(CONFIG_MSF2) now.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 3 +--
hw/arm/Kconfig | 8
hw/arm/Makefile.objs
Netduino only depends on the stm32f205 SoC which in turn depends on
its components.
Reviewed-by: Alistair Francis
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 9 +
hw/arm/Kconfig | 7 +++
2 files changed, 8 insertions(+), 8 deletions(-)
diff --g
Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI
sysbus device, but do not use CONFIG_PCI since they do not feature a PCI
bus. With CONFIG_AHCI but without CONFIG_PCI, currently linking fails:
../hw/ide/ich.o: In function `pci_ich9_ahci_realize':
hw/ide/ich.c:124:
Add Kconfig dependencies for the OMAP machines (cheetah, n800, n810,
sx1 and sx1-v1).
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 17 -
hw/arm/Kcon
Add Kconfig dependencies for the DIGIC / canon-a1100 machine.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 2 +-
hw/arm/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/default-configs/arm-softm
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 6 +-
hw/arm/Kconfig | 5 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/def
Add Kconfig dependencies for the Exynos-related boards (nuri and
smdkc210).
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 17 ++---
hw/arm/Kconfig
Dependencies have been determined by looking at hw/arm/aspeed.c
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 7 +--
hw/arm/Kconfig | 10 ++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/default-configs/arm-softmmu.mak b/default-
Add Kconfig dependencies for the PXA2xx machines (akita, borzoi,
connex and verdex gumstix, tosa, mainstone, spitz, terrier and z2).
This patch is based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.m
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 7 +--
hw/arm/Kconfig | 10 ++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --
Some machines (like the pxa2xx-based ARM machines) only have a sysbus
OHCI controller, but no PCI. With the new Kconfig-style build system,
it will soon be possible to create QEMU binaries that only contain
such PCI-less machines. However, the two OHCI controllers, for sysbus
and for PCI, are curre
This series reworks the default-configs/arm-softmmu.mak and
default-configs/aarch64-softmmu.mak files to use the new Kconfig-style
dependencies instead.
Some of the patches are slightly based on the work by Ákos Kovács:
https://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg03730.html
The
This patch is slightly based on earlier work by Ákos Kovács (i.e.
his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak | 8 +---
hw/arm/Kconfig | 8
hw/display/Kconfig | 1 +
3 files changed, 10 in
Some machines have an AHCI adapter, but no PCI. To be able to
compile hw/ide/ahci.c without CONFIG_PCI, we still need the two
functions msi_enabled() and msi_notify() for linking.
This is required for the new Kconfig-like build system, if a user
wants to compile a QEMU binary with just one machine
Hah! Thanks, I don't know how I missed the existence of bootindex (given
that it looks like it went in in 2011 and is in the docs once I know the
name to search for.) I was probably conflating it with the index=
option.
I did see the warning, and my reaction was "that must apply to other
uses than
18.04.2019, 20:01, "Dr. David Alan Gilbert" :
> * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> 18.04.2019, 19:03, "Dr. David Alan Gilbert" :
>> > * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> >> 18.04.2019, 17:20, "Dr. David Alan Gilbert" :
>> >> > * Yury Kotov (yury-ko...@yandex-tea
Daniel P. Berrangé writes:
> On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote:
>> Hi all,
>>
>> First some background:
>>
>> For the userspace side of AArch64 guest SVE support we need to
>> expose KVM's allowed vector lengths bitmap to the user and allow
>> the user to choose a sub
13.04.2019 19:11, Max Reitz wrote:
> Ping again
>
> (I feel like I just need to start merging unreviewed patches until I
> break something (can't take that long) so you get so scared of my
> patches that you at least refuse them outright)
Could you resend before?
>
> On 13.07.18 13:14, Max Reit
* Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> 18.04.2019, 19:03, "Dr. David Alan Gilbert" :
> > * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> >> 18.04.2019, 17:20, "Dr. David Alan Gilbert" :
> >> > * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> >> >> 15.04.2019, 14:30, "Dr. David Ala
Hi Stefan,
On 4/18/19 6:13 PM, Stefan Hajnoczi wrote:
> At KVM Forum 2018 I gave a presentation on security in QEMU:
> https://www.youtube.com/watch?v=YAdRf_hwxU8 (video)
> https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides)
>
> This patch adds a security guide to the developer docs
Some PT_LOAD sections may be completely zeroed out and their p_filesize
is zero, in that case the loader should just allocate a page that's at
least p_memsz bytes large (plus eventual alignment padding).
Calling zero_bss does this job for us, all we have to do is make sure we
don't try to mmap a z
18.04.2019 3:14, John Snow wrote:
> This just about rewrites the entirety of the bitmaps.rst document to
> make it consistent with the 4.0 release. I have added new features seen
> in the 4.0 release, as well as tried to clarify some points that keep
> coming up when discussing this feature both in
On Thu, 18 Apr 2019 08:18:56 +0200
Markus Armbruster wrote:
> Alex Williamson writes:
>
> > On Wed, 17 Apr 2019 21:06:33 +0200
> > Markus Armbruster wrote:
> >
> >> Cc: Alex Williamson
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> hw/vfio/pci.c | 19 +--
> >> 1 file
On 18/04/2019 16.53, Markus Armbruster wrote:
> atoui() and get_index() pass char values to isdigit(). With a
> standard isdigit(), we'd get undefined behavior when the value is
> negative. But we're using isdigit() from pc-bios/s390-ccw/libc.h
> here, which behaves nicely. Clean up anyway, just
18.04.2019, 19:03, "Dr. David Alan Gilbert" :
> * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> 18.04.2019, 17:20, "Dr. David Alan Gilbert" :
>> > * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> >> 15.04.2019, 14:30, "Dr. David Alan Gilbert" :
>> >> > * Daniel P. Berrangé (berra...@redh
At KVM Forum 2018 I gave a presentation on security in QEMU:
https://www.youtube.com/watch?v=YAdRf_hwxU8 (video)
https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides)
This patch adds a security guide to the developer docs. This document
covers things that developers should know about
On Thu, Apr 18, 2019 at 09:05:05AM -0700, Dan Williams wrote:
> > > I'd either add a comment about avoiding retpoline overhead here or just
> > > make ->flush == NULL mean generic_nvdimm_flush(). Just so that people
> > > don't
> > > get confused by the code.
> >
> > Isn't this premature optimizat
On 18.04.19 17:36, David Hildenbrand wrote:
> On 18.04.19 13:31, Christian Borntraeger wrote:
>> add the deflate conversion facility.
>
> Nit:
>
> "s390x/cpumodel: add Deflate-conversion facility"
>
>>
>> Signed-off-by: Christian Borntraeger
>> ---
>> target/s390x/cpu_features.c | 9 ++
Dan Williams writes:
> On Fri, Apr 12, 2019 at 6:12 AM Jeff Moyer wrote:
>>
>> Jan Kara writes:
>>
>> > On Thu 11-04-19 07:51:48, Dan Williams wrote:
>> >> On Tue, Apr 9, 2019 at 9:09 PM Pankaj Gupta wrote:
>> >> > + } else {
>> >> > + if (nd_region->flush(nd_region))
>> >>
On Fri, Apr 12, 2019 at 6:12 AM Jeff Moyer wrote:
>
> Jan Kara writes:
>
> > On Thu 11-04-19 07:51:48, Dan Williams wrote:
> >> On Tue, Apr 9, 2019 at 9:09 PM Pankaj Gupta wrote:
> >> > + } else {
> >> > + if (nd_region->flush(nd_region))
> >> > + rc = -
* Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> 18.04.2019, 17:20, "Dr. David Alan Gilbert" :
> > * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> >> 15.04.2019, 14:30, "Dr. David Alan Gilbert" :
> >> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> >> >> On Mon, Apr 15, 2019 at 12:15:1
Patchew URL:
https://patchew.org/QEMU/1555601350-4176-1-git-send-email-mateja.marjano...@rt-rk.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TES
Patchew URL:
https://patchew.org/QEMU/1555601350-4176-1-git-send-email-mateja.marjano...@rt-rk.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TES
On 18.04.19 13:31, Christian Borntraeger wrote:
> add the deflate conversion facility.
Nit:
"s390x/cpumodel: add Deflate-conversion facility"
>
> Signed-off-by: Christian Borntraeger
> ---
> target/s390x/cpu_features.c | 9 +
> target/s390x/cpu_features.h | 1 +
> target/s39
On 4/18/19 4:53 PM, Markus Armbruster wrote:
> "Debugging with GDB / Appendix E GDB Remote Serial Protocol /
> Overview" specifies "The printable characters '#' and '$' or with a
> numeric value greater than 126 must not be used." gdb_read_byte()
> only rejects values < 32. This is wrong. Impact
From: Mateja Marjanovic
Optimize ILVR. instructions, using
directly tcg registers and logic performed on
them, and instead of shifting the bit mask or
assigning a new tcg constant to the bit mask,
assign a new (shifted) uint64_t value to the
bit mask.
Performance measurement is done by executing
From: Mateja Marjanovic
Optimize set of MSA instructions ILVEV., using
directly tcg registers and performing logic on them
instead of using helpers.
In the following table, the first column is the performance
before this patch. The second represents the performance
after converting from helpers
18.04.2019, 17:20, "Dr. David Alan Gilbert" :
> * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> 15.04.2019, 14:30, "Dr. David Alan Gilbert" :
>> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
>> >> On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote:
>> >> > * Danie
From: Mateja Marjanovic
Optimize and refactor MSA instructions ILVEV.,
ILVOD., ILVL. and ILVR..
v9:
- Tests were changed, instead of iterating through the
loop 10 million times and calling the instruction
once, iterate through the loop 1 million times, and
call the instruction ten time
From: Mateja Marjanovic
Optimize ILVL. instructions, using
directly tcg registers and logic performed on
them, and instead of shifting the bit mask or
assigning a new tcg constant to the bit mask,
assign a new (shifted) uint64_t value to the
bit mask.
Performance measurement is done by executing
From: Mateja Marjanovic
Optimize set of MSA instructions ILVOD., using
directly tcg registers and performing logic on them instead
of using helpers.
In the following table, the first column is the performance
before this patch. The second represents the performance
after converting from helpers
On 4/18/19 4:53 PM, Markus Armbruster wrote:
> parse_acl_file() passes char values to isspace(). Undefined behavior
> when the value is negative. Not a security issue, because the
> characters come from trusted $prefix/etc/qemu/bridge.conf and the
> files it includes.
>
> Fix by using qemu_isspa
From: Mateja Marjanovic
The implementation for ILVEV.D and ILVR.D instructions
is equivalent, so use a single handler for both of them.
Suggested-by: Aleksandar Markovic
Signed-off-by: Mateja Marjanovic
---
target/mips/translate.c | 29 +++--
1 file changed, 11 inserti
From: Mateja Marjanovic
The implementation for ILVOD.D and ILVL.D instructions
is equivalent, so use a single handler for both of them.
Suggested-by: Aleksandar Markovic
Signed-off-by: Mateja Marjanovic
---
target/mips/translate.c | 27 ++-
1 file changed, 10 insertion
On 18.04.19 16:56, Igor Mammedov wrote:
> On Thu, 18 Apr 2019 14:06:25 +0200
> David Hildenbrand wrote:
>
>> On 18.04.19 14:01, Igor Mammedov wrote:
>>> On Thu, 18 Apr 2019 13:24:43 +0200
>>> David Hildenbrand wrote:
>>>
On 18.04.19 11:38, Igor Mammedov wrote:
> On Tue, 16 Apr 2019
On Thu, Apr 18, 2019 at 12:26:10PM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote:
> > Hi all,
> >
> > First some background:
> >
> > For the userspace side of AArch64 guest SVE support we need to
> > expose KVM's allowed vector lengths bitmap to t
On 18.04.19 16:01, Christian Borntraeger wrote:
>
>
> On 18.04.19 14:45, David Hildenbrand wrote:
>> On 18.04.19 13:31, Christian Borntraeger wrote:
>>> conditional sske is deprecated and a distant future machine (will be one
>>> where the IBC will not allow to fully go back to z14) will remove t
On Thu, 18 Apr 2019 10:23:29 -0300
Eduardo Habkost wrote:
> On Thu, Apr 18, 2019 at 01:22:16PM +0200, Igor Mammedov wrote:
> > On Thu, 18 Apr 2019 00:45:01 -0300
> > Eduardo Habkost wrote:
> >
> > > Fix the following crash:
> > >
> > > $ qemu-system-x86_64 -cpu ''
> > > qemu-system-x86_6
On Thu, Apr 18, 2019 at 03:43:06PM +0100, Andrew Jones wrote:
> On Thu, Apr 18, 2019 at 03:03:02PM +0100, Dave Martin wrote:
[...]
> > It's worth nothing that there are two problems to be solved here: one is
> > to specify an exact set unambiguously, which is important for migration
> > scenarios
On Thu, Apr 18, 2019 at 03:03:02PM +0100, Dave Martin wrote:
> On Thu, Apr 18, 2019 at 12:28:47PM +0100, Andrew Jones wrote:
> > On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote:
> > > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jones wrote:
> > > > On Thu, Apr 18, 2019 at 11:28:41A
parse_acl_file() passes char values to isspace(). Undefined behavior
when the value is negative. Not a security issue, because the
characters come from trusted $prefix/etc/qemu/bridge.conf and the
files it includes.
Fix by using qemu_isspace() instead.
Signed-off-by: Markus Armbruster
---
qem
Markus Armbruster (6):
qemu-bridge-helper: Fix misuse of isspace()
tests/vhost-user-bridge: Fix misuse of isdigit()
gdbstub: Reject invalid RLE repeat counts
gdbstub: Fix misuse of isxdigit()
pc-bios/s390-ccw: Clean up harmless misuse of isdigit()
cutils: Simplify how parse_uint() check
Hi,
I was trying to migrate a VM(CentOS7) which started with 4G memory and hot
plugged 5 memslots with 1G each. So the VM has total of 9G memory and
trying to migrate fails in vhost_dev_init() on destination host
if (used_memslots >
hdev->vhost_ops->vhost_backend_memslots_limit(hdev)) {
gdb_read_byte() passes its @ch argument to isxdigit(). Undefined
behavior when the value is negative. Two callers:
* gdb_chr_receive() passes an uint8_t value. Safe.
* gdb_handlesig() a char value. Unsafe. Not a security issue,
because the characters come from the gdb client, which is trus
vubr_set_host() passes char values to isdigit(). Undefined behavior
when the value is negative.
Fix by using qemu_isdigit() instead.
Signed-off-by: Markus Armbruster
---
tests/vhost-user-bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vhost-user-bridge.c b/te
Use qemu_isspace() so we don't have to cast to unsigned char.
Signed-off-by: Markus Armbruster
---
util/cutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/cutils.c b/util/cutils.c
index e098debdc0..bed63fc2f1 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -683,7
On Thu, 18 Apr 2019 14:06:25 +0200
David Hildenbrand wrote:
> On 18.04.19 14:01, Igor Mammedov wrote:
> > On Thu, 18 Apr 2019 13:24:43 +0200
> > David Hildenbrand wrote:
> >
> >> On 18.04.19 11:38, Igor Mammedov wrote:
> >>> On Tue, 16 Apr 2019 13:09:08 +0200
> >>> Christian Borntraeger wr
"Debugging with GDB / Appendix E GDB Remote Serial Protocol /
Overview" specifies "The printable characters '#' and '$' or with a
numeric value greater than 126 must not be used." gdb_read_byte()
only rejects values < 32. This is wrong. Impact depends on the caller:
* gdb_handlesig() passes a c
* Andrew Jones (drjo...@redhat.com) wrote:
> On Thu, Apr 18, 2019 at 03:03:02PM +0100, Dave Martin wrote:
> > On Thu, Apr 18, 2019 at 12:28:47PM +0100, Andrew Jones wrote:
> > > On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote:
> > > > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jon
atoui() and get_index() pass char values to isdigit(). With a
standard isdigit(), we'd get undefined behavior when the value is
negative. But we're using isdigit() from pc-bios/s390-ccw/libc.h
here, which behaves nicely. Clean up anyway, just to avoid setting a
bad example.
Cc: Christian Borntr
On Wed, 17 Apr 2019 13:31:41 +0200
David Hildenbrand wrote:
> While the detection on s390x of the maximum ram pagesize works by pure luck,
> we should try to do better. Especially, once "-mem-path" is replaced
> by memory backends, the current approach will break.
>
> Configure the maximum page
On Thu, Apr 18, 2019 at 11:05:20AM -0300, Eduardo Habkost wrote:
> On Thu, Apr 18, 2019 at 11:59:35AM +0200, Pavel Hrdina wrote:
> > On Thu, Apr 18, 2019 at 09:48:25AM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Apr 17, 2019 at 09:26:10PM +0200, Pavel Hrdina wrote:
> > > > On Wed, Apr 17, 2019 a
On Thu, Apr 18, 2019 at 02:46:00PM +0800, Tao Xu wrote:
> The aim of this patch is to add struct NumaState in MachineState
> and move existing numa global nb_numa_nodes into NumaState.
> And add variable numa_support into MachineClass to decide which
> submachines support NUMA.
>
> Suggested-by: I
That should not happen unless you have some device that is incorrectly
not providing a suitable read function in its MemoryRegionOps. If you
look at 'mr' in the debugger you should be able to figure out which
device is the problem.
--
You received this bug notification because you are a member of
On Thu, Apr 18, 2019 at 01:02:41PM +0200, Igor Mammedov wrote:
>On Wed, 17 Apr 2019 09:40:38 +0800
>Wei Yang wrote:
>
>> build_append_foo() API doesn't need explicit endianness conversions
>> which eliminates a source of errors and it makes build_mcfg() look like
>> declarative definition of MCFG
I have to say, after applying this patch, my test still fails while
fetching the instructions from this _small_ region. Although there is no
MMU_DATA_LOAD anymore, a few iterations later (while guest code has just
jumped to the beginning of the executable region), QEmu segfaults (call
stack is atta
call stack for SEGFAULT that happens during the execution of small
region. This will go away IF THE ENTRY ADDED TO TLB FOR THIS REGION IS
OF SIZE TARGET_PAGE_SIZE. However, that would not be correct behavior.
** Attachment added: "segfault_bt.txt"
https://bugs.launchpad.net/qemu/+bug/1825359/+
* Yury Kotov (yury-ko...@yandex-team.ru) wrote:
> 15.04.2019, 14:30, "Dr. David Alan Gilbert" :
> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> >> On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote:
> >> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> >> > > On
The uncommented piece of my /etc/libvirt/qemu.conf.
vnc_listen = "192.168.0.61"
user = "root"
group = "root"
dynamic_ownership = 0
nvram = [
"/usr/share/edk2-ovmf/OVMF_CODE.fd:/usr/share/edk2-ovmf/OVMF_VARS.fd",
]
For some reason, emails directly from mailing list are not hitting my inbox
The patch looks OK code-wise, but could you submit it to the mailing list,
please?
https://wiki.qemu.org/Contribute/SubmitAPatch has the details, but the most
important part is that it needs a Signed-off-by: line from you that says you
have the legal right and are willing to contribute it to QEM
On Thu, Apr 18, 2019 at 11:59:35AM +0200, Pavel Hrdina wrote:
> On Thu, Apr 18, 2019 at 09:48:25AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Apr 17, 2019 at 09:26:10PM +0200, Pavel Hrdina wrote:
> > > On Wed, Apr 17, 2019 at 10:53:04PM +0800, Pu Wen wrote:
> > > > On 2019/4/16 22:17, Pavel Hrdin
On Thu, Apr 18, 2019 at 12:28:47PM +0100, Andrew Jones wrote:
> On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote:
> > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jones wrote:
> > > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote:
> > > > Hi all,
> > > >
> > > > First s
On 18.04.19 14:45, David Hildenbrand wrote:
> On 18.04.19 13:31, Christian Borntraeger wrote:
>> conditional sske is deprecated and a distant future machine (will be one
>> where the IBC will not allow to fully go back to z14) will remove this
>> feature. To prepare for this and allow for the z1
Should I make a patch then?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1825359
Title:
cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH
Status in QEMU:
Confirmed
Bug description:
** Patch added: "bug1825359_io_readx.patch"
https://bugs.launchpad.net/qemu/+bug/1825359/+attachment/5256724/+files/bug1825359_io_readx.patch
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1825359
On Thu, Apr 18, 2019 at 01:22:16PM +0200, Igor Mammedov wrote:
> On Thu, 18 Apr 2019 00:45:01 -0300
> Eduardo Habkost wrote:
>
> > Fix the following crash:
> >
> > $ qemu-system-x86_64 -cpu ''
> > qemu-system-x86_64: qom/cpu.c:291: cpu_class_by_name: \
> > Assertion `cpu_model && cc->c
Patchew URL:
https://patchew.org/QEMU/20190418125908.11928-1-marcandre.lur...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/2] Memory fixes for slirp tcp_emu()
Type: series
Message-id: 20190418125908
On 18.04.19 15:00, Christian Borntraeger wrote:
>
>
> On 18.04.19 14:45, David Hildenbrand wrote:
>> On 18.04.19 13:31, Christian Borntraeger wrote:
>>> conditional sske is deprecated and a distant future machine (will be one
>>> where the IBC will not allow to fully go back to z14) will remove t
On 18.04.19 14:56, David Hildenbrand wrote:
> On 18.04.19 13:31, Christian Borntraeger wrote:
>> Add vector enhancements to the cpu model.
>>
>> Signed-off-by: Christian Borntraeger
>> ---
>> target/s390x/cpu_features.c | 2 ++
>> target/s390x/cpu_features_def.h | 2 ++
>> 2 files changed,
On 18.04.19 14:45, David Hildenbrand wrote:
> On 18.04.19 13:31, Christian Borntraeger wrote:
>> conditional sske is deprecated and a distant future machine (will be one
>> where the IBC will not allow to fully go back to z14) will remove this
>> feature. To prepare for this and allow for the z1
On 18.04.19 14:54, David Hildenbrand wrote:
> On 18.04.19 13:31, Christian Borntraeger wrote:
>> Provide the MSA9 facility (stfle.155). This also contains pckmo
>> functions for key wrapping. Keep them in a separate group to allow
>> disabling/enabling those as a block if necessary.
>>
>> Signe
For some reason, EMU_IDENT is not like other "emulated" protocols and
tries to reconstitute the original buffer, if it came in multiple
packets. Unfortunately, it does so wrongly, as it doesn't respect the
sbuf circular buffer appending rules, nor does it maintain some of the
invariants (rptr is in
Prevents from buffer overflows.
Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1664205
Cc: Prasad J Pandit
Signed-off-by: Marc-André Lureau
---
slirp/src/tcp_subr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/slirp/src/tcp_subr.c b/slirp/src/tcp_subr.c
index fde9207b0c..c435
Hi,
See the following 2 patches fixing some memory issues in
tcp_emu(). Those are not regressions, consider it for 4.1.
Marc-André Lureau (2):
slirp: ensure there is enough space in mbuf to null-terminate
slirp: don't manipulate so_rcv in tcp_emu()
slirp/src/tcp_subr.c | 27 +++-
101 - 200 of 277 matches
Mail list logo
