Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > The Golang JSON parser decodes JSON numbers to float64 by default so > > will have this precision limitation too, though at least they provide > > a backdoor for custom parsing from the original serialized representation. > > >

Re: [Qemu-devel] [PATCH v2 2/4] 9P: trivial cleanup of QID path collision mitigation

On Fri, 03 May 2019 18:22:12 +0200 Christian Schoenebeck wrote: > Addresses trivial changes regarding the previous patch as requested > on the mailing list a while ago. > Ah... so that explains why I couldn't find the changes in the other patch. > * Removed unneccessary parantheses: > https:

[Qemu-devel] [Bug 1826568] Re: RISC-V Disassembler/translator instruction decoding disagreement

I've encountered this message before for invalid instructions, and it often doesn't really mean there was an error. In particular for variable instruction length ISAs you'll see the error if the translator reads part of the insn and determines that it's invalid without needing to read the rest of i

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

24.04.2019 19:36, Max Reitz wrote: > On 19.04.19 12:23, Vladimir Sementsov-Ogievskiy wrote: >> 17.04.2019 19:22, Max Reitz wrote: >>> On 16.04.19 12:02, Vladimir Sementsov-Ogievskiy wrote: 10.04.2019 23:20, Max Reitz wrote: > What bs->file and bs->backing mean depends on the node. For fil

Re: [Qemu-devel] [PATCH v2 1/4] 9p: mitigates most QID path collisions

On Fri, 03 May 2019 18:21:36 +0200 Christian Schoenebeck wrote: > This first patch here is an updated version of Antonios Motakis' > original 4-patch set, merged to one patch: > > https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02283.html > > * Updated to latest git master, specificall

Re: [Qemu-devel] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

On Sun, 5 May 2019 21:51:02 -0400 Yan Zhao wrote: > This feature implements the version attribute for Intel's vGPU mdev > devices. > > version attribute is rw. > It's used to check device compatibility for two mdev devices. > version string format and length are private for vendor driver. vendo

Re: [Qemu-devel] [PATCH v4 05/24] crypto: Use O_CLOEXEC in qcrypto_random_init

On 06/05/2019 19:33, Richard Henderson wrote: Avoids leaking the /dev/urandom fd into any child processes. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [Qemu-devel] [PATCH v2 0/4] 9p: Fix file ID collisions

On Fri, 03 May 2019 18:20:39 +0200 Christian Schoenebeck wrote: > Hi! > > This is v2 of a proposed patch set for fixing file ID collisions with 9pfs. > > Patch 1 to 3 are identical to the previous version. New in this v2 is patch 4 > which introduces variable length suffixes for inode mapping i

Re: [Qemu-devel] [QEMU PATCH] MAINTAINERS: Downgrade status of block sections without "M:" to "Odd Fixes"

Am 06.05.2019 um 08:18 hat Thomas Huth geschrieben: > Fixes might still get picked up via the qemu-block mailing list, > so the status is not "Orphan" yet. > Also add the gluster mailing list as suggested by Niels here: > > https://patchwork.kernel.org/patch/10613297/#22409943 > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. > C

Re: [Qemu-devel] [PATCH v4 04/24] crypto: Do not fail for EINTR during qcrypto_random_bytes

On 06/05/2019 19:33, Richard Henderson wrote: We can always get EINTR for read; /dev/urandom is no exception. Rearrange the order of tests for likelihood; allow degenerate buflen==0 case to perform a no-op zero-length read. This means that the normal success path is a straight line with a singl

Re: [Qemu-devel] [PATCH v4 03/24] crypto: Reverse code blocks in random-platform.c

On 06/05/2019 19:33, Richard Henderson wrote: Use #ifdef _WIN32 instead of #ifndef _WIN32. This will make other tests easier to sequence. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 35 +-

Re: [Qemu-devel] [PATCH RFC v2] s390/css: handle CCW_FLAG_SKIP

On 07/05/2019 10:12, Cornelia Huck wrote: If a ccw has CCW_FLAG_SKIP set, and the command is of type read, read backwards, or sense, no data should be written to the guest for that command. Signed-off-by: Cornelia Huck --- v1 -> v2: fixed checks for command type [Eric] Still only lightly test

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 0/9] s390x: new guest features

On 29.04.19 18:08, Cornelia Huck wrote: > On Mon, 29 Apr 2019 05:02:41 -0400 > Christian Borntraeger wrote: > >> Adding gen15. >> >> v2->v3: - merge deprecation patch into gen 15 patch >> - fix comments >> - use gen15a and gen15b instead of cpuid >> v1->v2: - rework csske deprecatio

Re: [Qemu-devel] [PATCH v4 02/24] crypto: Merge crypto-obj-y into libqemuutil.a

On 06/05/2019 19:33, Richard Henderson wrote: We will shortly need this in the user-only binaries, so drop the split into system and tools binaries. This also means that crypto-aes-obj-y can be merged back into crypto-obj-y. This patch breaks linux-user statically linked build on Fedora. Fed

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 03 May 2019 16:10 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; sa...@linux.intel.com

Re: [Qemu-devel] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

On Tue, 7 May 2019 01:39:13 -0400 Yan Zhao wrote: > On Tue, Apr 30, 2019 at 11:29:08PM +0800, Cornelia Huck wrote: > > If I followed the discussion correctly, I think you plan to drop this > > format, don't you? I'd be happy if a vendor driver can use a simple > > number without any prefixes if

Re: [Qemu-devel] [PATCH v2 5/5] qxl: avoid unaligned pointer reads/writes

On Tue, May 07, 2019 at 10:11:02AM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 5/7/19 9:54 AM, Gerd Hoffmann wrote: > > On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: > >> The SPICE_RING_PROD_ITEM() macro is initializing a local > >> 'uint64_t *' variable to point t

Re: [Qemu-devel] [PATCH] block: remove bs from lists before closing

Am 07.05.2019 um 10:12 hat Anton Kuchin geschrieben: > Close involves flush that can be performed asynchronously and bs > must be protected from being referenced before it is deleted. > > Signed-off-by: Anton Kuchin Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

Am 06.05.2019 um 22:33 hat John Snow geschrieben: > in blockdev_backup_prepare, we check to make sure that the target is > associated with a compatible aio context. However, do_blockdev_backup is > called later and has some logic to move the target to a compatible > aio_context. The transaction ver

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

Daniel P. Berrangé writes: > On Tue, Apr 30, 2019 at 03:45:46PM +0100, Dr. David Alan Gilbert wrote: >> * Daniel P. Berrangé (berra...@redhat.com) wrote: >> > The QEMU QMP service is based on JSON which is nice because that is a >> > widely supported "standard" data format. >> > >> > ex

[Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

This fixes several things: - add "id" description to -virtfs documentation - split the description into several lines in both usage and documentation for accurateness and clarity - add documentation and usage of the synth fsdriver - add "throttling.*" description to -fsdev local - add some missin

[Qemu-devel] [PATCH 4/6] fsdev: Error out when unsupported option is passed

Each fsdriver only supports a subset of the options that can be passed to -fsdev. Unsupported options are simply ignored. This could cause the user to erroneously think QEMU has a bug. Enforce strict checking of supported options for all fsdrivers. This shouldn't impact libvirt, since it doesn't k

[Qemu-devel] [PATCH 5/6] vl: Deprecate -virtfs_synth

The synth fsdriver never got used for anything else but the QTest testcase for VirtIO 9P. And even there, QTest directly uses -fsdev synth and -device virtio-9p-{pci|device}. Signed-off-by: Greg Kurz --- This should be Cc'd to libvir-l...@redhat.com according to MAINTAINERS, but libvirt doesn't

[Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c

It would make sense for these types to be defined in a header file if we had an API for fsdrivers to register themselves. In practice, we only have three of them and it is very unlikely we add new ones since the future of file sharing between host and guest is the upcoming virtio-fs. Move the type

[Qemu-devel] [PATCH 0/6] fsdev/virtfs: Assorted cleanups and fixes

Hi, This series does several things, not necessarily related, but I post them all together anyway because it will be more convenient for me to merge them after review, given the little time I can spend on virtfs maintainership. Thomas, Patch 6 supersedes http://patchwork.ozlabs.org/patch/1095472

[Qemu-devel] [PATCH 1/6] fsdev: Drop unused extern declaration

This is a leftover of the handle backend, removed in QEMU 4.0. Signed-off-by: Greg Kurz --- fsdev/qemu-fsdev.h |1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/qemu-fsdev.h b/fsdev/qemu-fsdev.h index d9716b414492..844159d1e1ff 100644 --- a/fsdev/qemu-fsdev.h +++ b/fsdev/qemu-fsdev.h @

[Qemu-devel] [PATCH 2/6] fsdev: Drop unused opaque field

This was introduced along with -fsdev but it never got used. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 3fa062b39f1b..c757c8099f54 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@

Re: [Qemu-devel] Use of PreallocMode in block drivers (was: [PATCH] block/rbd: add preallocation support)

On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: > Cc: Peter for a libvirt perspective. > > Stefano Garzarella writes: > > > This patch adds the support of preallocation (off/full) for the RBD > > block driver. > > If available, we use rbd_writesame() to quickly fill the image

Re: [Qemu-devel] Update *BSD images with gnu-sed and bash (was: [PATCH 4/6] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD)

> >> D'oh! Does anybody know what are the correct steps to update these images? > > > > (1) make the OPENBSD subsystem maintainer care > > > > (2) update > > > > (3) download the image from download.patchew.org, boot it and update it > > > > (4) upload the imag

Re: [Qemu-devel] [PATCH v4 01/24] configure: Link test before auto-enabling gnutls

On 06/05/2019 19:33, Richard Henderson wrote: At least ubuntu 18.04 does not package static gnutls libraries. Signed-off-by: Richard Henderson --- configure | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) Reviewed-by: Laurent Vivier

[Qemu-devel] [PULL 6/8] qxl: avoid unaligned pointer reads/writes

From: Daniel P. Berrangé The SPICE_RING_PROD_ITEM() macro is initializing a local 'uint64_t *' variable to point to the 'el' field inside the QXLReleaseRing struct. This uint64_t field is not guaranteed aligned as the struct is packed. Code should not take the address of fields within a packed s

[Qemu-devel] [PULL 5/8] vl: add -vga help support

From: Marc-André Lureau Provide help output similar to other argument help handling: $ qemu-system-x86_64 -vga help none std standard VGA (default) cirrus Cirrus VGA vmware VMWare SVGA xenfb qxl QXL VGA virtio Virtio VG

[Qemu-devel] [PULL 8/8] i2c-ddc: move it to hw/display

From: Paolo Bonzini Move it together with the other EDID code. hw/i2c should only include the core and the adapters, not the slaves. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190325155923.30987-1-pbonz...@redhat.com Signed-off-by: Gerd Hoffmann --- inclu

[Qemu-devel] [PULL 4/8] vl: constify VGAInterfaceInfo

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-id: 20190412152713.16018-2-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PULL 2/8] hw/display/cirrus_vga: Update the documentation URL

From: Philippe Mathieu-Daudé The documentation URL is not working, but is backed up by the Wayback Machine on the Internet Archive. Replace the outdated link by a captured one. Add another link to the VGADOC4b.ZIP archive content. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20190504121650

[Qemu-devel] [PULL 7/8] ati-vga: Fix check for blt outside vram

From: BALATON Zoltan Fix the check preventing calling pixman functions that would access memory outside allocated vram. The r128 X driver sometimes seem to try blits that span outside vram, this check prevents crashing QEMU in that case. (The r128 X driver may have problems even on real hardware

[Qemu-devel] [PULL 3/8] hw/display/cirrus_vga: Remove unused include

From: Philippe Mathieu-Daudé Commit ce3cf70edaaf split the ISA device out of the PCI one, but forgot to remove the "hw/loader.h" header inclusion (the ISA device calls rom_add_vga()). Remove the now unused include. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-id: 201

[Qemu-devel] [PULL 1/8] qxl: check release info object

From: Prasad J Pandit When releasing spice resources in release_resource() routine, if release info object 'ext.info' is null, it leads to null pointer dereference. Add check to avoid it. Reported-by: Bugs SysSec Signed-off-by: Prasad J Pandit Message-id: 20190425063534.32747-1-ppan...@redhat.

[Qemu-devel] [PULL 0/8] Vga 20190507 patches

The following changes since commit a6ae23831b05a11880b40f7d58e332c45a6b04f7: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2019-05-03 15:26:09 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-201

[Qemu-devel] [PATCH] block: remove bs from lists before closing

Close involves flush that can be performed asynchronously and bs must be protected from being referenced before it is deleted. Signed-off-by: Anton Kuchin --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 9ae5c0ed2f..b505271a4d 100644 ---

[Qemu-devel] [PATCH RFC v2] s390/css: handle CCW_FLAG_SKIP

If a ccw has CCW_FLAG_SKIP set, and the command is of type read, read backwards, or sense, no data should be written to the guest for that command. Signed-off-by: Cornelia Huck --- v1 -> v2: fixed checks for command type [Eric] Still only lightly tested (it boots); I don't think I have a tool g

Re: [Qemu-devel] [PATCH v2 5/5] qxl: avoid unaligned pointer reads/writes

Hi Gerd, On 5/7/19 9:54 AM, Gerd Hoffmann wrote: > On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: >> The SPICE_RING_PROD_ITEM() macro is initializing a local >> 'uint64_t *' variable to point to the 'el' field inside >> the QXLReleaseRing struct. This uint64_t field is not >>

Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block

Am 03.05.2019 um 16:39 hat Alex Bennée geschrieben: > This attempts to clean-up the output to better match the output of the > rest of the QEMU check system. This includes: > > - formatting as " TESTiotest: nnn" > - calculating time diff at the end > - only dumping config on failure >

[Qemu-devel] [PATCH v3] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

From: HOU Qiming In a GVT-g setup with dmabuf and GTK GUI, the current 2D texture at surface_gl_update_texture is not necessarily surface->texture. Adding a glBindTexture fixes related crashes and artifacts, and is generally more secure. Signed-off-by: HOU Qiming Tested-by: Marcel Apfelbaum [fi

Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp

On 5/7/19 2:48 AM, Anton Blanchard wrote: > Fix a typo in xvxsigdp where we put both results into the lower > doubleword. > > Fixes: dd977e4f45cb ("target/ppc: Optimize x[sv]xsigdp using deposit_i64()") > Signed-off-by: Anton Blanchard > --- > target/ppc/translate/vsx-impl.inc.c | 2 +- > 1 file

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

On 5/7/19 9:49 AM, Hou Qiming wrote: My real name is "HOU Qiming". @Marcel Apfelbaum can you incorporate that in your v2 patch? Thanks! Sure thing, Thanks, Marcel Qiming On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé mailto:phi...@redhat.com

Re: [Qemu-devel] [PATCH] i2c-ddc: move it to hw/display

On Mon, Mar 25, 2019 at 04:59:23PM +0100, Paolo Bonzini wrote: > Move it together with the other EDID code. hw/i2c should only > include the core and the adapters, not the slaves. Added to vga queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] ati-vga: Fix check for blt outside vram

On Tue, Apr 09, 2019 at 12:56:18PM +0200, BALATON Zoltan wrote: > Fix the check preventing calling pixman functions that would access > memory outside allocated vram. The r128 X driver sometimes seem to try > blits that span outside vram, this check prevents crashing QEMU in > that case. (The r128

Re: [Qemu-devel] [PATCH v2 5/5] qxl: avoid unaligned pointer reads/writes

On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: > The SPICE_RING_PROD_ITEM() macro is initializing a local > 'uint64_t *' variable to point to the 'el' field inside > the QXLReleaseRing struct. This uint64_t field is not > guaranteed aligned as the struct is packed. > > Code sh

Re: [Qemu-devel] [PATCH] net: avoid to use variable length array in net_client_init()

On Mon, May 06, 2019 at 12:54:20PM -0500, Eric Blake wrote: > On 5/3/19 12:06 PM, Stefano Garzarella wrote: > > net_client_init() uses a variable length array to store the prefix > > of 'ipv6-net' parameter (e.g. if ipv6-net=fec0::0/64, the prefix > > is 'fec0::0'). > > Since the IPv6 prefix can be

Re: [Qemu-devel] [PATCH 0/2] Add -vga help

On Fri, Apr 12, 2019 at 05:27:11PM +0200, Marc-André Lureau wrote: > Hi, > > SSIA, see patches. Series added to vga queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2] ui/console: Precautionary glBindTexture and surface->texture validation in surface_gl_update_texture

On 5/7/19 8:49 AM, Hou Qiming wrote: > My real name is "HOU Qiming". @Marcel Apfelbaum > can you incorporate that in your v2 > patch? Thanks! Thanks a lot Qiming :) > On Tue, May 7, 2019 at 2:25 PM Philippe Mathieu-Daudé > wrote: > >

Re: [Qemu-devel] [PATCH RFC] s390/css: handle CCW_FLAG_SKIP

On Mon, 6 May 2019 16:58:03 -0400 Eric Farman wrote: > On 5/6/19 1:17 PM, Cornelia Huck wrote: > > If a ccw has CCW_FLAG_SKIP set, and the command is of type > > read, read backwards, or sense, no data should be written > > to the guest for that command. > > > > Signed-off-by: Cornelia Huck > >

Re: [Qemu-devel] [PATCH v2 1/3] aspeed: add a per SoC mapping for the interrupt space

On 5/6/19 4:47 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 5/6/19 4:20 PM, Cédric Le Goater wrote: >> This will simplify the definition of new SoCs, like the AST2600 which >> should use a different CPU and a different IRQ number layout. >> >> Signed-off-by: Cédric Le Goater >> --- >> >>

Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include

On Mon, May 06, 2019 at 12:56:40AM +0200, Philippe Mathieu-Daudé wrote: > Commit ce3cf70edaaf split the ISA device out of the PCI one, > but forgot to remove the "hw/loader.h" header inclusion (the ISA > device calls rom_add_vga()). Remove the now unused include. Added to vga queue. thanks, Ge

Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Update the documentation URL

On Sat, May 04, 2019 at 02:16:50PM +0200, Philippe Mathieu-Daudé wrote: > The documentation URL is not working, but is backed up by the > Wayback Machine on the Internet Archive. > Replace the outdated link by a captured one. > Add another link to the VGADOC4b.ZIP archive content. Added to vga pat

Re: [Qemu-devel] [PATCH] qxl: check release info object

On Thu, Apr 25, 2019 at 12:05:34PM +0530, P J P wrote: > From: Prasad J Pandit > > When releasing spice resources in release_resource() routine, > if release info object 'ext.info' is null, it leads to null > pointer dereference. Add check to avoid it. Added to vga patch queue. thanks, Gerd

<    1   2   3   4