Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent

2019-05-22 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 21 May 2019 at 15:34, Markus Armbruster wrote: >> >> Damien Hedde writes: >> >> > On 5/16/19 11:19 AM, Peter Maydell wrote: >> >> On Thu, 16 May 2019 at 06:37, Markus Armbruster wrote: >> >>> >> >>> A registry of callbacks to run on certain events is a fine tech

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-22 Thread Alex Bennée
Richard Henderson writes: > Since v4.0, capstone.h has moved to . > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/disas/capstone.h | 4 > configure| 6 ++ > 2 files changed, 10 insertions(+) > > diff --git a/include/disas/capstone.h b/

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

2019-05-22 Thread Christian Ehrhardt 
I only saw this because it expired now :-/ Anyone affected by this might want to take a look at bug 1776189 where Ubuntu added a special machine type to more easily set "host-phys-bits" which is the qemu flag to have more (usually the host has more) available (at the cost of migratability). That a

[Qemu-devel] [PATCH 2/8] spapr: Clean up device tree construction for PCI devices

2019-05-22 Thread David Gibson
spapr_create_pci_child_dt() is a trivial wrapper around spapr_populate_pci_child_dt(), but is the latter's only caller. So fold them together into spapr_dt_pci_device(), which closer matches our modern naming convention. While there, make a number of cleanups to the function itself. This is most

[Qemu-devel] [PATCH 1/8] spapr: Clean up device node name generation for PCI devices

2019-05-22 Thread David Gibson
spapr_populate_pci_child_dt() adds a 'name' property to the device tree node for PCI devices. This is never necessary for a flattened device tree, it is implicit in the name added when the node is constructed. In fact anything we do add to a 'name' property will be overwritten with something deri

[Qemu-devel] [PATCH 7/8] spapr: Direct all PCI hotplug to host bridge, rather than P2P bridge

2019-05-22 Thread David Gibson
A P2P bridge will attempt to handle the hotplug with SHPC, which doesn't work in the PAPR environment. Instead we want to direct all PCI hotplug actions to the PAPR specific host bridge which will use the PAPR hotplug mechanism. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 11 +++ 1

[Qemu-devel] [PATCH 4/8] spapr: Clean up spapr_drc_populate_dt()

2019-05-22 Thread David Gibson
This makes some minor cleanups to spapr_drc_populate_dt(), renaming it to the shorter and more idiomatic spapr_dt_drc() along the way. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 7 +++ hw/ppc/spapr_drc.c | 13 ++--- hw/ppc/spapr_pci.c | 3 +-- incl

[Qemu-devel] [PATCH 6/8] spapr: Don't use bus number for building DRC ids

2019-05-22 Thread David Gibson
DRC ids are more or less arbitrary, as long as they're consistent. For PCI, we notionally build them from the phb's index along with PCI bus number, slot and function number. Using bus number is broken, however, because it can change if the guest re-enumerates the PCI topology for whatever reason

[Qemu-devel] [PATCH 8/8] spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges

2019-05-22 Thread David Gibson
The pseries machine type already allows PCI hotplug and unplug via the PAPR mechanism, but only on the root bus of each PHB. This patch extends this to allow PCI to PCI bridges to be hotplugged, and devices to be hotplugged or unplugged under P2P bridges. For now we disallow hot unplugging P2P br

[Qemu-devel] [PATCH 5/8] spapr: Clean up DRC index construction

2019-05-22 Thread David Gibson
spapr_pci.c currently has several confusingly similarly named functions for various conversions between representations of DRCs. Make things clearer by renaming things in a more consistent XXX_from_YYY() manner and remove some called-only-once variants in favour of open coding. While we're at it,

[Qemu-devel] [PATCH 3/8] spapr: Clean up dt creation for PCI buses

2019-05-22 Thread David Gibson
Device nodes for PCI bridges (both host and P2P) describe both the bridge device itself and the bus hanging off it, handling of this is a bit of a mess. spapr_dt_pci_device() has a few things it only adds for non-bridges, but always adds #address-cells and #size-cells which should only appear for

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

2019-05-22 Thread Launchpad Bug Tracker
[Expired for qemu (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1562653 Ti

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

2019-05-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1562653 Title: Ubuntu 15.1

[Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-22 Thread Richard Henderson
Since v4.0, capstone.h has moved to . Signed-off-by: Richard Henderson --- include/disas/capstone.h | 4 configure| 6 ++ 2 files changed, 10 insertions(+) diff --git a/include/disas/capstone.h b/include/disas/capstone.h index e29068dd97..90631d84a9 100644 --- a/include

[Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x

2019-05-22 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Install a skipdata hook to keep capstone in sync with the instruction stream for unknown opcodes. Signed-off-by: Richard Henderson --- Makefile | 1 + disas.c| 40

[Qemu-devel] [PATCH 0/3] Update capstone module

2019-05-22 Thread Richard Henderson
There has recently been some good progress in the upstream capstone repository, syncing the instruction sets from the (further) upstream llvm. In particular, there are Power9 and System z13 instructions. Both of which were missing from our current snapshot and from our (ancient) binutils opcodes s

[Qemu-devel] [PATCH 2/3] capstone: Update to master

2019-05-22 Thread Richard Henderson
Update to fbb20ea83c5a. Choose this over the 4.0.1 tag because master now includes the s390x z13 vector opcodes. Signed-off-by: Richard Henderson --- capstone | 2 +- configure | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/capstone b/capstone index 22ead3e0bf..fbb20ea83c

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Eduardo Habkost
On Wed, May 22, 2019 at 09:04:17PM -0400, Cleber Rosa wrote: > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Cleber Rosa" > > Cc: "Philippe Mathieu-Daudé" , qemu-devel@nongnu.org, > > "Aleksandar Rikalo" , > > "Aleksandar Markovic" , "Aleksandar Markovic" > > , "Aureli

Re: [Qemu-devel] [RFC v2 PATCH 3/3] spapr: Add Hcalls to support PAPR NVDIMM device

2019-05-22 Thread David Gibson
On Wed, May 22, 2019 at 03:08:34PM -0300, Fabiano Rosas wrote: > Shivaprasad G Bhat writes: > > > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c > > index 6c16d2b120..b6e7d04dcf 100644 > > --- a/hw/ppc/spapr_hcall.c > > +++ b/hw/ppc/spapr_hcall.c > > @@ -3,11 +3,13 @@ > > #include "sys

[Qemu-devel] [PATCH] vmstate: Add VMSTATE_OPAQUE to save/load complex data structures

2019-05-22 Thread rkir--- via Qemu-devel
From: Roman Kiryanov VMSTATE_OPAQUE allows passing user defined functions to save and load vmstate for cases when data structures do not fit into int/struct/array terms. Signed-off-by: Roman Kiryanov --- include/migration/vmstate.h | 13 + 1 file changed, 13 insertions(+) diff --g

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-22 Thread Laszlo Ersek
(+Ard) On 05/22/19 16:22, Laszlo Ersek wrote: > On 05/22/19 15:06, Igor Mammedov wrote: >> On Tue, 21 May 2019 09:26:16 -0400 >> "Michael S. Tsirkin" wrote: >> >>> On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: >>>

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-22 Thread Laszlo Ersek
On 05/23/19 02:51, Laszlo Ersek wrote: > I'm attaching the two log sections ("good.txt" (from > the x86-64 host) vs "bad.txt" (from the aarch64 host)). Typo correction: "bad.txt" comes from an aarch32 host. (That's quite the point.) Thanks & sorry Laszlo

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Cleber Rosa
- Original Message - > From: "Eduardo Habkost" > To: "Cleber Rosa" > Cc: "Philippe Mathieu-Daudé" , qemu-devel@nongnu.org, > "Aleksandar Rikalo" , > "Aleksandar Markovic" , "Aleksandar Markovic" > , "Aurelien > Jarno" , "Wainer dos Santos Moschetta" > > Sent: Wednesday, May 22, 201

Re: [Qemu-devel] [PATCH v2] numa: improve cpu hotplug error message with a wrong node-id

2019-05-22 Thread David Gibson
On Tue, May 21, 2019 at 09:33:48AM +0200, Laurent Vivier wrote: > On pseries, core-ids are strongly binded to a node-id by the command > line option. If an user tries to add a CPU to the wrong node, he has > an error but it is not really helpful: > > qemu-system-ppc64 ... -smp 1,maxcpus=64,cores

Re: [Qemu-devel] [PATCH 1/1] spapr: Do not re-read the clock on pre_save handler on migration

2019-05-22 Thread David Gibson
On Mon, May 20, 2019 at 05:43:40PM -0300, Maxiwell S. Garcia wrote: > This handler was added in the commit: > 42043e4f1241: spapr: clock should count only if vm is running > > In a scenario without migration, this pre_save handler is not > triggered, so the 'stop/cont' commands save and restore

Re: [Qemu-devel] [PATCH 0/2] spapr/xive: change default interrupt mode to 'dual'

2019-05-22 Thread David Gibson
On Wed, May 22, 2019 at 09:40:14AM +0200, Cédric Le Goater wrote: > Hello, > > Here is a little series fixing multiple resets when in 'dual' > interrupt mode and changing the default mode to 'dual'. Applied, thanks. > > Thanks, > > C. > > Cédric Le Goater (2): > spapr/xive: fix multiple res

Re: [Qemu-devel] [PATCH] spapr: Don't migrate the hpt_maxpagesize cap to older machine types

2019-05-22 Thread David Gibson
On Wed, May 22, 2019 at 03:43:46PM +0200, Greg Kurz wrote: > Commit 0b8c89be7f7b added the hpt_maxpagesize capability to the migration > stream. This is okay for new machine types but it breaks backward migration > to older QEMUs, which don't expect the extra subsection. > > Add a compatibility bo

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Eduardo Habkost
On Wed, May 22, 2019 at 05:46:06PM -0400, Cleber Rosa wrote: > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Philippe Mathieu-Daudé" > > Cc: qemu-devel@nongnu.org, "Aleksandar Rikalo" , > > "Aleksandar Markovic" > > , "Aleksandar Markovic" > > , "Cleber Rosa" , > > "Au

Re: [Qemu-devel] [PATCH 4/4] hw/arm/exynos4210: QOM'ify the Exynos4210 SoC

2019-05-22 Thread Alistair Francis
On Mon, May 20, 2019 at 2:47 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/exynos4210.c | 26 +++--- > hw/arm/exynos4_boards.c | 9 ++--- > include/hw/arm/exynos4210.h | 9

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Aleksandar Markovic
On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Philippe Mathieu-Daudé" > > Cc: qemu-devel@nongnu.org, "Aleksandar Rikalo" , "Aleksandar Markovic" > > , "Aleksandar Markovic" < amarko...@wavecomp.com>, "Cleber Rosa" , > > "

[Qemu-devel] [PULL 15/16] tcg/aarch64: Allow immediates for vector ORR and BIC

2019-05-22 Thread Richard Henderson
The allows immediates to be used for ORR and BIC, as well as the trivial inversions, ORC and AND. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 90 +--- 1 file changed, 83 insertions(+), 7 deletions(-) diff --git a/tcg/aarch64/tcg-target.inc

[Qemu-devel] [PULL 11/16] tcg/aarch64: Support vector bitwise select value

2019-05-22 Thread Richard Henderson
The instruction set has 3 insns that perform the same operation, only varying in which operand must overlap the destination. We can represent the operation without overlap and choose based on the operands seen. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch

[Qemu-devel] [PULL 13/16] tcg/aarch64: Use MVNI in tcg_out_dupi_vec

2019-05-22 Thread Richard Henderson
The compliment of a subset of immediates can be computed with a single instruction. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index 1422dfebe2..0b8

[Qemu-devel] [PULL 12/16] tcg/aarch64: Split up is_fimm

2019-05-22 Thread Richard Henderson
There are several sub-classes of vector immediate, and only MOVI can use them all. This will enable usage of MVNI and ORRI, which use progressively fewer sub-classes. This patch adds no new functionality, merely splits the function and moves part of the logic into tcg_out_dupi_vec. Signed-off-by

[Qemu-devel] [PULL 16/16] tcg/i386: Use MOVDQA for TCG_TYPE_V128 load/store

2019-05-22 Thread Richard Henderson
This instruction raises #GP, aka SIGSEGV, if the effective address is not aligned to 16-bytes. We have assertions in tcg-op-gvec.c that the offset from ENV is aligned, for vector types <= V128. But the offset itself does not validate that the final pointer is aligned -- one must also remember to

[Qemu-devel] [PULL 10/16] tcg/i386: Use umin/umax in expanding unsigned compare

2019-05-22 Thread Richard Henderson
Using umin(a, b) == a as an expansion for TCG_COND_LEU is a better alternative to (a - INT_MIN) <= (b - INT_MIN). Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 80 +-- 1 file changed, 61 insertions(+), 19 deletions(-) diff --git a/tcg/i386/

[Qemu-devel] [PULL 07/16] tcg: Add TCG_OPF_NOT_PRESENT if TCG_TARGET_HAS_foo is negative

2019-05-22 Thread Richard Henderson
If INDEX_op_foo is always expanded by tcg_expand_vec_op, then there may be no reasonable set of constraints to return from tcg_target_op_def for that opcode. Let TCG_TARGET_HAS_foo be specified as -1 in that case. Thus a boolean test for TCG_TARGET_HAS_foo is true, but we will not assert within p

[Qemu-devel] [PULL 08/16] tcg/i386: Support vector comparison select value

2019-05-22 Thread Richard Henderson
We already had backend support for this feature. Expand the new cmpsel opcode using vpblendb. The combination allows us to avoid an extra NOT for some comparison codes. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 39 ++

[Qemu-devel] [PULL 09/16] tcg/i386: Remove expansion for missing minmax

2019-05-22 Thread Richard Henderson
This is now handled by code within tcg-op-vec.c. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 37 - 1 file changed, 37 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index ffcafb1e14..569a2c2120 100644 ---

[Qemu-devel] [PULL 14/16] tcg/aarch64: Build vector immediates with two insns

2019-05-22 Thread Richard Henderson
Use MOVI+ORR or MVNI+BIC in order to build some vector constants, as opposed to dropping them to the constant pool. This includes all 16-bit constants and a similar set of 32-bit constants. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 47 ++

[Qemu-devel] [PULL 04/16] tcg: Add support for vector compare select

2019-05-22 Thread Richard Henderson
Perform a per-element conditional move. This combination operation is easier to implement on some host vector units than plain cmp+bitsel. Omit the usual gvec interface, as this is intended to be used by target-specific gvec expansion call-backs. Signed-off-by: Richard Henderson --- tcg/aarch64

[Qemu-devel] [PULL 05/16] tcg: Introduce do_op3_nofail for vector expansion

2019-05-22 Thread Richard Henderson
This makes do_op3 match do_op2 in allowing for failure, and thus fall back expansions. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 45 +++-- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c ind

[Qemu-devel] [PULL 00/16] tcg queued patches

2019-05-22 Thread Richard Henderson
The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-201

[Qemu-devel] [PULL 06/16] tcg: Expand vector minmax using cmp+cmpsel

2019-05-22 Thread Richard Henderson
Provide a generic fallback for the min/max operations. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 004a34935b..501d9630a2 100644 --- a/tcg/tcg-op-vec.c ++

[Qemu-devel] [PULL 02/16] tcg: Fix missing checks and clears in tcg_gen_gvec_dup_mem

2019-05-22 Thread Richard Henderson
The paths through tcg_gen_dup_mem_vec and through MO_128 were missing the check_size_align. The path through MO_128 was also missing the expand_clr. This last was not visible because the only user is ARM SVE, which would set oprsz == maxsz, and not require the clear. Fix by adding the check_size

[Qemu-devel] [PULL 03/16] tcg: Add support for vector bitwise select

2019-05-22 Thread Richard Henderson
This operation performs d = (b & a) | (c & ~a), and is present on a majority of host vector units. Include gvec expanders. Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 2 ++ tcg/aarch64/tcg-target.h | 1 + tcg/i386/tcg-target.h| 1 + tcg/tcg-op-gvec.h

[Qemu-devel] [PULL 01/16] tcg/i386: Fix dupi/dupm for avx1 and 32-bit hosts

2019-05-22 Thread Richard Henderson
The VBROADCASTSD instruction only allows %ymm registers as destination. Rather than forcing VEX.L and writing to the entire 256-bit register, revert to using MOVDDUP with an %xmm register. This is sufficient for an avx1 host since we do not support TCG_TYPE_V256 for that case. Also fix the 32-bit

Re: [Qemu-devel] [PULL v2 00/11] MIPS queue for May 19th, 2019 - v2

2019-05-22 Thread Aleksandar Markovic
On May 22, 2019 9:15 PM, "Aleksandar Markovic" < aleksandar.marko...@rt-rk.com> wrote: > > From: Aleksandar Markovic > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 1

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Aleksandar Markovic
On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > > > > - Original Message - > > From: "Eduardo Habkost" > > To: "Philippe Mathieu-Daudé" > > Cc: qemu-devel@nongnu.org, "Aleksandar Rikalo" , "Aleksandar Markovic" > > , "Aleksandar Markovic" < amarko...@wavecomp.com>, "Cleber Rosa" , > > "

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Cleber Rosa
- Original Message - > From: "Eduardo Habkost" > To: "Philippe Mathieu-Daudé" > Cc: qemu-devel@nongnu.org, "Aleksandar Rikalo" , > "Aleksandar Markovic" > , "Aleksandar Markovic" > , "Cleber Rosa" , > "Aurelien Jarno" , "Wainer dos Santos Moschetta" > > Sent: Wednesday, May 22, 201

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-22 Thread Peter Maydell
On Wed, 22 May 2019 at 15:22, Laszlo Ersek wrote: > This is very interesting. I had obviously tested booting > "bios-tables-test.aarch64.iso.qcow2" against "edk2-aarch64-code.fd", > using TCG, on my x86_64 laptop. (And, I've run the above exact command > just now, at commit a4f667b67149 -- it work

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-22 Thread Eduardo Habkost
On Tue, May 21, 2019 at 01:19:06AM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > It was a rainy week-end here, so I invested it to automatize some > of my MIPS tests. > > The BootLinuxSshTest is not Global warming friendly, it is not > meant to run on a CI system but rather on a workstation prev

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread Peter Maydell
On Wed, 22 May 2019 at 20:02, John Snow wrote: > > > > On 5/22/19 4:49 AM, Peter Maydell wrote: > > On Tue, 21 May 2019 at 21:07, John Snow wrote: > >> > >> Sphinx, through Pygments, does not like annotated json examples very > >> much. In some versions of Sphinx (1.7), it will render the non-jso

Re: [Qemu-devel] [PATCH v2 2/2] Boot Linux Console Test: add a test for the Raspberry Pi 2

2019-05-22 Thread Cleber Rosa
- Original Message - > From: "Eduardo Habkost" > To: "Philippe Mathieu-Daudé" > Cc: qemu-devel@nongnu.org, "Cleber Rosa" , "Peter Maydell" > , > qemu-...@nongnu.org, "Philippe Mathieu-Daudé" , "Andrew > Baumann" > Sent: Wednesday, May 22, 2019 4:52:34 PM > Subject: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH v2 2/2] Boot Linux Console Test: add a test for the Raspberry Pi 2

2019-05-22 Thread Eduardo Habkost
On Wed, Mar 13, 2019 at 12:45:41AM +0100, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Similar to the x86_64/pc test, it boots a Linux kernel on a raspi2 > board and verify the serial is working. > > If ARM is a target being built, "make check-acceptance" will > automatically

Re: [Qemu-devel] [PATCH 4/4] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-22 Thread Eduardo Habkost
On Tue, May 21, 2019 at 10:18:10AM +0200, Aleksandar Markovic wrote: > On May 21, 2019 1:19 AM, "Philippe Mathieu-Daudé" wrote: > > > > This tests boot a full VM and check the serial console until > > the SSH daemon is running, then start a SSH session and run > > some commands. > > > > This test

Re: [Qemu-devel] [PATCH v14 1/1] qcow2: skip writing zero buffers to empty COW areas

2019-05-22 Thread Max Reitz
On 16.05.19 16:27, Anton Nefedov wrote: > If COW areas of the newly allocated clusters are zeroes on the backing > image, efficient bdrv_write_zeroes(flags=BDRV_REQ_NO_FALLBACK) can be > used on the whole cluster instead of writing explicit zero buffers later > in perform_cow(). > > iotest 060: >

[Qemu-devel] [PULL v2 11/11] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-22 Thread Aleksandar Markovic
From: Philippe Mathieu-Daudé This tests boot a full VM and check the serial console until the SSH daemon is running, then start a SSH session and run some commands. This test can be run using: $ avocado --show=ssh run -t arch:mips tests/acceptance/linux_ssh_mips_malta.py ssh: Entering inter

[Qemu-devel] [PULL v2 08/11] hw/mips: Use object_initialize() on MIPSCPSState

2019-05-22 Thread Aleksandar Markovic
From: Philippe Mathieu-Daudé Initialize the MIPSCPSState with object_initialize() instead of object_new(). This will allow us to add it as children of the machine container. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Reviewed-by: Paolo Bonzini Message-Id: <201905

[Qemu-devel] [PULL v2 09/11] hw/mips: Use object_initialize_child for correct reference counting

2019-05-22 Thread Aleksandar Markovic
From: Philippe Mathieu-Daudé As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the

[Qemu-devel] [PULL v2 06/11] target/mips: Refactor and fix COPY_U. instructions

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic The old version of the helper for the COPY_U. MSA instructions has been replaced with four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic Signed-off-by: Aleksandar Markovic

Re: [Qemu-devel] [PATCH v3 0/8] block: Ignore loosening perm restrictions failures

2019-05-22 Thread Eric Blake
On 5/22/19 1:37 PM, Max Reitz wrote: >> I don't know if there is an easy way to warn for normal users, but >> silence the warnings if run under test setups to keep 'make check' >> output unchanged (I know we've silenced warnings in the past when we >> detect we are running qtest, but this isn't ne

[Qemu-devel] [PULL v2 10/11] mips: Decide to map PAGE_EXEC in map_address

2019-05-22 Thread Aleksandar Markovic
From: Jakub Jermář This commit addresses QEMU Bug #1825311: mips_cpu_handle_mmu_fault renders all accessed pages executable It allows finer-grained control over whether the accessed page should be executable by moving the decision to the underlying map_address function, which has more informa

[Qemu-devel] [PULL v2 03/11] target/mips: Fix MSA instructions LD. on big endian host

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic Fix the case when the host is a big endian machine, and change the approach toward LD. instruction helpers. Signed-off-by: Mateja Marjanovic Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Message-Id: <1554212605-16457-2-git-send-email-mateja.marjan

[Qemu-devel] [PULL v2 02/11] target/mips: Make the results of MOD_. the same as on hardware

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic MSA instructions MOD_. when dividing by zero, didn't return the same value when executed on a referent hardware (FPGA MIPS 64 r6, little endian) and when executed on QEMU, which is not a real bug, because the result when dividing by zero is UNPREDICTABLE [1] (page 255, 256

[Qemu-devel] [PULL 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes

2019-05-22 Thread Richard Henderson
We can always get EINTR for read; /dev/urandom is no exception. Rearrange the order of tests for likelihood; allow degenerate buflen==0 case to perform a no-op zero-length read. This means that the normal success path is a straight line with a single test for success. Reviewed-by: Laurent Vivier

[Qemu-devel] [PULL 03/25] crypto: Reverse code blocks in random-platform.c

2019-05-22 Thread Richard Henderson
Use #ifdef _WIN32 instead of #ifndef _WIN32. This will make other tests easier to sequence. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 35 +-- 1

[Qemu-devel] [PULL 01/25] configure: Link test before auto-enabling crypto libraries

2019-05-22 Thread Richard Henderson
At least ubuntu 18.04 does not package static gnutls libraries. At least Fedora 30 does not ship static nettle and gcrypt libraries. Reviewed-by: Daniel P. Berrangé Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Message-Id: <20190510012458.22706-2-richard.hender...@linaro.org> Signed-off

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread John Snow
On 5/22/19 4:49 AM, Peter Maydell wrote: > On Tue, 21 May 2019 at 21:07, John Snow wrote: >> >> Sphinx, through Pygments, does not like annotated json examples very >> much. In some versions of Sphinx (1.7), it will render the non-json >> portions of code blocks in red, but in newer versions (2

[Qemu-devel] [PULL 06/25] crypto: Use getrandom for qcrypto_random_bytes

2019-05-22 Thread Richard Henderson
Prefer it to direct use of /dev/urandom. Reviewed-by: Laurent Vivier Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 37 - configure| 18 +- 2 files changed, 49 insertions(+), 6

[Qemu-devel] [PULL 08/25] ui/vnc: Split out authentication_failed

2019-05-22 Thread Richard Henderson
There were 3 copies of this code, one of which used the wrong data size for the failure indicator. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- ui/vnc.c | 37 +++

[Qemu-devel] [PULL 07/25] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-05-22 Thread Richard Henderson
Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c |

[Qemu-devel] [PULL v2 07/11] target/mips: Refactor and fix INSERT. instructions

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic The old version of the helper for the INSERT. MSA instructions has been replaced with four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic Signed-off-by: Aleksandar Markovic

[Qemu-devel] [PULL 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail

2019-05-22 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Review

[Qemu-devel] [PULL 10/25] util: Add qemu_guest_getrandom and associated routines

2019-05-22 Thread Richard Henderson
This routine is intended to produce high-quality random numbers to the guest. Normally, such numbers are crypto quality from the host, but a command-line option can force the use of a fully deterministic sequence for use while debugging. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-

[Qemu-devel] [PULL v2 05/11] target/mips: Refactor and fix COPY_S. instructions

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic The old version of the helper for the COPY_S. MSA instructions has been replaced with four helpers that don't use switch, and change the endianness of the given index, when executed on a big endian host. Signed-off-by: Mateja Marjanovic Signed-off-by: Aleksandar Markovic

[Qemu-devel] [PULL 16/25] linux-user: Remove srand call

2019-05-22 Thread Richard Henderson
We no longer use rand() within linux-user. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/main.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 66c909a1a6..689bcf436d 1

[Qemu-devel] [PULL 11/25] cpus: Initialize pseudo-random seeds for all guest cpus

2019-05-22 Thread Richard Henderson
When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created; which is a no-op unless the subsystem is in deterministic mode. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: D

[Qemu-devel] [PULL v2 04/11] target/mips: Fix MSA instructions ST. on big endian host

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic Fix the case when the host is a big endian machine, and change the approach toward ST. instruction helpers. Signed-off-by: Mateja Marjanovic Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Message-Id: <1554212605-16457-3-git-send-email-mateja.marjan

[Qemu-devel] [PULL v2 00/11] MIPS queue for May 19th, 2019 - v2

2019-05-22 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) are available in the git repository at: https://github.com/AMarkovic/qemu tag

[Qemu-devel] [PULL 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys

2019-05-22 Thread Richard Henderson
Use a better interface for random numbers than rand() * 3. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/aarch64/target_syscall.h | 2 -- linux-user/aarch64/cpu_loop.c | 29 ++- linux-user/syscall.

[Qemu-devel] [PULL 12/25] linux-user: Initialize pseudo-random seeds for all guest cpus

2019-05-22 Thread Richard Henderson
When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created during clone; which is a no-op unless the subsystem is in deterministic mode. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé S

[Qemu-devel] [PULL 00/25] Add qemu_getrandom and ARMv8.5-RNG etc

2019-05-22 Thread Richard Henderson
0/qemu.git tags/pull-rng-20190522 for you to fetch changes up to 369fd5ca66810b2ddb16e23a497eabe59385eceb: target/i386: Implement CPUID_EXT_RDRAND (2019-05-22 12:38:54 -0400) Introduce qemu_guest_getrandom. Use qemu_guest_getran

[Qemu-devel] [PULL v2 01/11] target/mips: Make the results of DIV_. the same as on hardware

2019-05-22 Thread Aleksandar Markovic
From: Mateja Marjanovic MSA instructions DIV_. when dividing by zero, didn't return the same value when executed on a referent hardware (FPGA MIPS 64 r6, little endian) and when executed on QEMU, which is not a real bug, because the result when dividing by zero is UNPREDICTABLE [1] (page 141, 142

[Qemu-devel] [PULL 21/25] target/arm: Put all PAC keys into a structure

2019-05-22 Thread Richard Henderson
This allows us to use a single syscall to initialize them all. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/cpu.h | 12 +++- linux-user/aarch64/cpu_loop.c | 6 +- linux-user/syscall.c | 10 +++

[Qemu-devel] [PULL 22/25] target/arm: Implement ARMv8.5-RNG

2019-05-22 Thread Richard Henderson
Use the newly introduced infrastructure for guest random numbers. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h| 5 + target/arm/cpu64.c | 1 + target/arm/helper.c | 44 3 files changed, 50 insertions(+)

[Qemu-devel] [PULL 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom

2019-05-22 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/misc/exynos4210_rng.c | 11 --- 1 file changed, 4 insertions(+),

[Qemu-devel] [PULL 02/25] build: Link user-only with crypto random number objects

2019-05-22 Thread Richard Henderson
For user-only, we require only the random number bits of the crypto subsystem. Rename crypto-aes-obj-y to crypto-user-obj-y, and add the random number objects, plus init.o to handle any extra stuff the crypto library requires. Move the crypto libraries from libs_softmmu and libs_tools to LIBS, so

[Qemu-devel] [PULL 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init

2019-05-22 Thread Richard Henderson
Avoids leaking the /dev/urandom fd into any child processes. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cr

[Qemu-devel] [Bug 1826422] Re: Regression: QEMU 4.0 hangs the host (*bisect included*)

2019-05-22 Thread Alex Williamson
Just to provide an update, patches are posted to revert this change in both the q35 4.1 machine type for the next release as well as introduce a q35 4.0.1 machine type making the same change for 4.0-stable. References: https://patchwork.ozlabs.org/patch/1099695/ https://patchwork.ozlabs.org/patch/

[Qemu-devel] [PULL 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail

2019-05-22 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of error_abort directly. Reviewed-by: Laurent Vivier Reviewed-by: Joel Stanley Signed-off-by: Richard Henderson --- hw/misc/nrf51_rng.c | 4 ++

[Qemu-devel] [PULL 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-05-22 Thread Richard Henderson
Use a better interface for random numbers than rand(). Fail gracefully if for some reason we cannot use the crypto system. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- ui/vnc.c | 22 +++---

[Qemu-devel] [PULL 23/25] target/ppc: Use gen_io_start/end around DARN

2019-05-22 Thread Richard Henderson
Generating a random number counts as I/O, as it cannot be replayed and produce the same results. Acked-by: David Gibson Reviewed-by: Laurent Vivier Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/ppc/translate.c | 21 +++-- 1 file changed, 15 insertions

[Qemu-devel] [PULL 25/25] target/i386: Implement CPUID_EXT_RDRAND

2019-05-22 Thread Richard Henderson
We now have an interface for guest visible random numbers. Reviewed-by: Eduardo Habkost Signed-off-by: Richard Henderson --- target/i386/helper.h | 2 ++ target/i386/cpu.c| 5 ++-- target/i386/int_helper.c | 21 ++ target/i386/translate.c | 62

[Qemu-devel] [PULL 19/25] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail

2019-05-22 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL 13/25] linux-user: Call qcrypto_init if not using -seed

2019-05-22 Thread Richard Henderson
When not using -seed, we will use the crypto subsystem for random numbers. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/main.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/li

[Qemu-devel] [PATCH 3/5] linux-user: Add functionality for tracking target signal mask

2019-05-22 Thread Aleksandar Markovic
From: Miloš Stojanović Add two inline functions that work with the signal set of the target. target_sigdelset() removes a signal from target_sigset_t. target_sigorset() creates a union of two target_sigset_t. These functions will be used for introducing support for tracking the target signal se

[Qemu-devel] [PULL 24/25] target/ppc: Use qemu_guest_getrandom for DARN

2019-05-22 Thread Richard Henderson
We now have an interface for guest visible random numbers. Acked-by: David Gibson Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/target/ppc/in

[Qemu-devel] [PULL 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM

2019-05-22 Thread Richard Henderson
Use a better interface for random numbers than rand * 16. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/elfload.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfl

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-22 Thread Richard Henderson
On 5/22/19 2:16 PM, David Hildenbrand wrote: > On 22.05.19 17:59, Richard Henderson wrote: >> On Wed, 22 May 2019 at 07:16, David Hildenbrand wrote: Also plausible. I guess it would be good to know, anyway. >>> >>> I'll dump the parameters when booting Linux. My gut feeling is that the >>> c

  1   2   3   4   >