Re: [Qemu-devel] Patch causing qemu-system-ppc to crash

2019-05-23 Thread Mark Cave-Ayland
On 24/05/2019 03:48, Programmingkid wrote: > Recently I have noticed that qemu-system-ppc is crashing while booting up my > Mac OS X VM. A bit of git bisecting shows this is the patch that causes this > issue: > > commit 1e262b49b5331441f697461e4305fe06719758a7 > Author: Richard Henderson > Da

Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-23 Thread Mark Cave-Ayland
On 22/05/2019 07:10, David Gibson wrote: > On Wed, May 22, 2019 at 05:37:47AM +0100, Mark Cave-Ayland wrote: >> On 22/05/2019 01:49, David Gibson wrote: >> >>> On Wed, May 22, 2019 at 06:11:12AM +1000, Anton Blanchard wrote: Hi, > I've now had a bit of time to look through this and I

[Qemu-devel] [PATCH v2] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-23 Thread Mark Cave-Ayland
From: Anton Blanchard During the conversion these instructions were incorrectly treated as stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() helpers for VSR register access") Signed-off-by: Anton Blanchard Review

[Qemu-devel] [PATCH 19/20] hw/i386/pc: Rename pc_build_feature_control() as generic fw_cfg_build_*

2019-05-23 Thread Philippe Mathieu-Daudé
Now that the pc_build_feature_control_file() function has been refactored to not depend of PC specific types, rename it to a more generic name. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[Qemu-devel] [PATCH 18/20] hw/i386/pc: Let pc_build_feature_control() take a MachineState argument

2019-05-23 Thread Philippe Mathieu-Daudé
Let the pc_build_feature_control_file() function take a generic MachineState argument. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 0db0ba3893..0ff2cea

[Qemu-devel] [PATCH 17/20] hw/i386/pc: Let pc_build_feature_control() take a FWCfgState argument

2019-05-23 Thread Philippe Mathieu-Daudé
Pass the FWCfgState object by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH 16/20] hw/i386/pc: Rename pc_build_smbios() as generic fw_cfg_build_smbios()

2019-05-23 Thread Philippe Mathieu-Daudé
Now that the pc_build_smbios() function has been refactored to not depend of PC specific types, rename it to a more generic name. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.

[Qemu-devel] [PATCH 10/20] hw/i386/pc: Pass the boot_cpus value by argument

2019-05-23 Thread Philippe Mathieu-Daudé
The boot_cpus is used once. Pass it by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.

[Qemu-devel] [PATCH 15/20] hw/i386/pc: Let pc_build_smbios() take a generic MachineState argument

2019-05-23 Thread Philippe Mathieu-Daudé
Let the pc_build_smbios() function take a generic MachineState argument. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b029aee6c7..a79b344eb5 100644 ---

[Qemu-devel] [PATCH 06/20] hw/i386/pc: Use e820_get_num_entries() to access e820_entries

2019-05-23 Thread Philippe Mathieu-Daudé
To be able to extract the e820* code out of this file (in the next patch), access e820_entries with its correct helper. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index ac8343c728..2e19504

[Qemu-devel] [PATCH 14/20] hw/i386/pc: Let pc_build_smbios() take a FWCfgState argument

2019-05-23 Thread Philippe Mathieu-Daudé
Pass the FWCfgState object by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c in

[Qemu-devel] [PATCH 04/20] hw/i386/pc: Add the E820Type enum type

2019-05-23 Thread Philippe Mathieu-Daudé
This ensure we won't use an incorrect value. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 12 +++- include/hw/i386/pc.h | 16 ++-- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 1245028dd6..ac8343c728 100

[Qemu-devel] [PATCH 09/20] hw/i386/pc: Rename bochs_bios_init() more generic as x86_create_fw_cfg()

2019-05-23 Thread Philippe Mathieu-Daudé
The bochs_bios_init() is not restricted to the Bochs BIOS and is useful to other BIOS. Rename it to be more generic. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386

[Qemu-devel] [PATCH 13/20] hw/i386/pc: Let fw_cfg_init() use the generic MachineState

2019-05-23 Thread Philippe Mathieu-Daudé
We removed the PCMachineState access, we can now let the fw_cfg_init() function to take a generic MachineState object. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i38

[Qemu-devel] [PATCH 07/20] hw/i386/pc: Extract e820 memory layout code

2019-05-23 Thread Philippe Mathieu-Daudé
Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/Makefile.objs| 2 +- hw/i386/e820_memory_layout.c | 62 + hw/i386/e820_memory_layout.h | 76 hw/i386/pc.c | 64 +-

[Qemu-devel] [PATCH 03/20] hw/i386/pc: Let e820_add_entry() return a ssize_t type

2019-05-23 Thread Philippe Mathieu-Daudé
e820_add_entry() returns an array size on success, or a negative value on error. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 2 +- include/hw/i386/pc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index df8600ac24..124502

[Qemu-devel] [PATCH 20/20] hw/i386/pc: Extract the x86 generic fw_cfg code

2019-05-23 Thread Philippe Mathieu-Daudé
Extract all the functions that are not PC-machine specific into the (arch-specific) fw_cfg.c file. This will allow other X86-machine to re-use these functions. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg.c | 135 +++

[Qemu-devel] [PATCH 12/20] hw/i386/pc: Pass the CPUArchIdList array by argument

2019-05-23 Thread Philippe Mathieu-Daudé
Pass the CPUArchIdList array by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/pc.c b/hw/i

[Qemu-devel] [PATCH 01/20] hw/i386/pc: Use unsigned type to index arrays

2019-05-23 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 5 +++-- include/hw/i386/pc.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2632b73f80..fc38b59d2d 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -870,7 +870,7 @@ static vo

[Qemu-devel] [PATCH 05/20] hw/i386/pc: Add documentation to the e820_*() functions

2019-05-23 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 10e77a40ce..95bf3278f2 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i38

[Qemu-devel] [PATCH 11/20] hw/i386/pc: Pass the apic_id_limit value by argument

2019-05-23 Thread Philippe Mathieu-Daudé
Pass the apic_id_limit value by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH 08/20] hw/i386/pc: Use address_space_memory in place

2019-05-23 Thread Philippe Mathieu-Daudé
The address_space_memory variable is used once. Use it in place and remove the argument. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index fc22779ac1..a39

[Qemu-devel] [PATCH 00/20] hw/i386/pc: Do not restrict the fw_cfg functions to the PC machine

2019-05-23 Thread Philippe Mathieu-Daudé
Hi, This is my take at salvaging some NEMU good work. Samuel worked in adding the fw_cfg device to the x86-virt NEMU machine. This series is inspired by NEMU's commit 3cb92d080835 [*] and adapted to upstream style. The result makes the upstream codebase more modularizable. There are very little lo

[Qemu-devel] [PATCH 02/20] hw/i386/pc: Use size_t type to hold/return a size of array

2019-05-23 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 4 ++-- include/hw/i386/pc.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index fc38b59d2d..df8600ac24 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -104,7 +104,7 @@ struct e82

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190522

2019-05-23 Thread David Gibson
On Fri, May 24, 2019 at 12:17:25PM +1000, David Gibson wrote: > On Fri, May 24, 2019 at 10:46:16AM +1000, David Gibson wrote: > > On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > > > On Wed, 22 May 2019 at 05:46, David Gibson > > > wrote: > > > > > > > > The following changes sinc

Re: [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device

2019-05-23 Thread Pankaj Gupta
> > On 5/23/19 5:24 AM, Pankaj Gupta wrote: > > This is the implementation of virtio-pmem device. Support will require > > machine changes for the architectures that will support it, so it will > > not yet be compiled. It can be unlocked with VIRTIO_PMEM_SUPPORTED per > > machine and disabled gl

Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 10:15 AM, Markus Armbruster wrote: > Make target check-source is for checking the source code itself. For > now, there's just one such check, make target check-headers. It > checks basic header sanity: for each header "FOO.h", test whether > > #include "qemu/osdep.h" > #in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/8] spapr: Clean up dt creation for PCI buses

2019-05-23 Thread Alexey Kardashevskiy
On 23/05/2019 15:29, David Gibson wrote: > Device nodes for PCI bridges (both host and P2P) describe both the bridge > device itself and the bus hanging off it, handling of this is a bit of a > mess. > > spapr_dt_pci_device() has a few things it only adds for non-bridges, but > always adds #add

Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused headers inclusion

2019-05-23 Thread Marcel Apfelbaum
Hi Markus, On 5/23/19 6:24 PM, Markus Armbruster wrote: Looks stuck. Let's try qemu-trivial. Thanks, that is a great idea. I didn't want to send a single-patch pull request, especially while another is waiting for reviews. Anyway, trivial queue can be used indeed. Thanks, Marcel Yuval Sh

Re: [Qemu-devel] [RFC v4 3/7] Makefile: Rename targets for make recursion

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 10:15 AM, Markus Armbruster wrote: > We make a few sub-directories recursively, in particular > $(TARGET_DIRS). > > For goal "all", we do it the nice way: "all" has a prerequisite > subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make > recursively. Behaves nicely with -j an

Re: [Qemu-devel] [PATCH] hw/rdma: Add support for GID state changes for non-qmp frameworks

2019-05-23 Thread Marcel Apfelbaum
Hi Yuval, On 5/5/19 1:55 PM, Yuval Shaia wrote: Any GID change in guest must be propogate to host. This is already done by firing QMP event to managment system such as libvirt which in turn will update the host with the relevant change. Agreed, *any* management software can do that. When

Re: [Qemu-devel] [RFC v4 2/7] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 10:15 AM, Markus Armbruster wrote: > When commit df2943ba3c7 moved "rm -f qemu-options.def" from distclean > to clean, it also added "rm -f $$d/qemu-options.def" to the for d in > $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken > rm. > > Signed-off-by: Markus Armbrus

Re: [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status

2019-05-23 Thread Philippe Mathieu-Daudé
Hi Markus, On 5/23/19 10:15 AM, Markus Armbruster wrote: > When commit bdf523e6923 made configure generate config.status, it > added a fallback to Makefile to smooth the transition, with a TODO > "code can be removed after QEMU 1.7." It's been more than five years. > Remove it. > > Signed-off-by

Re: [Qemu-devel] [PATCH 0/4] tests/docker: add podman support

2019-05-23 Thread Gerd Hoffmann
On Fri, May 24, 2019 at 01:40:07AM +0200, Marc-André Lureau wrote: > Hi, > > podman allows to run containers in a similar fashion as docker, but > without daemon or root privileges. Thank you podman! Well, I saw a rather dramatic increase on disk usage when running podman rootless. Looked like p

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190522

2019-05-23 Thread David Gibson
On Fri, May 24, 2019 at 10:46:16AM +1000, David Gibson wrote: > On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > > On Wed, 22 May 2019 at 05:46, David Gibson > > wrote: > > > > > > The following changes since commit > > > a4f667b6714916683408b983cfe0a615a725775f: > > > > > > Me

[Qemu-devel] [PATCH] BootLinuxConsoleTest: Test the RX-Virt machine

2019-05-23 Thread Philippe Mathieu-Daudé
Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are very quick tests: $ avocado run -t arch:rx tests/acceptance/boot_linux_co

Re: [Qemu-devel] [PULL 07/13] hw/char: RX62N serial communication interface (SCI)

2019-05-23 Thread Philippe Mathieu-Daudé
Hi Paolo, Marc-André, On 5/23/19 4:00 PM, Richard Henderson wrote: > From: Yoshinori Sato > > This module supported only non FIFO type. > Hardware manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > Signed-off-by: Yoshinori Sato > Reviewed-by

[Qemu-devel] Patch causing qemu-system-ppc to crash

2019-05-23 Thread Programmingkid
Recently I have noticed that qemu-system-ppc is crashing while booting up my Mac OS X VM. A bit of git bisecting shows this is the patch that causes this issue: commit 1e262b49b5331441f697461e4305fe06719758a7 Author: Richard Henderson Date: Mon Mar 18 12:02:54 2019 -0700 tcg/i386: Implem

Re: [Qemu-devel] [PULL 05/15] hw/ppc: Implement fw_cfg_arch_key_name()

2019-05-23 Thread David Gibson
On Thu, May 23, 2019 at 02:43:10PM +0200, Philippe Mathieu-Daudé wrote: > Implement fw_cfg_arch_key_name(), which returns the name of a > ppc-specific key. > > The fw_cfg device is used by the machine using OpenBIOS: > - 40p > - mac99 (oldworld) > - g3beige (newworld) > > Reviewed-by: Laszlo Erse

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190522

2019-05-23 Thread David Gibson
On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > On Wed, 22 May 2019 at 05:46, David Gibson > wrote: > > > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > > staging

[Qemu-devel] [PATCH 4/4] qemu-sockets: do not require configured ipv4/ipv6 address

2019-05-23 Thread Marc-André Lureau
podman containers without network don't have ipv4/ipv6 addresses other than loopback address. However, some of our tests require getaddrinfo("127.0.0.1") to succeed. Alternatively, we may want to treat 127.0.0.1 as a special case, to keep the AI_ADDRCONFIG convenience. Signed-off-by: Marc-André L

[Qemu-devel] [PATCH 2/4] tests/docker: add podman support

2019-05-23 Thread Marc-André Lureau
Allow to specify the container engine to run with ENGINE variable. By default, ENGINE=auto and will select either podman or docker. With current podman, we have to use a uidmap trick in order to be able to rw-share the ccache directory with the container user. With a user 1000, the default mappi

[Qemu-devel] [PATCH 3/4] docker: update fedora to f30

2019-05-23 Thread Marc-André Lureau
Released last month. Signed-off-by: Marc-André Lureau --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 69d4a7f5d7..1496b68ba1 100644 --- a/tests/do

[Qemu-devel] [PATCH 0/4] tests/docker: add podman support

2019-05-23 Thread Marc-André Lureau
Hi, podman allows to run containers in a similar fashion as docker, but without daemon or root privileges. Thank you podman! I haven't done extensive testing. Basic make docker-test rules work. There seems to be a few issues with permissions at run time (podman ps fails), but that seems not direc

[Qemu-devel] [PATCH 1/4] docker.py: add podman support

2019-05-23 Thread Marc-André Lureau
Add a --engine option to select either docker, podman or auto. Among other advantages, podman allows to run rootless & daemonless containers, fortunately sharing compatible CLI with docker. Signed-off-by: Marc-André Lureau --- tests/docker/docker.py | 43 +---

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Eduardo Habkost
On Thu, May 23, 2019 at 09:28:00AM -0400, Cleber Rosa wrote: > > > - Original Message - > > From: "Philippe Mathieu-Daudé" > > To: "Eduardo Habkost" , "Cleber Rosa" > > > > Cc: "Aleksandar Rikalo" , "Philippe Mathieu-Daudé" > > , "Wainer dos Santos > > Moschetta" , qemu-devel@nongnu.o

Re: [Qemu-devel] [PATCH] i386: Fix nested SVM on older Opterons

2019-05-23 Thread Eduardo Habkost
On Thu, May 23, 2019 at 07:57:38PM +0100, Dr. David Alan Gilbert wrote: > * Bernhard M. Wiedemann (bwiedem...@suse.de) wrote: > > Without this patch, a VM on a Opteron G3 host will have the svm flag, but > > the kvm-amd module fails to load in there, complaining that it needs > > cpuid 0x800a >

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Aleksandar Markovic
On May 22, 2019 3:50 PM, "Cornelia Huck" wrote: > > On Wed, 22 May 2019 15:22:23 +0200 > Aleksandar Markovic wrote: > > > On May 22, 2019 2:24 PM, "Cornelia Huck" wrote: > > > > > > On Wed, 22 May 2019 14:10:39 +0200 > > > Laurent Vivier wrote: > > > > > > > On 22/05/2019 14:07, Cornelia Huck w

[Qemu-devel] [PATCH v2 2/2] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson --- Makefile | 1 + disas.c| 3 +++ target/s390x/cpu.c | 4 3 files changed, 8 insertions(+) diff --git a/Makefile b/Makefil

[Qemu-devel] [PATCH v2 0/2] Update capstone module

2019-05-23 Thread Richard Henderson
There has recently been some good progress in the upstream capstone repository, syncing the instruction sets from the (further) upstream llvm. In particular, there are Power9 and System z13 instructions. Both of which were missing from our current snapshot and from our (ancient) binutils opcodes s

[Qemu-devel] [PATCH v2 1/2] capstone: Update to master

2019-05-23 Thread Richard Henderson
Update to fbb20ea83c5a. Choose this over the 4.0.1 tag because master now includes the s390x z13 vector opcodes. Acked-by: David Hildenbrand Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- capstone | 2 +- configure | 2 +- 2 files

[Qemu-devel] [RISU v3 09/11] i386: Add avx512 state to reginfo_t

2019-05-23 Thread Jan Bobek
From: Richard Henderson The state expected for a given test must be specifically requested with the --xfeatures=mask command-line argument. This is recorded with the saved state so that it is obvious if the apprentice is given a different argument. Any features beyond what are present on the ru

[Qemu-devel] [RISU v3 11/11] risu_reginfo_i386: rework --xfeatures value parsing

2019-05-23 Thread Jan Bobek
Have the --xfeatures option accept "sse", "avx" and "avx512" in addition to a plain numerical value, purely for users' convenience. Don't fail silently when an incorrect value is specified, to avoid confusion. Suggested-by: Richard Henderson Signed-off-by: Jan Bobek --- risu_reginfo_i386.c | 19

[Qemu-devel] [RISU v3 07/11] test_i386: change syntax from nasm to gas

2019-05-23 Thread Jan Bobek
This allows us to drop dependency on NASM and build the test image with GCC only. Adds support for x86_64, too. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- Makefile| 3 +++ test_i386.S | 41 + test_i38

[Qemu-devel] [RISU v3 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names

2019-05-23 Thread Jan Bobek
The original code used "magic numbers", which made it unclear in some places. Include a reference to the Intel manual where the constants' meaning is discussed. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- risu_reginfo_i386.c | 48 +++

[Qemu-devel] [RISU v3 04/11] risu_reginfo_i386: implement arch-specific reginfo interface

2019-05-23 Thread Jan Bobek
CPU-specific code in risu_reginfo_* is expected to define and export the following symbols: - arch_long_opts, arch_extra_help, process_arch_opt - reginfo_size - reginfo_init - reginfo_is_eq - reginfo_dump, reginfo_dump_mismatch Make risu_reginfo_i386.c implement this interface; and while we're at

[Qemu-devel] [RISU v3 05/11] risu_i386: implement missing CPU-specific functions

2019-05-23 Thread Jan Bobek
risu_i386.c is expected to implement the following functions: - advance_pc - get_reginfo_paramreg, set_ucontext_paramreg - get_risuop - get_pc This patch adds the necessary code. We use EAX as the parameter register and opcode "UD1 %xxx,%eax" for triggering RISU actions. Suggested-by: Richard He

[Qemu-devel] [RISU v3 02/11] risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h

2019-05-23 Thread Jan Bobek
In order to build risu successfully for i386, we need files risu_reginfo_i386.{h,c}; this patch adds the former by extracting the relevant code from risu_i386.c. This patch is pure code motion; no functional changes were made. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-b

[Qemu-devel] [RISU v3 08/11] configure: add i386/x86_64 architectures

2019-05-23 Thread Jan Bobek
Now that i386 and x86_64 architectures are supported by RISU, we want to detect them and build RISU for them automatically. Suggested-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- configure | 10 ++ 1 file changed, 6 inserti

[Qemu-devel] [RISU v3 03/11] risu_i386: move reginfo-related code to risu_reginfo_i386.c

2019-05-23 Thread Jan Bobek
In order to build risu successfully for i386, we need files risu_reginfo_i386.{h,c}; this patch adds the latter by extracting the relevant code from risu_i386.c. This patch is pure code motion; no functional changes were made. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-b

[Qemu-devel] [RISU v3 01/11] Makefile: undefine the arch name symbol

2019-05-23 Thread Jan Bobek
At least GCC defines the symbol "i386" to 1 to signal the target platform. We need to use "i386" as an undefined symbol in order to correctly include risu_reginfo_i386.h from risu.h. Add an -U option to the build command to make sure the symbol remains undefined. Suggested-by: Richard Henderson R

[Qemu-devel] [RISU v3 06/11] risu_i386: remove old unused code

2019-05-23 Thread Jan Bobek
The code being removed is a remnant of the past implementation; it has since been replaced by its more powerful, architecture-independent counterpart in reginfo.c. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Jan Bobek --- risu_i386.c | 58

[Qemu-devel] [RISU v3 00/11] Support for i386/x86_64 with vector extensions

2019-05-23 Thread Jan Bobek
This patch series adds support for i386 and x86_64 architectures to RISU. Notably, vector registers (SSE, AVX, AVX-512) are supported for verification of the apprentice. This is V3 of the series posted in [1] and [2]. Changes is V3: - fix a matching bug caused by misplaced index multiplication [

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] spapr: Do not re-read the clock on pre_save handler on migration

2019-05-23 Thread Maxiwell S. Garcia
On Thu, May 23, 2019 at 09:29:52AM +1000, David Gibson wrote: > On Mon, May 20, 2019 at 05:43:40PM -0300, Maxiwell S. Garcia wrote: > > This handler was added in the commit: > > 42043e4f1241: spapr: clock should count only if vm is running > > > > In a scenario without migration, this pre_save h

Re: [Qemu-devel] [PATCH v2 11/28] MAINTAINERS: update for semihostings new home

2019-05-23 Thread Richard Henderson
On 5/23/19 6:25 AM, Alex Bennée wrote: > Seeing as I touched it I should at least keep an eye on it. > > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 17/28] tests/tcg/aarch64: add system boot.S

2019-05-23 Thread Richard Henderson
On 5/23/19 6:25 AM, Alex Bennée wrote: > This provides the bootstrap and low level helper functions for an > aarch64 kernel. We use semihosting to handle test output and exiting > the emulation. semihosting's parameter passing is a little funky so we > end up using the stack and pointing to that as

Re: [Qemu-devel] [PATCH v2 09/28] target/mips: only build mips-semi for softmmu

2019-05-23 Thread Richard Henderson
On 5/23/19 6:25 AM, Alex Bennée wrote: > The is_uhi gates all semihosting calls and always returns false for > CONFIG_USER_ONLY builds. There is no reason to build and link > mips-semi for these builds so lets fix that. > > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > Revie

Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source

2019-05-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/05/19 10:15, Markus Armbruster wrote: >> A large number of headers don't pass this test, by design or by >> accident. To keep things more manageable, exclude all headers outside >> include/ for now. > > A lot of these, either in include/ or outside, are _meant_ to b

Re: [Qemu-devel] [PATCH 00/15] block: AioContext management, part 2

2019-05-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190523160104.21258-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/15] block: AioContext management, part 2 Type: series Message-id: 20190523160104.21258

Re: [Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
On 5/23/19 3:26 PM, Richard Henderson wrote: > On 5/22/19 10:42 PM, Richard Henderson wrote: >> Enable s390x, aka SYSZ, in the git submodule build. >> Set the capstone parameters for both s390x host and guest. >> Install a skipdata hook to keep capstone in sync with the >> instruction stream for un

Re: [Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
On 5/22/19 10:42 PM, Richard Henderson wrote: > Enable s390x, aka SYSZ, in the git submodule build. > Set the capstone parameters for both s390x host and guest. > Install a skipdata hook to keep capstone in sync with the > instruction stream for unknown opcodes. > > Signed-off-by: Richard Henderso

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Richard Henderson
On 5/23/19 7:07 AM, Daniel P. Berrangé wrote: > On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote: >> Since v4.0, capstone.h has moved to . > NB this was a regression bug in capstone pkg-config file which has been > fixed upstream > >https://github.com/aquynh/capstone/pull/1276

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Laurent Vivier
On 23/05/2019 21:16, Alex Bennée wrote: > > Laurent Vivier writes: > >> On 23/05/2019 13:56, Cornelia Huck wrote: >>> On Wed, 22 May 2019 15:22:23 +0200 >>> Aleksandar Markovic wrote: >>> The alternative way of invoking via IPCV6 (else part of “ifdef __NR_MSGSND”) should work for MIPS

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Alex Bennée
Laurent Vivier writes: > On 23/05/2019 13:56, Cornelia Huck wrote: >> On Wed, 22 May 2019 15:22:23 +0200 >> Aleksandar Markovic wrote: >> >>> The alternative way of invoking via IPCV6 (else part of “ifdef >>> __NR_MSGSND”) should work for MIPS in the present stage of headers and >>> kernel. >>

Re: [Qemu-devel] [PATCH] i386: Fix nested SVM on older Opterons

2019-05-23 Thread Dr. David Alan Gilbert
* Bernhard M. Wiedemann (bwiedem...@suse.de) wrote: > Without this patch, a VM on a Opteron G3 host will have the svm flag, but > the kvm-amd module fails to load in there, complaining that it needs > cpuid 0x800a > > I have successfully built and tested this for 3+ years in production > on Op

[Qemu-devel] [PATCH] bios-tables-test: add diff allowed list

2019-05-23 Thread Michael S. Tsirkin
Expected table change is then handled like this: 1. add table to diff allowed list 2. change generating code (can be combined with 1) 3. maintainer runs a script to update expected + blows away allowed diff list Signed-off-by: Michael S. Tsirkin --- So I got tired of manual "remember to updat

Re: [Qemu-devel] [PATCH 2/4] qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h

2019-05-23 Thread Richard Henderson
On 5/23/19 10:35 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/ssh.c| 1 + > block/vvfat.c | 1 + > gdbstub.c | 2 ++ > hw/core/bus.c | 2 +- > hw/core/qdev-properties.c | 1 + > hw/s390x/s390-virtio-

Re: [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h

2019-05-23 Thread Richard Henderson
On 5/23/19 10:35 AM, Markus Armbruster wrote: > Other accelerators have their own headers: sysemu/hax.h, sysemu/hvf.h, > sysemu/kvm.h, sysemu/whpx.h. Only tcg_enabled() & friends sit in > qemu-common.h. This necessitates inclusion of qemu-common.h into > headers, which is against the rules spelle

Re: [Qemu-devel] Running linux on qemu omap

2019-05-23 Thread Aaro Koskinen
Hi, On Thu, May 23, 2019 at 02:00:41PM +0200, Philippe Mathieu-Daudé wrote: > On 5/23/19 1:27 PM, Thomas Huth wrote: > > On 22/05/2019 20.19, Aaro Koskinen wrote: > >> On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: > >>> qemu-system-arm -M help |grep OMAP > >>> cheetah

Re: [Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-23 Thread Philippe Mathieu-Daudé
On Thu, May 23, 2019 at 8:29 PM Philippe Mathieu-Daudé wrote: > On 5/23/19 7:54 PM, Laurent Vivier wrote: > > In current code, __NR_msgrcv and__NR_semtimedop are supposed to be > > defined if __NR_msgsnd is defined. > > > > But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining > >

Re: [Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 7:54 PM, Laurent Vivier wrote: > In current code, __NR_msgrcv and__NR_semtimedop are supposed to be > defined if __NR_msgsnd is defined. > > But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining > __NR_semtimedop and it breaks the QEMU build. > > __NR_semtimedop is def

Re: [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions

2019-05-23 Thread Richard Henderson
On 5/23/19 2:03 PM, Jan Bobek wrote: > I ran some experiments on my laptop's Intel(R) Core(TM) i5-4210U to > find out what actually happens. This CPU supports AVX (but not > AVX-512) and doesn't support XSAVEC, so I only looked at XSAVE and > XSAVEOPT (XSAVES is kernel-mode only). I found out that:

Re: [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions

2019-05-23 Thread Jan Bobek
On 5/21/19 12:49 PM, Richard Henderson wrote: > SSE2 is a mandatory part of the x86_64 ABI. > > I sincerely doubt we care about testing 32-bit that does not have SSE, but > even > then this patch set will not fail, as the kernel will not include the SSE > registers into the signal frame. It woul

Re: [Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-23 Thread John Snow
On 5/23/19 1:49 PM, Max Reitz wrote: > On 23.05.19 19:06, John Snow wrote: >> Instead of event_wait which looks for a single event, add an events_wait >> which can look for any number of events simultaneously. However, it >> will still only return one at a time, whichever happens first. >> >> Si

[Qemu-devel] [PATCH] linux-user: fix __NR_semtimedop undeclared error

2019-05-23 Thread Laurent Vivier
In current code, __NR_msgrcv and__NR_semtimedop are supposed to be defined if __NR_msgsnd is defined. But linux headers 5.2-rc1 for MIPS define __NR_msgsnd without defining __NR_semtimedop and it breaks the QEMU build. __NR_semtimedop is defined in asm-mips/unistd_n64.h and asm-mips/unistd_n32.h

Re: [Qemu-devel] [PATCH v3 0/5] blockdev-backup: don't check aio_context too early

2019-05-23 Thread Max Reitz
On 23.05.19 19:06, John Snow wrote: > See patch one's commit message for justification. > Patches 2-5 are for testing, because that's always how these things go. > > 001/5:[] [--] 'blockdev-backup: don't check aio_context too early' > 002/5:[0004] [FC] 'iotests.py: do not use infinite waits' >

Re: [Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-23 Thread Max Reitz
On 23.05.19 19:06, John Snow wrote: > Instead of event_wait which looks for a single event, add an events_wait > which can look for any number of events simultaneously. However, it > will still only return one at a time, whichever happens first. > > Signed-off-by: John Snow > --- > python/qemu/_

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Aleksandar Markovic
On May 23, 2019 7:27 PM, "Philippe Mathieu-Daudé" wrote: > > On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > > On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: > >>> From: "Aleksandar Markovic" > >>> On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > > From: "Eduardo Habkost" > > > > U

Re: [Qemu-devel] [PATCH v5 0/3] qemu-img: rebase: Improve/optimize rebase operation

2019-05-23 Thread Max Reitz
On 23.05.19 18:33, Sam Eiderman wrote: > This patch series aims to improve the speed of qemu-img rebase. > > 1. Mainly by removing unnecessary reads when rebasing on the same > chain. > 2. But also by minimizing the number of bdrv_open calls rebase > requires. > > v2: > > * Added m

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

2019-05-23 Thread Aleksandar Markovic
On May 23, 2019 6:51 PM, wrote: > > Patchew URL: https://patchew.org/QEMU/20190523144336.13960-1-laur...@vivier.eu/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20190523144336.13960-1-laur...@vivier.eu > Type: series

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

2019-05-23 Thread Max Reitz
On 17.05.19 16:50, Vladimir Sementsov-Ogievskiy wrote: > 10.04.2019 23:20, Max Reitz wrote: >> What bs->file and bs->backing mean depends on the node. For filter >> nodes, both signify a node that will eventually receive all R/W >> accesses. For format nodes, bs->file contains metadata and data,

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 7:11 PM, Aleksandar Markovic wrote: > On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: >>> From: "Aleksandar Markovic" >>> On May 22, 2019 11:46 PM, "Cleber Rosa" wrote: > From: "Eduardo Habkost" > > Until we actually have a mechanism to exclude the test case on > travis

[Qemu-devel] [PATCH v3 5/5] iotests: add iotest 250 for testing blockdev-backup across iothread contexts

2019-05-23 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/250 | 122 + tests/qemu-iotests/250.out | 119 tests/qemu-iotests/group | 1 + 3 files changed, 242 insertions(+) create mode 100755 tests/qemu-iotests/250 create mod

[Qemu-devel] [PATCH v3 3/5] QEMUMachine: add events_wait method

2019-05-23 Thread John Snow
Instead of event_wait which looks for a single event, add an events_wait which can look for any number of events simultaneously. However, it will still only return one at a time, whichever happens first. Signed-off-by: John Snow --- python/qemu/__init__.py | 69 +-

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Aleksandar Markovic
On May 23, 2019 3:45 PM, "Cleber Rosa" wrote: > > > > - Original Message - > > From: "Aleksandar Markovic" > > To: "Cleber Rosa" > > Cc: "Wainer dos Santos Moschetta" , "Aleksandar Markovic" , > > qemu-devel@nongnu.org, "Aleksandar Rikalo" , "Eduardo Habkost" , > > "Aurelien Jarno" , "Ph

[Qemu-devel] [PATCH v3 2/5] iotests.py: do not use infinite waits

2019-05-23 Thread John Snow
Cap waits to 60 seconds so that iotests can fail gracefully if something goes wrong. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 6

[Qemu-devel] [PATCH v3 0/5] blockdev-backup: don't check aio_context too early

2019-05-23 Thread John Snow
See patch one's commit message for justification. Patches 2-5 are for testing, because that's always how these things go. 001/5:[] [--] 'blockdev-backup: don't check aio_context too early' 002/5:[0004] [FC] 'iotests.py: do not use infinite waits' 003/5:[down] 'QEMUMachine: add events_wait

[Qemu-devel] [PATCH v3 4/5] iotests.py: rewrite run_job to be pickier

2019-05-23 Thread John Snow
Don't pull events out of the queue that don't belong to us; be choosier so that we can use this method to drive jobs that were launched by transactions that may have more jobs. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 48 +-- 1 file changed, 29

[Qemu-devel] [PATCH v3 1/5] blockdev-backup: don't check aio_context too early

2019-05-23 Thread John Snow
in blockdev_backup_prepare, we check to make sure that the target is associated with a compatible aio context. However, do_blockdev_backup is called later and has some logic to move the target to a compatible aio_context. The transaction version will fail certain commands needlessly early as a resu

Re: [Qemu-devel] [PATCH] vmstate: Add VMSTATE_OPAQUE to save/load complex data structures

2019-05-23 Thread Roman Kiryanov via Qemu-devel
Hi Dave, thank you for looking. > Can you give me an example of where you would use it? We use it in our host memory sharing device. I used the existing macros for all fields I could, but unfortunately some state does not fit into them. We use this new macro to save/load memory allocators (for no

  1   2   3   4   5   >