Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

Peter Maydell writes: > On Mon, 27 May 2019 at 08:52, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > Suggestions for how to restructure reset so this doesn't >> > happen are welcome... "reset follows the bus hierarchy" >> > works well in some places but is a bit weird in others >> >

Re: [Qemu-devel] [RFC v4 09/27] memory: Prepare for different kinds of IOMMU MR notifiers

On Mon, May 27, 2019 at 01:41:45PM +0200, Eric Auger wrote: [...] > @@ -3368,8 +3368,9 @@ static void vtd_address_space_unmap(VTDAddressSpace > *as, IOMMUNotifier *n) > { > IOMMUTLBEntry entry; > hwaddr size; > -hwaddr start = n->start; > -hwaddr end = n->end; > + (extra new

[Qemu-devel] [Bug 1777777] Re: arm9 clock pending (SP804)

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/177 Title: arm9 clock

[Qemu-devel] [Bug 1817846] Re: Qemu 3.1 Aarch64 TLBI VAE1, x0

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817846 Title: Qemu 3.1

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

On Tue, 28 May 2019 at 02:54, Michael S. Tsirkin wrote: > > On Mon, May 27, 2019 at 12:44:46PM +0200, Greg Kurz wrote: > > On Fri, 24 May 2019 19:56:06 +0800 > > Yongji Xie wrote: > > > > > On Fri, 24 May 2019 at 18:20, Greg Kurz wrote: > > > > > > > > On Mon, 20 May 2019 19:10:35 -0400 > > > >

Re: [Qemu-devel] [RFC v4 08/27] hw/vfio/common: Force nested if iommu requires it

On Mon, May 27, 2019 at 01:41:44PM +0200, Eric Auger wrote: > In case we detect the address space is translated by > a virtual IOMMU which requires nested stages, let's set up > the container with the VFIO_TYPE1_NESTING_IOMMU iommu_type. > > Signed-off-by: Eric Auger > > --- > > v2 -> v3: > -

Re: [Qemu-devel] [PATCH v2 2/5] i386/cpu: Consolidate die-id validity in smp context

On 2019/5/22 1:12, Dr. David Alan Gilbert wrote: * Like Xu (like...@linux.intel.com) wrote: Following the legacy smp check rules, the die_id validity is added to the same contexts as leagcy smp variables such as hmp_hotpluggable_cpus(), machine_set_cpu_numa_node(), cpu_slot_to_string() and

[Qemu-devel] [PATCH 4/4] migration/ram.c: multifd_send_state->count is not really used

Signed-off-by: Wei Yang --- migration/ram.c | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 5d31f7bd4c..c9a9f7489b 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -892,8 +892,6 @@ static int multifd_recv_unfill_packet(MultiFDRecvParams *p,

[Qemu-devel] [PATCH 3/4] migration/ram.c: MultiFDSendParams.sem_sync is not really used

Besides init and destroy, MultiFDSendParams.sem_sync is not really used. Signed-off-by: Wei Yang --- migration/ram.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index dcf4c54eb5..5d31f7bd4c 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -661,8

[Qemu-devel] [PATCH 2/4] migration/ram.c: use same type in MultiFDPages_t to define offsest

MultiFDPacket_t.offset is allocated to store MultiFDPages_t.offset. It would be better to use the same type. Signed-off-by: Wei Yang --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 4c60869226..dcf4c54eb5 100644 ---

[Qemu-devel] [PATCH 1/4] migration: multifd_save_setup always return 0

Signed-off-by: Wei Yang --- migration/migration.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index d0a0f68f11..3aae4f2734 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3336,12 +3336,7 @@ void

[Qemu-devel] [PATCH 0/4] Multifd Cleanup

Just found several small places for unused variables. Wei Yang (4): migration: multifd_save_setup always return 0 migration/ram.c: use same type in MultiFDPages_t to define offsest migration/ram.c: MultiFDSendParams.sem_sync is not really used migration/ram.c: multifd_send_state->count is

Re: [Qemu-devel] [PATCH] hw/i386/pc: check apci hotplug capability before nvdimm's

On Mon, May 27, 2019 at 02:21:14PM +0200, Igor Mammedov wrote: >On Thu, 11 Apr 2019 15:17:39 +0800 >Wei Yang wrote: > >> pc_memory_pre_plug() is called during hotplug for both pc-dimm and >> nvdimm. This is more proper to check apci hotplug capability before >> check nvdimm specific capability.

Re: [Qemu-devel] [PATCH] ppc/pnv: introduce new skiboot platform properties

On Mon, May 27, 2019 at 09:17:49AM +0200, Cédric Le Goater wrote: > Newer skiboots (after 6.3) support QEMU platforms that have > characteristics closer to real OpenPOWER systems. The CPU type is used > to define the BMC drivers: Aspeed AST2400 for POWER8 processors and > AST2500 for POWER9s. > >

Re: [Qemu-devel] [PATCH v2] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

On Fri, May 24, 2019 at 07:53:45AM +0100, Mark Cave-Ayland wrote: > From: Anton Blanchard > > During the conversion these instructions were incorrectly treated as > stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and

Re: [Qemu-devel] [PATCH] ppc/pnv: add dummy XSCOM registers for PRD initialization

On Mon, May 27, 2019 at 09:17:22AM +0200, Cédric Le Goater wrote: > PRD (Processor recovery diagnostics) is a service available on > OpenPower systems. The opal-prd daemon initializes the PowerPC > Processor through the XSCOM bus and then waits for hardware diagnostic > events. > > Signed-off-by:

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

On Fri, May 24, 2019 at 12:19:09PM +0200, Greg Kurz wrote: > On Mon, 20 May 2019 19:10:35 -0400 > "Michael S. Tsirkin" wrote: > > > From: Xie Yongji > > > > The virtio 1.0 transitional devices support driver uses the device > > before setting the DRIVER_OK status bit. So we introduce a started

Re: [Qemu-devel] [PATCH v3 0/7] Kconfig dependencies for MIPS machines (but Malta)

Hi Aleksandar, On 5/27/19 8:31 PM, Aleksandar Markovic wrote: > > On Mar 11, 2019 1:56 AM, "Philippe Mathieu-Daudé" > wrote: >> >> Express the MIPS machine dependencies with Kconfig. >> >> Due to its complexity, the Malta board fill follow in a different >> series. >>

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

On Mon, May 27, 2019 at 10:41:57AM -0400, Michael S. Tsirkin wrote: >On Mon, May 27, 2019 at 10:34:23AM +0800, Wei Yang wrote: >> On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: >> >arm and i386 has almost the same function acpi_add_rom_blob(), except >> >giving different FWCfgCallback

Re: [Qemu-devel] [PATCH] The m68k gdbstub SR reg request doesnt include Condition-Codes

Patchew URL: https://patchew.org/QEMU/20190526074527.33632-1-lucienmp_antis...@yahoo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] The m68k gdbstub SR reg request doesnt include Condition-Codes Message-id:

Re: [Qemu-devel] [PATCH v3 0/8] Add support for io_uring

Patchew URL: https://patchew.org/QEMU/20190527080327.10780-1-mehta.aar...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190527080327.10780-1-mehta.aar...@gmail.com Type: series Subject: [Qemu-devel] [PATCH v3 0/8]

Re: [Qemu-devel] How do we do user input bitmap properties?

On Mon, May 27, 2019 at 06:29:44PM +0200, Andrea Bolognani wrote: > On Fri, 2019-05-24 at 15:24 -0300, Eduardo Habkost wrote: > > On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > > > [...] the above looks good to > > > me as a general direction, but note that you'll have to

Re: [Qemu-devel] Running linux on qemu omap

On Mon, 27 May 2019 at 16:56, Guenter Roeck wrote: > I'd be happy to use a different (supported) branch, but the Linaro branch > was the only one I could find that supports those boards. Unfortunately, > qemu changed so much since 2.3 that it is all but impossible to merge > the code into

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

On Mon, 27 May 2019 at 08:52, Markus Armbruster wrote: > > Peter Maydell writes: > > Suggestions for how to restructure reset so this doesn't > > happen are welcome... "reset follows the bus hierarchy" > > works well in some places but is a bit weird in others > > (for SoC containers and the

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

On Mon, May 27, 2019 at 12:44:46PM +0200, Greg Kurz wrote: > On Fri, 24 May 2019 19:56:06 +0800 > Yongji Xie wrote: > > > On Fri, 24 May 2019 at 18:20, Greg Kurz wrote: > > > > > > On Mon, 20 May 2019 19:10:35 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > From: Xie Yongji > > > > >

Re: [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

On Fri, May 17, 2019 at 09:45:17AM +0200, Igor Mammedov wrote: > '-numa mem' option has a number of issues and mgmt often defaults > to it. Unfortunately it's no possible to replace it with an alternative > '-numa memdev' without breaking migration compatibility. What's possible > though is to

Re: [Qemu-devel] [PATCH 0/3] hw/microblaze: Kconfig cleanup

On 27/05/19 18:10, Philippe Mathieu-Daudé wrote: >>> >> Queued, thanks. > I don't see these patches in your queue merged on "Fri 17 May", are > you planning to include them in your next batch? Yes, thanks. Paolo

Re: [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

Igor Mammedov writes: > '-numa mem' option has a number of issues and mgmt often defaults > to it. Unfortunately it's no possible to replace it with an alternative > '-numa memdev' without breaking migration compatibility. To be precise: -numa node,mem=... and -numa node,memdev=... Correct? >

Re: [Qemu-devel] [PATCH v3 0/7] Kconfig dependencies for MIPS machines (but Malta)

On Mar 11, 2019 1:56 AM, "Philippe Mathieu-Daudé" wrote: > > Express the MIPS machine dependencies with Kconfig. > > Due to its complexity, the Malta board fill follow in a different > series. > Philippe, What would be the status of this series? I am willing to integrate all this, including all

Re: [Qemu-devel] [PATCH v3 3/6] qmp: qmp_qom_list_properties(): ignore empty string options

Igor Mammedov writes: > Current QAPI semantics return empty "" string in case string property > value hasn't been set (i.e. NULL). Do not show initial value in this > case in "qom-list-properties" command output to reduce clutter. > > Signed-off-by: Igor Mammedov > --- > qmp.c | 12

Re: [Qemu-devel] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial property values

Igor Mammedov writes: > Add in the command output object's property values right after creation > (i.e. state of the object returned by object_new() or equivalent). > > Follow up patch will add machine property 'numa-mem-supported', which > would allow mgmt to introspect which machine types

Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly

On May 27, 2019 5:44 PM, "Yoshinori Sato" wrote: > > On Fri, 24 May 2019 00:07:57 +0900, > Richard Henderson wrote: > > > > Here's a sample of the new output, taken from u-boot.bin: > > > > IN: > > 0xfff8000a: fb 12 00 01 00 00 mov.l #0x0100, r1 > > 0xfff80010: fb 32 f0 13 00 00

Re: [Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

On 24.04.19 09:49, Sam Eiderman wrote: > Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in > QEMU). > > This format was lacking in the following: > > * Grain directory (L1) and grain table (L2) entries were 32-bit, > allowing access to only 2TB (slightly less) of

Re: [Qemu-devel] [PATCH v2 27/28] tests/qemu-iotests: re-format output to for make check-block

On 27.05.19 18:20, Alex Bennée wrote: > > Max Reitz writes: > >> On 23.05.19 12:25, Alex Bennée wrote: >>> This attempts to clean-up the output to better match the output of the >>> rest of the QEMU check system when called with -makecheck. This includes: >>> >>> - formatting as " TEST

Re: [Qemu-devel] [PATCH v2 2/9] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID

Roman Kagan writes: > On Fri, May 17, 2019 at 04:19:17PM +0200, Vitaly Kuznetsov wrote: >> KVM now supports reporting supported Hyper-V features through CPUID >> (KVM_GET_SUPPORTED_HV_CPUID ioctl). Going forward, this is going to be >> the only way to announce new functionality and this has

Re: [Qemu-devel] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

Igor Mammedov writes: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet (ex: property being inspected during preconfig time). Reproduced: $ qemu-system-x86_64 -nodefaults -S -display none -preconfig -qmp stdio {"QMP":

Re: [Qemu-devel] How do we do user input bitmap properties?

On Fri, 2019-05-24 at 15:24 -0300, Eduardo Habkost wrote: > On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > > [...] the above looks good to > > me as a general direction, but note that you'll have to implement at > > the very least the query-cpu-model-expansion QMP command for

Re: [Qemu-devel] [PATCH v2 27/28] tests/qemu-iotests: re-format output to for make check-block

Max Reitz writes: > On 23.05.19 12:25, Alex Bennée wrote: >> This attempts to clean-up the output to better match the output of the >> rest of the QEMU check system when called with -makecheck. This includes: >> >> - formatting as " TESTiotest-FMT: nnn" >> - only dumping config on

[Qemu-devel] Status update on Meson features needed by QEMU

Hi all, if everything goes according to plan, Meson 0.51.0 (out in a couple of weeks) should have everything needed for QEMU. I am not sure whether I'll have time to attempt a partial conversion to have something to show, but anyway this is a status update. On 06/03/19 19:12, Paolo Bonzini

Re: [Qemu-devel] [PATCH 0/3] hw/microblaze: Kconfig cleanup

Hi Paolo, On Tue, Apr 30, 2019 at 9:55 PM Paolo Bonzini wrote: > > On 27/04/19 16:14, Philippe Mathieu-Daudé wrote: > > Hi Edgar, Peter, > > > > Few fixes while cleaning Kconfig, trying to optimize builds. > > > > Regards, > > > > Phil. > > > > Philippe Mathieu-Daudé (3): > > hw/Kconfig: Move

Re: [Qemu-devel] [PATCH for-4.1 0/2] hw/alpha: Add the CY82C693UB southbridge in Kconfig

On 5/8/19 10:16 PM, Philippe Mathieu-Daudé wrote: > Paolo, Thomas, > > On 4/29/19 1:29 PM, Philippe Mathieu-Daudé wrote: >> CC'ing Thomas who is a Kconfig expert. >> >> On 3/17/19 12:44 AM, Philippe Mathieu-Daudé wrote: >>> Explicit the CY82C693UB southbridge used by the 264DP. >>> >>> Philippe

Re: [Qemu-devel] Running linux on qemu omap

On 5/27/19 5:56 PM, Guenter Roeck wrote: > On 5/26/19 11:32 PM, Tony Lindgren wrote: >> Hi, >> >> * Philippe Mathieu-Daudé [190523 12:01]: >>> What I use as reference for testing ARM boards [*] is the work of >>> Guenter Roeck: >>>

Re: [Qemu-devel] Running linux on qemu omap

On 5/26/19 11:32 PM, Tony Lindgren wrote: Hi, * Philippe Mathieu-Daudé [190523 12:01]: What I use as reference for testing ARM boards [*] is the work of Guenter Roeck: https://github.com/groeck/linux-build-test/blob/master/rootfs/arm/run-qemu-arm.sh I think Guenter also has

Re: [Qemu-devel] [PATCH v2 2/9] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID

On Fri, May 17, 2019 at 04:19:17PM +0200, Vitaly Kuznetsov wrote: > KVM now supports reporting supported Hyper-V features through CPUID > (KVM_GET_SUPPORTED_HV_CPUID ioctl). Going forward, this is going to be > the only way to announce new functionality and this has already happened > with Direct

Re: [Qemu-devel] [PATCH v2 1/9] i386/kvm: convert hyperv enlightenments properties from bools to bits

On Fri, May 17, 2019 at 04:19:16PM +0200, Vitaly Kuznetsov wrote: > Representing Hyper-V properties as bits will allow us to check features > and dependencies between them in a natural way. > > Suggested-by: Roman Kagan > Signed-off-by: Vitaly Kuznetsov > --- > hw/i386/pc.c | 3 +- >

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

On Mon, 27 May 2019 21:04:38 +0800 Yongji Xie wrote: > On Mon, 27 May 2019 at 18:44, Greg Kurz wrote: > > > > On Fri, 24 May 2019 19:56:06 +0800 > > Yongji Xie wrote: > > > > > On Fri, 24 May 2019 at 18:20, Greg Kurz wrote: > > > > > > > > On Mon, 20 May 2019 19:10:35 -0400 > > > >

Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly

On Fri, 24 May 2019 00:07:57 +0900, Richard Henderson wrote: > > Here's a sample of the new output, taken from u-boot.bin: > > IN: > 0xfff8000a: fb 12 00 01 00 00 mov.l #0x0100, r1 > 0xfff80010: fb 32 f0 13 00 00 mov.l #0x13f0, r3 > 0xfff80016: 43 13

Re: [Qemu-devel] [PATCH 5/6] target/rx: Collect all bytes during disassembly

On Fri, 24 May 2019 00:08:02 +0900, Richard Henderson wrote: > > Collected, to be used in the next patch. > > Signed-off-by: Richard Henderson Reviewed-by: Yoshinori Sato > --- > target/rx/disas.c | 62 --- > 1 file changed, 42 insertions(+), 20

Re: [Qemu-devel] [PATCH 2/6] target/rx: Replace operand with prt_ldmi in disassembler

On Fri, 24 May 2019 00:07:59 +0900, Richard Henderson wrote: > > This has consistency with prt_ri(). It loads all data before > beginning output. It uses exactly one call to prt() to emit > the full instruction. > > Signed-off-by: Richard Henderson Reviewed-by: Yoshinori Sato > --- >

Re: [Qemu-devel] [PATCH 4/6] target/rx: Emit all disassembly in one prt()

On Fri, 24 May 2019 00:08:01 +0900, Richard Henderson wrote: > > Many of the multi-part prints have been eliminated by previous > patches. Eliminate the rest of them. > > Signed-off-by: Richard Henderson Reviewed-by: Yoshinori Sato > --- > target/rx/disas.c | 75

Re: [Qemu-devel] [PATCH 6/6] target/rx: Dump bytes for each insn during disassembly

On Fri, 24 May 2019 00:08:03 +0900, Richard Henderson wrote: > > There are so many different forms of each RX instruction > that it will be very useful to be able to look at the bytes > to see on which path a bug may lie. > > Signed-off-by: Richard Henderson Reviewed-by: Yoshinori Sato > ---

Re: [Qemu-devel] [PATCH 3/6] target/rx: Use prt_ldmi for XCHG_mr disassembly

On Fri, 24 May 2019 00:08:00 +0900, Richard Henderson wrote: > > Note that the ld == 3 case handled by prt_ldmi is decoded as > XCHG_rr and cannot appear here. > > Signed-off-by: Richard Henderson Reviewed-by: Yoshinori Sato > --- > target/rx/disas.c | 8 +--- > 1 file changed, 1

Re: [Qemu-devel] [PATCH 1/6] target/rx: Disassemble rx_index_addr into a string

On Fri, 24 May 2019 00:07:58 +0900, Richard Henderson wrote: > > We were eliding all zero indexes. It is only ld==0 that does > not have an index in the instruction. This also allows us to > avoid breaking the final print into multiple pieces. > > Signed-off-by: Richard Henderson Reviewed-by:

Re: [Qemu-devel] [PATCH v4 00/20] monitor: add asynchronous command type

Hi On Mon, May 27, 2019 at 3:23 PM Markus Armbruster wrote: > > Gerd Hoffmann writes: > > > On Mon, May 27, 2019 at 10:18:42AM +0200, Markus Armbruster wrote: > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Thu, May 23, 2019 at 9:52 AM Markus Armbruster > >> > wrote: > >> >>

[Qemu-devel] [Bug 1829682] Re: QEMU PPC SYSTEM regression - 3.1.0 and GIT - Fail to boot AIX

** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Greg Kurz (gkurz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1829682 Title: QEMU PPC

Re: [Qemu-devel] [PATCH v2 2/2] block: avoid recursive block_status call if possible

On 08.04.19 18:26, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where are holes

Re: [Qemu-devel] Failing qemu-iotest 211 with -vdi

On 28.04.19 17:43, Thomas Huth wrote: > QEMU iotest 211 is failing for me, too, when I run it with -vdi: > > tests/qemu-iotests$ ./check -vdi 211 > QEMU -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > -nodefaults -machine accel=qtest >

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

On Mon, May 27, 2019 at 10:34:23AM +0800, Wei Yang wrote: > On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: > >arm and i386 has almost the same function acpi_add_rom_blob(), except > >giving different FWCfgCallback function. > > > >This patch moves acpi_add_rom_blob() to utils.c by

Re: [Qemu-devel] [PATCH] ui/curses: Fix build with -m32

Max Reitz, le lun. 27 mai 2019 16:25:40 +0200, a ecrit: > wchar_t may resolve to be an unsigned long on 32-bit architectures. > Using the %x conversion specifier will then give a compiler warning: > > ui/curses.c: In function ‘get_ucs’: > ui/curses.c:492:49: error: format ‘%x’ expects argument of

[Qemu-devel] [PATCH] ui/curses: Fix build with -m32

wchar_t may resolve to be an unsigned long on 32-bit architectures. Using the %x conversion specifier will then give a compiler warning: ui/curses.c: In function ‘get_ucs’: ui/curses.c:492:49: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘wchar_t’ {aka

Re: [Qemu-devel] [RFC v4 00/27] vSMMUv3/pSMMUv3 2 stage VFIO integration

Patchew URL: https://patchew.org/QEMU/20190527114203.2762-1-eric.au...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit

Re: [Qemu-devel] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

On May 27, 2019 3:32 PM, "Aleksandar Markovic" wrote: > > > On May 26, 2019 1:07 AM, "Laurent Vivier" wrote: > > > > If you want to test the machine, it doesn't yet boot a MacROM, but you can > > boot a linux kernel from the command line. > > > > You can install your own disk using

Re: [Qemu-devel] [PATCH] qcow2-bitmap: initialize bitmap directory alignment

On 27/05/2019 16:28, Max Reitz wrote: > On 27.05.19 14:52, Andrey Shinkevich wrote: >> Valgrind detects multiple issues in QEMU iotests when the memory is >> used without being initialized. Valgrind may dump lots of unnecessary >> reports what makes the memory issue analysis harder.

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

On Mon 27 May 2019 03:44:59 PM CEST, Anton Nefedov wrote: >> I think in general optimizing for SSDs should probably be the >> default. HDDs are slow anyway, so whoever uses them probably doesn’t >> care about performance too much anyway...? Whereas people using SSDs >> probably do. But as I

Re: [Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

On 27/05/2019 14:50, Igor Mammedov wrote: > On Mon, 27 May 2019 08:55:49 +0200 > Laurent Vivier wrote: > >> On 24/05/2019 22:14, Eduardo Habkost wrote: >>> On Fri, May 24, 2019 at 04:39:12PM +0200, Laurent Vivier wrote: On 24/05/2019 16:10, Igor Mammedov wrote: > On Fri, 24 May 2019

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

On 27.05.19 15:44, Anton Nefedov wrote: > On 27/5/2019 3:57 PM, Max Reitz wrote: >> On 27.05.19 14:37, Alberto Garcia wrote: >>> On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: On 26.05.19 17:08, Alberto Garcia wrote: > On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: >>

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

On 27/5/2019 3:57 PM, Max Reitz wrote: > On 27.05.19 14:37, Alberto Garcia wrote: >> On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: >>> On 26.05.19 17:08, Alberto Garcia wrote: On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: > +## > +# @ImageRotationalInfo: > +#

Re: [Qemu-devel] [PATCH v2 27/28] tests/qemu-iotests: re-format output to for make check-block

On 23.05.19 12:25, Alex Bennée wrote: > This attempts to clean-up the output to better match the output of the > rest of the QEMU check system when called with -makecheck. This includes: > > - formatting as " TESTiotest-FMT: nnn" > - only dumping config on failure (when -makecheck

Re: [Qemu-devel] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

On 27/05/2019 15:32, Aleksandar Markovic wrote: > > On May 26, 2019 1:07 AM, "Laurent Vivier" > wrote: > > > > If you want to test the machine, it doesn't yet boot a MacROM, but > you can > > boot a linux kernel from the command line. > > > > You can install your

Re: [Qemu-devel] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

On May 26, 2019 1:07 AM, "Laurent Vivier" wrote: > > If you want to test the machine, it doesn't yet boot a MacROM, but you can > boot a linux kernel from the command line. > > You can install your own disk using debian-installer with: > > ./qemu-system-m68k \ > -M q800 \ > -serial

Re: [Qemu-devel] [PATCH] qcow2-bitmap: initialize bitmap directory alignment

On 27.05.19 14:52, Andrey Shinkevich wrote: > Valgrind detects multiple issues in QEMU iotests when the memory is > used without being initialized. Valgrind may dump lots of unnecessary > reports what makes the memory issue analysis harder. Particularly, > that is true for the aligned bitmap

Re: [Qemu-devel] [PATCH] event_match: always match on None value

On 24.05.19 20:02, John Snow wrote: > Before, event_match didn't always recurse if the event value was not a > dictionary, and would instead check for equality immediately. > > By delaying equality checking to post-recursion, we can allow leaf > values like "5" to match "None" and take advantage

Re: [Qemu-devel] [PATCH v4 00/20] monitor: add asynchronous command type

Gerd Hoffmann writes: > On Mon, May 27, 2019 at 10:18:42AM +0200, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Thu, May 23, 2019 at 9:52 AM Markus Armbruster >> > wrote: >> >> I'm not sure how asynchronous commands could support reconnect and >> >> resume. >>

Re: [Qemu-devel] [PATCH v3 0/5] blockdev-backup: don't check aio_context too early

On 23.05.19 19:06, John Snow wrote: > See patch one's commit message for justification. > Patches 2-5 are for testing, because that's always how these things go. > > 001/5:[] [--] 'blockdev-backup: don't check aio_context too early' > 002/5:[0004] [FC] 'iotests.py: do not use infinite waits'

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

It's been three years, let's examine how things have evolved. I'm using commit db3d11ee3f0, which is a bit behind current master, just so I can apply my "[PATCH 0/4] Cleanups around qemu-common.h" cleanly. Markus Armbruster writes: [...] > = The status quo and why I hate it = > > I've seen

Re: [Qemu-devel] [PULL v2 04/36] virtio: Introduce started flag to VirtioDevice

On Mon, 27 May 2019 at 18:44, Greg Kurz wrote: > > On Fri, 24 May 2019 19:56:06 +0800 > Yongji Xie wrote: > > > On Fri, 24 May 2019 at 18:20, Greg Kurz wrote: > > > > > > On Mon, 20 May 2019 19:10:35 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > From: Xie Yongji > > > > > > > > The

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

On 27.05.19 14:37, Alberto Garcia wrote: > On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: >> On 26.05.19 17:08, Alberto Garcia wrote: >>> On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: +## +# @ImageRotationalInfo: +# +# Indicates whether an image is stored on a

[Qemu-devel] [PATCH] qcow2-bitmap: initialize bitmap directory alignment

Valgrind detects multiple issues in QEMU iotests when the memory is used without being initialized. Valgrind may dump lots of unnecessary reports what makes the memory issue analysis harder. Particularly, that is true for the aligned bitmap directory and can be seen while running the iotest #169.

Re: [Qemu-devel] Question about wrong ram-node0 reference

We find only one VM aborted among at least 20 VMs with the same configuration. And this problem does not reproduce yet... (Be aware of reproduce is importance to figure out the problem, we already tried to add more VMs to reproduce, but no results yet.) The qemu cmdline is as follows:

Re: [Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

On Mon, 27 May 2019 08:55:49 +0200 Laurent Vivier wrote: > On 24/05/2019 22:14, Eduardo Habkost wrote: > > On Fri, May 24, 2019 at 04:39:12PM +0200, Laurent Vivier wrote: > >> On 24/05/2019 16:10, Igor Mammedov wrote: > >>> On Fri, 24 May 2019 12:35:21 +0200 > >>> Laurent Vivier wrote: >

Re: [Qemu-devel] Running linux on qemu omap

Hi, * Philippe Mathieu-Daudé [190523 12:01]: > What I use as reference for testing ARM boards [*] is the work of > Guenter Roeck: > https://github.com/groeck/linux-build-test/blob/master/rootfs/arm/run-qemu-arm.sh I think Guenter also has v2.3.50-local-linaro branch in his github repo that has

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

On Mon 27 May 2019 02:16:53 PM CEST, Max Reitz wrote: > On 26.05.19 17:08, Alberto Garcia wrote: >> On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: >>> +## >>> +# @ImageRotationalInfo: >>> +# >>> +# Indicates whether an image is stored on a rotating disk or not. >>> +# >>> +# @solid-state:

Re: [Qemu-devel] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

On 25/05/2019 23:50, Laurent Vivier wrote: > If you want to test the machine, it doesn't yet boot a MacROM, but you can > boot a linux kernel from the command line. > > You can install your own disk using debian-installer with: > > ./qemu-system-m68k \ > -M q800 \ > -serial none

Re: [Qemu-devel] [PATCH] hw/i386/pc: check apci hotplug capability before nvdimm's

On Thu, 11 Apr 2019 15:17:39 +0800 Wei Yang wrote: > pc_memory_pre_plug() is called during hotplug for both pc-dimm and > nvdimm. This is more proper to check apci hotplug capability before > check nvdimm specific capability. not sure what this about. Currently we are checking if ACPI is enabled

Re: [Qemu-devel] [RFC 1/3] block: Add ImageRotationalInfo

On 26.05.19 17:08, Alberto Garcia wrote: > On Fri 24 May 2019 07:28:10 PM CEST, Max Reitz wrote: >> +## >> +# @ImageRotationalInfo: >> +# >> +# Indicates whether an image is stored on a rotating disk or not. >> +# >> +# @solid-state: Image is stored on a solid-state drive >> +# >> +# @rotating:

Re: [Qemu-devel] [PATCH v14 0/1] qcow2: cluster space preallocation

On 26.05.19 17:01, Alberto Garcia wrote: > On Fri 24 May 2019 03:56:21 PM CEST, Max Reitz wrote: >>> +---+---+--+---+--+--+ >>> | file|before| after| gain | >>> +---+---+--+---+--+--+ >>> |ssd|

[Qemu-devel] [RFC v4 27/27] vfio-pci: Implement the DMA fault handler

Whenever the eventfd is triggered, we retrieve the DMA faults from the mmapped fault region and inject them in the iommu memory region. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 53 +++ hw/vfio/pci.h | 1 + 2 files changed, 54 insertions(+)

[Qemu-devel] [RFC v4 26/27] vfio-pci: Set up fault regions

We setup two fault regions: the producer fault is read-only from the user space perspective. It is composed of the fault queue (mmappable) and a header written by the kernel, located in a separate page. The consumer fault is write-only from the user-space perspective. Signed-off-by: Eric Auger

[Qemu-devel] [RFC v4 24/27] hw/arm/smmuv3: Implement fault injection

We convert iommu_fault structs received from the kernel into the data struct used by the emulation code and record the evnts into the virtual event queue. Signed-off-by: Eric Auger --- v3 -> v4: - fix compil issue on mingw Exhaustive mapping remains to be done --- hw/arm/smmuv3.c | 71

[Qemu-devel] [Bug 1829682] Re: QEMU PPC SYSTEM regression - 3.1.0 and GIT - Fail to boot AIX

According to git bisect : git bisect bad c24ba3d0a34f68ad2c6bf1a15bc43770005f6cc0 is the first bad commit commit c24ba3d0a34f68ad2c6bf1a15bc43770005f6cc0 Author: Laurent Vivier Date: Wed Dec 19 17:35:41 2018 +0100 spapr: Add H-Call H_HOME_NODE_ASSOCIATIVITY H_HOME_NODE_ASSOCIATIVITY

[Qemu-devel] [RFC v4 23/27] memory: Introduce IOMMU Memory Region inject_faults API

This new API allows to inject @count iommu_faults into the IOMMU memory region. Signed-off-by: Eric Auger --- include/exec/memory.h | 25 + memory.c | 10 ++ 2 files changed, 35 insertions(+) diff --git a/include/exec/memory.h

[Qemu-devel] [RFC v4 19/27] hw/vfio/common: Introduce helpers to DMA map/unmap a RAM section

Let's introduce two helpers that allow to DMA map/unmap a RAM section. Those helpers will be called for nested stage setup in another call site. Also the vfio_listener_region_add/del() structure may be clearer. Signed-off-by: Eric Auger --- hw/vfio/common.c | 178

[Qemu-devel] [RFC v4 21/27] hw/vfio/common: Register a MAP notifier for MSI binding

Instantiate a MAP notifier to register the MSI stage 1 binding (gIOVA -> gDB) to the host. This allows the host to build a nested mapping towards the physical doorbell: guest IOVA -> guest Doorbell -> physical doorbell. Stage1 Stage 2 The unregistration is done on VFIO

[Qemu-devel] [RFC v4 18/27] hw/vfio/common: Introduce hostwin_from_range helper

Let's introduce a hostwin_from_range() helper that returns the hostwin encapsulating an IOVA range or NULL if non is found. This improves the readibility of callers and removes the usage of hostwin_found. Signed-off-by: Eric Auger --- hw/vfio/common.c | 37 ++---

[Qemu-devel] [RFC v4 20/27] hw/vfio/common: Setup nested stage mappings

In nested mode, legacy vfio_iommu_map_notify cannot be used as there is no "caching" mode and we do not trap on map. On Intel, vfio_iommu_map_notify was used to DMA map the RAM through the host single stage. With nested mode, we need to setup the stage 2 and the stage 1 separately. This patch

[Qemu-devel] [RFC v4 25/27] vfio-pci: register handler for iommu fault

We use the VFIO_PCI_DMA_FAULT_IRQ_INDEX "irq" index to set/unset a notifier for physical DMA faults. The associated eventfd is triggered, in nested mode, whenever a fault is detected at IOMMU physical level. As this is the first use of this new IRQ index, also handle it in irq_to_str() in case

[Qemu-devel] [RFC v4 22/27] vfio-pci: Expose MSI stage 1 bindings to the host

When the guest is exposed with a virtual IOMMU that translates MSIs, the guest allocates an IOVA (gIOVA) that maps the virtual doorbell (gDB). In nested mode, when the MSI is setup, we pass this stage1 mapping to the host so that it can use this stage1 binding to create a nested stage translating

[Qemu-devel] [RFC v4 16/27] hw/arm/smmuv3: Notify on config changes

In case IOMMU config notifiers are attached to the IOMMU memory region, we execute them, passing as argument the iommu_pasid_table_config struct updated with the new viommu translation config. Config notifiers are called on STE changes. At physical level, they translate into CMD_CFGI_STE_*

[Qemu-devel] [RFC v4 15/27] hw/arm/smmuv3: Fill the IOTLBEntry leaf field on NH_VA invalidation

Let's propagate the leaf attribute throughout the invalidation path. This hint is used to reduce the scope of the invalidations to the last level of translation. Not enforcing it induces large performance penalties in nested mode. Signed-off-by: Eric Auger --- hw/arm/smmuv3.c | 16

[Qemu-devel] [RFC v4 17/27] hw/vfio/common: Introduce vfio_alloc_guest_iommu helper

Soon this code will be called several times. So let's introduce an helper. Signed-off-by: Eric Auger --- hw/vfio/common.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 75fb568f95..7df8b92563 100644 ---

  1   2   >