Re: [Qemu-devel] [PULL 57/60] target/ppc: add HV support for POWER9

2019-07-01 Thread Philippe Mathieu-Daudé
On 7/1/19 7:04 AM, David Gibson wrote: > On Fri, Jun 28, 2019 at 03:20:32PM +0200, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 3/12/19 8:58 PM, Cédric Le Goater wrote: >>> On 3/12/19 8:30 PM, Cleber Rosa wrote: > From: "Cleber Rosa" > Sent: Tuesday, March 12, 2019 3:14:09 PM >

Re: [Qemu-devel] [PATCH v2 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-01 Thread Daniel P . Berrangé
On Mon, Jul 01, 2019 at 02:39:03PM +0530, P J P wrote: > From: Prasad J Pandit > > Move repeating error handling sequence in parse_acl_file routine > to an 'err' label. > > Signed-off-by: Prasad J Pandit > --- > qemu-bridge-helper.c | 18 -- > 1 file changed, 8 insertions(+),

Re: [Qemu-devel] [PATCH v2 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-01 Thread Daniel P . Berrangé
On Mon, Jul 01, 2019 at 02:39:02PM +0530, P J P wrote: > From: Prasad J Pandit > > The interface names in qemu-bridge-helper are defined to be > of size IFNAMSIZ(=16), including the terminating null('\0') byte. > The same is applied to interface names read from 'bridge.conf' > file to form ACLs

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7

2019-07-01 Thread Philippe Mathieu-Daudé
On 6/30/19 5:13 PM, Jan Kiszka wrote: > From: Jan Kiszka > > No reason to deny this type. Maybe add "As the A15, it supports the EL2/V7VE features."? > > Signed-off-by: Jan Kiszka > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c >

[Qemu-devel] [PATCH v2 3/6] hw/vfio/common: Do not replay IOMMU mappings in nested case

2019-07-01 Thread Eric Auger
In nested mode, the stage 1 translation tables are owned by the guest and there is no caching on host side. So there is no need to replay the mappings. As of today, the SMMUv3 nested mode is not yet implemented and there is no functional VFIO integration without. But keeping the replay call would

Re: [Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMSIZ

2019-07-01 Thread Daniel P . Berrangé
On Mon, Jul 01, 2019 at 02:39:04PM +0530, P J P wrote: > From: Prasad J Pandit > > The interface name in Linux interface request struct 'ifreq' > OR in qemu-bridge-helper is defined to be of size IFNAMSIZ(=16), > including the terminating null('\0') byte. > > QEMU tap device, while invoking

[Qemu-devel] [PATCH v2 6/6] hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations

2019-07-01 Thread Eric Auger
An IOVA/ASID invalidation is notified to all IOMMU Memory Regions through smmuv3_inv_notifiers_iova/smmuv3_notify_iova. When the notification occurs it is possible that some of the PCIe devices associated to the notified regions do not have a valid stream table entry. In that case we output a

[Qemu-devel] [PATCH 4/3] pcie: minor cleanups for slot control/status

2019-07-01 Thread Michael S. Tsirkin
Rename function arguments to make intent clearer. Better documentation for slot control logic. Suggested-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie.h | 3 ++- hw/pci/pcie.c | 17 +++-- 2 files changed, 13 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH v2 5/6] hw/arm/smmuv3: Log a guest error when decoding an invalid STE

2019-07-01 Thread Eric Auger
Log a guest error when encountering an invalid STE. Signed-off-by: Eric Auger --- hw/arm/smmuv3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 384c02cb91..2e270a0f07 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -320,6 +320,7 @@ static int

[Qemu-devel] [PATCH v2 1/6] memory: Remove unused memory_region_iommu_replay_all()

2019-07-01 Thread Eric Auger
memory_region_iommu_replay_all is not used. Remove it. Signed-off-by: Eric Auger Reported-by: Peter Maydell --- include/exec/memory.h | 10 -- memory.c | 9 - 2 files changed, 19 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

[Qemu-devel] [PATCH v2 4/6] hw/arm/smmuv3: Advertise VFIO_NESTED

2019-07-01 Thread Eric Auger
Virtual SMMUv3 requires physical nested stages for VFIO integration. Advertise this attribute. Signed-off-by: Eric Auger --- --- hw/arm/smmuv3.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index e96d5beb9a..384c02cb91 100644 ---

[Qemu-devel] [PATCH v2 0/6] ARM SMMUv3: Fix spurious notification errors and stall with vfio-pci

2019-07-01 Thread Eric Auger
This series fixes the guest stall observed when attempting to run a guest exposed with a SMMUv3 and a VFIO-PCI device. As a reminder SMMUv3 is not yet integrated with VFIO (the device will not work properly) but this shouldn't prevent the guest from booting. It also silences some spurious

[Qemu-devel] [PATCH v2 2/6] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute

2019-07-01 Thread Eric Auger
We introduce a new IOMMU Memory Region attribute, IOMMU_ATTR_VFIO_NESTED that tells whether the virtual IOMMU requires physical nested stages for VFIO integration. Current Intel virtual IOMMU device supports "Caching Mode" and does not require 2 stages at physical level to be integrated with

Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine

2019-07-01 Thread Michael S. Tsirkin
On Fri, Jun 28, 2019 at 11:44:07PM +0200, Sergio Lopez wrote: > > Eduardo Habkost writes: > > > On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote: > > [...] > >> /* Enables contiguous-apic-ID mode, for compatibility */ > >> -static bool compat_apic_id_mode; > >> +bool

Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging

2019-07-01 Thread Pavel Dovgalyuk
Ping. Pavel Dovgalyuk > -Original Message- > From: dovgaluk [mailto:dovga...@ispras.ru] > Sent: Thursday, June 27, 2019 8:49 PM > To: pbonz...@redhat.com > Cc: qemu-devel@nongnu.org; kw...@redhat.com; peter.mayd...@linaro.org; > crosthwaite.pe...@gmail.com; boost.li...@gmail.com; >

Re: [Qemu-devel] [PATCH 2/3] pcie: check that slt ctrl changed before deleting

2019-07-01 Thread Michael S. Tsirkin
On Tue, Jun 25, 2019 at 02:45:11PM +0200, Igor Mammedov wrote: > On Fri, 21 Jun 2019 02:46:48 -0400 > "Michael S. Tsirkin" wrote: > > > During boot, linux would sometimes overwrites control of a powered off > > slot before powering it on. Unfortunately QEMU interprets that as a > > power off

Re: [Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ

2019-07-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190701090904.31312-1-ppan...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190701090904.31312-1-ppan...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v2 0/3] restrict

Re: [Qemu-devel] [PATCH 3/3] pcie: work around for racy guest init

2019-07-01 Thread Michael S. Tsirkin
On Tue, Jun 25, 2019 at 03:07:30PM +0200, Igor Mammedov wrote: > On Fri, 21 Jun 2019 02:46:50 -0400 > "Michael S. Tsirkin" wrote: > > > During boot, linux guests tend to clear all bits in pcie slot status > > register which is used for hotplug. > > If they clear bits that weren't set this is

Re: [Qemu-devel] [PATCH 3/3] pcie: work around for racy guest init

2019-07-01 Thread Marcel Apfelbaum
CCing qemu-devel On 7/1/19 11:57 AM, Igor Mammedov wrote: On Mon, 1 Jul 2019 10:04:01 +0300 Marcel Apfelbaum wrote: On 6/21/19 9:46 AM, Michael S. Tsirkin wrote: During boot, linux guests tend to clear all bits in pcie slot status register which is used for hotplug. If they clear bits that

[Qemu-devel] [PATCH v2 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-01 Thread P J P
From: Prasad J Pandit The interface names in qemu-bridge-helper are defined to be of size IFNAMSIZ(=16), including the terminating null('\0') byte. The same is applied to interface names read from 'bridge.conf' file to form ACLs rules. If user supplied '--br=bridge' name is not restricted to the

Re: [Qemu-devel] [PATCH 3/3] pcie: work around for racy guest init

2019-07-01 Thread Marcel Apfelbaum
CCing qemu-devel On 7/1/19 11:57 AM, Igor Mammedov wrote: On Mon, 1 Jul 2019 10:04:01 +0300 Marcel Apfelbaum wrote: On 6/21/19 9:46 AM, Michael S. Tsirkin wrote: During boot, linux guests tend to clear all bits in pcie slot status register which is used for hotplug. If they clear bits that

[Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMSIZ

2019-07-01 Thread P J P
From: Prasad J Pandit The interface name in Linux interface request struct 'ifreq' OR in qemu-bridge-helper is defined to be of size IFNAMSIZ(=16), including the terminating null('\0') byte. QEMU tap device, while invoking qemu-bridge-helper, supplies bridge name of 16 characters, restrict it

Re: [Qemu-devel] RFC: Why does target/m68k RTE insn. use gen_exception

2019-07-01 Thread Peter Maydell
On Sat, 29 Jun 2019 at 17:37, Lucien Murray-Pitts wrote: > However for the m68k the do_transaction_failed function pointer field > has not been implemented. Er, I implemented that in commit e1aaf3a88e95ab007. Are you working with an out-of-date version of QEMU ? thanks -- PMM

[Qemu-devel] [PATCH v2 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-01 Thread P J P
From: Prasad J Pandit Move repeating error handling sequence in parse_acl_file routine to an 'err' label. Signed-off-by: Prasad J Pandit --- qemu-bridge-helper.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c

[Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ

2019-07-01 Thread P J P
From: Prasad J Pandit Hello, Linux net_deivce defines network interface name to be of IFNAMSIZE(=16) bytes, including the terminating null('\0') byte. Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the network bridge interface, supplies bridge name of 16 characters, thus

Re: [Qemu-devel] [PATCH v24 1/7] target/avr: Add outward facing interfaces and core CPU logic

2019-07-01 Thread Igor Mammedov
On Fri, 28 Jun 2019 18:54:27 +0300 Michael Rolnik wrote: > Igor. > > so avr6 instead of a6-avr-cpu, xmega2 instead of xmega2-avr-cpu and so on, > right? (it would be better if question was rith under context that prompted it) [...] > > > +++ b/target/avr/cpu.h > > > @@ -0,0 +1,283 @@ > > > +/*

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

2019-07-01 Thread Peter Maydell
On Sat, 29 Jun 2019 at 11:53, Philippe Mathieu-Daudé wrote: > > Hi Marlies, > > On 6/29/19 1:26 AM, Marlies Ruck wrote: > > Hi, > > > > I just wanted to follow up since I sent this patch a week ago to make sure > > it was a received. An ack would be appreciated. > > You did not Cc'ed the

Re: [Qemu-devel] [QEMU-PPC] [PATCH v3] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-07-01 Thread Greg Kurz
On Mon, 1 Jul 2019 16:19:46 +1000 Suraj Jitindar Singh wrote: > The ibm,get_system_parameter rtas call is used by the guest to retrieve > data relating to certain parameters of the system. The SPLPAR > characteristics option (token 20) is used to determin characteristics of > the environment in

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

2019-07-01 Thread Laurent Vivier
Le 27/06/2019 à 02:15, Justin Hibbits a écrit : > > > On Wed, Jun 26, 2019, 19:08 Laurent Vivier > wrote: > > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits >

Re: [Qemu-devel] [PATCH] linux-user: move QEMU_IFLA_BR_MULTI_BOOLOPT to the good function

2019-07-01 Thread Laurent Vivier
Le 26/06/2019 à 17:08, Laurent Vivier a écrit : > QEMU_IFLA_BR_MULTI_BOOLOPT has been added to the wrong function > host_to_target_slave_data_bridge_nlattr(). Move it to > host_to_target_data_bridge_nlattr(). > > This fixes following error: > Unknown QEMU_IFLA_BR type 46 > > Fixes:

Re: [Qemu-devel] [PATCH v16 5/5] linux-user: Handle EXCP_FPE properly for MIPS

2019-07-01 Thread Laurent Vivier
Le 28/06/2019 à 12:43, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Handle EXCP_FPE properly for MIPS in cpu loop. > > Note that a vast majority of FP instructions are not affected by > the absence of the code in this patch, as they use alternative code > paths for handling

Re: [Qemu-devel] [PATCH v16 5/5] linux-user: Handle EXCP_FPE properly for MIPS

2019-07-01 Thread Laurent Vivier
Le 28/06/2019 à 12:43, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Handle EXCP_FPE properly for MIPS in cpu loop. > > Note that a vast majority of FP instructions are not affected by > the absence of the code in this patch, as they use alternative code > paths for handling

Re: [Qemu-devel] [PATCH v16 4/5] linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK

2019-07-01 Thread Laurent Vivier
Le 28/06/2019 à 12:43, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Bring target_flock definitions to be more in sync with the way > flock is defined in kernel. > > Basically, the rules from the kernel are: > > 1. Majority of architectures have a common flock definition. > >

Re: [Qemu-devel] [PATCH v16 3/5] linux-user: Fix target_flock structure for MIPS O64 ABI

2019-07-01 Thread Laurent Vivier
Le 28/06/2019 à 12:43, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Among MIPS ABIs, only MIPS O32 and N32 have special (different > than other architectures) definition of structure flock in kernel. > > Bring target_flock definition in QEMU for MIPS O64 ABI to the > correct

Re: [Qemu-devel] [PATCH v16 2/5] linux-user: Add support for strace for statx() syscall

2019-07-01 Thread Laurent Vivier
Le 28/06/2019 à 12:43, Aleksandar Markovic a écrit : > From: Jim Wilson > > All of the flags need to be conditional as old systems don't have > statx support. Otherwise it works the same as other stat family > syscalls. This requires the pending patch to add statx support. > > Tested on

Re: [Qemu-devel] [PATCH v16 1/5] linux-user: Add support for translation of statx() syscall

2019-07-01 Thread Laurent Vivier
Le 28/06/2019 à 12:43, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Implement support for translation of system call statx(). > > The implementation is based on "best effort" approach: if host > is capable of executing statx(), host statx() is used. If not, > the implementation

Re: [Qemu-devel] [RFC PATCH 0/5] FAULT INJECTION FRAMEWORK

2019-07-01 Thread Stefan Hajnoczi
On Fri, Jun 28, 2019 at 02:45:29PM +0200, Damien Hedde wrote: > This series adds a python framework aiming to provide some ways to do fault > injection in a running vm. In its current state, it allows to easily interact > with memory, change gpios and qom properties. > > The framework consists in

[Qemu-devel] [Bug 1774149] Re: qemu-user x86_64 x86 gdb call function from gdb doesn't work

2019-07-01 Thread Lukas Durfina
It seems the issue is related to gdb code: set_gdbarch_call_dummy_location (gdbarch, ON_STACK); What is going on? The breakpoint is stored on stack and for the first time the address has a flag PAGE_WRITE. After a call, the address does not have anymore the flag PAGE_WRITE. It is changed in

Re: [Qemu-devel] [PATCH] spapr/xive: H_INT_ESB is used for LSIs only

2019-07-01 Thread David Gibson
On Mon, Jul 01, 2019 at 07:55:03AM +0200, Cédric Le Goater wrote: > On 01/07/2019 07:07, David Gibson wrote: > > On Fri, Jun 21, 2019 at 05:05:45PM +0200, Cédric Le Goater wrote: > >> On 21/06/2019 16:52, Greg Kurz wrote: > >>> As indicated in the function header, this "hcall is only supported for

[Qemu-devel] [PATCH v2] console: fix cell overflow

2019-07-01 Thread Gerd Hoffmann
Linux terminal behavior (coming from vt100 I think) is somewhat strange when it comes to line wraps: When a character is printed to the last char cell of a line the cursor does NOT jump to the next line but stays where it is. The line feed happens when the next character is printed. So the

Re: [Qemu-devel] [SeaBIOS] [PATCH v4 0/5] Add Qemu to SeaBIOS LCHS interface

2019-07-01 Thread Gerd Hoffmann
On Wed, Jun 26, 2019 at 03:38:11PM +0300, Sam Eiderman wrote: > v1: > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries (consistent values being reported from BIOS INT13 > AH=08) will most likely break

Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface

2019-07-01 Thread Gerd Hoffmann
On Wed, Jun 26, 2019 at 03:39:40PM +0300, Sam Eiderman wrote: > v1: > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries (consistent values being reported from BIOS INT13 > AH=08) will most likely break

Re: [Qemu-devel] [PATCH v2 9/9] i386: Add Cascadelake-Server-v2 CPU model

2019-07-01 Thread Xiaoyao Li
On 6/28/2019 8:28 AM, Eduardo Habkost wrote: Add new version of Cascadelake-Server CPU model, setting stepping=5 and enabling the IA32_ARCH_CAPABILITIES MSR with some flags. The new feature will introduce a new host software requirement, breaking our CPU model runnability promises. This means

Re: [Qemu-devel] [PATCH 3/3] pcie: work around for racy guest init

2019-07-01 Thread Marcel Apfelbaum
On 6/21/19 9:46 AM, Michael S. Tsirkin wrote: During boot, linux guests tend to clear all bits in pcie slot status register which is used for hotplug. If they clear bits that weren't set this is racy and will lose events: not a big problem for manual hotplug on bare-metal, but a problem for

Re: [Qemu-devel] [PATCH 2/3] pcie: check that slt ctrl changed before deleting

2019-07-01 Thread Marcel Apfelbaum
On 6/21/19 9:46 AM, Michael S. Tsirkin wrote: During boot, linux would sometimes overwrites control of a powered off slot before powering it on. Unfortunately QEMU interprets that as a power off request and ejects the device. For example: /x86_64-softmmu/qemu-system-x86_64 -enable-kvm -S

Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events

2019-07-01 Thread Marcel Apfelbaum
On 6/21/19 9:46 AM, Michael S. Tsirkin wrote: If we are trying to set multiple bits at once, testing that just one of them is already set gives a false positive. As a result we won't interrupt guest if e.g. presence detection change and attention button press are both set. This happens with

Re: [Qemu-devel] [PATCH] spapr/xive: Add proper rollback to kvmppc_xive_connect()

2019-07-01 Thread David Gibson
On Mon, Jul 01, 2019 at 08:13:07AM +0200, Cédric Le Goater wrote: > On 19/06/2019 11:36, David Gibson wrote: > > On Sun, Jun 16, 2019 at 07:22:23PM +0200, Greg Kurz wrote: > >> Make kvmppc_xive_disconnect() able to undo the changes of a partial > >> execution of kvmppc_xive_connect() and use it to

Re: [Qemu-devel] [RFC] Re-evaluating subcluster allocation for qcow2 images

2019-07-01 Thread Kevin Wolf
Am 28.06.2019 um 17:12 hat Alberto Garcia geschrieben: > On Fri 28 Jun 2019 05:09:11 PM CEST, Kevin Wolf wrote: > > Am 28.06.2019 um 17:02 hat Alberto Garcia geschrieben: > >> On Fri 28 Jun 2019 04:57:08 PM CEST, Kevin Wolf wrote: > >> > Am 28.06.2019 um 16:43 hat Alberto Garcia geschrieben: > >>

[Qemu-devel] [QEMU-PPC] [PATCH v3] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-07-01 Thread Suraj Jitindar Singh
The ibm,get_system_parameter rtas call is used by the guest to retrieve data relating to certain parameters of the system. The SPLPAR characteristics option (token 20) is used to determin characteristics of the environment in which the lpar will run. It may be useful for a guest to know the

Re: [Qemu-devel] [PATCH] spapr/xive: Add proper rollback to kvmppc_xive_connect()

2019-07-01 Thread Cédric Le Goater
On 19/06/2019 11:36, David Gibson wrote: > On Sun, Jun 16, 2019 at 07:22:23PM +0200, Greg Kurz wrote: >> Make kvmppc_xive_disconnect() able to undo the changes of a partial >> execution of kvmppc_xive_connect() and use it to perform rollback. >> >> Based-on: <20190614165920.12670-2-...@kaod.org>

<    1   2   3   4   5