On Fri, Jul 12, 2019 at 11:18:47AM +0100, Daniel P. Berrangé wrote:
> This short series fixes a few compatibility issues around different
> nettle versions.
Thank you for the fix. The compilation with nettle 3.5.1 now succeeds
without resorting to --disable-werror or --disable-nettle.
-amol
Patchew URL:
https://patchew.org/QEMU/20190711172845.31035-1-eric.au...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
Public bug reported:
Latest release (20190712) 64-bit doesn't install:
The setup seems to work fine at first and actually extract all the files needed
for qemu in the correct location, but after it has done that, it proceeds to
delete every file and leaves no trace of qemu except
On 7/10/19 4:04 AM, Richard Henderson wrote:
On 7/9/19 6:58 PM, Lucien Murray-Pitts wrote:
Any suggestions on how to obtain pc_next from the "m68k_cpu_do_interrupt(
CPUState *cs)" ?
test
I did have a suggestion. It was fairly detailed.
On 12/07/2019 06:59, Markus Armbruster wrote:
> Until recently, target install used to recurse into target directories
> in its recipe: it ran make install in a for-loop. Since target
> install depends on target all, this trivially ensured we run the
> sub-make install only after completing
On 11/07/2019 15:45, Markus Armbruster wrote:
> Mark Cave-Ayland writes:
>
>> Something also looks a bit odd with distclean here on a fresh checkout:
>>
>> build@ezio:~/src/qemu/git/tmp/qemu$ make distclean
>> LD recurse-clean.mo
>> cc: fatal error: no input files
>> compilation
When tcp_chr_disconnect() is called, other thread may be still writing
to the channel. This patch protects only read operations that initiate
the disconnection.
Signed-off-by: Andrey Shinkevich
---
The segmentation fault occurred because of the race condition when the
write operation was
On Fri, Jul 12, 2019 at 8:19 PM Aleksandar Markovic
wrote:
>
> On Fri, Jul 12, 2019 at 8:09 PM Aleksandar Markovic
> wrote:
> >
> > Hello, Richard, Peter, and others.
> >
> > As a part of activities before 4.1 release, I tested nanoMIPS support
> > in QEMU (which was officially fully integrated
On 12.07.19 12:46, Stefano Garzarella wrote:
> When the backing_file is specified as a JSON object, the
> qemu_gluster_reopen_prepare() fails with this message:
> invalid URI json:{"server.0.host": ...}
>
> In this case, we should call qemu_gluster_init() using the QDict
> 'state->options'
On 12.07.19 12:27, Stefano Garzarella wrote:
> On Thu, Jul 11, 2019 at 03:29:35PM +0200, Max Reitz wrote:
>> When preallocating an encrypted qcow2 image, it just lets the protocol
>> driver write data and then does not mark the clusters as zero.
>> Therefore, reading this image will yield
On Fri, Jul 12, 2019 at 8:09 PM Aleksandar Markovic
wrote:
>
> Hello, Richard, Peter, and others.
>
> As a part of activities before 4.1 release, I tested nanoMIPS support
> in QEMU (which was officially fully integrated in 4.0, is currently
> limited to system mode only, and was tested in a
Hello, Richard, Peter, and others.
As a part of activities before 4.1 release, I tested nanoMIPS support
in QEMU (which was officially fully integrated in 4.0, is currently
limited to system mode only, and was tested in a similar fashion right
prior to 4.0).
This support appears to be broken
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Fri, 12 Jul 2019 at 15:32, Juan Quintela wrote:
> >
> > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38:
> >
> > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712'
On Fri, Jul 12, 2019 at 9:34 PM Paolo Bonzini wrote:
>
> main-loop.c has a dependency on iohandler.c, and everything breaks
> if that dependency is instead satisfied by stubs/iohandler.c.
> Just put everything in the same file to avoid strange dependencies
> on the order of files in util-obj-y.
>
On 12/07/19 15:26, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
> ---
> target/i386/whpx-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
> index 31d47320e4..ed95105eae 100644
> --- a/target/i386/whpx-all.c
>
On 12/07/19 19:46, Marc-André Lureau wrote:
> Hi
>
> On Fri, Jul 12, 2019 at 9:37 PM Philippe Mathieu-Daudé
> wrote:
>>
>> Hi Marc-André,
>>
>> On 7/12/19 7:27 PM, Marc-André Lureau wrote:
>>> Left over from c2d63650d962612cfa1b21302782d4cd12142c74.
>>>
>>> Signed-off-by: Marc-André Lureau
>>
On 12/07/19 08:52, Wang King wrote:
> From: King Wang
>
> The memory region reference is increased when insert a range
> into flatview range array, then decreased by destroy flatview.
> If some flat range merged by flatview_simplify, the memory region
> reference can not be decreased by destroy
Hi
On Fri, Jul 12, 2019 at 9:37 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Marc-André,
>
> On 7/12/19 7:27 PM, Marc-André Lureau wrote:
> > Left over from c2d63650d962612cfa1b21302782d4cd12142c74.
> >
> > Signed-off-by: Marc-André Lureau
>
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by:
On 12/07/19 18:02, Julio Montes wrote:
> vmport device is not included when CONFIG_VMPORT is disabled, hence
> QEMU fails with the following error:
>
> `Unknown device 'vmport' for bus 'ISA': unknown.`
>
> v2: imply VMPORT (Paolo Bonzini )
>
> Signed-off-by: Julio Montes
> ---
>
* Kirti Wankhede (kwankh...@nvidia.com) wrote:
>
>
> On 7/11/2019 9:53 PM, Dr. David Alan Gilbert wrote:
> > * Yan Zhao (yan.y.z...@intel.com) wrote:
> >> On Thu, Jul 11, 2019 at 06:50:12PM +0800, Dr. David Alan Gilbert wrote:
> >>> * Yan Zhao (yan.y.z...@intel.com) wrote:
> Hi Kirti,
>
Hi Marc-André,
On 7/12/19 7:27 PM, Marc-André Lureau wrote:
> Left over from c2d63650d962612cfa1b21302782d4cd12142c74.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> util/Makefile.objs | 1 -
> 1 file changed, 1
The generic fallback implementation effectively does the same.
Signed-off-by: Max Reitz
---
block/file-posix.c | 67 --
1 file changed, 67 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 4479cc7ab4..65bd6d 100644
---
The generic fallback implementation effectively does the same.
Signed-off-by: Max Reitz
---
block/iscsi.c | 56 ---
1 file changed, 56 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 267f160bf6..0e5729d335 100644
--- a/block/iscsi.c
When nbd_close() is called from a coroutine, the connection_co never
gets to run, and thus nbd_teardown_connection() hangs.
This is because aio_co_enter() only puts the connection_co into the main
coroutine's wake-up queue, so this main coroutine needs to yield and
wait for connection_co to
Signed-off-by: Max Reitz
---
block/parallels.c | 2 +-
block/qcow.c | 2 +-
block/qcow2.c | 2 +-
block/qed.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 00fae125d1..a17b2d92f2 100644
--- a/block/parallels.c
Signed-off-by: Max Reitz
---
tests/qemu-iotests/259 | 61 ++
tests/qemu-iotests/259.out | 14 +
tests/qemu-iotests/group | 1 +
3 files changed, 76 insertions(+)
create mode 100755 tests/qemu-iotests/259
create mode 100644
If a protocol driver does not support image creation, we can see whether
maybe the file exists already. If so, just truncating it will be
sufficient.
Signed-off-by: Max Reitz
---
block.c | 83 -
1 file changed, 71 insertions(+), 12
Signed-off-by: Max Reitz
---
include/sysemu/block-backend.h | 12
block/block-backend.c | 54 ++
2 files changed, 66 insertions(+)
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 733c4957eb..cd9ec8bf52 100644
Hi,
Kevin commented on my RFC, so I got what an RFC wants, and he didn’t
object to the creation fallback part. So I suppose I can go down that
route at least. (Which was actually the more important part of the
series.)
So as in the RFC, this series adds a fallback path for creating files
(on
main-loop.c has a dependency on iohandler.c, and everything breaks
if that dependency is instead satisfied by stubs/iohandler.c.
Just put everything in the same file to avoid strange dependencies
on the order of files in util-obj-y.
Signed-off-by: Paolo Bonzini
---
util/Makefile.objs | 2 +-
On 12/07/19 18:51, Marc-André Lureau wrote:
> ../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
> ../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835
> equals destination size [-Werror=stringop-truncation]
> 118 | strncpy(unix_socket_path, optarg,
On 12/07/19 19:27, Marc-André Lureau wrote:
> Left over from c2d63650d962612cfa1b21302782d4cd12142c74.
>
> Signed-off-by: Marc-André Lureau
> ---
> util/Makefile.objs | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/util/Makefile.objs b/util/Makefile.objs
> index 38178201ff..68af3cd5e9
On 12/07/19 18:45, Philippe Mathieu-Daudé wrote:
> On 7/12/19 4:58 PM, Paolo Bonzini wrote:
>> The other is whether we want to enable USB_BLUETOOTH by default. I
>> wouldn't have any problem there, but if we disable it basically no one
>> would ship/use it and we might as well delete the whole
On 7/12/19 1:50 PM, Peter Maydell wrote:
> The i.MX6UL always has a single Cortex-A7 CPU (we set FSL_IMX6UL_NUM_CPUS
> to 1 in line with this). This means that all the code in fsl-imx6ul.c to
> handle multiple CPUs is dead code, and Coverity is now complaining that
> it is unreachable (CID
Left over from c2d63650d962612cfa1b21302782d4cd12142c74.
Signed-off-by: Marc-André Lureau
---
util/Makefile.objs | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/Makefile.objs b/util/Makefile.objs
index 38178201ff..68af3cd5e9 100644
--- a/util/Makefile.objs
+++ b/util/Makefile.objs
@@
I think the ieee6 test is due to a broken runtime:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78314
** Bug watch added: GCC Bugzilla #78314
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78314
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On 7/12/19 12:18 PM, Daniel P. Berrangé wrote:
> Nettle version 2.7.x used 'unsigned int' instead of 'size_t' for length
> parameters in functions. Use a local typedef so that we can build with
> the correct signature depending on nettle version, as we already do in
> the cipher code.
>
Cc'ing Gerd
On 7/11/19 12:55 AM, Carlo Marcelo Arenas Belón wrote:
> If SDL2 is requested but pkg-config doesn't have a module for it
> configure should fallback to use sdl*-config, but wasn't able to
> because and old variable (from SDL) was being used by mistake.
>
> Correct the variable name
On 7/11/19 9:25 PM, Michael S. Tsirkin wrote:
> slt ctl/status are passed in incorrect order.
> Fix this up.
>
Fixes: Coverity (CID 1403007)
> Signed-off-by: Michael S. Tsirkin
> Reported-by: Peter Maydell
> ---
> hw/pci-bridge/xio3130_downstream.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On 7/12/19 9:35 AM, Pankaj Gupta wrote:
> Coverity reported memory region returns zero
> for non-null value. This is because of wrong
> arguments to '?:' , fixing this.
>
Please amend:
Fixes: Coverity (CID 1403009)
> Signed-off-by: Pankaj Gupta
Reviewed-by: Philippe Mathieu-Daudé
Tested-by:
On 7/12/19 4:41 PM, Michal Privoznik wrote:
> Commit d52c454aadc creates
> '/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu'
> and commit 06914c97d3a creates '/vhost-user-input' neither of
> which is ignored by git.
>
> Signed-off-by: Michal Privoznik
> ---
> .gitignore | 3 +++
>
On 7/12/19 5:15 PM, Peter Maydell wrote:
> On Thu, 11 Jul 2019 at 16:58, Philippe Mathieu-Daudé
> wrote:
>>
>> In the "Read Array Flowchart" the command has a value of 0xFF.
>>
>> In the document [*] the "Read Array Flowchart", the READ_ARRAY
>> command has a value of 0xff.
>>
>> Use the correct
../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835
equals destination size [-Werror=stringop-truncation]
118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
Signed-off-by: Marc-André Lureau
---
On 7/11/19 8:24 AM, Stefan Hajnoczi wrote:
> On Sun, Jul 07, 2019 at 07:55:03PM -0700, shaju.abra...@nutanix.com wrote:
>
> Reviewed-by: Stefan Hajnoczi
>
> CCing John Snow, IDE maintainer.
>
> You can use scripts/get_maintainer.pl -f hw/ide/core.c to find out who
> to send patches to.
>
>
On 7/12/19 4:58 PM, Paolo Bonzini wrote:
> On 12/07/19 16:16, Philippe Mathieu-Daudé wrote:
>> I wondered but am not sure, it is default to Yes, but Bluetooth code is
>> deprecated and print a big warning when you use it, so I think this
>> device should not be selected as default, neither pull in
On Fri, 12 Jul 2019 at 15:32, Juan Quintela wrote:
>
> The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712'
> into staging (2019-07-12 11:06:48 +0100)
>
> are available
vmport device is not included when CONFIG_VMPORT is disabled, hence
QEMU fails with the following error:
`Unknown device 'vmport' for bus 'ISA': unknown.`
v2: imply VMPORT (Paolo Bonzini )
Signed-off-by: Julio Montes
---
hw/i386/Kconfig | 4 ++--
hw/i386/pc.c| 5 +
2 files changed, 7
On 7/12/19 4:27 AM, Dr. David Alan Gilbert wrote:
[snip]
>>>
>>> OK, that's our very last usable flag! Use it wisely!
>>>
>>
>> Hmm, maybe then I missed something. I thought the flag is 64-bit and
>> we have more room. Did I miss something ?
>
> The 64bit value written in the stream is
>
Refresh: still happening with Qemu 4.0 and Kernel 5.2.
One additional observation:
4) problem disappears when vhost is disabled.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1811533
Title:
On 7/12/19 6:30 AM, Dr. David Alan Gilbert wrote:
> * Singh, Brijesh (brijesh.si...@amd.com) wrote:
>> When memory encryption is enabled, the hypervisor maintains a page
>> encryption bitmap which is referred by hypervisor during migratoin to check
>> if page is private or shared. The bitmap is
slt ctl/status are passed in incorrect order.
Fix this up.
Signed-off-by: Michael S. Tsirkin
Reported-by: Peter Maydell
Reviewed-by: Marcel Apfelbaum
---
hw/pci-bridge/xio3130_downstream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-bridge/xio3130_downstream.c
The function declarations for pci_cap_slot_get and
pci_cap_slot_write_config call the argument "slot_ctl", but the function
definitions and all the call sites drop the 'o' and call it "slt_ctl".
Let's be consistent.
Reported-by: Peter Maydell
Signed-off-by: Michael S. Tsirkin
Reviewed-by:
The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' into
staging (2019-07-12 11:06:48 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags
On Fri, 12 Jul 2019 at 08:53, David Engraf wrote:
>
> Using the whole 128 MiB flash in non-secure mode is not working because
> virt_flash_fdt() expects the same address for secure_sysmem and sysmem.
> This is not correctly handled by caller because it forwards NULL for
> secure_sysmem in
Patchew URL:
https://patchew.org/QEMU/20190712011934.29863-1-mdr...@linux.vnet.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190712011934.29863-1-mdr...@linux.vnet.ibm.com
Type: series
Subject: [Qemu-devel] [RFC PATCH
On Fri, 12 Jul 2019 at 14:53, Kevin Wolf wrote:
>
> The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712'
> into staging (2019-07-12 11:06:48 +0100)
>
> are available
* Singh, Brijesh (brijesh.si...@amd.com) wrote:
>
>
> On 7/12/19 5:43 AM, Dr. David Alan Gilbert wrote:
> > * Singh, Brijesh (brijesh.si...@amd.com) wrote:
> >> The sev_save_outgoing_page() provide the implementation to encrypt the
> >> guest private pages during the transit. The routines uses
On 7/12/19 6:02 AM, Dr. David Alan Gilbert wrote:
> * Singh, Brijesh (brijesh.si...@amd.com) wrote:
>> The sev_load_incoming_page() provide the implementation to read the
>> incoming guest private pages from the socket and load it into the guest
>> memory. The routines uses the RECEIVE_START
On 7/12/19 5:43 AM, Dr. David Alan Gilbert wrote:
> * Singh, Brijesh (brijesh.si...@amd.com) wrote:
>> The sev_save_outgoing_page() provide the implementation to encrypt the
>> guest private pages during the transit. The routines uses the SEND_START
>> command to create the outgoing encryption
On Thu, 11 Jul 2019 at 16:58, Philippe Mathieu-Daudé wrote:
>
> In the "Read Array Flowchart" the command has a value of 0xFF.
>
> In the document [*] the "Read Array Flowchart", the READ_ARRAY
> command has a value of 0xff.
>
> Use the correct value in the pflash model.
>
> There is no change of
Quoting David Gibson (2019-07-12 01:40:27)
> On Thu, Jul 11, 2019 at 08:19:33PM -0500, Michael Roth wrote:
> > For now this only covers hcalls relating to TPM communication since
> > it's the only one particularly important from a QEMU perspective atm,
> > but others can be added here where it
Patchew URL: https://patchew.org/QEMU/20190711173131.6347-1-laur...@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190711173131.6347-1-laur...@vivier.eu
Type: series
Subject: [Qemu-devel] [PATCH v4] linux-user: fix to
Patchew URL:
https://patchew.org/QEMU/20190711172845.31035-1-eric.au...@redhat.com/
Hi,
This series failed build test on s390x host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit
On 7/12/19 5:09 AM, Daniel P. Berrangé wrote:
> On Fri, Jul 12, 2019 at 11:00:22AM +0100, Dr. David Alan Gilbert wrote:
>> * Singh, Brijesh (brijesh.si...@amd.com) wrote:
>>> The command can be used by the hypervisor to specify the target Platform
>>> Diffie-Hellman key (PDH) and certificate
On 12/07/19 16:16, Philippe Mathieu-Daudé wrote:
> I wondered but am not sure, it is default to Yes, but Bluetooth code is
> deprecated and print a big warning when you use it, so I think this
> device should not be selected as default, neither pull in the deprecated
> bluetooth code.
>
> So
On 7/11/19 2:05 PM, Dr. David Alan Gilbert wrote:
> * Singh, Brijesh (brijesh.si...@amd.com) wrote:
>> The SEV VMs have concept of private and shared memory. The private memory
>> is encrypted with guest-specific key, while shared memory may be encrypted
>> with hyperivosr key. The
On 12/07/19 16:50, Julio Montes wrote:
> vmport device is not included when CONFIG_VMPORT is disabled, hence
> QEMU fails with the following error:
>
> `Unknown device 'vmport' for bus 'ISA': unknown.`
>
> Signed-off-by: Julio Montes
> ---
> hw/i386/pc.c | 5 +
> 1 file changed, 5
Patchew URL: https://patchew.org/QEMU/20190711171556.3377-1-laur...@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190711171556.3377-1-laur...@vivier.eu
Type: series
Subject: [Qemu-devel] [PATCH v3] linux-user: fix to
vmport device is not included when CONFIG_VMPORT is disabled, hence
QEMU fails with the following error:
`Unknown device 'vmport' for bus 'ISA': unknown.`
Signed-off-by: Julio Montes
---
hw/i386/pc.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index
On Fri, Jul 12, 2019 at 6:42 PM Michal Privoznik wrote:
>
> Commit d52c454aadc creates
> '/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu'
> and commit 06914c97d3a creates '/vhost-user-input' neither of
> which is ignored by git.
>
> Signed-off-by: Michal Privoznik
Reviewed-by:
Patchew URL:
https://patchew.org/QEMU/20190711150940.17483-1-mlevi...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190711150940.17483-1-mlevi...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v3] LUKS:
Commit d52c454aadc creates
'/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu'
and commit 06914c97d3a creates '/vhost-user-input' neither of
which is ignored by git.
Signed-off-by: Michal Privoznik
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore
Cc'ing Justin
Maybe we should add a MAINTAINERS section for the WHPX files.
On 7/12/19 3:26 PM, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
> ---
> target/i386/whpx-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/i386/whpx-all.c
Quoting David Gibson (2019-07-12 01:46:19)
> On Thu, Jul 11, 2019 at 08:19:34PM -0500, Michael Roth wrote:
> > This implements the H_TPM_COMM hypercall, which is used by an
> > Ultravisor to pass TPM commands directly to the host's TPM device, or
> > a TPM Resource Manager associated with the
From: Peter Xu
Introduce KVMMemoryListener.slots_lock to protect the slots inside the
kvm memory listener. Currently it is close to useless because all the
KVM code path now is always protected by the BQL. But it'll start to
make sense in follow up patches where we might do remote dirty bitmap
From: Peter Xu
Firstly detect the interface using KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2
and mark it. When failed to enable the new feature we'll fall back to
the old sync.
Provide the log_clear() hook for the memory listeners for both address
spaces of KVM (normal system memory, and SMM) and
Patchew URL:
https://patchew.org/QEMU/20190711104412.31233-1-quint...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190711104412.31233-1-quint...@redhat.com
Type: series
Subject: [Qemu-devel] [PULL 00/19] Migration
From: Peter Xu
Introduce a new memory region listener hook log_clear() to allow the
listeners to hook onto the points where the dirty bitmap is cleared by
the bitmap users.
Previously log_sync() contains two operations:
- dirty bitmap collection, and,
- dirty bitmap clear on remote site.
From: Peter Xu
When synchronizing dirty bitmap from kernel KVM we do it in a
per-kvmslot fashion and we allocate the userspace bitmap for each of
the ioctl. This patch instead make the bitmap cache be persistent
then we don't need to g_malloc0() every time.
More importantly, the cached
From: Wei Yang
In case we gets a queued page, the order of block is interrupted. We may
not rely on the complete_round flag to say we have already searched the
whole blocks on the list.
Signed-off-by: Wei Yang
Reviewed-by: Juan Quintela
Message-Id:
From: Peter Xu
It's obviously obsolete. Do some update.
Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Message-Id: <20190603065056.25211-8-pet...@redhat.com>
Signed-off-by: Juan Quintela
---
accel/kvm/kvm-all.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
From: Peter Xu
Also we change the 2nd parameter of it to be the relative offset
within the memory region. This is to be used in follow up patches.
Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Message-Id: <20190603065056.25211-6-pet...@redhat.com>
Signed-off-by: Juan Quintela
---
From: Wei Yang
Notification from recv thread is not ordered, which means we may be
notified by one MultiFDRecvParams but adjust packet_num for another.
Move the adjustment after we are sure each recv thread are sync-ed.
Signed-off-by: Wei Yang
Reviewed-by: Juan Quintela
Reviewed-by: Peter Xu
From: Wei Yang
When we are not in the last_stage, we need to update the cache if page
is not the same.
Currently this procedure is scattered in two places and mixed with
encoding status check.
This patch extract this general step out to make the code a little bit
easy to read.
Signed-off-by:
From: Peter Xu
These helpers copy the source bitmap to destination bitmap with a
shift either on the src or dst bitmap.
Meanwhile, we never have bitmap tests but we should.
This patch also introduces the initial test cases for utils/bitmap.c
but it only tests the newly introduced functions.
From: Peng Tao
By removing the share ram check, qemu is able to migrate
to private destination ram when x-ignore-shared capability
is on. Then we can create multiple destination VMs based
on the same source VM.
This changes the x-ignore-shared migration capability to
work similar to Lai's
From: Peter Xu
cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as
parameter, which means that it must be with RCU read lock held
already. Taking it again inside seems redundant. Removing it.
Instead comment on the functions about the RCU read lock.
Reviewed-by: Paolo Bonzini
From: Peter Xu
Currently we are doing log_clear() right after log_sync() which mostly
keeps the old behavior when log_clear() was still part of log_sync().
This patch tries to further optimize the migration log_clear() code
path to split huge log_clear()s into smaller chunks.
We do this by
From: Peter Xu
Similar to 9460dee4b2 ("memory: do not touch code dirty bitmap unless
TCG is enabled", 2015-06-05) but for the migration bitmap - we can
skip the MIGRATION bitmap update if migration not enabled.
Reviewed-by: Paolo Bonzini
Reviewed-by: Juan Quintela
Signed-off-by: Peter Xu
We set multifd-channels.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Thomas Huth
Tested-by: Wei Yang
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 48 ++
1 file changed, 48 insertions(+)
diff --git
From: Wei Yang
Since we will not operate on the next address pointed by out, it is not
necessary to do addition on it.
After removing the operation, the function size reduced 16/18 bytes.
Signed-off-by: Wei Yang
Reviewed-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Message-Id:
From: Wei Yang
On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to
synchronize receive threads. Current synchronization mechanism is to wait
for each channel's sem_sync semaphore. This semaphore is triggered by a
packet with MULTIFD_FLAG_SYNC flag. While in current
We would need _str ones on the next patch.
Signed-off-by: Juan Quintela
Reviewed-by: Wei Yang
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 55 +-
1 file changed, 28 insertions(+), 27 deletions(-)
diff --git a/tests/migration-test.c
The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' into
staging (2019-07-12 11:06:48 +0100)
are available in the Git repository at:
https://github.com/juanquintela/qemu.git tags/migration
It uses num in multifd_send(). Make it coherent.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Wei Yang
Signed-off-by: Juan Quintela
---
migration/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/trace-events
I confirm this patch fixes the problem I reported. Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1834496
Title:
Regressions on arm target with some GCC tests
Status in QEMU:
In Progress
I confirm this patch fixes the problem I reported.
Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1836078
Title:
Regressions on arm-linux-gnueabihf target with some GCC tests
Status in
I confirm this patch fixes the problem I reported. Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1836192
Title:
Regressions on arm926 target with some GCC tests
Status in QEMU:
In
* Singh, Brijesh (brijesh.si...@amd.com) wrote:
> Signed-off-by: Brijesh Singh
> ---
> docs/amd-memory-encryption.txt | 42 +-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
> diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt
>
On 7/12/19 12:32 AM, Jan Bobek wrote:
> +sub vex($%)
> +{
> +my ($insn, %vex) = @_;
> +my $regidw = $is_x86_64 ? 4 : 3;
> +
> +# There is no point in randomizing other VEX fields, since
> +# VEX.R/.X/.B are encoded automatically by risugen_x86_asm, and
> +# VEX.M/.P are
1 - 100 of 237 matches
Mail list logo
