From: Rémi Denis-Courmont
Fix a crash with LTP testsuite and aarch64:
tst_test.c:1015: INFO: Timeout per run is 0h 05m 00s
qemu-aarch64: .../qemu/accel/tcg/translate-all.c:2522: page_check_range:
Assertion `start < ((target_ulong)1 << L1_MAP_ADDR_SPACE_BITS)' failed.
qemu:handle_cpu_signa
On 7/17/19 9:52 AM, Paolo Bonzini wrote:
On 17/07/19 14:59, Collin Walling wrote:
On 7/16/19 11:04 AM, Thomas Huth wrote:
On 16/07/2019 15.06, Markus Armbruster wrote:
Paolo Bonzini writes:
On 15/07/19 18:12, Cornelia Huck wrote:
Is it INTx vs. MSI vs. MSI-X?
I think for s390x we need (I
The following changes since commit a1a4d49f60d2b899620ee2be4ebb991c4a90a026:
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/pflash-next-20190716' into staging (2019-07-16
17:02:44 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu.git tags/linux-user-for-
On Tue, 16 Jul 2019 16:38:11 +0100
Shameer Kolothum wrote:
> This is in preparation to create ACPI GED device as we
> need to disable it for <4.2 for migration to work.
>
> Signed-off-by: Shameer Kolothum
Reviewed-by: Igor Mammedov
> ---
> hw/arm/virt.c | 9 -
> hw/core/machine
On 7/17/19 3:43 PM, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé
>
> Various firmwares has been added in the pc-bios/ directory:
>
> - CCW (since commit 0c1fecdd523)
> - Skiboot (since commit bcad45de6a0)
> - EDK2(since commit f7fa38b74c3)
>
> Since we install qemu-system able to r
On Tue, 16 Jul 2019 16:38:10 +0100
Shameer Kolothum wrote:
> From: Eric Auger
>
> This patch adds the memory hot-plug/hot-unplug infrastructure
> in machvirt. The device memory is not yet exposed to the Guest
> either through DT or ACPI and hence both cold/hot plug of memory
> is explicitly dis
The halt poll control MSR should only be enabled on hosts which
support it.
Fixes: ("kvm: i386: halt poll control MSR support")
Signed-off-by: Mark Kanda
---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
---
target/i386/cpu.c | 1 -
1 file changed, 1 deletion(-)
On Tue, 16 Jul 2019 16:38:09 +0100
Shameer Kolothum wrote:
> From: Samuel Ortiz
>
> The ACPI Generic Event Device (GED) is a hardware-reduced specific
> device[ACPI v6.1 Section 5.6.9] that handles all platform events,
> including the hotplug ones. This patch generates the AML code that
> defin
On 7/16/19 11:08 PM, tony.ngu...@bt.com wrote:
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index baa61719ad..11debb7dda 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -731,7 +731,7 @@ void tlb_set_page_with_attrs(CPUState *cpu, target_ulong
> vaddr,
>
On Wed, Jul 17, 2019 at 08:30:29PM +0800, Jason Wang wrote:
>
> On 2019/7/17 下午7:00, Michael S. Tsirkin wrote:
> > On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote:
> > > On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote:
> > > > On Tue, Jun 11, 2019 at 02:51:37PM +0800,
On 7/16/19 11:06 PM, tony.ngu...@bt.com wrote:
> +++ b/include/exec/poison.h
> @@ -38,7 +38,6 @@
> #pragma GCC poison TARGET_HAS_BFLT
> #pragma GCC poison TARGET_NAME
> #pragma GCC poison TARGET_SUPPORTS_MTTCG
> -#pragma GCC poison TARGET_WORDS_BIGENDIAN
You can't do this. This is here for a v
On 7/16/19 11:04 PM, tony.ngu...@bt.com wrote:
> +MO_ASHIFT = 4,
> +MO_AMASK = 7 << MO_ASHIFT,
> +#ifdef ALIGNED_ONLY
> +MO_ALIGN = 0,
> +MO_UNALN = MO_AMASK,
> +#else
> +MO_ALIGN = MO_AMASK,
> +MO_UNALN = 0,
> +#endif
I'm not sure you can move this portion as-is.
I think
Hi Laszlo,
On 7/17/19 2:24 PM, Laszlo Ersek wrote:
> Hi Phil,
>
> On 07/17/19 00:15, Philippe Mathieu-Daudé wrote:
>> Hello it's me again, insisting with this series because there are at
>> least 2 different report of guests bricked on reset due to the bug
>> fixed by patch #5:
>> https://bugzill
From: Thomas Huth
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on certain file systems
like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
taking too much time.
Reviewed-by: Max Reitz
Signed-off-by:
From: Philippe Mathieu-Daudé
The NSIS installer generates an executable suitable to install
QEMU on Windows.
Suggested-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20190715174817.18981-9-phi...@redhat.com>
[AJB: also --enable-docs in configure step]
Signed-off-by: Alex Be
From: Philippe Mathieu-Daudé
Various firmwares has been added in the pc-bios/ directory:
- CCW (since commit 0c1fecdd523)
- Skiboot (since commit bcad45de6a0)
- EDK2(since commit f7fa38b74c3)
Since we install qemu-system able to run the architectures
targetted by these firmware, include
From: Thomas Huth
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.
Signed-off-by: Thomas Huth
Message-Id: <20190717111947.30356-5-th
It's very confusing when things work in the debug shell because the
environment is different from what the test is running. Fix this by
ensuring we only have the inherited environment from the run shell.
Signed-off-by: Alex Bennée
---
tests/docker/run | 4 ++--
1 file changed, 2 insertions(+), 2
Commit 97fd1ea8c1 broke the build for --without-default-devices as
VMMOUSE depends on VMPORT.
Fixes: 97fd1ea8c1
Signed-off-by: Alex Bennée
---
hw/i386/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index b9c96ac361e..6350438036f
On 17/07/19 14:59, Collin Walling wrote:
> On 7/16/19 11:04 AM, Thomas Huth wrote:
>> On 16/07/2019 15.06, Markus Armbruster wrote:
>>> Paolo Bonzini writes:
>>>
On 15/07/19 18:12, Cornelia Huck wrote:
>> Is it INTx vs. MSI vs. MSI-X?
>
> I think for s390x we need (INTx || MSI) vs
From: Thomas Huth
People often forget to run the iotests before submitting patches or pull
requests - this is likely due to the fact that we do not run the tests
during our mandatory "make check" tests yet. Now that we've got a proper
"auto" group of iotests that should be fine to run in every en
From: Philippe Mathieu-Daudé
This fixes:
$ make installer
[...]
(cd /tmp/qemu-nsis; \
for i in qemu-system-*.exe; do \
arch=${i%.exe}; \
arch=${arch#qemu-system-}; \
echo Section \"$arch\" Section_$arch; \
echo SetOutPath \"\$I
From: Thomas Huth
The regular expressions in the "check" script currently expect that there
is always a space after the test number in the group file, so you can't
have a test in there without a group unless the line still ends with a
space - which is quite error prone since some editors might re
From: Philippe Mathieu-Daudé
The qemu-nsis.bmp file was not listed with the other blobs, thus
not installed in the ${BINDIR} location.
This fixes:
$ make installer
[...]
(cd /tmp/qemu-nsis; \
for i in qemu-system-*.exe; do \
arch=${i%.exe}; \
arch=${ar
We have some flaky tests and usually the test passes on a retry.
Enable travis_retry for the test phase and see if that helps keep
things green.
Signed-off-by: Alex Bennée
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 5d3d6ee1
On Wed, 17 Jul 2019 at 14:36, Philippe Mathieu-Daudé wrote:
> I still wonder why this didn't assert on Peter's setup.
My setup does not assert because my host kernel correctly
provides the ID register values to QEMU. Laszlo's appears
to be providing all-zeroes, which then obviously breaks
asserti
On Wed, 17 Jul 2019 at 10:22, Laszlo Ersek wrote:
> Hmmm wait a second. The ARMv8 ARM says, about ID_ISAR0_EL1:
>
> > Divide, bits [27:24]
> >
> > Indicates the implemented Divide instructions. Permitted values
> > are:
> > None implemented.
> > 0001 Adds SDIV and UDIV in the
From: Philippe Mathieu-Daudé
This fixes:
$ make installer
(cd /tmp/qemu-nsis; \
for i in qemu-system-*.exe; do \
arch=${i%.exe}; \
arch=${arch#qemu-system-}; \
echo Section \"$arch\" Section_$arch; \
echo SetOutPath \"\$INSTDIR\"
From: Philippe Mathieu-Daudé
Since commit 5f71eac06e the Sphinx tool is required
to build the rST documentation.
This fixes:
$ ./configure --enable-docs
ERROR: User requested feature docs
configure was not able to find it.
Install texinfo, Perl/perl-podlators and python-sphin
The pkg.mxe.cc repo has been restored.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
.shippable.yml | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/.shippable.yml b/.shippable.yml
index f2ffef21d11..f74a3de3ffd
From: Philippe Mathieu-Daudé
Since commit 5f71eac06e the Sphinx tool is required
to build the rST documentation.
This fixes:
$ ./configure --enable-docs
ERROR: User requested feature docs
configure was not able to find it.
Install texinfo, Perl/perl-podlators and python-sphin
From: Marc-André Lureau
"git archive" fails when a submodule has a modification, because "git
stash create" doesn't handle submodules. Let's teach our
archive-source.sh to handle modifications in submodules the same way
as qemu tree, by creating a stash.
Signed-off-by: Marc-André Lureau
Message
Hi,
This is my current queue for testing/next which I shall submit a PR
for on Tuesday in time for rc2. This update adds:
- fixes for Windows builds under docker (+installer)
- build fix for --no-default-devices
- tweak to docker DEBUG behaviour
- run iotests in make check
- use travis_
From: Philippe Mathieu-Daudé
Since commit 5f71eac06e the Sphinx tool is required
to build the rST documentation.
This fixes:
$ ./configure --enable-docs
ERROR: User requested feature docs
configure was not able to find it.
Install texinfo, Perl/perl-podlators and python-sphin
Quite often the information about which test failed is hidden by the
wall of repeated failures for each page. Stop outputting the error
after 10 bad pages and just summarise the total damage at the end.
Signed-off-by: Alex Bennée
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Thomas Huth
Revi
From: Philippe Mathieu-Daudé
The 'makeinfo' is required to generate the documentation from
the 'html' Makefile rule (called by 'install-doc').
The NSIS installer uses these files.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20190715174817.18981-6-phi...@redhat.com>
Signed-off-by: Alex Be
While fixing up pkg.mxe.cc they move the URLs around a bit and dropped
Jessie support in favour of Stretch. We also need to update the keys
used to verify the packages.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.in
From: Philippe Mathieu-Daudé
We correctly use the DEBIAN_FRONTEND environment variable on
the Debian images, but forgot the Ubuntu ones are based on it.
Since building docker images is not interactive, we need to
inform the APT tools about it using the DEBIAN_FRONTEND
environment variable (we al
Add yet another test type so we cna quickly exercise the miscellaneous
build products of the build system under various docer configurations.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/docker/test-misc | 22 ++
From: Philippe Mathieu-Daudé
This silents a bunch of warnings while compiling the Slirp objects:
$ make
[...]
CC slirp/src/tftp.o
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH enviro
On 17/07/2019 07:39, Nicholas Piggin wrote:
> H_PROD is added, and H_CEDE is modified to test the prod bit
> according to PAPR.
>
> Signed-off-by: Nicholas Piggin
> ---
> hw/ppc/spapr_hcall.c | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/hw/ppc/spapr_hc
On 7/17/19 11:22 AM, Laszlo Ersek wrote:
> On 07/17/19 10:36, Laszlo Ersek wrote:
>> On 07/16/19 22:10, Philippe Mathieu-Daudé wrote:
>>> On 7/16/19 8:42 PM, Laszlo Ersek wrote:
On 07/16/19 18:59, Peter Maydell wrote:
> On Tue, 16 Jul 2019 at 17:51, Laszlo Ersek
> wrote:
>> The is
Patchew URL:
https://patchew.org/QEMU/20190716145421.17645-1-yury-ko...@yandex-team.ru/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/ba
On Wed, Jul 17, 2019 at 03:46:55PM +1000, Nicholas Piggin wrote:
> This is a bit of proof of concept in case mttcg becomes more important
> yield could be handled like this. You can have by accident or deliberately
> force vCPUs onto the same physical CPU and cause inversion issues when the
> lock
On 16.07.19 18:37, Kevin Wolf wrote:
> Am 16.07.2019 um 18:24 hat Max Reitz geschrieben:
>> On 16.07.19 16:40, Kevin Wolf wrote:
>>> Am 19.06.2019 um 17:25 hat Max Reitz geschrieben:
Hi,
This is v2 to “block: Keep track of parent quiescing”.
Please read this cover letter, b
Patchew URL: https://patchew.org/QEMU/20190716145121.19578-1-tao3...@intel.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make d
On 7/16/19 11:04 AM, Thomas Huth wrote:
On 16/07/2019 15.06, Markus Armbruster wrote:
Paolo Bonzini writes:
On 15/07/19 18:12, Cornelia Huck wrote:
Is it INTx vs. MSI vs. MSI-X?
I think for s390x we need (INTx || MSI) vs MSI-X...
I think MSI vs MSI-X is just how it's configured, not the
On 07/17/19 11:22, Laszlo Ersek wrote:
> On 07/17/19 10:36, Laszlo Ersek wrote:
>> -assert(no_aa32 || cpu_isar_feature(arm_div, cpu));
>> +assert(!no_aa32 || !cpu_isar_feature(arm_div, cpu));
BTW this can be pronounced in natural language as follows: "we either
have aa32 support,
On 7/17/19 5:27 AM, Christian Borntraeger wrote:
On 17.07.19 10:54, Cornelia Huck wrote:
On Tue, 16 Jul 2019 14:34:22 -0400
Collin Walling wrote:
On 7/16/19 11:20 AM, Cornelia Huck wrote:
On Wed, 10 Jul 2019 10:20:41 +0200
Cornelia Huck wrote:
On Tue, 9 Jul 2019 18:55:34 -0400
Collin
Thomas Huth writes:
> Let's enable the block iotests during "make check" again, to avoid that
> they get broken so easily by accident (like we've seen many times in the
> past).
Queued to testing/next, thanks.
>
> v3:
> - Added dependency for "check-block" so that the *-softmmu targets are
>
On 17/07/2019 07:39, Nicholas Piggin wrote:
> Implement cpu_exec_enter/exit on ppc which calls into new methods of
> the same name in PPCVirtualHypervisorClass. These are used by spapr
> to implement these splpar elements, used in subsequent changes.
>
> Signed-off-by: Nicholas Piggin
This is ni
On 07/17/19 11:22, Laszlo Ersek wrote:
> because, (A --> B) === (!A --> !B)
Obviously, it is impossible for me to write an email containing logical
formulae without at least one *crucial* typo.
The correct form of the above equivalence is:
(A --> B) === (!B --> !A)
This typo does not affect
On 17.07.19 14:35, Thomas Huth wrote:
> FWIW, I've got a new iotest failure with current master branch:
>
> $ ./check -qed 141
> QEMU --
> "/tmp/qemu/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64"
> -nodefaults -machine accel=qtest
> QEMU_IMG -- "/tmp/qemu/tests/qemu-i
FWIW, I've got a new iotest failure with current master branch:
$ ./check -qed 141
QEMU --
"/tmp/qemu/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64"
-nodefaults -machine accel=qtest
QEMU_IMG -- "/tmp/qemu/tests/qemu-iotests/../../qemu-img"
QEMU_IO -- "/tmp/qemu/
在 2019/7/17 下午1:53, David Gibson 写道:
On Wed, Jul 17, 2019 at 10:33:00AM +0800, Fei Li wrote:
From: Fei Li
qemu_thread_create() abort()s on error. Not nice. Give it a return
value and an Error ** argument, so it can return success/failure.
Considering qemu_thread_create() is quite widely use
On 2019/7/17 下午7:00, Michael S. Tsirkin wrote:
On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote:
On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote:
On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote:
The VIRTIO_NET_F_CTRL_VLAN feature requires the support of
Hi Phil,
On 07/17/19 00:15, Philippe Mathieu-Daudé wrote:
> Hello it's me again, insisting with this series because there are at
> least 2 different report of guests bricked on reset due to the bug
> fixed by patch #5:
> https://bugzilla.redhat.com/show_bug.cgi?id=1678713
> https://bugzilla.redhat
Patchew URL:
https://patchew.org/QEMU/20190716121352.302-1-alex.ben...@linaro.org/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
ma
Am 17.07.2019 um 11:07 hat Max Reitz geschrieben:
> On 17.07.19 10:17, Kevin Wolf wrote:
> > Am 17.07.2019 um 09:47 hat Max Reitz geschrieben:
> >> On 16.07.19 19:01, Kevin Wolf wrote:
> >>> Am 03.07.2019 um 19:28 hat Max Reitz geschrieben:
> BDS.inherits_from does not always point to an immed
On Tue, 16 Jul 2019 14:56:32 -0600
Alex Williamson wrote:
> On Tue, 9 Jul 2019 15:19:08 +0530
> Kirti Wankhede wrote:
> > diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h
> > index 24f505199f83..6696a4600545 100644
> > --- a/linux-headers/linux/vfio.h
> > +++ b/linux-headers
On 08/07/2019 09.24, Marc-André Lureau wrote:
> Modify the behaviour of qtest_quit() to check against the expected
> exit status value. The default remains 0.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/libqtest.c | 41 ++---
> tests/libqtest.h | 9 +++
On 17.07.19 13:29, Michael S. Tsirkin wrote:
> On Wed, Jul 17, 2019 at 01:06:29PM +0200, David Hildenbrand wrote:
>> On 17.07.19 12:48, Michael S. Tsirkin wrote:
>>> On Wed, Jul 17, 2019 at 12:35:50PM +0200, David Hildenbrand wrote:
When a guest reboots (ordinary reboots, but also via kexec),
On Wed, Jul 17, 2019 at 01:28:19PM +0200, David Hildenbrand wrote:
> On 17.07.19 13:22, Michael S. Tsirkin wrote:
> > On Wed, Jul 17, 2019 at 01:10:21PM +0200, David Hildenbrand wrote:
> >> On 17.07.19 13:06, Michael S. Tsirkin wrote:
> >>> On Wed, Jul 17, 2019 at 12:17:57PM +0200, David Hildenbran
On Wed, Jul 17, 2019 at 01:06:29PM +0200, David Hildenbrand wrote:
> On 17.07.19 12:48, Michael S. Tsirkin wrote:
> > On Wed, Jul 17, 2019 at 12:35:50PM +0200, David Hildenbrand wrote:
> >> When a guest reboots (ordinary reboots, but also via kexec), it will
> >> happily reuse any system memory, in
On 17.07.19 13:22, Michael S. Tsirkin wrote:
> On Wed, Jul 17, 2019 at 01:10:21PM +0200, David Hildenbrand wrote:
>> On 17.07.19 13:06, Michael S. Tsirkin wrote:
>>> On Wed, Jul 17, 2019 at 12:17:57PM +0200, David Hildenbrand wrote:
On 17.07.19 12:04, David Hildenbrand wrote:
> On 17.07.19
On Wed, Jul 17, 2019 at 01:22:27PM +0200, Paolo Bonzini wrote:
> On 17/07/19 12:37, Michael S. Tsirkin wrote:
> > On Mon, Jun 24, 2019 at 05:02:00AM -0400, Igor Mammedov wrote:
> >> QEMU will crash when device-memory-region-size property is read if
> >> ms->device_memory
> >> wasn't initialized ye
On Wed, Jul 17, 2019 at 01:10:21PM +0200, David Hildenbrand wrote:
> On 17.07.19 13:06, Michael S. Tsirkin wrote:
> > On Wed, Jul 17, 2019 at 12:17:57PM +0200, David Hildenbrand wrote:
> >> On 17.07.19 12:04, David Hildenbrand wrote:
> >>> On 17.07.19 11:57, Michael S. Tsirkin wrote:
> On Wed,
On 17/07/19 12:37, Michael S. Tsirkin wrote:
> On Mon, Jun 24, 2019 at 05:02:00AM -0400, Igor Mammedov wrote:
>> QEMU will crash when device-memory-region-size property is read if
>> ms->device_memory
>> wasn't initialized yet.
>>
>> Crash can be reproduced with:
>> $QEMU -preconfig -qmp unix:qmp
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on certain file systems
like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
taking too much time.
Reviewed-by: Max Reitz
Signed-off-by: Thomas Huth
---
t
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 13 -
1 file changed, 4
Let's enable the block iotests during "make check" again, to avoid that
they get broken so easily by accident (like we've seen many times in the
past).
v3:
- Added dependency for "check-block" so that the *-softmmu targets are
now built first
- Added 197 and 215 back to gitlab-ci.yml (there i
People often forget to run the iotests before submitting patches or pull
requests - this is likely due to the fact that we do not run the tests
during our mandatory "make check" tests yet. Now that we've got a proper
"auto" group of iotests that should be fine to run in every environment,
we can en
The regular expressions in the "check" script currently expect that there
is always a space after the test number in the group file, so you can't
have a test in there without a group unless the line still ends with a
space - which is quite error prone since some editors might remove spaces
at the e
On 17.07.19 13:10, Michael S. Tsirkin wrote:
> On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
>> We are using the wrong functions to set/clear bits, effectively touching
>> multiple bits, writing out of range of the bitmap, resulting in memory
>> corruptions. We have to use set_
On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
> We are using the wrong functions to set/clear bits, effectively touching
> multiple bits, writing out of range of the bitmap, resulting in memory
> corruptions. We have to use set_bit()/clear_bit() instead.
>
> Can easily be repr
On 17.07.19 13:06, Michael S. Tsirkin wrote:
> On Wed, Jul 17, 2019 at 12:17:57PM +0200, David Hildenbrand wrote:
>> On 17.07.19 12:04, David Hildenbrand wrote:
>>> On 17.07.19 11:57, Michael S. Tsirkin wrote:
On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
> We are usin
On Wed, Jul 17, 2019 at 12:17:57PM +0200, David Hildenbrand wrote:
> On 17.07.19 12:04, David Hildenbrand wrote:
> > On 17.07.19 11:57, Michael S. Tsirkin wrote:
> >> On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
> >>> We are using the wrong functions to set/clear bits, effecti
On 17.07.19 12:48, Michael S. Tsirkin wrote:
> On Wed, Jul 17, 2019 at 12:35:50PM +0200, David Hildenbrand wrote:
>> When a guest reboots (ordinary reboots, but also via kexec), it will
>> happily reuse any system memory, including previously inflated memory.
>>
>> We could have tracking data for a
Cédric Le Goater's on July 17, 2019 8:16 pm:
> On 17/07/2019 07:39, Nicholas Piggin wrote:
>> H_PROD is added, and H_CEDE is modified to test the prod bit
>> according to PAPR.
>>
>> Signed-off-by: Nicholas Piggin
>> ---
>> hw/ppc/spapr_hcall.c | 29 +
>> 1 file chang
On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote:
> On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote:
> > On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote:
> > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of
> > > vhost-user backend. But it will be a
On Wed, Jul 17, 2019 at 12:35:50PM +0200, David Hildenbrand wrote:
> When a guest reboots (ordinary reboots, but also via kexec), it will
> happily reuse any system memory, including previously inflated memory.
>
> We could have tracking data for a pbp (PartiallyBalloonedPage). It could
> happen t
On Wed, 17 Jul 2019 03:20:31 -0500
Shivaprasad G Bhat wrote:
> Free all SpaprOptionVector local pointers after use.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr_hcall.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b
On Wed, 17 Jul 2019 03:20:01 -0500
Shivaprasad G Bhat wrote:
> Leaking the drc_name while preparing the DT properties.
> Fixing that.
>
> Also, remove the const qualifier from spapr_drc_name().
>
> Signed-off-by: Shivaprasad G Bhat
> ---
> hw/ppc/spapr_drc.c |7 +--
> 1 file changed,
On Wed, 17 Jul 2019 03:19:43 -0500
Shivaprasad G Bhat wrote:
> Free the capability name string after setting
> the capability.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr_caps.c |4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --g
We could have tracking data for a pbp (PartiallyBalloonedPage)
allocated. Let's free it.
Fixes: ed48c59875b6 ("virtio-balloon: Safely handle BALLOON_PAGE_SIZE <
host page size")
Cc: qemu-sta...@nongnu.org #v4.0.0
Cc: Stefan Hajnoczi
Cc: David Gibson
Cc: Michael S. Tsirkin
C
On Mon, Jun 24, 2019 at 05:02:00AM -0400, Igor Mammedov wrote:
> QEMU will crash when device-memory-region-size property is read if
> ms->device_memory
> wasn't initialized yet.
>
> Crash can be reproduced with:
> $QEMU -preconfig -qmp unix:qmp_socket,server,nowait &
> ./scripts/qmp/qom-get -s
When a guest reboots (ordinary reboots, but also via kexec), it will
happily reuse any system memory, including previously inflated memory.
We could have tracking data for a pbp (PartiallyBalloonedPage). It could
happen that a new inflation request from the guest will result in a
discard of such a
We are using the wrong functions to set/clear bits, effectively touching
multiple bits, writing out of range of the bitmap, resulting in memory
corruptions. We have to use set_bit()/clear_bit() instead.
Can easily be reproduced by starting a qemu guest on hugetlbfs memory,
inflating the balloon. Q
On Wed, Jul 17, 2019 at 11:14:53AM +0100, Stefan Hajnoczi wrote:
> On Mon, Jun 24, 2019 at 10:13:04AM +0100, Stefan Hajnoczi wrote:
> > The vhost-user specification does not explain when
> > VHOST_USER_PROTOCOL_F_MQ must be implemented. This may lead
> > implementors of vhost-user masters to belie
Some v4.1 (also v4.0 stable) fixes for virtio-balloon that only trigger
when the pagesize is > BALLOON_PAGE_SIZE (4k).
v1 -> v2:
- Added "virtio-balloon: fix memory leak on unrealize()"
- Added "virtio-balloon: reset pbp on device resets"
Cc: Stefan Hajnoczi
Cc: David Gibson
Cc: Michael S. Tsir
On Wed, 17 Jul 2019 17:06:36 +1000
Alexey Kardashevskiy wrote:
> The pseries guests do not normally allocate PCI resources and rely on
> the system firmware doing so. Furthermore at least at some point in
> the past the pseries guests won't even allowed to change BARs, probably
> it is still the
Hi, I'm a bit worried that this patch might have been forgotten.
Is it queued? Thanks!
14.06.2019, 19:56, "Dr. David Alan Gilbert" :
> * Yury Kotov (yury-ko...@yandex-team.ru) wrote:
>> Currently, there is no information about error if outgoing migration was
>> failed
>> because of file channel
On 17.07.19 12:04, David Hildenbrand wrote:
> On 17.07.19 11:57, Michael S. Tsirkin wrote:
>> On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
>>> We are using the wrong functions to set/clear bits, effectively touching
>>> multiple bits, writing out of range of the bitmap, result
On 17/07/2019 07:39, Nicholas Piggin wrote:
> H_PROD is added, and H_CEDE is modified to test the prod bit
> according to PAPR.
>
> Signed-off-by: Nicholas Piggin
> ---
> hw/ppc/spapr_hcall.c | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/hw/ppc/spapr_hc
On Mon, Jun 24, 2019 at 10:13:04AM +0100, Stefan Hajnoczi wrote:
> The vhost-user specification does not explain when
> VHOST_USER_PROTOCOL_F_MQ must be implemented. This may lead
> implementors of vhost-user masters to believe that this protocol feature
> is required for any device that has multi
On 17/07/19 07:57, tony.ngu...@bt.com wrote:
> This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE.
>
> It is an attempt of the instructions outlined by Richard Henderson to Mark
> Cave-Ayland.
>
> Tested with OpenBSD on sun4u. Solaris 10 is my actual goal, but unfortunately
>
On 17/07/19 08:06, tony.ngu...@bt.com wrote:
> +
> +static inline MemOp MEMOP(unsigned size)
> +{
> +switch (size) {
> +case 1:
> +return MO_8;
> +case 2:
> +return MO_16;
> +case 4:
> +return MO_32;
> +case 8:
> +return MO_64;
> +default:
> +
Le 14/07/2019 à 18:19, John Paul Adrian Glaubitz a écrit :
> Hi!
>
>> On Jul 14, 2019, at 3:40 PM, Laurent Vivier wrote:
>>
>> Add --preserve-arg0 in qemu-binfmt-conf.sh to configure the preserve-arg0
>> flag.
>>
>> Now, if QEMU is started with -0 or QEMU_ARGV0 and an empty parameter
>> argv[0] (
On 17.07.19 11:57, Michael S. Tsirkin wrote:
> On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
>> We are using the wrong functions to set/clear bits, effectively touching
>> multiple bits, writing out of range of the bitmap, resulting in memory
>> corruptions. We have to use set_
On Wed, Jul 17, 2019 at 10:42:55AM +0200, David Hildenbrand wrote:
> We are using the wrong functions to set/clear bits, effectively touching
> multiple bits, writing out of range of the bitmap, resulting in memory
> corruptions. We have to use set_bit()/clear_bit() instead.
>
> Can easily be repr
101 - 200 of 246 matches
Mail list logo
