[Qemu-devel] [PULL 20/23] tests/qemu-iotests/check: Allow tests without groups

2019-07-23 Thread Alex Bennée
From: Thomas Huth The regular expressions in the "check" script currently expect that there is always a space after the test number in the group file, so you can't have a test in there without a group unless the line still ends with a space - which is quite error prone since some editors might re

[Qemu-devel] [PULL 14/23] buildsys: The NSIS Windows build requires qemu-nsis.bmp installed

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé The qemu-nsis.bmp file was not listed with the other blobs, thus not installed in the ${BINDIR} location. This fixes: $ make installer [...] (cd /tmp/qemu-nsis; \ for i in qemu-system-*.exe; do \ arch=${i%.exe}; \ arch=${ar

[Qemu-devel] [PULL 13/23] buildsys: The NSIS Windows build requires the documentation installed

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé This fixes: $ make installer [...] (cd /tmp/qemu-nsis; \ for i in qemu-system-*.exe; do \ arch=${i%.exe}; \ arch=${arch#qemu-system-}; \ echo Section \"$arch\" Section_$arch; \ echo SetOutPath \"\$I

[Qemu-devel] [PULL 17/23] hw/i386: also turn off VMMOUSE is VMPORT is disabled

2019-07-23 Thread Alex Bennée
Commit 97fd1ea8c1 broke the build for --without-default-devices as VMMOUSE depends on VMPORT. Fixes: 97fd1ea8c1 Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index b9c96ac361e..6350438036f 100644 --- a/hw/

[Qemu-devel] [PULL 21/23] tests/qemu-iotests/group: Remove some more tests from the "auto" group

2019-07-23 Thread Alex Bennée
From: Thomas Huth Remove some more tests from the "auto" group that either have issues in certain environments (like macOS or FreeBSD, or on certain file systems like ZFS or tmpfs), do not work with the qcow2 format, or that are simply taking too much time. Reviewed-by: Max Reitz Signed-off-by:

[Qemu-devel] [PULL 19/23] tests/docker: invoke the DEBUG shell with --noprofile/--norc

2019-07-23 Thread Alex Bennée
It's very confusing when things work in the debug shell because the environment is different from what the test is running. Fix this by ensuring we only have the inherited environment from the run shell. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/docker/ru

[Qemu-devel] [PULL 16/23] NSIS: Add missing firmware blobs

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Various firmwares has been added in the pc-bios/ directory: - CCW (since commit 0c1fecdd523) - skiboot (since commit bcad45de6a0) - EDK2(since commit f7fa38b74c3) Since we install qemu-system able to run the architectures targetted by these firmware, include

[Qemu-devel] [PULL 18/23] travis: enable travis_retry for check phase

2019-07-23 Thread Alex Bennée
We have some flaky tests and usually the test passes on a retry. Enable travis_retry for the test phase and see if that helps keep things green. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.travis.yml index 5d3d6ee1d32..caf0a1f8faf 100644 --- a/.tra

[Qemu-devel] [PULL 22/23] tests: Run the iotests during "make check" again

2019-07-23 Thread Alex Bennée
From: Thomas Huth People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a proper "auto" group of iotests that should be fine to run in every en

[Qemu-devel] [PULL 15/23] tests/docker: Let the test-mingw test generate a NSIS installer

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé The NSIS installer generates an executable suitable to install QEMU on Windows. Suggested-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190715174817.18981-9-phi...@redhat.com> [AJB: also --enable-docs in configure step] Signed-off-by: Alex Be

Re: [Qemu-devel] [PULL v2 0/2] pflash-next patches for v4.1.0-rc2

2019-07-23 Thread Peter Maydell
00) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/pflash-next-20190723 > > for you to fetch changes up to 124e4cfaa42bb5a14eec33ea47d3502b5f46eb33: > > hw/block/pflash_cfi02: Rewrite

[Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ

2019-07-23 Thread P J P
From: Prasad J Pandit Hello, Linux net_deivce defines network interface name to be of IFNAMSIZE(=16) bytes, including the terminating null('\0') byte. Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the network bridge interface, supplies bridge name of 16 characters, thus al

[Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-23 Thread P J P
From: Prasad J Pandit The network interface name in Linux is defined to be of size IFNAMSIZ(=16), including the terminating null('\0') byte. The same is applied to interface names read from 'bridge.conf' file to form ACL rules. If user supplied '--br=bridge' name is not restricted to the same len

[Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread P J P
From: Prasad J Pandit When invoking qemu-bridge-helper in 'net_bridge_run_helper', instead of using fixed sized buffers, use dynamically allocated ones initialised and returned by g_strdup_printf(). Signed-off-by: Prasad J Pandit --- net/tap.c | 19 +++ 1 file changed, 11 inser

[Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-23 Thread P J P
From: Prasad J Pandit Move repeating error handling sequence in parse_acl_file routine to an 'err' label. Signed-off-by: Prasad J Pandit --- qemu-bridge-helper.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) Reviewed v3: -> https://lists.nongnu.org/archive/html/

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 23.07.2019 um 12:21 hat Max Reitz geschrieben: > On 23.07.19 12:02, Kevin Wolf wrote: > > Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: > >> On 23.07.19 10:52, Kevin Wolf wrote: > >>> Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > bdrv_set_aio_context_ignore() can only work in the

[Qemu-devel] [PATCH] tests/qemu-iotests: Don't use 'seq' in the iotests

2019-07-23 Thread Thomas Huth
The 'seq' command is not available by default on OpenBSD, so these iotests are currently failing there. It could be installed as 'gseq' from the coreutils package - but since it is using a different name there and we are running the iotests with the "bash" shell anyway, let's simply use the built-i

Re: [Qemu-devel] [PATCH] tests/qemu-iotests: Don't use 'seq' in the iotests

2019-07-23 Thread Philippe Mathieu-Daudé
Cc'ing Brad, the OpenBSD maintainer. On 7/23/19 1:12 PM, Thomas Huth wrote: > The 'seq' command is not available by default on OpenBSD, so these > iotests are currently failing there. It could be installed as 'gseq' > from the coreutils package - but since it is using a different name > there and

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 10:47:39AM +0100, Stefan Hajnoczi wrote: > On Tue, Jul 23, 2019 at 9:43 AM Sergio Lopez wrote: > > Montes, Julio writes: > > > > > On Fri, 2019-07-19 at 16:09 +0100, Stefan Hajnoczi wrote: > > >> On Fri, Jul 19, 2019 at 2:48 PM Sergio Lopez wrote: > > >> > Stefan Hajnoczi

[Qemu-devel] [PATCH for 4.2] target/arm: generate a custom MIDR for -cpu max

2019-07-23 Thread Alex Bennée
While most features are now detected by probing the ID_* registers kernels can (and do) use MIDR_EL1 for working out of they have to apply errata. This can trip up warnings in the kernel as it tries to work out if it should apply workarounds to features that don't actually exist in the reported CPU

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Alex Bennée
Peter Maydell writes: > On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: >> >> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >> >> Merge remote-tracking branch >> 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 >> 15:16:48 +0100) >>

Re: [Qemu-devel] [PATCH for 4.2] target/arm: generate a custom MIDR for -cpu max

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 12:33, Alex Bennée wrote: > > While most features are now detected by probing the ID_* registers > kernels can (and do) use MIDR_EL1 for working out of they have to > apply errata. This can trip up warnings in the kernel as it tries to > work out if it should apply workaroun

Re: [Qemu-devel] [PULL v2 1/2] hw/block/pflash_cfi01: Add missing DeviceReset() handler

2019-07-23 Thread Laszlo Ersek
On 07/23/19 11:35, Philippe Mathieu-Daudé wrote: > To avoid incoherent states when the machine resets (see bug report > below), add the device reset callback. > > A "system reset" sets the device state machine in READ_ARRAY mode > and, after some delay, set the SR.7 READY bit. > > Since we do not

[Qemu-devel] [PATCH] docs: correct kconfig option

2019-07-23 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/devel/kconfig.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst index d6f8eb0977..b7bca44704 100644 --- a/docs/devel/kconfig.rst +++ b/docs/devel/kconfig.rst @@ -267,7 +267,7 @@ the def

[Qemu-devel] [PATCH-for-4.2 1/2] target/riscv/pmp: Restrict priviledged PMP to system-mode emulation

2019-07-23 Thread Philippe Mathieu-Daudé
The RISC-V Physical Memory Protection is restricted to privileged modes. Restrict its compilation to QEMU system builds. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/Makefile.objs | 3 ++- target/riscv/pmp.c | 4 2 files changed, 2 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH-for-4.2 0/2] target/riscv/pmp: Convert to trace events

2019-07-23 Thread Philippe Mathieu-Daudé
Trivial convertion, suggested on https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg04728.html Philippe Mathieu-Daudé (2): target/riscv/pmp: Restrict priviledged PMP to system-mode emulation target/riscv/pmp: Convert qemu_log_mask(LOG_TRACE) to trace events target/riscv/Makefile.objs |

[Qemu-devel] [PATCH-for-4.2 2/2] target/riscv/pmp: Convert qemu_log_mask(LOG_TRACE) to trace events

2019-07-23 Thread Philippe Mathieu-Daudé
Use the always-compiled trace events, remove the now unused RISCV_DEBUG_PMP definition. Note pmpaddr_csr_read() could previously do out-of-bound accesses passing addr_index >= MAX_RISCV_PMPS. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/pmp.c| 31 ++

Re: [Qemu-devel] [PATCH] docs: correct kconfig option

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 2:08 PM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > docs/devel/kconfig.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst > index d6f8eb0977..b7bca44704 100644 > --- a/docs/devel/kconfig

Re: [Qemu-devel] [PATCH v7 01/13] vfio: KABI for migration interface

2019-07-23 Thread Cornelia Huck
On Tue, 16 Jul 2019 14:56:32 -0600 Alex Williamson wrote: > On Tue, 9 Jul 2019 15:19:08 +0530 > Kirti Wankhede wrote: I'm still a bit unsure about the device_state bit handling as well. > > + * device_state: (read/write) > > + * To indicate vendor driver the state VFIO device should be >

[Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-07-23 Thread Marc-André Lureau
This is a left-over from commit c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule") Signed-off-by: Marc-André Lureau --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index ad0b8582bf..82c65ab46a 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 1:46 PM, Alex Bennée wrote: > > Peter Maydell writes: > >> On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: >>> >>> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >>> >>> Merge remote-tracking branch >>> 'remotes/pmaydell/tags/pull-target-arm-20190722

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2019-07-23 Thread Peter Maydell
The 'qemucrash' test case from this bug still crashes as of current head-of-git (4.1 rc1). ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1696773 T

[Qemu-devel] [Bug 1818937] Re: Crash with HV_ERROR on macOS host

2019-07-23 Thread Gergely Kis
Hi Roman, thanks for the patch, we were able to reproduce this issue with our custom Android Cuttlefish based d VM (running 4.14 kernel): 2019-07-23T11:36:37.180753Z qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.8001H:ECX.svm [bit 2] 2019-07-23T11:36:37.182517Z q

[Qemu-devel] The WCE issue in guest when i enable WCE in Qemu side.

2019-07-23 Thread Zhong, Yang
Hello all, I am using the Qemu/SPDK to do vhost-user-blk verification, and the qemu command as below: ./qemu-system-x86_64 \ -machine q35,accel=kvm \ -cpu host -m 1024,maxmem=20G,slots=2 -smp 6 \ -kernel ./../linux-stable/arch/x86/boot/bzImage \ -append 'root=/dev/vdb3 rw rootfs

Re: [Qemu-devel] [PULL 0/2] MIPS queue for July 23rd, 2019

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 11:18, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé wrote: > > On 7/23/19 1:46 PM, Alex Bennée wrote: > >> I see Thomas Huth has a patch on-list for that, but this > >> didn't manifest as a problem before this pullreq. > > > > OK, I'll add it and rebuild the PR. > > But Thomas got another error l

Re: [Qemu-devel] [PATCH-for-4.2 v7 09/10] hw/arm: Use GED for system_powerdown event

2019-07-23 Thread Igor Mammedov
On Mon, 22 Jul 2019 14:15:17 + Shameerali Kolothum Thodi wrote: > > -Original Message- > > From: Qemu-devel > > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nongn > > u.org] On Behalf Of Igor Mammedov > > Sent: 18 July 2019 14:03 > > To: Shameerali Kolothum Thodi >

Re: [Qemu-devel] [PATCH v7 05/13] vfio: Add migration region initialization and finalize function

2019-07-23 Thread Cornelia Huck
On Tue, 9 Jul 2019 15:19:12 +0530 Kirti Wankhede wrote: > - Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this > patch series. > - VFIO device supports migration or not is decided based of migration region > query. If migration region query is successful and migration

Re: [Qemu-devel] [PATCH v2 0/2] Avoid sending zero-size packets

2019-07-23 Thread Stefan Hajnoczi
On Mon, Jul 22, 2019 at 01:24:44PM +, Oleinik, Alexander wrote: > While fuzzing the virtio-net tx vq, I ran into an assertion failure due > to iov_copy offsets larger than the total iov size. Though there is > a check to cover this, it does not execute when !n->has_vnet_hdr. This > patch tries

Re: [Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 2:16 PM, Marc-André Lureau wrote: > This is a left-over from commit > c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule") > > Signed-off-by: Marc-André Lureau > --- > configure | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/configure b/configure > index

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/23/19 1:46 PM, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: Merge remote-tracking branch >>

Re: [Qemu-devel] [PATCH-for-4.2 v7 10/10] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

2019-07-23 Thread Igor Mammedov
On Mon, 22 Jul 2019 14:51:59 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Qemu-devel > > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nongn > > u.org] On Behalf Of Igor Mammedov > > Sent: 18 July 2019 14:13 > > To: Shameerali Kol

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Alex Bennée
Peter Maydell writes: > On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé > wrote: >> >> On 7/23/19 1:46 PM, Alex Bennée wrote: >> >> I see Thomas Huth has a patch on-list for that, but this >> >> didn't manifest as a problem before this pullreq. >> > >> > OK, I'll add it and rebuild the P

Re: [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-23 Thread Stefan Hajnoczi
On Tue, Jul 23, 2019 at 04:17:53PM +0530, P J P wrote: > From: Prasad J Pandit > > Move repeating error handling sequence in parse_acl_file routine > to an 'err' label. > > Signed-off-by: Prasad J Pandit > --- > qemu-bridge-helper.c | 19 +-- > 1 file changed, 9 insertions(+),

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 13:58, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé > > wrote: > >> > >> On 7/23/19 1:46 PM, Alex Bennée wrote: > >> >> I see Thomas Huth has a patch on-list for that, but this > >> >> didn't manifest as a probl

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread Stefan Hajnoczi
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > -snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s", > - helper, "--use-vnet", fd_buf, br_buf); > +helper_cmd = g_strdup_printf("%s %s %s %s", helper, > +"--use-vnet"

Re: [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-23 Thread Stefan Hajnoczi
On Tue, Jul 23, 2019 at 04:17:52PM +0530, P J P wrote: > From: Prasad J Pandit > > The network interface name in Linux is defined to be of size > IFNAMSIZ(=16), including the terminating null('\0') byte. > The same is applied to interface names read from 'bridge.conf' > file to form ACL rules. If

Re: [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2019 at 04:17:52PM +0530, P J P wrote: > From: Prasad J Pandit > > The network interface name in Linux is defined to be of size > IFNAMSIZ(=16), including the terminating null('\0') byte. > The same is applied to interface names read from 'bridge.conf' > file to form ACL rules. If

Re: [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2019 at 04:17:53PM +0530, P J P wrote: > From: Prasad J Pandit > > Move repeating error handling sequence in parse_acl_file routine > to an 'err' label. > > Signed-off-by: Prasad J Pandit > --- > qemu-bridge-helper.c | 19 +-- > 1 file changed, 9 insertions(+),

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > From: Prasad J Pandit > > When invoking qemu-bridge-helper in 'net_bridge_run_helper', > instead of using fixed sized buffers, use dynamically allocated > ones initialised and returned by g_strdup_printf(). > > Signed-off-by: Prasad J Pand

Re: [Qemu-devel] [PATCH v7 12/13] vfio: Add vfio_listerner_log_sync to mark dirty pages

2019-07-23 Thread Cornelia Huck
On Tue, 9 Jul 2019 15:19:19 +0530 Kirti Wankhede wrote: > vfio_listerner_log_sync gets list of dirty pages from vendor driver and mark s/listerner/listener/ (here and in the code) > those pages dirty when in _SAVING state. > Return early for the RAM block section of mapped MMIO region. > > Sig

[Qemu-devel] [PULL v2 00/22 for 4.1] testing updates

2019-07-23 Thread Alex Bennée
The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-2

Re: [Qemu-devel] [PATCH] tests/qemu-iotests: Don't use 'seq' in the iotests

2019-07-23 Thread Eric Blake
On 7/23/19 6:12 AM, Thomas Huth wrote: > The 'seq' command is not available by default on OpenBSD, so these > iotests are currently failing there. It could be installed as 'gseq' > from the coreutils package - but since it is using a different name > there and we are running the iotests with the "b

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 12:46, Alex Bennée wrote: > Odd. Does: > > make docker-image-debian10 V=1 > > fail for you? Yes. The files apt tries to download do not appear to be on the mirror: e104462:bionic:all-linux-static$ make docker-image-debian10 V=1 /home/petmay01/linaro/qemu-for-merges/tests/

[Qemu-devel] [PATCH v4 2/3] cpus: Fix throttling during vm_stop

2019-07-23 Thread Yury Kotov
Throttling thread sleeps in VCPU thread. For high throttle percentage this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. vm_stop() kicks all VCPUs and waits for them. It's called at the end of migration and because of the long sleep the migration downtime might be more than 100ms e

[Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct

2019-07-23 Thread Yury Kotov
Hi, V4: * The test was simplified to prevent false fails. V3: * Rebase fixes (migrate_set_parameter -> migrate_set_parameter_int) V2: * Added a test * Fixed qemu_cond_timedwait for qsp I wrote a test for migration auto converge and found out a strange thing: 1. Enable auto converge 2. Set max-b

[Qemu-devel] [PATCH v4 1/3] qemu-thread: Add qemu_cond_timedwait

2019-07-23 Thread Yury Kotov
Signed-off-by: Yury Kotov --- include/qemu/thread.h| 18 ++ util/qemu-thread-posix.c | 40 util/qemu-thread-win32.c | 16 util/qsp.c | 18 ++ 4 files changed, 80 insertions(+), 12 deletions

[Qemu-devel] [PATCH v4 3/3] tests/migration: Add a test for auto converge

2019-07-23 Thread Yury Kotov
Signed-off-by: Yury Kotov --- tests/migration-test.c | 103 - 1 file changed, 92 insertions(+), 11 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index a4feb9545d..b783ae47b3 100644 --- a/tests/migration-test.c +++ b/tests/migrat

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 3:33 PM, Peter Maydell wrote: > On Tue, 23 Jul 2019 at 12:46, Alex Bennée wrote: >> Odd. Does: >> >> make docker-image-debian10 V=1 >> >> fail for you? > > Yes. The files apt tries to download do not appear to be > on the mirror: > e104462:bionic:all-linux-static$ make docker-image-d

Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

2019-07-23 Thread Eduardo Habkost
On Fri, Jul 12, 2019 at 03:43:07PM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > v2: Remove also max_cpus (merci à Laurent Vivier ) > > include/sysemu/sysemu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 98

Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

2019-07-23 Thread Laurent Vivier
Le 23/07/2019 à 15:53, Eduardo Habkost a écrit : > On Fri, Jul 12, 2019 at 03:43:07PM +0200, Stefan Weil wrote: >> Signed-off-by: Stefan Weil >> --- >> v2: Remove also max_cpus (merci à Laurent Vivier ) >> >> include/sysemu/sysemu.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/inc

[Qemu-devel] [Bug 1670170] Re: `qemu-system-sparc64 -M Niagara` Aborted (core dumped)

2019-07-23 Thread lentilwal...@hotmail.com
not to pester anyone but it's back. moo-PowerEdge-R710 Downloads # qemu-system-sparc64 -version QEMU emulator version 4.0.91 Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers moo-PowerEdge-R710 Downloads # qemu-system-sparc64 -machine niagara Could not open option rom 'nvra

[Qemu-devel] [Bug 1670170] Re: `qemu-system-sparc64 -M Niagara` Aborted (core dumped)

2019-07-23 Thread lentilwal...@hotmail.com
S10image directory in this archive holds the rom images in case anyone is looking http://download.oracle.com/technetwork/systems/opensparc/OpenSPARCT1_Arch.1.5.tar.bz2 not that it really helps for qemu-4.1.0-rc1 moo-PowerEdge-R710 qemu-4.1.0-rc1 # qemu-system-sparc64 -machine niagara qemu: f

[Qemu-devel] [PATCH v2 0/2] pc: mmap kernel (ELF image) and initrd

2019-07-23 Thread Stefano Garzarella
In order to reduce the memory footprint when PVH kernel and initrd are used, we map them into memory instead of reading them. In this way we can share them between multiple instances of QEMU. v2: - Patch 1: used g_mapped_file_new_from_fd() with 'writeble' set to 'true', since we can mod

[Qemu-devel] [PATCH v2 2/2] hw/i386/pc: Map into memory the initrd

2019-07-23 Thread Stefano Garzarella
In order to reduce the memory footprint we map into memory the initrd using g_mapped_file_new() instead of reading it. In this way we can share the initrd pages between multiple instances of QEMU. Suggested-by: Paolo Bonzini Signed-off-by: Stefano Garzarella --- hw/i386/pc.c | 15 +++---

[Qemu-devel] [PATCH v2 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Stefano Garzarella
In order to reduce the memory footprint we map into memory the ELF to load using g_mapped_file_new_from_fd() instead of reading each sections. In this way we can share the ELF pages between multiple instances of QEMU. Suggested-by: Dr. David Alan Gilbert Suggested-by: Paolo Bonzini Signed-off-by

Re: [Qemu-devel] [PULL v2 00/22 for 4.1] testing updates

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 14:31, Alex Bennée wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100) > > are available in the Git reposito

[Qemu-devel] [PATCH] tests/docker: Refresh APT cache before installing new packages on Debian

2019-07-23 Thread Philippe Mathieu-Daudé
Since docker caches the different layers, updating the package list does not invalidate the previous "apt-get update" layer, and it is likely "apt-get install" hits an outdated repository. See commit beac6a98f6eb and https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get

Re: [Qemu-devel] [PATCH v2 2/2] hw/i386/pc: Map into memory the initrd

2019-07-23 Thread Paolo Bonzini
On 23/07/19 16:04, Stefano Garzarella wrote: > In order to reduce the memory footprint we map into memory > the initrd using g_mapped_file_new() instead of reading it. > In this way we can share the initrd pages between multiple > instances of QEMU. > > Suggested-by: Paolo Bonzini > Signed-off-by

Re: [Qemu-devel] [PATCH v2 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Paolo Bonzini
On 23/07/19 16:04, Stefano Garzarella wrote: > +/* Increments the reference count to avoid the unmap */ > +g_mapped_file_ref(gmf); > /* rom_add_elf_program() seize the ownership of 'data' */ > rom_add_elf_program(labe

Re: [Qemu-devel] [PATCH v2 2/2] hw/i386/pc: Map into memory the initrd

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 04:30:17PM +0200, Paolo Bonzini wrote: > On 23/07/19 16:04, Stefano Garzarella wrote: > > In order to reduce the memory footprint we map into memory > > the initrd using g_mapped_file_new() instead of reading it. > > In this way we can share the initrd pages between multiple

Re: [Qemu-devel] [PATCH v7 02/11] numa: move numa global variable nb_numa_nodes into MachineState

2019-07-23 Thread Igor Mammedov
On Tue, 16 Jul 2019 22:51:12 +0800 Tao Xu wrote: > Add struct NumaState in MachineState and move existing numa global > nb_numa_nodes(renamed as "num_nodes") into NumaState. And add variable > numa_support into MachineClass to decide which submachines support NUMA. > > Suggested-by: Igor Mammedo

Re: [Qemu-devel] [PATCH v2 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 04:33:44PM +0200, Paolo Bonzini wrote: > On 23/07/19 16:04, Stefano Garzarella wrote: > > +/* Increments the reference count to avoid the unmap */ > > +g_mapped_file_ref(gmf); > > /* rom_add_elf_program() seize the

Re: [Qemu-devel] [PATCH v7 01/11] hw/arm: simplify arm_load_dtb

2019-07-23 Thread Igor Mammedov
On Tue, 16 Jul 2019 22:51:11 +0800 Tao Xu wrote: > In struct arm_boot_info, kernel_filename, initrd_filename and > kernel_cmdline are copied from from MachineState. This patch add > MachineState as a parameter into arm_load_dtb() and move the copy chunk > of kernel_filename, initrd_filename and k

Re: [Qemu-devel] [PATCH v2 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Paolo Bonzini
On 23/07/19 16:57, Stefano Garzarella wrote: > On Tue, Jul 23, 2019 at 04:33:44PM +0200, Paolo Bonzini wrote: >> Since this is the only call to rom_add_elf_program, what about adding a >> GMappedFile* field to struct Rom and passing it here instead of >> data+file_size? > > Ehm, we currently use a

Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

2019-07-23 Thread Eduardo Habkost
On Tue, Jul 23, 2019 at 03:54:56PM +0200, Laurent Vivier wrote: > Le 23/07/2019 à 15:53, Eduardo Habkost a écrit : > > On Fri, Jul 12, 2019 at 03:43:07PM +0200, Stefan Weil wrote: > >> Signed-off-by: Stefan Weil > >> --- > >> v2: Remove also max_cpus (merci à Laurent Vivier ) > >> > >> include/sy

Re: [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-23 Thread Li Qiang
P J P 于2019年7月23日周二 下午6:50写道: > From: Prasad J Pandit > > The network interface name in Linux is defined to be of size > IFNAMSIZ(=16), including the terminating null('\0') byte. > The same is applied to interface names read from 'bridge.conf' > file to form ACL rules. If user supplied '--br=bri

Re: [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-23 Thread Li Qiang
P J P 于2019年7月23日周二 下午6:50写道: > From: Prasad J Pandit > > Move repeating error handling sequence in parse_acl_file routine > to an 'err' label. > > Signed-off-by: Prasad J Pandit > Reviewed-by: Li Qiang > --- > qemu-bridge-helper.c | 19 +-- > 1 file changed, 9 insertions(+

Re: [Qemu-devel] [PATCH v7 02/11] numa: move numa global variable nb_numa_nodes into MachineState

2019-07-23 Thread Eduardo Habkost
On Tue, Jul 23, 2019 at 04:56:41PM +0200, Igor Mammedov wrote: > On Tue, 16 Jul 2019 22:51:12 +0800 > Tao Xu wrote: > > > Add struct NumaState in MachineState and move existing numa global > > nb_numa_nodes(renamed as "num_nodes") into NumaState. And add variable > > numa_support into MachineClas

Re: [Qemu-devel] The WCE issue in guest when i enable WCE in Qemu side.

2019-07-23 Thread Paolo Bonzini
On 23/07/19 14:17, Zhong, Yang wrote: > When I set config-wce=true or false, the below value never change > root@unicorn ~ # cat /sys/block/vda/cache_type > write back > root@unicorn ~ # cat /sys/block/vda/device/features > 0010 0010 0110 0110 1000 1000

[Qemu-devel] [PULL v3 for 4.1 00/23] testing updates

2019-07-23 Thread Alex Bennée
The following changes since commit 4da6c0f9ebbdaaf4315c71ccd288d02b9087f8af: Merge remote-tracking branch 'remotes/amarkovic2/tags/mips-queue-jul-23-2019' into staging (2019-07-23 12:49:39 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-2

Re: [Qemu-devel] [PATCH] migration/multifd: multifd_load_cleanup() always return 0

2019-07-23 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > multifd_load_cleanup() always return 0 and never use the errp, just > cleanup a little. > > Signed-off-by: Wei Yang I'd rather leave this; it wouldn't be that odd for us to add an error check there later. Dave > --- > migration/migration.c |

Re: [Qemu-devel] [PATCH] migration/postcopy: use static PostcopyDiscardState instead of allocating it for each block

2019-07-23 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Fri, Jul 19, 2019 at 06:41:28PM +0100, Dr. David Alan Gilbert wrote: > >* Wei Yang (richardw.y...@linux.intel.com) wrote: > >> Even we need to do discard for each RAMBlock, we still can leverage the > >> same memory space to store the informati

Re: [Qemu-devel] [PATCH 1/2] migration: return -EINVAL directly when version_id mismatch

2019-07-23 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > It is not reasonable to continue when version_id mismatch. > > Signed-off-by: Wei Yang > --- > migration/ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 7e34c82a72..6bfdf

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread Li Qiang
Stefan Hajnoczi 于2019年7月23日周二 下午9:03写道: > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > > -snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s", > > - helper, "--use-vnet", fd_buf, br_buf); > > +helper_cmd = g_strdup_printf("%s %s %s %s", h

[Qemu-devel] [PATCH for 4.2 2/3] crypto: define cleanup functions for use with g_autoptr

2019-07-23 Thread Daniel P . Berrangé
Allow crypto structs to be used with g_autoptr, avoiding the need to explicitly call XXX_free() functions when variables go out of scope on the stack. Signed-off-by: Daniel P. Berrangé --- include/crypto/block.h | 2 ++ include/crypto/cipher.h | 2 ++ include/crypto/hmac.h | 2 ++

[Qemu-devel] [PATCH for 4.2 0/3] require newer glib2 to enable autofree'ing of stack variables exiting scope

2019-07-23 Thread Daniel P . Berrangé
Both GCC and CLang support a C extension attribute((cleanup)) which allows you to define a function that is invoked when a stack variable exits scope. This typically used to free the memory allocated to it, though you're not restricted to this. For example it could be used to unlock a mutex. We co

[Qemu-devel] [PATCH for 4.2 1/3] glib: bump min required glib library version to 2.48

2019-07-23 Thread Daniel P . Berrangé
Per supported platforms doc[1], the various min glib on relevant distros is: RHEL-8: 2.56.1 RHEL-7: 2.50.3 Debian (Buster): 2.58.3 Debian (Stretch): 2.50.3 OpenBSD (Ports): 2.58.3 FreeBSD (Ports): 2.56.3 OpenSUSE Leap 15: 2.54.3 SLE12-SP2: 2.48.2 Ubuntu (Xenial): 2.48.0 macOS (

[Qemu-devel] [PATCH for 4.2 3/3] crypto: use auto cleanup for many stack variables

2019-07-23 Thread Daniel P . Berrangé
Simplify cleanup paths by using glib's auto cleanup macros for stack variables, allowing several goto jumps / labels to be eliminated. Signed-off-by: Daniel P. Berrangé --- crypto/afsplit.c | 28 +--- crypto/block-luks.c | 74 +-- crypto

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Thomas Huth
On 23/07/2019 15.01, Peter Maydell wrote: > On Tue, 23 Jul 2019 at 13:58, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >>> On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé >>> wrote: On 7/23/19 1:46 PM, Alex Bennée wrote: >> I see Thomas Huth has a patch on-list for th

Re: [Qemu-devel] [PATCH for 4.2 1/3] glib: bump min required glib library version to 2.48

2019-07-23 Thread Thomas Huth
On 23/07/2019 17.48, Daniel P. Berrangé wrote: > Per supported platforms doc[1], the various min glib on relevant distros is: > > RHEL-8: 2.56.1 > RHEL-7: 2.50.3 > Debian (Buster): 2.58.3 > Debian (Stretch): 2.50.3 > OpenBSD (Ports): 2.58.3 > FreeBSD (Ports): 2.56.3 > OpenSUSE Leap 1

Re: [Qemu-devel] [PATCH for 4.2 1/3] glib: bump min required glib library version to 2.48

2019-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2019 at 06:02:43PM +0200, Thomas Huth wrote: > On 23/07/2019 17.48, Daniel P. Berrangé wrote: > > Per supported platforms doc[1], the various min glib on relevant distros is: > > > > RHEL-8: 2.56.1 > > RHEL-7: 2.50.3 > > Debian (Buster): 2.58.3 > > Debian (Stretch): 2.50.3

[Qemu-devel] [PATCH] pc-dimm: fix crash when invalid slot number is used

2019-07-23 Thread Igor Mammedov
QEMU will crash with: Segmentation fault (core dumped) when negative slot number is used, ex: qemu-system-x86_64 -m 1G,maxmem=20G,slots=256 \ -object memory-backend-ram,id=mem1,size=1G \ -device pc-dimm,id=dimm1,memdev=mem1,slot=-2 fix it by checking that slot number is within vali

Re: [Qemu-devel] [PATCH v2 2/2] configure: Cosmetic yes to "yes" for consistency

2019-07-23 Thread Aleksandar Markovic
Hi, Tony On Mon, Jul 22, 2019 at 5:28 AM wrote: > Signed-off-by: Tony Nguyen > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 8316a16..c07687c 100755 > --- a/configure > +++ b/configure > @@ -7433,7 +7433,7 @@ esac > targ

Re: [Qemu-devel] [PATCH v2 1/2] configure: Define target access alignment in configure

2019-07-23 Thread Aleksandar Markovic
Hello, Tony On Mon, Jul 22, 2019 at 5:27 AM wrote: > Move the define of target access alignment earlier from > target/foo/cpu.h to configure. > > It would be better if the commit message explained WHY the change is needed and HOW it is achieved - not WHAT the change is. Yours, Aleksandar > Si

[Qemu-devel] [Bug 1670170] Re: `qemu-system-sparc64 -M Niagara` Aborted (core dumped)

2019-07-23 Thread Mark Cave-Ayland
It's difficult to tell as you haven't posted your complete command line, however it looks as if you're missing the path to the rom images: https://qemu.weilnetz.de/doc/qemu-doc.html#Sparc64-System-emulator https://wiki.qemu.org/Documentation/Platforms/SPARC#Compatibility ATB, Mark. -- You rec

Re: [Qemu-devel] [PULL v3 for 4.1 00/23] testing updates

2019-07-23 Thread Alex Bennée
Alex Bennée writes: > The following changes since commit 4da6c0f9ebbdaaf4315c71ccd288d02b9087f8af: > > Merge remote-tracking branch > 'remotes/amarkovic2/tags/mips-queue-jul-23-2019' into staging (2019-07-23 > 12:49:39 +0100) > > are available in the Git repository at: > > https://github.

[Qemu-devel] [PULL v4 00/23 for 4.1-rc2] testing updates

2019-07-23 Thread Alex Bennée
The following changes since commit 4da6c0f9ebbdaaf4315c71ccd288d02b9087f8af: Merge remote-tracking branch 'remotes/amarkovic2/tags/mips-queue-jul-23-2019' into staging (2019-07-23 12:49:39 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-2

Re: [Qemu-devel] [PATCH 2/2] migration: extract ram_load_precopy

2019-07-23 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > After cleanup, it would be clear to audience there are two cases > ram_load: > > * precopy > * postcopy > > And it is not necessary to check postcopy_running on each iteration for > precopy. > > Signed-off-by: Wei Yang > --- > migration/r

  1   2   3   >