Re: [Qemu-devel] [PATCH v4 11/29] typedefs: Separate incomplete types and function types

2019-08-12 Thread Markus Armbruster
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> While there, drop the obsolete file comment. >>> >>> Signed-off-by: Markus Armbruster >>> Reviewed-by: Philippe Mathieu-Daudé >>> Tested-by: Philippe Mathieu-Daudé >>> --- >>> include/qemu/typedefs.h | 12

Re: [Qemu-devel] [RFC PATCH v2 15/39] target/i386: introduce function ck_cpuid

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > +enum { > +CK_CPUID_MMX = 1, > +CK_CPUID_3DNOW, > +CK_CPUID_SSE, > +CK_CPUID_SSE2, > +CK_CPUID_SSE3, > +CK_CPUID_SSSE3, > +CK_CPUID_SSE4_1, > +CK_CPUID_SSE4_2, > +CK_CPUID_SSE4A, > +CK_CPUID_AVX, > +CK_CPUID_AVX2, >

Re: [Qemu-devel] [PATCH] Add git-publish profile for security bugs

2019-08-12 Thread Gerd Hoffmann
> > +# https://wiki.qemu.org/SecurityProcess > > +[gitpublishprofile "security"] > > +base = master > > +to = m...@redhat.com > > +to = pmato...@redhat.com > > +to = sstabell...@kernel.org > > +to = secal...@redhat.com > > +to = mdr...@linux.vnet.ibm.com > > +to = p...@redhat.com > > +suppresscc =

Re: [Qemu-devel] [RFC PATCH v2 14/39] target/i386: introduce mnemonic aliases for several gvec operations

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > It is helpful to introduce aliases for some general gvec operations as > it makes a couple of instruction code generators simpler (added > later). > > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 7 +++ > 1 file changed, 7 insertions(+) >

Re: [Qemu-devel] [RFC PATCH v2 12/39] target/i386: introduce gen_sse_ng

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > This function serves as the point-of-intercept for all newly > implemented instructions. If no new implementation exists, fall back > to gen_sse. > > Note: This changeset is intended for development only and shall not be > included in the final patch series.

Re: [Qemu-devel] [RFC PATCH v2 11/39] target/i386: introduce gen_(ld, st)d_env_A0

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > Similar in spirit to the already present gen_(ld,st)(q,o)_env_A0, it > will prove useful in later commits for smaller-sized vector loads. > > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 12 > 1 file changed, 12 insertions(+)

Re: [Qemu-devel] [RFC PATCH v2 09/39] target/i386: make variable is_xmm const

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > The variable is_xmm does not change value after assignment, so make > this fact explicit by marking it const. > > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 17 ++--- > 1 file changed, 6 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [RFC PATCH v2 08/39] target/i386: make variable b1 const

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > The variable b1 does not change value once assigned. Make this fact > explicit by marking it const. > > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) Reviewed-by: Richard

Re: [Qemu-devel] [RFC PATCH v2 05/39] target/i386: use prefix from DisasContext

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > Reduce scope of the local variable prefixes to enforce use of prefix > from DisasContext instead. > > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 113 > 1 file changed, 57 insertions(+), 56

Re: [Qemu-devel] [RFC PATCH v2 04/39] target/i386: use dflag from DisasContext

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > There already is a variable dflag in DisasContext, so reduce the scope > of the local variable dflag to enforce use of the one in DisasContext. > > Suggested-by: Richard Henderson > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 184

Re: [Qemu-devel] [RFC PATCH v2 03/39] target/i386: reduce scope of variable aflag

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > The variable aflag is not used in most of disas_insn; make this clear > by explicitly reducing its scope to the block where it is used. > > Suggested-by: Richard Henderson > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 6 +- > 1 file

Re: [Qemu-devel] [RFC PATCH v2 07/39] target/i386: use pc_start from DisasContext

2019-08-12 Thread Richard Henderson
On 8/10/19 5:12 AM, Jan Bobek wrote: > The variable pc_start is already a member of DisasContext. Remove the > superfluous local variable. > > Signed-off-by: Jan Bobek > --- > target/i386/translate.c | 131 > 1 file changed, 65 insertions(+), 66

Re: [Qemu-devel] [PATCH qemu] spapr_iommu: Fix xlate trace to print translated address

2019-08-12 Thread Alexey Kardashevskiy
On 12/08/2019 19:01, Philippe Mathieu-Daudé wrote: Hi Alexey, On 8/12/19 7:42 AM, Alexey Kardashevskiy wrote: Currently we basically print IO address twice, fix this. Fixes: 7e472264e9e2 ("PPC: spapr: iommu: rework traces") Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c |

[Qemu-devel] [PATCH v2] HACKING: Document 'struct' keyword usage

2019-08-12 Thread Eduardo Habkost
Sometimes we use the 'struct' keyword in headers to help us reduce dependencies between header files. Document that practice. Signed-off-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use paragraphs written by Paolo Bonzini at

Re: [Qemu-devel] [PATCH v4 22/29] Include hw/boards.h a bit less

2019-08-12 Thread Eduardo Habkost
On Mon, Aug 12, 2019 at 07:23:52AM +0200, Markus Armbruster wrote: > hw/boards.h pulls in almost 60 headers. The less we include it into > headers, the better. As a first step, drop superfluous inclusions, > and downgrade some more to what's actually needed. Gets rid of just > one inclusion

Re: [Qemu-devel] [PATCH-4.2 v2 5/5] target/riscv: Fix Floating Point register names

2019-08-12 Thread Palmer Dabbelt
On Tue, 30 Jul 2019 16:35:34 PDT (-0700), Alistair Francis wrote: From: Atish Patra As per the RISC-V spec, Floating Point registers are named as f0..f31 so lets fix the register names accordingly. Signed-off-by: Atish Patra Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 8

Re: [Qemu-devel] [PATCH 1/3] riscv: sifive_u: Add support for loading initrd

2019-08-12 Thread Palmer Dabbelt
On Fri, 19 Jul 2019 06:40:43 PDT (-0700), li...@roeck-us.net wrote: Add support for loading initrd with "-initrd " to the sifive_u machine. This lets us boot into Linux without disk drive. Signed-off-by: Guenter Roeck --- hw/riscv/sifive_u.c | 20 +--- 1 file changed, 17

Re: [Qemu-devel] [RFC PATCH v2 02/17] fuzz: Add fuzzer configure options

2019-08-12 Thread Bandan Das
"Oleinik, Alexander" writes: ... > if test "$supported_cpu" = "no"; then > echo > @@ -7306,6 +7310,17 @@ fi > if test "$sheepdog" = "yes" ; then >echo "CONFIG_SHEEPDOG=y" >> $config_host_mak > fi > +if test "$fuzzing" = "yes" ; then > + QEMU_CFLAGS="$QEMU_CFLAGS

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block: Make various formats' block_status recurse again

2019-08-12 Thread John Snow
On 8/12/19 3:11 PM, Max Reitz wrote: > On 12.08.19 20:39, John Snow wrote: >> >> >> On 7/25/19 11:55 AM, Max Reitz wrote: >>> Hi, >>> >>> 69f47505ee66afaa513305de0c1895a224e52c45 changed block_status so that it >>> would only go down to the protocol layer if the format layer returned >>>

Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] iotests: Disable 126 for some vmdk subformats

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > Several vmdk subformats do not work with iotest 126, so disable them. > > (twoGbMaxExtentSparse actually should work, but fixing that is a bit > difficult. The problem is that the vmdk descriptor file will contain a > referenc to "image:base.vmdk",

Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] iotests: Disable 110 for vmdk.twoGbMaxExtentSparse

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > The error message for the test case where we have a quorum node for > which no directory name can be generated is different: For > twoGbMaxExtentSparse, it complains that it cannot open the extent file. > For other (sub)formats, it just notes that it

Re: [Qemu-devel] [PATCH 3/9] vfio: unplug failover primary device before migration

2019-08-12 Thread Alex Williamson
On Mon, 12 Aug 2019 17:18:54 +0200 Cornelia Huck wrote: > On Fri, 2 Aug 2019 17:05:59 +0200 > Jens Freimann wrote: > > > As usual block all vfio-pci devices from being migrated, but make an > > exception for failover primary devices. This is achieved by setting > > unmigratable to 0 but also

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-08-12 Thread Eric Blake
On 7/29/19 6:08 AM, Kevin Wolf wrote: >> On a different topic, how much of this work overlaps with the nbdkit ssh >> plugin? Should we be duplicating efforts with both projects supporting >> ssh natively, or is it worth considering getting qemu out of the ssh >> business and instead connecting to

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-12 Thread John Snow
On 8/12/19 5:03 PM, Max Reitz wrote: > On 12.08.19 22:26, John Snow wrote: >> >> >> On 7/25/19 11:57 AM, Max Reitz wrote: >>> Compressed writes generally have to write full clusters, not just in >>> theory but also in practice when it comes to vmdk's streamOptimized >>> subformat. It currently

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-12 Thread Peter Xu
On Mon, Aug 12, 2019 at 10:24:53AM -0600, Alex Williamson wrote: > On Mon, 12 Aug 2019 09:45:27 +0200 > Peter Xu wrote: > > > This is a RFC series. > > > > The VT-d code has some defects, one of them is that we cannot detect > > the misuse of vIOMMU and vfio-pci early enough. > > > > For

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-08-12 Thread Max Reitz
On 29.07.19 13:08, Kevin Wolf wrote: > Am 26.07.2019 um 16:24 hat Eric Blake geschrieben: >> On 7/26/19 9:09 AM, Pino Toscano wrote: >>> Add a 'private-key' option which represents the path of a private key >>> to use for authentication, and 'private-key-secret' as the name of an >>> object with

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-12 Thread Max Reitz
On 12.08.19 22:26, John Snow wrote: > > > On 7/25/19 11:57 AM, Max Reitz wrote: >> Compressed writes generally have to write full clusters, not just in >> theory but also in practice when it comes to vmdk's streamOptimized >> subformat. It currently is just silently broken for writes with >>

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] vmdk: Reject invalid compressed writes

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > Compressed writes generally have to write full clusters, not just in > theory but also in practice when it comes to vmdk's streamOptimized > subformat. It currently is just silently broken for writes with > non-zero in-cluster offsets: > > $ qemu-img

Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] iotests: Keep testing broken relative extent paths

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > We had a test for a case where relative extent paths did not work, but > unfortunately we just fixed the underlying problem, so it works now. > This patch adds a new test case that still fails. > > Signed-off-by: Max Reitz > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH 2/7] vmdk: Use bdrv_dirname() for relative extent paths

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > This makes iotest 033 pass with e.g. subformat=monolithicFlat. It also > turns a former error in 059 into success. > > Signed-off-by: Max Reitz Seems roughly correct, but I only really gave it a cursory look; my trust in you knowing the exact

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-12 Thread Max Reitz
On 12.08.19 21:46, Max Reitz wrote: > On 12.08.19 20:11, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> I'm not sure, is it a bug or a feature, but using qcow2 under raw is >> broken. It should be either fixed like I propose (by Max's suggestion) >> or somehow forbidden (just forbid

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-12 Thread Max Reitz
On 12.08.19 20:11, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I'm not sure, is it a bug or a feature, but using qcow2 under raw is > broken. It should be either fixed like I propose (by Max's suggestion) > or somehow forbidden (just forbid backing-file supporting node to be > file child of

Re: [Qemu-devel] [PATCH] tests/test-hbitmap: test next_zero and _next_dirty_area after truncate

2019-08-12 Thread John Snow
On 8/9/19 4:26 AM, Vladimir Sementsov-Ogievskiy wrote: > 08.08.2019 3:04, John Snow wrote: >> >> >> On 8/5/19 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Test that hbitmap_next_zero and hbitmap_next_dirty_area can find things >>> after old bitmap end. >>> >>> Signed-off-by: Vladimir

Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] iotests: Fix _filter_img_create()

2019-08-12 Thread John Snow
On 7/25/19 11:57 AM, Max Reitz wrote: > fe646693acc changed qemu-img create's output so that it no longer prints > single quotes around parameter values. The subformat and adapter_type > filters in _filter_img_create() have never been adapted to that change. > > Fixes:

Re: [Qemu-devel] [Qemu-block] qemu-iotest 059 fails with vmdk

2019-08-12 Thread Max Reitz
On 12.08.19 21:14, John Snow wrote: > > > On 7/22/19 8:58 AM, Thomas Huth wrote: >> Not sure if it has been reported before, but test 059 currently fails: >> >> 059 fail [14:55:21] [14:55:26]output >> mismatch (see 059.out.bad) >> ---

Re: [Qemu-devel] [Qemu-block] qemu-iotests 069 and 111 are failing on NetBSD

2019-08-12 Thread John Snow
On 7/25/19 4:34 AM, Thomas Huth wrote: > On 24/07/2019 18.29, Paolo Bonzini wrote: >> On 24/07/19 11:34, Thomas Huth wrote: >>> In case somebody is interested, two of the "auto" iotests are failing >>> on NetBSD due to non-matching output: >>> >>> TESTiotest-qcow2: 069 [fail] >>> ---

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-12 Thread Max Reitz
On 12.08.19 19:14, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 16:09, Max Reitz wrote: >> On 10.08.19 18:41, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: If the driver does not implement bdrv_get_allocated_file_size(), we should fall back to cumulating

Re: [Qemu-devel] [Qemu-block] qemu-iotest 059 fails with vmdk

2019-08-12 Thread John Snow
On 7/22/19 8:58 AM, Thomas Huth wrote: > Not sure if it has been reported before, but test 059 currently fails: > > 059 fail [14:55:21] [14:55:26]output > mismatch (see 059.out.bad) > --- /home/thuth/devel/qemu/tests/qemu-iotests/059.out 2019-07-19 >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block: Make various formats' block_status recurse again

2019-08-12 Thread Max Reitz
On 12.08.19 20:39, John Snow wrote: > > > On 7/25/19 11:55 AM, Max Reitz wrote: >> Hi, >> >> 69f47505ee66afaa513305de0c1895a224e52c45 changed block_status so that it >> would only go down to the protocol layer if the format layer returned >> BDRV_BLOCK_RECURSE, thus indicating that it has no

Re: [Qemu-devel] [PATCH 3/3] vpc: Do not return RAW from block_status

2019-08-12 Thread Max Reitz
On 12.08.19 18:50, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 18:56, Max Reitz wrote: >> On 12.08.19 17:33, Vladimir Sementsov-Ogievskiy wrote: >>> 25.07.2019 18:55, Max Reitz wrote: vpc is not really a passthrough driver, even when using the fixed subformat (where host and guest

Re: [Qemu-devel] [PATCH v8 9/9] qapi: query-blockstat: add driver specific file-posix stats

2019-08-12 Thread Max Reitz
On 16.05.19 16:33, Anton Nefedov wrote: > A block driver can provide a callback to report driver-specific > statistics. > > file-posix driver now reports discard statistics > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy > Acked-by: Markus Armbruster > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/5] iotests: Allow skipping test cases

2019-08-12 Thread John Snow
On 6/25/19 5:19 PM, Max Reitz wrote: > case_notrun() does not actually skip the current test case. It just > adds a "notrun" note and then returns to the caller, who manually has to > skip the test. Generally, skipping a test case is as simple as > returning from the current function, but not

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/5] iotests: Prefer null-co over null-aio

2019-08-12 Thread John Snow
On 6/25/19 5:19 PM, Max Reitz wrote: > We use null-co basically everywhere in the iotests. Unless we want to > test null-aio specifically, we should use it instead (for consistency). > > Signed-off-by: Max Reitz Probably fine. Reviewed-by: John Snow

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img convert: Deprecate using -n and -o together

2019-08-12 Thread John Snow
On 8/9/19 5:11 AM, Kevin Wolf wrote: > bdrv_create options specified with -o have no effect when skipping image > creation with -n, so this doesn't make sense. Warn against the misuse > and deprecate the combination so we can make it a hard error later. > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Fix 141 when run with qed

2019-08-12 Thread John Snow
On 8/9/19 2:52 PM, Max Reitz wrote: > 69f47505ee has changed qcow2 in such a way that the commit job run in > test 141 (and 144[1]) returns before it emits the READY event. However, > 141 also runs with qed, where the order is still the other way around. > Just filter out the {"return": {}} so

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block: Make various formats' block_status recurse again

2019-08-12 Thread John Snow
On 7/25/19 11:55 AM, Max Reitz wrote: > Hi, > > 69f47505ee66afaa513305de0c1895a224e52c45 changed block_status so that it > would only go down to the protocol layer if the format layer returned > BDRV_BLOCK_RECURSE, thus indicating that it has no sufficient > information whether a given range

[Qemu-devel] Fwd: Re: [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread Andrew Randrianasulu
-- Пересланное сообщение -- Тема: Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true Дата: Понедельник 12 августа 2019 Отправитель: Andrew Randrianasulu Получатель: BALATON Zoltan В сообщении от Monday 12 August 2019 13:55:45 BALATON Zoltan

Re: [Qemu-devel] [PATCH v8 4/9] ide: account UNMAP (TRIM) operations

2019-08-12 Thread Max Reitz
On 16.05.19 16:33, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > hw/ide/core.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 6afadf894f..3a7ac93777 100644 > ---

[Qemu-devel] [PATCH 2/2] iotests: test mirroring qcow2 under raw format

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
Check that it is fixed by previous commit Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/263 | 46 ++ tests/qemu-iotests/263.out | 12 ++ tests/qemu-iotests/group | 1 + 3 files changed, 59 insertions(+) create mode 100755

[Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to returned file. But is it correct behavior at all? If returned file itself has a backing file, we may report as totally unallocated and area which actually has data in bottom backing file. So, mirroring of qcow2 under raw-format

[Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
Hi all! I'm not sure, is it a bug or a feature, but using qcow2 under raw is broken. It should be either fixed like I propose (by Max's suggestion) or somehow forbidden (just forbid backing-file supporting node to be file child of raw-format node). Vladimir Sementsov-Ogievskiy (2):

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 20:46, John Snow wrote: > > > On 8/10/19 7:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 23:13, John Snow wrote: >>> >>> >>> On 8/9/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: Hi! Hmm, hacking around backup I have a question: What prevents guest

Re: [Qemu-devel] [PATCH] Add git-publish profile for security bugs

2019-08-12 Thread John Snow
On 8/12/19 3:12 AM, Gerd Hoffmann wrote: > Simplifies sending security patches to all people listed in > https://wiki.qemu.org/SecurityProcess. Should also make it > harder to send a copy to the mailing list by accident. > > Signed-off-by: Gerd Hoffmann > --- > .gitpublish | 11 +++

Re: [Qemu-devel] [PATCH v8 5/9] scsi: store unmap offset and nb_sectors in request struct

2019-08-12 Thread Max Reitz
On 16.05.19 16:33, Anton Nefedov wrote: > it allows to report it in the error handler > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Alberto Garcia > --- > hw/scsi/scsi-disk.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-)

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread John Snow
On 8/10/19 7:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 23:13, John Snow wrote: >> >> >> On 8/9/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> Hmm, hacking around backup I have a question: >>> >>> What prevents guest write request after job_start but before setting

[Qemu-devel] [Bug 1839807] Re: Snapshots freeze guest Sabrelite IMX.6 board

2019-08-12 Thread Peter Maydell
The underlying cause of this is that we're not migrating the Secure banked cp15 register contents. So boards which don't enable TrustZone or where the guest runs in the NonSecure state (like the virt board, etc) can save/restore fine, but since the imx6 happens to run the guest in the Secure state

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 16:09, Max Reitz wrote: > On 10.08.19 18:41, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:13, Max Reitz wrote: >>> If the driver does not implement bdrv_get_allocated_file_size(), we >>> should fall back to cumulating the allocated size of all non-COW >>> children instead of

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 19:49, Kevin Wolf wrote: > Am 12.08.2019 um 18:09 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 12.08.2019 16:23, Kevin Wolf wrote: >>> Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi! Hmm, hacking around backup I have a question: What

Re: [Qemu-devel] [PATCH 3/3] vpc: Do not return RAW from block_status

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 18:56, Max Reitz wrote: > On 12.08.19 17:33, Vladimir Sementsov-Ogievskiy wrote: >> 25.07.2019 18:55, Max Reitz wrote: >>> vpc is not really a passthrough driver, even when using the fixed >>> subformat (where host and guest offsets are equal). It should handle >>> preallocation like

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Kevin Wolf
Am 12.08.2019 um 18:09 hat Vladimir Sementsov-Ogievskiy geschrieben: > 12.08.2019 16:23, Kevin Wolf wrote: > > Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Hi! > >> > >> Hmm, hacking around backup I have a question: > >> > >> What prevents guest write request after

Re: [Qemu-devel] [PATCH] linux-user: Add AT_HWCAP2 for aarch64-linux-user

2019-08-12 Thread Peter Maydell
On Fri, 9 Aug 2019 at 18:11, Richard Henderson wrote: > > Add the HWCAP2_* bits from kernel version v5.3-rc3. > Enable the bits corresponding to ARMv8.5-CondM and ARMv8.5-FRINT. > > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 31 +++ > 1 file

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 19:11, Max Reitz wrote: > On 12.08.19 17:47, Vladimir Sementsov-Ogievskiy wrote: >> 12.08.2019 18:10, Max Reitz wrote: >>> On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote: backup_cow_with_offload can transfer more than one cluster. Let backup_cow_with_bounce_buffer

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Peter Maydell
On Mon, 12 Aug 2019 at 16:48, Alex Williamson wrote: > > On Mon, 12 Aug 2019 16:38:05 +0100 > Peter Maydell wrote: > > > On Mon, 12 Aug 2019 at 16:35, Alex Williamson > > wrote: > > > Quoting new commit log: > > > > > > This makes sure the pci config space allocation is big enough, > >

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-12 Thread Alex Williamson
On Mon, 12 Aug 2019 09:45:27 +0200 Peter Xu wrote: > This is a RFC series. > > The VT-d code has some defects, one of them is that we cannot detect > the misuse of vIOMMU and vfio-pci early enough. > > For example, logically this is not allowed: > > -device intel-iommu,caching-mode=off \ >

Re: [Qemu-devel] [PATCH v3 1/2] bitmap: get last word mask from nr directly

2019-08-12 Thread Paolo Bonzini
On 18/07/19 03:04, Wei Yang wrote: > The value left in nr is the number of bits for the last word, which > could be calculate the last word mask directly. > > Remove the unnecessary size. Hi, the value left in nr is _not_ the number of bits for the last word if the start and the end are in the

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-12 Thread Max Reitz
On 12.08.19 17:47, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 18:10, Max Reitz wrote: >> On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote: >>> backup_cow_with_offload can transfer more than one cluster. Let >>> backup_cow_with_bounce_buffer behave similarly. It reduces the number >>> of

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 16:23, Kevin Wolf wrote: > Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> Hmm, hacking around backup I have a question: >> >> What prevents guest write request after job_start but before setting >> write notifier? >> >> code path: >> >>

Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing sysemu/sysemu.h triggers a > recompile of some 1800 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h, down from 5400 due to the > previous commit). > > Several headers

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread Thomas Huth
On 8/12/19 5:39 PM, David Hildenbrand wrote: > On 12.08.19 17:28, David Hildenbrand wrote: >> On 12.08.19 17:18, Thomas Huth wrote: >>> On 8/12/19 1:27 PM, David Hildenbrand wrote: Let's select the ASC before calling the function. This is a prepararion to remove the ASC magic depending

Re: [Qemu-devel] [PATCH v4 18/29] Include hw/hw.h exactly where needed

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing hw/hw.h triggers a recompile > of some 2600 out of 6600 objects (not counting tests and objects that > don't depend on qemu/osdep.h). > > The previous commits have left only the declaration of hw_error() in >

Re: [Qemu-devel] [PATCH v4 22/29] Include hw/boards.h a bit less

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > hw/boards.h pulls in almost 60 headers. The less we include it into > headers, the better. As a first step, drop superfluous inclusions, > and downgrade some more to what's actually needed. Gets rid of just > one inclusion into a header. > > Cc:

Re: [Qemu-devel] [PATCH v4 15/29] Include migration/vmstate.h less

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing migration/vmstate.h triggers a > recompile of some 2700 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). > > hw/hw.h supposedly includes it for convenience. Several

Re: [Qemu-devel] [PATCH v4 01/29] include: Make headers more self-contained

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include

[Qemu-devel] [PATCH v4 1/2] main-loop: Fix GSource leak in qio_task_thread_worker()

2019-08-12 Thread Andrey Shinkevich
From: Alberto Garcia After g_source_attach() the GMainContext holds a reference to the GSource, so the caller does not need to keep it. qio_task_thread_worker() is not releasing its reference so the GSource is being leaked since a17536c594bfed94d05667b419f747b692f5fc7f. Signed-off-by: Alberto

[Qemu-devel] [PATCH v4 2/2] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-08-12 Thread Andrey Shinkevich
From: Alberto Garcia There's a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. Running iotest 136 in a loop triggers this problem and crashes QEMU. (gdb) bt #0 0x5558b842902d in object_get_class (obj=0x0) at

[Qemu-devel] [PATCH v4 0/2] char-socket: Fix race condition

2019-08-12 Thread Andrey Shinkevich
This fixes a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. v4: The functions qemu_idle_add() and tcp_chr_be_event_closed() were removed because the callback is invoked after the call to object_property_del_all()

Re: [Qemu-devel] [PATCH 3/3] vpc: Do not return RAW from block_status

2019-08-12 Thread Max Reitz
On 12.08.19 17:33, Vladimir Sementsov-Ogievskiy wrote: > 25.07.2019 18:55, Max Reitz wrote: >> vpc is not really a passthrough driver, even when using the fixed >> subformat (where host and guest offsets are equal). It should handle >> preallocation like all other drivers do, namely by returning

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Alex Williamson
On Mon, 12 Aug 2019 16:38:05 +0100 Peter Maydell wrote: > On Mon, 12 Aug 2019 at 16:35, Alex Williamson > wrote: > > Quoting new commit log: > > > > This makes sure the pci config space allocation is big enough, > > so accessing the PCIe extended config space doesn't overflow >

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 18:10, Max Reitz wrote: > On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote: >> backup_cow_with_offload can transfer more than one cluster. Let >> backup_cow_with_bounce_buffer behave similarly. It reduces the number >> of IO requests, since there is no need to copy cluster by

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread David Hildenbrand
On 12.08.19 17:28, David Hildenbrand wrote: > On 12.08.19 17:18, Thomas Huth wrote: >> On 8/12/19 1:27 PM, David Hildenbrand wrote: >>> Let's select the ASC before calling the function. This is a prepararion >>> to remove the ASC magic depending on the access mode from mmu_translate. >>> >>> There

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Peter Maydell
On Mon, 12 Aug 2019 at 16:35, Alex Williamson wrote: > Quoting new commit log: > > This makes sure the pci config space allocation is big enough, > so accessing the PCIe extended config space doesn't overflow > the pci config space buffer. > > PCI(e) config space

Re: [Qemu-devel] [Qemu-arm] [PATCH] elf: Allow loading AArch64 ELF files

2019-08-12 Thread Aaron Lindsay OS via Qemu-devel
On Aug 12 16:02, Peter Maydell wrote: > On Mon, 12 Aug 2019 at 15:46, Aaron Lindsay OS via Qemu-arm > wrote: > > > > Treat EM_AARCH64 as a valid value when checking the ELF's machine-type > > header. > > > > Signed-off-by: Aaron Lindsay > > --- > > include/hw/elf_ops.h | 6 ++ > > 1 file

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Alex Williamson
On Mon, 12 Aug 2019 14:39:53 +0100 Peter Maydell wrote: > On Mon, 12 Aug 2019 at 13:51, Philippe Mathieu-Daudé > wrote: > > > > On 8/12/19 2:45 PM, Paolo Bonzini wrote: > > > On 12/08/19 08:52, Gerd Hoffmann wrote: > > >> Just found while investigating > > >>

Re: [Qemu-devel] [PATCH 3/3] vpc: Do not return RAW from block_status

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
25.07.2019 18:55, Max Reitz wrote: > vpc is not really a passthrough driver, even when using the fixed > subformat (where host and guest offsets are equal). It should handle > preallocation like all other drivers do, namely by returning > DATA | RECURSE instead of RAW. > > There is no tangible

Re: [Qemu-devel] [Qemu-arm] Beagle Board support

2019-08-12 Thread Peter Maydell
(I've added qemu-devel to the cc list; some people don't read the qemu-arm list.) On Sat, 10 Aug 2019 at 16:24, Esteban Bosse wrote: > El sáb., 10 ago. 2019 23:01, Peter Maydell > escribió: >> On Sat, 10 Aug 2019 at 04:39, Esteban Bosse wrote: >> > I am new in this world, but I want to port

[Qemu-devel] [PATCH] memory: Correct access mask generation in access_with_adjusted_size

2019-08-12 Thread Francisco Iglesias
Also consider the requested transaction size when generating the access mask (so that only the requested bytes are returned when those are less than the memory region's minimum access size). Signed-off-by: Francisco Iglesias --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread David Hildenbrand
On 12.08.19 17:18, Thomas Huth wrote: > On 8/12/19 1:27 PM, David Hildenbrand wrote: >> Let's select the ASC before calling the function. This is a prepararion >> to remove the ASC magic depending on the access mode from mmu_translate. >> >> There is currently no way to distinguish if we have code

Re: [Qemu-devel] [PATCH 3/9] vfio: unplug failover primary device before migration

2019-08-12 Thread Cornelia Huck
On Fri, 2 Aug 2019 17:05:59 +0200 Jens Freimann wrote: > As usual block all vfio-pci devices from being migrated, but make an > exception for failover primary devices. This is achieved by setting > unmigratable to 0 but also add a migration blocker for all vfio-pci > devices except failover

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread Thomas Huth
On 8/12/19 1:27 PM, David Hildenbrand wrote: > Let's select the ASC before calling the function. This is a prepararion > to remove the ASC magic depending on the access mode from mmu_translate. > > There is currently no way to distinguish if we have code or data access. > For now, we were using

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-12 Thread Max Reitz
On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote: > backup_cow_with_offload can transfer more than one cluster. Let > backup_cow_with_bounce_buffer behave similarly. It reduces the number > of IO requests, since there is no need to copy cluster by cluster. > > Logic around bounce_buffer

Re: [Qemu-devel] [Qemu-arm] [PATCH] elf: Allow loading AArch64 ELF files

2019-08-12 Thread Peter Maydell
On Mon, 12 Aug 2019 at 15:46, Aaron Lindsay OS via Qemu-arm wrote: > > Treat EM_AARCH64 as a valid value when checking the ELF's machine-type > header. > > Signed-off-by: Aaron Lindsay > --- > include/hw/elf_ops.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> In my "build everything" tree, changing sysemu/sysemu.h triggers a >>> recompile of some 1800 out of 6600 objects (not counting tests and >>> objects that don't depend on qemu/osdep.h, down from 5400 due to

Re: [Qemu-devel] [PATCH 2/3] vmdk: Make block_status recurse for flat extents

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
25.07.2019 18:55, Max Reitz wrote: > Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 > Signed-off-by: Max Reitz Again, don't know vmdk code, but briefly looking at it (and at vmdk spec) I see that "extents" are files, and flat extent is a raw file without any special format. And it is allocated

Re: [Qemu-devel] [PATCH] elf: Allow loading AArch64 ELF files

2019-08-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019081212.30027-1-aa...@os.amperecomputing.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] elf: Allow loading AArch64 ELF files Message-id:

[Qemu-devel] [Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2019-08-12 Thread Peter Maydell
(Edit to note that "that hardware" is an SH7785LCR with an SH7785 CPU.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796520 Title: autogen crashes on qemu-sh4-user after 61dedf2af7 Status in

Re: [Qemu-devel] [PATCH v2 0/9] add failover feature for assigned network devices

2019-08-12 Thread Michael S. Tsirkin
On Fri, Aug 02, 2019 at 05:05:56PM +0200, Jens Freimann wrote: > This is implementing the host side of the net_failover concept > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Virtio bits look fine. Anyone else wants to comment on management/migration aspects? Which tree

Re: [Qemu-devel] [PATCH v3 3/7] block/io: handle alignment and max_transfer for copy_range

2019-08-12 Thread Max Reitz
On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote: > copy_range ignores these limitations, let's improve it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/io.c | 44 > 1 file changed, 36 insertions(+), 8 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH 1/3] vdi: Make block_status recurse for fixed images

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
25.07.2019 18:55, Max Reitz wrote: > Suggested-by: Vladimir Sementsov-Ogievskiy > Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 > Signed-off-by: Max Reitz Sorry for a delay, I thought that maintainers of the formats will approve these patches ;) Don't know vdi code, but it is what I

[Qemu-devel] [PATCH] elf: Allow loading AArch64 ELF files

2019-08-12 Thread Aaron Lindsay OS via Qemu-devel
Treat EM_AARCH64 as a valid value when checking the ELF's machine-type header. Signed-off-by: Aaron Lindsay --- include/hw/elf_ops.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 690f9238c8..f12faa90a1 100644 ---

[Qemu-devel] [Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2019-08-12 Thread Peter Maydell
On that hardware, at least, the user-space visible FPSCR value is indeed 0x00080. Execution of the 'frchg' insn either doesn't trap, or the trap is caught by the kernel and emulated. I think it is not being emulated because CONFIG_SH_FPU_EMU is not set. The comment at the top of

  1   2   >