Re: [Qemu-devel] Regression with floppy drive controller

Hi, > Using the default QEMU config, we build SeaBIOS to use the TSC timer: > > builds/seabios-128k/.config:CONFIG_TSC_TIMER=y > builds/seabios-256k/.config:CONFIG_TSC_TIMER=y > Do we need a cpu with TSC support to run SeaBIOS? Hmm. seabios uses pmtimer if available. isapc has no pmtimer th

Re: [Qemu-devel] [PATCH v2 0/3] colo: Add support for continious replication

> -Original Message- > From: Lukas Straub [mailto:lukasstra...@web.de] > Sent: Saturday, August 17, 2019 2:20 AM > To: Zhang, Chen > Cc: Dr. David Alan Gilbert ; qemu-devel de...@nongnu.org>; Jason Wang ; Xie Changlong > ; Wen Congyang > Subject: Re: [Qemu-devel] [PATCH v2 0/3] colo:

Re: [Qemu-devel] [RFC PATCH v3 02/46] target/i386: Push rex_w into DisasContext

On 8/15/19 6:19 AM, Aleksandar Markovic wrote: > > 15.08.2019. 11.55, "Richard Henderson" > је написао/ла: >> >> On 8/15/19 8:30 AM, Aleksandar Markovic wrote: >> > >> > 15.08.2019. 04.13, "Jan Bobek" > > >> >

Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid

On 8/15/19 11:01 AM, Aleksandar Markovic wrote: > > 15.08.2019. 04.23, "Jan Bobek" > је написао/ла: >> >> Introduce a helper function to take care of instruction CPUID checks. >> >> Signed-off-by: Jan Bobek mailto:jan.bo...@gmail.com>> >> --- > > Jan, what is the orig

Re: [Qemu-devel] [RFC PATCH v3 46/46] target/i386: introduce SSE3 instructions to sse-opcode.inc.h

On 8/15/19 6:07 AM, Aleksandar Markovic wrote: > > 15.08.2019. 11.55, "Richard Henderson" > је написао/ла: >> >> On 8/15/19 8:02 AM, Aleksandar Markovic wrote: >> > A question for you: What about FISTTP, MONITOR, MWAIT, that belong to >> > SSE3, but >> > are

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

On Tue, Aug 20, 2019 at 08:24:49AM +0200, Paolo Bonzini wrote: > On 20/08/19 07:22, Peter Xu wrote: > > On Mon, Aug 12, 2019 at 09:45:27AM +0200, Peter Xu wrote: > >> This is a RFC series. > >> > >> The VT-d code has some defects, one of them is that we cannot detect > >> the misuse of vIOMMU and v

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

Just finished a bisect between cfcca36 (working) and current master (not working), here is the result: $ git bisect bad cd1bfd5ef336166b275a09dc9842542bf5e63ae3 is the first bad commit commit cd1bfd5ef336166b275a09dc9842542bf5e63ae3 Author: Gerd Hoffmann Date: Wed Jun 20 12:17:34 2018 +0200

Re: [Qemu-devel] [Qemu-riscv] RISCV: when will the CLIC be ready?

On 2019/8/20 上午12:38, Chih-Min Chao wrote: On Mon, Aug 19, 2019 at 9:47 PM liuzhiwei > wrote: On 2019/8/17 上午1:29, Alistair Francis wrote: > On Thu, Aug 15, 2019 at 8:39 PM liuzhiweimailto:zhiwei_...@c-sky.com>> wrote: >> Hi, Palmer >> >> Wh

Re: [Qemu-devel] [PATCH for 4.1] aspeed/timer: Provide back-pressure information for short periods

On Tue, 16 Jul 2019 at 07:02, Philippe Mathieu-Daudé wrote: > On 7/16/19 9:00 AM, Joel Stanley wrote: > > On Tue, 16 Jul 2019 at 06:54, Joel Stanley wrote: > >> On Thu, 4 Jul 2019 at 12:26, Paolo Bonzini wrote: > >>> On 04/07/19 12:13, Stefan Hajnoczi wrote: > On Thu, Jul 04, 2019 at 11:26:

[Qemu-devel] [PATCH v2] ppc/pnv: Set default ram size to 1.75GB

This makes the powernv machine easier for end users as the default initrd address (1.5GB) is now within RAM. This uses less than 2GB of RAM to ensure 32 bit Qemu still works. Signed-off-by: Joel Stanley -- v2: Use INITRD defines, whcih come out to 1.75, instead of 2GB --- hw/ppc/pnv.c | 4 +++-

Re: [Qemu-devel] RISCV: when will the CLIC be ready?

On 2019/8/20 上午2:56, Alistair Francis wrote: On Mon, Aug 19, 2019 at 6:44 AM liuzhiwei wrote: On 2019/8/17 上午1:29, Alistair Francis wrote: On Thu, Aug 15, 2019 at 8:39 PM liuzhiwei wrote: Hi, Palmer When Michael Clark still was the maintainer of RISCV QEMU, he wrote in the mail list, "t

Re: [Qemu-devel] [PATCH] Revert "i386: correct cpu_x86_cpuid(0xd)"

Thanks for you reply, we have some hosts running with legacy kernel, difficult to upgrade, and i want to run the latest qemu. Does QEMU support running with legacy kernel(kvm) in design? owen...@ucloud.cn From: Eduardo Habkost Date: 2019-08-21 05:23 To: Bingsong Si CC: qemu-devel Subject: Re:

[Qemu-devel] [Bug 1840865] [NEW] qemu crashes when doing iotest on virtio-9p filesystem

Public bug reported: Qemu crashes when doing avocado-vt test on virtio-9p filesystem. This bug can be reproduced running https://github.com/autotest/tp-qemu/blob/master/qemu/tests/9p.py. The crash stack goes like: Program terminated with signal SIGSEGV, Segmentation fault. #0 v9fs_mark_fids_unr

Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging

Patchew URL: https://patchew.org/QEMU/20190820235243.26092-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging Message-id: 20190820235243.26092-1-js...

[Qemu-devel] [PATCH v3 4/4] iotests: use python logging for iotests.log()

We can turn logging on/off globally instead of per-function. Remove use_log from run_job, and use python logging to turn on diffable output when we run through a script entry point. iotest 245 changes output order due to buffering reasons. --- tests/qemu-iotests/030| 4 +-- tests/qemu-i

Re: [Qemu-devel] [PATCH v5 00/17] target/arm: Reduce overhead of cpu_get_tb_cpu_state

On 8/20/19 2:07 PM, Richard Henderson wrote: > Changes since v4: > * Split patch 1 into 15 smaller patches. > * Cache the new DEBUG_TARGET_EL field. > * Split out m-profile hflags separately from a-profile 32-bit. > * Move around non-cached tb flags as well, avoiding repetitive > checks

[Qemu-devel] [PATCH v3 0/4] iotests: use python logging

This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests. It will help alleviate the need to create logged/unlogged versions of all the v

[Qemu-devel] [PATCH v3 2/4] iotest 258: use script_main

Since this one is nicely factored to use a single entry point, use script_main to run the tests. --- tests/qemu-iotests/258 | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/258 b/tests/qemu-iotests/258 index b84cf02254..1372522c7a 100755 --- a/tests/qe

[Qemu-devel] [PATCH v3 3/4] iotests: add protocol support to initialization info

This will add supported_protocols and unsupported_protocols to all of iotests.main, iotests.script_main, and iotests.script_initialize. --- tests/qemu-iotests/207| 4 ++-- tests/qemu-iotests/210| 4 ++-- tests/qemu-iotests/211| 4 ++-- tests/qemu-iotests/212| 4 ++--

[Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

Like script_main, but doesn't require a single point of entry. Replace all existing initialization sections with this drop-in replacement. This brings debug support to all existing script-style iotests. Note: supported_oses=['linux'] was omitted, as it is a default argument. --- tests/qemu-iotes

Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

Patchew URL: https://patchew.org/QEMU/1566284395-30287-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [Qemu-devel] [PATCH] block/backup: install notifier during creation

ping, y'all On 8/9/19 4:13 PM, John Snow wrote: > Backup jobs may yield prior to installing their handler, because of the > job_co_entry shim which guarantees that a job won't begin work until > we are ready to start an entire transaction. > > Unfortunately, this makes proving correctness about t

Re: [Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

20.08.2019. 23.56, "Brad Parker" <1819...@bugs.launchpad.net> је написао/ла: > > So it looks like even though that commit fixed it, it seems to break > again (differently) in 3.0.0, so I'll need to do another bisect between > cfcca36 and v3.0.0 then I guess. And keep working my way up to master as

[Qemu-devel] QEMU bitmap backup usability FAQ

Hi, downstream here at Red Hat I've been fielding some questions about the usability and feature readiness of Bitmaps (and related features) in QEMU. Here are some questions I answered internally that I am copying to the list for two reasons: (1) To make sure my answers are actually correct, and

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

So it looks like even though that commit fixed it, it seems to break again (differently) in 3.0.0, so I'll need to do another bisect between cfcca36 and v3.0.0 then I guess. And keep working my way up to master as well. -- You received this bug notification because you are a member of qemu- devel

Re: [Qemu-devel] [PATCH v3 3/8] iotests: Allow skipping test cases

On 8/19/19 4:18 PM, Max Reitz wrote: > case_notrun() does not actually skip the current test case. It just > adds a "notrun" note and then returns to the caller, who manually has to > skip the test. Generally, skipping a test case is as simple as > returning from the current function, but not

Re: [Qemu-devel] [PATCH] Revert "i386: correct cpu_x86_cpuid(0xd)"

On Mon, Aug 19, 2019 at 06:09:24PM +0800, Bingsong Si wrote: > This reverts commit de2e68c902f7b6e438b0fa3cfedd74a06a20704f. > > Initial value of env->xcr0 == 0, then CPUID(EAX=0xd,ECX=0).EBX == 0, after kvm > upstream commit 412a3c41, It is ok. > On host before commit 412a3c41, some legacy guest,

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

e3af7c788b73a6495 was indeed one of the bad commits I tested during the bisect. If I apply cfcca361d77142f25f on top of it, Windows starts up normally instead of giving me a BSOD on bootup. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd: Advertise multi-conn for shared read-only connections

On Mon, Aug 19, 2019 at 9:04 PM Eric Blake wrote: > On 8/17/19 8:31 PM, Nir Soffer wrote: > >>> Also, for qemu-nbd, shouldn't we allow -e only together with -r ? > >> > >> I'm reluctant to; it might break whatever existing user is okay exposing > >> it (although such users are questionable, so ma

Re: [Qemu-devel] [PATCH v3 5/8] iotests: Let skip_if_unsupported() accept a method

On 8/19/19 4:18 PM, Max Reitz wrote: > This lets tests use skip_if_unsupported() with a potentially variable > list of required formats. > > Suggested-by: Kevin Wolf > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

On 8/19/19 4:18 PM, Max Reitz wrote: > null-aio may not be whitelisted. Skip all test cases that require it. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/093 | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/093 b/tests/qemu-

Re: [Qemu-devel] [PATCH v3 8/8] iotests: Cache supported_formats()

Any particular reason? I guess an "itch." On 8/19/19 4:18 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py

Re: [Qemu-devel] [PATCH v3 4/8] iotests: Use case_skip() in skip_if_unsupported()

On 8/19/19 4:18 PM, Max Reitz wrote: > skip_if_unsupported() should use the stronger variant case_skip(), > because this allows it to be used even with setUp() (in a meaningful > way). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v5 12/17] target/arm: Add arm_rebuild_hflags

This function assumes nothing about the current state of the cpu, and writes the computed value to env->hflags. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 6 ++ target/arm/helper.c | 30 ++ 2 files changed, 28 insertions(+), 8 deletions(-) diff -

[Qemu-devel] [PATCH v5 17/17] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

This is the payoff. >From perf record -g data of ubuntu 18 boot and shutdown: BEFORE: - 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr - 20.22% helper_lookup_tb_ptr + 10.05% tb_htable_lookup - 9.13% cpu_get_tb_cpu_state 3.20% aa64_va_parameters_both

[Qemu-devel] [PATCH v5 08/17] target/arm: Split out rebuild_hflags_aprofile

Create a function to compute the values of the TBFLAG_ANY bits that will be cached, and are used by A-profile. Signed-off-by: Richard Henderson --- target/arm/helper.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helpe

[Qemu-devel] [PATCH v5 14/17] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state

By performing this store early, we avoid having to save and restore the register holding the address around any function calls. Signed-off-by: Richard Henderson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c i

[Qemu-devel] [PATCH v5 13/17] target/arm: Split out arm_mmu_idx_el

Avoid calling arm_current_el() twice. Signed-off-by: Richard Henderson --- target/arm/internals.h | 9 + target/arm/helper.c| 12 +++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 232d963875..f5313dd3d4

[Qemu-devel] [PATCH v5 11/17] target/arm: Hoist computation of TBFLAG_A32.VFPEN

There are 3 conditions that each enable this flag. M-profile always enables; A-profile with EL1 as AA64 always enables. Both of these conditions can easily be cached. The final condition relies on the FPEXC register which we are not prepared to cache. Signed-off-by: Richard Henderson --- targ

[Qemu-devel] [PATCH v5 03/17] target/arm: Split out rebuild_hflags_common_32

Create a function to compute the values of the TBFLAG_A32 bits that will be cached, and are used by all profiles. Signed-off-by: Richard Henderson --- target/arm/helper.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper

[Qemu-devel] [PATCH v5 16/17] target/arm: Rebuild hflags at EL changes and MSR writes

Now setting, but not relying upon, env->hflags. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 1 + target/arm/cpu.c | 1 + target/arm/helper-a64.c| 3 +++ target/arm/helper.c| 2 ++ target/arm/machine.c | 1 + target/arm/op_helper.c | 1 +

[Qemu-devel] [PATCH v5 15/17] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32})

This functions are given the mode and el state of the cpu and writes the computed value to env->hflags. Signed-off-by: Richard Henderson --- target/arm/helper.h | 4 target/arm/helper.c | 24 2 files changed, 28 insertions(+) diff --git a/target/arm/helper.h b/tar

[Qemu-devel] [PATCH v5 09/17] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state

We do not need to compute any of these values for M-profile. Further, XSCALE_CPAR overlaps VECSTRIDE so obviously the two sets must be mutually exclusive. Signed-off-by: Richard Henderson --- target/arm/helper.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff -

[Qemu-devel] [PATCH v5 02/17] target/arm: Split out rebuild_hflags_a64

Create a function to compute the values of the TBFLAG_A64 bits that will be cached. For now, the env->hflags variable is not used, and the results are fed back to cpu_get_tb_cpu_state. Signed-off-by: Richard Henderson --- target/arm/helper.c | 131 +++- 1

[Qemu-devel] [PATCH v5 10/17] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state

Hoist the variable load for PSTATE into the existing test vs is_a64. Signed-off-by: Richard Henderson --- target/arm/helper.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 3889b9295a..c01b3027e0 100644 --

[Qemu-devel] [PATCH v5 05/17] target/arm: Split out rebuild_hflags_m32

Create a function to compute the values of the TBFLAG_A32 bits that will be cached, and are used by M-profile. Signed-off-by: Richard Henderson --- target/arm/helper.c | 45 ++--- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/target/arm/h

[Qemu-devel] [PATCH v5 07/17] target/arm: Split out rebuild_hflags_a32

Currently a trivial wrapper for rebuild_hflags_common_32. Signed-off-by: Richard Henderson --- target/arm/helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 570f2dcc98..0fea62dc12 100644 --- a/target/arm/helper.c ++

[Qemu-devel] [PATCH v5 00/17] target/arm: Reduce overhead of cpu_get_tb_cpu_state

Changes since v4: * Split patch 1 into 15 smaller patches. * Cache the new DEBUG_TARGET_EL field. * Split out m-profile hflags separately from a-profile 32-bit. * Move around non-cached tb flags as well, avoiding repetitive checks for m-profile or other mutually exclusive conditions.

[Qemu-devel] [PATCH v5 04/17] target/arm: Split arm_cpu_data_is_big_endian

Set TBFLAG_ANY.BE_DATA in rebuild_hflags_common_32 and rebuild_hflags_a64 instead of rebuild_hflags_common, where we do not need to re-test is_a64() nor re-compute the various inputs. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 49 +++-- tar

[Qemu-devel] [PATCH v5 06/17] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state

Hoist the computation of some TBFLAG_A32 bits that only apply to M-profile under a single test for ARM_FEATURE_M. Signed-off-by: Richard Henderson --- target/arm/helper.c | 49 + 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/target/ar

[Qemu-devel] [PATCH v5 01/17] target/arm: Split out rebuild_hflags_common

Create a function to compute the values of the TBFLAG_ANY bits that will be cached. For now, the env->hflags variable is not used, and the results are fed back to cpu_get_tb_cpu_state. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 29 ++--- target/arm/helper

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

On Fri, Aug 16, 2019 at 05:07:10PM -0400, Yash Mankad wrote: > On 8/16/19 1:42 PM, Eduardo Habkost wrote: > > On Fri, Aug 16, 2019 at 02:22:58PM +0200, Markus Armbruster wrote: > >> Erik Skultety writes: > >> > >>> On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo H

Re: [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

On 8/19/19 4:22 PM, Max Reitz wrote: > On 19.08.19 22:18, Max Reitz wrote: >> We use null-co basically everywhere in the iotests. Unless we want to >> test null-aio specifically, we should use it instead (for consistency). >> >> Signed-off-by: Max Reitz >> Reviewed-by: John Snow > > Hm, sorr

Re: [Qemu-devel] [PATCH] block: Use QEMU_IS_ALIGNED instead of reinventing it

On Tue, Aug 20, 2019 at 10:51 PM Max Reitz wrote: > On 17.08.19 19:53, Nir Soffer wrote: > > Replace instances of: > > > > (n & (BDRV_SECTOR_SIZE - 1)) == 0) > > > > With: > > > > QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE) > > > > Which reveals the intent of the code better, and makes it easier

Re: [Qemu-devel] [PATCH v7 10/13] vfio: Add load state functions to SaveVMHandlers

On 7/23/2019 3:20 AM, Yan Zhao wrote: > On Tue, Jul 23, 2019 at 03:07:13AM +0800, Alex Williamson wrote: >> On Sun, 21 Jul 2019 23:20:28 -0400 >> Yan Zhao wrote: >> >>> On Fri, Jul 19, 2019 at 03:00:13AM +0800, Kirti Wankhede wrote: On 7/12/2019 8:22 AM, Yan Zhao wrote: > O

Re: [Qemu-devel] Regression with floppy drive controller

On Tue, Aug 20, 2019 at 06:21:28PM +0200, Philippe Mathieu-Daudé wrote: > Cc'ing Eduardo, Paolo. > > On 8/20/19 3:38 PM, Philippe Mathieu-Daudé wrote: > > On 8/20/19 3:12 PM, John Snow wrote: > >> On 8/20/19 6:25 AM, Philippe Mathieu-Daudé wrote: > >>> [cross posting QEMU & SeaBIOS] > >>> > >>> He

Re: [Qemu-devel] [PATCH v7 08/13] vfio: Register SaveVMHandlers for VFIO device

On 7/22/2019 2:04 PM, Yan Zhao wrote: > On Tue, Jul 09, 2019 at 05:49:15PM +0800, Kirti Wankhede wrote: >> Define flags to be used as delimeter in migration file stream. >> Added .save_setup and .save_cleanup functions. Mapped & unmapped migration >> region from these functions at source during

Re: [Qemu-devel] [PATCH v7 11/13] vfio: Add function to get dirty page list

On 7/22/2019 2:09 PM, Yan Zhao wrote: > On Tue, Jul 09, 2019 at 05:49:18PM +0800, Kirti Wankhede wrote: >> Dirty page tracking (.log_sync) is part of RAM copying state, where >> vendor driver provides the bitmap of pages which are dirtied by vendor >> driver through migration region and as part

Re: [Qemu-devel] [PATCH v7 06/13] vfio: Add VM state change handler to know state of VM

On 7/22/2019 2:07 PM, Yan Zhao wrote: > On Tue, Jul 09, 2019 at 05:49:13PM +0800, Kirti Wankhede wrote: >> VM state change handler gets called on change in VM's state. This is used to >> set >> VFIO device state to _RUNNING. >> VM state change handler, migration state change handler and log_syn

Re: [Qemu-devel] [PATCH v7 06/13] vfio: Add VM state change handler to know state of VM

On 7/22/2019 1:53 PM, Yan Zhao wrote: > On Fri, Jul 12, 2019 at 03:14:03AM +0800, Kirti Wankhede wrote: >> >> >> On 7/11/2019 5:43 PM, Dr. David Alan Gilbert wrote: >>> * Kirti Wankhede (kwankh...@nvidia.com) wrote: VM state change handler gets called on change in VM's state. This is used

Re: [Qemu-devel] [PATCH v7 09/13] vfio: Add save state functions to SaveVMHandlers

On 7/17/2019 8:20 AM, Yan Zhao wrote: > On Tue, Jul 09, 2019 at 05:49:16PM +0800, Kirti Wankhede wrote: >> Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy >> functions. These functions handles pre-copy and stop-and-copy phase. >> >> In _SAVING|_RUNNING device state o

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Use QEMU_IS_ALIGNED instead of reinventing it

On Tue, Aug 20, 2019 at 10:30 PM John Snow wrote: > > > On 8/17/19 1:53 PM, Nir Soffer wrote: > > Replace instances of: > > > > (n & (BDRV_SECTOR_SIZE - 1)) == 0) > > > > With: > > > > QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE) > > > > Do you have a magical incantation you used to find these? >

Re: [Qemu-devel] [PATCH v7 07/13] vfio: Add migration state change notifier

On 7/17/2019 7:55 AM, Yan Zhao wrote: > On Tue, Jul 09, 2019 at 05:49:14PM +0800, Kirti Wankhede wrote: >> Added migration state change notifier to get notification on migration state >> change. These states are translated to VFIO device state and conveyed to >> vendor >> driver. >> >> Signed-o

Re: [Qemu-devel] [PATCH v2] RISC-V: Select FPU gdb xml file based on the supported extensions

On 8/20/19 1:06 PM, Jim Wilson wrote: > I don't see a need to remove the fp csr's from the csr list.  There are other > extension dependent CSRs, like hypervisor ones. I think it makes more sense > for > the csr list to contain all of the csrs, and then disable access to them if > that extension i

Re: [Qemu-devel] [PATCH v2] RISC-V: Select FPU gdb xml file based on the supported extensions

On 8/20/19 7:39 AM, Georg Kotheimer wrote: The size of the FPU registers depends solely on the floating point extensions supported by the target architecture. However, in the previous implementation the floating point register size was derived from whether the target architecture is 32-bit or 64-

Re: [Qemu-devel] [PATCH] block: Use QEMU_IS_ALIGNED instead of reinventing it

On 17.08.19 19:53, Nir Soffer wrote: > Replace instances of: > > (n & (BDRV_SECTOR_SIZE - 1)) == 0) > > With: > > QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE) > > Which reveals the intent of the code better, and makes it easier to > locate the code checking alignment. > > QEMU_IS_ALIGNED is im

Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters

On 8/20/19 4:28 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.08.2019 22:11, John Snow wrote: >> >> >> On 8/14/19 12:54 PM, Vladimir Sementsov-Ogievskiy wrote: >>> >>> >>> 14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy >>> написал: >>> >>> Hi all! >>> >>> There is a bu

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Use QEMU_IS_ALIGNED instead of reinventing it

On 8/17/19 1:53 PM, Nir Soffer wrote: > Replace instances of: > > (n & (BDRV_SECTOR_SIZE - 1)) == 0) > > With: > > QEMU_IS_ALIGNED(n, BDRV_SECTOR_SIZE) > Do you have a magical incantation you used to find these? > Which reveals the intent of the code better, and makes it easier to

Re: [Qemu-devel] [PATCH] iotests: Check for enabled drivers before testing them

On 20.08.19 21:19, Thomas Huth wrote: > On 8/20/19 8:48 PM, Max Reitz wrote: >> On 20.08.19 18:01, Thomas Huth wrote: > [...] >>> Well, we disable blkverify in our downstream RHEL version of QEMU - so >>> it would be great if the iotests could at least adapt to that missing >>> driver. >> >> I woul

Re: [Qemu-devel] [PATCH] iotests: Check for enabled drivers before testing them

On 8/20/19 8:48 PM, Max Reitz wrote: > On 20.08.19 18:01, Thomas Huth wrote: [...] >> Well, we disable blkverify in our downstream RHEL version of QEMU - so >> it would be great if the iotests could at least adapt to that missing >> driver. > > I would like to say that RHEL is not a gold standard

Re: [Qemu-devel] [PATCH v10] qemu-io: add pattern file for write command

On 20.08.19 19:24, Eric Blake wrote: > On 8/20/19 11:46 AM, Denis Plotnikov wrote: >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> --- > >> @@ -983,8 +1057,9 @@ static int write_f(BlockBackend *blk, i

Re: [Qemu-devel] [PATCH v10] qemu-io: add pattern file for write command

On 8/20/19 1:24 PM, Eric Blake wrote: > On 8/20/19 11:46 AM, Denis Plotnikov wrote: >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> --- > >> @@ -983,8 +1057,9 @@ static int write_f(BlockBackend *bl

Re: [Qemu-devel] [RFC v2] hw/sd/aspeed_sdhci: New device

On 8/19/19 1:41 AM, Cédric Le Goater wrote: On 15/08/2019 22:13, Eddie James wrote: On 8/15/19 3:05 AM, Cédric Le Goater wrote: Hello Eddie, On 14/08/2019 22:27, Eddie James wrote: The Aspeed SOCs have two SD/MMC controllers. Add a device that encapsulates both of these controllers and model

[Qemu-devel] [RFC v3] hw/sd/aspeed_sdhci: New device

The Aspeed SOCs have two SD/MMC controllers. Add a device that encapsulates both of these controllers and models the Aspeed-specific registers and behavior. Tested by reading from mmcblk0 in Linux: qemu-system-arm -machine romulus-bmc -nographic \ -drive file=flash-romulus,format=raw,if=mtd \ -d

Re: [Qemu-devel] [PATCH] ppc: Fix xscvdpspn for SNAN

On 8/20/19 10:26 AM, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > helper_xscvdpspn() uses float64_to_float32() to convert double-precision > floating-point to single-precision. Unfortunately, float64_to_float32() > converts SNAN to QNAN, which should not happen with xscvdpspn. > > float64

Re: [Qemu-devel] [PATCH] iotests: Check for enabled drivers before testing them

On 20.08.19 18:01, Thomas Huth wrote: > On 8/20/19 5:01 PM, Max Reitz wrote: >> On 19.08.19 09:53, Thomas Huth wrote: >>> It is possible to enable only a subset of the block drivers with the >>> "--block-drv-rw-whitelist" option of the "configure" script. All other >>> drivers are marked as unusabl

Re: [Qemu-devel] [PATCH 2/2] riscv: Resolve full path of the given bios image

On Fri, Aug 16, 2019 at 6:11 AM Bin Meng wrote: > > At present when "-bios image" is supplied, we just use the straight > path without searching for the configured data directories. Like > "-bios default", we add the same logic so that "-L" actually works. > > Signed-off-by: Bin Meng Reviewed-by

Re: [Qemu-devel] [PATCH v4 20/28] riscv: sifive_u: Reference PRCI clocks in UART and ethernet nodes

On Sun, Aug 18, 2019 at 10:24 PM Bin Meng wrote: > > Now that we have added a PRCI node, update existing UART and ethernet > nodes to reference PRCI as their clock sources, to keep in sync with > the Linux kernel device tree. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair

Re: [Qemu-devel] [PATCH 12/13] qemu-img: implement key management

On 14.08.19 22:22, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/crypto.c | 16 ++ > block/crypto.h | 3 + > qemu-img-cmds.hx | 13 + > qemu-img.c | 140 +++ > 4 files changed, 172 insertions(+) Yes, this see

Re: [Qemu-devel] [PATCH 07/13] block: add manage-encryption command (qmp and blockdev)

On 14.08.19 22:22, Maxim Levitsky wrote: > This adds: > > * x-blockdev-update-encryption and x-blockdev-erase-encryption qmp commands > Both commands take the QCryptoKeyManageOptions > the x-blockdev-update-encryption is meant for non destructive addition > of key slots / whatever the encryp

Re: [Qemu-devel] Difference between commit and rebase

On 8/20/19 5:27 AM, lampahome wrote: > I want to remove snapshots and I found two ways: > qemu-img commit Commit takes a chain of images: [base] <-- [top] and commits the top image down into the base image: [base+top] > qemu-img rebase Rebase takes a chain of images: [base] <-- [top] And

Re: [Qemu-devel] [PATCH 05/13] qcrypto-luks: clear the masterkey and password before freeing them always

On 14.08.19 22:22, Maxim Levitsky wrote: > While there are other places where these are still stored in memory, > this is still one less key material area that can be sniffed with > various side channel attacks > > > (Many empty lines here) > Signed-off-by: Maxim Levitsky > --- > crypto/bloc

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

On 20.08.19 19:02, Aleksandar Markovic wrote: >> From: David Hildenbrand >> >> I just got familiar with the terminology and everything I read so far >> confuses me even more (gather/pick/extend/extl/shrd). No, I don't like that. > > David, > > How often did you use the functions in question? Thi

[Qemu-devel] [PULL v3 00/33] Misc patches for 2019-08-20

The following changes since commit 17dc57990320edaad52ac9ea808be9719c91cea6: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-08-20' into staging (2019-08-20 14:14:20 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

On 14.08.19 22:22, Maxim Levitsky wrote: > With upcoming key management, the header will > need to be stored after the image is created. > > Extracting load header isn't strictly needed, but > do this anyway for the symmetry. > > Also I extracted a function that does basic sanity > checks on the

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

On 14.08.19 22:22, Maxim Levitsky wrote: [...] > Testing. This was lightly tested with manual testing and with few iotests > that I prepared. > I haven't yet tested fully the write sharing behavior, nor did I run the > whole iotests > suite to see if this code causes some regressions. Since I w

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

20.08.2019. 18.49, "Peter Maydell" је написао/ла: > > On Tue, 20 Aug 2019 at 17:44, David Hildenbrand wrote: > > > > On 20.08.19 18:38, Aleksandar Markovic wrote: > > >> From: BALATON Zoltan > > >> > > >> Sorry to comment on this without really knowing what is it about but maybe > > >> my view i

Re: [Qemu-devel] [PATCH 02/13] qcrypto-luks: misc refactoring

On 14.08.19 22:22, Maxim Levitsky wrote: > This is also a preparation for key read/write/erase functions > > * use master key len from the header > * prefer to use crypto params in the QCryptoBlockLUKS > over passing them as function arguments > * define QCRYPTO_BLOCK_LUKS_DEFAULT_ITER_TIME > *

[Qemu-devel] [PATCH] ppc: Fix xscvdpspn for SNAN

From: "Paul A. Clarke" helper_xscvdpspn() uses float64_to_float32() to convert double-precision floating-point to single-precision. Unfortunately, float64_to_float32() converts SNAN to QNAN, which should not happen with xscvdpspn. float64_to_float32() is also used by other instruction implement

Re: [Qemu-devel] [PATCH v10] qemu-io: add pattern file for write command

On 8/20/19 11:46 AM, Denis Plotnikov wrote: > The patch allows to provide a pattern file for write > command. There was no similar ability before. > > Signed-off-by: Denis Plotnikov > --- > @@ -983,8 +1057,9 @@ static int write_f(BlockBackend *blk, int argc, char > **argv) > /* Some compil

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

If your bisect hit e3af7c788b73a6495 can you try it with cfcca361d77142f25f applied on top? That commit fixed a bug in e3af7c788b73a6495 which may be throwing off your bisection results. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

> From: David Hildenbrand > > I just got familiar with the terminology and everything I read so far > confuses me even more (gather/pick/extend/extl/shrd). No, I don't like that. David, How often did you use the functions in question? Thinks about that, and about reasons for that. Yours, Aleks

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

On 13/08/2019 15:21, Alex Bennée wrote: > > Andrey Shinkevich writes: > >> PINGING... > > Sorry about the delay. I did attempt see if the existing code threw up > any errors when built with clang's undefined sanitizer. I think this is > because xPtr->exp will only get read if none of the xPtr->

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

Hopefully third time's the charm. I ran yet another bisect, between 2.5.0 (working) and 2.11.0 (not working), this time reinstalling the entire OS from scratch with a blank disk every single time. Results: $ git bisect good e3af7c788b73a6495eb9d94992ef11f6ad6f3c56 is the first bad commit commit e3

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

> From: Laurent Vivier > > Personally I agree with David, proposed terminology is not more obvious > to me and changing things just for matter of taste is not a good idea. Thanks, Laurent for your input, but this in not a matter of taste, there are exact metrics here - different things should be

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

Le 20/08/2019 à 18:44, David Hildenbrand a écrit : > On 20.08.19 18:38, Aleksandar Markovic wrote: >>> From: BALATON Zoltan >>> >>> Sorry to comment on this without really knowing what is it about but maybe >>> my view is not completely useless if this is to be understood by people >>> who don't k

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

On 8/20/19 9:15 AM, Aleksandar Markovic wrote: > > tcg_gen_gather_i32 > > tcg_gen_gather_i64 > > tcg_gen_gather_tl > > I'm not sure how "gather" applies. > > > gather = come together; assemble or accumulate Sure, but... > To me this sounds like a vector > scatter/gather

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

On Tue, 20 Aug 2019 at 17:44, David Hildenbrand wrote: > > On 20.08.19 18:38, Aleksandar Markovic wrote: > >> From: BALATON Zoltan > >> > >> Sorry to comment on this without really knowing what is it about but maybe > >> my view is not completely useless if this is to be understood by people > >>

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

On 20.08.19 17:37, Richard Henderson wrote: > On 8/20/19 6:49 AM, Aleksandar Markovic wrote: >>> From: Peter Maydell >>> On Tue, 20 Aug 2019 at 13:50, Aleksandar Markovic >>> wrote: The idea is to provide significant "lexicographic" distance between those > groups of functions, rather

[Qemu-devel] [PATCH v10] qemu-io: add pattern file for write command

The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v10: * fix overflow [Max] * remove casting to bool [Max, Eric] * fix wording [Max] v9: * replace flag cast to int with bool [Eric] * fix the error messa

  1   2   3   >