Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 23, 2019 at 04:14:48PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Fri, Aug 23, 2019 at 03:56:34PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redh

[Qemu-devel] [PATCH v4 2/7] riscv: plic: Remove unused interrupt functions

Signed-off-by: Alistair Francis Reviewed-by: Jonathan Behrens Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Chih-Min Chao Reviewed-by: Bin Meng --- hw/riscv/sifive_plic.c | 12 include/hw/riscv/sifive_plic.h | 3 --- 2 files changed, 15 deletions(-) diff --git a/hw/r

[Qemu-devel] [PATCH v4 5/7] target/riscv: Use both register name and ABI name

From: Atish Patra Use both the generic register name and ABI name for the general purpose registers and floating point registers. Signed-off-by: Atish Patra Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.c | 19 +++ 1 file changed, 11 insertions(+)

[Qemu-devel] [PATCH v4 1/7] target/riscv: Don't set write permissions on dirty PTEs

Setting write permission on dirty PTEs results in userspace inside a Hypervisor guest (VU) becoming corrupted. This appears to be because it ends up with write permission in the second stage translation in cases where we aren't doing a store. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng

[Qemu-devel] [PATCH v4 0/7] RISC-V: Hypervisor prep work part 2

The first three patches are ones that I have pulled out of my original Hypervisor series at an attempt to reduce the number of patches in the series. These three patches all make sense without the Hypervisor series so can be merged seperatley and will reduce the review burden of the next version

[Qemu-devel] [PATCH v4 4/7] target/riscv: Update the Hypervisor CSRs to v0.4

Update the Hypervisor CSR addresses to match the v0.4 spec. Signed-off-by: Alistair Francis Reviewed-by: Chih-Min Chao Reviewed-by: Bin Meng --- target/riscv/cpu_bits.h | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/target/riscv/cpu_bi

Re: [Qemu-devel] [PATCH v3 7/7] target/riscv: Convert mip to target_ulong

On Thu, Aug 15, 2019 at 2:38 PM Alistair Francis wrote: > > The mip register is an MXLEN-bit long register. Convert it to a > target_ulong type instead of uint32_t. > > Signed-off-by: Alistair Francis MIP is 32-bit to allow atomic access on 32-bit hosts, so I am going to send a v4 with this patc

Re: [Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

On 8/23/19 3:07 AM, David Hildenbrand wrote: > +void probe_write(CPUArchState *env, target_ulong addr, int size, int mmu_idx, > + uintptr_t retaddr) > +{ > +CPUState *cpu = env_cpu(env); > +CPUClass *cc; > + > +if (!guest_addr_valid(addr) || > +(size > 0 && !gues

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Fri, Aug 23, 2019 at 04:14:48PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Fri, Aug 23, 2019 at 03:56:34PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > If two helpers are running as the s

Re: [Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

On 8/23/19 3:07 AM, David Hildenbrand wrote: > Factor it out, we'll do some further changes/extensions to both > probe_write() implementations soon. Make sure to allow "size = 0". > > Signed-off-by: David Hildenbrand > --- > accel/tcg/user-exec.c | 16 > include/exec/exec-al

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

On 8/22/19 8:33 PM, Samuel Thibault wrote: > Philippe Mathieu-Daudé, le jeu. 22 août 2019 16:41:33 +0200, a ecrit: >> Later the newly calculated pointer q is converted into ip structure >> and values are modified, Due to the wrong calculation of the delta, >> ip will be pointing to incorrect

Re: [Qemu-devel] [PATCH v2 2/6] hw/arm: Use object_initialize_child for correct reference counting

On 8/23/19 4:32 PM, Philippe Mathieu-Daudé wrote: > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the reference >

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 23, 2019 at 03:56:34PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Fri, Aug 23, 2019 at 03:26:02PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redh

Re: [Qemu-devel] [PULL 0/7] First batch of s390x changes for 4.2

On Thu, 22 Aug 2019 at 14:58, Cornelia Huck wrote: > > The following changes since commit f3b8f18ebf344ab359e8f79f6ed777e740dae77c: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2019-08-21' > into staging (2019-08-22 10:31:21 +0100) > > are available in the Git repository a

Re: [Qemu-devel] [PATCH 1/2] virtiofsd: replace warn(3) and warnx(3) with fuse_warning()

On 2019/8/23 17:24, Stefan Hajnoczi wrote: > Do not use warn(3) and warnx(3) since they print to stderr. When > --syslog is used these messages must go to syslog(3) instead. > > Signed-off-by: Stefan Hajnoczi > --- > contrib/virtiofsd/passthrough_ll.c | 36 +++--- > 1

Re: [Qemu-devel] cross-project patches: Add NBD Fast Zero support

23.08.2019 17:30, Eric Blake wrote: > This is a cover letter to a series of patches being proposed in tandem > to four different projects: I always knew you were great, but that breaks all the records > - nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag > - qemu: Implement the flag for bot

Re: [Qemu-devel] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 797 ++--- > target/arm/a32.decode | 120 +++ > target/arm/t32.decode | 141 > 3 files changed, 615 insertions(+), 443 d

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On 08/22/19 20:51, Paolo Bonzini wrote: > On 22/08/19 20:29, Laszlo Ersek wrote: >> On 08/22/19 08:18, Paolo Bonzini wrote: >>> On 21/08/19 22:17, Kinney, Michael D wrote: DMA protection of memory ranges is a chipset feature. For the current QEMU implementation, what ranges of memory are

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Fri, Aug 23, 2019 at 03:56:34PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Fri, Aug 23, 2019 at 03:26:02PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Fri, Aug 23, 2019 at 03:09:48PM

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

On Fri, Aug 23, 2019 at 09:40:54AM -0400, Cleber Rosa wrote: > On Thu, Aug 22, 2019 at 06:54:20PM -0300, Eduardo Habkost wrote: > > On Thu, Aug 22, 2019 at 05:19:26PM -0400, Cleber Rosa wrote: > > > On Thu, Aug 22, 2019 at 05:48:46PM +0100, Peter Maydell wrote: > > > > On Fri, 9 Nov 2018 at 15:09,

Re: [Qemu-devel] [PATCH v1 1/9] s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in probe_write_access()

On 8/23/19 3:07 AM, David Hildenbrand wrote: > If I'm not completely wrong, we are dealing with guest addresses here > and not with host addresses. Use the right check. > > Fixes: c5a7392cfb96 ("s390x/tcg: Provide probe_write_access helper") > Signed-off-by: David Hildenbrand > --- > target/s390

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vfio: fix a typo

Le 22/08/2019 à 08:49, Chen Zhang via Qemu-trivial a écrit : > Signed-off-by: Chen Zhang > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index dc3479c..c5e6fe6 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c >

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

On 8/23/19 7:47 AM, Peter Maydell wrote: > On Fri, 23 Aug 2019 at 15:45, Richard Henderson > wrote: >> >> On 8/23/19 6:04 AM, Peter Maydell wrote: +&ri rd imm &r rm &i imm &msr_reg rn r mask >>> >>> Should this change be in so

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

On 8/23/19 6:04 AM, Peter Maydell wrote: >> +static bool trans_ADR(DisasContext *s, arg_ri *a) >> +{ >> +store_reg_bx(s, a->rd, add_reg_for_lit(s, 15, a->imm)); >> +return true; >> +} ... >> -if (rn == 13 && rd == 13) { >> -/* ADD SP, SP,

Re: [Qemu-devel] [PATCH v1 2/9] s390x/tcg: Fix length calculation in probe_write_access()

On 8/23/19 3:07 AM, David Hildenbrand wrote: > Hm,, how did that "-" slip in (-TAGRET_PAGE_SIZE would be correct). This > currently makes us exceed one page in a single probe_write() call, > essentially leaving some memory unchecked. > > Fixes: c5a7392cfb96 ("s390x/tcg: Provide probe_write_access

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 23, 2019 at 03:26:02PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Fri, Aug 23, 2019 at 03:09:48PM +0100, Dr. David Alan Gilbert wrote: > > > > * Marc-André Lureau (marcandre.lur.

[Qemu-devel] [nbdkit PATCH 0/3] nbdkit support for new NBD fast zero

See the cross-post cover letter for details: https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html Notably, this series did NOT add fast zero support to the file plugin yet; there, I probably need to do more testing and/or kernel source code reading to learn whether to mark fallocat

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

On Fri, 23 Aug 2019 at 15:45, Richard Henderson wrote: > > On 8/23/19 6:04 AM, Peter Maydell wrote: > >> +&ri rd imm > >> &r rm > >> &i imm > >> &msr_reg rn r mask > > > > Should this change be in some other patch ? > > No, it's used by ADR. > >

[Qemu-devel] [nbdkit PATCH 2/3] filters: Add .can_fast_zero hook

Allow filters to affect the handling of the new NBD_CMD_FLAG_FAST_ZERO flag, then update affected filters. In particular, the log filter logs the state of the new flag (requires a tweak to expected output in test-fua.sh), the delay filter gains a bool parameter delay-fast-zero, several filters rej

[Qemu-devel] [libnbd PATCH 1/1] api: Add support for FAST_ZERO flag

Qemu was able to demonstrate that knowing whether a zero operation is fast is useful when copying from one image to another: there is a choice between bulk pre-zeroing and then revisiting the data sections (fewer transactions, but depends on the zeroing to be fast), vs. visiting every portion of th

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Fri, Aug 23, 2019 at 03:26:02PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Fri, Aug 23, 2019 at 03:09:48PM +0100, Dr. David Alan Gilbert wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > > Hi > > > > > > > > On Fri, A

[Qemu-devel] [nbdkit PATCH 1/3] server: Add internal support for NBDKIT_FLAG_FAST_ZERO

Qemu was able to demonstrate that knowing whether a zero operation is fast is useful when copying from one image to another: there is a choice between bulk pre-zeroing and then revisiting the data sections (fewer transactions, but depends on the zeroing to be fast), vs. visiting every portion of th

[Qemu-devel] [PATCH 1/5] nbd: Improve per-export flag handling in server

When creating a read-only image, we are still advertising support for TRIM and WRITE_ZEROES to the client, even though the client should not be issuing those commands. But seeing this requires looking across multiple functions: All callers to nbd_export_new() passed a single flag based solely on

[Qemu-devel] [PATCH 2/5] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO

Commit fe0480d6 and friends added BDRV_REQ_NO_FALLBACK as a way to avoid wasting time on a preliminary write-zero request that will later be rewritten by actual data, if it is known that the write-zero request will use a slow fallback; but in doing so, could not optimize for NBD. The NBD specifica

[Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured reply request

A server may have a reason to reject a request for structured replies, beyond just not recognizing them as a valid request. It doesn't hurt us to continue talking to such a server; otherwise 'qemu-nbd --list' of such a server fails to display all possible details about the export. Encountered whe

[Qemu-devel] [PATCH 0/5] Add NBD fast zero support to qemu client and server

See the cross-post cover letter for more details: https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html Based-on: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04805.html [Andrey Shinkevich block: workaround for unaligned byte range in fallocate()] Eric Blake (5): nbd:

[Qemu-devel] [PATCH 3/5] nbd: Implement client use of NBD FAST_ZERO

The client side is fairly straightforward: if the server advertised fast zero support, then we can map that to BDRV_REQ_NO_FALLBACK support. A server that advertises FAST_ZERO but not WRITE_ZEROES is technically broken, but we can ignore that situation as it does not change our behavior. Signed-o

[Qemu-devel] [PATCH 4/5] nbd: Implement server use of NBD FAST_ZERO

The server side is fairly straightforward: we can always advertise support for detection of fast zero, and implement it by mapping the request to the block layer BDRV_REQ_NO_FALLBACK. Signed-off-by: Eric Blake --- Again, this may be worth merging with the previous patch. --- nbd/server.c | 8 +

[Qemu-devel] [nbdkit PATCH 3/3] plugins: Add .can_fast_zero hook

Allow plugins to affect the handling of the new NBD_CMD_FLAG_FAST_ZERO flag, then update affected plugins. In particular, in-memory plugins are always fast; the full plugin is better served by omitting .zero and relying on .pwrite fallback; nbd takes advantage of libnbd extensions proposed in para

[Qemu-devel] [PATCH v2 3/6] hw/arm: Use sysbus_init_child_obj for correct reference counting

As explained in commit aff39be0ed97: Both functions, object_initialize() and qdev_set_parent_bus() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the child object will not be properly

[Qemu-devel] [PATCH 1/1] protocol: Add NBD_CMD_FLAG_FAST_ZERO

While it may be counterintuitive at first, the introduction of NBD_CMD_WRITE_ZEROES and NBD_CMD_BLOCK_STATUS has caused a performance regression in qemu [1], when copying a sparse file. When the destination file must contain the same contents as the source, but it is not known in advance whether th

[Qemu-devel] [PATCH 0/1] NBD protocol change to add fast zero support

See the cross-post cover letter for details: https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html Eric Blake (1): protocol: Add NBD_CMD_FLAG_FAST_ZERO doc/proto.md | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) -- 2.21

[Qemu-devel] [PATCH v2 2/6] hw/arm: Use object_initialize_child for correct reference counting

As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the child object will not be prope

[Qemu-devel] [PATCH v2 5/6] hw/dma/xilinx_axi: Use object_initialize_child for correct ref. counting

As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the child object will not be prope

[Qemu-devel] [libnbd PATCH 0/1] libnbd support for new fast zero

See the cross-post cover letter for details: https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html Eric Blake (1): api: Add support for FAST_ZERO flag lib/nbd-protocol.h | 2 ++ generator/generator| 29 +++-- lib/flags.c| 12 +

[Qemu-devel] [PATCH v2 6/6] hw/net/xilinx_axi: Use object_initialize_child for correct ref. counting

As explained in commit aff39be0ed97: Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the child object will not be prope

[Qemu-devel] [PATCH v2 1/6] hw/arm: Use ARM_CPU_TYPE_NAME() macro when appropriate

Commit ba1ba5cca introduce the ARM_CPU_TYPE_NAME() macro. Unify the code base by use it in all places. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- v2: rebased, use in imx25/31 (pm215) --- hw/arm/allwinner-a10.c | 3 ++- hw/arm/cubieboard.c| 3 ++- hw/arm/digic.c

[Qemu-devel] [PATCH v2 4/6] hw/arm/fsl-imx: Add the cpu as child of the SoC object

Child properties form the composition tree. All objects need to be a child of another object. Objects can only be a child of one object. Respect this with the i.MX SoC, to get a cleaner composition tree. Signed-off-by: Philippe Mathieu-Daudé --- v2: reworded commit description with Markus sugges

Re: [Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

On 8/23/19 5:03 AM, Peter Maydell wrote: > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > wrote: > > In subject, typo: "Miscellaneous". > >> This fixes an exiting bug with the T5 encoding of SUBS PC, LR, #IMM, > > "existing" > >> in that it may be executed from user mode as with any other e

[Qemu-devel] [PATCH v2 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child()

First we use ARM_CPU_TYPE_NAME() when we should. Then is follow up of [1]: This series looks at Eduardo suggestions from [2] and Thomas commit aff39be0ed97 to replace various object_initialize + qdev_set_parent_bus calls by sysbus_init_child_obj(). Finally, some devices are declared orph

[Qemu-devel] [PATCH v2] job: drop job_drain

In job_finish_sync job_enter should be enough for a job to make some progress and draining is a wrong tool for it. So use job_enter directly here and drop job_drain with all related staff not used more. Suggested-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: drop drain from

[Qemu-devel] cross-project patches: Add NBD Fast Zero support

This is a cover letter to a series of patches being proposed in tandem to four different projects: - nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag - qemu: Implement the flag for both clients and server - libnbd: Implement the flag for clients - nbdkit: Implement the flag for servers, incl

Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM

On 8/23/19 3:58 PM, Philippe Mathieu-Daudé wrote: > A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. > > If KVM is not enabled, they are enabled by default. [...] > config CHEETAH > bool > +select ARM_V4 > select OMAP > select TSC210X Are you sure about the

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 23, 2019 at 03:09:48PM +0100, Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Fri, Aug 23, 2019 at 5:00 PM Dr. David Alan Gilbert > > > wrote: > > > > > > > > * Daniel

[Qemu-devel] [PATCH v2] trace: Clarify DTrace/SystemTap help message

Most tracing backends are implemented within QEMU, except the DTrace/SystemTap backends. One side effect is when running 'qemu -trace help', an incomplete list of trace events is displayed when using the DTrace/SystemTap backends. This is partly due to trace events registered as modules with trac

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Fri, Aug 23, 2019 at 03:09:48PM +0100, Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Fri, Aug 23, 2019 at 5:00 PM Dr. David Alan Gilbert > > wrote: > > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > > > > > > > > >

Re: [Qemu-devel] [PATCH v2 15/68] target/arm: Convert BX, BXJ, BLX (register)

On 8/23/19 4:49 AM, Peter Maydell wrote: > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > wrote: >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate.c | 78 -- >> target/arm/a32.decode | 7 >> target/arm/t32.decode | 2 ++ >>

Re: [Qemu-devel] [PULL 0/6] Podman patches

On Thu, 22 Aug 2019 at 14:47, Marc-André Lureau wrote: > > The following changes since commit 810923480863c43ecb22ae124156298385439339: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-08-22 13:13:35 +0100) > > are available in the Git repository at: > >

[Qemu-devel] [Bug 1724590] Re: Usermode networking hostfwd only listens on IPv4

Hi Guys - I'm currently trying to use IPv6 with QEMU on ARM / AARCH64 Models (Sabre-Lite / Zync SOCs) and I see this problem. The system gets an IPv6 address from the QEMU in-built router which can be used to ping the default gateway (the dhcp router itself). All this is good but not really usef

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On Thu, 22 Aug 2019 at 18:42, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > --- a/tests/modules-test.c > +++

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

On Thu, 22 Aug 2019 at 18:42, Paolo Bonzini wrote: > > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/m

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Fri, Aug 23, 2019 at 5:00 PM Dr. David Alan Gilbert > wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > > > > > > This means QEMU still has to iterate over every single client > > > on the bus to identify

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Fri, Aug 23, 2019 at 05:48:37PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Aug 23, 2019 at 5:00 PM Dr. David Alan Gilbert > wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > > > > > > This means QEMU still has to iterate over every single client > > > on the bus t

[Qemu-devel] [PATCH 2/4] target/arm: Restrict R and M profiles to TCG

KVM is only able to run A profile cpus. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 522485a2de..299c59fde4 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c

[Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG

KVM requires at least a ARMv7 cpu. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 2399c14471..522485a2de 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1678,6 +1678,8

[Qemu-devel] [PATCH 4/4] RFC target/arm: Do not build A/M-profile cpus when using KVM

A KVM-only build won't be able to run A or M-profile cpus, disable them. If KVM is not enabled, they are enabled by default. Signed-off-by: Philippe Mathieu-Daudé --- Sadly this does not work with --enable-tcg --enable-kvm dual config. --- default-configs/arm-softmmu.mak | 14 ++ hw

Re: [Qemu-devel] [PATCH] block: posix: Always allocate the first block

On 22.08.19 21:01, Nir Soffer wrote: > On Thu, Aug 22, 2019 at 9:11 PM Max Reitz > wrote: > > On 22.08.19 18:39, Nir Soffer wrote: > > On Thu, Aug 22, 2019 at 5:28 PM Max Reitz > >

[Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM

A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. If KVM is not enabled, they are enabled by default. Signed-off-by: Philippe Mathieu-Daudé --- Sadly this does not work with --enable-tcg --enable-kvm dual config. --- default-configs/arm-softmmu.mak | 33 ---

[Qemu-devel] [PATCH 0/4] Support disabling TCG on ARM (part 2)

Cover from Samuel Ortiz from (part 1) [1]: This patchset allows for building and running ARM targets with TCG disabled. [...] The rationale behind this work comes from the NEMU project where we're trying to only support x86 and ARM 64-bit architectures, without including the TCG code ba

[Qemu-devel] [PATCH] hostmem-file: fix pmem file size check

Commit 314aec4a6e06844937f1677f6cba21981005f389 ("hostmem-file: reject invalid pmem file sizes") added a file size check that verifies the hostmem object's size parameter against the actual devdax pmem file. This is useful because getting the size wrong results in confusing errors inside the guest.

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

Hi On Fri, Aug 23, 2019 at 5:00 PM Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > > This means QEMU still has to iterate over every single client > > on the bus to identify them. If you're doing that, there's > > no point in owning a well known servic

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/2] spapr: Reset CAS & IRQ subsystem after devices

On 23/08/2019 07:39, David Gibson wrote: > On Thu, Aug 22, 2019 at 10:07:09PM +0200, Laurent Vivier wrote: >> On 13/08/2019 08:59, David Gibson wrote: >>> This fixes a nasty regression in qemu-4.1 for the 'pseries' machine, >>> caused by the new "dual" interrupt controller model. Specifically, >>>

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

On Fri, 23 Aug 2019 at 14:41, Cleber Rosa wrote: > I see it being used by humans, so that brings a lot of subjetivity > into the matter. IMO this is not out of place within the build > system, given that a lot of requirements detected by configure will > print out their versions (GTK, nettle, spi

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

On Thu, Aug 22, 2019 at 06:54:20PM -0300, Eduardo Habkost wrote: > On Thu, Aug 22, 2019 at 05:19:26PM -0400, Cleber Rosa wrote: > > On Thu, Aug 22, 2019 at 05:48:46PM +0100, Peter Maydell wrote: > > > On Fri, 9 Nov 2018 at 15:09, Cleber Rosa wrote: > > > > > > > > Some functionality is dependent o

[Qemu-devel] [PATCH v2] iotests: Check for enabled drivers before testing them

It is possible to enable only a subset of the block drivers with the "--block-drv-rw-whitelist" option of the "configure" script. All other drivers are marked as unusable (or only included as read-only with the "--block-drv-ro-whitelist" option). If an iotest is now using such a disabled block driv

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

On 8/22/19 7:05 PM, Paolo Bonzini wrote: > On 22/08/19 18:50, Dr. David Alan Gilbert wrote: >> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>> On 22/08/19 18:31, Dr. David Alan Gilbert wrote: > With both these points in mind, I think it is pretty hard sell to > say we should write & maint

Re: [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 23, 2019 at 12:06:09PM +0100, Dr. David Alan Gilbert wrote: > > (Copying Dan in) > > > > * Wei Yang (richardw.y...@linux.intel.com) wrote: > > > In add_to_iovec(), qemu_fflush() will be called if iovec is full. If > > > this happens,

[Qemu-devel] [PATCH 0/2] block/file-posix: Reduce xfsctl() use

Hi, As suggested by Paolo, this series drops xfsctl() calls where we have working fallocate() alternatives. (And thus replaces “block/file-posix: Fix xfs_write_zeroes()”.) Unfortunately, we also use xfsctl() to inquire the request alignment for O_DIRECT, and this is the only way we currently hav

[Qemu-devel] [PATCH 1/2] block/file-posix: Reduce xfsctl() use

This patch removes xfs_write_zeroes() and xfs_discard(). Both functions have been added just before the same feature was present through fallocate(): - fallocate() has supported PUNCH_HOLE for XFS since Linux 2.6.38 (March 2011); xfs_discard() was added in December 2010. - fallocate() has supp

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 24 +--- > target/arm/a32.decode | 1 + > target/arm/t32.decode | 19 +++ > 3 files changed, 33 insertions(+), 11 deletions(-) > > d

[Qemu-devel] [PATCH 2/2] iotests: Test reverse sub-cluster qcow2 writes

This exercises the regression introduced in commit 50ba5b2d994853b38fed10e0841b119da0f8b8e5. On my machine, it has close to a 50 % false-negative rate, but that should still be sufficient to test the fix. Signed-off-by: Max Reitz --- tests/qemu-iotests/265 | 67 +

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Daniel P. Berrangé (berra...@redhat.com) wrote: > This means QEMU still has to iterate over every single client > on the bus to identify them. If you're doing that, there's > no point in owning a well known service at all. Just iterate > over the unique bus names and look for the exported obje

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On Thu, Aug 22, 2019 at 07:42:13PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > --- a/tests/modules-te

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

On Thu, Aug 22, 2019 at 07:42:14PM +0200, Paolo Bonzini wrote: > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH 3/3] mailmap: Add many entries to improve 'git shortlog' statistics

On 8/23/19 11:44 AM, Aleksandar Markovic wrote: > 23.08.2019. 01.10, "Philippe Mathieu-Daudé" > је написао/ла: >> >> All of these emails have a least 1 commit with utf8/latin1 encoding >> issue, or one with no author name. >> When there are multiple commits, keep the auth

Re: [Qemu-devel] [PATCH 0/2] virtiofsd: use "fuse_log.h" APIs instead of

On 8/23/19 11:23 AM, Stefan Hajnoczi wrote: > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog > option was given. In this case messages to stderr are likely to be lost and > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of . > > Stefan Hajnoczi (2):

Re: [Qemu-devel] [PATCH v3 3/6] tests/docker: add podman support

Just saw this land in master, awesome. Suggestion inline. Marc-André Lureau writes: > Allow to specify the container engine to run with ENGINE variable. > > By default, ENGINE=auto and will select either podman or docker. > > Signed-off-by: Marc-André Lureau > --- > Makefile

Re: [Qemu-devel] [PATCH v2 17/68] target/arm: Convert ERET

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Pass the T5 encoding of SUBS PC, LR, #IMM through the normal SUBS path > to make it clear exactly what's happening -- we hit ALUExceptionReturn > along that path. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks

Re: [Qemu-devel] [PATCH v2 14/68] target/arm: Convert Cyclic Redundancy Check

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 121 +++-- > target/arm/a32.decode | 9 +++ > target/arm/t32.decode | 7 +++ > 3 files changed, 72 insertions(+), 65 deletions(-)

Re: [Qemu-devel] [PATCH v2 13/68] target/arm: Convert MRS/MSR (banked, register)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > The m-profile and a-profile, decodings overlap. Only return false > for the case of wrong profile; handle UNDEFINED for permission failure > directly. This ensures that we don't accidentally pass an insn that > applies to the wrong profi

Re: [Qemu-devel] [PATCH v2 11/68] target/arm: Simplify op_smlawx for SMLAW*

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > By shifting the 16-bit input left by 16, we can align the desired > portion of the 48-bit product and use tcg_gen_muls2_i32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 16 > 1 file changed, 8 i

Re: [Qemu-devel] [PATCH v3 3/6] tests/docker: add podman support

One more: does docs/devel/testing.rst need an update?

Re: [Qemu-devel] [PATCH v9 00/20] Invert Endian bit in SPARCv9 MMU TTE

On 8/22/19 12:29 PM, Richard Henderson wrote: > So... after an hour only the cover letter has arrived. > I'm thinking that it didn't work. Frustratingly, I keep getting blocked. Perhaps new GMail and Mail.com accounts sending in bulk on behalf of bt.com falls foul of spam filters. *sigh* I am m

Re: [Qemu-devel] [PATCH v2 12/68] target/arm: Convert MSR (immediate) and hints

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 60 +- > target/arm/a32.decode | 25 ++ > target/arm/t32.decode | 17 > 3 files changed, 84 insertio

Re: [Qemu-devel] [PATCH v2 10/68] target/arm: Simplify op_smlaxxx for SMLAL*

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Since all of the inputs and outputs are i32, dispense with > the intermediate promotion to i64 and use tcg_gen_add2_i32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 15 --- > 1 file changed, 8 insert

Re: [Qemu-devel] [PATCH v2 07/68] target/arm: Simplify UMAAL

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Since all of the inputs and outputs are i32, dispense with > the intermediate promotion to i64 and use tcg_gen_mulu2_i32 > and tcg_gen_add2_i32. > > Signed-off-by: Richard Henderson 8 > --- > target/arm/translate.c | 34 --

Re: [Qemu-devel] [PATCH v2 09/68] target/arm: Convert Halfword multiply and multiply accumulate

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 218 +++-- > target/arm/a32.decode | 20 > target/arm/t32.decode | 29 ++ > 3 files changed, 170 insertions(+), 97 deletio

Re: [Qemu-devel] [PATCH v2 06/68] target/arm: Convert multiply and multiply accumulate

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 248 +++-- > target/arm/a32.decode | 17 +++ > target/arm/t32.decode | 19 > 3 files changed, 177 insertions(+), 107 deletions

Re: [Qemu-devel] [PATCH v2 05/68] target/arm: Convert Data Processing (immediate)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Convert the modified immediate form of the data processing insns. > For A32, we can finally remove any code that was intertwined with > the register and register-shifted-register forms. > > Signed-off-by: Richard Henderson > --- > target

Re: [Qemu-devel] [PATCH v2 04/68] target/arm: Convert Data Processing (reg-shifted-reg)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Convert the register shifted by register form of the data > processing insns. For A32, we cannot yet remove any code > because the legacy decoder intertwines the immediate form. > > Signed-off-by: Richard Henderson > --- > target/arm/tr

<    1   2   3   4   >