Re: [Qemu-devel] [qemu-s390x] [PATCH v3 3/5] s390: vfio_pci: Use a PCI Group structure

2019-09-08 Thread Thomas Huth
On 07/09/2019 02.16, Matthew Rosato wrote: > From: Pierre Morel > > We use a S390PCIGroup structure to hold the information > related to zPCI Function group. > > This allows us to be ready to support multiple groups and to retrieve > the group information from the host. > > Signed-off-by: Pierr

[Qemu-devel] [PATCH] pci_bridge: fix a typo in comment

2019-09-08 Thread Mao Zhongyi
Signed-off-by: Mao Zhongyi --- hw/pci/pci_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index 715b9a4fe6..97967d12eb 100644 --- a/hw/pci/pci_bridge.c +++ b/hw/pci/pci_bridge.c @@ -311,7 +311,7 @@ void pci_bridge_reset(Device

[Qemu-devel] [Bug 1843205] Re: Inaccurate Fmod on i386

2019-09-08 Thread Alexander Huszagh
** Tags removed: fmod ** Tags added: float libm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1843205 Title: Inaccurate Fmod on i386 Status in QEMU: New Bug description: # Qemu Version ```

[Qemu-devel] [Bug 1843205] [NEW] Inaccurate Fmod on i386

2019-09-08 Thread Alexander Huszagh
Public bug reported: # Qemu Version ```bash $ qemu-i386 --version qemu-i386 version 3.0.1 (qemu-3.0.1-4.fc29) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers ``` # Failing Source Code (C) ```c #include #include int main() { double x = 29860476080414620.0; doub

[Qemu-devel] [PATCH v2 20/24] audio: basic support for multichannel audio

2019-09-08 Thread Kővágó, Zoltán
Which currently only means removing some checks. Old code won't require more than two channels, but new code will need it. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 7 --- audio/audio.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/audio/alsaaudio.c b

[Qemu-devel] [PATCH v2 18/24] audio: support more than two channels in volume setting

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 30 ++ audio/audio.h | 10 ++ audio/audio_int.h | 4 ++-- audio/paaudio.c| 20 audio/spiceaudio.c | 14 -- 5 files changed, 54 insertions(+), 24 deletions(-) dif

[Qemu-devel] [PATCH v2 16/24] audio: make mixeng optional

2019-09-08 Thread Kővágó, Zoltán
Implementation of the previously added mixing-engine option. Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 70 ++ audio/audio_template.h | 20 2 files changed, 78 insertions(+), 12 deletions(-) diff --git a/audio/audio.c b/audio/

[Qemu-devel] [PATCH v2 13/24] audio: common rate control code for timer based outputs

2019-09-08 Thread Kővágó, Zoltán
This commit removes the ad-hoc rate-limiting code from noaudio and wavaudio, and replaces them with a (slightly modified) code from spiceaudio. This way multiple write calls (for example when the circular buffer wraps around) do not cause problems. Signed-off-by: Kővágó, Zoltán --- audio/audio.

[Qemu-devel] [PATCH v2 15/24] audio: add mixeng option (documentation)

2019-09-08 Thread Kővágó, Zoltán
This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just convert it to a third format. We no longer convert, only the underlying sys

[Qemu-devel] [PATCH v2 24/24] usbaudio: change playback counters to 64 bit

2019-09-08 Thread Kővágó, Zoltán
With stereo playback, they need about 375 minutes of continuous audio playback to overflow, which is usually not a problem (as stopping and later resuming playback resets the counters). But with 7.1 audio, they only need about 95 minutes to overflow. After the overflow, the buf->prod % USBAUDIO_P

[Qemu-devel] [PATCH v2 06/24] ossaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/ossaudio.c | 272 +-- 1 file changed, 96 insertions(+), 176 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 1696933688..2782512706 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@ -40,1

[Qemu-devel] [PATCH v2 19/24] audio: replace shift in audio_pcm_info with bytes_per_frame

2019-09-08 Thread Kővágó, Zoltán
The bit shifting trick worked because the number of bytes per frame was always a power-of-two (since QEMU only supports mono, stereo and 8, 16 and 32 bit samples). But if we want to add support for surround sound, this no longer holds true. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c

[Qemu-devel] [PATCH v2 22/24] usb-audio: do not count on avail bytes actually available

2019-09-08 Thread Kővágó, Zoltán
This assumption is no longer true when mixeng is turned off. Signed-off-by: Kővágó, Zoltán --- hw/usb/dev-audio.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index ae42e5a2f1..74c99b1f12 100644 --- a/h

[Qemu-devel] [PATCH v2 10/24] wavaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/wavaudio.c | 54 1 file changed, 9 insertions(+), 45 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index b6eeeb4e26..7816097db8 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c @@ -36,52

[Qemu-devel] [PATCH v2 21/24] paaudio: channel-map option

2019-09-08 Thread Kővágó, Zoltán
Add an option to change the channel map used by pulseaudio. If not specified, falls back to an OSS compatible channel map. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 18 ++ qapi/audio.json | 7 +-- qemu-options.hx | 9 + 3 files changed, 28 insertions(+),

[Qemu-devel] [PATCH v2 14/24] audio: split ctl_* functions into enable_* and volume_*

2019-09-08 Thread Kővágó, Zoltán
This way we no longer need vararg functions, improving compile time error detection. Also now it's possible to check actually what commands are supported, without needing to manually update ctl_caps. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 62 -- audio/audio.

[Qemu-devel] [PATCH v2 01/24] audio: api for mixeng code free backends

2019-09-08 Thread Kővágó, Zoltán
This will make it possible to skip mixeng with audio playback and recording, allowing us to free ourselves from the limitations of the current mixeng (stereo, int64 samples only). In this case, HW and SW voices will be essentially the same, for every SW voice we will create a HW voice, since we ca

[Qemu-devel] [PATCH v2 12/24] audio: unify input and output mixeng buffer management

2019-09-08 Thread Kővágó, Zoltán
Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the initial size of the STSampleBuffer. The next commit tries to fix this inconsistency. Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 120

[Qemu-devel] [PATCH v2 02/24] alsaaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 302 -- 1 file changed, 80 insertions(+), 222 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 591344dccd..19124d09d8 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -

[Qemu-devel] [PATCH v2 08/24] sdlaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/sdlaudio.c | 87 +++- 1 file changed, 42 insertions(+), 45 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 14b11f0335..f7ac8cd101 100644 --- a/audio/sdlaudio.c +++ b/audio/sdlaudio.c @@ -41,8

[Qemu-devel] [PATCH v2 07/24] paaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/Makefile.objs | 1 - audio/audio_pt_int.c | 173 audio/audio_pt_int.h | 22 --- audio/paaudio.c | 372 ++- configure| 5 - 5 files changed, 45 insertions(+), 528 deletions(-

[Qemu-devel] [PATCH v2 11/24] audio: remove remains of the old backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 42 ++ audio/audio_int.h | 7 --- 2 files changed, 6 insertions(+), 43 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index f5a5942da9..c945f23724 100644 --- a/audio/audio.c +++ b/audio/au

[Qemu-devel] [PATCH v2 00/24] Audio: Mixeng-free 5.1/7.1 audio support

2019-09-08 Thread Kővágó, Zoltán
Hi, This is the v2 of my patch series that makes mixeng optional and enables more than two audio channels. Changes from v1: * renamed "mixeng" option to "mixing-engine" * dropped patch "audio: remove hw->samples, buffer_size_in/out pcm_ops" Regards, Zoltan Kővágó, Zoltán (24): audio: api fo

[Qemu-devel] [PATCH v2 04/24] dsoundaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/dsound_template.h | 47 +++--- audio/dsoundaudio.c | 307 +--- 2 files changed, 92 insertions(+), 262 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index 8ece870c9e..9f10b688df 100644 -

[Qemu-devel] [PATCH v2 03/24] coreaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/coreaudio.c | 130 -- 1 file changed, 69 insertions(+), 61 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index d1be58b40a..5cde42f982 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -4

[Qemu-devel] [PATCH v2 05/24] noaudio: port to the new audio backend api

2019-09-08 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/noaudio.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 0fb2629cf2..b054fd225b 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -41,10 +41,9 @@

Re: [Qemu-devel] [RFC PATCH v3 3/3] tests/acceptance: Run commands sending VNC keys

2019-09-08 Thread Thomas Huth
Am Tue, 13 Aug 2019 15:49:21 +0200 schrieb Philippe Mathieu-Daudé : > Proof of concept to interract with a framebuffer via VNC. > > This test send 'mem' and 'help' to the firmware prompt > within the single X terminal opened. > > Signed-off-by: Philippe Mathieu-Daudé > --- > This test is limite

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-08 Thread Michael S. Tsirkin
On Fri, Sep 06, 2019 at 05:32:02PM +0200, Johannes Berg wrote: > Hi, > > > Oh. Apparently qemu mailman chose this time to kick me out > > of list subscription (too many bounces or something?) > > so I didn't see it. > > D'oh. Well, it's really my mistake, I should've CC'ed you. > > > What worrie

Re: [Qemu-devel] [PATCH v3 1/5] vfio: vfio_iommu_type1: linux header place holder

2019-09-08 Thread Michael S. Tsirkin
On Fri, Sep 06, 2019 at 08:16:25PM -0400, Matthew Rosato wrote: > From: Pierre Morel > > This should be copied from Linux kernel UAPI includes. > The version used here is Linux 5.3.0 > > We define a new device region in vfio.h to be able to > get the ZPCI CLP information by reading this region f

[Qemu-devel] [PATCH] riscv: Fix timer overflow in sifive_clint.c

2019-09-08 Thread Anthony Coulter
If a hart writes -1 to mtimecmp it should not receive a timer interrupt for (2^64 - 1)/(10 MHz) = 58455 years assuming a 10 MHz realtime clock. But in practice I get a timer interrupt immediately because of an integer overflow bug when QEMU converts realtime clock ticks into nanoseconds. My propos

[Qemu-devel] [PATCH v2 1/2] linux-user: remove useless variable

2019-09-08 Thread Laurent Vivier
filename is only used to open the file if AT_EXECFD is not provided. But exec_path already contains the path of the file to open. Remove filename as it is only used in main.c whereas exec_path is also used in syscall.c. Fixes: d088d664f201 ("linux-user: identify running binary in /proc/self/exe")

[Qemu-devel] [PATCH v2 2/2] linux-user: manage binfmt-misc preserve-arg[0] flag

2019-09-08 Thread Laurent Vivier
Add --preserve-arg0 in qemu-binfmt-conf.sh to configure the preserve-arg0 flag. Now, if QEMU is started with -0 or QEMU_ARGV0 and an empty parameter argv[0] (the full pathname provided by binfmt-misc) is removed and replaced by argv[1] (the original argv[0] provided by binfmt-misc when 'P'/preserv

Re: [Qemu-devel] [PATCH v6 0/8] linux-user: strace improvements

2019-09-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190908061543.25136-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190908061543.25136-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH v6 0/8] linux-user: strace improvements