[Qemu-devel] [Bug 1832250] Re: arm32v6/golang:1.10-alpine is broken for qemu 2.8 on MacOS cross-compilation

2019-09-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1832250 Title:

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2019-09-09 Thread Rafael David Tinoco
Alright, I'm still investigating this but wanted to share some findings... I haven't got a kernel dump yet after the task is frozen, I have analyzed only the userland part of it (although I have checked if code was running inside kernel with perf cycles:u/cycles:k at some point). The big picture

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

2019-09-09 Thread Zoltán Kővágó
On 2019-08-28 12:39, Maxim Levitsky wrote: On Wed, 2019-08-28 at 11:26 +0100, Daniel P. Berrangé wrote: On Wed, Aug 28, 2019 at 01:14:03PM +0300, Maxim Levitsky wrote: On Wed, 2019-08-28 at 10:53 +0100, Daniel P. Berrangé wrote: On Wed, Aug 28, 2019 at 12:43:49AM +0200, Zoltán Kővágó wrote:

Re: [Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

2019-09-09 Thread David Gibson
On Mon, Sep 09, 2019 at 08:10:09PM +0200, Greg Kurz wrote: > Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL > tpm_proxy->host_path pointer to open(). This is based on the fact that > h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes > tpm_proxy to

Re: [Qemu-devel] [Qemu-block] [PATCH v4 1/5] tests/qemu-iotests: Fix qemu-io related output in 026.out.nocache

2019-09-09 Thread John Snow
On 8/16/19 11:30 AM, Vladimir Sementsov-Ogievskiy wrote: > qemu-io now prefixes its error and warnings with "qemu-io:". > 36b9986b08787019e fixed a lot of iotests output but forget about > 026.out.nocache. Fix it too. > > Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()") >

Re: [Qemu-devel] [PATCH 3/3] hw/mips/mips_jazz: Remove no-longer-necessary override of do_unassigned_access

2019-09-09 Thread Hervé Poussineau
Le 02/08/2019 à 18:04, Peter Maydell a écrit : Now that the MIPS CPU implementation uses the new do_transaction_failed hook, we can remove the old code that handled the do_unassigned_access hook. Signed-off-by: Peter Maydell --- hw/mips/mips_jazz.c | 27 --- 1 file

Re: [Qemu-devel] [PATCH 2/3] target/mips: Switch to do_transaction_failed() hook

2019-09-09 Thread Hervé Poussineau
Le 02/08/2019 à 18:04, Peter Maydell a écrit : Switch the MIPS target from the old unassigned_access hook to the new do_transaction_failed hook. Unlike the old hook, do_transaction_failed is only ever called from the TCG memory access paths, so there is no need for the "ignore this if we're

Re: [Qemu-devel] [PATCH 1/3] hw/mips/mips_jazz: Override do_transaction_failed hook

2019-09-09 Thread Hervé Poussineau
Le 02/08/2019 à 18:04, Peter Maydell a écrit : The MIPS Jazz ('magnum' and 'pica61') boards have some code which overrides the CPU's do_unassigned_access hook, so they can intercept it and not raise exceptions on data accesses to invalid addresses, only for instruction fetches. We want to

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-devel] [Qemu-block] [PATCH 6/6] curl: Check curl_multi_add_handle()'s return code

2019-09-09 Thread John Snow
On 8/27/19 12:34 PM, Max Reitz wrote: > If we had done that all along, debugging would have been much simpler. > (Also, I/O errors are better than hangs.) > > Signed-off-by: Max Reitz > --- > block/curl.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH 5/6] curl: Handle success in multi_check_completion

2019-09-09 Thread John Snow
On 8/27/19 12:34 PM, Max Reitz wrote: > Background: As of cURL 7.59.0, it verifies that several functions are > not called from within a callback. Among these functions is > curl_multi_add_handle(). > > curl_read_cb() is a callback from cURL and not a coroutine. Waking up > acb->co will lead

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] curl: Report only ready sockets

2019-09-09 Thread John Snow
On 8/27/19 12:34 PM, Max Reitz wrote: > Instead of reporting all sockets to cURL, only report the one that has > caused curl_multi_do_locked() to be called. This lets us get rid of the > QLIST_FOREACH_SAFE() list, which was actually wrong: SAFE foreaches are > only safe when the current

Re: [Qemu-devel] [Qemu-block] [PATCH 3/6] curl: Pass CURLSocket to curl_multi_{do, read}()

2019-09-09 Thread John Snow
On 8/27/19 12:34 PM, Max Reitz wrote: > curl_multi_do_locked() currently marks all sockets as ready. That is > not only inefficient, but in fact unsafe (the loop is). A follow-up > patch will change that, but to do so, curl_multi_do_locked() needs to > know exactly which socket is ready; and

Re: [Qemu-devel] [Qemu-block] [PATCH 2/6] curl: Keep *socket until the end of curl_sock_cb()

2019-09-09 Thread John Snow
On 8/27/19 12:34 PM, Max Reitz wrote: > This does not really change anything, but it makes the code a bit easier > to follow once we use @socket as the opaque pointer for > aio_set_fd_handler(). > > (Also, this change stops us from creating new CURLSocket objects when > the cURL library just

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] curl: Keep pointer to the CURLState in CURLSocket

2019-09-09 Thread John Snow
On 8/27/19 12:34 PM, Max Reitz wrote: > A follow-up patch will make curl_multi_do() and curl_multi_read() take a > CURLSocket instead of the CURLState. They still need the latter, > though, so add a pointer to it to the former. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz > ---

Re: [Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-09 Thread Laszlo Ersek
On 09/09/19 21:15, Laszlo Ersek wrote: > ... I've done some testing too. Applying the QEMU patch on top of > 89ea03a7dc83, my plan was: > > - do not change OVMF, just see if it continues booting with the QEMU > patch > > - then negotiate bit#1 too, in step (1a) -- this is when I'd expect (3a) >

Re: [Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-09 Thread Laszlo Ersek
Hi Igor, On 09/05/19 17:49, Igor Mammedov wrote: > lpc already has SMI negotiation feature, extend it by adding > optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. > > Writing this bit into "etc/smi/requested-features" fw_cfg file, > tells QEMU to alias 0x3,128K RAM range into

Re: [Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

2019-09-09 Thread Michael Roth
Quoting Greg Kurz (2019-09-09 13:10:09) > Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL > tpm_proxy->host_path pointer to open(). This is based on the fact that > h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes > tpm_proxy to tpm_execute(). > > The

Re: [Qemu-devel] [PATCH v2 2/3] iotests: add protocol support to initialization info

2019-09-09 Thread John Snow
On 9/9/19 6:09 AM, Max Reitz wrote: > On 29.07.19 23:35, John Snow wrote: >> This will add supported_protocols and unsupported_protocols to all of >> iotests.main, iotests.script_main, and iotests.script_initialize. >> >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/207| 4

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Junio C Hamano
Eric Blake writes: > How hard would it be to improve 'git format-patch'/'git send-email' to > have an option to ALWAYS output a From: line in the body, even when the > sender is the author, for the case of a mailing list that munges the > mail headers due to DMARC/DKIM reasons? I'd say that it

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1568049517-10261-1-git-send-email-andyc...@synology.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize

2019-09-09 Thread John Snow
On 9/9/19 6:06 AM, Max Reitz wrote: > On 29.07.19 23:35, John Snow wrote: >> Like script_main, but doesn't require a single point of entry. >> Replace all existing initialization sections with this drop-in replacement. >> >> This brings debug support to all existing script-style iotests. >> >>

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Laurent Vivier
Le 09/09/2019 à 18:11, Peter Maydell a écrit : > On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> Reviewed-by: Hervé Poussineau > >> +static void

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

2019-09-09 Thread John Snow
On 9/9/19 1:18 PM, andychiu via Qemu-devel wrote: > If Windows 10 guests have enabled 'turn off hard disk after idle' > option in power settings, and the guest has a SATA disk plugged in, > the SATA disk will be turned off after a specified idle time. > If the guest is live migrated or

[Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

2019-09-09 Thread Greg Kurz
Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL tpm_proxy->host_path pointer to open(). This is based on the fact that h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes tpm_proxy to tpm_execute(). The check in h_tpm_comm() is abusive actually since a

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-devel] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

2019-09-09 Thread Thomas Huth
On 09/09/2019 19.06, Paolo Bonzini wrote: [...] > > Thanks. While "-accel kvm:tcg" is not going to be supported, the above > replacement are all good. I guess we should really do something about that before people start using it in the wild... Thomas

[Qemu-devel] [PATCH] MAINTAINERS: update virtio-rng and virtio-serial maintainer

2019-09-09 Thread Laurent Vivier
As discussed with Amit, I volunteer to maintain virtio-rng and virtio-serial previously maintained by Amit. Signed-off-by: Laurent Vivier --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50eaf005f40e..db916ade55cd 100644

Re: [Qemu-devel] [PULL 20/42] spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy

2019-09-09 Thread Greg Kurz
On Mon, 9 Sep 2019 18:23:20 +0100 Peter Maydell wrote: > On Wed, 21 Aug 2019 at 08:26, David Gibson > wrote: > > > > From: Michael Roth > > > > This implements the H_TPM_COMM hypercall, which is used by an > > Ultravisor to pass TPM commands directly to the host's TPM device, or > > a TPM

Re: [Qemu-devel] qcow2 lock

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 15:57, Kevin Wolf wrote: > Am 09.09.2019 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 09.09.2019 13:47, Kevin Wolf wrote: >>> Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi! I have a (may be stupid) question: what is

Re: [Qemu-devel] [PATCH] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC

2019-09-09 Thread Paolo Bonzini
On 09/09/19 19:34, Cole Robinson wrote: > CONFIG_ACPI_PCI is a hard requirement of acpi-build.c, which is built > unconditionally for x86 target. Putting it in default-configs/ suggests > that it can be easily disabled, which isn't true. > > Relocate the symbol with the other acpi-build.c

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Aleksandar Markovic
09.09.2019. 18.32, "Aleksandar Markovic" је написао/ла: > > > 09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Reviewed-by: Hervé Poussineau > > --- > > Laurent, hi! > > I am

Re: [Qemu-devel] [PULL 01/12] util/iov: introduce qemu_iovec_init_extended

2019-09-09 Thread Peter Maydell
On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: > > From: Vladimir Sementsov-Ogievskiy > > Introduce new initialization API, to create requests with padding. Will > be used in the following patch. New API uses qemu_iovec_init_buf if > resulting io vector has only one element, to avoid extra

Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

2019-09-09 Thread Johannes Berg
On Mon, 2019-09-09 at 18:00 +0200, Stefan Hajnoczi wrote: > Is this really necessary? Yes* :) > Can the simulation interpose between the > call/kick eventfds in order to control when events happen? > > CPU --cpu_kickfd--> Simulation --vhost_kickfd--> vhost-user device > > and: > >

[Qemu-devel] [PATCH] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC

2019-09-09 Thread Cole Robinson
CONFIG_ACPI_PCI is a hard requirement of acpi-build.c, which is built unconditionally for x86 target. Putting it in default-configs/ suggests that it can be easily disabled, which isn't true. Relocate the symbol with the other acpi-build.c requirements, under 'config PC'. This is similar to what

Re: [Qemu-devel] [PULL 1/9] qapi: Add InetSocketAddress member keep-alive

2019-09-09 Thread Peter Maydell
On Thu, 15 Aug 2019 at 19:34, Eric Blake wrote: > > From: Vladimir Sementsov-Ogievskiy > > It's needed to provide keepalive for nbd client to track server > availability. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Message-Id: <20190725094937.32454-1-vsement...@virtuozzo.com> >

Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host

2019-09-09 Thread Paolo Bonzini
On 28/08/19 19:22, Mark Kanda wrote: > Gentle ping - I would like to confirm this patch is acceptable. Yes, it was squashed in Marcelo's patch (commit d645e1328726b38b3c79525eb57842ce29c1df7c). Paolo > Thanks/regards, > -Mark > > On 7/17/2019 9:38 AM, Mark Kanda wrote: >> The halt poll control

Re: [Qemu-devel] [PULL v2 01/16] qemu-io: add pattern file for write command

2019-09-09 Thread Peter Maydell
On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: > > From: Denis Plotnikov > > The patch allows to provide a pattern file for write > command. There was no similar ability before. > > Signed-off-by: Denis Plotnikov > Message-id: 20190820164616.4072-1-dplotni...@virtuozzo.com > Reviewed-by: Eric

Re: [Qemu-devel] IOTEST 162

2019-09-09 Thread John Snow
On 9/6/19 1:25 PM, Maxim Levitsky wrote: > Hi! > > I just had a very fun rabbit hole dive, and I want to share it with you. > > I notice for some time that iotest 162 fails with that: > > -qemu-img: Could not open 'json:{"driver": "nbd", "host": 42}': Failed to > connect socket: Invalid

Re: [Qemu-devel] [PULL 20/42] spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy

2019-09-09 Thread Peter Maydell
On Wed, 21 Aug 2019 at 08:26, David Gibson wrote: > > From: Michael Roth > > This implements the H_TPM_COMM hypercall, which is used by an > Ultravisor to pass TPM commands directly to the host's TPM device, or > a TPM Resource Manager associated with the device. > > This also introduces a new

Re: [Qemu-devel] [PULL 03/15] audio: basic support for multi backend audio

2019-09-09 Thread Peter Maydell
On Wed, 21 Aug 2019 at 09:49, Gerd Hoffmann wrote: > > From: Kővágó, Zoltán > > Audio functions no longer access glob_audio_state, instead they get an > AudioState as a parameter. This is required in order to support > multiple backends. > > glob_audio_state is also gone, and replaced with a

[Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

2019-09-09 Thread andychiu via Qemu-devel
If Windows 10 guests have enabled 'turn off hard disk after idle' option in power settings, and the guest has a SATA disk plugged in, the SATA disk will be turned off after a specified idle time. If the guest is live migrated or saved/loaded with its SATA disk turned off, the following error will

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

2019-09-09 Thread Paolo Bonzini
On 02/09/19 11:02, Daniel P. Berrangé wrote: >>> === OUTPUT BEGIN === >>> ERROR: spaces required around that '*' (ctx:WxB) >>> #118: FILE: ui/vnc-enc-tight.c:355: >>> +data = (uint##bpp##_t *)vs->tight->tight.buffer;\ >>>^ >>> >>> >> Hello

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-devel] [Qemu-arm] [RFC PATCH 12/14] hw/arm/bcm2836: Add the BCM2838 which uses a GICv2

2019-09-09 Thread Philippe Mathieu-Daudé
Hi Luc, On 9/5/19 10:41 AM, Luc Michel wrote: > On 9/4/19 7:13 PM, Philippe Mathieu-Daudé wrote: >> The BCM2838 is improvement of the BCM2837: >> - Cortex-A72 instead of the A53 >> - peripheral block and local soc controller are mapped differently, >> - GICv2 >> - PCIe block >> - exhanced MMU to

Re: [Qemu-devel] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

2019-09-09 Thread Paolo Bonzini
On 04/09/19 07:27, Thomas Huth wrote: > We've got a separate option to configure the accelerator nowadays, which > is shorter to type and the preferred way of specifying an accelerator. > Use it in the source and examples to show that it is the favored option. > (However, do not touch the places

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-09-09 Thread John Snow
On 9/9/19 5:25 AM, Max Reitz wrote: > On 05.09.19 19:27, John Snow wrote: > > [...] > >> You also probably require review (or at least an ACK) from Keith Busch >> who maintains this file. > > Keith actually maintains the NVMe guest device; technically, Fam is the > NVMe block driver

Re: [Qemu-devel] Greetings qemu folks

2019-09-09 Thread Peter Maydell
On Mon, 9 Sep 2019 at 17:56, John Snow wrote: > On 9/7/19 9:58 AM, Toe Dev wrote: > > 2) My main target is to output a lot of this to console cause I new to qemu > > and I want fastfeedback on stuff like this. I try start > > qemu with -D option but the log files never have

Re: [Qemu-devel] [PATCH v2 0/3] tests/tcg: disentangle makefiles

2019-09-09 Thread Paolo Bonzini
On 04/09/19 16:27, Alex Bennée wrote: >> Ping? > > Sorry I should have said I've queued it to testing/next. I'll post the > series shortly after I've squashed the last annoying python 3.<>6 > problem. Great, thanks. Paolo

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2019-09-09 Thread Rafael David Tinoco
Alright, with a d06 aarch64 machine I was able to reproduce it after 8 attempts.I'll debug it today and provide feedback on my findings. (gdb) bt full #0 0xb0b2181c in __GI_ppoll (fds=0xce5ab770, nfds=4, timeout=, timeout@entry=0x0, sigmask=sigmask@entry=0x0) at

Re: [Qemu-devel] Greetings qemu folks

2019-09-09 Thread John Snow
On 9/7/19 9:58 AM, Toe Dev wrote: > I am new in QEMU developing and I have general questions about QEMU source > code as I could not find any guidelines about it. > Hi, welcome! > 1) I have no success running qemu in nographic mode. >The internet says using chardev driver to redirect

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Laurent Vivier
Le 09/09/2019 à 18:32, Aleksandar Markovic a écrit : > > 09.09.2019. 18.03, "Laurent Vivier" > је написао/ла: >> >> Co-developed-by: Mark Cave-Ayland > >> Signed-off-by: Mark Cave-Ayland > >>

Re: [Qemu-devel] [PATCH] nbd/client: Add hint when TLS is missing

2019-09-09 Thread Eric Blake
On 9/9/19 4:13 AM, Daniel P. Berrangé wrote: > On Sat, Sep 07, 2019 at 12:20:55PM -0500, Eric Blake wrote: >> I received an off-list report of failure to connect to an NBD server >> expecting an x509 certificate, when the client was attempting something >> similar to this command line: >> >> +++

Re: [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

2019-09-09 Thread John Snow
On 9/6/19 7:39 AM, Thomas Huth wrote: > When running "make check -j8" or something similar, the iotests are > running in parallel with the other tests. So when they are printing > out "Passed all xx tests" or a similar status message at the end, > it might not be quite clear that this message

Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

2019-09-09 Thread John Snow
On 9/6/19 7:35 AM, Thomas Huth wrote: > The check script is already printing out which iotest is currently > running, so printing out the name of the check-block.sh shell script > looks superfluous here. > > Signed-off-by: Thomas Huth Makes sense. Acked-by: John Snow > --- >

Re: [Qemu-devel] [PATCH] tests/Makefile: test-char does not need libqtest

2019-09-09 Thread John Snow
On 9/6/19 11:26 AM, Thomas Huth wrote: > No need to link the libqtest objects here. > > Signed-off-by: Thomas Huth Reviewed-by: John Snow > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Laurent Vivier
Le 09/09/2019 à 18:18, Dr. David Alan Gilbert a écrit : > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: >>> >>> Co-developed-by: Mark Cave-Ayland >>> Signed-off-by: Mark Cave-Ayland >>> Signed-off-by: Laurent Vivier >>> Reviewed-by:

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Aleksandar Markovic
09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > --- Laurent, hi! I am not sure how "Co-developed-by:" fits in our workflow. There was some recent talk

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 3/5] s390: vfio_pci: Use a PCI Group structure

2019-09-09 Thread Matthew Rosato
On 9/9/19 1:18 AM, Thomas Huth wrote: > On 07/09/2019 02.16, Matthew Rosato wrote: >> From: Pierre Morel >> >> We use a S390PCIGroup structure to hold the information >> related to zPCI Function group. >> >> This allows us to be ready to support multiple groups and to retrieve >> the group

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Peter Maydell
On Mon, 9 Sep 2019 at 17:18, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Missing reset and VMState for migration. These should be > > baseline requirements for adding new device models to the > > tree, because in an ideal world every device would

Re: [Qemu-devel] [PATCH v8 21/32] riscv: sifive: Implement PRCI model for FU540

2019-09-09 Thread Palmer Dabbelt
On Fri, 06 Sep 2019 09:20:08 PDT (-0700), bmeng...@gmail.com wrote: This adds a simple PRCI model for FU540 (sifive_u). It has different register layout from the existing PRCI model for FE310 (sifive_e). Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes

Re: [Qemu-devel] [PATCH v8 01/32] riscv: hw: Remove duplicated "hw/hw.h" inclusion

2019-09-09 Thread Palmer Dabbelt
On Fri, 06 Sep 2019 09:19:48 PDT (-0700), bmeng...@gmail.com wrote: Commit a27bd6c779ba ("Include hw/qdev-properties.h less") wrongly added "hw/hw.h" to sifive_prci.c and sifive_test.c. Another inclusion of "hw/hw.h" was later added via commit 650d103d3ea9 ("Include hw/hw.h exactly where

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Reviewed-by: Hervé Poussineau > > > +static void

Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

2019-09-09 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 10:28:33PM +0200, Johannes Berg wrote: > > > +``VHOST_USER_VQ_CALL`` > > + :id: 34 > > + :equivalent ioctl: N/A > > + :slave payload: vring state description > > + :master payload: N/A > > Oops. This message should be called VHOST_USER_VRING_KICK. > > This file

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: > On 09.09.19 11:36, Kevin Wolf wrote: > > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > >> On 04.09.19 18:16, Kevin Wolf wrote: > >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > There are BDS children that the general block

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Peter Maydell
On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > +static void sysbus_swim_class_init(ObjectClass *oc, void *data) > +{ > +DeviceClass *dc =

[Qemu-devel] [PATCH v9 3/9] hw/m68k: add via support

2019-09-09 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/misc/Kconfig | 4 + hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 692 ++

[Qemu-devel] [PATCH v9 9/9] hw/m68k: define Macintosh Quadra 800

2019-09-09 Thread Laurent Vivier
If you want to test the machine, it doesn't yet boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer with: ./qemu-system-m68k \ -M q800 \ -serial none -serial mon:stdio \ -m 1000M -drive

[Qemu-devel] [PATCH v9 6/9] hw/m68k: add Nubus support

2019-09-09 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- hw/Kconfig | 1 + hw/Makefile.objs| 1 + hw/nubus/Kconfig| 2 + hw/nubus/Makefile.objs

[Qemu-devel] [PATCH v9 5/9] hw/m68k: add macfb video card

2019-09-09 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- arch_init.c| 4 + hw/display/Kconfig | 3 + hw/display/Makefile.objs | 1 + hw/display/macfb.c |

[Qemu-devel] [PATCH v9 1/9] esp: add pseudo-DMA as used by Macintosh

2019-09-09 Thread Laurent Vivier
There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.c:MAC_ESP_PDMA_LOOP(). The start of the

[Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/block/Kconfig| 3 + hw/block/Makefile.objs | 1 + hw/block/swim.c | 421 include/hw/block/swim.h |

[Qemu-devel] [PATCH v9 2/9] dp8393x: manage big endian bus

2019-09-09 Thread Laurent Vivier
This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 +++- 1 file

[Qemu-devel] [PATCH v9 4/9] hw/m68k: implement ADB bus support for via

2019-09-09 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- hw/misc/mac_via.c | 190 ++ include/hw/misc/mac_via.h | 7 ++ 2 files changed, 197

[Qemu-devel] [PATCH v9 7/9] hw/m68k: add Nubus support for macfb video card

2019-09-09 Thread Laurent Vivier
From: Mark Cave-Ayland Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/display/Kconfig | 1 + hw/display/macfb.c | 56 ++ include/hw/display/macfb.h | 21

[Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-09 Thread Laurent Vivier
I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer, with: ... -M q800 \ -serial

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Johannes Berg
On Mon, 2019-09-09 at 11:45 -0400, Michael S. Tsirkin wrote: > On Mon, Sep 09, 2019 at 05:34:13PM +0200, Johannes Berg wrote: > > On Mon, 2019-09-09 at 17:26 +0200, Johannes Berg wrote: > > > Maybe instead we should just add a "VHOST_USER_REPLY_ERROR" bit (e.g. > > > bit 4 after NEED_REPLY). Qemu

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2019 at 05:34:13PM +0200, Johannes Berg wrote: > On Mon, 2019-09-09 at 17:26 +0200, Johannes Berg wrote: > > > > Maybe instead we should just add a "VHOST_USER_REPLY_ERROR" bit (e.g. > > bit 4 after NEED_REPLY). Qemu in vhost_user_read_header() validates that > > it received

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Johannes Berg
On Mon, 2019-09-09 at 17:26 +0200, Johannes Berg wrote: > > Maybe instead we should just add a "VHOST_USER_REPLY_ERROR" bit (e.g. > bit 4 after NEED_REPLY). Qemu in vhost_user_read_header() validates that > it received REPLY_MASK | VERSION, so it would reject the message at that > point. > >

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Johannes Berg
On Mon, 2019-09-09 at 10:59 -0400, Michael S. Tsirkin wrote: > > > Next command is GET_FEATURES. Return an error response from that > > > and device init will fail. > > > > Hmm, what's an error here though? You can only return a value, no? > > Either returning id that does not match

[Qemu-devel] [qemu-web PATCH v4] add support page

2019-09-09 Thread Alex Bennée
This is intended to be a useful page we can link to in the banner of the IRC channel explaining the various support options someone might have. Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- v2 - add cleanups suggested by Stefan v3 - add link

Re: [Qemu-devel] Cross-posted : Odd QXL/KVM performance issue with a Windows 7 Guest

2019-09-09 Thread Dr. David Alan Gilbert
* Brad Campbell (lists2...@fnarfbargle.com) wrote: > > On 7/9/19 03:03, Dr. David Alan Gilbert wrote: > > * Brad Campbell (lists2...@fnarfbargle.com) wrote: > > > On 2/9/19 6:23 pm, Brad Campbell wrote: > > > > > > > Here is the holdup : > > > > > > > >

Re: [Qemu-devel] [PATCH v13 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-09 Thread Greg Kurz
On Mon, 09 Sep 2019 12:54:53 +0530 Aravinda Prasad wrote: > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls and sets the default > value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine > type 4.2. > I'd rather activate the feature for the

Re: [Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-09 Thread Alex Bennée
Paolo Bonzini writes: > On 09/09/19 15:20, Philippe Mathieu-Daudé wrote: >>> Doh. If we care about NSIS, we really need to have it being tested by >>> some part of our CI system, and by pre-merge build tests. >> >> I believe Stefan Weil does, since he regularly sends fixes or opens LP >> bugs

[Qemu-devel] [qemu-web PATCH v3] add support page

2019-09-09 Thread Alex Bennée
This is intended to be a useful page we can link to in the banner of the IRC channel explaining the various support options someone might have. Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- v2 - add cleanups suggested by Stefan v3 - add link

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 17:24, Max Reitz wrote: > On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: >> 09.09.2019 15:59, Max Reitz wrote: >>> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: Split copying code part from backup to "block-copy", including separate state structure and

Re: [Qemu-devel] [qemu-web PATCH v2] add support page

2019-09-09 Thread Thomas Huth
On 09/09/2019 15.58, Alex Bennée wrote: > This is intended to be a useful page we can link to in the banner of > the IRC channel explaining the various support options someone might > have. > > Signed-off-by: Alex Bennée > Reviewed-by: Marc-André Lureau > > --- > v2 > - add cleanups

Re: [Qemu-devel] [qemu-web PATCH v2] add support page

2019-09-09 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Sep 09, 2019 at 02:58:42PM +0100, Alex Bennée wrote: >> This is intended to be a useful page we can link to in the banner of >> the IRC channel explaining the various support options someone might >> have. >> >> Signed-off-by: Alex Bennée >> Reviewed-by:

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2019 at 03:50:48PM +0200, Johannes Berg wrote: > On Mon, 2019-09-09 at 09:48 -0400, Michael S. Tsirkin wrote: > > > > I suppose we could fail a later command that already needs a reply > > > without REPLY_ACK, but that seems difficult to debug? > > > > Next command is

Re: [Qemu-devel] [PATCH v9 3/9] block: add empty account cookie type

2019-09-09 Thread Alberto Garcia
On Fri 06 Sep 2019 06:01:14 PM CEST, Anton Nefedov wrote: > This adds some protection from accounting uninitialized cookie. > That is, block_acct_failed/done without previous block_acct_start; > in that case, cookie probably holds values from previous operation. > > (Note: it might also be

Re: [Qemu-devel] [PULL 0/8] Add the m68k next-cube machine

2019-09-09 Thread Peter Maydell
On Sat, 7 Sep 2019 at 16:47, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 90b1e3afd33226b6078fec6d77a18373712a975c: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-09-05-v2' into staging > (2019-09-05 17:09:13 +0100) > > are available

[Qemu-devel] [PATCH v2] test-char: fix AddressSanitizer failure

2019-09-09 Thread Paolo Bonzini
The CharSocketServerTestConfig and CharSocketClientTestConfig objects escape after they are passed to g_test_add_data_func, but they cease existing after the scope that defines them is closed. Make them static to fix this issue. Fixes: e7b6ba4186f243f149b0d8cddc129fe681ba3912 Reviewed-by:

Re: [Qemu-devel] [qemu-web PATCH v2] add support page

2019-09-09 Thread Paolo Bonzini
On 09/09/19 16:11, Daniel P. Berrangé wrote: > On Mon, Sep 09, 2019 at 02:58:42PM +0100, Alex Bennée wrote: >> This is intended to be a useful page we can link to in the banner of >> the IRC channel explaining the various support options someone might >> have. >> >> Signed-off-by: Alex Bennée >>

Re: [Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-09 Thread Paolo Bonzini
On 09/09/19 15:20, Philippe Mathieu-Daudé wrote: >> Doh. If we care about NSIS, we really need to have it being tested by >> some part of our CI system, and by pre-merge build tests. > > I believe Stefan Weil does, since he regularly sends fixes or opens LP > bugs during freeze time. > > We do

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Jeff King
On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote: > > But as you can already read from the manual, the overall behaviour of git > > regarding a separate "From:" line in the email body was intended solely for > > the use case sender != author. So in practice (at least in my git

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-09 Thread Max Reitz
On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 15:59, Max Reitz wrote: >> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >>> Split copying code part from backup to "block-copy", including separate >>> state structure and function renaming. This is needed to share it

Re: [Qemu-devel] [PATCH v6 4/8] linux-user/syscall: Introduce target_sockaddr_nl

2019-09-09 Thread Laurent Vivier
Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Tested-By: Guido Günther > --- > linux-user/syscall.c | 6 -- > linux-user/syscall_defs.h | 7 +++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-09 Thread Max Reitz
On 09.09.19 12:01, Kevin Wolf wrote: > Am 09.09.2019 um 10:31 hat Max Reitz geschrieben: >> On 05.09.19 18:24, Kevin Wolf wrote: >>> Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the

  1   2   3   >