Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv

2019-09-19 Thread Oleinik, Alexander
On Thu, 2019-09-19 at 13:15 +0200, Paolo Bonzini wrote: > On 19/09/19 01:19, Oleinik, Alexander wrote: > > The names i2c_send and i2c_recv collide with functions defined in > > hw/i2c/core.c. This causes an error when linking against libqos and > > softmmu simultaneously (for example when using qte

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Eric Blake
On 9/19/19 7:00 AM, Peter Maydell wrote: >> In an incremental build on Fedora 30, I'm now seeing: >> >> CHK version_gen.h >> GEN docs/interop/qemu-ga.8 >> No filename or title >> make: *** [/home/eblake/qemu/rules.mak:394: docs/interop/qemu-ga.8] >> Error 255 >> >> and suspect this p

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 16:03, Kevin Wolf wrote: > Am 19.09.2019 um 14:00 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 19.09.2019 12:17, Kevin Wolf wrote: >>> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > + */ > +#define MAKE_ERRP_S

Re: [Qemu-devel] [PULL 0/3] Tracing patches

2019-09-19 Thread Peter Maydell
On Wed, 18 Sep 2019 at 14:21, Stefan Hajnoczi wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are available in the Git repository at: > > https://github.com/stefa

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Eric Blake
On 9/19/19 1:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> "The evaluations of the initialization list expressions are >> indeterminately sequenced with respect to one another and thus the order >> in which any side effects occur is unspecified." >> >> which does not bode well for the assignment t

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Peter Maydell
On Thu, 19 Sep 2019 at 14:27, Eric Blake wrote: > > On 9/19/19 7:00 AM, Peter Maydell wrote: > > >> In an incremental build on Fedora 30, I'm now seeing: > >> > >> CHK version_gen.h > >> GEN docs/interop/qemu-ga.8 > >> No filename or title > >> make: *** [/home/eblake/qemu/rules.mak:

Re: [Qemu-devel] [PATCH] edk2 build scripts: work around TianoCore#1607 without forcing Python 2

2019-09-19 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 9/18/19 7:11 PM, Laszlo Ersek wrote: > It turns out that forcing python2 for running the edk2 "build" utility is > neither necessary nor sufficient. > > Forcing python2 is not sufficient for two reasons: > > - QEMU is moving away from python2, with python2 nearing EOL, > > - accor

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Eric Blake
On 9/19/19 4:17 AM, Kevin Wolf wrote: > Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: >>> + */ >>> +#define MAKE_ERRP_SAFE(errp) \ >>> +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ >>> +if ((errp) == NULL ||

[Qemu-devel] [PULL 8/8] configure: Add xkbcommon configure options

2019-09-19 Thread Laurent Vivier
From: James Le Cuirot This dependency is currently "automagic", which is bad for distributions. Signed-off-by: James Le Cuirot Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Message-Id: <20190914145155.19360-1-ch...@gentoo.org> Signed-off-by: Laure

Re: [Qemu-devel] [PATCH] edk2 build scripts: work around TianoCore#1607 without forcing Python 2

2019-09-19 Thread Philippe Mathieu-Daudé
Hi Bruce, On 9/18/19 7:11 PM, Laszlo Ersek wrote: > It turns out that forcing python2 for running the edk2 "build" utility is > neither necessary nor sufficient. > > Forcing python2 is not sufficient for two reasons: > > - QEMU is moving away from python2, with python2 nearing EOL, > > - accord

[Qemu-devel] [PULL 0/8] Trivial branch patches

2019-09-19 Thread Laurent Vivier
up to 754119198de633683d7af79bc08e73c2de9df011: configure: Add xkbcommon configure options (2019-09-19 14:42:31 +0200) Trivial patches 20190919 Chen Zhang (1

[Qemu-devel] [PULL 5/8] build: Don't ignore qapi-visit-core.c

2019-09-19 Thread Laurent Vivier
From: Eric Blake This file is version-controlled, and not generated from a .json file. Fixes: bf582c3461b Reported-by: Thomas Huth Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190912184607.3507-1-ebl...@redhat.com> Signed-off-by: Laure

[Qemu-devel] [PULL 1/8] vfio: fix a typo

2019-09-19 Thread Laurent Vivier
From: Chen Zhang Signed-off-by: Chen Zhang Reviewed-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Message-Id: <8e5a9c27-c76d-46cf-85b0-79121a00b...@me.com> Signed-off-by: Laurent Vivier --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL 4/8] target/m68k/fpu_helper.c: rename the access arguments

2019-09-19 Thread Laurent Vivier
From: KONRAD Frederic The "access" arguments clash with a macro under Windows with MinGW: CC m68k-softmmu/target/m68k/fpu_helper.o target/m68k/fpu_helper.c: In function 'fmovem_predec': target/m68k/fpu_helper.c:405:56: error: macro "access" passed 4 arguments, but takes just 2

[Qemu-devel] [PULL 7/8] kvm: Fix typo in header of kvm_device_access()

2019-09-19 Thread Laurent Vivier
From: Greg Kurz Signed-off-by: Greg Kurz Message-Id: <156829664683.2070256.13400788010568373502.st...@bahia.tls.ibm.com> Signed-off-by: Laurent Vivier --- include/sysemu/kvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index

Re: [Qemu-devel] [PATCH v3 16/22] fuzz: add fuzzer skeleton

2019-09-19 Thread Oleinik, Alexander
On Thu, 2019-09-19 at 13:48 +0100, Stefan Hajnoczi wrote: > > + > > +void reboot(QTestState *s) > > +{ > > +qemu_system_reset(SHUTDOWN_CAUSE_GUEST_RESET); > > +} > > Why does reboot() take an unused argument? It was needed when I had a reset_state(s) pointer which was separate from fuzz(). Si

[Qemu-devel] [PULL 6/8] Fix cacheline detection on FreeBSD/powerpc.

2019-09-19 Thread Laurent Vivier
From: Justin Hibbits machdep.cacheline_size is an integer, not a long. Since PowerPC is big-endian this causes sysctlbyname() to fill in the upper bits of the argument, rather than the correct 'lower bits' of the word. Specify the correct type to fix this. Fixes: b255b2c8a548 ("util: add cache

[Qemu-devel] [PULL 2/8] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

2019-09-19 Thread Laurent Vivier
From: Philippe Mathieu-Daudé "qemu/cutils.h" contains various qemu_strtosz_*() functions useful to convert strings to size. It seems natural to have the opposite usage (from size to string) there too. The function definition is already in util/cutils.c. Signed-off-by: Philippe Mathieu-Daudé Re

Re: [Qemu-devel] [PATCH 0/2] Fix tarball builds of UEFI/EDK2 firmware

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/13/19 1:12 AM, Michael Roth wrote: > Bruce noticed that we cannot build `make efi` target from the v4.1.0 > tarball. This is due to a failure on the part of the make-release script > to pull in submodules nested under other submodules, as well as > Makefile.edk2's assumptions about being in a

Re: [Qemu-devel] [PATCH] BootLinuxSshTest: Only run the tests when explicitly requested

2019-09-19 Thread Cleber Rosa
On Wed, Sep 18, 2019 at 09:23:59PM -0400, Cleber Rosa wrote: > On Wed, Sep 18, 2019 at 02:27:48PM +0200, Philippe Mathieu-Daudé wrote: > > Currently the Avocado framework does not distinct the time spent > > downloading assets vs. the time spent running a test. With big > > assets (like a full VM i

[Qemu-devel] [PULL 3/8] Replace '-machine accel=xyz' with '-accel xyz'

2019-09-19 Thread Laurent Vivier
From: Thomas Huth We've got a separate option to configure the accelerator nowadays, which is shorter to type and the preferred way of specifying an accelerator. Use it in the source and examples to show that it is the favored option. (However, do not touch the places yet which also specify other

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Michael S. Tsirkin
On Thu, Sep 19, 2019 at 05:37:48PM +0800, Jason Wang wrote: > > On 2019/9/19 下午3:16, Tian, Kevin wrote: > > +Paolo to help clarify here. > > > > > From: Jason Wang [mailto:jasow...@redhat.com] > > > Sent: Thursday, September 19, 2019 2:32 PM > > > > > > > > > On 2019/9/19 下午2:17, Yan Zhao wrote

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Eric Blake
On 9/19/19 8:35 AM, Peter Maydell wrote: > On Thu, 19 Sep 2019 at 14:27, Eric Blake wrote: >> >> On 9/19/19 7:00 AM, Peter Maydell wrote: >> In an incremental build on Fedora 30, I'm now seeing: CHK version_gen.h GEN docs/interop/qemu-ga.8 No filename or titl

Re: [Qemu-devel] [PATCH v3 17/22] fuzz: add support for fork-based fuzzing.

2019-09-19 Thread Oleinik, Alexander
On Thu, 2019-09-19 at 13:54 +0100, Stefan Hajnoczi wrote: > On Wed, Sep 18, 2019 at 11:19:44PM +, Oleinik, Alexander wrote: > > diff --git a/exec.c b/exec.c > > index 235d6bc883..d3838f4ea4 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -2295,7 +2295,9 @@ static void ram_block_add(RAMBlock > >

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 16:40, Eric Blake wrote: > On 9/19/19 4:17 AM, Kevin Wolf wrote: >> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >>> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: + */ +#define MAKE_ERRP_SAFE(errp) \ +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.er

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Eric Blake
On 9/19/19 8:03 AM, Kevin Wolf wrote: >> >> Interesting, that to handle error_append_hint problem, we don't need to >> create local_err in case of errp==NULL either.. >> >> So, possibly, we need the following steps: >> >> 1. implement MAKE_ERRP_SAFE_FOR_HINT (which only leave "*(errp) == >> error

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Alex Bennée
Peter Maydell writes: > On Thu, 19 Sep 2019 at 02:25, Eric Blake wrote: >> >> On 9/13/19 10:49 AM, Peter Maydell wrote: >> > The qemu-ga documentation is currently in qemu-ga.texi in >> > Texinfo format, which we present to the user as: >> > * a qemu-ga manpage >> > * a section of the main q

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Eric Blake
On 9/19/19 9:13 AM, Vladimir Sementsov-Ogievskiy wrote: > > With my plan of two different macro, I at least messed the case when we need > both dereferencing and hints, which means third macro, or one macro with > parameters, > saying what to wrap. > > And my aim was to follow the idea of "do p

Re: [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv

2019-09-19 Thread Paolo Bonzini
On 19/09/19 15:27, Oleinik, Alexander wrote: > On Thu, 2019-09-19 at 13:18 +0200, Paolo Bonzini wrote: >> I think you can pass "s" to the tx handler as well, and remove the >> send_opaque and recv_opaque fields? > > Qtest also uses this function to communicate over qmp (different fd). > I can pro

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Eric Blake
On 9/19/19 9:30 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> To the same topic, of minimization: should we always call MAKE_ERRP_SAFE at >> function top, or only >> in block, where it is needed (assume, we dereference it only inside some >> "if" or "while"? >> Kevin, is something bad in propaga

Re: [RFC v2 1/5] cputlb: Disable __always_inline__ without optimization

2019-09-19 Thread David Hildenbrand
On 18.09.19 20:02, Richard Henderson wrote: > This forced inlining can result in missing symbols, > which makes a debugging build harder to follow. > > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > include/qemu/compiler.h | 11 +++ > accel/tcg/cputlb.c | 4

Re: [PATCH 6/7] target/i386: add VMX features

2019-09-19 Thread Liran Alon
> On 17 Sep 2019, at 13:34, Paolo Bonzini wrote: > > Add code to convert the VMX feature words back into MSR values, > allowing the user to enable/disable VMX features as they wish. The same > infrastructure enables support for limiting VMX features in named > CPU models. > > Signed-off-by:

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Kevin Wolf
Am 19.09.2019 um 16:13 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.09.2019 16:40, Eric Blake wrote: > > On 9/19/19 4:17 AM, Kevin Wolf wrote: > >> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: > >>> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > + */ > +#define MAKE

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

2019-09-19 Thread Richard Henderson
On 9/18/19 4:47 PM, Alistair Francis wrote: > I'm not a fan of the pointer method that I'm using, but to me it seems > the least worst in terms of handling future code, keeping everythign > consistnent and avoiding complex access rules. FWIW, I prefer the "banked" register method used by ARM. enu

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 17:12, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 16:40, Eric Blake wrote: >> On 9/19/19 4:17 AM, Kevin Wolf wrote: >>> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > + */ > +#define MAKE_ERRP_SAFE(errp) \ >

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 09:44:14AM -0500, Eric Blake wrote: > On 9/19/19 9:30 AM, Vladimir Sementsov-Ogievskiy wrote: > > >> > >> To the same topic, of minimization: should we always call MAKE_ERRP_SAFE > >> at function top, or only > >> in block, where it is needed (assume, we dereference it onl

Re: [RFC v2 2/5] cputlb: Replace switches in load/store_helper with callback

2019-09-19 Thread David Hildenbrand
On 18.09.19 20:02, Richard Henderson wrote: > Add a function parameter to perform the actual load/store to ram. > With optimization, this results in identical code. > > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 159 +++-- > 1 file chang

Re: [PATCH 6/7] target/i386: add VMX features

2019-09-19 Thread Paolo Bonzini
On 19/09/19 16:32, Liran Alon wrote: > > >> On 17 Sep 2019, at 13:34, Paolo Bonzini wrote: >> >> Add code to convert the VMX feature words back into MSR values, >> allowing the user to enable/disable VMX features as they wish. The same >> infrastructure enables support for limiting VMX features

Re: [RFC v2 3/5] cputlb: Introduce TLB_BSWAP

2019-09-19 Thread David Hildenbrand
On 18.09.19 20:02, Richard Henderson wrote: > Handle bswap on ram directly in load/store_helper. This fixes a > bug with the previous implementation in that one cannot use the > I/O path for RAM. > > Fixes: a26fc6f5152b47f1 > Signed-off-by: Richard Henderson > --- > include/exec/cpu-all.h | 2

Re: [RFC v2 2/5] cputlb: Replace switches in load/store_helper with callback

2019-09-19 Thread Richard Henderson
On 9/19/19 7:53 AM, David Hildenbrand wrote: > On 18.09.19 20:02, Richard Henderson wrote: >> Add a function parameter to perform the actual load/store to ram. >> With optimization, this results in identical code. >> >> Signed-off-by: Richard Henderson >> --- >> accel/tcg/cputlb.c | 159 +

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 17:44, Eric Blake wrote: > On 9/19/19 9:30 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> >>> To the same topic, of minimization: should we always call MAKE_ERRP_SAFE at >>> function top, or only >>> in block, where it is needed (assume, we dereference it only inside some >>> "if" or "

Re: [RFC v2 3/5] cputlb: Introduce TLB_BSWAP

2019-09-19 Thread Richard Henderson
On 9/19/19 8:09 AM, David Hildenbrand wrote: > On 18.09.19 20:02, Richard Henderson wrote: >> Handle bswap on ram directly in load/store_helper. This fixes a >> bug with the previous implementation in that one cannot use the >> I/O path for RAM. >> >> Fixes: a26fc6f5152b47f1 >> Signed-off-by: Rich

Re: [Qemu-devel] [PULL 00/26] Audio 20190919 patches

2019-09-19 Thread Peter Maydell
git://git.kraxel.org/qemu tags/audio-20190919-pull-request > > for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96: > > audio: fix ALSA period-length typo in documentation (2019-09-19 10:32:48 > +0200) > > --

Re: [PATCH 6/7] target/i386: add VMX features

2019-09-19 Thread Paolo Bonzini
On 19/09/19 16:54, Paolo Bonzini wrote: > I will add defines for fixed_vmx_basic, fixed_vmx_misc and > fixed_vmx_ept_mask, though. ... like this: diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 8447ece..c62e3b6 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -779,14 +779,19 @@

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Peter Maydell
On Thu, 19 Sep 2019 at 14:54, Eric Blake wrote: > > On 9/19/19 8:35 AM, Peter Maydell wrote: > > On Thu, 19 Sep 2019 at 14:27, Eric Blake wrote: > >> > >> On 9/19/19 7:00 AM, Peter Maydell wrote: > >> > In an incremental build on Fedora 30, I'm now seeing: > > CHK version_g

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Eric Blake
On 9/19/19 9:49 AM, Daniel P. Berrangé wrote: >> ALWAYS using MAKE_ERRP_SAFE() on entry to any function that has an Error >> **errp parameter is dirt-simple to explain. It has no performance >> penalty if the user passed in a normal error or error_abort (the cost of >> an 'if' hidden in the macro

Re: [PULL 15/26] audio: add mixeng option (documentation)

2019-09-19 Thread Eric Blake
On 9/19/19 3:36 AM, Gerd Hoffmann wrote: > From: Kővágó, Zoltán > > This will allow us to disable mixeng when we use a decent backend. > > Disabling mixeng have a few advantages: > * we no longer convert the audio output from one format to another, when > the underlying audio system would just

Re: [Qemu-devel] [PULL 00/26] Audio 20190919 patches

2019-09-19 Thread Eric Blake
+0100) >> >> are available in the Git repository at: >> >> git://git.kraxel.org/qemu tags/audio-20190919-pull-request >> >> for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96: >> >> a

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Eric Blake
On 9/19/19 10:22 AM, Peter Maydell wrote: > Alex looked at this and suggests the problem is probably because > you're doing an in-tree build. Bingo. I thought we wanted to get rid of that, though. What's the status on forcing out-of-tree builds? (I'll adapt, but only once patches are in that f

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 18:24, Eric Blake wrote: > On 9/19/19 9:49 AM, Daniel P. Berrangé wrote: > >>> ALWAYS using MAKE_ERRP_SAFE() on entry to any function that has an Error >>> **errp parameter is dirt-simple to explain. It has no performance >>> penalty if the user passed in a normal error or error_abort

Re: [qemu-web PATCH] Gemfile: use a fixed version of sassc

2019-09-19 Thread Thomas Huth
On 19/09/2019 15.01, Paolo Bonzini wrote: > Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the > Gemfile was requiring an earlier version (2.1.0 in practice). > Since the bug has been fixed, remove the workaround and instead > require a fixed version. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-19 Thread Peter Maydell
On Thu, 19 Sep 2019 at 16:37, Eric Blake wrote: > > On 9/19/19 10:22 AM, Peter Maydell wrote: > > > Alex looked at this and suggests the problem is probably because > > you're doing an in-tree build. > > Bingo. I thought we wanted to get rid of that, though. What's the > status on forcing out-of

Re: [RFC v2 4/5] exec: Adjust notdirty tracing

2019-09-19 Thread David Hildenbrand
On 18.09.19 20:02, Richard Henderson wrote: > The memory_region_tb_read tracepoint is unreachable, since notdirty > is supposed to apply only to writes. The memory_region_tb_write > tracepoint is mis-named, because notdirty is not only used for TB > invalidation. It is also used for e.g. VGA RAM

Re: [NOTFORMERGE PATCH v2 1/9] tests/docker: Kludge to build the Fedora image

2019-09-19 Thread Philippe Mathieu-Daudé
On 7/16/19 3:03 PM, Philippe Mathieu-Daudé wrote: > On 7/16/19 12:54 PM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Rebuilding the Fedora image is failing: >>> >>> $ make docker-image-fedora V=1 >> >> Broken build state? Just do: >> >> make docker-image-fedora V=1 NOCACHE=1

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 10:24:20AM -0500, Eric Blake wrote: > On 9/19/19 9:49 AM, Daniel P. Berrangé wrote: > > >> ALWAYS using MAKE_ERRP_SAFE() on entry to any function that has an Error > >> **errp parameter is dirt-simple to explain. It has no performance > >> penalty if the user passed in a n

[PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern

2019-09-19 Thread Cleber Rosa
Instead of looking for a specific error, let's relax the pattern because different errors have been seen (I'm consistenly getting 52) and the real goal of this test is to validate the framebuffer operation, and not to reproduce one specific error. Signed-off-by: Cleber Rosa --- tests/acceptance/

[PATCH] Makefile: Fix in-tree builds when Sphinx is available

2019-09-19 Thread Peter Maydell
In commit 27a296fce9821e we switched the qemu-ga manpage over to being built from Sphinx. The makefile rules for this were correct for an out-of-tree build, but break for in-tree builds if Sphinx is present and we're trying to build the documentation. Specifically, because Sphinx refuses to build

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 18:50, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 10:24:20AM -0500, Eric Blake wrote: >> On 9/19/19 9:49 AM, Daniel P. Berrangé wrote: >> ALWAYS using MAKE_ERRP_SAFE() on entry to any function that has an Error **errp parameter is dirt-simple to explain. It has no per

Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread Richard Henderson
On 9/19/19 2:41 AM, David Hildenbrand wrote: >> +/* prepare the buffers - two consecutive pages */ >> +src = valloc(ALLOC_SIZE); >> +dst = valloc(ALLOC_SIZE); > > If anybody cares, I can convert the obsolete valloc into a > posix_memalign(&src, 4096, ALLOC_SIZE) etc. I don't care. It

Re: [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern

2019-09-19 Thread Philippe Mathieu-Daudé
Cc'ing Thomas On 9/19/19 6:14 PM, Cleber Rosa wrote: > Instead of looking for a specific error, let's relax the pattern > because different errors have been seen (I'm consistenly getting 52) > and the real goal of this test is to validate the framebuffer > operation, and not to reproduce one speci

Re: [Qemu-devel] [PULL 0/2] Ati 20190919 patches

2019-09-19 Thread Peter Maydell
git://git.kraxel.org/qemu tags/ati-20190919-pull-request > > for you to fetch changes up to aab0e2a661b2b6bf7915c0aefe807fb60d6d9d13: > > ati: use vga_read_byte in ati_cursor_define (2019-09-19 10:37:46 +0200) > > -

[PULL 0/2] Python (acceptance tests) queue, 2019-09-19

2019-09-19 Thread Cleber Rosa
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) are available in the Git repository at: git://github.com/clebergnu/qemu.git tags/python-next-pull-request for you to fetch changes u

[PULL 2/2] BootLinuxSshTest: Only run the tests when explicitly requested

2019-09-19 Thread Cleber Rosa
From: Philippe Mathieu-Daudé Currently the Avocado framework does not distinct the time spent downloading assets vs. the time spent running a test. With big assets (like a full VM image) the tests likely fail. This is a limitation known by the Avocado team. Until this issue get fixed, do not run

[PULL 1/2] tests/acceptance: Specify arch for QueryCPUModelExpansion

2019-09-19 Thread Cleber Rosa
From: David Gibson At the moment this test runs on whatever the host arch is. But it looks for 'unavailable-features' which is an x86 specific cpu property. Tag it to always use qemu-system-x86_64. Signed-off-by: David Gibson Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mat

[PATCH v2 1/2] iotests: Require Python 3.6 or later

2019-09-19 Thread Kevin Wolf
Running iotests is not required to build QEMU, so we can have stricter version requirements for Python here and can make use of new features and drop compatibility code earlier. This makes qemu-iotests skip all Python tests if a Python version before 3.6 is used for the build. Suggested-by: Eduar

[PATCH v2 0/2] iotests: Require Python 3.6 or later

2019-09-19 Thread Kevin Wolf
v2: - Provide the right exit code from Python instead of having a potentially confusing negation in the shell script - Raised the minimal version to 3.6. If we're going to use a different version than QEMU as a whole anyway, we can use a version that suits us best. 3.5 would only be for Deb

[PATCH v2 2/2] iotests: Remove Python 2 compatibility code

2019-09-19 Thread Kevin Wolf
Some scripts check the Python version number and have two code paths to accomodate both Python 2 and 3. Remove the code specific to Python 2 and assert the minimum version of 3.6 instead (check skips Python tests in this case, so the assertion would only ever trigger if a Python script is executed

Re: [PATCH v2 1/2] iotests: Require Python 3.6 or later

2019-09-19 Thread Eduardo Habkost
On Thu, Sep 19, 2019 at 06:29:04PM +0200, Kevin Wolf wrote: > Running iotests is not required to build QEMU, so we can have stricter > version requirements for Python here and can make use of new features > and drop compatibility code earlier. > > This makes qemu-iotests skip all Python tests if a

Re: [PATCH v2 2/2] iotests: Remove Python 2 compatibility code

2019-09-19 Thread Eduardo Habkost
On Thu, Sep 19, 2019 at 06:29:05PM +0200, Kevin Wolf wrote: > Some scripts check the Python version number and have two code paths to > accomodate both Python 2 and 3. Remove the code specific to Python 2 and > assert the minimum version of 3.6 instead (check skips Python tests in > this case, so t

Re: [PATCH] edk2 build scripts: work around TianoCore#1607 without forcing Python 2

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/18/19 7:11 PM, Laszlo Ersek wrote: > It turns out that forcing python2 for running the edk2 "build" utility is > neither necessary nor sufficient. > > Forcing python2 is not sufficient for two reasons: > > - QEMU is moving away from python2, with python2 nearing EOL, > > - according to my m

Re: [PATCH v2 1/2] iotests: Require Python 3.6 or later

2019-09-19 Thread Thomas Huth
On 19/09/2019 18.29, Kevin Wolf wrote: > Running iotests is not required to build QEMU, so we can have stricter > version requirements for Python here and can make use of new features > and drop compatibility code earlier. > > This makes qemu-iotests skip all Python tests if a Python version befor

Re: [PATCH v2 2/2] iotests: Remove Python 2 compatibility code

2019-09-19 Thread Thomas Huth
On 19/09/2019 18.29, Kevin Wolf wrote: > Some scripts check the Python version number and have two code paths to > accomodate both Python 2 and 3. Remove the code specific to Python 2 and > assert the minimum version of 3.6 instead (check skips Python tests in > this case, so the assertion would on

Re: [Qemu-devel] [PATCH 0/4] mirror: Do not dereference invalid pointers

2019-09-19 Thread Max Reitz
On 18.09.19 17:38, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 16:56, Max Reitz wrote: >> Hi, >> >> The fix (patch 1) is pretty straightforward; patch 2 (which I need for >> the test) may not be. >> >> The biggest problem with patch 2 is that you can use it to uncover where >> our permission h

Re: [Qemu-devel] [PATCH 2/4] blkdebug: Allow taking/unsharing permissions

2019-09-19 Thread Max Reitz
On 18.09.19 18:01, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 16:56, Max Reitz wrote: >> Sometimes it is useful to be able to add a node to the block graph that >> takes or unshare a certain set of permissions for debugging purposes. >> This patch adds this capability to blkdebug. >> >> (Note

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-19 Thread John Snow
On 9/19/19 4:35 AM, Kevin Wolf wrote: > Am 18.09.2019 um 20:49 hat John Snow geschrieben: >> >> >> On 9/18/19 4:55 AM, Kevin Wolf wrote: >>> Running iotests is not required to build QEMU, so we can have stricter >>> version requirements for Python here and can make use of new features >>> and dr

Re: [Qemu-devel] [PATCH 0/4] mirror: Do not dereference invalid pointers

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 19:45, Max Reitz wrote: > On 18.09.19 17:38, Vladimir Sementsov-Ogievskiy wrote: >> 12.09.2019 16:56, Max Reitz wrote: >>> Hi, >>> >>> The fix (patch 1) is pretty straightforward; patch 2 (which I need for >>> the test) may not be. >>> >>> The biggest problem with patch 2 is that you can

Re: [RFC] error: auto propagated local_err

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 04:16:25PM +, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 18:50, Daniel P. Berrangé wrote: > > On Thu, Sep 19, 2019 at 10:24:20AM -0500, Eric Blake wrote: > >> On 9/19/19 9:49 AM, Daniel P. Berrangé wrote: > >> > ALWAYS using MAKE_ERRP_SAFE() on entry to any fu

Re: [Qemu-devel] [PATCH 4/4] iotests: Add test for failing mirror complete

2019-09-19 Thread Max Reitz
On 18.09.19 18:30, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 16:56, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/041 | 44 ++ >> tests/qemu-iotests/041.out | 4 ++-- >> 2 files changed, 46 insertions(+), 2 deletions(-

Re: Problems with MIPS Malta SSH tests in make check-acceptance

2019-09-19 Thread Cleber Rosa
On Wed, Sep 18, 2019 at 09:14:58PM -0400, Cleber Rosa wrote: > On Wed, Sep 18, 2019 at 05:16:54PM +1000, David Gibson wrote: > > Hi, > > > > I'm finding make check-acceptance is currently useless for me as a > > pre-pull test, because a bunch of the tests are not at all reliable. > > There are a b

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-19 Thread John Snow
On 9/19/19 4:35 AM, Kevin Wolf wrote: > Am 18.09.2019 um 20:49 hat John Snow geschrieben: >> >> >> On 9/18/19 4:55 AM, Kevin Wolf wrote: >>> Running iotests is not required to build QEMU, so we can have stricter >>> version requirements for Python here and can make use of new features >>> and dr

Re: [Qemu-devel] [PATCH 4/4] iotests: Add test for failing mirror complete

2019-09-19 Thread Max Reitz
On 18.09.19 20:46, John Snow wrote: > > > On 9/12/19 9:56 AM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >>   tests/qemu-iotests/041 | 44 ++ >>   tests/qemu-iotests/041.out |  4 ++-- >>   2 files changed, 46 insertions(+), 2 deletions(-) >> >> dif

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

2019-09-19 Thread Jonathan Behrens
On Thu, Sep 19, 2019 at 10:50 AM Richard Henderson wrote: > > On 9/18/19 4:47 PM, Alistair Francis wrote: > > I'm not a fan of the pointer method that I'm using, but to me it seems > > the least worst in terms of handling future code, keeping everythign > > consistnent and avoiding complex access

Re: Problems with MIPS Malta SSH tests in make check-acceptance

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 6:56 PM, Cleber Rosa wrote: > On Wed, Sep 18, 2019 at 09:14:58PM -0400, Cleber Rosa wrote: >> On Wed, Sep 18, 2019 at 05:16:54PM +1000, David Gibson wrote: >>> Hi, >>> >>> I'm finding make check-acceptance is currently useless for me as a >>> pre-pull test, because a bunch of the tests a

Re: [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-19 Thread Laszlo Ersek
Hi Igor, (+Brijesh) long-ish pondering ahead, with a question at the end. On 09/17/19 15:07, Igor Mammedov wrote: > Use commit (2f295167e0 q35/mch: implement extended TSEG sizes) for > inspiration and (ab)use reserved register in config space at 0x9c > offset [*] to extend q35 pci-host with abil

Will the qemu-devel prefix in the mails come back?

2019-09-19 Thread Martin Schrodt
Does anybody know? My mail filter would appreciate :) Thank you, Martin

Re: [Qemu-devel] [PATCH 4/4] iotests: Add test for failing mirror complete

2019-09-19 Thread John Snow
On 9/19/19 12:58 PM, Max Reitz wrote: > On 18.09.19 20:46, John Snow wrote: >> >> >> On 9/12/19 9:56 AM, Max Reitz wrote: >>> Signed-off-by: Max Reitz >>> --- >>>   tests/qemu-iotests/041 | 44 ++ >>>   tests/qemu-iotests/041.out |  4 ++-- >>>   2 files ch

[PATCH v2 15/16] docs/devel: add "check-tcg" to testing.rst

2019-09-19 Thread Alex Bennée
It was pointed out we haven't documented the check-tcg part of the build system. Attempt to rectify that now. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 62 ++ 1 file changed, 62 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/

[PATCH v2 05/16] podman: fix command invocation

2019-09-19 Thread Alex Bennée
From: John Snow Oops; there's no argv here. Signed-off-by: John Snow Message-Id: <20190913193821.17756-1-js...@redhat.com> Signed-off-by: Alex Bennée --- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py

[PATCH v2 14/16] configure: preserve PKG_CONFIG for subdir builds

2019-09-19 Thread Alex Bennée
The slirp sub-module complains about not being able to find the glib library on cross-compiles because it is using the default pkg-config tool (which isn't installed in our cross-build docker images). Preserve PKG_CONFIG in our host config and pass it down to slirp. Signed-off-by: Alex Bennée ---

[PATCH v2 03/16] tests/docker: remove python2.7 from docker9-mxe

2019-09-19 Thread Alex Bennée
From: John Snow When it was based on docker8 which uses python-minimal, it needed this. It no longer does. Goodbye, python2.7. Signed-off-by: John Snow Message-Id: <20190918222546.11696-1-js...@redhat.com> Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian9-mxe.docker | 3 +-- 1

[PATCH v2 12/16] tests/docker: Add fedora-win10sdk-cross image

2019-09-19 Thread Alex Bennée
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190919105932.19412-2-phi...@redhat.com> Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 + .../dockerfiles/fedora-win10sdk-cross.docker | 21 +++ 2 files changed

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Alex Williamson
On Wed, 18 Sep 2019 07:21:05 + "Tian, Kevin" wrote: > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Wednesday, September 18, 2019 2:04 PM > > > > On 2019/9/18 上午9:31, Tian, Kevin wrote: > > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > > >> Sent: Tuesday, Septe

[PATCH v2 11/16] tests/tcg: add simple record/replay smoke test for aarch64

2019-09-19 Thread Alex Bennée
This adds two new tests that re-use the memory test to check basic record replay functionality is still working. We have to define our own runners rather than using the default pattern as we want to change the test name but re-use the memory binary. We declare the test binaries as PHONY as they do

[PATCH v2 02/16] tests/docker: fix DOCKER_PARTIAL_IMAGES

2019-09-19 Thread Alex Bennée
Finger trouble in a previous clean-up inadvertently set DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES. Also fix the typo to debian-9-mxe. Fixes: 44d5a8bf5d2 Signed-off-by: John Snow [AJB: merged fix from Message-Id: <20190917185537.25417-1-js...@redhat.com>] Signed-off-by: Alex Bennée R

Re: [PATCH] Makefile: Fix in-tree builds when Sphinx is available

2019-09-19 Thread Peter Maydell
On Thu, 19 Sep 2019 at 18:12, Alex Bennée wrote: > > > Peter Maydell writes: > > > In commit 27a296fce9821e we switched the qemu-ga manpage over to > > being built from Sphinx. The makefile rules for this were correct > > for an out-of-tree build, but break for in-tree builds if Sphinx is > > pr

Re: [PATCH v2 0/2] iotests: Require Python 3.6 or later

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 6:29 PM, Kevin Wolf wrote: > v2: > > - Provide the right exit code from Python instead of having a > potentially confusing negation in the shell script > > - Raised the minimal version to 3.6. If we're going to use a different > version than QEMU as a whole anyway, we can use a ver

[PATCH v2 16/16] Makefile: fix-up qemu-ga.8 paths to take in-src builds into account

2019-09-19 Thread Alex Bennée
We tweak MANUAL_BUILDIR for in-src builds because sphinx won't build documents inside a source tree. This was causing the document build to fail on things like shippable which were using in-tree builds. Suggested-by: Peter Maydell Signed-off-by: Alex Bennée --- Makefile | 26 +--

Re: Will the qemu-devel prefix in the mails come back?

2019-09-19 Thread Peter Maydell
On Thu, 19 Sep 2019 at 18:06, Martin Schrodt wrote: > > Does anybody know? > > My mail filter would appreciate :) Sorry, no. See the announcement sent out last week: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg01645.html We recommend you filter using the List-Id: header instead. th

Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches

2019-09-19 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190919-pull-request > > for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0: > > vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200) > > ---

[Bug 1833661] Re: Linux kernel oops on Malta board while accessing pflash

2019-09-19 Thread Cleber Rosa
When running tests/acceptance/linux_ssh_mips_malta.py:LinuxSSH.test_mips_malta64el_kernel3_2_0, I'm getting in roughly 8% of executions: 2019-09-18 22:37:43,665 linux_ssh_mips_m L0065 DEBUG| Intel/Sharp Extended Query Table at 0x0031 2019-09-18 22:37:43,668 linux_ssh_mips_m L0065 DEBUG| Using buf

<    1   2   3   4   5   >