Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2019-09-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190920113329.16787-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190920113329.16787-1-phi...@redhat.com Subject: [PATCH v2 0/3] testing: Build WHPX enabled binaries Typ

[PATCH v2 2/2] riscv: sifive_u: Add ethernet0 to the aliases node

2019-09-20 Thread Bin Meng
U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node. This is to keep in sync with Linux kernel commit below: https://patchwork.kernel.org/patch/11133033/ Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v2: None hw/riscv/sifiv

[PATCH v2 1/2] riscv: hw: Drop "clock-frequency" property of cpu nodes

2019-09-20 Thread Bin Meng
The "clock-frequency" property of cpu nodes isn't required. Drop it. This is to keep in sync with Linux kernel commit below: https://patchwork.kernel.org/patch/11133031/ Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v2: - drop the one in spike and virt machines too hw

Re: [PATCH 03/21] hw: aspeed_scu: Add AST2600 support

2019-09-20 Thread Joel Stanley
On Fri, 20 Sep 2019 at 15:15, Cédric Le Goater wrote: > > On 20/09/2019 06:10, Andrew Jeffery wrote: > > > > > > On Thu, 19 Sep 2019, at 15:19, Cédric Le Goater wrote: > >> From: Joel Stanley > >> > >> The SCU controller on the AST2600 SoC has extra registers. Increase > >> the number of regs of

[PATCH 6/7] target/alpha: Mask IOV exception with INV for user-only

2019-09-20 Thread Richard Henderson
The kernel masks the integer overflow exception with the software invalid exception mask. Include IOV in the set of exception bits masked by fpcr_exc_enable. Fixes the new float_convs test. Signed-off-by: Richard Henderson --- target/alpha/helper.c | 7 +++ 1 file changed, 7 insertions(+)

[PATCH 4/7] target/alpha: Handle SWCR_MAP_DMZ earlier

2019-09-20 Thread Richard Henderson
Since we're converting the swcr to fpcr format for exceptions, it's trivial to add FPCR_DNZ to the set of fpcr bits overriden. No functional change. Signed-off-by: Richard Henderson --- target/alpha/helper.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/alpha/hel

[PATCH 2/7] target/alpha: Fix SWCR_MAP_UMZ

2019-09-20 Thread Richard Henderson
We were setting the wrong bit. The fp_status.flush_to_zero setting is overwritten by either the constant 1 or the value of fpcr_flush_to_zero depending on bits within an fp insn. Signed-off-by: Richard Henderson --- target/alpha/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 7/7] target/alpha: Tidy helper_fp_exc_raise_s

2019-09-20 Thread Richard Henderson
Remove a redundant masking of ignore. Once that's gone it is obvious that the system-mode inner test is redundant with the outer test. Move the fpcr_exc_enable masking up and tidy. No functional change. Signed-off-by: Richard Henderson --- target/alpha/fpu_helper.c | 15 --- 1 fil

[PATCH 5/7] target/alpha: Write to fpcr_flush_to_zero once

2019-09-20 Thread Richard Henderson
Tidy the computation of the value; no functional change. Signed-off-by: Richard Henderson --- target/alpha/helper.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 2f959c65ef..1b3479738b 100644 --- a/target/alpha/he

[PATCH 3/7] target/alpha: Fix SWCR_TRAP_ENABLE_MASK

2019-09-20 Thread Richard Henderson
The CONFIG_USER_ONLY adjustment blindly mashed the swcr exception enable bits into the fpcr exception disable bits. However, fpcr_exc_enable has already converted the exception disable bits into the exception status bits in order to make it easier to mask status bits at runtime. Instead, merge th

[PATCH 0/7] target/alpha: Fix linux-user exception for CVTTQ

2019-09-20 Thread Richard Henderson
Alex's new float_convs test dies with SIGFPE for alpha-linux-user. This is fixed in patch 6, where I mask the exception similar to how the kernel would, when passed through the software completion handler. Patches 2 & 3 fix bugs that I noticed in the process; the rest are simple cleanup, trying t

[PATCH 1/7] target/alpha: Use array for FPCR_DYN conversion

2019-09-20 Thread Richard Henderson
This is a bit more straight-forward than using a switch statement. No functional change. Signed-off-by: Richard Henderson --- target/alpha/helper.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 19

Re: [PATCH v12 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-09-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190920074349.2616-1-tao3...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v12 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-09-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190920074349.2616-1-tao3...@intel.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Migration failure when running nested VMs

2019-09-20 Thread Jintack Lim
Hi, I'm seeing VM live migration failure when a VM is running a nested VM. I'm using latest Linux kernel (v5.3) and QEMU (v4.1.0). I also tried v5.2, but the result was the same. Kernel versions in L1 and L2 VM are v4.18, but I don't think that matters. The symptom is that L2 VM kernel crashes in

Re: [PATCH 0/7] exec: Improve code for TARGET_PAGE_BITS_VARY

2019-09-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190919232952.6382-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190919232952.6382-1-richard.hender...@linaro.org Subject: [PATCH 0/7] exec: Improve code for

Re: [PATCH v1 0/2] RISC-V: Convert to do_transaction_failed hook

2019-09-20 Thread Palmer Dabbelt
On Tue, 17 Sep 2019 16:22:56 PDT (-0700), Alistair Francis wrote: The do_unassigned_access hook has been deprecated and RISC-V is the last user of it. Let's instead update the RISC-V implementation to use do_transaction_failed instead. After this series I used the 'git grep' regexes in docs/deve

Re: [RFC 2 PATCH 00/16] APIC ID fixes for AMD EPYC CPU models

2019-09-20 Thread Moger, Babu
Eduardo and all, Waiting for the feedback on this to move forward. Appreciate your time. Thanks Babu On 9/6/19 2:11 PM, Moger, Babu wrote: > These series fixes the problems encoding APIC ID for AMD EPYC cpu models. > https://bugzilla.redhat.com/show_bug.cgi?id=1728166 > > This is the second pass

Re: [PATCH v1 0/6] RISC-V: Add more machine memory

2019-09-20 Thread Palmer Dabbelt
On Thu, 19 Sep 2019 15:24:51 PDT (-0700), Alistair Francis wrote: This series aims to improve the use of QEMU for developing boot code. It does a few things: - sifive_u machine: - Adds a chunk of memory in the Flash area. This allows boot loaders to use this memory. I can't find details o

Re: [Qemu-devel] [PULL 04/32] target/riscv: Implement riscv_cpu_unassigned_access

2019-09-20 Thread Palmer Dabbelt
On Tue, 17 Sep 2019 09:37:47 PDT (-0700), alistai...@gmail.com wrote: On Tue, Sep 17, 2019 at 6:56 AM Peter Maydell wrote: On Fri, 16 Aug 2019 at 09:57, Peter Maydell wrote: > > On Thu, 15 Aug 2019 at 23:17, Palmer Dabbelt wrote: > > You're more than welcome to take them over. I've got some

[PATCH v2 1/5] docker: move tests from python2 to python3

2019-09-20 Thread John Snow
As part of the push to drop python2 support, replace any explicit python2 dependencies with python3 versions. For centos, python2 still exists as an implicit dependency, but by adding python3 we will be able to build even if the configure script begins to require python 3.5+. Tested with centos7,

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-20 Thread Alistair Francis
On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis > wrote: > > > > Add the CFI01 PFlash to the RISC-V virt board. This is the same PFlash > > from the ARM Virt board and the implementation is based on the ARM Virt > > board. This allows users to

[PATCH v2 4/5] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread John Snow
These are listed as "partial" images, but have no user. Remove them. Signed-off-by: John Snow Message-id: 20190920001413.22567-4-js...@redhat.com --- tests/docker/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker

Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the export's AioContext

2019-09-20 Thread Eric Blake
On 9/20/19 2:11 PM, Eric Blake wrote: > On 9/20/19 1:49 PM, John Snow wrote: >> > To fix this, as soon we have the export corresponding to the client, we call qio_channel_attach_aio_context() to attach the QIOChannel context to the export's AioContext. This matches with the logic at

[PATCH v2 3/5] docker: remove debian8-mxe definitions

2019-09-20 Thread John Snow
We don't have a debian8-mxe dockerfile anymore. Signed-off-by: John Snow Message-id: 20190920001413.22567-3-js...@redhat.com --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 0

[PATCH v2 2/5] docker: remove 'deprecated' image definitions

2019-09-20 Thread John Snow
There isn't a debian.dockerfile anymore, so perform some ghost-busting. Signed-off-by: John Snow Message-id: 20190920001413.22567-2-js...@redhat.com --- tests/docker/Makefile.include | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/

[PATCH v2 0/5] docker: misc cleanups

2019-09-20 Thread John Snow
This should include anything I've sent so far (not including the RFC for more exploratory changes) that hasn't already been included in a roundup by Alex Bennée. Mostly, it removes unused docker files and replaces python2 with python3 in all of the container environments. V2: - Rolled in python2

[PATCH v2 5/5] docker: removed unused debian8 partial image

2019-09-20 Thread John Snow
debian8 partial base is also not consumed by any image, so remove it. Signed-off-by: John Snow --- tests/docker/Makefile.include | 3 +-- tests/docker/dockerfiles/debian8.docker | 33 - 2 files changed, 1 insertion(+), 35 deletions(-) delete mode 100644 tests/

Re: [PATCH v1 4/6] riscv/sifive_u: Add the start-in-flash property

2019-09-20 Thread Alistair Francis
On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > On Fri, Sep 20, 2019 at 6:32 AM Alistair Francis > wrote: > > > > Add a property that when set to true QEMU will jump from the ROM code to > > the start of flash memory instead of DRAM which is the default > > behaviour. > > > > Signed-off-by:

Re: [PATCH v2 10/16] tests/tcg: add generic version of float_convs

2019-09-20 Thread Richard Henderson
On 9/20/19 3:15 AM, Alex Bennée wrote: > I can't figure out what is meant to be going on with CONVERT_BITS. It > seems to be implying there is a direct relationship between status flags > and the exception disable bits. But that is confusing because integer > overflow (IOV) and float overflow (OVF)

[PATCH 2/1] tests: Use iothreads during iotest 223

2019-09-20 Thread Eric Blake
Doing so catches the bugs we just fixed with NBD not properly using correct contexts. Signed-off-by: Eric Blake --- This is https://bugzilla.redhat.com/show_bug.cgi?id=1741094, distinct from Sergio's patch also related to aiocontext in NBD, which is https://bugzilla.redhat.com/show_bug.cgi?id=17

Re: [PATCH] hw/arm/boot.c: Set NSACR.{CP11,CP10} for NS kernel boots

2019-09-20 Thread Richard Henderson
On 9/20/19 10:40 AM, Peter Maydell wrote: > If we're booting a Linux kernel directly into Non-Secure > state on a CPU which has Secure state, then make sure we > set the NSACR CP11 and CP10 bits, so that Non-Secure is allowed > to access the FPU. Otherwise an AArch32 kernel will UNDEF as > soon as

Re: [PATCH RFC] docker: automatic dependencies for dockerfiles

2019-09-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190920001823.23279-1-js...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread John Snow
On 9/20/19 5:19 PM, Alex Bennée wrote: > > John Snow writes: > >> On 9/20/19 12:20 PM, Alex Bennée wrote: >>> >>> John Snow writes: >>> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: > On 9/20/19 2:14 AM, John Snow wrote: >> These are listed as "partial" images, but have no u

Re: [PATCH] docker: move tests from python2 to python3

2019-09-20 Thread Eduardo Habkost
On Fri, Sep 20, 2019 at 04:00:49PM -0400, John Snow wrote: > As part of the push to drop python2 support, replace any explicit python2 > dependencies with python3 versions. > > For centos, python2 still exists as an implicit dependency, but by adding > python3 we will be able to build even if the

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread Alex Bennée
John Snow writes: > On 9/20/19 12:20 PM, Alex Bennée wrote: >> >> John Snow writes: >> >>> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: On 9/20/19 2:14 AM, John Snow wrote: > These are listed as "partial" images, but have no user. > Remove them. Well, I have WiP use

Re: [Qemu-devel] [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

2019-09-20 Thread John Snow
On 9/12/19 6:30 PM, Maxim Levitsky wrote: > This patch series is continuation of my work to add encryption > key managment to luks/qcow2 with luks. > > This is second version of this patch set. > The changes are mostly addressing the review feedback, > plus I tested (and fixed sadly) the somewh

Re: [Qemu-block] [PATCH] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

2019-09-20 Thread John Snow
On 9/18/19 7:57 AM, Paul Durrant wrote: > When a frontend gracefully disconnects from an offline backend, it will > set its own state to XenbusStateClosed. The code in xen-block.c correctly > deals with this and sets the backend into XenbusStateClosed. Unfortunately > it is possible for toolstac

Re: [PATCH] Acceptance tests: use avocado.utils.ssh for SSH interaction

2019-09-20 Thread Cleber Rosa
On Fri, Sep 20, 2019 at 05:33:35PM -0300, Eduardo Habkost wrote: > On Thu, Sep 19, 2019 at 06:59:05PM -0400, Cleber Rosa wrote: > > This replaces paramiko with avocado.utils.ssh module, which is based > > on a (open)ssh binary, supposedly more ubiquitous. > > > > Signed-off-by: Cleber Rosa > > R

Re: [PATCH] Acceptance tests: use avocado.utils.ssh for SSH interaction

2019-09-20 Thread Eduardo Habkost
On Thu, Sep 19, 2019 at 06:59:05PM -0400, Cleber Rosa wrote: > This replaces paramiko with avocado.utils.ssh module, which is based > on a (open)ssh binary, supposedly more ubiquitous. > > Signed-off-by: Cleber Rosa Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH] Acceptance tests: use avocado.utils.ssh for SSH interaction

2019-09-20 Thread Cleber Rosa
On Fri, Sep 20, 2019 at 04:16:54PM -0300, Eduardo Habkost wrote: > On Thu, Sep 19, 2019 at 06:59:05PM -0400, Cleber Rosa wrote: > > This replaces paramiko with avocado.utils.ssh module, which is based > > on a (open)ssh binary, supposedly more ubiquitous. > > > > Signed-off-by: Cleber Rosa > > I

[PATCH] docker: move tests from python2 to python3

2019-09-20 Thread John Snow
As part of the push to drop python2 support, replace any explicit python2 dependencies with python3 versions. For centos, python2 still exists as an implicit dependency, but by adding python3 we will be able to build even if the configure script begins to require python 3.5+. Tested with centos7,

[Bug 1811533] Re: Unstable Win10 guest with qemu 3.1 + huge pages + hv_stimer

2019-09-20 Thread Damir
Also attaching my libvirt log with a few errors at the end of the log. Thank you for looking into this! ** Attachment added: "Libvirt_log_command_line" https://bugs.launchpad.net/qemu/+bug/1811533/+attachment/5290071/+files/libvirt_log.txt -- You received this bug notification because you

Re: [Qemu-devel] [PATCH 2/2] roms/Makefile.edk2: don't pull in submodules when building from tarball

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/13/19 1:12 AM, Michael Roth wrote: > Currently the `make efi` target pulls submodules nested under the > roms/edk2 submodule as dependencies. However, when we attempt to build > from a tarball this fails since we are no longer in a git tree. > > A preceding patch will pre-populate these submo

Re: [RFC 4/4] ahci media error reporting

2019-09-20 Thread John Snow
On 9/20/19 3:25 PM, Tony Asleson wrote: > On 9/20/19 11:18 AM, John Snow wrote: >> For sure -- I handle the normative cases, but I don't test what happens >> if you issue an unsupported NCQ command. (I don't know what real >> hardware does right now, either. I'm sure I could read the spec and fi

Re: [PATCH v2 06/16] target/ppc: fix signal delivery for ppc64abi32

2019-09-20 Thread Laurent Vivier
Le 19/09/2019 à 19:10, Alex Bennée a écrit : We were incorrectly using the 64-bit AIX ABI instead of the 32-bit SYSV ABI for setting NIP for the signal handler. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - change to wording --- linux-user/ppc/signal.c | 4 +++- 1 f

Re: [RFC 4/4] ahci media error reporting

2019-09-20 Thread Tony Asleson
On 9/20/19 11:18 AM, John Snow wrote: > For sure -- I handle the normative cases, but I don't test what happens > if you issue an unsupported NCQ command. (I don't know what real > hardware does right now, either. I'm sure I could read the spec and find > out, but don't have a testing setup that le

Re: [PATCH] Acceptance tests: use avocado.utils.ssh for SSH interaction

2019-09-20 Thread Eduardo Habkost
On Thu, Sep 19, 2019 at 06:59:05PM -0400, Cleber Rosa wrote: > This replaces paramiko with avocado.utils.ssh module, which is based > on a (open)ssh binary, supposedly more ubiquitous. > > Signed-off-by: Cleber Rosa I just noticed that I have some patches on python-next that never went to a pull

[PULL] Request pull for IPMI changes

2019-09-20 Thread Corey Minyard
The following changes since commit a77d20bafcd4cb7684168a9b4c6dc2a321aaeb50: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190919-pull-request' into staging (2019-09-19 17:16:07 +0100) are available in the Git repository at: https://github.com/cminyard/qemu.git tags/ipmi-for-releas

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 12:08 PM, Eric Blake wrote: > I am worried, however, that making data transactions have to go through > QMP to get an answer on how to handle a specific guest request will slow > things down; QMP is not built to be an efficient dataplane interface. IMHO we only need to make the code pat

[Bug 1811533] Re: Unstable Win10 guest with qemu 3.1 + huge pages + hv_stimer

2019-09-20 Thread Žilvinas Žaltiena
As asked by dgilbert-h, I am attaching my qemu command line. It is ripped from libvirt log. ** Attachment added: "Bug reproducing Qemu command line from libvirt log." https://bugs.launchpad.net/qemu/+bug/1811533/+attachment/5290067/+files/qemu_cmdln.txt -- You received this bug notification

Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the export's AioContext

2019-09-20 Thread Eric Blake
On 9/20/19 1:49 PM, John Snow wrote: > >>> To fix this, as soon we have the export corresponding to the client, >>> we call qio_channel_attach_aio_context() to attach the QIOChannel >>> context to the export's AioContext. This matches with the logic at >>> blk_aio_attached(). >>> >> >> I assume

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 1:11 PM, Kevin Wolf wrote: > Emitting a QMP event when blkdebug injects an error makes sense to me. > > I wouldn't use it for this case, though, because this would become racy. > It could happen that the guest writes to the image, which sends a QMP > event, and then reads before the ext

Re: [PATCH 0/3] migration/postcopy: unsentmap is not necessary

2019-09-20 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Hi, Dave and Juan > > Would you mind taking a look at this one? Yes, I'll have a look, I'm just fighting through a bunch of other stuff. Dave > On Mon, Aug 19, 2019 at 02:18:40PM +0800, Wei Yang wrote: > >Three patches to cleanup postcopy: > >

Re: [PATCH 1/2] riscv: sifive_u: Drop "clock-frequency" property of cpu nodes

2019-09-20 Thread Alistair Francis
On Fri, Sep 20, 2019 at 2:26 AM Bin Meng wrote: > > The "clock-frequency" property of cpu nodes isn't required. Drop it. > > This is to keep in sync with Linux kernel commit below: > https://patchwork.kernel.org/patch/11133031/ > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair

Re: [PATCH 2/2] riscv: sifive_u: Add ethernet0 to the aliases node

2019-09-20 Thread Alistair Francis
On Fri, Sep 20, 2019 at 2:26 AM Bin Meng wrote: > > U-Boot expects this alias to be in place in order to fix up the mac > address of the ethernet node. > > This is to keep in sync with Linux kernel commit below: > https://patchwork.kernel.org/patch/11133033/ > > Signed-off-by: Bin Meng Reviewed-

Re: [PATCH] Remove unassigned_access CPU hook

2019-09-20 Thread Alistair Francis
On Fri, Sep 20, 2019 at 5:52 AM Peter Maydell wrote: > > All targets have now migrated away from the old unassigned_access > hook to the new do_transaction_failed hook. This means we can remove > the core-code infrastructure for that hook and the code that calls it. > > Signed-off-by: Peter Maydel

Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the export's AioContext

2019-09-20 Thread John Snow
On 9/20/19 2:12 PM, John Snow wrote: > > > On 9/12/19 7:00 AM, Sergio Lopez wrote: >> On creation, the export's AioContext is set to the same one as the >> BlockBackend, while the AioContext in the client QIOChannel is left >> untouched. >> >> As a result, when using data-plane, nbd_client_rec

Re: [PATCH] riscv: Skip checking CSR privilege level in debugger mode

2019-09-20 Thread Alistair Francis
On Fri, Sep 20, 2019 at 7:48 AM Bin Meng wrote: > > If we are in debugger mode, skip the CSR privilege level checking > so that we can read/write all CSRs. Otherwise we get: > > (gdb) p/x $mtvec > Could not fetch register "mtvec"; remote failure reply 'E14' > > when the hart is currently in S-mode

Re: [PATCH v2] target/i386: clean up comments over 80 chars per line

2019-09-20 Thread Eduardo Habkost
On Fri, Sep 20, 2019 at 01:31:36PM +0800, Tao Xu wrote: > Drop the duplicate definition of CPUID_7_0_ECX_VBMI. And add some > comments, clean up comments over 80 chars per line. > > There is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, > remove the extra enter and spaces. > > Signed-

Re: [PATCH v2] target/i386: clean up comments over 80 chars per line

2019-09-20 Thread Eduardo Habkost
On Fri, Sep 20, 2019 at 11:14:56AM +0200, Stefano Garzarella wrote: > On Fri, Sep 20, 2019 at 01:31:36PM +0800, Tao Xu wrote: > > Drop the duplicate definition of CPUID_7_0_ECX_VBMI. And add some > > comments, clean up comments over 80 chars per line. > > > > There is an extra line in comment of C

Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the export's AioContext

2019-09-20 Thread John Snow
On 9/12/19 7:00 AM, Sergio Lopez wrote: > On creation, the export's AioContext is set to the same one as the > BlockBackend, while the AioContext in the client QIOChannel is left > untouched. > > As a result, when using data-plane, nbd_client_receive_next_request() > schedules coroutines in the

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Kevin Wolf
Am 20.09.2019 um 18:41 hat Tony Asleson geschrieben: > On 9/20/19 3:36 AM, Kevin Wolf wrote: > > I/O error inserted by blkdebug can be one-off or permanent, but since it > > also supports using a small state machine, I think you should already be > > able to configure your errors that are corrected

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Nathan Chancellor
I pulled down the fix, built locally, and can confirm that this resolves the issue. Thank you for the quick patch! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1844597 Title: fc1120a7f5f2d4b601003

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Peter Maydell
Should be fixed by: https://patchew.org/QEMU/20190920174039.3916-1-peter.mayd...@linaro.org/ (which allows me to boot the kernel you attached at least as far as "didn't find a root filesystem"). ** Changed in: qemu Status: New => In Progress -- You received this bug notification because

Re: [Qemu-block] [Ping] [PATCH v6 0/3] qcow2: add zstd cluster compression

2019-09-20 Thread John Snow
On 9/18/19 12:29 PM, Denis Plotnikov wrote: > On 12.09.2019 11:46, Denis Plotnikov wrote: >> ping! >> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00943.html I was under the impression you were addressing feedback from Vladimir. --js

Re: [PULL 0/2] Python (acceptance tests) queue, 2019-09-19

2019-09-20 Thread Peter Maydell
On Thu, 19 Sep 2019 at 17:27, Cleber Rosa wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are available in the Git repository at: > > git://github.com/clebergnu/q

Re: [PATCH 00/15] ipmi: Bug fixes, add new interfaces

2019-09-20 Thread Peter Maydell
On Fri, 20 Sep 2019 at 18:36, Corey Minyard wrote: > > On Fri, Sep 20, 2019 at 01:57:48PM +0100, Peter Maydell wrote: > > Hi -- is this intended to be a pull request to be applied to > > master? It's in the form of a pullreq but the subject header > > says "PATCH" and you seem to be asking for mor

Re: [PATCH] .travis.yml: Test the release tarball

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/20/19 7:42 PM, Philippe Mathieu-Daudé wrote: > Add a job to generate the release tarball and build/install few > QEMU targets from it. > > Ideally we should build the 'efi' target from the 'roms' directory, > but it is too time consuming. > > This job is only triggered when a tag starting wi

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Peter Maydell
Thanks. I've diagnosed the problem -- when we boot a kernel directly into non-secure state on an AArch32 CPU which implements EL3, we need to set the NSACR.{CP11,CP10} bits so that Non-Secure is allowed to use the FPU, but we weren't doing that. The omission didn't matter until commit fc1120a7f5 be

[PATCH] .travis.yml: Test the release tarball

2019-09-20 Thread Philippe Mathieu-Daudé
Add a job to generate the release tarball and build/install few QEMU targets from it. Ideally we should build the 'efi' target from the 'roms' directory, but it is too time consuming. This job is only triggered when a tag starting with 'v' is pushed, which is the case with release candidate tags.

[PATCH] hw/arm/boot.c: Set NSACR.{CP11,CP10} for NS kernel boots

2019-09-20 Thread Peter Maydell
If we're booting a Linux kernel directly into Non-Secure state on a CPU which has Secure state, then make sure we set the NSACR CP11 and CP10 bits, so that Non-Secure is allowed to access the FPU. Otherwise an AArch32 kernel will UNDEF as soon as it tries to use the FPU. It used to not matter that

Re: [PATCH 00/15] ipmi: Bug fixes, add new interfaces

2019-09-20 Thread Corey Minyard
On Fri, Sep 20, 2019 at 01:57:48PM +0100, Peter Maydell wrote: > On Thu, 19 Sep 2019 at 22:39, wrote: > > > > I haven't gotten a lot of commentary on this, but I assume that means > > that everything is ok. It's been posted a few times and the last time > > I received no issues, just a couple of

Re: [PATCH] roms: Add a 'make help' target alias

2019-09-20 Thread John Snow
On 9/20/19 1:11 PM, Philippe Mathieu-Daudé wrote: > Various C projects provide a 'make help' target. Our root directory > does so. The roms/ directory lacks a such rule, but already displays > a help output when the default target is called. > Add a 'help' target aliased to the default one, to a

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread John Snow
On 9/20/19 12:28 PM, Philippe Mathieu-Daudé wrote: > On 9/20/19 6:23 PM, Philippe Mathieu-Daudé wrote: >> On 9/20/19 6:20 PM, Alex Bennée wrote: >>> John Snow writes: On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: > On 9/20/19 2:14 AM, John Snow wrote: >> These are listed as "pa

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: > blkdebug is purely at the QEMU block layer level. It is not aware of > storage controller-specific error information or features. If you want > to inject NVMe- or SCSI-specific errors that make no sense in QEMU's > block layer, then trying to do it in

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread John Snow
On 9/20/19 12:20 PM, Alex Bennée wrote: > > John Snow writes: > >> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: >>> On 9/20/19 2:14 AM, John Snow wrote: These are listed as "partial" images, but have no user. Remove them. >>> >>> Well, I have WiP users from them. I could restor

Re: [RFC 4/4] ahci media error reporting

2019-09-20 Thread John Snow
On 9/19/19 5:49 PM, Tony Asleson wrote: > On 9/19/19 3:43 PM, John Snow wrote: >> >> >> On 9/19/19 3:48 PM, Tony Asleson wrote: >>> Initial attempt at returning a media error for ahci. This is certainly >>> wrong and needs serious improvement. >>> >> >> Hi; I have the unfortunate distinction of

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Nathan Chancellor
** Attachment added: "aspeed-bmc-opp-romulus.dtb" https://bugs.launchpad.net/qemu/+bug/1844597/+attachment/5290033/+files/aspeed-bmc-opp-romulus.dtb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[Bug 1844597] Re: fc1120a7f5f2d4b601003205c598077d3eb11ad2 causes a kernel panic in vfp_init on a clang built kernel

2019-09-20 Thread Nathan Chancellor
Ugh, sorry, I forget that I can actually upload files to these platforms :( Done, let me know if you need anything else! ** Attachment added: "zImage" https://bugs.launchpad.net/qemu/+bug/1844597/+attachment/5290032/+files/zImage -- You received this bug notification because you are a membe

Re: [PATCH] roms: Add a 'make help' target alias

2019-09-20 Thread Peter Maydell
On Fri, 20 Sep 2019 at 18:12, Philippe Mathieu-Daudé wrote: > > Various C projects provide a 'make help' target. Our root directory > does so. The roms/ directory lacks a such rule, but already displays > a help output when the default target is called. > Add a 'help' target aliased to the default

[PATCH] roms: Add a 'make help' target alias

2019-09-20 Thread Philippe Mathieu-Daudé
Various C projects provide a 'make help' target. Our root directory does so. The roms/ directory lacks a such rule, but already displays a help output when the default target is called. Add a 'help' target aliased to the default one, to avoid: $ make -C roms help make: *** No rule to make targ

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Eric Blake
On 9/20/19 11:41 AM, Tony Asleson wrote: > On 9/20/19 3:36 AM, Kevin Wolf wrote: >> I/O error inserted by blkdebug can be one-off or permanent, but since it >> also supports using a small state machine, I think you should already be >> able to configure your errors that are corrected by a rewrite,

Invalid blob size on NVDIMM hot-add (was: RE: [RFC PATCH 0/4] ARM virt: ACPI memory hotplug support)

2019-09-20 Thread Shameerali Kolothum Thodi
Hi Laszlo/Igor, I spend some time to debug this further as I was rebasing the nvdimm hot-add support patches on top of the ongoing pc-dimm hot add ones. Just to refresh the memory: https://patchwork.kernel.org/cover/10783589/ " It is observed that hot adding nvdimm will results in guest reboot

RE: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2019-09-20 Thread Justin Terry (VM)
Hey Phil, I have contacted our legal department for guidance on this specific use case and will update you when I hear back. Thank you for your patience. Justin Terry > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Friday, September 20, 2019 8:18 AM > To: qemu-devel@nongnu.

Re: [RFC 0/4] POC: Generating realistic block errors

2019-09-20 Thread Tony Asleson
On 9/20/19 3:36 AM, Kevin Wolf wrote: > I/O error inserted by blkdebug can be one-off or permanent, but since it > also supports using a small state machine, I think you should already be > able to configure your errors that are corrected by a rewrite, too, even > if there is no explicit support fo

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/20/19 6:23 PM, Philippe Mathieu-Daudé wrote: > On 9/20/19 6:20 PM, Alex Bennée wrote: >> John Snow writes: >>> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: On 9/20/19 2:14 AM, John Snow wrote: > These are listed as "partial" images, but have no user. > Remove them.

[PULL 2/4] iotests: Test internal snapshots with -blockdev

2019-09-20 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Peter Krempa Tested-by: Peter Krempa --- tests/qemu-iotests/267 | 168 tests/qemu-iotests/267.out | 182 +++ tests/qemu-iotests/common.filter | 5 +- tests/qemu-iotests/group

[PULL 4/4] iotests: Remove Python 2 compatibility code

2019-09-20 Thread Kevin Wolf
Some scripts check the Python version number and have two code paths to accomodate both Python 2 and 3. Remove the code specific to Python 2 and assert the minimum version of 3.6 instead (check skips Python tests in this case, so the assertion would only ever trigger if a Python script is executed

Re: [RFC 4/4] ahci media error reporting

2019-09-20 Thread John Snow
On 9/20/19 4:43 AM, Kevin Wolf wrote: > Am 19.09.2019 um 22:43 hat John Snow geschrieben: >> I'd have to check -- because I can't say the AHCI emulator was designed >> so much as congealed -- but you might need calls to ncq_finish. >> >> usually, ncq_cb handles the return from any NCQ command an

Re: [Qemu-devel] [PULL 0/8] Trivial branch patches

2019-09-20 Thread Peter Maydell
On Thu, 19 Sep 2019 at 15:02, Laurent Vivier wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are available in the Git repository at: > > git://github.com/vivier/q

Re: [PATCH v13 00/15] backup-top filter driver for backup

2019-09-20 Thread John Snow
On 9/20/19 12:01 PM, Vladimir Sementsov-Ogievskiy wrote: > 20.09.2019 18:55, Max Reitz wrote: >> On 20.09.19 16:20, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> These series introduce backup-top driver. It's a filter-node, which >>> do copy-before-write operation. Mirror uses filter-n

[PULL 1/4] block/snapshot: Restrict set of snapshot nodes

2019-09-20 Thread Kevin Wolf
Nodes involved in internal snapshots were those that were returned by bdrv_next(), inserted and not read-only. bdrv_next() in turn returns all nodes that are either the root node of a BlockBackend or monitor-owned nodes. With the typical -drive use, this worked well enough. However, in the typical

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread John Snow
On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: > On 9/20/19 2:14 AM, John Snow wrote: >> These are listed as "partial" images, but have no user. >> Remove them. > > Well, I have WiP users from them. I could restore this content when they > are ready... Ports is the base of deprecated Debian

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/20/19 6:20 PM, Alex Bennée wrote: > John Snow writes: >> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: >>> On 9/20/19 2:14 AM, John Snow wrote: These are listed as "partial" images, but have no user. Remove them. >>> >>> Well, I have WiP users from them. I could restore this con

Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

2019-09-20 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 9/20/19 6:20 PM, Alex Bennée wrote: >> John Snow writes: >>> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote: On 9/20/19 2:14 AM, John Snow wrote: > These are listed as "partial" images, but have no user. > Remove them. Well, I have W

Re: [PATCH v2 0/2] edk2 build scripts: eliminate python 2 dependency

2019-09-20 Thread John Snow
On 9/20/19 4:38 AM, Laszlo Ersek wrote: > v1 URL: > 20190918171141.15957-1-lersek@redhat.com">http://mid.mail-archive.com/20190918171141.15957-1-lersek@redhat.com > > Updates are noted on each patch. > > Cc: Eduardo Habkost > Cc: John Snow > Cc: Philippe Mathieu-Daudé > > Thanks > Laszlo >

[PULL 0/4] Block layer patches

2019-09-20 Thread Kevin Wolf
The following changes since commit 521db80318d6c749a6f6c5a65a68397af9e3ef16: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-09-16' into staging (2019-09-16 15:25:55 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[PULL 3/4] iotests: Require Python 3.6 or later

2019-09-20 Thread Kevin Wolf
Running iotests is not required to build QEMU, so we can have stricter version requirements for Python here and can make use of new features and drop compatibility code earlier. This makes qemu-iotests skip all Python tests if a Python version before 3.6 is used for the build. Suggested-by: Eduar

Re: Initialize data memory in user space emulation

2019-09-20 Thread Libo Zhou
Thanks for your insightful input. I will come back to this thread after I tried all the options. Cheers, Libo Zhou -- Original -- From: "Peter Maydell";; Send time: Saturday, Sep 21, 2019 0:08 AM To: "Libo Zhou"; Cc: "qemu-devel"; Subject: Re: Initialize da

  1   2   3   >