[Bug 1824704] Re: -k tr not working after v20171217! turkish keyboard dont working

2019-09-23 Thread Thomas Huth
Can you find out which commit broke the keyboard for you? (By using "git bisect" for example) ** Information type changed from Private Security to Public -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1842916] Re: [18.04 FEAT] Enhanced Hardware Support - Finalize Naming

2019-09-23 Thread Thomas Huth
*** This bug is a duplicate of bug 1842774 *** https://bugs.launchpad.net/bugs/1842774 ** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1842916 Title: [18.04 FEAT]

[Bug 1842774] Re: Enhanced Hardware Support - Finalize Naming

2019-09-23 Thread Thomas Huth
Patch a0e2251132995b9 is a kernel patch, thus this is certainly not something we need to track in the upstream QEMU bugtracker. ** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH 4/4] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes

2019-09-23 Thread Cédric Le Goater
On 24/09/2019 06:59, David Gibson wrote: > TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever > instantiated, and the only one we're ever likely to want. The > existence of different classes is just a hang over from when we > (misguidedly) had separate subtypes for the KVM and

Re: [PATCH 3/4] xics: Rename misleading ics_simple_*() functions

2019-09-23 Thread Cédric Le Goater
On 24/09/2019 06:59, David Gibson wrote: > There are a number of ics_simple_*() functions that aren't actually > specific to TYPE_XICS_SIMPLE at all, and are equally valid on > TYPE_XICS_BASE. Rename them to ics_*() accordingly. > > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater

Re: [PATCH 2/4] xics: Merge reset and realize hooks

2019-09-23 Thread Cédric Le Goater
On 24/09/2019 06:59, David Gibson wrote: > Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset and > realize methods, using the standard technique for having the subtype > call the supertype's methods before doing its own thing. > > But TYPE_XICS_SIMPLE is the only subtype of

Re: [PATCH 1/4] xics: Eliminate 'reject', 'resend' and 'eoi' class hooks

2019-09-23 Thread Cédric Le Goater
On 24/09/2019 06:59, David Gibson wrote: > Currently ics_reject(), ics_resend() and ics_eoi() indirect through > class methods. But there's only one implementation of each method, > the one in TYPE_ICS_SIMPLE. TYPE_ICS_BASE has no implementation, but > it's never instantiated, and has no other

Re: [PATCH 0/4] xics: Eliminate unnecessary class

2019-09-23 Thread Cédric Le Goater
On 24/09/2019 06:59, David Gibson wrote: > The XICS interrupt controller device used to have separate subtypes > for the KVM and non-KVM variant of the device. That was a bad idea, > because it leaked information that should be entirely host-side > implementation specific to the kinda-sorta guest

[PATCH 4/4] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes

2019-09-23 Thread David Gibson
TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever instantiated, and the only one we're ever likely to want. The existence of different classes is just a hang over from when we (misguidedly) had separate subtypes for the KVM and non-KVM version of the device. So, collapse the two

[PATCH 2/4] xics: Merge reset and realize hooks

2019-09-23 Thread David Gibson
Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset and realize methods, using the standard technique for having the subtype call the supertype's methods before doing its own thing. But TYPE_XICS_SIMPLE is the only subtype of TYPE_XICS_BASE ever instantiated, so there's no point

Re: [PATCH] target/riscv: Bugfix reserved bits in PTE for RV64

2019-09-23 Thread Alistair Francis
On Mon, Sep 23, 2019 at 10:01 PM wrote: > > From: Guo Ren > > Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we > need to ignore them. They can not be a part of ppn. > > 1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture >4.4 Sv39: Page-Based

[PATCH] target/riscv: Bugfix reserved bits in PTE for RV64

2019-09-23 Thread guoren
From: Guo Ren Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we need to ignore them. They can not be a part of ppn. 1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture 4.4 Sv39: Page-Based 39-bit Virtual-Memory System 4.5 Sv48: Page-Based 48-bit

[PATCH 1/4] xics: Eliminate 'reject', 'resend' and 'eoi' class hooks

2019-09-23 Thread David Gibson
Currently ics_reject(), ics_resend() and ics_eoi() indirect through class methods. But there's only one implementation of each method, the one in TYPE_ICS_SIMPLE. TYPE_ICS_BASE has no implementation, but it's never instantiated, and has no other subtypes. So clean up by eliminating the method

[PATCH 3/4] xics: Rename misleading ics_simple_*() functions

2019-09-23 Thread David Gibson
There are a number of ics_simple_*() functions that aren't actually specific to TYPE_XICS_SIMPLE at all, and are equally valid on TYPE_XICS_BASE. Rename them to ics_*() accordingly. Signed-off-by: David Gibson --- hw/intc/trace-events | 6 +++--- hw/intc/xics.c| 29

[PATCH 0/4] xics: Eliminate unnecessary class

2019-09-23 Thread David Gibson
The XICS interrupt controller device used to have separate subtypes for the KVM and non-KVM variant of the device. That was a bad idea, because it leaked information that should be entirely host-side implementation specific to the kinda-sorta guest visible QOM class names. We eliminated the KVM

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-23 Thread Thomas Huth
On 23/09/2019 20.50, Peter Maydell wrote: > On Mon, 23 Sep 2019 at 19:36, Thomas Huth wrote: >> >> On 23/09/2019 20.27, Peter Maydell wrote: >>> On Mon, 23 Sep 2019 at 18:54, Thomas Huth wrote: Ok, then what would you suggest to solve the problem that this file has always to be linked

Re: [PATCH v2] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-09-23 Thread Tao Xu
Hi Eduardo, How about this version of patch? Last month this patch is reverted from pull request. And I submitted this version. Tao On 9/5/2019 4:32 PM, Xu, Tao3 wrote: Add MachineClass::auto_enable_numa field. When it is true, a NUMA node is expected to be created implicitly. Acked-by:

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-23 Thread Peter Xu
On Mon, Sep 23, 2019 at 06:49:12PM +0200, Paolo Bonzini wrote: > On 23/09/19 18:15, Igor Mammedov wrote: > > Yep, commit message doesn't fit patch, how about following description: > > " > > Currently MemoryRegionSection has 1:1 mapping to KVMSlot. > > However next patch will allow splitting

Re: illegal hardware instruction during MIPS-I ELF linux useremulation

2019-09-23 Thread Libo Zhou
> I would start by using the QEMU gdbstub to connect a > MIPS-aware gdb. Then when the SIGILL arrives you can see > what instruction the guest program was trying to execute. Just tried it and found something interesting. I connected gdb-multiarch to QEMU gdbstub. gdb-multiarch's architecture was

Re: illegal hardware instruction during MIPS-I ELF linux useremulation

2019-09-23 Thread Libo Zhou
> I would start by using the QEMU gdbstub to connect a > MIPS-aware gdb. Then when the SIGILL arrives you can see > what instruction the guest program was trying to execute. Just tried it and found something interesting. I connected gdb-multiarch to QEMU gdbstub. gdb-multiarch's architecture was

Re: illegal hardware instruction during MIPS-I ELF linux useremulation

2019-09-23 Thread Libo Zhou
> I would start by using the QEMU gdbstub to connect a > MIPS-aware gdb. Then when the SIGILL arrives you can see > what instruction the guest program was trying to execute. Just tried it and found something interesting. I connected gdb-multiarch to QEMU gdbstub. gdb-multiarch's architecture was

RE: [PATCH v8 01/13] vfio: KABI for migration interface

2019-09-23 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Friday, September 13, 2019 7:00 AM > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Thursday, September 12, 2019 10:41 PM > > > > On Tue, 3 Sep 2019 06:57:27 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson

RE: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-23 Thread Tian, Kevin
> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Friday, September 20, 2019 9:19 AM > > On 2019/9/20 上午6:54, Tian, Kevin wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> Sent: Thursday, September 19, 2019 7:14 PM > >> > >> On 19/09/19 09:16, Tian, Kevin wrote: > > why

Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23

2019-09-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-cr...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190923134019.8548-1-cr...@redhat.com Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23

Re: [Qemu-devel] [PATCH 4/4] target/arm: Add support for DC CVAP & DC CVADP ins

2019-09-23 Thread Alex Bennée
Beata Michalska writes: > ARMv8.2 introduced support for Data Cache Clean instructions > to PoP (point-of-persistence) - DC CVAP and PoDP (point-of-deep-persistence) > - DV CVADP. Both specify conceptual points in a memory system where all writes > that are to reach them are considered

Re: illegal hardware instruction during MIPS-I ELF linux useremulation

2019-09-23 Thread Libo Zhou
> Can you run QEMU with some debugging options: > qemu-mipsel -d in_asm,exec,cpu,unimp,guest_errors,nochain -D debug.log > -singlestep test > and then put the resulting debug.log somewhere we can get it? > (it'll probably be quite large) The logging only shows this little information. It seems

[PATCH v4 2/2] target/i386: drop the duplicated definition of cpuid AVX512_VBMI marco

2019-09-23 Thread Tao Xu
Drop the duplicated definition of cpuid AVX512_VBMI and marco and rename it as CPUID_7_0_ECX_AVX512_VBMI. And rename CPUID_7_0_ECX_VBMI2 as CPUID_7_0_ECX_AVX512_VBMI2. Signed-off-by: Tao Xu --- target/i386/cpu.c | 8 target/i386/cpu.h | 5 ++---

[PATCH v4 0/2] target/i386: cpu.h marcos clean up

2019-09-23 Thread Tao Xu
Add some comments, clean up comments over 80 chars per line. And there is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove the extra enter and spaces. Drop the duplicated definition of cpuid AVX512_VBMI marco and rename it as CPUID_7_0_ECX_AVX512_VBMI. And rename

[PATCH v4 1/2] target/i386: clean up comments over 80 chars per line

2019-09-23 Thread Tao Xu
Add some comments, clean up comments over 80 chars per line. And there is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove the extra enter and spaces. Acked-by: Stefano Garzarella Signed-off-by: Tao Xu --- target/i386/cpu.h | 164 ++

Re: [PATCH v1 4/6] riscv/sifive_u: Add the start-in-flash property

2019-09-23 Thread Bin Meng
On Tue, Sep 24, 2019 at 1:51 AM Alistair Francis wrote: > > On Sat, Sep 21, 2019 at 7:19 PM Bin Meng wrote: > > > > On Sat, Sep 21, 2019 at 6:12 AM Alistair Francis > > wrote: > > > > > > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > > > > > > > On Fri, Sep 20, 2019 at 6:32 AM Alistair

Re: [PATCH v4 21/24] paaudio: channel-map option

2019-09-23 Thread Zoltán Kővágó
On 2019-09-23 15:12, Markus Armbruster wrote: "Kővágó, Zoltán" writes: Add an option to change the channel map used by pulseaudio. If not specified, falls back to an OSS compatible channel map. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 18 ++ qapi/audio.json |

Re: [PATCH v4 15/24] audio: add mixing-engine option (documentation)

2019-09-23 Thread Zoltán Kővágó
On 2019-09-23 15:08, Markus Armbruster wrote: "Kővágó, Zoltán" writes: This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just

Re: Migration failure when running nested VMs

2019-09-23 Thread Paolo Bonzini
On 23/09/19 20:32, Jintack Lim wrote: > On Mon, Sep 23, 2019 at 4:48 AM Paolo Bonzini wrote: >> >> On 23/09/19 12:42, Dr. David Alan Gilbert wrote: >>> >>> With those two clues, I guess maybe some dirty pages made by L2 are >>> not transferred to the destination correctly, but I'm not really

Re: [PATCH] migration/postcopy: Recognise the recovery states as 'in_postcopy'

2019-09-23 Thread Peter Xu
On Mon, Sep 23, 2019 at 06:49:42PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Various parts of the migration code do different things when they're > in postcopy mode; prior to this patch this has been 'postcopy-active'. > This patch extends 'in_postcopy' to

Re: [Qemu-devel] [PATCH 2/4] Memory: Enable writeback for given memory region

2019-09-23 Thread Alex Bennée
Beata Michalska writes: > Add an option to trigger memory writeback to sync given memory region > with the corresponding backing store, case one is available. > This extends the support for persistent memory, allowing syncing on-demand. > > Also, adding verification for msync support on host.

Re: [Qemu-devel] [PATCH 4/4] target/arm: Add support for DC CVAP & DC CVADP ins

2019-09-23 Thread Alex Bennée
Beata Michalska writes: > ARMv8.2 introduced support for Data Cache Clean instructions > to PoP (point-of-persistence) - DC CVAP and PoDP (point-of-deep-persistence) > - DV CVADP. Both specify conceptual points in a memory system where all writes > that are to reach them are considered

Re: [Qemu-devel] [PATCH 1/4] tcg: cputlb: Add probe_read

2019-09-23 Thread Alex Bennée
Beata Michalska writes: > Add probe_read alongside the write probing equivalent. > > Signed-off-by: Beata Michalska Reviewed-by: Alex Bennée > --- > include/exec/exec-all.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Peter Xu
On Mon, Sep 23, 2019 at 05:10:43PM -0600, Alex Williamson wrote: > On Mon, 23 Sep 2019 13:43:08 +0200 > Auger Eric wrote: > > > On 9/23/19 9:51 AM, Peter Xu wrote: > > > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote: > > >> @@ -1308,9 +1319,9 @@ static int

[PATCH] qemu-pr-helper: fix crash in mpath_reconstruct_sense

2019-09-23 Thread Maxim Levitsky
The 'r' variable was accidently shadowed, and because of this we were always passing 0 to mpath_generic_sense, instead of original return value, which triggers an abort() This is an attempt to fix the https://bugzilla.redhat.com/show_bug.cgi?id=1720047 although there might be other places in the

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Alex Williamson
On Mon, 23 Sep 2019 13:43:08 +0200 Auger Eric wrote: > On 9/23/19 9:51 AM, Peter Xu wrote: > > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote: > >> @@ -1308,9 +1319,9 @@ static int vfio_connect_container(VFIOGroup *group, > >> AddressSpace *as, > >>

[PATCH v4 16/16] cputlb: Pass retaddr to tb_check_watchpoint

2019-09-23 Thread Richard Henderson
Fixes the previous TLB_WATCHPOINT patches because we are currently failing to set cpu->mem_io_pc with the call to cpu_check_watchpoint. Pass down the retaddr directly because it's readily available. Fixes: 50b107c5d61 Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson ---

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Alex Williamson
On Mon, 23 Sep 2019 08:55:51 +0200 Eric Auger wrote: > The container error integer field is currently used to store > the first error potentially encountered during any > vfio_listener_region_add() call. However this fails to propagate > detailed error messages up to the vfio_connect_container

[PATCH v4 14/16] cputlb: Remove tb_invalidate_phys_page_range is_cpu_write_access

2019-09-23 Thread Richard Henderson
All callers pass false to this argument. Remove it and pass the constant on to tb_invalidate_phys_page_range__locked. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- accel/tcg/translate-all.h | 3 +-- accel/tcg/translate-all.c | 6 ++ exec.c| 4 ++--

[PATCH v4 13/16] cputlb: Remove cpu->mem_io_vaddr

2019-09-23 Thread Richard Henderson
With the merge of notdirty handling into store_helper, the last user of cpu->mem_io_vaddr was removed. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 2 -- accel/tcg/cputlb.c| 2 -- hw/core/cpu.c | 1 - 3 files changed, 5 deletions(-)

[PATCH v4 11/16] cputlb: Merge and move memory_notdirty_write_{prepare, complete}

2019-09-23 Thread Richard Henderson
Since 9458a9a1df1a, all readers of the dirty bitmaps wait for the rcu lock, which means that they wait until the end of any executing TranslationBlock. As a consequence, there is no need for the actual access to happen in between the _prepare and _complete. Therefore, we can improve things by

[PATCH v4 05/16] cputlb: Split out load/store_memop

2019-09-23 Thread Richard Henderson
We will shortly be using these more than once. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 110 +++-- 1 file changed, 57 insertions(+), 53 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index e529af6d09..430ba4a69d 100644

[PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-23 Thread Richard Henderson
There is only one caller, tlb_set_page_with_attrs. We cannot inline the entire function because the AddressSpaceDispatch structure is private to exec.c, and cannot easily be moved to include/exec/memory-internal.h. Compute is_ram and is_romd once within tlb_set_page_with_attrs. Fold the number

[PATCH v4 15/16] cputlb: Pass retaddr to tb_invalidate_phys_page_fast

2019-09-23 Thread Richard Henderson
Rather than rely on cpu->mem_io_pc, pass retaddr down directly. Within tb_invalidate_phys_page_range__locked, the is_cpu_write_access parameter is non-zero exactly when retaddr would be non-zero, so that is a simple replacement. Recognize that current_tb_not_found is true only when mem_io_pc

[PATCH v4 07/16] exec: Adjust notdirty tracing

2019-09-23 Thread Richard Henderson
The memory_region_tb_read tracepoint is unreachable, since notdirty is supposed to apply only to writes. The memory_region_tb_write tracepoint is mis-named, because notdirty is not only used for TB invalidation. It is also used for e.g. VGA RAM updates and migration. Replace

[PATCH v4 09/16] cputlb: Move NOTDIRTY handling from I/O path to TLB path

2019-09-23 Thread Richard Henderson
Pages that we want to track for NOTDIRTY are RAM. We do not really need to go through the I/O path to handle them. Acked-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/exec/cpu-common.h | 2 -- accel/tcg/cputlb.c| 26

Re: [PATCH v2 04/16] tests/docker: reduce scary warnings from failed inspect

2019-09-23 Thread Alex Bennée
Cleber Rosa writes: > On Thu, Sep 19, 2019 at 06:10:03PM +0100, Alex Bennée wrote: >> There is a race here in the clean-up code so lets just accept that >> sometimes the active task we just looked up might have finished before >> we got to inspect it. >> >> Signed-off-by: Alex Bennée >> ---

[PATCH v4 12/16] cputlb: Handle TLB_NOTDIRTY in probe_access

2019-09-23 Thread Richard Henderson
We can use notdirty_write for the write and return a valid host pointer for this case. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index

[PATCH v4 06/16] cputlb: Introduce TLB_BSWAP

2019-09-23 Thread Richard Henderson
Handle bswap on ram directly in load/store_helper. This fixes a bug with the previous implementation in that one cannot use the I/O path for RAM. Fixes: a26fc6f5152b47f1 Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- include/exec/cpu-all.h | 4 ++- accel/tcg/cputlb.c

[PATCH v4 02/16] cputlb: Disable __always_inline__ without optimization

2019-09-23 Thread Richard Henderson
This forced inlining can result in missing symbols, which makes a debugging build harder to follow. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- include/qemu/compiler.h | 11 +++ accel/tcg/cputlb.c

[PATCH v4 04/16] cputlb: Use optimize_away in load/store_helpers

2019-09-23 Thread Richard Henderson
Increase the current runtime assert to a compile-time assert. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index b87764..e529af6d09 100644 --- a/accel/tcg/cputlb.c +++

[PATCH v4 08/16] cputlb: Move ROM handling from I/O path to TLB path

2019-09-23 Thread Richard Henderson
It does not require going through the whole I/O path in order to discard a write. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 5 - include/exec/cpu-common.h | 1 - accel/tcg/cputlb.c| 35 +++-- exec.c

[PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-23 Thread Richard Henderson
Use this as a compile-time assert that a particular code path is not reachable. Signed-off-by: Richard Henderson --- include/qemu/compiler.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 20780e722d..6604ccea92 100644

[PATCH v4 01/16] exec: Use TARGET_PAGE_BITS_MIN for TLB flags

2019-09-23 Thread Richard Henderson
These bits do not need to vary with the actual page size used by the guest. Reviewed-by: David Hildenbrand Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- include/exec/cpu-all.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH v4 00/16] Move rom and notdirty handling to cputlb

2019-09-23 Thread Richard Henderson
Changes since v3: * Don't accidentally include the TARGET_PAGE_BITS_VARY patch set. ;-) * Remove __has_attribute(__always_inline__). * Use single load/store_memop function instead of separate small wrappers. * Introduce optimize_away to assert the code folds away as expected. Patches

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Jeff King
On Mon, Sep 23, 2019 at 01:19:18PM +0200, Christian Schoenebeck wrote: > > if (cmit_fmt_is_mail(pp->fmt)) { > > - if (pp->from_ident && ident_cmp(pp->from_ident, )) { > > + if (pp->always_use_in_body_from || > > + (pp->from_ident && ident_cmp(pp->from_ident,

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-23 Thread Peter Maydell
On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > I don't think we should mirror what is used on ARM virt board to > > create 2 flash for sifive_u. For ARM virt, there are 2 flashes because > > they need distinguish secure and

[PATCH] ui: fix keymap file search in input-barrier object

2019-09-23 Thread Laurent Vivier
If we try to start QEMU with "-k en-us", qemu prints a message and exits with: qemu-system-i386: could not read keymap file: 'en-us' It's because this function is called way too early, before qemu_add_data_dir() is called, and so qemu_find_file() fails. To fix that, move

Re: [PULL 00/30] s390x/tcg update

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 09:07, David Hildenbrand wrote: > > Hi Peter, > > here is the updated tcg subset of the s390x update (including one more > test). > > The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad: > > Merge remote-tracking branch

Re: [Qemu-block] [PATCH v6 5/8] bootdevice: Gather LCHS from all relevant devices

2019-09-23 Thread John Snow
On 8/27/19 4:24 AM, Sam Eiderman via Qemu-block wrote: > From: Sam Eiderman > > Relevant devices are: > * ide-hd (and ide-cd, ide-drive) > * scsi-hd (and scsi-cd, scsi-disk, scsi-block) > * virtio-blk-pci > > We do not call del_boot_device_lchs() for ide-* since we don't need to

Re: Debian support lifetime (was Re: [PATCH] docker: move tests from python2 to python3)

2019-09-23 Thread John Snow
On 9/23/19 3:05 PM, Eduardo Habkost wrote: > On Mon, Sep 23, 2019 at 01:19:41PM -0400, John Snow wrote: >> On 9/23/19 10:50 AM, Cleber Rosa wrote: > [...] diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker b/tests/docker/dockerfiles/debian-xtensa-cross.docker index

Re: [RFC v2 6/9] scripts: add coccinelle script to use auto propagated errp

2019-09-23 Thread Eric Blake
On 9/23/19 3:05 PM, Eric Blake wrote: > Does running this Coccinelle script 2 times in a row add a second > ERRP_FUNCTION_BEGIN() line? We want it to be idempotent (no changes on > a second run). (Admittedly, I did not actually test that yet). Also, I > don't know if this can be tweaked to

Re: [RFC v2 6/9] scripts: add coccinelle script to use auto propagated errp

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/coccinelle/auto-propagated-errp.cocci | 82 +++ > 1 file changed, 82 insertions(+) > create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci > > diff

Re: [PATCH v2 04/16] tests/docker: reduce scary warnings from failed inspect

2019-09-23 Thread Cleber Rosa
On Thu, Sep 19, 2019 at 06:10:03PM +0100, Alex Bennée wrote: > There is a race here in the clean-up code so lets just accept that > sometimes the active task we just looked up might have finished before > we got to inspect it. > > Signed-off-by: Alex Bennée > --- > tests/docker/docker.py | 32

Re: [RFC v2 4/9] hw/core/loader-fit: fix freeing errp in fit_load_fdt

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > fit_load_fdt forget to zero errp. Fix it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/core/loader-fit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Independent bug fix. Either we take the (fixed) 2-3 (to

Re: [RFC v2 2/9] qapi/error: add (Error **errp) cleaning APIs

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- A "why" as the commit message body wouldn't hurt. > include/qapi/error.h | 22 ++ > util/error.c | 6 +++--- > 2 files changed, 25 insertions(+), 3

Re: [RFC v2 0/9] error: auto propagated local_err

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal of auto propagation for local_err, to not call > error_propagate on every exit point, when we deal with local_err. > > It also fixes two issues: > 1. Fix issue with error_fatal & error_append_hint: user

Re: [RFC v2 3/9] errp: rename errp to errp_in where it is IN-argument

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Error **errp is almost always OUT-argument: it's assumed to be NULL, or > pointer to NULL-initialized pointer, or pointer to error_abort or > error_fatal, for callee to report error. > > But very few functions (most of the are error API)

Re: [RFC v2 5/9] net/net: fix local variable shadowing in net_client_init

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Don't shadow Error *err: it's a bad thing. This patch also simplifies > following Error propagation conversion. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > net/net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [RFC v2 7/9] Use auto-propagated errp

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > This commit is generated by command > > git grep -l 'Error \*\*errp' | while read f; \ > do spatch --sp-file \ > scripts/coccinelle/auto-propagated-errp.cocci --in-place $f; done > As mentioned in your cover letter, this fails

Re: [RFC v2 1/9] error: auto propagated local_err

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Here is introduced ERRP_FUNCTION_BEGIN macro, to be used at start of > any function with errp parameter. > > It has three goals: > > 1. Fix issue with error_fatal & error_append_hint: user can't see these > hints, because exit() happens

Re: [PULL 00/30] s390x/tcg update

2019-09-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190923080712.23951-1-da...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190923080712.23951-1-da...@redhat.com Subject: [PULL 00/30] s390x/tcg update Type: series === TEST

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-23 Thread Alistair Francis
On Sat, Sep 21, 2019 at 7:15 PM Bin Meng wrote: > > On Sat, Sep 21, 2019 at 6:16 AM Alistair Francis wrote: > > > > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > > > > > On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis > > > wrote: > > > > > > > > Add the CFI01 PFlash to the RISC-V virt

Re: [PATCH v2 03/16] tests/docker: remove python2.7 from docker9-mxe

2019-09-23 Thread John Snow
On 9/23/19 3:49 PM, Cleber Rosa wrote: > On Thu, Sep 19, 2019 at 06:10:02PM +0100, Alex Bennée wrote: >> From: John Snow >> >> When it was based on docker8 which uses python-minimal, it needed this. > > Assuming this docker8 was a typo? I mean, s/docker8/debian8/ ? > > - Cleber > WHOOPS,

Re: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23

2019-09-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-cr...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190923134019.8548-1-cr...@redhat.com Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-09-23 Thread Eric Blake
On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: > Add test, which starts backup to nbd target and restarts nbd server > during backup. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/264| 65 +++ >

Re: [PATCH v2 03/16] tests/docker: remove python2.7 from docker9-mxe

2019-09-23 Thread Cleber Rosa
On Thu, Sep 19, 2019 at 06:10:02PM +0100, Alex Bennée wrote: > From: John Snow > > When it was based on docker8 which uses python-minimal, it needed this. Assuming this docker8 was a typo? I mean, s/docker8/debian8/ ? - Cleber > It no longer does. > > Goodbye, python2.7. > > Signed-off-by:

Re: [PATCH v2 02/16] tests/docker: fix DOCKER_PARTIAL_IMAGES

2019-09-23 Thread Cleber Rosa
On Thu, Sep 19, 2019 at 06:10:01PM +0100, Alex Bennée wrote: > Finger trouble in a previous clean-up inadvertently set > DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES. Also fix the > typo to debian-9-mxe. > > Fixes: 44d5a8bf5d2 > Signed-off-by: John Snow > [AJB: merged fix from

Re: [PATCH v9 2/3] block/nbd: nbd reconnect

2019-09-23 Thread Eric Blake
On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: > Implement reconnect. To achieve this: > > 1. add new modes: >connecting-wait: means, that reconnecting is in progress, and there > were small number of reconnect attempts, so all requests are > waiting for the connection. >

[Bug 1777777] Re: arm9 clock pending (SP804)

2019-09-23 Thread RTOS Pharos
Forgot to state the qemu argument, it's this one: ~/cross-compiler/qemu/2.5/bin/qemu-system-arm -M versatilepb -m 128M -nographic -kernel myApplication -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Debian support lifetime (was Re: [PATCH] docker: move tests from python2 to python3)

2019-09-23 Thread Eduardo Habkost
On Mon, Sep 23, 2019 at 01:19:41PM -0400, John Snow wrote: > On 9/23/19 10:50 AM, Cleber Rosa wrote: [...] > >> diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker > >> b/tests/docker/dockerfiles/debian-xtensa-cross.docker > >> index b9c2e2e531..e6f93f65ee 100644 > >> ---

[Bug 1777777] Re: arm9 clock pending (SP804)

2019-09-23 Thread RTOS Pharos
Sorry to have taken some time to answer. Created the binary with the test. Here is the output when it fails (tested in Qemu 2.12): Checked 0 times if the time is always increasing Checked 10 times if the time is always increasing Checked 20 times if the time is always increasing Checked

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 19:51, Thomas Huth wrote: > It also sounds like CONFIG_ARM_V7M should rather be renamed to > CONFIG_ARM_MPROFILE or something similar? Depends whether it's visible to end-users or not. If it is, a different name is probably more helpful; if it's just a symbol used in the

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Thomas Huth
On 23/09/2019 20.45, Peter Maydell wrote: > On Mon, 23 Sep 2019 at 19:09, Thomas Huth wrote: >> However, there's one thing I currently don't quite understand in this >> code (since I'm not an ARM guy, sorry) : There are references to "v8" in >> m_helper.c, too. Is that related to a separate CPU

Re: [Qemu-devel] [PATCH v3] ui: add an embedded Barrier client

2019-09-23 Thread Laurent Vivier
Le 23/09/2019 à 18:07, Anthony PERARD a écrit : > Hi, > > Once this patch is applied, if we try to start QEMU with "-k en-us", > qemu print a message and exit: > qemu-system-i386: could not read keymap file: 'en-us' > > See below, > > On Fri, Sep 06, 2019 at 10:38:12AM +0200, Laurent Vivier

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 19:36, Thomas Huth wrote: > > On 23/09/2019 20.27, Peter Maydell wrote: > > On Mon, 23 Sep 2019 at 18:54, Thomas Huth wrote: > >> Ok, then what would you suggest to solve the problem that this file has > >> always to be linked into the binary? I can't use "obj-y += ..." in

Re: [PATCH v2 05/16] podman: fix command invocation

2019-09-23 Thread Cleber Rosa
On Thu, Sep 19, 2019 at 06:10:04PM +0100, Alex Bennée wrote: > From: John Snow > > Oops; there's no argv here. > > Signed-off-by: John Snow > Message-Id: <20190913193821.17756-1-js...@redhat.com> > Signed-off-by: Alex Bennée Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa > --- >

Re: [Qemu-devel] [PATCH] podman: fix command invocation

2019-09-23 Thread Cleber Rosa
On Fri, Sep 13, 2019 at 03:38:21PM -0400, John Snow wrote: > Oops; there's no argv here. > > Signed-off-by: John Snow > --- > tests/docker/docker.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/docker.py b/tests/docker/docker.py > index

Re: [PATCH 2/4] target/arm: Move cortex-m related functions to new file v7m.c

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 19:09, Thomas Huth wrote: > However, there's one thing I currently don't quite understand in this > code (since I'm not an ARM guy, sorry) : There are references to "v8" in > m_helper.c, too. Is that related to a separate CPU type, ie. should the > v8 code also be available

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-23 Thread Thomas Huth
On 23/09/2019 20.27, Peter Maydell wrote: > On Mon, 23 Sep 2019 at 18:54, Thomas Huth wrote: >> Ok, then what would you suggest to solve the problem that this file has >> always to be linked into the binary? I can't use "obj-y += ..." in >> hw/intc/Makefile.objs since that would mean that the

Re: [Qemu-devel] [RFC QEMU v2 1/2] arm/virt: Initialize generic timer scale factor dynamically

2019-09-23 Thread Masayoshi Mizuma
Hi, This issue remains on the latest qemu, right? Let me add some comments for the patch. On Tue, Nov 27, 2018 at 01:07:16PM -0800, Bijan Mottahedeh wrote: > Initialize the generic timer scale factor based on the counter frequency > register cntfrq_el0, and default to the current static value if

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-23 Thread Laszlo Ersek
On 09/20/19 11:28, Laszlo Ersek wrote: > On 09/20/19 10:28, Igor Mammedov wrote: >> On Thu, 19 Sep 2019 19:02:07 +0200 >> "Laszlo Ersek" wrote: >> >>> Hi Igor, >>> >>> (+Brijesh) >>> >>> long-ish pondering ahead, with a question at the end. >> [...] >> >>> Finally: can you please remind me why we

Re: Migration failure when running nested VMs

2019-09-23 Thread Jintack Lim
On Mon, Sep 23, 2019 at 3:42 AM Dr. David Alan Gilbert wrote: > > * Jintack Lim (incredible.t...@gmail.com) wrote: > > Hi, > > Copying in Paolo, since he recently did work to fix nested migration - > it was expected to be broken until pretty recently; but 4.1.0 qemu on > 5.3 kernel is pretty new,

Re: Migration failure when running nested VMs

2019-09-23 Thread Jintack Lim
On Mon, Sep 23, 2019 at 4:48 AM Paolo Bonzini wrote: > > On 23/09/19 12:42, Dr. David Alan Gilbert wrote: > > > > With those two clues, I guess maybe some dirty pages made by L2 are > > not transferred to the destination correctly, but I'm not really sure. > > > > 3) It happens on Intel(R)

Re: [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements

2019-09-23 Thread Markus Armbruster
Queued with two small tweaks as per Eric's review: a commit message typo fix in PATCH 10, and an additional paragraph on invisible schema changes in PATCH 13.

Re: [PATCH 3/4] hw/arm: Move armv7m_nvic.c to hw/arm/ and always enable it for arm builds

2019-09-23 Thread Peter Maydell
On Mon, 23 Sep 2019 at 18:54, Thomas Huth wrote: > Ok, then what would you suggest to solve the problem that this file has > always to be linked into the binary? I can't use "obj-y += ..." in > hw/intc/Makefile.objs since that would mean that the file also gets > compiled for non-Arm boards.

  1   2   3   4   >