Re: Is network backend vde worth keeping? (was: Is network backend netmap worth keeping?)

2019-10-10 Thread Thomas Huth
On 09/10/2019 11.13, Thomas Huth wrote: > On 07/10/2019 20.21, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Please excuse the attention-grabbing subject. >> >> Again. >> >> [...] >>> So, to make use of QEMU's netmap backend (CONFIG_NETMAP), you have to >>> build and install netmap

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Laszlo Ersek
On 10/10/19 17:57, Igor Mammedov wrote: > On Thu, 10 Oct 2019 09:59:42 -0400 > "Michael S. Tsirkin" wrote: > >> On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote: >>> On Thu, 10 Oct 2019 05:56:55 -0400 >>> "Michael S. Tsirkin" wrote: >>> On Wed, Oct 09, 2019 at 09:22:49AM -0400,

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Laszlo Ersek
On 10/10/19 20:08, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote: >> On 10/10/19 14:48, Igor Mammedov wrote: >> >>> it doesn't really matter if it's ACPI blob or fw_cfg, >>> what firmware needs is a table of possible CPUs with APIC IDs. >> >> To repeat my

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-10-10 Thread Greg Kurz
On Fri, 11 Oct 2019 16:07:58 +1100 David Gibson wrote: > On Thu, Oct 10, 2019 at 10:33:04PM +0200, Greg Kurz wrote: > > On Thu, 10 Oct 2019 08:29:58 +0200 > > Greg Kurz wrote: > > > > > On Thu, 10 Oct 2019 13:02:09 +1100 > > > David Gibson wrote: > > > > > > > On Wed, Oct 09, 2019 at 07:02:15

RE: [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-10-10 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 25.09.2019 um 11:02 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 20.09.2019 um 09:25 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 19.09.2019 um 14:10

[Bug 1847440] Re: ppc64le: KVM guest fails to boot with an error `virtio_scsi: probe of virtio1 failed with error -22` on master

2019-10-10 Thread David Gibson
Oh... are you using the SLOF (guest firmware) image included in the qemu tree, or is it coming from a separate package? If it's from a separate package, that could be the problem - it needs to be updated before that qemu patch is safe. -- You received this bug notification because you are a me

Re: [PATCH v2 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-10 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.10.2019 um 13:57 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> >> > On 10/1/19 2:34 PM, Markus Armbruster wrote: >> >> Peter Krempa writes: >> >> >> >>> savevm was buggy as it considered all monitor owned block device nodes >> >> >> >> Recommend "monito

Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues

2019-10-10 Thread Jan Glauber
On Wed, Oct 09, 2019 at 11:15:04AM +0200, Paolo Bonzini wrote: > On 09/10/19 10:02, Jan Glauber wrote: > > I'm still not sure what the actual issue is here, but could it be some bad > > interaction between the notify_me and the list_lock? The are both 4 byte > > and side-by-side: > > > > address

Re: [PATCH] trace: avoid "is" with a literal Python 3.8 warnings

2019-10-10 Thread Markus Armbruster
Stefan Hajnoczi writes: > The following statement produces a SyntaxWarning with Python 3.8: > > if len(format) is 0: > scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did > you mean "=="? > > Use the conventional len(x) == 0 syntax instead. > > Reported-by: Daniel P. B

Re: [PATCH v4] migration: Support gtree migration

2019-10-10 Thread Peter Xu
On Thu, Oct 10, 2019 at 10:52:42PM +0200, Eric Auger wrote: > Introduce support for GTree migration. A custom save/restore > is implemented. Each item is made of a key and a data. > > If the key is a pointer to an object, 2 VMSDs are passed into > the GTree VMStateField. > > When putting the item

[Bug 1847440] Re: ppc64le: KVM guest fails to boot with an error `virtio_scsi: probe of virtio1 failed with error -22` on master

2019-10-10 Thread David Gibson
Ok, I just tried booting a guest with virtio-scsi and ic-mode=xics, and I wasn't able to reproduce this problem. Can you try simplifying your command line to see what options are needed to trigger this? -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [PATCH v4] migration: Support gtree migration

2019-10-10 Thread Auger Eric
Hi, On 10/11/19 1:51 AM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20191010205242.711-1-eric.au...@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker in

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-10-10 Thread David Gibson
On Thu, Oct 10, 2019 at 10:33:04PM +0200, Greg Kurz wrote: > On Thu, 10 Oct 2019 08:29:58 +0200 > Greg Kurz wrote: > > > On Thu, 10 Oct 2019 13:02:09 +1100 > > David Gibson wrote: > > > > > On Wed, Oct 09, 2019 at 07:02:15PM +0200, Greg Kurz wrote: > > > > On Wed, 9 Oct 2019 17:08:16 +1100 > >

Re: [PATCH v3 0/8] hw: Convert various reset() handler to DeviceReset

2019-10-10 Thread Eduardo Habkost
Queueing on machine-next. Thanks! On Thu, Oct 10, 2019 at 03:15:19PM +0200, Philippe Mathieu-Daudé wrote: > Only patch 3/8 is missing review: > - hw/ide/piix: Convert reset handler to DeviceReset > > Since v2: > - Fixed PIIX_IDE conversion (Li) > - Added more R-b tag. > > Since v1: > - Removed

Re: [Qemu-devel] [RFC 2 PATCH 16/16] hw/core: Fix up the machine_set_cpu_numa_node for epyc

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:13:29PM +, Moger, Babu wrote: > Current topology id match will not work for epyc mode when setting > the node id. In epyc mode, ids like smt_id, thread_id, core_id, > ccx_id, socket_id can be same for more than one CPUs with across > two numa nodes. > > For example,

Re: [Qemu-devel] [RFC 2 PATCH 15/16] i386: Fix pkg_id offset for epyc mode

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:13:22PM +, Moger, Babu wrote: > Signed-off-by: Babu Moger > --- > target/i386/cpu.c | 24 +++- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index f25491a029..f8b1fc5c07 100644 > --

Re: [Qemu-devel] [RFC 2 PATCH 13/16] machine: Add new epyc property in PCMachineState

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:13:09PM +, Moger, Babu wrote: > Adds new epyc property in PCMachineState and also in MachineState. > This property will be used to initialize the mode specific handlers > to generate apic ids. > > Signed-off-by: Babu Moger > --- [...] > diff --git a/include/hw/board

Re: [Qemu-devel] [RFC 2 PATCH 09/16] hw/i386: Introduce initialize_topo_info function

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:12:40PM +, Moger, Babu wrote: > Introduce initialize_topo_info to initialize X86CPUTopoInfo > data structure to build the topology. No functional change. > > Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost Maybe this could be squashed into patch 03/16. -

Re: [Qemu-devel] [RFC 2 PATCH 03/16] hw/i386: Introduce X86CPUTopoInfo to contain topology info

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:11:57PM +, Moger, Babu wrote: > This is an effort to re-arrange few data structure for better > readability. Add X86CPUTopoInfo which will have all the topology > informations required to build the cpu topology. There is no > functional changes. > > Signed-off-by: Ba

Re: [Qemu-devel] [RFC 2 PATCH 08/16] i386: Cleanup and use the new epyc mode topology functions

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:12:33PM +, Moger, Babu wrote: > Use the new epyc mode functions and delete the unused code. > > Signed-off-by: Babu Moger > --- > target/i386/cpu.c | 171 > +++-- > 1 file changed, 48 insertions(+), 123 deletions(-)

Re: [Qemu-devel] [RFC 2 PATCH 07/16] hw/386: Add new epyc mode topology decoding functions

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:12:25PM +, Moger, Babu wrote: > These functions add support for building new epyc mode topology > given smp details like numa nodes, cores, threads and sockets. > Subsequent patches will use these functions to build the topology. > > The topology details are availabl

Re: [Bug 1847440] [NEW] ppc64le: KVM guest fails to boot with an error `virtio_scsi: probe of virtio1 failed with error -22` on master

2019-10-10 Thread David Gibson
On Thu, Oct 10, 2019 at 07:16:49AM -, Launchpad Bug Tracker wrote: > You have been subscribed to a public bug by Satheesh Rajendran (sathnaga): > > PowerPC KVM Guest fails to boot on current qemu master, bad commit: > e68cd0cb5cf49d334abe17231a1d2c28b846afa2 > > Env: > HW: IBM Power9 > Host K

Re: [RFC 2/2] virtio-net: use post load hook

2019-10-10 Thread Jason Wang
On 2019/10/11 上午2:04, Michael S. Tsirkin wrote: Currently offloads disabled by guest via the VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET command are not preserved on VM migration. Instead all offloads reported by guest features (via VIRTIO_PCI_GUEST_FEATURES) get enabled. What happens is: first the Virt

Re: [Qemu-devel] [RFC 2 PATCH 05/16] hw/i386: Simplify topology Offset/width Calculation

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:12:11PM +, Moger, Babu wrote: > Some parameters are unnecessarily passed for offset/width > calculation. Remove those parameters from function prototypes. > No functional change. > > Signed-off-by: Babu Moger Isn't it simpler to use the new X86CPUTopoInfo struct, t

Re: [Qemu-devel] [RFC 2 PATCH 04/16] machine: Add SMP Sockets in CpuTopology

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:12:04PM +, Moger, Babu wrote: > Store the smp Sockets in CpuTopology. Socket information > is required to build the cpu topology in new epyc mode. > > Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost > --- > hw/core/machine.c |1 + > hw/i386/pc.c

Re: [Qemu-devel] [RFC 2 PATCH 03/16] hw/i386: Introduce X86CPUTopoInfo to contain topology info

2019-10-10 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:11:57PM +, Moger, Babu wrote: > This is an effort to re-arrange few data structure for better > readability. Add X86CPUTopoInfo which will have all the topology > informations required to build the cpu topology. There is no > functional changes. > > Signed-off-by: Ba

Re: [PATCH v3 3/8] hw/ide/piix: Convert reset handler to DeviceReset

2019-10-10 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月10日周四 下午9:16写道: > The PIIX/IDE is a PCI device within a PIIX chipset, it will be reset > when the PCI bus it stands on is reset. > > Convert its reset handler into a proper Device reset method. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang

Re: [PATCH v4] migration: Support gtree migration

2019-10-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191010205242.711-1-eric.au...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support

2019-10-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191010155853.4325-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/7] libqos: add VIRTIO PCI 1.0 support Type: series Message-id: 20191010155853.4325-1-stefa...@redh

[PATCH v2 0/2] Better NBD string length handling

2019-10-10 Thread Eric Blake
Patch 1 is a revised version after Maxim's comments - it moves the length checks earlier into the system (for cleaner error messages as soon as possible) and adds asserts at the later points that are now guaranteed by the earlier checks. It also covers more string handling, both in the client and i

[PATCH v2 1/2] nbd: Don't send oversize strings

2019-10-10 Thread Eric Blake
Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near the NBD spec maximum of a 4k limit per string. However, we weren't actually enforcing things,

[PATCH v2 2/2] nbd: Allow description when creating NBD blockdev

2019-10-10 Thread Eric Blake
Allow blockdevs to match the feature already present in qemu-nbd -D. Enhance iotest 223 to cover it. Signed-off-by: Eric Blake --- qapi/block.json| 8 +--- blockdev-nbd.c | 9 - monitor/hmp-cmds.c | 4 ++-- tests/qemu-iotests/223 | 2 +- tests/qemu

[PATCH v4] migration: Support gtree migration

2019-10-10 Thread Eric Auger
Introduce support for GTree migration. A custom save/restore is implemented. Each item is made of a key and a data. If the key is a pointer to an object, 2 VMSDs are passed into the GTree VMStateField. When putting the items, the tree is traversed in sorted order by g_tree_foreach. On the get()

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-10-10 Thread Greg Kurz
On Thu, 10 Oct 2019 08:29:58 +0200 Greg Kurz wrote: > On Thu, 10 Oct 2019 13:02:09 +1100 > David Gibson wrote: > > > On Wed, Oct 09, 2019 at 07:02:15PM +0200, Greg Kurz wrote: > > > On Wed, 9 Oct 2019 17:08:16 +1100 > > > David Gibson wrote: > > > > > > > The only thing remaining in this str

Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

2019-10-10 Thread Jag Raman
On 10/9/2019 1:58 PM, Elena Ufimtseva wrote: On Wed, Oct 09, 2019 at 02:37:24PM +0100, Stefan Hajnoczi wrote: On Thu, Sep 12, 2019 at 05:34:35PM +0200, Stefan Hajnoczi wrote: On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote: +msg->num_fds = 0; +for (chdr = CMSG_FIRS

Re: [PATCH 23/23] iotests: Drop TEST_DIR filter from _filter_nbd

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Sockets should be placed into $SOCK_DIR instead of $TEST_DIR, so remove the $TEST_DIR filter from _filter_nbd. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/common.fil

Re: [PATCH 04/23] iotests: Filter $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) @@ -218,7 +221,8 @@ _filter_nbd() # Filter out the TCP port number since this changes between runs. $SED -e '/nbd\

Re: [PATCH 20/23] iotests/223: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/223 | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu

Re: [PATCH 22/23] iotests/267: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/267 | 4 ++-- tests/qemu-iotests/267.out | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-

Re: [PATCH 21/23] iotests/240: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/240 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/240 b/tests/qemu-iotests/240 index f73bc07d80..8b4337b58d 100755 --- a/tests/qemu-

Re: [PATCH 19/23] iotests/222: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/222 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 index 0ead56d574..3f9f934ad8 100644 --- a/tests/qemu-iote

Re: [PATCH 18/23] iotests/209: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/209 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209 index 259e991ec6..e0f464bcbe 100755 --- a/tests/qemu-io

Re: [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/194 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194 index d746ab1e21..72e47e8833 100755 --- a/tests/qemu-iotests/194 +++ b/tests/qemu-

Re: [PATCH v3] migration: Support gtree migration

2019-10-10 Thread Auger Eric
Hi, On 10/10/19 8:53 PM, Dr. David Alan Gilbert wrote: > * Auger Eric (eric.au...@redhat.com) wrote: >> Hi peter, >> >> On 10/10/19 2:35 PM, Peter Xu wrote: >>> On Thu, Oct 10, 2019 at 02:11:46PM +0200, Auger Eric wrote: >>> Also, should we avoid using UINT in all cases? But of course if we >

Re: [PATCH 17/23] iotests/208: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/208 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208 index 1e202388dc..546eb1de3e 100755 --- a/tests/qemu-iote

Re: [PATCH 16/23] iotests/205: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/205 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205 index 76f6c5fa2b..4bb2c21e8b 100755 --- a/tests/qemu-iote

Re: [PATCH 15/23] iotests/201: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/201 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/201 b/tests/qemu-iotests/201 index 7abf740fe4..86fa37e714 100755 --- a/tests/qemu-iote

Re: [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/194 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194 index d746ab1e21..72e47e8833 100755 --- a/tests/qemu-

Re: [PATCH 13/23] iotests/192: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/192 | 4 ++-- tests/qemu-iotests/192.out | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-

Re: [PATCH 12/23] iotests/183: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/183 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 index 04fb344d08..bced83fae0 100755 --- a/tests/qemu-iote

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Eduardo Habkost
On Thu, Oct 10, 2019 at 11:06:29AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: > > On 10/09/19 15:22, Igor Mammedov wrote: > > > Extend CPU hotplug interface to return architecture specific > > > identifier for current CPU (in case of x86, it's A

Re: [PATCH 11/23] iotests/182: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/182 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/182 b/tests/qemu-iotests/182 index 7f494eb9bb..1ccb850055 100755 --- a/tests/qemu-

Re: [PATCH 10/23] iotests/181: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/181 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181 index e317e63422..378c2899d1 100755 --- a/tests/qemu-iote

Re: [PATCH 08/23] iotests/143: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/143 | 6 +++--- tests/qemu-iotests/143.out | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919

Re: [PATCH 09/23] iotests/147: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/147 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147 index ab8480b9a4..03fc2fabcf 100755 --- a/tests/qemu-iote

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Eduardo Habkost
On Thu, Oct 10, 2019 at 05:57:54PM +0200, Igor Mammedov wrote: > On Thu, 10 Oct 2019 09:59:42 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote: > > > On Thu, 10 Oct 2019 05:56:55 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

[PULL 1/1] hw/vfio/pci: fix double free in vfio_msi_disable

2019-10-10 Thread Alex Williamson
From: Evgeny Yakovlev The following guest behaviour patter leads to double free in VFIO PCI: 1. Guest enables MSI interrupts vfio_msi_enable is called, but fails in vfio_enable_vectors. In our case this was because VFIO GPU device was in D3 state. Unhappy path in vfio_msi_enable will g_free(vdev

[PULL 0/1] vfio update 2019-10-10

2019-10-10 Thread Alex Williamson
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20191

Re: [PATCH 07/23] iotests/140: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/140 | 8 tests/qemu-iotests/140.out | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-

Re: [PATCH 06/23] iotests/083: Create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/083 | 6 +++--- tests/qemu-iotests/083.out | 34 +- 2 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software En

Re: [PATCH 05/23] iotests: Let common.nbd create socket in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: In addition, drop the nbd_unix_socket assignment in 241 because it does not really do anything. Agreed, it duplicates the setting inherited by sourcing common.nbd. Signed-off-by: Max Reitz --- tests/qemu-iotests/241| 2 -- tests/qemu-iotests

Re: [PATCH v3] migration: Support gtree migration

2019-10-10 Thread Dr. David Alan Gilbert
* Auger Eric (eric.au...@redhat.com) wrote: > Hi peter, > > On 10/10/19 2:35 PM, Peter Xu wrote: > > On Thu, Oct 10, 2019 at 02:11:46PM +0200, Auger Eric wrote: > > Also, should we avoid using UINT in all cases? But of course if we > > start to use VMSTATE_UINT32_V then we don't have this

Re: [PATCH v3] migration: Support gtree migration

2019-10-10 Thread Auger Eric
Hi peter, On 10/10/19 2:35 PM, Peter Xu wrote: > On Thu, Oct 10, 2019 at 02:11:46PM +0200, Auger Eric wrote: > Also, should we avoid using UINT in all cases? But of course if we > start to use VMSTATE_UINT32_V then we don't have this issue. Depending on the clarification of above poi

Re: [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-10-10 Thread John Snow
On 10/10/19 11:39 AM, Eric Blake wrote: > On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote: >> 07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: >>> qcow2_can_store_new_dirty_bitmap works wrong, as it considers only >>> bitmaps already stored in the qcow2 image and ignores persistent >>

Re: [PATCH 04/23] iotests: Filter $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 9f418b4881..cd42f5e7e3 100644 --- a/tests/

Re: [PATCH 03/23] iotests.py: Add @base_dir to FilePaths etc.

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Specifying this optional parameter allows creating temporary files in other directories than the test_dir; for example in sock_dir. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

Re: [PATCH 02/23] iotests.py: Store socket files in $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: iotests.py itself does not store socket files, but it machine.py and s/it // qtest.py do. iotests.py needs to pass the respective path to them, and they need to adhere to it. Signed-off-by: Max Reitz --- python/qemu/machine.py| 15 ++

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 05:57:54PM +0200, Igor Mammedov wrote: > > Then we should consider switching acpi to use fw cfg. > > Or build another interface that can scale. > > Could be an option, it would be a pain to write a driver in AML for fwcfg > access though > (I've looked at possibility to ac

Re: [PATCH 01/23] iotests: Introduce $SOCK_DIR

2019-10-10 Thread Eric Blake
On 10/10/19 10:24 AM, Max Reitz wrote: Unix sockets generally have a maximum path length. Depending on your $TEST_DIR, it may be exceeded and then all tests that create and use Unix sockets there may fail. Circumvent this by adding a new scratch directory specifically for Unix socket files. It

Re: [PATCH v3 3/3] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-10 Thread Eric Blake
On 10/10/19 6:05 AM, Peter Krempa wrote: In addition to Markus' review, 'savevm' was buggy as it considered all monitor-owned block device nodes for snapshot. With introduction of -blockdev the common usage made all With the introduction of -blockdev, the common usage nodes including protoc

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread John Snow
On 10/10/19 7:54 AM, Peter Krempa wrote: > On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote: >> On 10/10/19 1:26 PM, Peter Krempa wrote: >>> On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote: On 10/10/19 12:43 AM, John Snow wrote: > It's an old com

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote: > On 10/10/19 14:48, Igor Mammedov wrote: > > > it doesn't really matter if it's ACPI blob or fw_cfg, > > what firmware needs is a table of possible CPUs with APIC IDs. > > To repeat my previous point: > > Not necessarily taking sides

[RFC 2/2] virtio-net: use post load hook

2019-10-10 Thread Michael S. Tsirkin
Currently offloads disabled by guest via the VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET command are not preserved on VM migration. Instead all offloads reported by guest features (via VIRTIO_PCI_GUEST_FEATURES) get enabled. What happens is: first the VirtIONet::curr_guest_offloads gets restored and offload

[RFC 1/2] virtio: new post_load hook

2019-10-10 Thread Michael S. Tsirkin
Post load hook in virtio vmsd is called early while device is processed, and when VirtIODevice core isn't fully initialized. Most device specific code isn't ready to deal with a device in such state, and behaves weirdly. Add a new post_load hook in a device class instead. Devices should use this

[Bug 1811533] Re: Unstable Win10 guest with qemu 3.1 + huge pages + hv_stimer

2019-10-10 Thread Damir
Hi, This seems to have died out. How do we proceed to get this looked into by the correct people? Thanks, Damir -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811533 Title: Unstable Win10 guest w

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Laszlo Ersek
On 10/10/19 17:06, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: >> On 10/09/19 15:22, Igor Mammedov wrote: >>> Extend CPU hotplug interface to return architecture specific >>> identifier for current CPU (in case of x86, it's APIC ID). >>> >>> Signed-off-

Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 04:58:09PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Oct 10, 2019 at 02:11:15PM +0200, Mikhail Sennikovsky wrote: > > > Currently offloads disabled by guest via the > > > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > > > command

Re: Is network backend vde worth keeping? (was: Is network backend netmap worth keeping?)

2019-10-10 Thread Daniel P . Berrangé
On Mon, Oct 07, 2019 at 08:21:14PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Please excuse the attention-grabbing subject. > > Again. > > [...] > > So, to make use of QEMU's netmap backend (CONFIG_NETMAP), you have to > > build and install netmap software from sources.

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-10 Thread Igor Mammedov
On Tue, 8 Oct 2019 07:33:15 -0400 Igor Mammedov wrote: > > Series cleans up remaining boards that call > memory_region_allocate_system_memory() > multiple times, violating interface contract (the function should be called > only > once). > > With that cleaned up, it should be possible to swi

Re: [PATCH v2] target/arm/arch_dump: Add SVE notes

2019-10-10 Thread Richard Henderson
On 10/10/19 2:16 AM, Andrew Jones wrote: >> It might be best to avoid the ifdef altogether: >> >> for (i = 0; i < 32; ++i) { >> uint64_t *d = (uint64_t *)&buf[sve_zreg_offset(vq, i)]; >> for (j = 0; j < vq * 2; ++j) { >> d[j] = cpu_to_le64(env->vfp.zregs[i].d[j]); >>

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 11:06:29 -0400 "Michael S. Tsirkin" wrote: > On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: > > On 10/09/19 15:22, Igor Mammedov wrote: > > > Extend CPU hotplug interface to return architecture specific > > > identifier for current CPU (in case of x86, it's APIC

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 11:16:52 -0300 Eduardo Habkost wrote: > On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote: > > On Thu, 10 Oct 2019 05:56:55 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Oct 09, 2019 at 09:22:49AM -0400, Igor Mammedov wrote: > > > > As an alternative to

Re: Is network backend vde worth keeping? (was: Is network backend netmap worth keeping?)

2019-10-10 Thread Julia Suvorova
On Mon, Oct 7, 2019 at 8:23 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > Please excuse the attention-grabbing subject. > > Again. > > [...] > > So, to make use of QEMU's netmap backend (CONFIG_NETMAP), you have to > > build and install netmap software from sources. Which prett

Re: [PATCH 2/2] iotests: Test large write request to qcow2 file

2019-10-10 Thread Eric Blake
On 10/10/19 5:08 AM, Max Reitz wrote: Without HEAD^, the following happens when you attempt a large write request to a qcow2 file such that the number of bytes covered by all clusters involved in a single allocation will exceed INT_MAX: (A) handle_alloc_space() decides to fill the whole area wit

Re: [PATCH] trace: avoid "is" with a literal Python 3.8 warnings

2019-10-10 Thread Stefan Hajnoczi
On Thu, Oct 10, 2019 at 01:21:54PM +0100, Stefan Hajnoczi wrote: > The following statement produces a SyntaxWarning with Python 3.8: > > if len(format) is 0: > scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did > you mean "=="? > > Use the conventional len(x) == 0 syn

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Laszlo Ersek
On 10/10/19 14:48, Igor Mammedov wrote: > it doesn't really matter if it's ACPI blob or fw_cfg, > what firmware needs is a table of possible CPUs with APIC IDs. To repeat my previous point: Not necessarily taking sides between "data table" and "register block", but *if* we opt for "data table",

Re: [PATCH v25 00/22] Add RX archtecture support

2019-10-10 Thread Philippe Mathieu-Daudé
On 9/27/19 8:22 AM, Yoshinori Sato wrote: Hello. This patch series is added Renesas RX target emulation. This series looks ready to get merged. Note to the maintainer merging it, various Signed-off-by are misplaced and the Message-Id tags should be removed. Regards, Phil.

Re: [PATCH v25 06/22] target/rx: CPU definition

2019-10-10 Thread Philippe Mathieu-Daudé
On 9/27/19 8:22 AM, Yoshinori Sato wrote: v21 changes Add cpu-param.h Remove CPU_COMMON rx_load_image move to rx-virt. remove rx_load_image ^ We can strip these lines, which are specific to a patchset version. Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-4-ys...@users.sou

[PATCH 3/7] libqos: pass full QVirtQueue to set_queue_address()

2019-10-10 Thread Stefan Hajnoczi
Instead of just passing the vring page frame number, pass the full QVirtQueue. This will allow the VIRTIO 1.0 transport to program the fine-grained vring address registers in the future. Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio.h | 2 +- tests/libqos/virtio-mmio.c | 6 --

[PATCH 2/7] libqos: add iteration support to qpci_find_capability()

2019-10-10 Thread Stefan Hajnoczi
VIRTIO 1.0 PCI devices have multiple PCI_CAP_ID_VNDR capabilities so we need a way to iterate over them. Extend qpci_find_capability() to take the last address. Signed-off-by: Stefan Hajnoczi --- tests/libqos/pci.h | 2 +- tests/libqos/pci.c | 18 -- 2 files changed, 13 inserti

[PATCH 1/7] libqos: extract Legacy virtio-pci.c code

2019-10-10 Thread Stefan Hajnoczi
The current libqos virtio-pci.c code implements the VIRTIO Legacy interface. Extract existing code in preparation for VIRTIO 1.0 support. Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio-pci.h | 2 -- tests/libqos/virtio-pci.c | 25 ++--- 2 files changed, 10 insertion

[PATCH 6/7] libqos: make the virtio-pci BAR index configurable

2019-10-10 Thread Stefan Hajnoczi
The Legacy virtio-pci interface always uses BAR 0. VIRTIO 1.0 may need to use a different BAR index, so make it configurable. Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio-pci.h | 2 ++ tests/libqos/virtio-pci.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tes

[PATCH 0/7] libqos: add VIRTIO PCI 1.0 support

2019-10-10 Thread Stefan Hajnoczi
New VIRTIO devices are Non-Transitional. This means they only expose the VIRTIO 1.0 PCI register interface. The libqos virtio-pci.c code only supports Legacy and Transitional devices (in Legacy mode). This patch series add VIRTIO PCI 1.0 support so that tests can run against Non-Transitional dev

Re: Problems with c8bb23cbdbe3 on ppc64le

2019-10-10 Thread Anton Nefedov
On 10/10/2019 6:17 PM, Max Reitz wrote: > Hi everyone, > > (CCs just based on tags in the commit in question) > > I have two bug reports which claim problems of qcow2 on XFS on ppc64le > machines since qemu 4.1.0. One of those is about bad performance > (sorry, is isn’t public :-/), the other ab

Re: [PATCH v25 22/22] qapi/machine.json: Add RX cpu.

2019-10-10 Thread Philippe Mathieu-Daudé
The subject should be "Add RX architecture" but anyway this patch has to be squashed in patch #20 "Add rx-softmmu" On 9/27/19 8:23 AM, Yoshinori Sato wrote: Signed-off-by: Yoshinori Sato --- qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/machine

[PATCH 4/7] libqos: add MSI-X callbacks to QVirtioPCIDevice

2019-10-10 Thread Stefan Hajnoczi
The MSI-X vectors are programmed differently in the VIRTIO 1.0 and Legacy interfaces. Introduce callbacks so different implementations can be used depending on the interface version. Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio-pci.h | 12 tests/libqos/virtio-pci.c | 36 +

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Laszlo Ersek
On 10/10/19 12:01, Michael S. Tsirkin wrote: > On Tue, Oct 08, 2019 at 05:59:31PM +0200, Igor Mammedov wrote: >> So far there were no need for it as all possible cpus are >> described in ACPI tables passed to guest, but I'm not going >> to suggest to parse them on firmware side as it's too complic

Re: [PATCH v3] virtio-net: prevent offloads reset on migration

2019-10-10 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Oct 10, 2019 at 02:11:15PM +0200, Mikhail Sennikovsky wrote: > > Currently offloads disabled by guest via the > > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > > command are not preserved on VM migration. > > Instead all offloads reported by guest fea

Re: [PATCH v25 17/22] hw/rx: RX Target hardware definition

2019-10-10 Thread Philippe Mathieu-Daudé
On 9/27/19 8:22 AM, Yoshinori Sato wrote: rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. We can strip this... : v23 changes. Add missing includes. v21 changes. rx_load_image move to rx-virt.c ... until here. Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-17-ys..

Re: [PATCH V4] block/vhdx: add check for truncated image files

2019-10-10 Thread Kevin Wolf
Am 10.09.2019 um 17:26 hat Peter Lieven geschrieben: > qemu is currently not able to detect truncated vhdx image files. > Add a basic check if all allocated blocks are reachable at open and > report all errors during bdrv_co_check. > > Signed-off-by: Peter Lieven Thanks, applied to the block bra

  1   2   3   4   >