Re: [PATCH v4 0/7] iotests: Selfish patches

2019-10-14 Thread Andrey Shinkevich
On 14/10/2019 17:59, Max Reitz wrote: > On 17.09.19 11:19, Max Reitz wrote: >> Hi, >> >> Again, let me start with a link to an actually explanatory cover letter: >> https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg01102.html >> >> v3: >>

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-10-14 Thread Tao Xu
On 10/15/2019 8:59 AM, Tao Xu wrote: On 10/14/2019 5:00 PM, Igor Mammedov wrote: On Sat, 12 Oct 2019 11:04:03 +0800 Tao Xu wrote: On 10/11/2019 10:08 PM, Igor Mammedov wrote: On Thu, 10 Oct 2019 14:53:56 +0800 Tao Xu wrote: On 10/3/2019 10:41 PM, Igor Mammedov wrote: On Fri, 20 Sep 2019

Re: [PATCH for 4.2 v5 00/55] Support for TCG plugins

2019-10-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191014104948.4291-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 4.2 v5 00/55] Support for TCG plugins Type: series Message-id:

Re: [PATCH v1 3/5] contrib/gitdm: add Andrey to the individual group

2019-10-14 Thread Andrey Smirnov
On Mon, Oct 14, 2019 at 6:59 AM Alex Bennée wrote: > > Please confirm this is the correct section for you. > I think this is. Here's Acked-by: Andrey Smirnov in case that's needed. > Signed-off-by: Alex Bennée > Cc: Andrey Smirnov > --- > contrib/gitdm/group-map-individuals | 1 + > 1

[PATCH 1/2] tests/tcg/multiarch: fix code style in function main of test-mmap.c

2019-10-14 Thread Wei Yang
This file uses quite a different code style and changing just one line would leads to some awkward appearance. This is a preparation for the following replacement of sysconf(_SC_PAGESIZE). BTW, to depress ERROR message from checkpatch.pl, this patch replaces strtoul with qemu_strtoul.

[PATCH 2/2] core: replace sysconf(_SC_PAGESIZE) with qemu_real_host_page_size

2019-10-14 Thread Wei Yang
Signed-off-by: Wei Yang Suggested-by: "Dr. David Alan Gilbert" CC: Richard Henderson --- block/file-posix.c | 2 +- net/l2tpv3.c| 2 +- tests/tcg/multiarch/test-mmap.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/file-posix.c

[PATCH 0/2] replace sysconf(_SC_PAGESIZE) with qemu_real_host_page_size

2019-10-14 Thread Wei Yang
This is a following up patch to cleanup page size, suggested by "Dr. David Alan Gilbert" . Patch 2 does the job, while during the cleanup I found test-mmap.c has quite a lot code style problem. To make the code looks good, patch 1 is introduced to make checkpatch.pl happy a little. Wei Yang (2):

Re: Using virtual IOMMU in guest hypervisors other than KVM and Xen?

2019-10-14 Thread Peter Xu
On Mon, Oct 14, 2019 at 01:28:49PM -0700, Jintack Lim wrote: > Hi, Hello, Jintack, > > I'm trying to pass through a physical network device to a nested VM > using virtual IOMMU. While I was able to do it successfully using KVM > and Xen guest hypervisors running in a VM respectively, I couldn't

Re: [PATCH v1 5/5] contrib/gitdm: add China Mobile to the domain map

2019-10-14 Thread maozy
On 10/14/19 9:59 PM, Alex Bennée wrote: We've had a number of contributions from this domain. I think they are from the company rather than customers using the email address but it's hard for me to tell. Please confirm. Acked-by: Mao Zhongyi Signed-off-by: Alex Bennée Cc: Mao Zhongyi

[PATCH] tcg/arm: Expand epilogue inline

2019-10-14 Thread Richard Henderson
It is, after all, just two instructions. Profiling on a cortex-a15, using -d nochain to increase the number of exit_tb that are executed, shows a minor improvement of 0.5%. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 32 +--- 1 file changed, 13

Re: [PATCH v1 5/5] contrib/gitdm: add China Mobile to the domain map

2019-10-14 Thread maozy
Hi, Alex On 10/14/19 9:59 PM, Alex Bennée wrote: We've had a number of contributions from this domain. I think they are from the company rather than customers using the email address but it's hard for me to tell. Please confirm. Yes, this domain comes from a china company, not an individual,

Re: [PATCH v2] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

2019-10-14 Thread Hikaru Nishida
> I think we don't need to mark this 'volatile sig_atomic_t', > but could use a simple 'bool', because both applicationDidFinishLaunching() > and handleEvent() are called from the same thread (the OSX run loop > thread). Oh, I didn't notice that. I replaced 'volatile sig_atomic_t' with 'static

[PATCH v3] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

2019-10-14 Thread hikarupsp
From: Hikaru Nishida macOS API documentation says that before applicationDidFinishLaunching is called, any events will not be processed. However, some events are fired before it is called in macOS Catalina. This causes deadlock of iothread_lock in handleEvent while it will be released after the

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-10-14 Thread Tao Xu
On 10/14/2019 5:00 PM, Igor Mammedov wrote: On Sat, 12 Oct 2019 11:04:03 +0800 Tao Xu wrote: On 10/11/2019 10:08 PM, Igor Mammedov wrote: On Thu, 10 Oct 2019 14:53:56 +0800 Tao Xu wrote: On 10/3/2019 10:41 PM, Igor Mammedov wrote: On Fri, 20 Sep 2019 15:43:47 +0800 Tao Xu wrote:

Re: [PATCH] linux-user/riscv: Propagate fault address

2019-10-14 Thread Palmer Dabbelt
On Tue, 01 Oct 2019 09:39:52 PDT (-0700), thatle...@gmail.com wrote: The CPU loop tagged all the queued signals as QEMU_SI_KILL while it was filling the `_sigfault` part of `siginfo`: this caused QEMU to copy the wrong fields over to the userspace program. Make sure the fault address recorded

Re: RFC: Why dont we move to newer capstone?

2019-10-14 Thread Richard Henderson
On 10/5/19 3:11 AM, Lucien Murray-Pitts wrote: > Hi folks, > > Whilst working on a m68k patch I noticed that the capstone in use today (3.0) > doesnt support the M68K and thus a hand turned disasm function is used.   > > The newer capstone (5.0) appears to support a few more CPU, inc. m68k. I

Re: [PATCH] target/arm: Fix sign-extension for SMLAL*

2019-10-14 Thread Richard Henderson
Ping. On 9/12/19 11:30 AM, Richard Henderson wrote: > The 32-bit product should be sign-extended, not zero-extended. > > Fixes: ea96b374641b > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH 2/2] core: replace getpagesize() with qemu_real_host_page_size

2019-10-14 Thread Richard Henderson
On 10/14/19 2:36 PM, Wei Yang wrote: > On Mon, Oct 14, 2019 at 10:15:02AM +0100, Dr. David Alan Gilbert wrote: >> We also use sysconf(_SC_PAGESIZE) in a few places. > > You mean need to replace them too? I would say so, as a separate patch. r~

Re: [PATCH V6] target/riscv: Ignore reserved bits in PTE for RV64

2019-10-14 Thread Alistair Francis
On Sat, Oct 12, 2019 at 10:33 AM Palmer Dabbelt wrote: > > On Wed, 25 Sep 2019 17:14:21 PDT (-0700), guo...@kernel.org wrote: > > From: Guo Ren > > > > Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we > > need to ignore them. They cannot be a part of ppn. > > > > 1: The

Re: ACPI table modifications

2019-10-14 Thread Corey Minyard
On Fri, Oct 11, 2019 at 09:22:19PM +0200, Philippe Mathieu-Daudé wrote: > Hi Gautam, > > On 10/11/19 8:47 PM, Gautam Bhat wrote: > > Hi, > > > > I want to add some I2C based temperature sensors to the -M Q35 machine. > > I want to update the ACPI tables to add this device information. How can >

Re: [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr

2019-10-14 Thread Wei Yang
On Mon, Oct 14, 2019 at 12:05:47PM -0300, Eduardo Habkost wrote: >On Sat, Oct 12, 2019 at 05:02:09PM +0800, Wei Yang wrote: >> On Sat, Sep 14, 2019 at 03:40:41PM -0400, Michael S. Tsirkin wrote: >> >On Fri, Sep 13, 2019 at 11:47:46PM +, Wei Yang wrote: >> >> On Tue, Jul 30, 2019 at 08:37:38AM

Re: [PATCH 0/2] cleanup on page size

2019-10-14 Thread Wei Yang
Hi, All, I got one page size related question, hope to get some hint. There is one comment in page_size_init(). /* NOTE: we can always suppose that qemu_host_page_size >= TARGET_PAGE_SIZE */ The final result is true, since we compare qemu_host_page_size with TARGET_PAGE_SIZE and if

Re: [PATCH 2/2] core: replace getpagesize() with qemu_real_host_page_size

2019-10-14 Thread Wei Yang
On Mon, Oct 14, 2019 at 10:15:02AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> There are three page size in qemu: >> >> real host page size >> host page size >> target page size >> >> All of them have dedicate variable to represent. For the

Using virtual IOMMU in guest hypervisors other than KVM and Xen?

2019-10-14 Thread Jintack Lim
Hi, I'm trying to pass through a physical network device to a nested VM using virtual IOMMU. While I was able to do it successfully using KVM and Xen guest hypervisors running in a VM respectively, I couldn't do it with Hyper-V as I described below. I wonder if anyone have successfully used

[PULL v2 13/19] block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy The function is unused, drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20190927122355.7344-6-vsement...@virtuozzo.com Signed-off-by: John Snow --- block/qcow2.h| 2 -- block/qcow2-bitmap.c | 15

[PULL v2 12/19] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Firstly, no reason to optimize failure path. Then, function name is ambiguous: it checks for readonly and similar things, but someone may think that it will ignore normal bitmaps which was just unchanged, and this is in bad relation with the fact that we should

[PULL v2 19/19] dirty-bitmaps: remove deprecated autoload parameter

2019-10-14 Thread John Snow
This parameter has been deprecated since 2.12.0 and is eligible for removal. Remove this parameter as it is actually completely ignored; let's not give false hope. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-id:

[PULL v2 11/19] iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Reopening bitmaps to RW was broken prior to previous commit. Check that it works now. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20190927122355.7344-4-vsement...@virtuozzo.com Signed-off-by: John Snow --- tests/qemu-iotests/165 | 57

[PULL v2 14/19] block/qcow2-bitmap: do not remove bitmaps on reopen-ro

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all readonly. But the latter don't work, as qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing. It's OK for inactivation but bad idea for reopen-ro. And this leads to the

[PULL v2 18/19] MAINTAINERS: Add Vladimir as a reviewer for bitmaps

2019-10-14 Thread John Snow
I already try to make sure all bitmaps patches have been reviewed by both Red Hat and Virtuozzo anyway, so this formalizes the arrangement. Fam meanwhile is no longer as active, so I am removing him as a co-maintainer simply to reflect the current practice. Signed-off-by: John Snow Reviewed-by:

[PULL v2 17/19] qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy The only reason I can imagine for this strange code at the very-end of bdrv_reopen_commit is the fact that bs->read_only updated after calling drv->bdrv_reopen_commit in bdrv_reopen_commit. And in the same time, prior to previous commit, qcow2_reopen_bitmaps_rw

[PULL v2 10/19] block: reverse order for reopen commits

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy It's needed to fix reopening qcow2 with bitmaps to RW. Currently it can't work, as qcow2 needs write access to file child, to mark bitmaps in-image with IN_USE flag. But usually children goes after parents in reopen queue and file child is still RO on qcow2

[PULL v2 07/19] block/dirty-bitmap: drop BdrvDirtyBitmap.mutex

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy mutex field is just a pointer to bs->dirty_bitmap_mutex, so no needs to store it in BdrvDirtyBitmap when we have bs pointer in it (since previous patch). Drop mutex field. Constantly use bdrv_dirty_bitmaps_lock/unlock in block/dirty-bitmap.c to make it more

[PULL v2 15/19] iotests: add test 260 to check bitmap life after snapshot + commit

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20190927122355.7344-8-vsement...@virtuozzo.com Signed-off-by: John Snow --- tests/qemu-iotests/260 | 89 ++ tests/qemu-iotests/260.out | 52 ++

[PULL v2 09/19] block: switch reopen queue from QSIMPLEQ to QTAILQ

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy We'll need reverse-foreach in the following commit, QTAILQ support it, so move to QTAILQ. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190927122355.7344-2-vsement...@virtuozzo.com Signed-off-by: John Snow ---

[PULL v2 08/19] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy bdrv_dirty_bitmap_next is always used in same pattern. So, split it into _next and _first, instead of combining two functions into one and add FOR_EACH_DIRTY_BITMAP macro. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id:

[PULL v2 16/19] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy - Correct check for write access to file child, and in correct place (only if we want to write). - Support reopen rw -> rw (which will be used in following commit), for example, !bdrv_dirty_bitmap_readonly() is not a corruption if bitmap is marked IN_USE

[PULL v2 05/19] block/dirty-bitmap: drop meta

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Drop meta bitmaps, as they are unused. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20190916141911.5255-2-vsement...@virtuozzo.com Signed-off-by: John Snow --- include/block/dirty-bitmap.h | 5 block/dirty-bitmap.c

[PULL v2 01/19] util/hbitmap: strict hbitmap_reset

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy hbitmap_reset has an unobvious property: it rounds requested region up. It may provoke bugs, like in recently fixed write-blocking mode of mirror: user calls reset on unaligned region, not keeping in mind that there are possible unrelated dirty bytes, covered

[PULL v2 06/19] block/dirty-bitmap: add bs link

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Add bs field to BdrvDirtyBitmap structure. Drop BlockDriverState parameter from bitmap APIs where possible. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20190916141911.5255-3-vsement...@virtuozzo.com [Rebased on top of

[PULL v2 04/19] block/qcow2: proper locking on bitmap add/remove paths

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy qmp_block_dirty_bitmap_add and do_block_dirty_bitmap_remove do acquire aio context since 0a6c86d024c52b. But this is not enough: we also must lock qcow2 mutex when access in-image metadata. Especially it concerns freeing qcow2 clusters. To achieve this, move

[PULL v2 03/19] block/dirty-bitmap: return int from bdrv_remove_persistent_dirty_bitmap

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy It's more comfortable to not deal with local_err. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20190920082543.23444-3-vsement...@virtuozzo.com Signed-off-by: John Snow --- block/qcow2.h| 5 ++---

[PULL v2 00/19] Bitmaps patches

2019-10-14 Thread John Snow
The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 16:09:52 +0100) are available in the Git repository at: https://github.com/jnsnow/qemu.git

[PULL v2 02/19] block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c

2019-10-14 Thread John Snow
From: Vladimir Sementsov-Ogievskiy block/dirty-bitmap.c seems to be more appropriate for it and bdrv_remove_persistent_dirty_bitmap already in it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20190920082543.23444-2-vsement...@virtuozzo.com Signed-off-by: John

Re: [PATCH v6 18/20] target/arm: Rebuild hflags at CPSR writes

2019-10-14 Thread Richard Henderson
On 10/14/19 12:08 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> Continue setting, but not relying upon, env->hflags. >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/op_helper.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/target/arm/op_helper.c

Re: [PATCH v6 19/20] target/arm: Rebuild hflags for M-profile.

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Continue setting, but not relying upon, env->hflags. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/m_helper.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c > index

Re: [PATCH v6 18/20] target/arm: Rebuild hflags at CPSR writes

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Continue setting, but not relying upon, env->hflags. > > Signed-off-by: Richard Henderson > --- > target/arm/op_helper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c > index ccc2cecb46..b529d6c1bf

Re: [PATCH v6 17/20] target/arm: Rebuild hflags at MSR writes

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Continue setting, but not relying upon, env->hflags. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 13 +++-- > target/arm/translate.c | 28 +++- > 2 files changed, 34

Re: [PATCH v6 16/20] target/arm: Rebuild hflags at EL changes

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Begin setting, but not relying upon, env->hflags. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > linux-user/syscall.c| 1 + > target/arm/cpu.c| 1 + > target/arm/helper-a64.c | 3 +++ > target/arm/helper.c | 2 ++ >

Re: [PATCH v6 15/20] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32})

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > This functions are given the mode and el state of the cpu > and writes the computed value to env->hflags. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.h | 4 > target/arm/helper.c | 24 >

Re: [PATCH v6 14/20] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > By performing this store early, we avoid having to save and restore > the register holding the address around any function calls. Been peeking at the assembly again ;-) > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.c

Re: [PATCH v6 13/20] target/arm: Split out arm_mmu_idx_el

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Avoid calling arm_current_el() twice. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/internals.h | 9 + > target/arm/helper.c| 12 +++- > 2 files changed, 16

Re: [PATCH v6 12/20] target/arm: Add arm_rebuild_hflags

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > This function assumes nothing about the current state of the cpu, > and writes the computed value to env->hflags. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/cpu.h| 6 ++ > target/arm/helper.c | 30

Re: [PATCH v6 11/20] target/arm: Hoist computation of TBFLAG_A32.VFPEN

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > There are 3 conditions that each enable this flag. M-profile always > enables; A-profile with EL1 as AA64 always enables. Both of these > conditions can easily be cached. The final condition relies on the > FPEXC register which we are not prepared to cache. > >

[PATCH v3 3/3] spapr: Add Hcalls to support PAPR NVDIMM device

2019-10-14 Thread Shivaprasad G Bhat
This patch implements few of the necessary hcalls for the nvdimm support. PAPR semantics is such that each NVDIMM device is comprising of multiple SCM(Storage Class Memory) blocks. The guest requests the hypervisor to bind each of the SCM blocks of the NVDIMM device using hcalls. There can be SCM

[PATCH v3 2/3] spapr: Add NVDIMM device support

2019-10-14 Thread Shivaprasad G Bhat
Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm device interface in QEMU to support virtual NVDIMM devices for Power. Create the required DT entries for the device (some entries have dummy values right now). The patch creates the required DT node and sends a hotplug

[PATCH v3 1/3] mem: move nvdimm_device_list to utilities

2019-10-14 Thread Shivaprasad G Bhat
nvdimm_device_list is required for parsing the list for devices in subsequent patches. Move it to common utility area. Signed-off-by: Shivaprasad G Bhat --- hw/acpi/nvdimm.c| 28 +--- include/qemu/nvdimm-utils.h |7 +++ util/Makefile.objs |

[PATCH v3 0/3] ppc: spapr: virtual NVDIMM support

2019-10-14 Thread Shivaprasad G Bhat
The patchset attempts to implement the virtual NVDIMM for pseries. PAPR semantics is such that each NVDIMM device is comprising of multiple SCM(Storage Class Memory) blocks. The hypervisor is expected to prepare the FDT for the NVDIMM device and send guest a hotplug interrupt with new type

Re: [PATCH v26 00/21] Add RX archtecture support

2019-10-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191014115757.51866-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v26 00/21] Add RX archtecture support Type: series Message-id:

Re: [PATCH v6 10/20] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Hoist the variable load for PSTATE into the existing test vs is_a64. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git

Re: [PULL 01/19] util/hbitmap: strict hbitmap_reset

2019-10-14 Thread John Snow
On 10/11/19 7:18 PM, John Snow wrote: > > > On 10/11/19 5:48 PM, Eric Blake wrote: >> On 10/11/19 4:25 PM, John Snow wrote: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> hbitmap_reset has an unobvious property: it rounds requested region up. >>> It may provoke bugs, like in recently fixed

Re: [PATCH v4 2/3] target/riscv: Expose "priv" register for GDB for reads

2019-10-14 Thread Alistair Francis
On Mon, Oct 14, 2019 at 8:50 AM Jonathan Behrens wrote: > > This patch enables a debugger to read the current privilege level via a > virtual > "priv" register. When compiled with CONFIG_USER_ONLY the register is still > visible but always reports the value zero. > > Signed-off-by: Jonathan

[Bug 1847906] Re: Cocoa display hangs on macOS 10.15 (Catalina)

2019-10-14 Thread Shachar Itzhaky
This is wonderful! Thank you Peter and Hikaru for this patch. I will try it ASAP and confirm. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847906 Title: Cocoa display hangs on macOS 10.15

Re: [PATCH v5 31/55] target/riscv: fetch code with translator_ld

2019-10-14 Thread Alistair Francis
On Mon, Oct 14, 2019 at 4:20 AM Alex Bennée wrote: > > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > Reviewed-by: Richard Henderson > Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c | 2 +- > 1 file changed, 1 insertion(+),

[Bug 1847906] Re: Cocoa display hangs on macOS 10.15 (Catalina)

2019-10-14 Thread Peter Maydell
Hikaru Nishida kindly wrote a patch which should fix this: https://patchew.org/QEMU/20191014141608.80923-1-hikaru...@gmail.com/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847906 Title: Cocoa

[Bug 1847906] Re: Cocoa display hangs on macOS 10.15 (Catalina)

2019-10-14 Thread Shachar Itzhaky
Yes, works perfectly! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847906 Title: Cocoa display hangs on macOS 10.15 (Catalina) Status in QEMU: New Bug description: I have downloaded the

Re: [PATCH] virito: Use auto rcu_read macros

2019-10-14 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD > to replace the manual rcu_read_(un)lock calls. > > I think the only change is virtio_load which was missing unlocks > in error paths; those end

Re: [PATCH v2] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

2019-10-14 Thread Peter Maydell
On Mon, 14 Oct 2019 at 15:16, wrote: > > From: Hikaru Nishida > > macOS API documentation says that before applicationDidFinishLaunching > is called, any events will not be processed. However, some events are > fired before it is called in macOS Catalina. This causes deadlock of > iothread_lock

[PATCH] virito: Use auto rcu_read macros

2019-10-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD to replace the manual rcu_read_(un)lock calls. I think the only change is virtio_load which was missing unlocks in error paths; those end up being fatal errors so it's not that important anyway. Signed-off-by:

Re: [PATCH 00/20] hw: Clean up hw/i386 headers (and few alpha/hppa)

2019-10-14 Thread John Snow
On 10/14/19 10:22 AM, Philippe Mathieu-Daudé wrote: > This is a follow-up of Markus's cleanup series: > Tame a few "touch this, recompile the world" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html > > This part is mostly restricted to X86, but since some file from the >

Re: [PATCH v5 54/55] plugins: add qemu_plugin_outs and use it

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > Having the plugins grab stdout and spew stuff there is a bit ugly and > certainly makes the tests look ugly. Provide a hook back into QEMU > which can be redirected as needed. > > For the newer plugins that use GString already this falls out pretty >

Re: [PATCH v5 52/55] plugins: make howvec plugin more generic

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > @@ -190,14 +211,18 @@ static uint64_t * find_counter(struct qemu_plugin_insn > *insn) > uint32_t opcode; > InsnClassExecCount *class = NULL; > > -/* we expect all instructions to by 32 bits for ARM */ > -

Re: [PATCH v5 48/55] tests/plugin: add hotpages plugin to breakdown memory access patterns

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > This plugin gives a break down of access patterns grouped into pages. > > Signed-off-by: Alex Bennée > > --- > v4 >- tweaks for new hwaddr api >- add sorting and pagesize selection args > --- > tests/plugin/Makefile | 1 + >

Re: [PATCH v5 47/55] tests/plugin: add instruction execution breakdown

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > This gives a break down of instruction classes and individual > instruction types. > > Signed-off-by: Alex Bennée > > --- > v5 > - add a bitmap guide to the comment ;-) > --- Reviewed-by: Richard Henderson r~

[PATCH v32 11/13] target/avr: Add example board configuration

2019-10-14 Thread Michael Rolnik
A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this is not a real board NOTE: it's used for CPU testing Signed-off-by: Michael

Re: [PATCH] sphinx: Use separate doctree directories for different builders

2019-10-14 Thread John Snow
On 10/14/19 11:01 AM, Eduardo Habkost wrote: > sphinx-build is buggy when multiple processes are using the same > doctree directory in parallel. See the 3-year-old Sphinx bug > report at: https://github.com/sphinx-doc/sphinx/issues/2946 > > Instead of avoiding parallel builds or adding some

Re: [PATCH v6 09/20] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > We do not need to compute any of these values for M-profile. > Further, XSCALE_CPAR overlaps VECSTRIDE so obviously the two > sets must be mutually exclusive. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 21

[PATCH v32 08/13] target/avr: Add instruction translation - MCU Control Instructions

2019-10-14 Thread Michael Rolnik
This includes: - BREAK - NOP - SLEEP - WDR Signed-off-by: Michael Rolnik --- target/avr/translate.c | 174 + 1 file changed, 174 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index 19540634df..21ba6004ee

Re: [PATCH v5 52/55] plugins: make howvec plugin more generic

2019-10-14 Thread Richard Henderson
On 10/14/19 10:14 AM, Alex Bennée wrote: >>> -/* we expect all instructions to by 32 bits for ARM */ >>> -g_assert(qemu_plugin_insn_size(insn) == 4); >>> +/* >>> + * We only match the first 32 bits of the instruction which is >>> + * fine for most RISCs but a bit limiting for

Re: [PATCH 1/2] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN

2019-10-14 Thread Juan Quintela
Wei Yang wrote: > Use ROUND_UP() to define, which is a little bit easy to read. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela

[PATCH v32 05/13] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2019-10-14 Thread Michael Rolnik
This includes: - ADD, ADC, ADIW Signed-off-by: Michael Rolnik --- target/avr/translate.c | 811 + 1 file changed, 811 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index 53c9892a60..3eaa3e5099 100644 ---

[PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

2019-10-14 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target/avr/translate.c | 132 + 1 file changed, 132 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c b/target/avr/translate.c new file mode 100644 index 00..53c9892a60

Re: [PATCH v6 08/20] target/arm: Split out rebuild_hflags_aprofile

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Create a function to compute the values of the TBFLAG_ANY bits > that will be cached, and are used by A-profile. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 20 > 1 file changed, 12

[PATCH v32 00/13] QEMU AVR 8 bit cores

2019-10-14 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support

[PATCH v32 12/13] target/avr: Register AVR support with the rest of QEMU, the build system, and the WMAINTAINERS file

2019-10-14 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 9 + arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6 ++ include/sysemu/arch_init.h | 1 +

[PATCH v32 13/13] target/avr: Add tests

2019-10-14 Thread Michael Rolnik
1. Avocado test The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working 2. Boot serial test Print out 'T' through

Re: [PATCH v6 07/20] target/arm: Split out rebuild_hflags_a32

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > Currently a trivial wrapper for rebuild_hflags_common_32. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/target/arm/helper.c

Re: [PATCH v5 23/55] translator: add translator_ld{ub,sw,uw,l,q}

2019-10-14 Thread Peter Maydell
On Mon, 14 Oct 2019 at 12:38, Alex Bennée wrote: > > From: "Emilio G. Cota" > > We don't bother with replicating the fast path (tlb_hit) of the old > cpu_ldst helpers as it has no measurable effect on performance. This > probably indicates we should consider flattening the whole set of > helpers

Re: [PATCH v5 55/55] .travis.yml: add --enable-plugins tests

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > check-tcg will automatically run the plugins against most TCG tests if > it is enabled in the build. We exclude sparc64-linux-user for now as > there are pending patches that need to be merged fixing it's fork > implementation. > > Signed-off-by: Alex

Re: [PATCH v5 41/55] tests/tcg: set QEMU_OPTS for all cris runs

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > This will important for ensuring the plugin test variants will also > work. > > Signed-off-by: Alex Bennée > --- > tests/tcg/cris/Makefile.target | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

[PATCH v32 07/13] target/avr: Add instruction translation - Bit and Bit-test Instructions

2019-10-14 Thread Michael Rolnik
This includes: - LSR, ROR - ASR - SWAP - SBI, CBI - BST, BLD - BSET, BCLR Signed-off-by: Michael Rolnik --- target/avr/translate.c | 1123 1 file changed, 1123 insertions(+) diff --git a/target/avr/translate.c

Re: [PATCH 02/20] hw/southbridge/ich9: Removed unused headers

2019-10-14 Thread John Snow
On 10/14/19 10:22 AM, Philippe Mathieu-Daudé wrote: > The ICH9 chipset is not X86/PC specific. > > These files don't use anything declared by the "hw/i386/pc.h" > or "hw/i386/ioapic.h" headers. Remove them. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: John Snow > --- >

[PATCH v32 03/13] target/avr: Add instruction decoding

2019-10-14 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git

Re: [PATCH v5 52/55] plugins: make howvec plugin more generic

2019-10-14 Thread Alex Bennée
Richard Henderson writes: > On 10/14/19 3:49 AM, Alex Bennée wrote: >> @@ -190,14 +211,18 @@ static uint64_t * find_counter(struct qemu_plugin_insn >> *insn) >> uint32_t opcode; >> InsnClassExecCount *class = NULL; >> >> -/* we expect all instructions to by 32 bits for ARM */ >>

Re: [PULL 00/19] Bitmaps patches

2019-10-14 Thread Peter Maydell
On Fri, 11 Oct 2019 at 22:26, John Snow wrote: > > The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-10-08 16:08:35 +0100) > > are available in the Git repository at: > >

Re: [PATCH v5 53/55] plugins: add sparc64 instruction classification table

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > +InsnClassExecCount sparc32_insn_classes[] = { > +{ "Call","call", 0xc000, 0x4000, COUNT_CLASS}, > +{ "Branch ICond","bcc",0xc1c0, 0x0080, COUNT_CLASS}, > +{ "Branch Fcond","fbcc",

Re: Occasional VM soft lockup when a remote cdrom is attached

2019-10-14 Thread John Snow
On 10/13/19 10:04 PM, Guoheyi wrote: > Really appreciate your advice. Some comments below: > > > On 2019/10/12 3:06, John Snow wrote: >> >> On 10/11/19 9:22 AM, Guoheyi wrote: >>> Hi folks, >>> >>> We observed Linux on VM occasionally (at very low rate) got soft lockup >>> when a remote cdrom

Re: [PATCH v5 17/55] plugins: implement helpers for resolving hwaddr

2019-10-14 Thread Peter Maydell
On Mon, 14 Oct 2019 at 17:34, Alex Bennée wrote: > Peter Maydell writes: > > Apologies for dropping into the middle of this patchset, but > > this API looks a bit odd. A hwaddr alone isn't a complete > > definition of an access -- you need an (AddressSpace, hwaddr) > > tuple for that. So this

[PULL 65/68] hw/arm/bcm2835_peripherals: Name various address spaces

2019-10-14 Thread Peter Maydell
From: Philippe Mathieu-Daudé Various address spaces from the BCM2835 are reported as 'anonymous' in memory tree: (qemu) info mtree address-space: anonymous -008f (prio 0, i/o): bcm2835-mbox 0010-001f (prio 0, i/o): bcm2835-fb

Re: [PATCH v5 51/55] plugins: expand the plugin_init function to include an info block

2019-10-14 Thread Richard Henderson
On 10/14/19 3:49 AM, Alex Bennée wrote: > This provides a limited amount of info to plugins about the guest > system that will allow them to make some additional decisions on > setup. > > Signed-off-by: Alex Bennée > --- > include/qemu/qemu-plugin.h | 26 -- >

  1   2   3   4   5   >