[PATCH v2 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-21 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 +- hw/hppa/dino.c | 94

[PATCH v2 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-10-21 Thread Sven Schnelle
From: Helge Deller LASI is a built-in multi-I/O chip which supports serial, parallel, network (Intel i82596 Apricot), sound and other functionalities. LASI has been used in many HP PARISC machines. This patch adds the necessary parts to allow Linux and HP-UX to detect LASI and the network card.

[PATCH v2 5/6] hppa: Add emulation of Artist graphics

2019-10-21 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |3 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1336

[PATCH v2 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-10-21 Thread Sven Schnelle
Hi, these series adds quite a lot to the HPPA emulation in QEMU: i82596 emulation from Helge, PS/2 and Artist graphics emulation. See https://parisc.wiki.kernel.org/index.php/Qemu for a few screenshots of QEMU running a X11/CDE session in HP-UX. Changes in v2: - dropped 'hppa: remove ISA

[PATCH v2 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-21 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

Re: [PATCH] tcg/LICENSE: Remove no-longer-true statement that TCG is BSD-licensed

2019-10-21 Thread Ard Biesheuvel
(uses Alex's working email address) On Mon, 21 Oct 2019 at 21:52, Ard Biesheuvel wrote: > > On Mon, 21 Oct 2019 at 19:57, Laszlo Ersek wrote: > > > > (+Ard, Alex) > > > > On 10/21/19 17:52, Richard Henderson wrote: > > > On 10/21/19 7:58 AM, Peter Maydell wrote: > > >> Since 2008 the

Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

2019-10-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019 Type: series

[Bug 1792523] Re: usb passthrough not resetting on host after vm shutdown if started with -daemonize

2019-10-21 Thread Marshall Porter
I tested this again on the latest Qemu and Linux kernel and cannot reproduce it anymore, so this can be closed now.. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1792523 Title: usb passthrough

[PATCH] Semihost SYS_READC implementation

2019-10-21 Thread Keith Packard
Provides a blocking call to read a character from the console by hooking into the console input chain. This happens *after* any uart has hooked in, so specifying -semihost overrides input to any emulated uarts. Signed-off-by: Keith Packard --- hw/semihosting/console.c | 92

Missing PVR setting capability

2019-10-21 Thread Wayne Li
Dear Qemu list members, I'm attempting to enable KVM in a Qemu-based project that is running on a T4240RDB board. After compiling my code with the -enable-kvm option I ran the qemu executable with the -enable-kvm option. The application exited with the following error message: "kvm error:

[Bug 1847440] Re: ppc64le: KVM guest fails to boot with an error `virtio_scsi: probe of virtio1 failed with error -22` on master

2019-10-21 Thread Alexey Kardashevskiy
https://patchwork.ozlabs.org/patch/1180363/ should fix it, a SLOF update for QEMU is also posted https://github.com/aik/qemu/tree/qemu-slof-20191022-branch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-10-21 Thread Alexey Kardashevskiy
The following changes since commit 7cff77c24d8f5e558cef3538a44044d66aa225a5: spapr: Move SpaprIrq::nr_xirqs to SpaprMachineClass (2019-10-16 12:01:41 +1100) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20191022 for you to fetch changes up to

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-10-21 Thread Denis Lunev
On 10/21/19 4:24 PM, Stefan Hajnoczi wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >> From: "Denis V. Lunev" >> >> Linux guests submit IO requests no longer than PAGE_SIZE * max_seg >> field reported by SCSI controler. Thus typical sequential read with >> 1 MB size

Re: [PATCH] net: add tulip (dec21143) driver

2019-10-21 Thread Jason Wang
On 2019/10/20 上午1:38, Sven Schnelle wrote: This adds the basic functionality to emulate a Tulip NIC. Implemented are: - RX and TX functionality - Perfect Frame Filtering - Big/Little Endian descriptor support - 93C46 EEPROM support - LXT970 PHY Not implemented, mostly because i had no OS

[Bug 1849234] [NEW] Macos Catalina bug

2019-10-21 Thread razer
Public bug reported: When I want to boot anything with qemu it just stops responding. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: qemu/powernv: coreboot support?

2019-10-21 Thread Marty E. Plummer
On Tue, Oct 22, 2019 at 12:40:32PM +1100, David Gibson wrote: > On Mon, Oct 21, 2019 at 07:32:09PM -0500, Marty E. Plummer wrote: > > On that note, is qemu-ppc64 currently capable of running LE > > firmware? > > Well.. "qemu-ppc64" as such isn't capable of running either LE or > firmware, since

Re: qemu/powernv: coreboot support?

2019-10-21 Thread David Gibson
On Mon, Oct 21, 2019 at 07:32:09PM -0500, Marty E. Plummer wrote: > On Mon, Oct 21, 2019 at 02:46:59PM +0200, Cédric Le Goater wrote: > > On 21/10/2019 07:34, David Gibson wrote: > > > On Sun, Oct 20, 2019 at 08:51:47AM +0200, Cédric Le Goater wrote: > > >> On 20/10/2019 08:28, David Gibson wrote:

Re: [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes

2019-10-21 Thread Tao Xu
On 10/21/2019 8:29 PM, Igor Mammedov wrote: On Sun, 20 Oct 2019 19:11:18 +0800 Tao Xu wrote: In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the

Re: qemu/powernv: coreboot support?

2019-10-21 Thread Marty E. Plummer
On Mon, Oct 21, 2019 at 02:46:59PM +0200, Cédric Le Goater wrote: > On 21/10/2019 07:34, David Gibson wrote: > > On Sun, Oct 20, 2019 at 08:51:47AM +0200, Cédric Le Goater wrote: > >> On 20/10/2019 08:28, David Gibson wrote: > >>> > >>> Ok. Note that the qemu emulated machine doesn't model the

Re: [PATCH v3 14/16] hw/arm/highbank: Use AddressSpace when using write_secondary_boot()

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:54 PM Philippe Mathieu-Daudé wrote: > > write_secondary_boot() is used in SMP configurations where the > CPU address space might not be the main System Bus. > The rom_add_blob_fixed_as() function allow us to specify an > address space. Use it to write each boot blob in

Re: [PATCH v3 10/16] hw/arm/raspi: Use AddressSpace when using arm_boot::write_secondary_boot

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:56 PM Philippe Mathieu-Daudé wrote: > > write_secondary_boot() is used in SMP configurations where the > CPU address space might not be the main System Bus. > The rom_add_blob_fixed_as() function allow us to specify an > address space. Use it to write each boot blob in

Re: [PATCH 10/21] hw/core: Let the machine be the owner of the system memory

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:07 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/core/null-machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/core/null-machine.c

Re: [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:12 PM Philippe Mathieu-Daudé wrote: > > All the codebase calls memory_region_allocate_system_memory() with > a NULL 'owner' from the board_init() function. > Let pass a MachineState argument, and enforce the QOM ownership of > the system memory. > > Signed-off-by:

Re: [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:10 PM Philippe Mathieu-Daudé wrote: > > All the memory_region_allocate_system_memory() calls are in the > board_init() code. From the 58 calls in the repository, only > 4 set the 'owner' parameter. It is obvious we want the Machine > to be the owner of the RAM, so we

Re: [PATCH v3 08/16] hw/arm/bcm2835_peripherals: Add const link property in realize()

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:53 PM Philippe Mathieu-Daudé wrote: > > The VideoCore GPU is indenpendant from the Peripheral block. In > the next commit, we will move its instantiation to the SoC block. > The "gpu-bus" object will not be accessible in init() but later > in realize(). As a preliminary

Re: [PATCH v3 07/16] hw/arm/bcm2836: Use per CPU address spaces

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:52 PM Philippe Mathieu-Daudé wrote: > > Currently all CPUs access the main system bus. Let each CPU have > his own address space. > > Before: > > (qemu) info mtree > address-space: memory > - (prio 0, i/o): system >

[PATCH v33 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-10-21 Thread Michael Rolnik
From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins).

[PATCH v33 11/13] target/avr: Add example board configuration

2019-10-21 Thread Michael Rolnik
A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this is not a real board NOTE: it's used for CPU testing Signed-off-by: Michael

[PATCH v33 07/13] target/avr: Add instruction translation - Bit and Bit-test Instructions

2019-10-21 Thread Michael Rolnik
This includes: - LSR, ROR - ASR - SWAP - SBI, CBI - BST, BLD - BSET, BCLR Signed-off-by: Michael Rolnik --- target/avr/translate.c | 1123 1 file changed, 1123 insertions(+) diff --git a/target/avr/translate.c

[PATCH v33 12/13] target/avr: Register AVR support with the rest of QEMU, the build system, and the WMAINTAINERS file

2019-10-21 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 9 + arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6 ++ include/sysemu/arch_init.h | 1 +

[PATCH v33 05/13] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2019-10-21 Thread Michael Rolnik
This includes: - ADD, ADC, ADIW - SBIW, SUB, SUBI, SBC, SBCI - AND, ANDI - OR, ORI, EOR - COM, NEG - INC, DEC - MUL, MULS, MULSU - FMUL, FMULS, FMULSU - DES Signed-off-by: Michael Rolnik --- target/avr/translate.c | 811 + 1 file changed, 811

[PATCH v33 06/13] target/avr: Add instruction translation - Branch Instructions

2019-10-21 Thread Michael Rolnik
This includes: - RJMP, IJMP, EIJMP, JMP - RCALL, ICALL, EICALL, CALL - RET, RETI - CPSE, CP, CPC, CPI - SBRC, SBRS, SBIC, SBIS - BRBC, BRBS Signed-off-by: Michael Rolnik --- target/avr/translate.c | 542 + 1 file changed, 542

[PATCH v33 13/13] target/avr: Add tests

2019-10-21 Thread Michael Rolnik
1. Avocado test The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working 2. Boot serial test Print out 'T' through

[PATCH v33 09/13] target/avr: Add instruction translation - CPU main translation function

2019-10-21 Thread Michael Rolnik
Co-developed-by: Richard Henderson Co-developed-by: Michael Rolnik Signed-off-by: Michael Rolnik --- target/avr/translate.c | 234 + 1 file changed, 234 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index

[PATCH v33 04/13] target/avr: Add instruction translation - Registers definition

2019-10-21 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target/avr/cpu.h | 2 +- target/avr/translate.c | 132 + 2 files changed, 133 insertions(+), 1 deletion(-) create mode 100644 target/avr/translate.c diff --git a/target/avr/cpu.h b/target/avr/cpu.h index

[PATCH v33 02/13] target/avr: Add instruction helpers

2019-10-21 Thread Michael Rolnik
Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wake interrupts. Memory

[PATCH v33 08/13] target/avr: Add instruction translation - MCU Control Instructions

2019-10-21 Thread Michael Rolnik
This includes: - BREAK - NOP - SLEEP - WDR Signed-off-by: Michael Rolnik --- target/avr/translate.c | 174 + 1 file changed, 174 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index 19540634df..21ba6004ee

[PATCH v33 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-10-21 Thread Michael Rolnik
This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik Acked-by: Igor Mammedov ---

[PATCH v33 03/13] target/avr: Add instruction decoding

2019-10-21 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git

[PATCH v33 00/13] QEMU AVR 8 bit cores

2019-10-21 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-21 Thread Michael Weiser
> After reading some related code, I have more questions than before, but > let's see... As more qcow2 code was merged since, I would suggest that > we debug the problem on commit 69f4750 (the bisection result) rather > than on anything newer. Okay, for all of the following I did a fresh compile

[PATCH] image-fuzzer: Use OSerror.strerror instead of tuple subscript

2019-10-21 Thread Eduardo Habkost
OSError can't be used like a tuple on Python 3, so change the code to use `e.sterror` instead of `e[1]`. Reported-by: John Snow Signed-off-by: Eduardo Habkost --- tests/image-fuzzer/runner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/image-fuzzer/runner.py

Re: [PATCH 09/14] smbus-eeprom: remove PROP_PTR

2019-10-21 Thread Marc-André Lureau
Hi On Fri, Oct 18, 2019 at 5:43 PM Marc-André Lureau wrote: > > Instead, set the initial data field directly. Since it is only 256 > bytes, let's simply copy it to avoid invalid pointers issues. Actually, the commit message is wrong. The patch used to introduce a init_data[256] array, and copy

Re: [PATCH 0/5] ppc/pnv: Add PNOR support

2019-10-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191021131215.3693-1-...@kaod.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/5] ppc/pnv: Add PNOR support Type: series Message-id: 20191021131215.3693-1-...@kaod.org === TEST

Re: [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:22 PM Philippe Mathieu-Daudé wrote: > > All the memory_region_allocate_system_memory() pass a MachineState > argument. Add an assertion to ensure the new boards/machines added > set this argument, so all system memory object have the machine as > its QOM owner. > >

Re: [PATCH 16/21] hw/lm32: Let the machine be the owner of the system memory

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:10 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/lm32/lm32_boards.c | 4 ++-- > hw/lm32/milkymist.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH 15/21] hw/i386: Let the machine be the owner of the system memory

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:20 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/i386/pc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index

Re: [PATCH 14/21] hw/hppa: Let the machine be the owner of the system memory

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:17 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/hppa/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c > index

Re: [PATCH 17/21] hw/m68k: Let the machine be the owner of the system memory

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:20 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/m68k/an5206.c| 2 +- > hw/m68k/mcf5208.c | 2 +- > hw/m68k/next-cube.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >

Re: [PATCH v8 0/8] Add Qemu to SeaBIOS LCHS interface

2019-10-21 Thread John Snow
On 10/16/19 12:41 PM, Sam Eiderman wrote: > > v1: > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries (consistent values being reported from BIOS INT13 > AH=08) will most likely break under

Re: [PATCH 13/21] hw/cris: Let the machine be the owner of the system memory

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:14 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/cris/axis_dev88.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c >

Re: [PATCH v2 0/6] hw/arm: Create the RAM in the board

2019-10-21 Thread Alistair Francis
On Mon, Oct 21, 2019 at 12:07 PM Philippe Mathieu-Daudé wrote: > > Hi Peter, > > This series contains the ARM patches extracted from the > "Let the machine be the owner of the system memory" series [1] > reviewed by Richard. > > These are cleanups moving the creation of the system ram at > the

Re: [PATCH 3/7] hppa: remove ISA region

2019-10-21 Thread Sven Schnelle
Hi Richard, On Mon, Oct 21, 2019 at 11:17:24AM -0700, Richard Henderson wrote: > On 10/20/19 1:47 PM, Sven Schnelle wrote: > > B160L doesn't have an ISA bus, and we no longer need it to > > workaround missing hardware, so remove it. > > > > Signed-off-by: Sven Schnelle > > --- > >

Re: [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:07 PM Philippe Mathieu-Daudé wrote: > > Having the RAM creation code in a separate function is not > very helpful. Move this code directly inside the board_init() > function, this will later allow the board to have the QOM > ownership of the RAM. > > Signed-off-by:

Re: [PATCH 03/21] hw/arm/collie: Create the RAM in the board

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 3:59 PM Philippe Mathieu-Daudé wrote: > > The SDRAM is incorrectly created in the SA1110 SoC. > Move its creation in the board code, this will later allow the > board to have the QOM ownership of the RAM. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair

Re: [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 3:58 PM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xilinx_zynq.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH 02/21] hw/arm/mps2: Use the IEC binary prefix definitions

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:02 PM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/mps2-tz.c | 3 ++- > hw/arm/mps2.c| 3 ++- > 2 files changed, 4

Re: [PATCH v3 06/16] hw/arm/bcm2836: Rename cpus[] as cpu[].core

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:49 PM Philippe Mathieu-Daudé wrote: > > As we are going to add more core-specific fields, add a 'cpu' > structure and move the ARMCPU field there as 'core'. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/bcm2836.c

Re: [PATCH 02/11] pci: add option for net failover

2019-10-21 Thread Alex Williamson
On Mon, 21 Oct 2019 22:28:57 +0200 Jens Freimann wrote: > On Mon, Oct 21, 2019 at 01:01:22PM -0600, Alex Williamson wrote: > >On Mon, 21 Oct 2019 20:45:46 +0200 > >Jens Freimann wrote: > > > >> On Mon, Oct 21, 2019 at 08:58:23AM -0600, Alex Williamson wrote: > >> >On Fri, 18 Oct 2019

Re: [PATCH v3 05/16] hw/arm/bcm2836: Make the SoC code modular

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:50 PM Philippe Mathieu-Daudé wrote: > > This file creates the BCM2836/BCM2837 blocks. > The biggest differences with the BCM2838 we are going to add, are > the base addresses of the interrupt controller and the peripherals. > Add these addresses in the BCM283XInfo

Re: [PATCH v3 03/16] hw/timer/bcm2835: Add the BCM2835 SYS_timer

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:47 PM Philippe Mathieu-Daudé wrote: > > Add the 64-bit free running timer. Do not model the COMPARE register > (no IRQ generated). > This timer is used by Linux kernel and recently U-Boot: >

Re: [PATCH v3 01/16] hw/misc/bcm2835_thermal: Add a dummy BCM2835 thermal sensor

2019-10-21 Thread Alistair Francis
On Sat, Oct 19, 2019 at 4:47 PM Philippe Mathieu-Daudé wrote: > > We will soon implement the SYS_timer. This timer is used by Linux > in the thermal subsystem, so once available, the subsystem will be > enabled and poll the temperature sensors. We need to provide the > minimum required to keep

Re: [PATCH 02/11] pci: add option for net failover

2019-10-21 Thread Jens Freimann
On Mon, Oct 21, 2019 at 01:01:22PM -0600, Alex Williamson wrote: On Mon, 21 Oct 2019 20:45:46 +0200 Jens Freimann wrote: On Mon, Oct 21, 2019 at 08:58:23AM -0600, Alex Williamson wrote: >On Fri, 18 Oct 2019 22:20:31 +0200 >Jens Freimann wrote: > >> This patch adds a net_failover_pair_id

Re: [PATCH] tcg/LICENSE: Remove no-longer-true statement that TCG is BSD-licensed

2019-10-21 Thread Ard Biesheuvel
On Mon, 21 Oct 2019 at 19:57, Laszlo Ersek wrote: > > (+Ard, Alex) > > On 10/21/19 17:52, Richard Henderson wrote: > > On 10/21/19 7:58 AM, Peter Maydell wrote: > >> Since 2008 the tcg/LICENSE file has not changed: it claims that > >> everything under tcg/ is BSD-licensed. > >> > >> This is not

[PATCH v6 06/12] target/mips: msa: Split helpers for ILV.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 21 +- target/mips/msa_helper.c | 768 +-- target/mips/translate.c |

[PATCH v6 10/12] target/mips: msa: Split helpers for PCK.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 11 +- target/mips/msa_helper.c | 386 +-- target/mips/translate.c |

[PATCH v6 05/12] target/mips: msa: Split helpers for _.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 20 ++- target/mips/msa_helper.c | 320 ++- target/mips/translate.c

[PATCH v6 01/12] target/mips: Clean up helper.c

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Mostly fix errors and warnings reported by 'checkpatch.pl -f'. Cc: Markus Armbruster Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.c | 123 +++ 1 file changed, 74

Re: [EXTERNAL][PATCH 18/21] hw/mips: Let the machine be the owner of the system memory

2019-10-21 Thread Aleksandar Markovic
> Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/boston.c| 2 +- > hw/mips/mips_fulong2e.c | 3 ++- > hw/mips/mips_jazz.c | 2 +- > hw/mips/mips_malta.c| 2 +- > hw/mips/mips_mipssim.c | 2 +- > hw/mips/mips_r4k.c | 3 ++- > 6 files changed, 8 insertions(+), 6

[PATCH v6 07/12] target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 30 +++- target/mips/msa_helper.c | 426 +-- target/mips/translate.c

[PATCH v6 08/12] target/mips: msa: Split helpers for HADD_.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 10 +++- target/mips/msa_helper.c | 131 ++- target/mips/translate.c

Re: [PATCH 11/11] vfio: unplug failover primary device before migration

2019-10-21 Thread Jens Freimann
On Mon, Oct 21, 2019 at 09:19:20AM -0600, Alex Williamson wrote: On Fri, 18 Oct 2019 22:20:40 +0200 Jens Freimann wrote: [...] +if (!pdev->net_failover_pair_id) { +error_setg(>migration_blocker, +"VFIO device doesn't support migration"); +ret =

[PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Mostly cosmetic changes. v5->v6: - minor corrections (r-b, t-b marks) in commit messages - added patches 11 and 12 v4->v5: - minor correction in patch on helper.c - added patches 9 and 10 v3->v4: - added patches 7 and 8 v2->v3: - removed all patches

[PATCH v6 11/12] target/mips: msa: Split helpers for HSUB_.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 10 - target/mips/msa_helper.c | 108 +-- target/mips/translate.c | 32 +++--- 3 files

[PATCH v6 02/12] target/mips: Clean up op_helper.c

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Mostly fix errors and warnings reported by 'checkpatch.pl -f'. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/op_helper.c | 1010 +++ 1 file changed, 663 insertions(+), 347 deletions(-)

[PATCH v6 04/12] target/mips: msa: Split helpers for _A.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 11 +++- target/mips/msa_helper.c | 163 ++- target/mips/translate.c

[PATCH v6 09/12] target/mips: msa: Split helpers for S.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 30 +++- target/mips/msa_helper.c | 424 +-- target/mips/translate.c

[PATCH v6 12/12] target/mips: msa: Split helpers for ASUB_.

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 12 +++- target/mips/msa_helper.c | 169 ++- target/mips/translate.c | 38 +-- 3 files

[PATCH v6 03/12] MAINTAINERS: Update mail address of Aleksandar Rikalo

2019-10-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Aleksandar Rikalo wishes to change his primary mail address for QEMU. Some minor line order is corrected in .mailmap to be alphabetical, too. Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by:

[PATCH v2 6/6] hw/arm/digic4: Inline digic4_board_setup_ram() function

2019-10-21 Thread Philippe Mathieu-Daudé
Having the RAM creation code in a separate function is not very helpful. Move this code directly inside the board_init() function, this will later allow the board to have the QOM ownership of the RAM. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 3/6] hw/arm/collie: Create the RAM in the board

2019-10-21 Thread Philippe Mathieu-Daudé
The SDRAM is incorrectly created in the SA1110 SoC. Move its creation in the board code, this will later allow the board to have the QOM ownership of the RAM. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/collie.c| 8 ++-- hw/arm/strongarm.c | 7

[PATCH v2 5/6] hw/arm/omap1: Create the RAM in the board

2019-10-21 Thread Philippe Mathieu-Daudé
The SDRAM is incorrectly created in the OMAP310 SoC. Move its creation in the board code, this will later allow the board to have the QOM ownership of the RAM. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/omap1.c| 12 +--- hw/arm/omap_sx1.c

[PATCH v2 1/6] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions

2019-10-21 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xilinx_zynq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index

[PATCH v2 4/6] hw/arm/omap2: Create the RAM in the board

2019-10-21 Thread Philippe Mathieu-Daudé
The SDRAM is incorrectly created in the OMAP2420 SoC. Move its creation in the board code, this will later allow the board to have the QOM ownership of the RAM. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v2: Move MemoryRegion sdram to struct n800_s (Richard) ---

[PATCH v2 0/6] hw/arm: Create the RAM in the board

2019-10-21 Thread Philippe Mathieu-Daudé
Hi Peter, This series contains the ARM patches extracted from the "Let the machine be the owner of the system memory" series [1] reviewed by Richard. These are cleanups moving the creation of the system ram at the board level. The other series will enforce memory_region_allocate_system_memory()

[PATCH v2 2/6] hw/arm/mps2: Use the IEC binary prefix definitions

2019-10-21 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/mps2-tz.c | 3 ++- hw/arm/mps2.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c index

Re: [PATCH 02/11] pci: add option for net failover

2019-10-21 Thread Alex Williamson
On Mon, 21 Oct 2019 20:45:46 +0200 Jens Freimann wrote: > On Mon, Oct 21, 2019 at 08:58:23AM -0600, Alex Williamson wrote: > >On Fri, 18 Oct 2019 22:20:31 +0200 > >Jens Freimann wrote: > > > >> This patch adds a net_failover_pair_id property to PCIDev which is > >> used to link the primary

Re: [PATCH 02/11] pci: add option for net failover

2019-10-21 Thread Jens Freimann
On Mon, Oct 21, 2019 at 08:58:23AM -0600, Alex Williamson wrote: On Fri, 18 Oct 2019 22:20:31 +0200 Jens Freimann wrote: This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device.

Re: [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-21 Thread Richard Henderson
On 10/20/19 1:47 PM, Sven Schnelle wrote: > #define DINO_PCI_HOST_BRIDGE(obj) \ > OBJECT_CHECK(DinoState, (obj), TYPE_DINO_PCI_HOST_BRIDGE) > > +#define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4) > +static uint8_t reg800_keep_bits[DINO800_REGS] > += { 1, 7, 7, 8, 7, 9, 32, 8, 30,

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-21 Thread Laszlo Ersek (Red Hat)
In reply to Kevin's comment#13: > I find Laszlo's case with a preallocated image particularly surprising > because the behaviour isn't supposed to have changed at all for > preallocated images, at least if the heuristics still detects them as > such. But isn't that "if" at the core of this

Re: [PATCH 3/7] hppa: remove ISA region

2019-10-21 Thread Richard Henderson
On 10/20/19 1:47 PM, Sven Schnelle wrote: > B160L doesn't have an ISA bus, and we no longer need it to > workaround missing hardware, so remove it. > > Signed-off-by: Sven Schnelle > --- > hw/hppa/hppa_hardware.h | 1 - > hw/hppa/machine.c | 32 > 2 files

Re: [PATCH] tcg/LICENSE: Remove no-longer-true statement that TCG is BSD-licensed

2019-10-21 Thread Laszlo Ersek
(+Ard, Alex) On 10/21/19 17:52, Richard Henderson wrote: > On 10/21/19 7:58 AM, Peter Maydell wrote: >> Since 2008 the tcg/LICENSE file has not changed: it claims that >> everything under tcg/ is BSD-licensed. >> >> This is not true and hasn't been true for years: in 2013 we >> accepted the

Re: [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > All the memory_region_allocate_system_memory() pass a MachineState > argument. Add an assertion to ensure the new boards/machines added > set this argument, so all system memory object have the machine as > its QOM owner. > > Signed-off-by:

Re: [PATCH 20/21] hw/sparc: Let the machine be the owner of the system memory

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sparc/leon3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 19/21] hw/ppc: Let the machine be the owner of the system memory

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ppc/e500.c | 3 ++- > hw/ppc/mac_newworld.c | 3 ++- > hw/ppc/mac_oldworld.c | 2 +- > hw/ppc/pnv.c | 2 +- > hw/ppc/ppc405_boards.c | 6 +++--- > hw/ppc/prep.c | 3

Re: [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board

2019-10-21 Thread Philippe Mathieu-Daudé
On 10/21/19 7:27 PM, Richard Henderson wrote: On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: @@ -73,8 +74,16 @@ static void clipper_init(MachineState *machine) cpus[0]->env.trap_arg1 = 0; cpus[0]->env.trap_arg2 = smp_cpus; +/* + * Main memory region, 0x00...

Re: [PATCH 16/21] hw/lm32: Let the machine be the owner of the system memory

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/lm32_boards.c | 4 ++-- > hw/lm32/milkymist.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 17/21] hw/m68k: Let the machine be the owner of the system memory

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/m68k/an5206.c| 2 +- > hw/m68k/mcf5208.c | 2 +- > hw/m68k/next-cube.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 13/21] hw/cris: Let the machine be the owner of the system memory

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/cris/axis_dev88.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 14/21] hw/hppa: Let the machine be the owner of the system memory

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/hppa/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

  1   2   3   4   >