[PATCH v3] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
This adds the basic functionality to emulate a Tulip NIC. Implemented are: - RX and TX functionality - Perfect Frame Filtering - Big/Little Endian descriptor support - 93C46 EEPROM support - LXT970 PHY Not implemented, mostly because i had no OS using these functions: - Imperfect frame

Re: [PATCH v10 3/3] iotests: test nbd reconnect

2019-10-23 Thread Vladimir Sementsov-Ogievskiy
23.10.2019 4:31, Eric Blake wrote: > On 10/9/19 3:41 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add test, which starts backup to nbd target and restarts nbd server >> during backup. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   tests/qemu-iotests/264    | 95

Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian

2019-10-23 Thread Stefan Hajnoczi
On Tue, Oct 22, 2019 at 06:51:39PM +0200, Christophe de Dinechin wrote: > > Stefan Hajnoczi writes: > [...] > > +static uint16_t qvirtio_readw(QVirtioDevice *d, QTestState *qts, uint64_t > > addr) > > +{ > > +uint16_t val = qtest_readw(qts, addr); > > + > > +if (d->features & (1ull <<

[PATCH v5 11/11] vfio: unplug failover primary device before migration

2019-10-23 Thread Jens Freimann
As usual block all vfio-pci devices from being migrated, but make an exception for failover primary devices. This is achieved by setting unmigratable to 0 but also add a migration blocker for all vfio-pci devices except failover primary devices. These will be unplugged before migration happens by

[Bug 1596579] Re: segfault upon reboot

2019-10-23 Thread Thomas Huth
Can you reproduce this problem with the latest upstream version of QEMU (currently version 4.1)? Or is it only reproducible in the qemu-kvm from your distribution? (In the latter case, please report this bug to your distro instead) ** Changed in: qemu Status: New => Incomplete -- You

[PATCH v5 08/11] migration: add new migration state wait-unplug

2019-10-23 Thread Jens Freimann
This patch adds a new migration state called wait-unplug. It is entered after the SETUP state if failover devices are present. It will transition into ACTIVE once all devices were succesfully unplugged from the guest. So if a guest doesn't respond or takes long to honor the unplug request the

[PATCH v5 10/11] net/virtio: add failover support

2019-10-23 Thread Jens Freimann
This patch adds support to handle failover device pairs of a virtio-net device and a vfio-pci device, where the virtio-net acts as the standby device and the vfio-pci device as the primary. The general idea is that we have a pair of devices, a vfio-pci and a emulated (virtio-net) device. Before

[PATCH v5 05/11] qapi: add unplug primary event

2019-10-23 Thread Jens Freimann
This event is emitted when we sent a request to unplug a failover primary device from the Guest OS and it includes the device id of the primary device. Signed-off-by: Jens Freimann --- qapi/migration.json | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH v5 06/11] qapi: add failover negotiated event

2019-10-23 Thread Jens Freimann
This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature was not negotiated during virtio feature negotiation. If this event is received it means any primary devices hotplugged before this were were never really added to QEMU devices. Signed-off-by: Jens Freimann ---

[Bug 1575561] Re: config qemu virtio_queue_size to 1024,create vm boot from network failed

2019-10-23 Thread Thomas Huth
Which version of QEMU were you using here? Can you still reproduce this issue with the latest version of QEMU? If so, please also provide the full command line parameters that you used to start QEMU. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification

[PATCH v5 09/11] libqos: tolerate wait-unplug migration state

2019-10-23 Thread Jens Freimann
Signed-off-by: Jens Freimann --- tests/libqos/libqos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c index d71557c5cb..f229eb2cb8 100644 --- a/tests/libqos/libqos.c +++ b/tests/libqos/libqos.c @@ -125,7 +125,8 @@ void

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

2019-10-23 Thread Stefan Hajnoczi
On Tue, Oct 22, 2019 at 08:48:31PM +0200, Thomas Huth wrote: > On 22/10/2019 17.48, Stefan Hajnoczi wrote: > > On Mon, Oct 21, 2019 at 02:15:53PM +0200, Thomas Huth wrote: > >> On 19/10/2019 08.38, Stefan Hajnoczi wrote: > >>> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device > >>>

[PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Jens Freimann
This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It only supports ethernet devices. Also currently it only supports PCIe devices. QEMU will exit with an error message

[PATCH v5 04/11] pci: mark device having guest unplug request pending

2019-10-23 Thread Jens Freimann
Set pending_deleted_event in DeviceState for failover primary devices that were successfully unplugged by the Guest OS. Signed-off-by: Jens Freimann --- hw/pci/pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 19363ff8ce..08718188bb 100644 ---

[PATCH v5 07/11] migration: allow unplug during migration for failover devices

2019-10-23 Thread Jens Freimann
In "b06424de62 migration: Disable hotplug/unplug during migration" we added a check to disable unplug for all devices until we have figured out what works. For failover primary devices qdev_unplug() is called from the migration handler, i.e. during migration. This patch adds a flag to DeviceState

[PATCH v5 03/11] pci: mark devices partially unplugged

2019-10-23 Thread Jens Freimann
Only the guest unplug request was triggered. This is needed for the failover feature. In case of a failed migration we need to plug the device back to the guest. Signed-off-by: Jens Freimann --- hw/pci/pcie.c| 3 +++ include/hw/pci/pci.h | 1 + 2 files changed, 4 insertions(+) diff

[PATCH v5 0/11] add failover feature for assigned network devices

2019-10-23 Thread Jens Freimann
This is implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Changes since v4: * Patch 1, qdev, add comment to DeviceClass and qdev_should_hide_device function * Patch 2 pci, set flag that allows unplug during

[PATCH v5 01/11] qdev/qbus: add hidden device support

2019-10-23 Thread Jens Freimann
This adds support for hiding a device to the qbus and qdev APIs. The first user of this will be the virtio-net failover feature but the API introduced with this patch could be used to implement other features as well, for example hiding pci devices when a pci bus is powered off.

[PATCH] audio: fix missing break

2019-10-23 Thread Paolo Bonzini
Reported by Coverity (CID 1406449). Signed-off-by: Paolo Bonzini --- audio/paaudio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/paaudio.c b/audio/paaudio.c index df541a72d3..55a91f8980 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -385,6 +385,7 @@ static pa_stream

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Kevin Wolf
Am 23.10.2019 um 09:57 hat Peter Xu geschrieben: > On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > > v2: > > > > - use uint32_t rather than int64_t

[Bug 1192464] Re: udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2019-10-23 Thread Thomas Huth
Sorry, I meant "bug tickets", of course, not "buck tickets" ... need more coffee... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1192464 Title: udp checksum computed as 0 not converted to 0x,

[Bug 1192464] Re: udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2019-10-23 Thread Thomas Huth
Triaging old buck tickets ... can you still reproduce this issue with the latest version of QEMU? Is it only happening with e1000 or also with other NICs? What kind of network backend are you using (--netdev user ? tap ? ). Could you please provide the full command line that you use to run

RE: [PATCH v6 1/4] block/replication.c: Ignore requests after failover

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Saturday, October 19, 2019 2:46 AM > To: qemu-devel > Cc: Zhang, Chen ; Jason Wang > ; Wen Congyang ; > Xie Changlong ; Kevin Wolf > ; Max Reitz ; qemu-block > > Subject: Re: [PATCH v6 1/4] block/replication.c: Ignore requests after >

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-23 Thread Kevin Wolf
> So it's much more likely that is_zero_cow() has a side-effect that somehow > causes corruption later on even without handle_alloc_space() ever calling > bdrv_co_pwrite_zeroes(). Yes, looks like it. I think we have ruled out that a changing return value is the cause of the problems because the

Re: [PATCH v4] migration: Support QLIST migration

2019-10-23 Thread Juan Quintela
Eric Auger wrote: > Support QLIST migration using the same principle as QTAILQ: > 94869d5c52 ("migration: migrate QTAILQ"). > > The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. > The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD > and QLIST_RAW_REVERSE. > >

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote: > > There are a couple of minor wrong-indent nits: > > > +static void tulip_update_ts(TULIPState *s, int state) > > +{ > > +s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT); > > +s->csr[5] |= (state & CSR5_TS_MASK) <<

Re: [PATCH v4 3/3] tests/migration:fix unreachable path in stress test

2019-10-23 Thread Laurent Vivier
Le 04/10/2019 à 19:32, Mao Zhongyi a écrit : > If stressone() or stress() exits it's because of a failure > because the test runs forever otherwise, so change stressone > and stress type to void to make the exit_failure() as the exit > function of main(). > > Signed-off-by: Mao Zhongyi > --- >

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Peter Xu
On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > v2: > > > - use uint32_t rather than int64_t [Juan] > > > - one more patch (patch 4) to check dup

[PATCH] nvme: fix NSSRS offset in CAP register

2019-10-23 Thread Klaus Jensen
Fix the offset of the NSSRS field the CAP register. Signed-off-by: Klaus Jensen Reported-by: Javier Gonzalez --- include/block/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/nvme.h b/include/block/nvme.h index 3ec8efcc435e..fa15b51c33bb 100644 ---

Re: [PATCH for 4.2 v1 00/19] testing/next before softfreeze

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Alex Bennée" > Sent: Tuesday, October 22, 2019 9:16:45 PM > > Hi, > > This is the current status of testing/next. I dropped the Travis arm64 > build due to stability concerns. As far as I can tell Thomas' latest > iotest updates are working fine. If there

Re: [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Alex Bennée" > Sent: Tuesday, October 22, 2019 9:16:52 PM > > The MacOS build can time out on Cirrus running to almost an hour. > Reduce the scope to the historical MacOS architectures much the same > way we do on Travis. Oh, really? For me, the builds on

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191022155413.4619-1-sv...@stackframe.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH V3 2/2] target/i386/kvm: Add Hyper-V direct tlb flush support

2019-10-23 Thread Paolo Bonzini
On 22/10/19 22:14, Roman Kagan wrote: > On Tue, Oct 22, 2019 at 07:04:11PM +0200, Paolo Bonzini wrote: >> On 16/10/19 15:07, lantianyu1...@gmail.com wrote: > > Somehow this patch never got through to me so I'll reply here. > >>> From: Tianyu Lan >>> >>> Hyper-V direct tlb flush targets KVM on

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Aleksandar Markovic" > Sent: Tuesday, October 22, 2019 10:35:51 PM > > On Tuesday, October 8, 2019, Thomas Huth wrote: > > > When running "make distclean" we currently leave a lot of generated > > files in the build directory. These should be completely

RE: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Paolo Bonzini > Sent: Tuesday, October 22, 2019 1:24 AM > To: Zhang, Chen ; Jason Wang > ; qemu-dev > Cc: Zhang Chen > Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog > module framework > > On 16/10/19 13:22, Zhang Chen wrote: > >

[PATCH v4 1/2] hw: rtc: Add Goldfish RTC device

2019-10-23 Thread Anup Patel
This patch adds model for Google Goldfish virtual platform RTC device. We will be adding Goldfish RTC device to the QEMU RISC-V virt machine for providing real date-time to Guest Linux. The corresponding Linux driver for Goldfish RTC device is already available in upstream Linux. For now, VM

[PATCH v4 2/2] riscv: virt: Use Goldfish RTC device

2019-10-23 Thread Anup Patel
We extend QEMU RISC-V virt machine by adding Goldfish RTC device to it. This will allow Guest Linux to sync it's local date/time with Host date/time via RTC device. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Reviewed-by: Alistair Francis ---

[PATCH v4 0/2] RTC support for QEMU RISC-V virt machine

2019-10-23 Thread Anup Patel
This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is already available in Linux so we just need to enable it in

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-23 Thread Tao Xu
On 10/23/2019 9:08 AM, Eduardo Habkost wrote: Hi, First of all, sorry for not reviewing this earlier. I thought other people were already looking at the first 4 patches. On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: To convert strings with time suffixes to numbers, support time

Re: [PATCH 3/5] ppc/pnv: Add HIOMAP commands

2019-10-23 Thread Joel Stanley
On Mon, 21 Oct 2019 at 13:12, Cédric Le Goater wrote: > > This activates HIOMAP support on the QEMU PowerNV machine. The PnvPnor > model is used to access the flash contents. The model simply maps the > contents at a fix offset and enables or disables the mapping. > > HIOMAP Protocol description

<    1   2   3   4