[Bug 1853083] Re: qemu ppc64 4.0 boot AIX5.1 hung

2019-11-18 Thread Philippe Mathieu-Daudé
Did this ever worked? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1853083 Title: qemu ppc64 4.0 boot AIX5.1 hung Status in QEMU: New Bug description: When boot AIX5.1 from cdrom device, qem

Re: [RFC PATCH] scripts/tap-driver: report "slow" tests (HACK)

2019-11-18 Thread Alex Bennée
Alex Bennée writes: > Some tests seem to run slower on CI systems but we don't really get > visibility of which it is unless we happen to hang the test at the end > of a run. This hacky change exposes "slow" tests in the tap output. > > [AJB: my perl is rusty, I'm sure this could be more idioma

Re: [PATCH v5] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread Marc-André Lureau
Hi On Tue, Nov 19, 2019 at 10:40 AM Micky Yun Chan wrote: > > From: michan > > This patch is to add standard commands defined in docs/interop/vhost-user.rst You should also follow and update docs/interop/vhost-user.json > For vhost-user-* program > > Signed-off-by: Micky Yun Chan (michiboo) >

Re: [PATCH v4] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread Philippe Mathieu-Daudé
Hi Micky, On 11/19/19 3:26 AM, Micky Yun Chan wrote: From: michan It seems your git setup lacks your username. This should solve it (eventually running with --global): git config user.name "Micky Yun Chan" This patch is to add standard commands defined in docs/interop/vhost-user.rst For

Re: [PATCH-for-4.2 v3 0/3] hw: Remove dynamic field width from trace events

2019-11-18 Thread Richard Henderson
On 11/18/19 10:04 PM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (3): > hw/block/pflash: Remove dynamic field width from trace events > hw/mips/gt64xxx: Remove dynamic field width from trace events > trace: Forbid dynamic field width in event format Reviewed-by: Richard Henderson

Re: [PATCH v3 for-4.2] monitor/qmp: resume monitor when clearing its queue

2019-11-18 Thread Markus Armbruster
Wolfgang Bumiller writes: > When a monitor's queue is filled up in handle_qmp_command() > it gets suspended. It's the dispatcher bh's job currently to > resume the monitor, which it does after processing an event > from the queue. However, it is possible for a > CHR_EVENT_CLOSED event to be proce

Re: [PATCH] i440FX-pcihost: add 'allow-hotplug' property for configuring whether to expose the BSEL to the guest.

2019-11-18 Thread Igor Mammedov
On Tue, 19 Nov 2019 17:51:20 +0800 lichun <706701...@qq.com> wrote: ... here should go rationale why it's needed. > Signed-off-by: lichun <706701...@qq.com> > --- > hw/acpi/pcihp.c | 2 +- > hw/pci-host/i440fx.c | 11 +++ > include/hw/pci-host/i440fx.h | 1 + > 3

Re: [PATCH] libvhost-user: Zero memory allocated for VuVirtqInflightDesc

2019-11-18 Thread Marc-André Lureau
Hi On Tue, Nov 19, 2019 at 7:49 AM wrote: > > From: Xie Yongji > > Use a zero-initialized VuVirtqInflightDesc struct to avoid > that scan-build reports that vq->resubmit_list[0].counter may > be garbage value in vu_check_queue_inflights(). > > Fixes: 5f9ff1eff ("libvhost-user: Support tracking i

Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities

2019-11-18 Thread Igor Mammedov
On Mon, 14 Oct 2019 13:37:37 -0500 Shivaprasad G Bhat wrote: > nvdimm_device_list is required for parsing the list for devices > in subsequent patches. Move it to common utility area. > > Signed-off-by: Shivaprasad G Bhat > --- > hw/acpi/nvdimm.c| 28 +---

[PATCH] audio: fix audio recording

2019-11-18 Thread Volker Rümelin
With current code audio recording with all audio backends except PulseAudio and DirectSound is broken. The generic audio recording buffer management forgot to update the current read position after a read. Fixes: ff095e5231 "audio: api for mixeng code free backends" Signed-off-by: Volker Rümelin

Re: [PATCH] ppc/pnv: Add a LPC "ranges" property

2019-11-18 Thread Cédric Le Goater
On 19/11/2019 01:49, David Gibson wrote: > On Mon, Nov 18, 2019 at 10:19:08AM +0100, Cédric Le Goater wrote: >> And fix a typo in the MEM address space definition. >> >> Signed-off-by: Cédric Le Goater > > Applied to ppc-for-5.0. AFAICT this is a bugfix (amongst other > things), but I don't thin

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-18 Thread Cédric Le Goater
On 19/11/2019 01:52, David Gibson wrote: > On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: >> The BMC of the OpenPOWER systems monitors the machine state using >> sensors, controls the power and controls the access to the PNOR flash >> device containing the firmware image required

[PATCH v5] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread Micky Yun Chan
From: michan This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 109 ++-- 1 file changed, 65 insertions(+), 44 deletions(-) diff --git

[PATCH v2 2/2] intel_iommu: TM field should not be in reserved bits

2019-11-18 Thread qi1 . zhang
From: "Zhang, Qi" When dt is supported, TM field should not be Reserved(0). Refer to VT-d Spec 9.8 Signed-off-by: Zhang, Qi Signed-off-by: Qi, Yadong --- hw/i386/intel_iommu.c | 12 hw/i386/intel_iommu_internal.h | 17 + 2 files changed, 21 insertions(+)

[PATCH 1/2] intel_iommu: split the resevred fields arrays into two ones

2019-11-18 Thread qi1 . zhang
From: "Zhang, Qi" Signed-off-by: Zhang, Qi --- hw/i386/intel_iommu.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index f1de8fdb75..a118efaeaf 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/

[PATCH v2 0/2] TM field check failed

2019-11-18 Thread qi1 . zhang
From: "Zhang, Qi" spilt the reserved fields arrays and remove TM field from reserved bits Changelog V1: add descriptons Changelog V2: refine Zhang, Qi (2): intel_iommu: split the resevred fields arrays into two ones intel_iommu: TM field should not be in reserved bits hw/i386/intel_io

Re: [PATCH v4] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191119022640.11021-1-mic...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v4] Implement backend program convention command for vhost-user-blk Type: series Message-id: 2019111

[PATCH] libvhost-user: Zero memory allocated for VuVirtqInflightDesc

2019-11-18 Thread elohimes
From: Xie Yongji Use a zero-initialized VuVirtqInflightDesc struct to avoid that scan-build reports that vq->resubmit_list[0].counter may be garbage value in vu_check_queue_inflights(). Fixes: 5f9ff1eff ("libvhost-user: Support tracking inflight I/O in shared memory") Reported-by: Marc-André Lur

Re: [PATCH for-5.0 v5 03/23] ppc/pnv: Remove pnv_xive_vst_size() routine

2019-11-18 Thread David Gibson
On Fri, Nov 15, 2019 at 05:24:16PM +0100, Cédric Le Goater wrote: > pnv_xive_vst_size() tries to compute the size of a VSD table from the > information given by FW. The number of entries of the table are > deduced from the result and the MMIO regions of the ESBs and the END > ESBs are then resized

Re: [PATCH for-5.0 v5 01/23] ppc/xive: Record the IPB in the associated NVT

2019-11-18 Thread David Gibson
On Fri, Nov 15, 2019 at 05:24:14PM +0100, Cédric Le Goater wrote: > When an interrupt can not be presented to a vCPU, because it is not > running on any of the HW treads, the XIVE presenter updates the > Interrupt Pending Buffer register of the associated XIVE NVT > structure. This is only done if

Re: [PATCH for-5.0 v5 02/23] ppc/xive: Introduce helpers for the NVT id

2019-11-18 Thread David Gibson
On Fri, Nov 15, 2019 at 05:24:15PM +0100, Cédric Le Goater wrote: > Each vCPU in the system is identified with an NVT identifier which is > pushed in the OS CAM line (QW1W2) of the HW thread interrupt context > register when the vCPU is dispatched on a HW thread. This identifier > is used by the pr

[Bug 1853083] [NEW] qemu ppc64 4.0 boot AIX5.1 hung

2019-11-18 Thread wzis
Public bug reported: When boot AIX5.1 from cdrom device, qemu hung there, no further info is displayed and cpu consumption is high. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [Qemu-devel][PATCH] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue

2019-11-18 Thread pannengyuan
Thanks for you reply. I think you are right, I will send a new version later. On 2019/11/19 10:50, David Gibson wrote: > On Mon, Nov 18, 2019 at 09:50:13AM +0800, pannengy...@huawei.com wrote: >> From: PanNengyuan >> >> source is being dereferenced before it is null checked, hence there is a >> p

[PULL 10/10] tests: More iotest 223 improvements

2019-11-18 Thread Eric Blake
Run the core of the test twice, once without iothreads, and again with, for more coverage of both setups. Suggested-by: Nir Soffer Signed-off-by: Eric Blake Reviewed-by: Max Reitz Message-Id: <20191114213415.23499-5-ebl...@redhat.com> --- tests/qemu-iotests/223 | 16 ++- tests/qemu-iot

[PULL 09/10] iotests: Include QMP input in .out files

2019-11-18 Thread Eric Blake
We generally include relevant HMP input in .out files, by virtue of the fact that HMP echoes its input. But QMP does not, so we have to explicitly inject it in the output stream (appropriately filtered to keep the tests passing), in order to make it easier to read .out files to see what behavior i

[PULL 08/10] iotests: Switch nbd tests to use Unix rather than TCP

2019-11-18 Thread Eric Blake
Up to now, all it took to cause a lot of iotest failures was to have a background process such as 'nbdkit -p 10810 null' running, because we hard-coded the TCP port. Switching to a Unix socket eliminates this contention. We still have TCP coverage in test 233, and that test is more careful to not

[PULL 06/10] MAINTAINERS: add more bitmap-related to Dirty Bitmaps section

2019-11-18 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Let's add bitmaps persistence qcow2 feature and postcopy bitmaps migration to Dirty Bitmaps section. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20191026165655.14112-1-vsement...@virtuozzo.com> Reviewed-by: John Snow Signed-off-by: Eric Blake --

Re: [PATCH] target/i386: Remove monitor from some CPU model

2019-11-18 Thread Tao Xu
On 11/19/2019 6:10 AM, Eduardo Habkost wrote: On Fri, Nov 15, 2019 at 04:33:45PM +0800, Tao Xu wrote: Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana CPU model to remove MONITOR/MWAIT feature. After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT (commit id 6f

[PULL 07/10] iotests: Fix 173

2019-11-18 Thread Eric Blake
This test has been broken since 3.0. It used TEST_IMG to influence the name of a file created during _make_test_img, but commit 655ae6bb changed things so that the wrong file name is being created, which then caused _launch_qemu to fail. In the meantime, the set of events issued for the actions o

[PULL 04/10] bitmap: Enforce maximum bitmap name length

2019-11-18 Thread Eric Blake
We document that for qcow2 persistent bitmaps, the name cannot exceed 1023 bytes. It is inconsistent if transient bitmaps do not have to abide by the same limit, and it is unlikely that any existing client even cares about using bitmap names this long. It's time to codify that ALL bitmaps managed

Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities

2019-11-18 Thread David Gibson
On Mon, Oct 14, 2019 at 01:37:37PM -0500, Shivaprasad G Bhat wrote: > nvdimm_device_list is required for parsing the list for devices > in subsequent patches. Move it to common utility area. > > Signed-off-by: Shivaprasad G Bhat LGTM, assuming it's needed in the subsequent patches. An ack from

[PULL 02/10] qemu-coroutine-sleep: Silence Coverity warning

2019-11-18 Thread Eric Blake
Coverity warns that we store the address of a stack variable through a pointer passed in by the caller, which would let the caller trivially trigger use-after-free if that stored value is still present when we finish execution. However, the way coroutines work is that after our call to qemu_corout

[PULL 03/10] nbd/server: Prefer heap over stack for parsing client names

2019-11-18 Thread Eric Blake
As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD standard, which is too large for stack allocation

[PULL 05/10] nbd: Don't send oversize strings

2019-11-18 Thread Eric Blake
Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near the NBD spec maximum of a 4k limit per string. However, we weren't actually enforcing things,

[PULL 01/10] iotests: Test NBD client reconnection

2019-11-18 Thread Eric Blake
From: Andrey Shinkevich The test for an NBD client. The NBD server is disconnected after the client write request. The NBD client should reconnect and complete the write operation. Suggested-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Reviewe

[PULL 00/10] NBD patches for 2019-11-19 for 4.2-rc2

2019-11-18 Thread Eric Blake
The following changes since commit a5c2a235103ab366ad5318636ec138e52c6dcfa4: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-11-18 17:06:17 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-11-19 for you to

Re: [PATCH v3] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191119021548.10101-1-mic...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3] Implement backend program convention command for vhost-user-blk Type: series Message-id: 2019111

Re: [Qemu-devel][PATCH] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue

2019-11-18 Thread David Gibson
On Mon, Nov 18, 2019 at 09:50:13AM +0800, pannengy...@huawei.com wrote: > From: PanNengyuan > > source is being dereferenced before it is null checked, hence there is a > potential null pointer dereference. > > This fixes: > 360 > CID 68911917: (NULL_RETURNS) > 361. dereferen

Re: [PATCH v17 6/7] migration: Include migration support for machine check handling

2019-11-18 Thread David Gibson
On Thu, Oct 24, 2019 at 01:13:06PM +0530, Ganesh Goudar wrote: > From: Aravinda Prasad > > This patch includes migration support for machine check > handling. Especially this patch blocks VM migration > requests until the machine check error handling is > complete as these errors are specific to

Re: [PATCH v17 5/7] ppc: spapr: Handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls

2019-11-18 Thread David Gibson
On Thu, Oct 24, 2019 at 01:13:05PM +0530, Ganesh Goudar wrote: > From: Aravinda Prasad > > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls. > > The machine check notification address is saved when the > OS issues "ibm,nmi-register" RTAS call. >

[PATCH v4] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread Micky Yun Chan
From: michan This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 109 ++-- 1 file changed, 65 insertions(+), 44 deletions(-) diff --git

[PATCH v3] Implement backend program convention command for vhost-user-blk

2019-11-18 Thread Micky Yun Chan
From: michan This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 109 ++-- 1 file changed, 65 insertions(+), 44 deletions(-) diff --git

[PATCH] i440FX-pcihost: add 'allow-hotplug' property for configuring whether to expose the BSEL to the guest.

2019-11-18 Thread lichun
Signed-off-by: lichun <706701...@qq.com> --- hw/acpi/pcihp.c | 2 +- hw/pci-host/i440fx.c | 11 +++ include/hw/pci-host/i440fx.h | 1 + 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 8413348..4f5e0d3 100644 ---

Re: [PATCH v17 4/7] target/ppc: Build rtas error log upon an MCE

2019-11-18 Thread David Gibson
On Mon, Nov 18, 2019 at 04:39:16PM +0530, Ganesh wrote: > > On 11/6/19 4:37 PM, Ganesh wrote: > > > > On 11/4/19 9:40 PM, David Gibson wrote: > > > On Thu, Oct 24, 2019 at 01:13:04PM +0530, Ganesh Goudar wrote: > > > > From: Aravinda Prasad > > > > > > > > Upon a machine check exception (MCE) i

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1574121497-2433-1-git-send-email-tsimp...@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linu

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-18 Thread David Gibson
On Fri, Nov 08, 2019 at 05:47:59PM +0100, Greg Kurz wrote: > On Fri, 8 Nov 2019 16:40:35 +0100 > Laurent Vivier wrote: > > > Commit 29cb4187497d sets by default the VSMT to smp_threads, > > but older kernels (< 4.13) don't support that. > > > > We can reasonably restore previous behavior with t

Re: [PATCH] ppc/pnv: Add a LPC "ranges" property

2019-11-18 Thread David Gibson
On Mon, Nov 18, 2019 at 10:19:08AM +0100, Cédric Le Goater wrote: > And fix a typo in the MEM address space definition. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-5.0. AFAICT this is a bugfix (amongst other things), but I don't think pnv is widely used enough to put this into 4.2 du

Re: [PATCH for-5.0] xive/kvm: Trigger interrupts from userspace

2019-11-18 Thread David Gibson
On Mon, Nov 18, 2019 at 04:37:16PM +0100, Cédric Le Goater wrote: > On 18/11/2019 16:12, Greg Kurz wrote: > > When using the XIVE KVM device, the trigger page is directly accessible > > in QEMU. Unlike with XICS, no need to ask KVM to fire the interrupt. A > > simple store on the trigger page does

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-18 Thread David Gibson
On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power

Re: [PATCH for-5.0 0/4] ppc: Some more QOM cleanup for XICS

2019-11-18 Thread David Gibson
On Mon, Nov 18, 2019 at 12:20:30AM +0100, Greg Kurz wrote: > This series consolidates some more QOM links and pointers that point to > the same object. While here also simplify the XICS interrupt controller > init in the machine code. Applied to ppc-for-5.0 (correcting the spelling errors Cédric n

[PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and

2019-11-18 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- configure | 9 + default-configs/hexagon-linux-user.mak | 1 + include/elf.h | 2 + linux-user/elfload.c| 16 ++ linux-user/hexagon/cpu_loop.c | 103

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-18 Thread Alex Williamson
On Mon, 18 Nov 2019 19:44:30 -0200 Marcelo Tosatti wrote: > On Sun, Nov 17, 2019 at 11:12:43AM +0100, Paolo Bonzini wrote: > > On 17/11/19 05:31, Alex Williamson wrote: > > > The 'merge' option gives me a similar error. The 'delay' option is > > > the only other choice where I can actually sta

Re: [PATCH for-5.0 1/2] aspeed: change the "scu" property definition

2019-11-18 Thread Joel Stanley
On Mon, 18 Nov 2019 at 16:17, Cédric Le Goater wrote: > > The Aspeed Watchdog and Timer models have a link pointing to the SCU > controller model of the machine. > > Change the "scu" property definition so that it explicitly sets the > pointer. The property isn't optional : not being able to set t

Re: [PATCH for-5.0 2/2] aspeed: change the "nic" property definition

2019-11-18 Thread Joel Stanley
On Mon, 18 Nov 2019 at 16:17, Cédric Le Goater wrote: > > The Aspeed MII model has a link pointing to its associated FTGMAC100 > NIC in the machine. > > Change the "nic" property definition so that it explicitly sets the > pointer. The property isn't optional : not being able to set the link > is

Re: [PATCH v3 2/4] iotests: Switch nbd tests to use Unix rather than TCP

2019-11-18 Thread Eric Blake
On 11/18/19 4:18 PM, Eric Blake wrote: If anything, I'm inclined to use $SOCK_DIR/nbd.raw to indicate that the NBD client sees raw format, regardless of the format in use by the server, to leave the door open for $SOCK_DIR/nbd.qcow2 when we finally are happy to test qcow2 format over NBD.

Re: [PATCH-for-4.2 v4 0/2] hw: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
This is material for 4.2-rc2. On 11/18/19 11:27 PM, Philippe Mathieu-Daudé wrote: This series fixes LP#1844817 [2]. (Eric noted in [1] the dtrace via stap backend can not support the dynamic '*' width format.) If they are trivial/block/tracing pull in preparation, this series will be happy to

[PATCH v4 2/2] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't need this anymore. Instead, disp

[PATCH v4 1/2] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't need this anymore. Instead, disp

[PATCH v4 0/2] hw: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
This series fixes LP#1844817 [2]. (Eric noted in [1] the dtrace via stap backend can not support the dynamic '*' width format.) If they are trivial/block/tracing pull in preparation, this series will be happy to be taken, else it will go via mips-next. Thanks, Phil. [1] https://lists.gnu.org/a

Re: [PATCH v3 2/4] iotests: Switch nbd tests to use Unix rather than TCP

2019-11-18 Thread Eric Blake
On 11/18/19 11:42 AM, Eric Blake wrote: - TEST_IMG="$DRIVER,file.driver=nbd,file.host=127.0.0.1,file.port=10810" + TEST_IMG="$DRIVER,file.driver=nbd,file.type=unix,file.path=$SOCKDIR/$IMGFMT" Maybe nbd.$IMGFMT? At first glance, it seems reasonable.  But reading further,

Re: [PATCH] target/i386: Remove monitor from some CPU model

2019-11-18 Thread Eduardo Habkost
On Fri, Nov 15, 2019 at 04:33:45PM +0800, Tao Xu wrote: > Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana > CPU model to remove MONITOR/MWAIT feature. > > After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT > (commit id 6f131f13e68d648a8e4f083c667ab1acd88ce4cd)

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-18 Thread Paolo Bonzini
On 18/11/19 22:44, Marcelo Tosatti wrote: > Second patch blocks NTPd from synchronizing to a source at all > (can't even confirm if it fails to synchronize after a while). > > Problem seems to be that calling from timer interrupt path: > >/* > * if the periodic timer's update is due to p

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-18 Thread Eduardo Habkost
On Mon, Nov 18, 2019 at 09:19:55PM +, Peter Maydell wrote: > On Mon, 18 Nov 2019 at 18:49, Eduardo Habkost wrote: > > Be them experimental or deprecated, we need all features included > > on "max" if we want to make them usable through libvirt. The > > fact Peter cares about defaults in "max"

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-18 Thread Marcelo Tosatti
On Sun, Nov 17, 2019 at 11:12:43AM +0100, Paolo Bonzini wrote: > On 17/11/19 05:31, Alex Williamson wrote: > > The 'merge' option gives me a similar error. The 'delay' option is > > the only other choice where I can actually start the VM, but this > > results in the commandline: > > > > -rtc base

Re: [PATCH-for-4.2 v3 3/3] trace: Forbid dynamic field width in event format

2019-11-18 Thread Philippe Mathieu-Daudé
On 11/18/19 10:26 PM, Eric Blake wrote: On 11/18/19 3:04 PM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), forbid them. Add a check to refuse field width in new formats:    $ make    [...] GEN hw/block/trac

Re: [PATCH-for-4.2 v3 3/3] trace: Forbid dynamic field width in event format

2019-11-18 Thread Eric Blake
On 11/18/19 3:04 PM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), forbid them. Add a check to refuse field width in new formats: $ make [...] GEN hw/block/trace.h Traceback (most recent call last):

Re: [PATCH 2/2] target/arm: Relax r13 restriction for ldrex/strex for v8.0

2019-11-18 Thread Peter Maydell
On Mon, 18 Nov 2019 at 20:02, Richard Henderson wrote: > > On 11/18/19 6:53 PM, Peter Maydell wrote: > > On Mon, 18 Nov 2019 at 13:16, Richard Henderson > > wrote: > >> > >> On 11/18/19 2:10 PM, Peter Maydell wrote: > /* We UNDEF for these UNPREDICTABLE cases. */ > if (a->rn

[PATCH v3 6/6] Added tests for close and change of logfile.

2019-11-18 Thread Robert Foley
One test ensures that the logfile handle is still valid even if the logfile is changed during logging. The other test validates that the logfile handle remains valid under the logfile lock even if the logfile is closed. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- v1 - Changes fo

Re: [PATCH-for-4.2 v3 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
On 11/18/19 10:15 PM, Eric Blake wrote: On 11/18/19 3:04 PM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of

Re: [PATCH-for-4.2 v3 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Eric Blake
On 11/18/19 3:04 PM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic fi

[PATCH v3 3/6] Add a mutex to guarantee single writer to qemu_logfile handle.

2019-11-18 Thread Robert Foley
Also added qemu_logfile_init() for initializing the logfile mutex. Note that inside qemu_set_log() we needed to add a pair of qemu_mutex_unlock() calls in order to avoid a double lock in qemu_log_close(). This unavoidable temporary ugliness will be cleaned up in a later patch in this series. Sig

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-18 Thread Peter Maydell
On Mon, 18 Nov 2019 at 18:49, Eduardo Habkost wrote: > Be them experimental or deprecated, we need all features included > on "max" if we want to make them usable through libvirt. The > fact Peter cares about defaults in "max" when used by humans > indicates we have incompatible definitions of "m

[PATCH v3 2/6] Cleaned up flow of code in qemu_set_log(), to simplify and clarify.

2019-11-18 Thread Robert Foley
Also added some explanation of the reasoning behind the branches. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- v2 - This is new in patch v2. --- util/log.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/util/log.c b/util/log.c index 43

[PATCH v3 0/6] Make the qemu_logfile handle thread safe.

2019-11-18 Thread Robert Foley
This patch adds thread safety to the qemu_logfile handle. This now allows changing the logfile while logging is active, and also solves the issue of a seg fault while changing the logfile. This patch adds use of RCU for handling the swap out of the old qemu_logfile file descriptor. Also added

[PATCH v3 5/6] Add use of RCU for qemu_logfile.

2019-11-18 Thread Robert Foley
This now allows changing the logfile while logging is active, and also solves the issue of a seg fault while changing the logfile. Any read access to the qemu_logfile handle will use the rcu_read_lock()/unlock() around the use of the handle. To fetch the handle we will use atomic_rcu_read(). We al

[PATCH v3 4/6] qemu_log_lock/unlock now preserves the qemu_logfile handle.

2019-11-18 Thread Robert Foley
qemu_log_lock() now returns a handle and qemu_log_unlock() receives a handle to unlock. This allows for changing the handle during logging and ensures the lock() and unlock() are for the same file. Also in target/tilegx/translate.c removed the qemu_log_lock()/unlock() calls (and the log("\n")), s

[PATCH v3 1/6] Fix double free issue in qemu_set_log_filename().

2019-11-18 Thread Robert Foley
After freeing the logfilename, we set logfilename to NULL, in case of an error which returns without setting logfilename. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- v2 - moved this change to the beginning of the patch series. --- v1 - This is new in the patch v1. --- util/

Re: [PATCH-for-4.2 v3 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Eric Blake
On 11/18/19 3:04 PM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic fi

[PATCH-for-4.2 v3 3/3] trace: Forbid dynamic field width in event format

2019-11-18 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), forbid them. Add a check to refuse field width in new formats: $ make [...] GEN hw/block/trace.h Traceback (most recent call last): File "scripts/tracetool.py", line 152, in mai

[PATCH-for-4.2 v3 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't need this anymore. Instead, disp

[PATCH-for-4.2 v3 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. We previously passed to the trace API 'width << 1' as the number of hex characters to display (the dynamic field width). We don't need this anymore. Instead, disp

[PATCH-for-4.2 v3 0/3] hw: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
Eric noted in [1] the dtrace via stap backend can not support the dynamic '*' width format. I'd really like to use dynamic width in trace event because the read/write accesses are easier to read but it is not a priority. Since next release is close, time to fix LP#1844817 [2]. Since v2: - addresse

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-11-18 Thread Michael Weiser
I've done some security updates on my Debian, Windows 7 64 and 32 Bit VMs and quite intensively used a Windows 1903 VM today without any corruption. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18464

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
On 11/18/19 8:21 PM, Eric Blake wrote: On 11/14/19 3:26 PM, Philippe Mathieu-Daudé wrote: -    trace_pflash_data_read(offset, width << 1, ret); +    trace_pflash_data_read(offset, width << 3, ret); Umm, why is width changing?  That's not mentioned in the commit message. Previously it was us

Re: [PATCH 0/4] target/arm vector improvements

2019-11-18 Thread Richard Henderson
On 11/18/19 5:26 PM, Peter Maydell wrote: > On Thu, 17 Oct 2019 at 05:42, Richard Henderson > wrote: >> >> The first patch has been seen before. >> >> https://patchwork.ozlabs.org/patch/1115039/ >> >> It had a bug and I didn't fix it right away and then forgot. >> Fixed now; I had mixed up the o

Re: [PATCH 2/2] target/arm: Relax r13 restriction for ldrex/strex for v8.0

2019-11-18 Thread Richard Henderson
On 11/18/19 6:53 PM, Peter Maydell wrote: > On Mon, 18 Nov 2019 at 13:16, Richard Henderson > wrote: >> >> On 11/18/19 2:10 PM, Peter Maydell wrote: /* We UNDEF for these UNPREDICTABLE cases. */ if (a->rn == 15 || a->rt == 15 -|| (s->thumb && a->rt == 13) +

[PATCH for-4.2] target/arm: Support EL0 v7m msr/mrs for CONFIG_USER_ONLY

2019-11-18 Thread Richard Henderson
Simply moving the non-stub helper_v7m_mrs/msr outside of !CONFIG_USER_ONLY is not an option, because of all of the other system-mode helpers that are called. But we can split out a few subroutines to handle the few EL0 accessible registers without duplicating code. Reported-by: Christophe Lyon S

Re: [PATCH for-5.0 2/2] aspeed: change the "nic" property definition

2019-11-18 Thread Greg Kurz
On Mon, 18 Nov 2019 17:17:12 +0100 Cédric Le Goater wrote: > The Aspeed MII model has a link pointing to its associated FTGMAC100 > NIC in the machine. > > Change the "nic" property definition so that it explicitly sets the > pointer. The property isn't optional : not being able to set the link

Re: [PATCH for-5.0 1/2] aspeed: change the "scu" property definition

2019-11-18 Thread Greg Kurz
On Mon, 18 Nov 2019 17:17:11 +0100 Cédric Le Goater wrote: > The Aspeed Watchdog and Timer models have a link pointing to the SCU > controller model of the machine. > > Change the "scu" property definition so that it explicitly sets the > pointer. The property isn't optional : not being able to

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Eric Blake
On 11/14/19 3:26 PM, Philippe Mathieu-Daudé wrote: -    trace_pflash_data_read(offset, width << 1, ret); +    trace_pflash_data_read(offset, width << 3, ret); Umm, why is width changing?  That's not mentioned in the commit message. Previously it was used to set the format width: [1, 2, 4] ->

[Bug 1853042] Re: Ubuntu 18.04 - vm disk i/o performance issue when using file system passthrough

2019-11-18 Thread Andrew Cloke
** Also affects: qemu Importance: Undecided Status: New ** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** No longer affects: qemu ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Canonical Server Team (canonical-server) ** Changed i

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Eric Blake
On 11/18/19 1:10 PM, Philippe Mathieu-Daudé wrote: -    trace_gt64120_write("INTRCAUSE", size << 1, val); +    trace_gt64120_write("INTRCAUSE", size << 3, val); Again, this isn't mentioned in the commit message.  Why are you changing parameter values? +++ b/hw/mips/trace-events @@

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
On 11/14/19 10:24 PM, Philippe Mathieu-Daudé wrote: On 11/8/19 4:58 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric

Re: [PATCH v3 04/33] chardev: generate an internal id when none given

2019-11-18 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 6:12 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:33, Marc-André Lureau > wrote: > > > > Internally, qemu may create chardev without ID. Those will not be > > looked up with qemu_chr_find(), which prevents using qdev_prop_set_chr(). > > > > Use id_generate(),

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-18 Thread Eduardo Habkost
On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: > Some device's property can be changed if the device has been already > realized. For example, it could be "drive" property of a scsi disk device. > > So far, set_pointer could operate only on a relized device. The patch > extends i

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-18 Thread Eduardo Habkost
On Mon, Nov 18, 2019 at 11:56:43AM +0100, David Hildenbrand wrote: > On 18.11.19 11:53, Peter Maydell wrote: > > On Mon, 18 Nov 2019 at 10:47, David Hildenbrand wrote: > > > My personal opinion: "max" really means "all features". If we want an > > > automatic way to specify something you requested

[PULL 2/3] vfio: don't ignore return value of migrate_add_blocker

2019-11-18 Thread Alex Williamson
From: Jens Freimann When an error occurs in migrate_add_blocker() it sets a negative return value and uses error pointer we pass in. Instead of just looking at the error pointer check for a negative return value and avoid a coverity error because the return value is set but never used. This fixes

[PULL 3/3] vfio: vfio-pci requires EDID

2019-11-18 Thread Alex Williamson
From: Paolo Bonzini hw/vfio/display.c needs the EDID subsystem, select it. Cc: Alex Williamson Signed-off-by: Paolo Bonzini Signed-off-by: Alex Williamson --- hw/vfio/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/Kconfig b/hw/vfio/Kconfig index 34da2a3cfdd9..f0eaa75c

[PULL 1/3] hw/vfio/pci: Fix double free of migration_blocker

2019-11-18 Thread Alex Williamson
From: Michal Privoznik When user tries to hotplug a VFIO device, but the operation fails somewhere in the middle (in my testing it failed because of RLIMIT_MEMLOCK forbidding more memory allocation), then a double free occurs. In vfio_realize() the vdev->migration_blocker is allocated, then somet

[PULL 0/3] VFIO fixes 2019-11-18

2019-11-18 Thread Alex Williamson
The following changes since commit 1bd0f1c9c149c2fb738f381099cec7ad0ee224a9: Merge remote-tracking branch 'remotes/kraxel/tags/seabios-20191118-pull-request' into staging (2019-11-18 14:30:24 +) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git

  1   2   3   >