Re: [PATCH for-5.0 v5 11/23] ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helper

2019-11-20 Thread Greg Kurz
On Wed, 20 Nov 2019 22:40:31 +0100 Cédric Le Goater wrote: > On 20/11/2019 18:26, Greg Kurz wrote: > > On Fri, 15 Nov 2019 17:24:24 +0100 > > Cédric Le Goater wrote: > > > >> and use this helper to exclude CPUs which are not enabled in the XIVE > >> controller. > >> > >> Signed-off-by: Cédric L

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-20 Thread Cédric Le Goater
On 21/11/2019 08:30, Greg Kurz wrote: > On Thu, 21 Nov 2019 08:01:44 +0100 > Cédric Le Goater wrote: > >> On 20/11/2019 19:30, Greg Kurz wrote: >>> On Fri, 15 Nov 2019 17:24:28 +0100 >>> Cédric Le Goater wrote: >>> Now that the machines have handlers implementing the XiveFabric and Xiv

Re: [PATCH for-5.0 v5 14/23] ppc/spapr: Implement the XiveFabric interface

2019-11-20 Thread Cédric Le Goater
On 21/11/2019 08:24, Greg Kurz wrote: > On Thu, 21 Nov 2019 07:56:32 +0100 > Cédric Le Goater wrote: > >> On 20/11/2019 18:53, Greg Kurz wrote: >>> On Fri, 15 Nov 2019 17:24:27 +0100 >>> Cédric Le Goater wrote: >>> The CAM line matching sequence in the pseries machine does not change m

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-20 Thread Greg Kurz
On Thu, 21 Nov 2019 08:01:44 +0100 Cédric Le Goater wrote: > On 20/11/2019 19:30, Greg Kurz wrote: > > On Fri, 15 Nov 2019 17:24:28 +0100 > > Cédric Le Goater wrote: > > > >> Now that the machines have handlers implementing the XiveFabric and > >> XivePresenter interfaces, remove xive_presenter

Re: [PATCH for-5.0 v5 14/23] ppc/spapr: Implement the XiveFabric interface

2019-11-20 Thread Greg Kurz
On Thu, 21 Nov 2019 07:56:32 +0100 Cédric Le Goater wrote: > On 20/11/2019 18:53, Greg Kurz wrote: > > On Fri, 15 Nov 2019 17:24:27 +0100 > > Cédric Le Goater wrote: > > > >> The CAM line matching sequence in the pseries machine does not change > >> much apart from the use of the new QOM interf

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-20 Thread Juan Quintela
Laurent Vivier wrote: > On ppc64, migration-test only works with kvm_hv, and we already > have a check to verify the module is loaded. > > kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists, > but on some systems (like build systems) /dev/kvm can be missing > (by administrators ch

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-20 Thread Cédric Le Goater
On 20/11/2019 19:30, Greg Kurz wrote: > On Fri, 15 Nov 2019 17:24:28 +0100 > Cédric Le Goater wrote: > >> Now that the machines have handlers implementing the XiveFabric and >> XivePresenter interfaces, remove xive_presenter_match() and make use >> of the 'match_nvt' handler of the machine. >> >>

Re: [PATCH for-5.0 v5 14/23] ppc/spapr: Implement the XiveFabric interface

2019-11-20 Thread Cédric Le Goater
On 20/11/2019 18:53, Greg Kurz wrote: > On Fri, 15 Nov 2019 17:24:27 +0100 > Cédric Le Goater wrote: > >> The CAM line matching sequence in the pseries machine does not change >> much apart from the use of the new QOM interfaces. There is an extra >> indirection because of the sPAPR IRQ backend o

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-20 Thread Marc-André Lureau
Hi On Wed, Nov 20, 2019 at 10:54 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > On Tue, Nov 19, 2019 at 2:35 PM Peter Maydell > > wrote: > > > > > > On Tue, 19 Nov 2019 at 10:23, Marc-André Lureau > > > wrote: > > > > On Mon, Nov 18, 2019 at 6:

Re: [PATCH 0/6] qapi: Module fixes and cleanups

2019-11-20 Thread Markus Armbruster
Markus Armbruster writes: > Kevin recently posted a minimally invasive fix for empty QAPI > modules[*]. This is my attempt at a fix that also addresses the > design weakness that led to the bug. [*] Subject: [RFC PATCH 15/18] qapi: Support empty modules Message-Id: <20191017130204.16131-16-kw..

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-20 Thread Aleksandar Markovic
On Wed, Nov 20, 2019 at 8:49 AM Richard Henderson wrote: > > How's that? He has been asked to split the linux-user stuff from the target > skeleton stuff. ... > This argument would make more sense if there were more present here than a > skeleton. Speaking about anatomy, I am opposed to upstr

Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
On Thu, Nov 21, 2019 at 6:41 AM Geoffrey McRae wrote: > > > > On 2019-11-20 23:13, Tomasz Figa wrote: > > Hi Geoffrey, > > > > On Thu, Nov 7, 2019 at 7:28 AM Geoffrey McRae > > wrote: > >> > >> > >> > >> On 2019-11-06 23:41, Gerd Hoffmann wrote: > >> > On Wed, Nov 06, 2019 at 05:36:22PM +0900, Da

Re: [PATCH v3 0/4] net/virtio: fixes for failover

2019-11-20 Thread Jason Wang
On 2019/11/20 下午11:56, Michael S. Tsirkin wrote: On Wed, Nov 20, 2019 at 04:49:47PM +0100, Jens Freimann wrote: This series fixes bugs found by coverity and one reported by David Gilbert. Looks good. Jason can you merge this pls? Yes, applied. Thanks v2->v3: * change patch descri

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-20 Thread David Gibson
On Wed, Nov 20, 2019 at 03:28:19PM +0100, Laurent Vivier wrote: > On 20/11/2019 12:41, David Gibson wrote: > > On Wed, Nov 20, 2019 at 12:28:19PM +0100, Laurent Vivier wrote: > >> On 20/11/2019 10:00, Laurent Vivier wrote: > >>> On 20/11/2019 05:36, David Gibson wrote: > On Tue, Nov 19, 2019 a

[PATCH v6] Implement backend program convention command for vhost-user-blk

2019-11-20 Thread Micky Yun Chan
From: michan This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 108 ++-- docs/interop/vhost-user.json| 31 +++ 2 file

Open ISA (RISC-V, OpenPOWER, etc) Miniconf at LCA 2020

2019-11-20 Thread Alistair Francis
Hi All, We’re pleased to announce the first Open ISA miniconf at linux.conf.au Open Instruction Set Architectures like RISC-V, OpenPOWER and others are the next step in the evolution of Open Hardware. The mini-conference will commence with a brief overview of Open ISAs in general. It will then

Re: [PATCH] exynos4210_gic: Suppress gcc9 format-truncation warnings

2019-11-20 Thread David Gibson
On Wed, Nov 20, 2019 at 10:31:48AM +, Peter Maydell wrote: > On Wed, 20 Nov 2019 at 05:27, David Gibson > wrote: > > > > On Mon, Oct 14, 2019 at 01:51:39PM +0100, Peter Maydell wrote: > > > If we assert() that num_cpu is always <= EXYNOS4210_NCPUS > > > is that sufficient to clue gcc in that

Re: [PATCH] pseries: fix migration-test and pxe-test

2019-11-20 Thread David Gibson
On Wed, Nov 20, 2019 at 03:25:39PM +0100, Laurent Vivier wrote: > Commit 29cb4187497d ("spapr: Set VSMT to smp_threads by default") > has introduced a new default value for VSMT that is not supported > by old kernels (before 4.13 kernel) and this breaks "make check" > on these kernels. > > To fix

[PATCH v2] exynos4210_gic: Suppress gcc9 format-truncation warnings

2019-11-20 Thread David Gibson
exynos4210_gic_realize() prints the number of cpus into some temporary buffers, but it only allows 3 bytes space for it. That's plenty: existing machines will only ever set this value to EXYNOS4210_NCPUS (2). But the compiler can't always figure that out, so some[*] gcc9 versions emit -Wformat-tr

Re: [PATCH v16 11/14] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-11-20 Thread Tao Xu
On 11/20/2019 6:09 PM, Igor Mammedov wrote: On Fri, 15 Nov 2019 15:53:49 +0800 Tao Xu wrote: From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in

Re: [PATCH v16 08/14] numa: Extend CLI to provide memory latency and bandwidth information

2019-11-20 Thread Tao Xu
On 11/20/2019 8:56 PM, Igor Mammedov wrote: On Wed, 20 Nov 2019 15:55:04 +0800 Tao Xu wrote: On 11/19/2019 7:03 PM, Igor Mammedov wrote: On Fri, 15 Nov 2019 15:53:46 +0800 Tao Xu wrote: From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Informat

[PATCH 2/5] vfio/pci: Split vfio_intx_update()

2019-11-20 Thread David Gibson
This splits the vfio_intx_update() function into one part doing the actual reconnection with the KVM irqchip (vfio_intx_update(), now taking an argument with the new routing) and vfio_intx_routing_notifier() which handles calls to the pci device intx routing notifier and calling vfio_intx_update()

[PATCH 1/5] kvm: Introduce KVM irqchip change notifier

2019-11-20 Thread David Gibson
Awareness of an in kernel irqchip is usually local to the machine and its top-level interrupt controller. However, in a few cases other things need to know about it. In particular vfio devices need this in order to accelerate interrupt delivery. If interrupt routing is changed, such devices may

[PATCH 4/5] spapr: Handle irq backend changes with VFIO PCI devices

2019-11-20 Thread David Gibson
pseries machine type can have one of two different interrupt controllers in use depending on feature negotiation with the guest. Usually this is invisible to devices, because they route to a common set of qemu_irqs which in turn dispatch to the correct back end. VFIO passthrough devices, however,

[PATCH 3/5] vfio/pci: Respond to KVM irqchip change notifier

2019-11-20 Thread David Gibson
VFIO PCI devices already respond to the pci intx routing notifier, in order to update kernel irqchip mappings when routing is updated. However this won't handle the case where the irqchip itself is replaced by a different model while retaining the same routing. This case can happen on the pseries

[PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-20 Thread David Gibson
Due to the way feature negotiation works in PAPR (which is a paravirtualized platform), we can end up changing the global irq chip at runtime, including it's KVM accelerate model. That causes complications for VFIO devices with INTx, which wire themselves up directly to the KVM irqchip for perform

[PATCH 5/5] spapr: Work around spurious warnings from vfio INTx initialization

2019-11-20 Thread David Gibson
Traditional PCI INTx for vfio devices can only perform well if using an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning if an in kernel irqchip is not available. We usually do have an in-kernel irqchip available for pseries machines on POWER hosts. However, because the platform

Re: [PATCH v16 13/14] tests/numa: Add case for QMP build HMAT

2019-11-20 Thread Tao Xu
On 11/20/2019 8:32 PM, Igor Mammedov wrote: On Fri, 15 Nov 2019 15:53:51 +0800 Tao Xu wrote: Check configuring HMAT usecase Suggested-by: Igor Mammedov Signed-off-by: Tao Xu --- New patch in v16. --- tests/numa-test.c | 51 +++ 1 file changed,

[PATCH v3 4/4] target/arm: Add support for DC CVAP & DC CVADP ins

2019-11-20 Thread Beata Michalska
ARMv8.2 introduced support for Data Cache Clean instructions to PoP (point-of-persistence) - DC CVAP and PoDP (point-of-deep-persistence) - DV CVADP. Both specify conceptual points in a memory system where all writes that are to reach them are considered persistent. The support provided considers b

[PATCH v3 3/4] migration: ram: Switch to ram block writeback

2019-11-20 Thread Beata Michalska
Switch to ram block writeback for pmem migration. Signed-off-by: Beata Michalska Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Acked-by: Dr. David Alan Gilbert --- migration/ram.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram

[PATCH v3 2/4] Memory: Enable writeback for given memory region

2019-11-20 Thread Beata Michalska
Add an option to trigger memory writeback to sync given memory region with the corresponding backing store, case one is available. This extends the support for persistent memory, allowing syncing on-demand. Signed-off-by: Beata Michalska --- exec.c | 36 +

[PATCH v3 1/4] tcg: cputlb: Add probe_read

2019-11-20 Thread Beata Michalska
Add probe_read alongside the write probing equivalent. Signed-off-by: Beata Michalska Reviewed-by: Alex Bennée --- include/exec/exec-all.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index d85e610..350c4b4 100644 --- a/include/exec

[PATCH v3 0/4] target/arm: Support for Data Cache Clean up to PoP

2019-11-20 Thread Beata Michalska
ARMv8.2 introduced support for Data Cache Clean instructions to PoP (point-of-persistence) and PoDP (point-of-deep-persistence): ARMv8.2-DCCVAP & ARMv8.2-DCCVADP respectively. This patch set adds support for emulating both, though there is no distinction between the two points: the PoDP is assumed

Re: [PATCH 0/6] qapi: Module fixes and cleanups

2019-11-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191120182551.23795-1-arm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: 9p: requests efficiency

2019-11-20 Thread Christian Schoenebeck
On Freitag, 15. November 2019 14:26:56 CET Greg Kurz wrote: > > However when there are a large number of (i.e. small) 9p requests, no > > matter what the actual request type is, then I am encountering severe > > performance issues with 9pfs and I try to understand whether this could > > be improved

Re: [PATCH v4 25/37] dp8393x: replace PROP_PTR with PROP_LINK

2019-11-20 Thread Laurent Vivier
Le 20/11/2019 à 16:24, Marc-André Lureau a écrit : > Link property is the correct way to pass a MemoryRegion to a device > for DMA purposes. > > Sidenote: as a sysbus device, this remains non-usercreatable > even though we can drop the specific flag here. > > Signed-off-by: Marc-André Lureau > R

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
On Wed, Nov 20, 2019 at 10:13 PM Aleksandar Markovic wrote: > > On Wed, Nov 20, 2019 at 3:58 PM Helge Deller wrote: > > > > Improve strace output of various syscalls which either have none > > or only int-type parameters. > > > > Signed-off-by: Helge Deller > > > > It would be nice if you includ

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Paolo Bonzini
On 20/11/19 22:15, Eduardo Habkost wrote: > > For how long was this broken? Jiri, was libvirt including +vmx > in mode=host-model for a long time, or is this something recent? Could that be related to making nested=1 the default in the kernel? KVM has static void vmx_set_supported_cpuid(u32 fu

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

2019-11-20 Thread Scott Cheloha
On Mon, Oct 21, 2019 at 09:14:44AM +0100, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Oct 18, 2019 at 10:43:52AM +0100, Dr. David Alan Gilbert wrote: > > > * Laurent Vivier (lviv...@redhat.com) wrote: > > > > On 18/10/2019 10:16, Dr. David Alan Gi

Re: guest / host buffer sharing ...

2019-11-20 Thread Geoffrey McRae
On 2019-11-20 23:13, Tomasz Figa wrote: Hi Geoffrey, On Thu, Nov 7, 2019 at 7:28 AM Geoffrey McRae wrote: On 2019-11-06 23:41, Gerd Hoffmann wrote: > On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote: >> > (1) The virtio device >> > = >> > >> > Has a sing

Re: [PATCH for-5.0 v5 11/23] ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helper

2019-11-20 Thread Cédric Le Goater
On 20/11/2019 18:26, Greg Kurz wrote: > On Fri, 15 Nov 2019 17:24:24 +0100 > Cédric Le Goater wrote: > >> and use this helper to exclude CPUs which are not enabled in the XIVE >> controller. >> >> Signed-off-by: Cédric Le Goater >> --- >> hw/intc/pnv_xive.c | 18 ++ >> 1 file ch

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-20 Thread Eric Blake
On 11/20/19 12:45 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 141 + tests/qemu-iotests/274.out| 227 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 files ch

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-20 Thread Eric Blake
On 11/20/19 12:44 PM, Kevin Wolf wrote: When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Eduardo Habkost
On Wed, Nov 20, 2019 at 09:49:35PM +0100, Paolo Bonzini wrote: > On 20/11/19 19:45, Eduardo Habkost wrote: > > On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: > >> This allows using "-cpu Haswell,+vmx", which we did not really want to > >> support in QEMU but was produced by Libvirt

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
On Wed, Nov 20, 2019 at 3:58 PM Helge Deller wrote: > > Improve strace output of various syscalls which either have none > or only int-type parameters. > > Signed-off-by: Helge Deller > It would be nice if you included a history of the patch (after the line "---", as it is customary for single p

Re: [PATCH] configure: Use lld --image-base for --disable-pie user mode binaries

2019-11-20 Thread Fangrui Song
On 2019-11-15, Fangrui Song wrote: For lld, --image-base is the preferred way to set the base address. lld does not actually implement -Ttext-segment, but treats it as an alias for -Ttext. -Ttext-segment=0x6000 combined with --no-rosegment can create a 1.6GB executable. Fix the problem by us

Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
On Wed, Nov 20, 2019 at 9:57 PM Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 8:05 PM Helge Deller wrote: > > > > Improve strace output of various syscalls which either have none > > or only int-type parameters. > > > > Signed-off-by: Helge Deller > > > > A very good patch! > > It would

Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
On Tue, Nov 19, 2019 at 8:05 PM Helge Deller wrote: > > Improve strace output of various syscalls which either have none > or only int-type parameters. > > Signed-off-by: Helge Deller > A very good patch! It would be even better if it covered ALL syscalls either without parameter or with all in

Re: [PATCH 6/6] qapi: Simplify QAPISchemaModularCVisitor

2019-11-20 Thread Eric Blake
On 11/20/19 12:25 PM, Markus Armbruster wrote: Since the previous commit, QAPISchemaVisitor.visit_module() is called just once. Simplify QAPISchemaModularCVisitor accordingly. Signed-off-by: Markus Armbruster --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, I

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Paolo Bonzini
On 20/11/19 19:45, Eduardo Habkost wrote: > On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: >> This allows using "-cpu Haswell,+vmx", which we did not really want to >> support in QEMU but was produced by Libvirt when using the "host-model" >> CPU model. > > I understand guest ABI c

Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
> @@ -26,7 +26,7 @@ > { TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_alarm > -{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL }, > +{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL }, > #endif Man page says: unsigned int alarm(unsigned int seconds) Th

Re: [PATCH 5/6] qapi: Fix code generation for empty modules

2019-11-20 Thread Eric Blake
On 11/20/19 12:25 PM, Markus Armbruster wrote: When a sub-module doesn't contain any definitions, we don't generate code for it, but we do generate the #include. We generate code only for modules that get visited. QAPISchema.visit() visits only modules that have definitions. It can visit module

Re: [PATCH 4/6] qapi: Proper intermediate representation for modules

2019-11-20 Thread Eric Blake
On 11/20/19 12:25 PM, Markus Armbruster wrote: Modules are represented only by their names so far. Introduce class QAPISchemaModule. So far, it merely wraps the name. The next patch will put it to more interesting use. Once again, arrays spice up the patch a bit. For any other type, @info po

Re: [PATCH] target/i386: add support for MSR_IA32_TSX_CTRL

2019-11-20 Thread Eduardo Habkost
On Wed, Nov 20, 2019 at 01:19:22PM +0100, Paolo Bonzini wrote: > The MSR_IA32_TSX_CTRL MSR can be used to hide TSX (also known as the > Trusty Side-channel Extension). By virtualizing the MSR, KVM guests > can disable TSX and avoid paying the price of mitigating TSX-based > attacks on microarchite

Re: [PATCH 0/6] qapi: Module fixes and cleanups

2019-11-20 Thread Markus Armbruster
Fat-fingered Kevin's e-mail address... Markus Armbruster writes: > Kevin recently posted a minimally invasive fix for empty QAPI > modules[*]. This is my attempt at a fix that also addresses the > design weakness that led to the bug. > > Markus Armbruster (6): > qapi: Tweak "command returns a

Re: [PATCH 3/6] qapi: Generate command registration stuff into separate files

2019-11-20 Thread Eric Blake
On 11/20/19 12:25 PM, Markus Armbruster wrote: Having to include qapi-commands.h just for qmp_init_marshal() is suboptimal. Generate it into separate files. This lets monitor/misc.c, qga/main.c, and the generated qapi-commands-FOO.h include less. Signed-off-by: Markus Armbruster --- +++ b/

Re: [PATCH 2/6] tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]

2019-11-20 Thread Eric Blake
On 11/20/19 12:25 PM, Markus Armbruster wrote: Commit 5d75648b56 "qapi: Generate QAPIEvent stuff into separate files" added tests/test-qapi-emit-events.[ch] to the set of generated files, but neglected to update tests/.gitignore and tests/Makefile.include. Commit a0af8cee3c "tests/.gitignore: ign

[Bug 1852781] Re: qemu s390x on focal - applications breaking

2019-11-20 Thread Frank Heimes
** Also affects: ubuntu-z-systems Importance: Undecided Status: New ** Changed in: ubuntu-z-systems Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1852781 T

[PATCH 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands

2019-11-20 Thread Maxim Levitsky
This way they all will be prefixed with 'Error:' which some parsers (e.g libvirt need) Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index

Re: [PATCH 1/6] qapi: Tweak "command returns a nice type" check for clarity

2019-11-20 Thread Eric Blake
On 11/20/19 12:25 PM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- scripts/qapi/schema.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index cf0045f34e..cfb574c85d 100

[PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

2019-11-20 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 247 monitor/hmp-cmds.c | 245 --- 2 files changed, 247 insertions(+), 245 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 76951

[PATCH 7/9] monitor: move remaining hmp_block* functions to blockdev-hmp-cmds.c

2019-11-20 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 63 monitor/hmp-cmds.c | 64 - 2 files changed, 63 insertions(+), 64 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index f3d22c7

[PATCH 1/9] monitor: uninline add_init_drive

2019-11-20 Thread Maxim Levitsky
This is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky --- device-hotplug.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/device-hotplug.c b/device-hotplug.c index

[PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c

2019-11-20 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 52 + monitor/hmp-cmds.c | 52 - 2 files changed, 52 insertions(+), 52 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 5ae899

[PATCH 4/9] monitor: move hmp_drive_mirror and hmp_drive_backup to blockdev-hmp-cmds.c

2019-11-20 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 61 + monitor/hmp-cmds.c | 58 -- 2 files changed, 61 insertions(+), 58 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 888461823

[PATCH 6/9] monitor: move hmp_snapshot_* to blockdev-hmp-cmds.c

2019-11-20 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 47 + monitor/hmp-cmds.c | 46 2 files changed, 47 insertions(+), 46 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index e333de2

[PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c

2019-11-20 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- blockdev-hmp-cmds.c | 97 - blockdev.c | 95 2 files changed, 96 insertions(+), 96 deletions(-) diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c index 21ff6fa

[PATCH 2/9] monitor: rename device-hotplug.c to blockdev-hmp-cmds.c

2019-11-20 Thread Maxim Levitsky
These days device-hotplug.c only contains the hmp_drive_add In the next patch, rest of hmp_drive* functions will be moved there. Signed-off-by: Maxim Levitsky --- MAINTAINERS | 1 + Makefile.objs | 4 ++-- device-hotplug.c => blockdev-hmp-cmd

[PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

2019-11-20 Thread Maxim Levitsky
This patch series is bunch of cleanups to the hmp monitor code. This series only touched blockdev related hmp handlers. No functional changes expected other that light error message changes by the last patch. This was inspired by this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1719169

Re: [PATCH v3 07/33] serial: register vmsd with DeviceClass

2019-11-20 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Tue, Nov 19, 2019 at 2:35 PM Peter Maydell > wrote: > > > > On Tue, 19 Nov 2019 at 10:23, Marc-André Lureau > > wrote: > > > On Mon, Nov 18, 2019 at 6:22 PM Peter Maydell > > > wrote: > > > > Did you test whether migration still work

[PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-20 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274| 141 + tests/qemu-iotests/274.out| 227 ++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 2 +- 4 files changed, 370 insertions(+), 1 deletion(-) create

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Eduardo Habkost
On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: > This allows using "-cpu Haswell,+vmx", which we did not really want to > support in QEMU but was produced by Libvirt when using the "host-model" > CPU model. I understand guest ABI compatibility is not a concern, but I don't remember

[PATCH v2 3/6] iotests: Add qemu_io_log()

2019-11-20 Thread Kevin Wolf
Add a function that runs qemu-io and logs the output with the appropriate filters applied. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/i

[PATCH v2 4/6] iotests: Fix timeout in run_job()

2019-11-20 Thread Kevin Wolf
run_job() accepts a wait parameter for a timeout, but it doesn't actually use it. The only thing that is missing is passing it to events_wait(), so do that now. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 2 +-

[PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-20 Thread Kevin Wolf
When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is shorter than its backing file: base.q

[PATCH v2 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter

2019-11-20 Thread Kevin Wolf
bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes by calling the driver in a loop until everything is done. Make the small remaining change that is necessary to let it accept a 64 bit byte count. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sements

[PATCH v2 5/6] iotests: Support job-complete in run_job()

2019-11-20 Thread Kevin Wolf
Automatically complete jobs that have a 'ready' state and need an explicit job-complete. Without this, run_job() would hang for such jobs. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 2 ++ 1 file changed, 2 ins

[PATCH for-4.2? v2 0/6] block: Fix resize (extending) of short overlays

2019-11-20 Thread Kevin Wolf
See patch 2 for the description of the bug fixed. v2: - Switched order of bs->total_sectors update and zero write [Vladimir] - Fixed coding style [Vladimir] - Changed the commit message to contain what was in the cover letter - Test all preallocation modes - Test allocation status with qemu-io 'ma

Re: [PATCH for-4.2 1/2] i386: Add new versions of Skylake/Cascadelake/Icelake without TSX

2019-11-20 Thread Eduardo Habkost
On Wed, Nov 20, 2019 at 06:40:06PM +0100, Paolo Bonzini wrote: > On 20/11/19 17:49, Eduardo Habkost wrote: > > One of the mitigation methods for TAA[1] is to disable TSX > > support on the host system. Linux added a mechanism to disable > > TSX globally through the kernel command line, and many Li

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-20 Thread Greg Kurz
On Wed, 20 Nov 2019 18:09:55 +0100 Laurent Vivier wrote: > On ppc64, migration-test only works with kvm_hv, and we already > have a check to verify the module is loaded. > > kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists, > but on some systems (like build systems) /dev/kvm c

Re: [PATCH v9 QEMU 12/15] vfio: Add load state functions to SaveVMHandlers

2019-11-20 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > Sequence during _RESUMING device state: > While data for this device is available, repeat below steps: > a. read data_offset from where user application should write data. > b. write data of data_size to migration region from data_offset. > c. write

Re: [PATCH for-5.0 v5 15/23] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-20 Thread Greg Kurz
On Fri, 15 Nov 2019 17:24:28 +0100 Cédric Le Goater wrote: > Now that the machines have handlers implementing the XiveFabric and > XivePresenter interfaces, remove xive_presenter_match() and make use > of the 'match_nvt' handler of the machine. > > Signed-off-by: Cédric Le Goater > --- > hw/in

[PATCH 5/6] qapi: Fix code generation for empty modules

2019-11-20 Thread Markus Armbruster
When a sub-module doesn't contain any definitions, we don't generate code for it, but we do generate the #include. We generate code only for modules that get visited. QAPISchema.visit() visits only modules that have definitions. It can visit modules multiple times. Clean this up as follows. Col

[PATCH 1/6] qapi: Tweak "command returns a nice type" check for clarity

2019-11-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi/schema.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index cf0045f34e..cfb574c85d 100644 --- a/scripts/qapi/schema.py +++ b/scripts/qapi/schema.py @@ -711,10 +711,11

[PATCH 0/6] qapi: Module fixes and cleanups

2019-11-20 Thread Markus Armbruster
Kevin recently posted a minimally invasive fix for empty QAPI modules[*]. This is my attempt at a fix that also addresses the design weakness that led to the bug. Markus Armbruster (6): qapi: Tweak "command returns a nice type" check for clarity tests/Makefile.include: Fix missing test-qapi-e

[PATCH 3/6] qapi: Generate command registration stuff into separate files

2019-11-20 Thread Markus Armbruster
Having to include qapi-commands.h just for qmp_init_marshal() is suboptimal. Generate it into separate files. This lets monitor/misc.c, qga/main.c, and the generated qapi-commands-FOO.h include less. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 19 --- Ma

[PATCH 4/6] qapi: Proper intermediate representation for modules

2019-11-20 Thread Markus Armbruster
Modules are represented only by their names so far. Introduce class QAPISchemaModule. So far, it merely wraps the name. The next patch will put it to more interesting use. Once again, arrays spice up the patch a bit. For any other type, @info points to the definition, which lets us map from @i

[PATCH 6/6] qapi: Simplify QAPISchemaModularCVisitor

2019-11-20 Thread Markus Armbruster
Since the previous commit, QAPISchemaVisitor.visit_module() is called just once. Simplify QAPISchemaModularCVisitor accordingly. Signed-off-by: Markus Armbruster --- scripts/qapi/commands.py | 2 +- scripts/qapi/events.py | 2 +- scripts/qapi/gen.py | 28 ++-- s

[PATCH 2/6] tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]

2019-11-20 Thread Markus Armbruster
Commit 5d75648b56 "qapi: Generate QAPIEvent stuff into separate files" added tests/test-qapi-emit-events.[ch] to the set of generated files, but neglected to update tests/.gitignore and tests/Makefile.include. Commit a0af8cee3c "tests/.gitignore: ignore test-qapi-emit-events.[ch] for in-tree builds

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Kashyap Chamarthy
On Wed, Nov 20, 2019 at 06:57:20PM +0100, Paolo Bonzini wrote: > On 20/11/19 18:50, Daniel P. Berrangé wrote: > > On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: > >> This allows using "-cpu Haswell,+vmx", which we did not really want to > >> support in QEMU but was produced by Libvi

Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

2019-11-20 Thread Jan Kiszka
On 12.11.19 09:04, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 05:38:29PM +0100, Jan Kiszka wrote: On 11.11.19 17:11, Michael S. Tsirkin wrote: On Mon, Nov 11, 2019 at 03:27:43PM +, Daniel P. Berrangé wrote: On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: On Mon,

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Daniel P . Berrangé
On Wed, Nov 20, 2019 at 06:57:20PM +0100, Paolo Bonzini wrote: > On 20/11/19 18:50, Daniel P. Berrangé wrote: > > On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: > >> This allows using "-cpu Haswell,+vmx", which we did not really want to > >> support in QEMU but was produced by Libvi

Re: [PATCH 2/6] block: truncate: Don't make backing file data visible

2019-11-20 Thread Vladimir Sementsov-Ogievskiy
20.11.2019 17:03, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > The old behaviour made a difference in 'block_res

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Daniel P . Berrangé
On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: > This allows using "-cpu Haswell,+vmx", which we did not really want to > support in QEMU but was produced by Libvirt when using the "host-model" > CPU model. Can you say what is currently broken ? If I launch my current QEMU (I have

Re: [PATCH] target/i386: add VMX features to named CPU models

2019-11-20 Thread Paolo Bonzini
On 20/11/19 18:50, Daniel P. Berrangé wrote: > On Wed, Nov 20, 2019 at 06:37:53PM +0100, Paolo Bonzini wrote: >> This allows using "-cpu Haswell,+vmx", which we did not really want to >> support in QEMU but was produced by Libvirt when using the "host-model" >> CPU model. > Can you say what is curr

Re: [PATCH for-5.0 v5 14/23] ppc/spapr: Implement the XiveFabric interface

2019-11-20 Thread Greg Kurz
On Fri, 15 Nov 2019 17:24:27 +0100 Cédric Le Goater wrote: > The CAM line matching sequence in the pseries machine does not change > much apart from the use of the new QOM interfaces. There is an extra > indirection because of the sPAPR IRQ backend of the machine. Only the > XIVE backend implemen

Re: [PATCH for 4.2?] tests/vm/centos: fix centos build target

2019-11-20 Thread Wainer dos Santos Moschetta
On 11/20/19 2:14 PM, Alex Bennée wrote: To be able to run the docker tests centos has here we have to install python3 as well as the basic tools. Signed-off-by: Alex Bennée --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wainer dos Santos Moschetta

Re: qcow2 preallocation and backing files

2019-11-20 Thread Vladimir Sementsov-Ogievskiy
20.11.2019 19:46, Kevin Wolf wrote: > Am 20.11.2019 um 16:58 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 20.11.2019 18:18, Alberto Garcia wrote: >>> On Wed 20 Nov 2019 01:27:53 PM CET, Vladimir Semeeausntsov-Ogievskiy wrote: >>> 3. Also, the latter way is inconsistent with discard. Discar

Re: [PATCH for-5.0 v5 13/23] ppc/pnv: Implement the XiveFabric interface

2019-11-20 Thread Greg Kurz
On Fri, 15 Nov 2019 17:24:26 +0100 Cédric Le Goater wrote: > The CAM line matching on the PowerNV machine now scans all chips of > the system and all CPUs of a chip to find a dispatched NVT in the > thread contexts. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > hw/ppc/p

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-20 Thread Thomas Huth
On 20/11/2019 18.09, Laurent Vivier wrote: > On ppc64, migration-test only works with kvm_hv, and we already > have a check to verify the module is loaded. > > kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists, > but on some systems (like build systems) /dev/kvm can be missing >

  1   2   3   4   >