[PATCH] riscv: virt: Allow PCI address 0

When testing e1000 with the virt machine, e1000's I/O space cannot be accessed. Debugging shows that the I/O BAR (BAR1) is correctly written with address 0 plus I/O enable bit, but QEMU's "info pci" shows that: Bus 0, device 1, function 0: Ethernet controller: PCI device 8086:100e ...

[Bug 1848556] Autopkgtest regression report (qemu/1:4.0+dfsg-0ubuntu9.2)

All autopkgtests for the newly accepted qemu (1:4.0+dfsg-0ubuntu9.2) for eoan have finished running. The following regressions have been reported in tests triggered by the package: ganeti/2.16.0-5ubuntu1 (ppc64el) Please visit the excuses page listed below and investigate the failures, proceed

Re: [QUESTION] Usage of '0b' as a prefix for numerical constants?

On 11/22/19 8:56 AM, Aleksandar Markovic wrote: Hello, all. I am currently reviewing some code, and I see it uses '0b' as a prefix of numerical constants, similar to these examples: switch (((inst >> 22) & 0b111000) | ((inst >> 12) & 0b000111)) { or ARRAY_FIELD_DP32(s->regs, CRB_INTF_

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

On Tue, Oct 29, 2019 at 10:25 PM Michael Rolnik wrote: > > From: Sarah Harris > > These were designed to facilitate testing but should provide enough function > to be useful in other contexts. > Only a subset of the functions of each peripheral is implemented, mainly due > to the lack of a stan

Re: [PATCH for-5.0 v5 18/23] ppc/xive: Move the TIMA operations to the controller model

On Fri, 15 Nov 2019 17:24:31 +0100 Cédric Le Goater wrote: > On the P9 Processor, the thread interrupt context registers of a CPU > can be accessed "directly" when by load/store from the CPU or > "indirectly" by the IC through an indirect TIMA page. This requires to > configure first the PC_TCTXT

[QUESTION] Usage of '0b' as a prefix for numerical constants?

Hello, all. I am currently reviewing some code, and I see it uses '0b' as a prefix of numerical constants, similar to these examples: switch (((inst >> 22) & 0b111000) | ((inst >> 12) & 0b000111)) { or ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID, RID, 0b); I remember a while ago, somethi

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

On Tue, Oct 29, 2019 at 10:25 PM Michael Rolnik wrote: > > From: Sarah Harris > > These were designed to facilitate testing but should provide enough function > to be useful in other contexts. > Only a subset of the functions of each peripheral is implemented, mainly due > to the lack of a stan

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

Kevin Wolf writes: > Am 22.11.2019 um 08:29 hat Markus Armbruster geschrieben: >> > At any rate, your counterpoint is taken - whatever we pick, we'll want >> > to make sure that introspection can expose semantics, and whether we >> > can make '*' redundant with some other form of longhand in the

Re: [PATCH 2/4] virtiofd: Create a notification queue

On Fri, Nov 22, 2019 at 10:19:03AM +, Stefan Hajnoczi wrote: > On Fri, Nov 15, 2019 at 03:55:41PM -0500, Vivek Goyal wrote: > > /* Callback from libvhost-user */ > > static void fv_set_features(VuDev *dev, uint64_t features) > > { > > +struct fv_VuDev *vud = container_of(dev, struct fv_V

Re: [PATCH v2 4/5] s390x: Move clear reset

On 22.11.19 15:00, Janosch Frank wrote: > Let's also move the clear reset function into the reset handler. > > Signed-off-by: Janosch Frank > --- > target/s390x/cpu-qom.h | 1 + > target/s390x/cpu.c | 50 -- > 2 files changed, 10 insertions(+), 41 del

Re: [PATCH] ipmi: add SET_SENSOR_READING command

On Mon, Nov 18, 2019 at 10:24:29AM +0100, Cédric Le Goater wrote: > SET_SENSOR_READING is a complex IPMI command (see IPMI spec 35.17) > which enables the host software to set the reading value and the event > status of sensors supporting it. > > Below is a proposal for all the operations (reading

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

On Wed 20 Nov 2019 07:44:57 PM CET, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > Consider the following scenario

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

On Fri, Nov 22, 2019 at 01:58:33PM +, Marc Zyngier wrote: > The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, > ISR_EL1 shows the pending status of the physical IRQ, FIQ, or > SError interrupts. > > Unfortunately, QEMU's implementation only considers the HCR_EL2 > bits, and ignore

Re: API definition for LUKS key management [V2]

Hi! This is the second version of the proposed QMP API for key management, after discussion with Keven and Max. Will this work? Adding Peter Krempa to CC, to hear his opinion from the libvirt side. Best regards, Maxim Levitsky diff --git a/qapi/block-core.json b/qapi/block-core.json

Re: [PATCH v2 3/5] s390x: Move initial reset

On 22.11.19 15:00, Janosch Frank wrote: > Let's move the intial reset into the reset handler and cleanup > afterwards. > > Signed-off-by: Janosch Frank > --- > target/s390x/cpu-qom.h | 2 +- > target/s390x/cpu.c | 44 +++--- > target/s390x/cpu.h | 2

Re: [PATCH] virtiofsd: fix libfuse information leaks

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > Some FUSE message replies contain padding fields that are not > initialized by libfuse. This is fine in traditional FUSE applications > because the kernel is trusted. virtiofsd does not trust the guest and > must not expose uninitialized memory. >

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

On Fri, 22 Nov 2019 at 13:59, Marc Zyngier wrote: > > The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, > ISR_EL1 shows the pending status of the physical IRQ, FIQ, or > SError interrupts. > > Unfortunately, QEMU's implementation only considers the HCR_EL2 > bits, and ignores the curr

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé wrote: > > Hi Aleksandar, > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > > Change the maintainership for R4000 systems to improve its quality. > > > > Acked-by: Aurelien Jarno > > Signed-off-by: Aleks

Re: [PATCH v2 2/5] s390x: Move reset normal to shared reset handler

On 22.11.19 14:59, Janosch Frank wrote: > Let's start moving the cpu reset functions into a single function with > a switch/case, so we can use fallthroughs and share more code between > resets. > > This patch introduces the reset function by renaming cpu_reset() and > cleaning up leftovers. > >

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

On Thu 21 Nov 2019 03:33:31 PM CET, Kevin Wolf wrote: > For commit it's an image corruptor. For resize, I'll admit that it's > just wrong behaviour that is probably harmless in most cases, but it's > still wrong behaviour. It would be a corruptor in the same way as > commit if it allowed resizing i

Re: [PATCH for-5.0 v5 19/23] ppc/xive: Remove the get_tctx() XiveRouter handler

On Fri, 15 Nov 2019 17:24:32 +0100 Cédric Le Goater wrote: > It is now unused. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/xive.h | 2 -- > hw/intc/pnv_xive.c| 13 - > hw/intc/spapr_xive.c | 8 > hw/intc/xive.c| 7 --

[PATCH v2 1/5] s390x: Don't do a normal reset on the initial cpu

The initiating cpu needs to be reset with an initial reset. While doing a normal reset followed by a initial reset is not wron per-se, the Ultravisor will only allow the correct reset to be performed. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 3

[PATCH v2 5/5] s390x: Beautify diag308 handling

Let's improve readability by: * Using constants for the subcodes * Moving parameter checking into a function * Removing subcode > 6 check as the default case catches that Signed-off-by: Janosch Frank Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand --- target

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

Juan Quintela writes: > Markus Armbruster wrote: >> From: Fangrui Song >> >> Clang does not like qmp_migrate_set_downtime()'s code to clamp double >> @value to 0..INT64_MAX: >> >> qemu/migration/migration.c:2038:24: error: implicit conversion from >> 'long' to 'double' changes value from 9

[PATCH v2 4/5] s390x: Move clear reset

Let's also move the clear reset function into the reset handler. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.h | 1 + target/s390x/cpu.c | 50 -- 2 files changed, 10 insertions(+), 41 deletions(-) diff --git a/target/s390x/cpu-qom.h b/targe

[PATCH v2 2/5] s390x: Move reset normal to shared reset handler

Let's start moving the cpu reset functions into a single function with a switch/case, so we can use fallthroughs and share more code between resets. This patch introduces the reset function by renaming cpu_reset() and cleaning up leftovers. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.

[PATCH v2 3/5] s390x: Move initial reset

Let's move the intial reset into the reset handler and cleanup afterwards. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.h | 2 +- target/s390x/cpu.c | 44 +++--- target/s390x/cpu.h | 2 +- target/s390x/sigp.c| 2 +- 4 files changed, 19

[PATCH v2 0/5] s390x: Reset cleanup

Adding comments and reordering code for better readability in the diag308 and machine reset functions. Janosch Frank (5): s390x: Don't do a normal reset on the initial cpu s390x: Move reset normal to shared reset handler s390x: Move initial reset s390x: Move clear reset s390x: Beautify d

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for R4000 systems to improve its quality. Acked-by: Aurelien Jarno Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, ISR_EL1 shows the pending status of the physical IRQ, FIQ, or SError interrupts. Unfortunately, QEMU's implementation only considers the HCR_EL2 bits, and ignores the current exception level. This means a hypervisor trying to look at i

Re: [PATCH v35 12/13] target/avr: Register AVR support with the rest of QEMU, the build system, and the WMAINTAINERS file

On 10/29/19 4:24 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- +++ b/qapi/machine.json @@ -21,11 +21,12 @@ #is true even for "qemu-system-x86_64". # # ppcemb: dropped in 3.1 +# avr: since 4.2 At this point, we've missed the cutoff for new features in 4.2, so this

Re: [PATCH for-5.0 v5 17/23] ppc/pnv: Clarify how the TIMA is accessed on a multichip system

On Fri, 15 Nov 2019 17:24:30 +0100 Cédric Le Goater wrote: > The TIMA region gives access to the thread interrupt context registers > of a CPU. It is mapped at the same address on all chips and can be > accessed by any CPU of the system. To identify the chip from which the > access is being done,

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

On 11/22/19 2:39 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:25 -0500 > Janosch Frank wrote: > >> When a guest has saved a ipib of type 5 and call diagnose308 with >> subcode 10, we have to setup the protected processing environment via >> Ultravisor calls. The calls are done by KVM and

Re: [PATCH 09/15] s390x: protvirt: SCLP interpretation

On 2019-11-21 15:24, Janosch Frank wrote: On 11/21/19 3:11 PM, Cornelia Huck wrote: On Wed, 20 Nov 2019 06:43:28 -0500 Janosch Frank wrote: SCLP for a protected guest is done over the SIDAD, so we need to use the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest memory when

RE: [PATCH v2 1/2] intel_iommu: split the resevred fields arrays into two ones

> -Original Message- > From: Peter Xu > Sent: Wednesday, November 20, 2019 12:06 AM > To: Zhang, Qi1 > Cc: qemu-devel@nongnu.org; ehabk...@redhat.com; m...@redhat.com; > pbonz...@redhat.com; Qi, Yadong ; r...@twiddle.net > Subject: Re: [PATCH v2 1/2] intel_iommu: split the resevred field

Re: [PATCH 1/4] virtiofsd: Release file locks using F_UNLCK

On Fri, Nov 22, 2019 at 10:07:13AM +, Stefan Hajnoczi wrote: > On Fri, Nov 15, 2019 at 03:55:40PM -0500, Vivek Goyal wrote: > > diff --git a/contrib/virtiofsd/passthrough_ll.c > > b/contrib/virtiofsd/passthrough_ll.c > > index bc214df0c7..028e7da273 100644 > > --- a/contrib/virtiofsd/passthrou

QEMU Licensing query

Hi All, QEMU is used in Android Emulator and is licensed under GPLv2 . For one of our customer support we may have to modify QEMU. I have below queries, - *Case 1: No modification in Q

Re: [PATCH-for-5.0] hw/display/sm501: Always map the UART0

On Fri, 22 Nov 2019 at 13:36, Philippe Mathieu-Daudé wrote: > > The SM501 is a Mobile Multimedia Companion Chip with 2 UARTs. > This model only implements the first UART. Being part of the > chipset, the UART block is always mapped in memory, regardless "regardless of whether we provide" > we pr

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

On Wed, 20 Nov 2019 06:43:25 -0500 Janosch Frank wrote: > When a guest has saved a ipib of type 5 and call diagnose308 with > subcode 10, we have to setup the protected processing environment via > Ultravisor calls. The calls are done by KVM and are exposed via an API. > > The following steps ar

[PATCH-for-5.0] hw/display/sm501: Always map the UART0

The SM501 is a Mobile Multimedia Companion Chip with 2 UARTs. This model only implements the first UART. Being part of the chipset, the UART block is always mapped in memory, regardless we provide a chardev backend. Since commit 12051d82f, qemu_chr_fe_init() accepts a NULL chardev. Let's remove th

Re: [PATCH 2/4] s390x: Cleanup cpu resets

On 11/22/19 11:35 AM, Philippe Mathieu-Daudé wrote: > Hi Janosh, > > On 11/22/19 8:52 AM, Janosch Frank wrote: >> Let's move the resets into one function and switch by type, so we can >> use fallthroughs for shared reset actions. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/cpu.c |

Re: [PATCH v1 3/3] tests/vm/ubuntu: update i386 image to 18.04

Philippe Mathieu-Daudé writes: > On 11/22/19 12:22 PM, Alex Bennée wrote: >> The current image is broken while running qtests but the bug go away >> when built with a newer Ubuntu i386 image. I was unable to replicate >> the crash on Debian Buster for i386 either so I'm concluding it is a >> di

Re: [PATCH] virtiofsd: fix libfuse information leaks

On 11/22/19 12:31 PM, Stefan Hajnoczi wrote: Some FUSE message replies contain padding fields that are not initialized by libfuse. This is fine in traditional FUSE applications because the kernel is trusted. virtiofsd does not trust the guest and must not expose uninitialized memory. Use C str

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

Thomas Huth writes: > Test 079 fails in the arm64, s390x and ppc64le LXD containers, which > apparently do not allow large files to be created. Test 079 tries to > create a 4G sparse file, so check first whether we can really create > such files before executing the test. > > Signed-off-by: Tho

Re: [PATCH 1/6] iotests: Skip test 060 if it is not possible to create large files

Thomas Huth writes: > Test 060 fails in the arm64, s390x and ppc64le LXD containers, which > apparently do not allow large files to be created. The repair process > in test 060 creates a file of 64 GiB, so test first whether such large > files are possible and skip the test if that's not the ca

Re: [PATCH v17 13/14] tests/numa: Add case for QMP build HMAT

On Fri, 22 Nov 2019 15:48:25 +0800 Tao Xu wrote: > Check configuring HMAT usecase > > Suggested-by: Igor Mammedov > Signed-off-by: Tao Xu Reviewed-by: Igor Mammedov > --- > > Chenges in v17: > - Add some fail test cases (Igor) > --- > tests/numa-test.c | 194 ++

Re: [PATCH 4/4] s390x: Beautify machine reset

On 22.11.19 08:52, Janosch Frank wrote: > * Add comments that tell you which diag308 subcode caused the reset > * Sort by diag308 reset subcode > > Signed-off-by: Janosch Frank > --- > hw/s390x/s390-virtio-ccw.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > >

Re: [PATCH v17 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

On Fri, 22 Nov 2019 01:17:12 -0800 (PST) no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191122074826.1373-1-tao3...@intel.com/ > do not ignore warnings "line over 80 characters", just fix them > > Hi, > > This series seems to have some coding style problems. See output b

Re: [PATCH v17 12/14] hmat acpi: Build Memory Side Cache Information Structure(s)

On Fri, 22 Nov 2019 15:48:24 +0800 Tao Xu wrote: > From: Liu Jingqi > > This structure describes memory side cache information for memory > proximity domains if the memory side cache is present and the > physical device forms the memory side cache. > The software could use this information to e

Re: [PATCH 4/4] s390x: Beautify machine reset

On 11/22/19 1:25 PM, David Hildenbrand wrote: > On 22.11.19 13:22, Janosch Frank wrote: >> On 11/22/19 1:10 PM, Cornelia Huck wrote: >>> On Fri, 22 Nov 2019 12:47:44 +0100 >>> David Hildenbrand wrote: >>> On 22.11.19 12:46, Janosch Frank wrote: > On 11/22/19 11:59 AM, David Hildenbrand wr

Re: [PATCH] Remove wrappers

On 11/22/19 1:23 PM, David Hildenbrand wrote: > On 22.11.19 13:20, Janosch Frank wrote: >> That's what it would look like. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/cpu-qom.h | 12 >> target/s390x/cpu.c | 28 +--- >> target/s390x/cpu.h

Re: [PATCH 4/4] s390x: Beautify machine reset

On 22.11.19 13:22, Janosch Frank wrote: On 11/22/19 1:10 PM, Cornelia Huck wrote: On Fri, 22 Nov 2019 12:47:44 +0100 David Hildenbrand wrote: On 22.11.19 12:46, Janosch Frank wrote: On 11/22/19 11:59 AM, David Hildenbrand wrote: On 22.11.19 08:52, Janosch Frank wrote: * Add comments that t

Re: [PATCH] Remove wrappers

On 22.11.19 13:20, Janosch Frank wrote: That's what it would look like. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.h | 12 target/s390x/cpu.c | 28 +--- target/s390x/cpu.h | 8 +--- target/s390x/sigp.c| 4 ++-- 4 files chan

Re: [PATCH 4/4] s390x: Beautify machine reset

On 11/22/19 1:10 PM, Cornelia Huck wrote: > On Fri, 22 Nov 2019 12:47:44 +0100 > David Hildenbrand wrote: > >> On 22.11.19 12:46, Janosch Frank wrote: >>> On 11/22/19 11:59 AM, David Hildenbrand wrote: On 22.11.19 08:52, Janosch Frank wrote: > * Add comments that tell you which diag3

Re: [PATCH v17 09/14] numa: Extend CLI to provide memory side cache information

On Fri, 22 Nov 2019 15:48:21 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-cache option to provide Memory Side Cache Information. > These memory attributes help to build Memory Side Cache Information > Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). > > Reviewed-b

[PATCH] Remove wrappers

That's what it would look like. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.h | 12 target/s390x/cpu.c | 28 +--- target/s390x/cpu.h | 8 +--- target/s390x/sigp.c| 4 ++-- 4 files changed, 20 insertions(+), 32 deletions(-) diff --

Re: [PATCH 4/4] s390x: Beautify machine reset

On Fri, 22 Nov 2019 12:47:44 +0100 David Hildenbrand wrote: > On 22.11.19 12:46, Janosch Frank wrote: > > On 11/22/19 11:59 AM, David Hildenbrand wrote: > >> On 22.11.19 08:52, Janosch Frank wrote: > >>> * Add comments that tell you which diag308 subcode caused the reset > >>> * Sort by diag3

Re: [PATCH v35 12/13] target/avr: Register AVR support with the rest of QEMU, the build system, and the WMAINTAINERS file

On 10/29/19 10:24 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- MAINTAINERS | 9 + arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h |

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

Hi Michael, On 10/29/19 10:24 PM, Michael Rolnik wrote: From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way t

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

On Fri, Nov 22, 2019 at 2:11 PM Peter Maydell wrote: > > On Thu, 21 Nov 2019 at 18:51, Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, Nov 21, 2019 at 10:24 PM Peter Maydell > > wrote: > > > > > > On Thu, 21 Nov 2019 at 18:15, Marc-André Lureau > > > wrote: > > > > > > > > On Thu, Nov 21

Re: [PATCH 4/4] s390x: Beautify machine reset

On 22.11.19 12:46, Janosch Frank wrote: On 11/22/19 11:59 AM, David Hildenbrand wrote: On 22.11.19 08:52, Janosch Frank wrote: * Add comments that tell you which diag308 subcode caused the reset * Sort by diag308 reset subcode Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 2

Re: [PATCH 4/4] s390x: Beautify machine reset

On 11/22/19 11:59 AM, David Hildenbrand wrote: > On 22.11.19 08:52, Janosch Frank wrote: >> * Add comments that tell you which diag308 subcode caused the reset >> * Sort by diag308 reset subcode >> >> Signed-off-by: Janosch Frank >> --- >> hw/s390x/s390-virtio-ccw.c | 20 ++-- >>

Re: [PATCH v35 09/13] target/avr: Add instruction translation - CPU main translation function

On 10/29/19 10:24 PM, Michael Rolnik wrote: Co-developed-by: Richard Henderson This misses a: "Signed-off-by: Richard Henderson " Co-developed-by: Michael Rolnik Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé --- target/avr/translate.c | 234 +++

Re: [PATCH v35 03/13] target/avr: Add instruction decoding

On 10/29/19 10:24 PM, Michael Rolnik wrote: This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé --- target/avr/insn.decode | 175 + 1 file chang

Re: [PATCH v35 02/13] target/avr: Add instruction helpers

On 10/29/19 10:24 PM, Michael Rolnik wrote: Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peri

Re: [PATCH v1 2/3] tests/vm/ubuntu: include language pack to silence locale warnings

On 11/22/19 12:22 PM, Alex Bennée wrote: The iotests in particular don't like the output being spammed with warnings about locales. Signed-off-by: Alex Bennée --- tests/vm/ubuntu.i386 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i

Re: [PATCH v1 3/3] tests/vm/ubuntu: update i386 image to 18.04

On 11/22/19 12:22 PM, Alex Bennée wrote: The current image is broken while running qtests but the bug go away when built with a newer Ubuntu i386 image. I was unable to replicate the crash on Debian Buster for i386 either so I'm concluding it is a distro problem. Let's paper over that crack by up

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

On 18.11.2019 21:54, Eduardo Habkost wrote: > On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: >> Some device's property can be changed if the device has been already >> realized. For example, it could be "drive" property of a scsi disk device. >> >> So far, set_pointer could ope

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

> On 22 Nov 2019, at 09:41, Markus Armbruster wrote: > > Reviving this old thread, because I'd like to connect it to more recent > discussions. > > Christophe de Dinechin mailto:dinec...@redhat.com>> > writes: > >> Markus Armbruster writes: >> >>> Peter Krempa writes: >>> >> [...] Fr

[PATCH] virtiofsd: fix libfuse information leaks

Some FUSE message replies contain padding fields that are not initialized by libfuse. This is fine in traditional FUSE applications because the kernel is trusted. virtiofsd does not trust the guest and must not expose uninitialized memory. Use C struct initializers to automatically zero out memo

[PATCH v1 1/3] tests/vm/centos: fix centos build target

To be able to run the docker tests centos has here we have to install python3 as well as the basic tools. Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé --- tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v1 3/3] tests/vm/ubuntu: update i386 image to 18.04

The current image is broken while running qtests but the bug go away when built with a newer Ubuntu i386 image. I was unable to replicate the crash on Debian Buster for i386 either so I'm concluding it is a distro problem. Let's paper over that crack by updating our 32 bir test image. Signed-off-b

[PATCH for 4.2 v1 0/3] some tests/vm fixes

Hi, These fixes are aimed at improving the "vm-build-all" make target. The first two are fairly non contriversal tweaks to the base configuration. The final one just elides over the fact that the tests are broken on 32bit 16.04 - but I think it may be a distro problem as I've failed to replicate o

[PATCH v1 2/3] tests/vm/ubuntu: include language pack to silence locale warnings

The iotests in particular don't like the output being spammed with warnings about locales. Signed-off-by: Alex Bennée --- tests/vm/ubuntu.i386 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 index 38f740eabf7..18b1ea2b72c 100755 ---

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

On 11/22/19 12:12 PM, Marc-André Lureau wrote: On Fri, Nov 22, 2019 at 3:07 PM Philippe Mathieu-Daudé wrote: On 11/20/19 4:24 PM, Marc-André Lureau wrote: Instead, set the initial data field directly. (the initial data is an array of 256 bytes. As I don't know if it may change over time, I k

Re: [PATCH 2/4] s390x: Cleanup cpu resets

[...] #if !defined(CONFIG_USER_ONLY) @@ -473,9 +459,9 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data) #if !defined(CONFIG_USER_ONLY) scc->load_normal = s390_cpu_load_normal; #endif -scc->cpu_reset = s390_cpu_reset; -scc->initial_cpu_reset = s390_cpu_initial

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

On 11/22/19 11:54 AM, Michael Rolnik wrote: Hi all. Once implemented, how to invoke this function? I'm testing your series with: qemu-system-avr -kernel ~/Downloads/ATmegaBOOT.elf -d in_asm,unimp The '-d in_asm' enable dumping the assembler instructions translated. Sent from my cell phone,

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

On Fri, Nov 22, 2019 at 3:07 PM Philippe Mathieu-Daudé wrote: > > On 11/20/19 4:24 PM, Marc-André Lureau wrote: > > Instead, set the initial data field directly. > > > > (the initial data is an array of 256 bytes. As I don't know if it may > > change over time, I keep the pointer to original buffe

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

On 11/20/19 4:24 PM, Marc-André Lureau wrote: Instead, set the initial data field directly. (the initial data is an array of 256 bytes. As I don't know if it may change over time, I keep the pointer to original buffer as is, but it might be worth to consider to copy it instead) Signed-off-by: M

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

On Friday, November 22, 2019, Philippe Mathieu-Daudé wrote: > On 11/21/19 9:55 PM, Aleksandar Markovic wrote: > >> Why not implement the dump_ASM code? This is very useful... >>> >>> >> ... and time-consuming to implement, unless Michael have some >> ready off-shelf code. >> >> It is great that y

Re: [PATCH 4/4] s390x: Beautify machine reset

On 22.11.19 08:52, Janosch Frank wrote: * Add comments that tell you which diag308 subcode caused the reset * Sort by diag308 reset subcode Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/h

Re: [PATCH 3/4] s390x: Beautify diag308 handling

On 22.11.19 08:52, Janosch Frank wrote: Let's improve readability by: * Using constants for the subcodes * Moving parameter checking into a function * Removing subcode > 6 check as the default case catches that Signed-off-by: Janosch Frank Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth -

Re: [PATCH 1/4] s390x: Don't do a normal reset on the initial cpu

On 22.11.19 08:52, Janosch Frank wrote: The initiating cpu needs to be reset with an initial reset. While doing a normal reset followed by a initial reset is not wron per-se, the Ultravisor will only allow the correct reset to be performed. Signed-off-by: Janosch Frank --- hw/s390x/s390-virti

Re: [PATCH v3] linux-user/strace: Improve output of various syscalls

On 11/21/19 8:33 PM, Helge Deller wrote: Improve strace output of various syscalls which either have none or only int-type parameters. Signed-off-by: Helge Deller --- Changes in v3: fixed alarm() added epoll_create(), epoll_create1(), eventfd(), eventfd2() Changes in v2: fixed

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

Hi all. Once implemented, how to invoke this function? Sent from my cell phone, please ignore typos On Fri, Nov 22, 2019, 12:46 PM Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 11/22/19 9:43 AM, Aleksandar Markovic wrote: > > On Friday, November 22, 2019, Richard Henderson > > mailto:rich

Re: [PATCH 4/4] virtiofsd: Implement blocking posix locks

On Fri, Nov 15, 2019 at 03:55:43PM -0500, Vivek Goyal wrote: > diff --git a/contrib/virtiofsd/fuse_lowlevel.c > b/contrib/virtiofsd/fuse_lowlevel.c > index d4a42d9804..f706e440bf 100644 > --- a/contrib/virtiofsd/fuse_lowlevel.c > +++ b/contrib/virtiofsd/fuse_lowlevel.c > @@ -183,7 +183,8 @@ int fu

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

Hi Michael, On 11/22/19 9:43 AM, Aleksandar Markovic wrote: On Friday, November 22, 2019, Richard Henderson mailto:richard.hender...@linaro.org>> wrote: On 11/21/19 8:53 PM, Michael Rolnik wrote: > It seems to be a huge investment. this function should parse the > binary data as

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

On 11/21/19 9:55 PM, Aleksandar Markovic wrote: Why not implement the dump_ASM code? This is very useful... ... and time-consuming to implement, unless Michael have some ready off-shelf code. It is great that you have lots of ideas, Philippe, however I think that it is counterproductive to su

Re: [PATCH 2/4] s390x: Cleanup cpu resets

Hi Janosh, On 11/22/19 8:52 AM, Janosch Frank wrote: Let's move the resets into one function and switch by type, so we can use fallthroughs for shared reset actions. Signed-off-by: Janosch Frank --- target/s390x/cpu.c | 110 - 1 file changed, 48 i

Re: [RFC v4 PATCH 41/49] multi-process/mig: Enable VMSD save in the Proxy object

* Jag Raman (jag.ra...@oracle.com) wrote: > > > On 11/13/2019 12:11 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 13, 2019 at 11:32:09AM -0500, Jag Raman wrote: > > > > > > > > > On 11/13/2019 10:50 AM, Daniel P. Berrangé wrote: > > > > On Thu, Oct 24, 2019 at 05:09:22AM -0400, Jagannathan Rama

Re: [PATCH 3/4] virtiofsd: Specify size of notification buffer using config space

On Fri, Nov 15, 2019 at 03:55:42PM -0500, Vivek Goyal wrote: > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c > index 44c9b3..982b6ad0bd 100644 > --- a/contrib/virtiofsd/fuse_virtio.c > +++ b/contrib/virtiofsd/fuse_virtio.c > @@ -109,7 +109,8 @@ static uint64_t f

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

On 11/22/19 9:00 AM, Markus Armbruster wrote: From: Fangrui Song Clang does not like qmp_migrate_set_downtime()'s code to clamp double @value to 0..INT64_MAX: qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to

Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

Am 22.11.2019 um 11:15 hat Dr. David Alan Gilbert geschrieben: > * Maxim Levitsky (mlevi...@redhat.com) wrote: > > This patch series is bunch of cleanups > > to the hmp monitor code. > > > > This series only touched blockdev related hmp handlers. > > Hi Maxim, > This looks mostly OK to me from

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

Am 22.11.2019 um 08:29 hat Markus Armbruster geschrieben: > > At any rate, your counterpoint is taken - whatever we pick, we'll want > > to make sure that introspection can expose semantics, and whether we > > can make '*' redundant with some other form of longhand in the qapi > > language is in pa

Re: [PATCH] monitor: Fix slow reading

Cc'ing the chardev maintainers. On 11/22/19 10:23 AM, Yury Kotov wrote: The monitor_can_read (as a callback of qemu_chr_fe_set_handlers) should return size of buffer which monitor_qmp_read or monitor_read can process. Currently, monitor_can_read returns 1 as a result of logical not. Thus, for ea

Re: [PATCH 2/4] virtiofd: Create a notification queue

On Fri, Nov 15, 2019 at 03:55:41PM -0500, Vivek Goyal wrote: > /* Callback from libvhost-user */ > static void fv_set_features(VuDev *dev, uint64_t features) > { > +struct fv_VuDev *vud = container_of(dev, struct fv_VuDev, dev); > +struct fuse_session *se = vud->se; > + > +if ((1 <<

Re: [PATCH for-5.0 v5 16/23] ppc/xive: Extend the TIMA operation with a XivePresenter parameter

On Fri, 15 Nov 2019 17:24:29 +0100 Cédric Le Goater wrote: > The TIMA operations are performed on behalf of the XIVE IVPE sub-engine > (Presenter) on the thread interrupt context registers. The current > operations supported by the model are simple and do not require access > to the controller bu

Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

* Maxim Levitsky (mlevi...@redhat.com) wrote: > This patch series is bunch of cleanups > to the hmp monitor code. > > This series only touched blockdev related hmp handlers. Hi Maxim, This looks mostly OK to me from the HMP side - with one change; can you please move the blockdev-hmp-cmds.c int

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

On Thu, 21 Nov 2019 at 18:51, Marc-André Lureau wrote: > > Hi > > On Thu, Nov 21, 2019 at 10:24 PM Peter Maydell > wrote: > > > > On Thu, 21 Nov 2019 at 18:15, Marc-André Lureau > > wrote: > > > > > > On Thu, Nov 21, 2019 at 5:47 PM Peter Maydell > > > wrote: > > > > > > > > On Wed, 20 Nov 20

Re: [PATCH 0/4] s390x: Reset cleanup

Patchew URL: https://patchew.org/QEMU/20191122075218.23935-1-fran...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/4] s390x: Reset cleanup Type: series Message-id: 20191122075218.23935-1-fran...@linux.ibm.com

<    1   2   3   >