Re: [PATCH v2 3/5] semihosting: add qemu_semihosting_console_inc for SYS_READC

2019-12-28 Thread Richard Henderson
On 12/21/19 12:22 AM, Alex Bennée wrote: > From: Keith Packard > > Provides a blocking call to read a character from the console using > semihosting.chardev, if specified. This takes some careful command > line options to use stdio successfully as the serial ports, monitor > and semihost all

Re: [PATCH v2 4/5] tests/tcg: add a dumb-as-bricks semihosting console test

2019-12-28 Thread Richard Henderson
On 12/21/19 12:22 AM, Alex Bennée wrote: > We don't run this during check-tcg as we would need to check stuff is > echoed back. However we can still build the binary so people can test > it manually. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > > --- > v8 > - actually

Re: [PATCH v2 5/5] tests/tcg: add user version of dumb-as-bricks semiconsole test

2019-12-28 Thread Richard Henderson
On 12/21/19 12:22 AM, Alex Bennée wrote: > +#if defined(__arm__) > +register uintptr_t t asm("r0") = type; > +register uintptr_t a0 asm("r1") = arg0; > +asm("svc 0xab" > +: "=r" (t) > +: "r" (t), "r" (a0)); This is the #ifdef __thumb__ svc code. Are you enforcing that

[PATCH v4] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

2019-12-28 Thread Marek Dolata - mkdol...@us.ibm.com
Fixes: corrects clobbering of registers appearing after k_gs_base Buglink: https://bugs.launchpad.net/qemu/+bug/1857640 Signed-off-by: Marek Dolata --- target/i386/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index

[PATCH v2] Implement the Screamer sound chip for the mac99 machine type

2019-12-28 Thread John Arbuckle
This patch enables the playback of audio on a Mac OS 9 or Mac OS X guest. Signed-off-by: John Arbuckle --- v2 changes: - Fixed a bug that prevented the sampling rate from being changed. hw/audio/Kconfig | 3 + hw/audio/Makefile.objs| 2 + hw/audio/screamer.c

Re: [PATCH 2/2] hppa: Switch to tulip NIC by default

2019-12-28 Thread Richard Henderson
On 12/22/19 9:25 AM, Helge Deller wrote: > Most HP PA-RISC machines have a Digital DS21142/43 Tulip network card, > only some very latest generation machines have an e1000 NIC. > Since qemu now provides an emulated tulip card, use that one instead. > > Signed-off-by: Helge Deller Queued,

Re: [PATCH 1/2] hppa: Do not enable artist graphics with -nographic option

2019-12-28 Thread Richard Henderson
On 12/22/19 9:24 AM, Helge Deller wrote: > When qemu was started with the -nographic option, do not enable the > artist graphic card emulation. > > Signed-off-by: Helge Deller Squashed into Sven's patch. r~

Re: [PATCH v5 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-12-28 Thread Richard Henderson
On 12/21/19 8:15 AM, Sven Schnelle wrote: > these series adds quite a lot to the HPPA emulation in QEMU: > i82596 emulation from Helge, PS/2 and Artist graphics emulation. > > See https://parisc.wiki.kernel.org/index.php/Qemu for a few screenshots > of QEMU running a X11/CDE session in HP-UX. >

Re: [PATCH v6 11/11] hw/s390x/ipl: replace deprecated qdev_reset_all registration

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > Replace deprecated qdev_reset_all by resettable_cold_reset_fn for > the ipl registration in the main reset handlers. > > This does not impact the behavior for the following reasons: > + at this point resettable just call the old reset methods of devices

Re: [PATCH v6 10/11] vl: replace deprecated qbus_reset_all registration

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > Replace deprecated qbus_reset_all by resettable_cold_reset_fn for > the sysbus reset registration. > > Apart for the raspi machines, this does not impact the behavior > because: > + at this point resettable just calls the old reset methods of devices >

Re: [PATCH v6 09/11] docs/devel/reset.rst: add doc about Resettable interface

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > Signed-off-by: Damien Hedde > Reviewed-by: Peter Maydell > --- > docs/devel/index.rst | 1 + > docs/devel/reset.rst | 289 +++ > 2 files changed, 290 insertions(+) > create mode 100644 docs/devel/reset.rst

Re: [PATCH v6 08/11] hw/core: deprecate old reset functions and introduce new ones

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > Deprecate device_legacy_reset(), qdev_reset_all() and > qbus_reset_all() to be replaced by new functions > device_cold_reset() and bus_cold_reset() which uses resettable API. > > Also introduce resettable_cold_reset_fn() which may be used as a >

Re: [PATCH v6 07/11] hw/core/qdev: update hotplug reset regarding resettable

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > +void resettable_state_clear(ResettableState *state) > +{ > +memset(state, 0, sizeof(ResettableState)); > +} Worth moving this into the header as inline? Anyway, Reviewed-by: Richard Henderson r~

Re: [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding resettable

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > In qdev_set_parent_bus(), when changing the parent bus of a > realized device, if the source and destination buses are not in the > same reset state, some adaptations are required. This patch adds > needed call to resettable_change_parent() to make sure

Re: [PATCH v6 05/11] hw/core/resettable: add support for changing parent

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > Add a function resettable_change_parent() to do the required > plumbing when changing the parent a of Resettable object. > > We need to make sure that the reset state of the object remains > coherent with the reset state of the new parent. > > We make

Re: [PATCH v6 03/11] hw/core: create Resettable QOM interface

2019-12-28 Thread Richard Henderson
On 12/20/19 10:50 PM, Damien Hedde wrote: > +typedef void (*ResettableEnterPhase)(Object *obj, ResetType type); > +typedef void (*ResettableHoldPhase)(Object *obj); > +typedef void (*ResettableExitPhase)(Object *obj); > +typedef ResettableState * (*ResettableGetState)(Object *obj); > +typedef void

[PATCH v3 28/29] cputlb: Remove support for MMU_MODE*_SUFFIX

2019-12-28 Thread Richard Henderson
All users have now been converted to cpu_*_mmuidx_ra. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 230 1 file changed, 230 deletions(-) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index

[PATCH v3 27/29] target/ppc: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-28 Thread Richard Henderson
There are only two uses. Within dcbz_common, the local variable mmu_idx already contains the epid computation, and we can avoid repeating it for the store. Within helper_icbiep, the usage is trivially expanded using PPC_TLB_EPID_LOAD. Acked-by: David Gibson Reviewed-by: Alex Bennée

[PATCH v3 20/29] target/microblaze: Remove MMU_MODE{0,1,2}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Cc: Edgar E. Iglesias Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/microblaze/cpu.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 95773089aa..32522f606b

[PATCH v3 19/29] target/i386: Remove MMU_MODE{0,1,2}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Cc: Eduardo Habkost Acked-by: Paolo Bonzini Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/i386/cpu.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index

[PATCH v3 23/29] target/xtensa: Remove MMU_MODE{0,1,2,3}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Acked-by: Max Filippov Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/xtensa/cpu.h | 4 1 file changed, 4 deletions(-) diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu.h index b363ffcf10..f5a7ea48bb 100644 ---

[PATCH v3 29/29] cputlb: Expand cpu_ldst_template.h in cputlb.c

2019-12-28 Thread Richard Henderson
Reduce the amount of preprocessor obfuscation by expanding the text of each of the functions generated. The result is only slightly smaller than the original. Reviewed-by: Alex Bennée Reviewed-by: Aleksandar Markovic Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 67

[PATCH v3 21/29] target/sh4: Remove MMU_MODE{0,1}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Cc: Aurelien Jarno Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index ecaa7a18a9..452a596e67 100644 ---

[PATCH v3 17/29] target/alpha: Remove MMU_MODE{0,1}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/alpha/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/alpha/cpu.h b/target/alpha/cpu.h index a530249a5b..3f782c0efe 100644 --- a/target/alpha/cpu.h +++

[PATCH v3 25/29] target/mips: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-28 Thread Richard Henderson
The separate suffixed functions were used to construct some do_##insn function switched on mmu_idx. The interface is exactly identical to the *_mmuidx_ra functions. Replace them directly and remove the constructions. Cc: Aurelien Jarno Cc: Aleksandar Rikalo Reviewed-by: Aleksandar Markovic

[PATCH v3 14/29] target/i386: Use cpu_*_mmuidx_ra instead of templates

2019-12-28 Thread Richard Henderson
Do not use exec/cpu_ldst_{,useronly_}template.h directly, but instead use the functional interface. Cc: Eduardo Habkost Acked-by: Paolo Bonzini Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/i386/seg_helper.c | 56 1 file

[PATCH v3 26/29] target/s390x: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-28 Thread Richard Henderson
The generated functions aside from *_real are unused. The *_real functions have a couple of users in mem_helper.c; use *_mmuidx_ra instead, with MMU_REAL_IDX. Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Use *_mmuidx_ra directly, without

[PATCH v3 24/29] target/m68k: Use cpu_*_mmuidx_ra instead of MMU_MODE{0, 1}_SUFFIX

2019-12-28 Thread Richard Henderson
The generated *_user functions are unused. The *_kernel functions have a couple of users in op_helper.c; use *_mmuidx_ra instead, with MMU_KERNEL_IDX. Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Use *_mmuidx_ra directly, without intermediate

[PATCH v3 12/29] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code

2019-12-28 Thread Richard Henderson
There are no uses of the *_cmmu names other than the bare wrapping within the *_code inlines. Therefore rename the functions so we can drop the inlines. Use abi_ptr instead of target_ulong in preparation for user-only; the two types are identical for softmmu. Reviewed-by: Aleksandar Markovic

[PATCH v3 13/29] cputlb: Provide cpu_(ld, st}*_mmuidx_ra for user-only

2019-12-28 Thread Richard Henderson
This finishes the new interface began with the previous patch. Document the interface and deprecate MMU_MODE_SUFFIX. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 80 +- docs/devel/loads-stores.rst | 211

[PATCH v3 22/29] target/unicore32: Remove MMU_MODE{0,1}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Cc: Guan Xuetao Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/unicore32/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/unicore32/cpu.h b/target/unicore32/cpu.h index 50ed9dd99c..7a32e086ed 100644 ---

[PATCH v3 10/29] cputlb: Move body of cpu_ldst_template.h out of line

2019-12-28 Thread Richard Henderson
With the tracing hooks, the inline functions are no longer so simple. Once out-of-line, the current tlb_entry lookup is redundant with the one in the main load/store_helper. This also begins the introduction of a new target facing interface, with suffix *_mmuidx_ra. This is not yet official

[PATCH v3 11/29] translator: Use cpu_ld*_code instead of open-coding

2019-12-28 Thread Richard Henderson
The DO_LOAD macros replicate the distinction already performed by the cpu_ldst.h functions. Use them. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 11 - include/exec/translator.h | 48 +++ 2 files

[PATCH v3 15/29] cputlb: Expand cpu_ldst_useronly_template.h in user-exec.c

2019-12-28 Thread Richard Henderson
With the tracing hooks, the inline functions are no longer so simple. Reduce the amount of preprocessor obfuscation by expanding the text of each of the functions generated. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 54 +++--

[PATCH v3 18/29] target/cris: Remove MMU_MODE{0,1}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Cc: Edgar E. Iglesias Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/cris/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/cris/cpu.h b/target/cris/cpu.h index aba0a66474..bc43bc23a1 100644 ---

[PATCH v3 09/29] plugins: Include trace/mem.h in api.c

2019-12-28 Thread Richard Henderson
Code movement in an upcoming patch will show that this file was implicitly depending on trace/mem.h being included beforehand. Reported-by: Alex Bennée Signed-off-by: Richard Henderson --- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/api.c b/plugins/api.c index

[PATCH v3 03/29] trace: Remove trace_mem_build_info_no_se_[bl]e

2019-12-28 Thread Richard Henderson
It is easy for the atomic helpers to use trace_mem_build_info directly, without resorting to symbol pasting. For this usage, we cannot use trace_mem_get_info, because the MemOp does not support 16-byte accesses. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson ---

[PATCH v3 16/29] target/nios2: Remove MMU_MODE{0,1}_SUFFIX

2019-12-28 Thread Richard Henderson
The functions generated by these macros are unused. Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/nios2/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 361b06ffeb..78f633f970

[PATCH v3 08/29] linux-user: Include trace-root.h in syscall-trace.h

2019-12-28 Thread Richard Henderson
Code movement in an upcoming patch will show that this file was implicitly depending on trace-root.h being included beforehand. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/user/syscall-trace.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 06/29] accel/tcg: Include tcg.h in tcg-runtime.c

2019-12-28 Thread Richard Henderson
Code movement in an upcoming patch will show that this file was implicitly depending on tcg.h being included indirectly. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/tcg/tcg-runtime.c

[PATCH v3 01/29] target/xtensa: Use probe_access for itlb_hit_test

2019-12-28 Thread Richard Henderson
We don't actually need the result of the read, only to probe that the memory mapping exists. This is exactly what probe_access does. This is also the only user of any cpu_ld*_code_ra function. Removing this allows the interface to be removed shortly. Acked-by: Max Filippov Reviewed-by: Alex

[PATCH v3 04/29] target/s390x: Include tcg.h in mem_helper.c

2019-12-28 Thread Richard Henderson
Code movement in an upcoming patch will show that this file was implicitly depending on tcg.h being included indirectly. Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 05/29] target/arm: Include tcg.h in sve_helper.c

2019-12-28 Thread Richard Henderson
Code movement in an upcoming patch will show that this file was implicitly depending on tcg.h being included indirectly. Cc: Peter Maydell Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/sve_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 07/29] linux-user: Include tcg.h in syscall.c

2019-12-28 Thread Richard Henderson
Code movement in an upcoming patch will show that this file was implicitly depending on tcg.h being included indirectly. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c

[PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX

2019-12-28 Thread Richard Henderson
This is part of a project to raise the limit on NB_MMU_MODES. One of those is in cpu_ldst.h, in support of MMU_MODE*_SUFFIX. While this could be extended, it's not the best interface for such things. Better is a single interface that allows a variable mmu_idx. The best exemplars of that is the

[PATCH v3 02/29] cputlb: Use trace_mem_get_info instead of trace_mem_build_info

2019-12-28 Thread Richard Henderson
In the cpu_ldst templates, we already require a MemOp, and it is cleaner and clearer to pass that instead of 3 separate arguments describing the memory operation. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/exec/cpu_ldst_template.h

Re: [PATCH v2 26/28] target/ppc: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-28 Thread Richard Henderson
On 12/21/19 6:51 AM, Alex Bennée wrote: >> --- a/target/ppc/mem_helper.c >> +++ b/target/ppc/mem_helper.c >> @@ -177,14 +177,7 @@ static void dcbz_common(CPUPPCState *env, target_ulong >> addr, >> } else { >> /* Slow path */ >> for (i = 0; i < dcbz_size; i += 8) { >> -

Re: [PATCH v2 08/28] target/i386: Use cpu_*_mmuidx_ra instead of templates

2019-12-28 Thread Richard Henderson
On 12/21/19 4:42 AM, Alex Bennée wrote: >> +/* >> + * TODO: Convert callers to compute cpu_mmu_index_kernel once >> + * and use *_mmuidx_ra directly. >> + */ > > I guess this would only be if it was a significant performance impact? > They seem to be mainly called for (I assume) infrequently

Re: [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code

2019-12-28 Thread Richard Henderson
On 12/21/19 4:25 AM, Alex Bennée wrote: >> -#define CPU_MMU_INDEX (cpu_mmu_index(env, true)) >> -#define MEMSUFFIX _code >> -#define SOFTMMU_CODE_ACCESS >> +uint32_t cpu_ldub_code(CPUArchState *env, abi_ptr addr); >> +uint32_t cpu_lduw_code(CPUArchState *env, abi_ptr addr); >> +uint32_t

Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line

2019-12-28 Thread Richard Henderson
On 12/21/19 5:36 AM, Alex Bennée wrote: >> -#if !defined(SOFTMMU_CODE_ACCESS) >> -#include "trace-root.h" >> -#endif >> - >> -#include "qemu/plugin.h" >> -#include "trace/mem.h" > > I think api.c needs to include trace/mem.h Yep, thanks. I'll enable travis for my local branches for next time,

Re: [PATCH v2 03/28] trace: Remove trace_mem_build_info_no_se_[bl]e

2019-12-28 Thread Richard Henderson
On 12/21/19 3:38 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> It is easy for the atomic helpers to use trace_mem_build_info >> directly, without resorting to symbol pasting. For this usage, >> we cannot use trace_mem_get_info, because the MemOp does not >> support 16-byte

Re: [PATCH v39 00/22] QEMU AVR 8 bit cores

2019-12-28 Thread Michael Rolnik
but this is a sample board that has some ATmega2560 devices and its avr6 core On Sat, Dec 28, 2019 at 9:38 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Saturday, December 28, 2019, Michael Rolnik wrote: > >> Hi Aleksandar. >> >> FreeRTOS demo we use uses avr6, that's

Re: [PATCH v39 00/22] QEMU AVR 8 bit cores

2019-12-28 Thread Aleksandar Markovic
On Saturday, December 28, 2019, Michael Rolnik wrote: > Hi Aleksandar. > > FreeRTOS demo we use uses avr6, that's why we use avr6. > > Yes, I figured that out, but I think you provide support for ovrerall AVR target, not only for RTOS demo, right? That's why I think the choice of default core

Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-28 Thread Michael Rolnik
Hi Aleksandar. This seems less logical to me. Then next thing will be to partition disassember part right? On Sat, Dec 21, 2019 at 7:15 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Saturday, December 21, 2019, Aleksandar Markovic < > aleksandar.m.m...@gmail.com>

Re: [PATCH v39 14/22] target/avr: Add dummy mask device

2019-12-28 Thread Michael Rolnik
This device is not "Power Reduction" but power reduction registers can be implemented with it. All it does, whenever a bit is written the device raises an interrupt / IRQ. If you have a better name please advise. On Mon, Dec 23, 2019 at 10:46 AM Aleksandar Markovic < aleksandar.m.m...@gmail.com>

Re: [PATCH v39 00/22] QEMU AVR 8 bit cores

2019-12-28 Thread Michael Rolnik
Hi Aleksandar. FreeRTOS demo we use uses avr6, that's why we use avr6. Regards. Michael Rolnik On Mon, Dec 23, 2019 at 11:13 AM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Wednesday, December 18, 2019, Michael Rolnik wrote: > >> This series of patches adds 8bit AVR

Re: [PATCH V3] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

2019-12-28 Thread Philippe Mathieu-Daudé
On 12/28/19 12:37 AM, Marek Dolata - mkdol...@us.ibm.com wrote: Fixes: corrects clobbering of registers appearing after k_gs_base Buglink: https://bugs.launchpad.net/qemu/+bug/1857640 Signed-off-by: Marek Dolata > --- target/i386/gdbstub.c | 4 ++-- 1 file

Re: [PATCH v3 0/2] ide: Fix incorrect handling of some PRDTs and add the corresponding unit-test

2019-12-28 Thread Alexander Popov
On 23.12.2019 20:51, Alexander Popov wrote: > Fuzzing the Linux kernel with syzkaller allowed to find how to crash qemu > using a special SCSI_IOCTL_SEND_COMMAND. It hits the assertion in > ide_dma_cb() introduced in the commit a718978ed58a in July 2015. > > This patch series fixes incorrect

Re: [PATCH] accel/kvm: Make "kernel_irqchip" default on

2019-12-28 Thread Xiaoyao Li
On Sat, 2019-12-28 at 10:57 +, Paolo Bonzini wrote: > > > Il sab 28 dic 2019, 10:24 Xiaoyao Li ha scritto: > > BTW, it seems that this patch makes kernel_irqchip default on to workaround > > the > > bug. > > However, when explicitly configuring kernel_irqchip=off, guest still fails > >

[PATCH v2] accel/kvm: Make "kernel_irqchip" default on

2019-12-28 Thread Xiaoyao Li
Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an accelerator property") moves kernel_irqchip property from "-machine" to "-accel kvm", but it forgets to set the default value of kernel_irqchip_allowed and kernel_irqchip_split. Also cleaning up the three useless members

Re: [PATCH] accel/kvm: Make "kernel_irqchip" default on

2019-12-28 Thread Paolo Bonzini
Il sab 28 dic 2019, 10:24 Xiaoyao Li ha scritto: > BTW, it seems that this patch makes kernel_irqchip default on to > workaround the > bug. > However, when explicitly configuring kernel_irqchip=off, guest still fails > booting due to "KVM: failed to send PV IPI: -95" with a latest upstream >

Re: [PATCH] accel/kvm: Make "kernel_irqchip" default on

2019-12-28 Thread Xiaoyao Li
On Sat, 2019-12-28 at 10:02 +, Paolo Bonzini wrote: > > > Il sab 28 dic 2019, 09:48 Xiaoyao Li ha scritto: > > Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an > > accelerator property") moves kernel_irqchip property from "-machine" to > > "-accel kvm", but it forgets to

Re: [PATCH] accel/kvm: Make "kernel_irqchip" default on

2019-12-28 Thread Paolo Bonzini
Il sab 28 dic 2019, 09:48 Xiaoyao Li ha scritto: > Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an > accelerator property") moves kernel_irqchip property from "-machine" to > "-accel kvm", but it forgets to set the default value of > kernel_irqchip_allowed and

[PATCH] accel/kvm: Make "kernel_irqchip" default on

2019-12-28 Thread Xiaoyao Li
Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an accelerator property") moves kernel_irqchip property from "-machine" to "-accel kvm", but it forgets to set the default value of kernel_irqchip_allowed and kernel_irqchip_split. Also cleaning up the three useless members