From: Liu Jingqi
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT). Before using
hmat-lb option, enable HMA
Devices tend to maintain vq pointers, allow deleting them trough a vq pointer.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: David Hildenbrand
Reviewed-by: David Hildenbrand
---
include/hw/virtio/virtio.h | 2 ++
hw/virtio/virtio.c | 15 ++-
2 files changed, 12 insertions
From: Joel Stanley
Following the pattern of the work recently done with the ASPEED GPIO
model, this adds support for inspecting and modifying the PCA9552 LEDs
from the monitor.
(qemu) qom-set /machine/unattached/device[17] led0 on
(qemu) qom-set /machine/unattached/device[17] led0 off
(qemu
These buffers should be aligned on 16 bytes.
Signed-off-by: Cédric Le Goater
---
hw/net/ftgmac100.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c
index 86ac25894a89..051f7b7af2d6 100644
--- a/hw/net/ftgmac100.c
+++ b/hw/net/ftgmac100.c
The overhead for the OpenBMC firmware images using the a custom U-Boot
is around 2 seconds, which is fine, but with a U-Boot from mainline,
it takes an extra 50 seconds or so to reach Linux. A quick survey on
the number of reads performed on the flash memory region gives the
following figures :
From: Michael Roth
Currently the SLOF firmware for pseries guests will disable/re-enable
a PCI device multiple times via IO/MEM/MASTER bits of PCI_COMMAND
register after the initial probe/feature negotiation, as it tends to
work with a single device at a time at various stages like probing
and ru
Hi,
Here is a short series adding :
- a new eMMC controller model for the AST2600 SoC (Andrew)
- accessors to control the led state of the pca9552 device (Joel)
- a 'execute-in-place' property to boot directly from CE0
Thanks,
C.
Andrew Jeffery (2):
hw/sd: Configure number of slots expose
Let's make sure calling this twice is harmless -
no known instances, but seems safer.
Suggested-by: Pan Nengyuan
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 31dd140990..6de3cfdc2c 1006
Am 23.12.2019 um 18:51 hat Alexander Popov geschrieben:
> The commit a718978ed58a from July 2015 introduced the assertion which
> implies that the size of successful DMA transfers handled in ide_dma_cb()
> should be multiple of 512 (the size of a sector). But guest systems can
> initiate DMA transf
On Wed, Dec 18, 2019 at 11:30:12AM +, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> I've got a case where usbredir_write manages to call back into itself
> via spice; this patch causes the recursion to fail (0 bytes) the write;
> this seems to avoid the deadlock I w
From: Andrew Jeffery
The AST2600 includes a second cut-down version of the SD/MMC controller
found in the AST2500, named the eMMC controller. It's cut down in the
sense that it only supports one slot rather than two, but it brings the
total number of slots supported by the AST2600 to three.
The
The following changes since commit f0dcfddecee8b860e015bb07d67cfcbdfbfd51d9:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2020-01-03 17:18:08 +)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_u
On 1/7/2020 4:48 AM, Alex Williamson wrote:
On Thu, 2 Jan 2020 18:25:37 +
"Dr. David Alan Gilbert" wrote:
* Alex Williamson (alex.william...@redhat.com) wrote:
On Fri, 20 Dec 2019 01:40:35 +0530
Kirti Wankhede wrote:
On 12/19/2019 10:57 PM, Alex Williamson wrote:
If d
> diff --git a/audio/audio.c b/audio/audio.c
> index 56fae55047..57daf3f620 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info,
> struct audsettings *as)
> switch (as->fmt) {
> case AUDIO_FORMAT_S8:
> si
On 1/6/20 11:19 PM, Finn Thain wrote:
On Fri, 20 Dec 2019, Finn Thain wrote:
The in_use field is no different to the other words handled using
dp8393x_put() and dp8393x_get(). Use the same technique for in_use
that is used everywhere else.
Signed-off-by: Finn Thain
---
Changed since v1:
- U
Hi,
> {
> bool zoom_to_fit = false;
>
> +int refresh_rate_millihz = 0;
Please drop the blank line between the variable declarations.
Also there is no need to zero-initialize the variable ...
> +refresh_rate_millihz = gdk_monitor_get_refresh_rate(monitor);
... as it is set unco
On 1/7/20 7:16 AM, Kevin Wolf wrote:
Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben:
On 1/6/20 4:54 PM, Corey Minyard wrote:
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
Hello,
[...]
Which is cleaner and requires less brain cycles to wonder
whethe
On 1/6/20 7:24 PM, Daniel Henrique Barboza wrote:
There are trailing whitespaces in this file that, if removed
by a text editor that refuses to let the traiing whitespace
typo "trailing"
alone, which happens to be the editor I am using, will cause
checkpatch.pl to warn about styling problems
On 1/6/20 7:23 PM, Daniel Henrique Barboza wrote:
'err' can be replaced by 'return r'.
CC: Gonglei
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Philippe Mathieu-Daudé
---
backends/cryptodev-vhost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/backends/
On 1/6/20 7:23 PM, Daniel Henrique Barboza wrote:
The 'fail' label is a simply call to 'return -1' on error. Remove
it and do the return call instead.
CC: Marc-André Lureau
CC: Paolo Bonzini
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char-win
On 1/3/20 7:49 AM, David Gibson wrote:
On Thu, Jan 02, 2020 at 01:21:09PM +0530, Ganesh Goudar wrote:
From: Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register"
and "ibm,nmi-interlock" RTAS calls.
The machine check notification address is saved when the
OS issues "ib
Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben:
>
>
> On 1/6/20 4:54 PM, Corey Minyard wrote:
> > On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
> > > Hello,
> [...]
> > >
> > > Which is cleaner and requires less brain cycles to wonder
> > > whether the
Since commit 6040aedddb5f474a9c2304b6a432a652d82b3d3c "virtio-blk:
make queue size configurable",if the user set the queue size to
more than 128 ,it will not take effect. That's because linux aio's
maximum outstanding requests at a time is always less than or equal
to 128.
This patch simply increa
Currently we use a big switch statement in ppc_hash64_update_rmls() to work
out what the right RMA limit is based on the LPCR[RMLS] field. There's no
formula for this - it's just an arbitrary mapping defined by the existing
CPU implementations - but we can make it a bit more readable by using a
lo
Am 06.01.2020 um 19:21 hat Marc-André Lureau geschrieben:
> > What my patch does is moving everything into a coroutine. This is wrong
> > because not everything can be run in a coroutine, so it needs to be made
> > optional (like you did with your async flag).
>
> "everything" is a bit too much ;)
When the LPCR is written, we update the env->rmls field with the RMA limit
it implies. Simplify things by just calculating the value directly from
the LPCR value when we need it.
It's possible this is a little slower, but it's unlikely to be significant,
since this is only for real mode accesses
For the "pseries" machine, we use "virtual hypervisor" mode where we only
model the CPU in non-hypervisor privileged mode. This means that we need
guest physical addresses within the modelled within the cpu to be treated
as absolute physical addresses.
We used to do that by clearing LPCR[VPM0] an
When we store the Logical Partitioning Control Register (LPCR) we have a
big switch statement to work out which are valid bits for the cpu model
we're emulating.
As well as being ugly, this isn't really conceptually correct, since it is
based on the mmu_model variable, whereas the LPCR isn't (only
When running guests under a hypervisor, the hypervisor obviously needs to
be protected from guest accesses even if those are in what the guest
considers real mode (translation off). The POWER hardware provides two
ways of doing that: The old way has guest real mode accesses simply offset
and bound
Currently we create the Real Mode Offset Register (RMOR) on all Book3S cpus
from POWER7 onwards. However the translation mode which the RMOR controls
is no longer supported in POWER9, and so the register has been removed from
the architecture.
Remove it from our model on POWER9 and POWER10.
Sign
The PowerPC 970 CPU was a cut-down POWER4, which had hypervisor capability.
However, it can be (and often was) strapped into "Apple mode", where the
hypervisor capabilities were disabled (essentially putting it always in
hypervisor mode).
That's actually the only mode of the 970 we support in qemu
The table of RMA limits based on the LPCR[RMLS] field is slightly wrong.
We're missing the RMLS == 0 => 256 GiB RMA option, which is available on
POWER8, so add that.
The comment that goes with the table is much more wrong. We *don't* filter
invalid RMLS values when writing the LPCR, and there's
The only effect of the PPC_EMULATE_32BITS_HYPV define is to change how
MSR_HVB is defined. This appears to be something to handle hypervisor mode
for 32-bit CPUs, but there's really no other code to handle this. The
MSR_THV bit, which it uses is implemented for no cpus we model.
It's unlikely an
POWER "book S" (server class) cpus have a concept of "real mode" where
MMU translation is disabled... sort of. In fact this can mean a bunch
of slightly different things when hypervisor mode and other
considerations are present.
We had some errors in edge cases here, so clean some things up and
c
On ppc we have the concept of virtual hypervisor ("vhyp") mode, where we
only model the non-hypervisor-privileged parts of the cpu. Essentially we
model the hypervisor's behaviour from the point of view of a guest OS, but
we don't model the hypervisor's execution.
In particular, in this mode, qem
On 06/01/2020 15:19, David Gibson wrote:
>> +
>> +static uint32_t client_package_to_path(const void *fdt, uint32_t phandle,
>> + uint32_t buf, uint32_t len)
>> +{
>> +char tmp[256];
>
> Fixed sized buffers are icky. You could either dynamically allocat
Hi All,
No news for a while about this series.
This version already add new docs to address Paolo's comments.
Please give me more comments.
Thanks
Zhang Chen
On 12/17/2019 8:45 PM, Zhang, Chen wrote:
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side, it c
Hi Richard,
Thanks for the comments of the part 1. It's really very helpful.
I accept most of the comments.
On 2020/1/4 7:41, Richard Henderson wrote:
On 1/3/20 2:33 PM, LIU Zhiwei wrote:
vsetvl and vsetvli are two configure instructions for vl, vtype. TB flags
should update after configure i
On 12/21/19 12:46 AM, Damien Hedde wrote:
> Hi All,
>
> This series is a follow-up of my reset series,
> https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04664.html
>
> I've extracted the raspberry-pi related patches. As suggested by Peter
> in the previous version of the reset serie, the
On 07/01/2020 01:15, Daniel Henrique Barboza wrote:
> Hey,
>
> On 1/5/20 8:38 PM, Alexey Kardashevskiy wrote:
>> Another version is coming, I'll start putting fewer people in the cc:
>> list, watch qemu-...@nongnu.org for further updates if interested.
>> Thanks,
>
>
> Question: does Petitboo
On 07/01/2020 04:25, Peter Maydell wrote:
> On Mon, 6 Jan 2020 at 17:09, Cédric Le Goater wrote:
>> ARM bootloaders are also embedded in QEMU's code. See hw/arm/boot.c.
>> You could improve a bit the definition though.
>
> Given an opportunity to restart from scratch I don't know
> that I'd do
On 2020/1/7 5:48, Jim Wilson wrote:
On 1/2/20 7:33 PM, LIU Zhiwei wrote:
+ if (cpu->cfg.vlen > RV_VLEN_MAX) {
+ error_setg(errp,
+ "Vector extension VLEN must <= %d",
RV_VLEN_MAX);
+ return;
There is no architectural maximum for
On Mon, Jan 6, 2020 at 9:51 AM Palmer Dabbelt wrote:
>
> On Mon, 09 Dec 2019 10:10:45 PST (-0800), Alistair Francis wrote:
> > Setting write permission on dirty PTEs results in userspace inside a
> > Hypervisor guest (VU) becoming corrupted. This appears to be because it
> > ends up with write per
On 2020/1/7 6:00, Jim Wilson wrote:
On 1/2/20 7:33 PM, LIU Zhiwei wrote:
Until v0.7.1 specification, vector status is still not defined for
mstatus.
The v0.8 spec does define a VS bit in mstatus.
Yes, I will also support v0.8 spec after the v0.7.1 spec.
@@ -107,11 +112,6 @@ static int pmp
On Mon, Jan 06, 2020 at 03:56:44PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> And call it from a QEMU reset handler. This allows each PNV child class to
> override the reset hook if needed, eg. POWER8 doesn't but POWER9 does.
> The proper way to do that would be to use device_class_set_
On Mon, Jan 06, 2020 at 03:56:38PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> Now that the spapr and pnv machines do set the "xive-fabric" link, the
> use of the XIVE fabric pointer becomes mandatory. This is checked with
> an assert() in a new realize hook. Since the XIVE router is rea
On Mon, Jan 06, 2020 at 03:56:43PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> And use it instead of reaching out to the machine. This allows to get
> rid of pnv_get_chip().
>
> Signed-off-by: Greg Kurz
> Signed-off-by: Cédric Le Goater
6..10 applied to ppc-for-5.0.
> ---
> include
On Mon, Jan 06, 2020 at 05:32:07PM +0100, Cédric Le Goater wrote:
> spapr_match_nvt() is a XIVE operation and it used by the machine to
> look for a matching target when an event notification is being
> delivered. An assert checks that spapr_match_nvt() is called only when
> the machine has selecte
On Mon, Jan 06, 2020 at 03:23:27PM -0300, Daniel Henrique Barboza wrote:
> 'out' can be replaced by 'return' with the appropriate
> return value.
>
> CC: David Gibson
> CC: qemu-...@nongnu.org
> Signed-off-by: Daniel Henrique Barboza
Applied to ppc-for-5.0. I see this is part of a larged serie
On Tue, Jan 07, 2020 at 12:39:42AM +1100, Alexey Kardashevskiy wrote:
>
>
> On 06/01/2020 15:19, David Gibson wrote:
>
> > > +const struct fdt_property *prop;
> > > +const char *tmp;
> > > +
> > > +readstr(prevaddr, prev);
> > > +for (offset = fdt_first_property_offset(fdt, offse
On Mon, Jan 06, 2020 at 03:23:28PM -0300, Daniel Henrique Barboza wrote:
> 'out' label can be replaced by 'return -1' in all cases.
>
> CC: David Gibson
> CC: qemu-...@nongnu.org
> Signed-off-by: Daniel Henrique Barboza
Applied to ppc-for-5.0.
> ---
> hw/ppc/ppc440_bamboo.c | 8 ++--
> 1
On Mon, Jan 06, 2020 at 11:29:42AM +0100, Greg Kurz wrote:
> The number of CPU chips of the powernv machine is configurable through a
> "num-chips" property. This doesn't fit well with the CPU topology, eg.
> some configurations can come up with more CPUs than the maximum of CPUs
> set in the toplo
On Mon, Jan 06, 2020 at 06:29:31PM +0100, Greg Kurz wrote:
> On Mon, 6 Jan 2020 17:32:07 +0100
> Cédric Le Goater wrote:
>
> > spapr_match_nvt() is a XIVE operation and it used by the machine to
>
> ... and it "is" used by the machine...
Adjusted in my tree.
>
> > look for a matching target
** Patch added: "generated_mips_syscall_table.template.patch"
https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5318010/+files/generated_mips_syscall_table.template.patch
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
http
Please do not use previous workaround in prod, it is bad, just proof of
concept.
It looks like nobody is maintaining syscall list. It is not possible to
trust it.
We have "arch/mips/kernel/syscalls/syscall_o32.tbl", we need to create
generator. Generator should provide maximum possible number of
Daniel Henrique Barboza wrote:
> ram_save_queue_pages() has an 'err' label that can be replaced by
> 'return -1' instead.
>
> Same thing with ram_discard_range(), and in this case we can also
> get rid of the 'ret' variable and return either '-1' on error
> or the result of ram_block_discard_range
Public bug reported:
I have built [both] current git, and 4.2.0, there are issues with audio/soundhw
for both.
Specifics:
Linux nullrig 5.3.0-24-generic #26-Ubuntu SMP Thu Nov 14 01:33:18 UTC
2019 x86_64 x86_64 x86_64 GNU/Linux
Out of source build, successful for both:
../configure --prefix=
./qemu is a symlink to qemu/build/i386-softmmu/qemu-system-i386
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1858488
Title:
qemu git && 4.2: timed audio issues with sb16, gus not working?
Statu
On Thu, 2 Jan 2020 18:25:37 +
"Dr. David Alan Gilbert" wrote:
> * Alex Williamson (alex.william...@redhat.com) wrote:
> > On Fri, 20 Dec 2019 01:40:35 +0530
> > Kirti Wankhede wrote:
> >
> > > On 12/19/2019 10:57 PM, Alex Williamson wrote:
> > >
> > >
> > >
>
>
>
> > >
> > > If d
The documentation on the new plugin capabilities of qemu is silent about the
order call back registration should be done, and is also silent on the order in
which call backs are fired.
Case in point: The callback registered by qemu_plugin_register_vcpu_mem_cb is
called after the call back regis
On Fri, 20 Dec 2019, Finn Thain wrote:
> The in_use field is no different to the other words handled using
> dp8393x_put() and dp8393x_get(). Use the same technique for in_use
> that is used everywhere else.
>
> Signed-off-by: Finn Thain
> ---
> Changed since v1:
> - Use existing 'address' vari
On Tue, 24 Dec 2019, hpous...@reactos.org wrote:
> >
> > I haven't tried the latest iso (9.0-rc1).
> >
I found that NetBSD 9.0-rc1 has the same regressions.
>
> Hello Finn,
>
> Thanks for finding the required steps to boot NetBSD on MIPS Magnum. I
> was trying to find how to let it work on
On Tue, 31 Dec 2019 08:39:15 -0500
Peter Xu wrote:
> The kvm irqchip notifier is only registered if the device supports
> INTx, however it's unconditionally removed. If the assigned device
> does not support INTx, this will cause QEMU to crash when unplugging
> the device from the system. Chang
From: Peter Xu
The kvm irqchip notifier is only registered if the device supports
INTx, however it's unconditionally removed. If the assigned device
does not support INTx, this will cause QEMU to crash when unplugging
the device from the system. Change it to conditionally remove the
notifier on
The following changes since commit 48008198270e3ebcc9394401d676c54ed5ac139c:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2019-12-20 11:20:25 +)
are available in the Git repository at:
git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20200106.0
On 1/2/20 7:33 PM, LIU Zhiwei wrote:
Until v0.7.1 specification, vector status is still not defined for
mstatus.
The v0.8 spec does define a VS bit in mstatus.
@@ -107,11 +112,6 @@ static int pmp(CPURISCVState *env, int csrno)
/* User Floating-Point CSRs */
static int read_fflags(CPURISCV
On 1/2/20 7:33 PM, LIU Zhiwei wrote:
+if (cpu->cfg.vlen > RV_VLEN_MAX) {
+error_setg(errp,
+ "Vector extension VLEN must <= %d", RV_VLEN_MAX);
+return;
There is no architectural maximum for VLEN. This is simply an
implementatio
On Montag, 6. Januar 2020 18:49:10 CET Greg Kurz wrote:
> On Mon, 06 Jan 2020 16:10:28 +0100
>
> Christian Schoenebeck wrote:
> > On Montag, 6. Januar 2020 13:30:24 CET Greg Kurz wrote:
> > > On Wed, 18 Dec 2019 14:17:59 +0100
> > >
> > > Christian Schoenebeck wrote:
> > > > A good 9p client se
Am 06.01.20 um 19:23 schrieb Daniel Henrique Barboza:
> The 'fail' label can be replaced by 'return ret' or by
> a 'return' with the error code that was being set right
> before the 'goto' call.
>
> CC: Stefan Weil
> CC: qemu-bl...@nongnu.org
> Signed-off-by: Daniel Henrique Barboza
> ---
> blo
On 1/6/20 4:54 PM, Corey Minyard wrote:
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
Hello,
[...]
Which is cleaner and requires less brain cycles to wonder
whether the 'cleanup' label does anything special, such
as a heap memory cleanup.
I would disagree with
ository at:
git://github.com/OSLL/qemu-xtensa.git tags/20200106-xtensa
for you to fetch changes up to a153a3f73d8e028be996f1602fa99c7f3f53348c:
target/xtensa: use MPU background map from core configuration (2020-01-06
11:4
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
> Hello,
>
> This is the type of cleanup I've contributed to Libvirt
> during the last year. Figured QEMU also deserves the same
> care.
>
> The idea here is remove unneeded labels. By 'unneeded' I
> mean labels that does no
From: Stefano Stabellini
init_in_iov_from_pdu might not be able to allocate the full buffer size
requested, which comes from the client and could be larger than the
transport has available at the time of the request. Specifically, this
can happen with read operations, with the client requesting a
On Mon, 6 Jan 2020, Greg Kurz wrote:
> On Mon, 06 Jan 2020 16:24:18 +0100
> Christian Schoenebeck wrote:
>
> > On Montag, 6. Januar 2020 14:42:54 CET Greg Kurz wrote:
> > > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> > > > index 775e8ff766..68873c3f5f 100644
> > > > -
* Daniel Henrique Barboza (danielhb...@gmail.com) wrote:
> ram_save_queue_pages() has an 'err' label that can be replaced by
> 'return -1' instead.
>
> Same thing with ram_discard_range(), and in this case we can also
> get rid of the 'ret' variable and return either '-1' on error
> or the result
Add a GitLab job to build the EDK2 firmware binaries.
This job is only built when the roms/edk2/ submodule is updated,
when a git-ref starts with 'edk2' or when the last commit contains
'EDK2'.
GitLab CI generates an artifacts.zip file containing the firmware
binaries.
With edk2-stable201905, the
The Debian (based) distributions currently provides 2 ARM
toolchains, documented as [1]:
* The ARM EABI (armel) port targets a range of older 32-bit ARM
devices, particularly those used in NAS hardware and a variety
of *plug computers.
* The newer ARM hard-float (armhf) port supports newer, mo
On Mon, Jan 06, 2020 at 03:23:45PM -0300, Daniel Henrique Barboza wrote:
> The 'out' labels for check_host_key_knownhosts() and authenticate()
> functions can be removed and, instead, call 'return' with the
> appropriate return value. The 'ret' integer from both functions
> could also be removed.
>
'out' can be replaced by 'return' calls with the adequate
return value.
CC: Riku Voipio
CC: Laurent Vivier
Signed-off-by: Daniel Henrique Barboza
---
linux-user/vm86.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/linux-user/vm86.c b/linux-user/vm86.c
index 2fa7a89
There are trailing whitespaces in this file that, if removed
by a text editor that refuses to let the traiing whitespace
alone, which happens to be the editor I am using, will cause
checkpatch.pl to warn about styling problems in the resulting
patch. This happens because the trailing whitespace lin
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: Vivek Goyal
> > >
> > > We need to create files in the caller's context. Otherwise after
> >
'out' can be replaced by 'return ret'. Since 'ret' is used
just to set the return value, drop the 'ret' variable and
use 'return' with the appropriate value instead.
CC: Riku Voipio
CC: Laurent Vivier
Signed-off-by: Daniel Henrique Barboza
---
linux-user/signal.c | 20 ++--
1 f
On Mon, Jan 6, 2020 at 10:25 PM Daniel Henrique Barboza
wrote:
>
> The 'fail' label is simply doing a 'return -1'.
>
> CC: Marc-André Lureau
> CC: Paolo Bonzini
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Marc-André Lureau
> ---
> chardev/char-pipe.c | 13 +
> 1 file c
'out' label can be replaced by 'return ret'. Since 'ret' will
be set to -ENOMEM in 'goto' time, we can replace it to
'return -ENOMEM'.
After this change, the 'ret' var is used to store the
result of rdma_backend_create_pd(), see if it's not zero,
then 'ret' is set to -EIO before the jump to out_tb
'err_out' can be replaced by 'return ret' in the error conditions
the jump was being made.
CC: Greg Kurz
Signed-off-by: Daniel Henrique Barboza
---
hw/9pfs/9p-local.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index c
On 1/6/20 6:25 PM, Peter Maydell wrote:
On Mon, 6 Jan 2020 at 17:09, Cédric Le Goater wrote:
ARM bootloaders are also embedded in QEMU's code. See hw/arm/boot.c.
You could improve a bit the definition though.
Given an opportunity to restart from scratch I don't know
that I'd do things the way
'remap_fail' label can be replaced by 'return' with the
adequate error value.
CC: Michael S. Tsirkin
CC: Marcel Apfelbaum
Signed-off-by: Daniel Henrique Barboza
---
hw/i386/amd_iommu.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i3
We provide the EDK2 firmware binaries in pc-bios/. When we
update the roms/edk2/ submodule, we need to rebuild the
firmware binaries.
To avoid the burden on a single developer, this series add
a GitLab job to generate reproducible EDK2 firmware binaries.
The job is only on specific conditions:
- r
On Mon, Jan 6, 2020 at 10:25 PM Daniel Henrique Barboza
wrote:
>
> The 'fail' label is a simply call to 'return -1' on error. Remove
> it and do the return call instead.
>
> CC: Marc-André Lureau
> CC: Paolo Bonzini
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Marc-André Lureau
> --
On Mon, Jan 6, 2020 at 10:25 PM Daniel Henrique Barboza
wrote:
>
> CC: Marc-André Lureau
> CC: Paolo Bonzini
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Marc-André Lureau
> ---
> chardev/char-mux.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/chardev/
'out' label can be replaced by 'return'.
CC: Corey Minyard
Signed-off-by: Daniel Henrique Barboza
---
hw/ipmi/ipmi_bmc_extern.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index 87da9ff99c..16d9114725 100644
--- a
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git) wrote:
> > From: Vivek Goyal
> >
> > We need to create files in the caller's context. Otherwise after
> > creating a file, the caller might not be able to do file operations
'out4' can be replaced by 'return 2'.
CC: Kevin Wolf
CC: Max Reitz
CC: qemu-bl...@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
qemu-img.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 6233b8ca56..fc7b08e7ee 100644
--- a/qemu-i
By using ccache we reduce the job duration from
40 minutes 26 seconds to 32 minutes 6 seconds.
Running after script...
$ ccache --show-stats
cache hit (direct) 6604
files in cache 12090
cache size 335.5 MB
For now downloading
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Dec 12, 2019 at 04:38:10PM +, Dr. David Alan Gilbert (git) wrote:
> > From: Stefan Hajnoczi
> >
> > Only allow system calls that are needed by virtiofsd. All other system
> > calls cause SIGSYS to be directed at the thread and the p
'out' can be replaced by 'return pci' instead.
CC: Stefan Weil
Signed-off-by: Daniel Henrique Barboza
---
qga/commands-win32.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 2461fd19bf..c520a341df 100644
--
'out2' label in do_sendrecvmsg_locked() can be replaced by
'return' with the adequate exit value. Same thing with the
label 'out' in do_ioctl_blkpg(), and in that function we
can get rid of the 'ret' variable as well.
CC: Riku Voipio
CC: Laurent Vivier
Signed-off-by: Daniel Henrique Barboza
---
'err' can be replaced by 'return 1'.
Signed-off-by: Daniel Henrique Barboza
---
contrib/ivshmem-server/main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index e4cd35f74c..b491e8237f 100644
--- a/contr
'out' label in out_free_buf() is not used at all.
CC: Riku Voipio
CC: Laurent Vivier
Signed-off-by: Daniel Henrique Barboza
---
linux-user/flatload.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 0122ab3afe..3945c40ee1 100644
--- a/linux
'exit' label of vhdx_region_check() and vhdx_update_header()
can be replaced by 'return' statements.
CC: Jeff Cody
CC: qemu-bl...@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/vhdx.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/vhdx.c b/bloc
1 - 100 of 328 matches
Mail list logo
