Re: [PATCH] riscv: sifive_u: Add a "serial" property for board serial number

2020-01-09 Thread Bin Meng
Hi Palmer, On Fri, Nov 22, 2019 at 10:38 AM Palmer Dabbelt wrote: > > On Thu, 21 Nov 2019 17:10:18 PST (-0800), bmeng...@gmail.com wrote: > > On Sat, Nov 16, 2019 at 11:08 PM Bin Meng wrote: > >> > >> At present the board serial number is hard-coded to 1, and passed > >> to OTP model during init

Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free()

2020-01-09 Thread Marc-André Lureau
Hi On Fri, Jan 10, 2020 at 7:17 AM wrote: > > From: Pan Nengyuan > > It's a mismatch between g_strsplit and g_free, it will cause a memory leak as > follow: > > [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help > Accelerators supported in QEMU binary: > tcg > kvm > ===

Re: Audio pace issue with qemu4.2

2020-01-09 Thread Gerd Hoffmann
On Fri, Jan 10, 2020 at 11:30:24AM +0530, padmashree mandri wrote: > Hi all, > > I am trying to run qemu4.2 with ALSA. Playback pace is fast. Where can > i set sampling rate and all parameters related to audio in qemu? https://www.kraxel.org/blog/2020/01/qemu-sound-audiodev/ HTH, Gerd

Re: [PATCH] virtio: add the queue number check

2020-01-09 Thread Yang Zhong
On Fri, Jan 03, 2020 at 10:18:58PM +0100, Paolo Bonzini wrote: > Il ven 3 gen 2020, 16:08 Yang Zhong ha scritto: > > > I also tried virtio-blk device like below: > > https://patchwork.kernel.org/cover/10873193/ > > > > The virtio-blk can work with this changes, but vhost-user-blk device >

RE: [PATCH v1 15/59] block/blkreplay.c: remove unneeded 'fail' label in blkreplay_open()

2020-01-09 Thread Pavel Dovgalyuk
> From: Daniel Henrique Barboza [mailto:danielhb...@gmail.com] > Sent: Monday, January 06, 2020 9:24 PM > To: qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; Daniel Henrique Barboza; Pavel Dovgalyuk; Paolo > Bonzini > Subject: [PATCH v1 15/59] block/blkreplay.c: remove unneeded 'fail' label i

Audio pace issue with qemu4.2

2020-01-09 Thread padmashree mandri
Hi all, I am trying to run qemu4.2 with ALSA. Playback pace is fast. Where can i set sampling rate and all parameters related to audio in qemu? Thanks padma

[PATCH] vl: Don't mismatch g_strsplit()/g_free()

2020-01-09 Thread pannengyuan
From: Pan Nengyuan It's a mismatch between g_strsplit and g_free, it will cause a memory leak as follow: [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help Accelerators supported in QEMU binary: tcg kvm = ==1207900

RE: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-09 Thread Zengtao (B)
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Thursday, January 09, 2020 5:54 PM > To: Zengtao (B) > Cc: Michael S. Tsirkin; qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > Shannon Zhao; Peter Maydell; qemu-...@nongnu.org > Subject: Re: [PATCH] hw/arm/acp

Re: [PATCH 0/2] not use multifd during postcopy

2020-01-09 Thread Wei Yang
On Thu, Jan 09, 2020 at 10:50:25AM +0100, Juan Quintela wrote: >Wei Yang wrote: >> On Mon, Dec 16, 2019 at 10:35:39AM +0800, Wei Yang wrote: >>>Would this one be picked up this time? >> >> Happy new year to all. >> >> Can I ask the plan for this patch set? > >queued > Thanks :-) -- Wei Yang Hel

[PATCH qemu v5] spapr: Kill SLOF

2020-01-09 Thread Alexey Kardashevskiy
The Petitboot bootloader is way more advanced than SLOF is ever going to be as Petitboot comes with the full-featured Linux kernel with all the drivers, and initramdisk with quite user friendly interface. The problem with ditching SLOF is that an unmodified pseries kernel can either start via: 1. k

[Bug 1859081] Re: Mouse way too fast when Qemu is on a Windows VM with a OS 9 Guest

2020-01-09 Thread John Arbuckle
What is the QEMU command-line you use? Does this problem exist with the usb mouse (-device usb-mouse)? Could you try upgrading to the latest version of QEMU and see if the issue is resolved please? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

[Bug 1859106] [NEW] 4.2 regression: ReactOS crashes on boot

2020-01-09 Thread Mike Swanson
Public bug reported: In QEMU 4.1.x and earlier, ReactOS can successfully boot, but starting with 4.2, it fails, instead coming up with an error "The video driver failed to initialize." This happens regardless of VM configuration (even -M pc-i440fx-4.1) and it works well with older versions of QEM

[Bug 1859106] Re: 4.2 regression: ReactOS crashes on boot

2020-01-09 Thread Mike Swanson
I should add, ReactOS can be downloaded from here: https://reactos.org/download The LiveCD is sufficient to see the problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859106 Title: 4.2 regres

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-09 Thread Gurchetan Singh
I like the idea of having one central place in the kernel where virtio-devices get their uuid from -- i.e, no separate VM specific, device specific implementations calling into uuid_gen(). On Wed, Jan 8, 2020 at 3:20 AM David Stevens wrote: > > > Is there a specific reason why you want the host p

Re: [PATCH qemu v4] spapr: Kill SLOF

2020-01-09 Thread Alexey Kardashevskiy
On 10/01/2020 10:32, Alexey Kardashevskiy wrote: > > > On 10/01/2020 10:05, Alexey Kardashevskiy wrote: >> >> >> On 08/01/2020 17:18, Alexey Kardashevskiy wrote: >>> The Petitboot bootloader is way more advanced than SLOF is ever going to >>> be as Petitboot comes with the full-featured Linux

Does ppc target support for MTTCG are stable?

2020-01-09 Thread Yonggang Luo
I enabled it and working, but I don't know if there any other issue are still not resolved.. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] riscv/sifive_u: fix a memory leak in soc_realize()

2020-01-09 Thread Palmer Dabbelt
On Tue, 10 Dec 2019 10:38:29 PST (-0800), alistai...@gmail.com wrote: On Mon, Dec 9, 2019 at 11:15 PM wrote: From: Pan Nengyuan Fix a minor memory leak in riscv_sifive_u_soc_realize() Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Alistair Francis Thanks. This is

Re: [PATCH qemu v4] spapr: Kill SLOF

2020-01-09 Thread Alexey Kardashevskiy
On 10/01/2020 10:05, Alexey Kardashevskiy wrote: > > > On 08/01/2020 17:18, Alexey Kardashevskiy wrote: >> The Petitboot bootloader is way more advanced than SLOF is ever going to >> be as Petitboot comes with the full-featured Linux kernel with all >> the drivers, and initramdisk with quite u

Re: [PATCH qemu v4] spapr: Kill SLOF

2020-01-09 Thread Alexey Kardashevskiy
On 08/01/2020 17:18, Alexey Kardashevskiy wrote: > The Petitboot bootloader is way more advanced than SLOF is ever going to > be as Petitboot comes with the full-featured Linux kernel with all > the drivers, and initramdisk with quite user friendly interface. > The problem with ditching SLOF is

Re: version 3.2 is missing from QEMU download page

2020-01-09 Thread Aleksandar Markovic
On Thursday, January 9, 2020, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > Hi all, > > For some reason, QEMU download page > > https://download.qemu.org > > seems to contain tarballs of all QEMU versions/releases, except 3.2 and > its follow-ups. This broke up some scripts that rely

version 3.2 is missing from QEMU download page

2020-01-09 Thread Aleksandar Markovic
Hi all, For some reason, QEMU download page https://download.qemu.org seems to contain tarballs of all QEMU versions/releases, except 3.2 and its follow-ups. This broke up some scripts that rely on presence of all versions on that page. I don't know who is in charge of QEMU download page, but I

Re: [kvm-unit-tests PATCH 05/10] arm: pmu: Basic event counter Tests

2020-01-09 Thread Auger Eric
Hi Andre, On 1/7/20 1:19 PM, Andre Przywara wrote: > On Mon, 16 Dec 2019 21:47:52 +0100 > Eric Auger wrote: > > Hi Eric, > > thanks a lot for your work on these elaborate tests! I have some PMU test > extensions as well, but they are nowhere as sophisticated as yours! > > Just ran this on my

[PATCH] crypto: fix getter of a QCryptoSecret's property

2020-01-09 Thread Tong Ho
This fixes the condition-check done by the "loaded" property getter, such that the property returns true even when the secret is loaded by the 'file' option. Signed-off-by: Tong Ho --- Pre-existing getter returns true only when the secret is loaded by the 'data' option. crypto/secret.c | 3 ++

[Bug 1859081] [NEW] Mouse way too fast when Qemu is on a Windows VM with a OS 9 Guest

2020-01-09 Thread Roman Bäriswyl
Public bug reported: On a server, I have a Windows 10 VM with Qemu 4.1.0 (latest) from https://qemu.weilnetz.de/w64/ installed. There I have a Mac OS 9.2.2 machine. Now if I connect to the Windows VM with VNC or RDP or even VMWare console, the Mouse in the Mac OS Guest inside Qemu is wy to f

Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO

2020-01-09 Thread André Silva
Hi Greg, Thanks for the commit info. But I'm testing in this scenario, that is, a ppc64le host with a ppc64 BE guest, and without my patch I can't get virtio to work. The patch makes virtio 0.95 (legacy) net, scsi, blk work. I don't get the firmware error. I also tested with a ppc64le guest and ha

Re: [PATCH] target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle

2020-01-09 Thread Richard Henderson
On 1/9/20 3:12 PM, Masahiro Yamada wrote: > According to the specification "Semihosting for AArch32 and Aarch64", > the SYS_OPEN operation should return: > > - A nonzero handle if the call is successful > - -1 if the call is not successful > > So, it should never return 0. > > Prior to commit

Re: [PATCH v1 06/59] mips-semi.c: remove 'uhi_done' label in helper_do_semihosting()

2020-01-09 Thread Aleksandar Markovic
On Monday, January 6, 2020, Daniel Henrique Barboza wrote: > The label 'uhi_done' is a simple 'return' call and can > be removed for a bit more clarity in the code. > > CC: Aurelien Jarno > CC: Aleksandar Markovic > CC: Aleksandar Rikalo > Signed-off-by: Daniel Henrique Barboza > --- > targe

Re: [PATCH v1 00/59] trivial unneeded labels cleanup

2020-01-09 Thread Daniel Henrique Barboza
On 1/7/20 6:43 AM, Max Reitz wrote: On 06.01.20 19:23, Daniel Henrique Barboza wrote: [...] For me, it doesn’t require any brain cycles, because I generally just assume the cleanup label will do the right thing. OTOH, a return statement may make me invest some some brain cycles, because

Re: [PATCH 092/104] virtiofsd: add man page

2020-01-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:38:52PM +, Dr. David Alan Gilbert (git) wrote: > > From: Stefan Hajnoczi > > > > Signed-off-by: Stefan Hajnoczi > > --- > > Makefile | 7 +++ > > tools/virtiofsd/virtiofsd.texi | 85 +++

Re: [PATCH v1 00/59] trivial unneeded labels cleanup

2020-01-09 Thread Daniel Henrique Barboza
On 1/7/20 4:06 AM, Philippe Mathieu-Daudé wrote: On 1/7/20 7:16 AM, Kevin Wolf wrote: Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben: On 1/6/20 4:54 PM, Corey Minyard wrote: On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote: Hello, [...] Which is cl

[PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-09 Thread Alberto Garcia
This replaces all remaining instances in the qcow2 code. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 2 +- block/qcow2.c | 10 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 932fc48919..777ca2d4

[PATCH v2 2/4] qcow2: Don't round the L1 table allocation up to the sector size

2020-01-09 Thread Alberto Garcia
The L1 table is read from disk using the byte-based bdrv_pread() and is never accessed beyond its last element, so there's no need to allocate more memory than that. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 5 ++--- block/qcow2-refcount.c | 2 +- block/qcow2-snapshot.c | 3 +--

[PATCH v2 0/4] qcow2: Misc BDRV_SECTOR_SIZE updates

2020-01-09 Thread Alberto Garcia
This small series gets rid of all the remaining instances of hardcoded sector sizes in the qcow2 code and adds a check for images whose virtual size is not a multiple of the sector size. See the individual patches for details. Berto v2: - Modify output of iotest 080 to make it easier to understa

[PATCH v2 3/4] qcow2: Tighten cluster_offset alignment assertions

2020-01-09 Thread Alberto Garcia
qcow2_alloc_cluster_offset() and qcow2_get_cluster_offset() always return offsets that are cluster-aligned so don't just check that they are sector-aligned. The check in qcow2_co_preadv_task() is also replaced by an assertion for the same reason. Signed-off-by: Alberto Garcia --- block/qcow2.c

[PATCH v2 1/4] qcow2: Require that the virtual size is a multiple of the sector size

2020-01-09 Thread Alberto Garcia
The qcow2 header specifies the virtual size of the image in bytes, but BlockDriverState stores it as a number of 512-byte sectors. If the user tries to create an image with a size that is not a multiple of the sector size then this is fixed on creation by silently rounding the image size up (see c

Re: [PATCH v2 3/9] hw/9pfs/9p-synth: added directory for readdir test

2020-01-09 Thread Greg Kurz
On Wed, 18 Dec 2019 14:23:48 +0100 Christian Schoenebeck wrote: > This will provide the following virtual files by the 9pfs > synth driver: > > - /ReadDirDir/ReadDirFile99 > - /ReadDirDir/ReadDirFile98 > ... > - /ReadDirDir/ReadDirFile1 > - /ReadDirDir/ReadDirFile0 > > This virtual di

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-09 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > Am 08.01.20 um 16:04 schrieb Dr. David Alan Gilbert: > > * Peter Lieven (p...@kamp.de) wrote: > > > Hi, > > > > > > > > > I have a Qemu 4.0.1 machine with vhost-net network adapter, thats > > > polluting the log with the above message. > > > > > > Is this

[PATCH 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-09 Thread Kevin Wolf
This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher than the command handler is safe to be run in a coroutine. Signed-off-by: Kevin Wolf --- tests/qapi-schema/qapi-schema-test.json | 1 + docs/devel/qapi-code-gen.txt| 4 include/qapi

[PATCH 0/4] qmp: Optionally run handlers in coroutines

2020-01-09 Thread Kevin Wolf
Some QMP command handlers can block the main loop for a relatively long time, for example because they perform some I/O. This is quite nasty. Allowing such handlers to run in a coroutine where they can yield (and therefore release the BQL) while waiting for an event such as I/O completion solves th

[PATCH 4/4] qmp: Move dispatcher to a coroutine

2020-01-09 Thread Kevin Wolf
This moves the QMP dispatcher to a coroutine and runs all QMP command handlers that declare 'coroutine': true in coroutine context so they can avoid blocking the main loop while doing I/O or waiting for other events. For commands that are not declared safe to run in a coroutine, the dispatcher dro

[PATCH 3/4] vl: Initialise main loop earlier

2020-01-09 Thread Kevin Wolf
We want to be able to use qemu_aio_context in the monitor initialisation. Signed-off-by: Kevin Wolf --- vl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 86474a55c9..4c79a00857 100644 --- a/vl.c +++ b/vl.c @@ -2903,6 +2903,11 @@ int main(int ar

[PATCH 2/4] block: Mark 'block_resize' as coroutine

2020-01-09 Thread Kevin Wolf
block_resize is safe to run in a coroutine, so use it as an example for the new 'coroutine': true annotation in the QAPI schema. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json in

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-09 Thread Peter Lieven
Am 08.01.20 um 16:04 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I have a Qemu 4.0.1 machine with vhost-net network adapter, thats polluting the log with the above message. Is this something known? Googling revealed the following patch in Nemu (with seems to be

Re: [PATCH 04/15] hw/ppc/spapr_rtas: Restrict variables scope to single switch case

2020-01-09 Thread Greg Kurz
On Thu, 9 Jan 2020 16:21:22 +0100 Philippe Mathieu-Daudé wrote: > We only access these variables in RTAS_SYSPARM_SPLPAR_CHARACTERISTICS > case, restrict their scope to avoid unnecessary initialization. > I guess a decent compiler can be smart enough detect that the initialization isn't needed

Re: [PATCH 080/104] virtiofsd: add helper for lo_data cleanup

2020-01-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:38:40PM +, Dr. David Alan Gilbert (git) wrote: > > From: Liu Bo > > > > This offers an helper function for lo_data's cleanup. > > > > Signed-off-by: Liu Bo > > --- > > tools/virtiofsd/passthrough_ll.c | 37 +

Re: [PATCH 079/104] virtiofsd: fix memory leak on lo.source

2020-01-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:38:39PM +, Dr. David Alan Gilbert (git) wrote: > > From: Liu Bo > > > > valgrind reported that lo.source is leaked on quiting, but it was defined > > as (const char*) as it may point to a const string "/". > > > >

[Bug 1850000] Re: 4.1.0 bogus QCOW2 corruption reported after compress

2020-01-09 Thread Thomas Huth
Fix has been included in QEMU v4.2: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=24552feb6ae2f615b76c2 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-09 Thread Auger Eric
Hi Andre, On 1/9/20 6:30 PM, André Przywara wrote: > On 09/01/2020 16:54, Auger Eric wrote: > > Hi Eric, > >> On 1/3/20 7:12 PM, Andre Przywara wrote: >>> On Mon, 16 Dec 2019 21:47:51 +0100 >>> Eric Auger wrote: >>> >>> Hi Eric, >>> If event counters are implemented check the common events

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-09 Thread André Przywara
On 09/01/2020 16:54, Auger Eric wrote: Hi Eric, > On 1/3/20 7:12 PM, Andre Przywara wrote: >> On Mon, 16 Dec 2019 21:47:51 +0100 >> Eric Auger wrote: >> >> Hi Eric, >> >>> If event counters are implemented check the common events >>> required by the PMUv3 are implemented. >>> >>> Some are uncond

[Bug 1835827] Re: HTIF symbols no longer recognized by RISC-V spike board

2020-01-09 Thread Thomas Huth
Patch has been included in QEMU v4.2: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6478dd745dca49d632 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

[Bug 1777777] Re: arm9 clock pending (SP804)

2020-01-09 Thread Thomas Huth
Fix has been included in QEMU v4.2: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5a65f7b5f4907ca70cb6 ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [PATCH] linux-aio: increasing MAX_EVENTS to a larger hardcoded value

2020-01-09 Thread Stefan Hajnoczi
On Tue, Jan 07, 2020 at 06:01:01AM +, Wangyong wrote: > Since commit 6040aedddb5f474a9c2304b6a432a652d82b3d3c "virtio-blk: > make queue size configurable",if the user set the queue size to > more than 128 ,it will not take effect. That's because linux aio's > maximum outstanding requests at a t

Re: [PATCH 2/2] hyperv/synic: Allocate as ram_device

2020-01-09 Thread Roman Kagan
On Thu, Jan 09, 2020 at 04:27:45PM +, Dr. David Alan Gilbert wrote: > * Roman Kagan (rka...@virtuozzo.com) wrote: > > On Thu, Jan 09, 2020 at 01:28:21PM +, Dr. David Alan Gilbert wrote: > > > * Roman Kagan (rka...@virtuozzo.com) wrote: > > > > On Thu, Jan 09, 2020 at 02:00:00PM +0100, Vital

Re: [PATCH 03/15] hw/ppc/spapr_rtas: Access MachineState via SpaprMachineState argument

2020-01-09 Thread Greg Kurz
On Thu, 9 Jan 2020 16:21:21 +0100 Philippe Mathieu-Daudé wrote: > We received a SpaprMachineState argument. Since SpaprMachineState > inherits of MachineState, use it instead of calling qdev_get_machine. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Greg Kurz > hw/ppc/spapr_

Re: [PATCH 02/15] hw/ppc/spapr_rtas: Use local MachineState variable

2020-01-09 Thread Greg Kurz
On Thu, 9 Jan 2020 16:21:20 +0100 Philippe Mathieu-Daudé wrote: > Since we have the MachineState already available locally, > ues it instead of the global current_machine. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Greg Kurz > hw/ppc/spapr_rtas.c | 2 +- > 1 file changed,

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

2020-01-09 Thread Igor Mammedov
On Mon, 6 Jan 2020 17:06:32 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Shameerali Kolothum Thodi > > Sent: 13 December 2019 12:52 > > To: 'Igor Mammedov' > > Cc: xiaoguangrong.e...@gmail.com; peter.mayd...@linaro.org; > > drjo...@redhat.com; sha

Re: [PATCH 056/104] virtiofsd: add security guide document

2020-01-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Jan 06, 2020 at 05:53:55PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Dec 12, 2019 at 04:38:16PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: Stefan Hajnoczi

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-09 Thread Auger Eric
Hi Andre, On 1/3/20 7:12 PM, Andre Przywara wrote: > On Mon, 16 Dec 2019 21:47:51 +0100 > Eric Auger wrote: > > Hi Eric, > >> If event counters are implemented check the common events >> required by the PMUv3 are implemented. >> >> Some are unconditionally required (SW_INCR, CPU_CYCLES, >> eith

[Bug 1528239] Re: Unable to debug PIE binaries with QEMU gdb stub.

2020-01-09 Thread Thomas Huth
Patch has been included in QEMU v4.2: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=dc12567a53c88d7a91b9 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

[PATCH 2/2] target/ppc: add support for Hypervisor Facility Unavailable Exception

2020-01-09 Thread Cédric Le Goater
The privileged message send and clear instructions (msgsndp & msgclrp) are privileged, but will generate a hypervisor facility unavailable exception if not enabled in the HFSCR and executed in privileged non-hypervisor state. Add checks when accessing the DPDES register and when using the msgsndp

[PATCH 1/2] target/ppc: Add privileged message send facilities

2020-01-09 Thread Cédric Le Goater
The Processor Control facility POWER8 processors and later provides a mechanism for the hypervisor to send messages to other threads in the system (msgsnd instruction) and cause hypervisor-level exceptions. Privileged non-hypervisor programs are also able to send messages (msgsndp instruction) but

[PATCH 0/2] ppc: add support for Directed Privileged Doorbell (non-hypervisor)

2020-01-09 Thread Cédric Le Goater
Hello, The Processor Control facility POWER8 processors and later provides a mechanism for the hypervisor to send messages to other threads in the system (msgsnd instruction) and cause hypervisor-level exceptions. Privileged non-hypervisor programs can also send messages (msgsndp instruction) but

Re: [PATCH 1/4] configure: Do not build libfdt is not required

2020-01-09 Thread Thomas Huth
On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > We only require libfdt for system emulation, in a small set > of architecture: > > 4077 # fdt support is mandatory for at least some target architectures, > 4078 # so insist on it if we're building those system emulators. > 4079 fdt_required=

Re: Pre-Christmas meeting notes

2020-01-09 Thread Thomas Huth
On 09/01/2020 16.03, Vladimir Sementsov-Ogievskiy wrote: > 06.01.2020 20:15, Max Reitz wrote: >> Misc >> >> >> The Wiki’s TODO list is horribly outdated. What should we do about >> it? Maybe archive it and start a new one? (Most of the things on the >> current list are either done or we don

Re: [PATCH 2/2] hyperv/synic: Allocate as ram_device

2020-01-09 Thread Dr. David Alan Gilbert
* Roman Kagan (rka...@virtuozzo.com) wrote: > On Thu, Jan 09, 2020 at 01:28:21PM +, Dr. David Alan Gilbert wrote: > > * Roman Kagan (rka...@virtuozzo.com) wrote: > > > On Thu, Jan 09, 2020 at 02:00:00PM +0100, Vitaly Kuznetsov wrote: > > > > "Dr. David Alan Gilbert" writes: > > > > > > > > >

[RFC PATCH] tests/tcg: add a vtimer test for aarch64

2020-01-09 Thread Alex Bennée
Bug: https://bugs.launchpad.net/bugs/1859021 Signed-off-by: Alex Bennée --- tests/tcg/aarch64/system/vtimer.c | 48 +++ tests/tcg/aarch64/Makefile.softmmu-target | 4 ++ 2 files changed, 52 insertions(+) create mode 100644 tests/tcg/aarch64/system/vtimer.c diff --g

Re: [PATCH 2/2] hyperv/synic: Allocate as ram_device

2020-01-09 Thread Roman Kagan
On Thu, Jan 09, 2020 at 01:28:21PM +, Dr. David Alan Gilbert wrote: > * Roman Kagan (rka...@virtuozzo.com) wrote: > > On Thu, Jan 09, 2020 at 02:00:00PM +0100, Vitaly Kuznetsov wrote: > > > "Dr. David Alan Gilbert" writes: > > > > > > > And I think vhost-user will fail if you have too many se

Re: [PATCH v12 00/13] VIRTIO-IOMMU device

2020-01-09 Thread Auger Eric
Hi, On 1/9/20 4:12 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200109144319.15912-1-eric.au...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker i

Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO

2020-01-09 Thread Greg Kurz
On Thu, 9 Jan 2020 07:39:17 -0500 "Michael S. Tsirkin" wrote: > On Thu, Jan 09, 2020 at 09:25:42AM -0300, André Silva wrote: > > Hi Michael! > > Thanks for reviewing the patch! > > > > > we always get LE values from memory subsystem, > > > not target endian values: > > > > I see. So do you thin

Re: [PATCH 06/15] migration/savevm: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > As we want to remove the global current_machine, > replace MACHINE_GET_CLASS(current_machine) by > MACHINE_GET_CLASS(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daudé > --- > migration/savevm.c | 10 +- > 1 file changed,

Re: [PATCH 2/2] hyperv/synic: Allocate as ram_device

2020-01-09 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 09/01/20 14:22, Dr. David Alan Gilbert wrote: >> * Michael S. Tsirkin (m...@redhat.com) wrote: >>> On Thu, Jan 09, 2020 at 12:22:37PM +, Dr. David Alan Gilbert wrote: Do we want a new memory_region_init for that or just to be able to add a flag? >>> I

[PATCH 2/4] Makefile: Clarify all the codebase requires qom/ objects

2020-01-09 Thread Philippe Mathieu-Daudé
QEMU user-mode also requires the qom/ objects, it is not only used by "system emulation and qemu-img". As we will use a big if() block, move it upper in the "Common libraries for tools and emulators" section. Signed-off-by: Philippe Mathieu-Daudé --- Makefile.objs | 6 +- 1 file changed, 1 i

Re: [PATCH 2/2] hyperv/synic: Allocate as ram_device

2020-01-09 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 09/01/20 14:22, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > >> On Thu, Jan 09, 2020 at 12:22:37PM +, Dr. David Alan Gilbert wrote: > >>> Do we want a new memory_region_init for that or just to be able to add

[PATCH 3/4] Makefile: Restrict system emulation and tools objects

2020-01-09 Thread Philippe Mathieu-Daudé
Restrict all the system emulation and tools objects with a Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. Using the same description over and over is not very helpful. Use it once, just before the if() block. Signed-off-by: Philippe Mathieu-Daudé --- Makefile.objs | 19 +++

[PATCH 4/4] Makefile: Remove unhelpful comment

2020-01-09 Thread Philippe Mathieu-Daudé
It is pointless to keep qapi/ object separate from the other common-objects. Drop the comment. Signed-off-by: Philippe Mathieu-Daudé --- Makefile.objs | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 395dd1e670..c6321d0465 100644 --- a

[PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user)

2020-01-09 Thread Philippe Mathieu-Daudé
In some configuration (linux-user, tools) we can ignore building various objects (and the libfdt). Philippe Mathieu-Daudé (4): configure: Do not build libfdt is not required Makefile: Clarify all the codebase requires qom/ objects Makefile: Restrict system emulation and tools objects Makef

[PATCH 1/4] configure: Do not build libfdt is not required

2020-01-09 Thread Philippe Mathieu-Daudé
We only require libfdt for system emulation, in a small set of architecture: 4077 # fdt support is mandatory for at least some target architectures, 4078 # so insist on it if we're building those system emulators. 4079 fdt_required=no 4080 for target in $target_list; do 4081case $target in

[PATCH 14/15] accel/accel: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace 'current_machine' by MACHINE(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- accel/accel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/accel/accel.c b/accel/accel.c index cb555e3b06..777d6ba119 100

[PATCH 13/15] accel: Replace current_machine->accelerator by current_accel() method

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace 'current_machine->accelerator' by current_accel(). Signed-off-by: Philippe Mathieu-Daudé --- accel/kvm/kvm-all.c | 4 ++-- accel/tcg/tcg-all.c | 2 +- memory.c| 2 +- target/arm/kvm64.c | 4 ++-- target/i386/kvm.c | 2 +- ta

[PATCH 11/15] exec: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace 'current_machine' by MACHINE(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- exec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index d4b769d0d4..98f5b049ca 100644 --- a/exe

[Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

2020-01-09 Thread Paul Clarke
Comment #5 suggested splitting the "float" issue to a separate bug, which was done some time ago (bug #1841592). I think this ticket can be closed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18414

Re: Difference between 'current_machine' vs MACHINE(qdev_get_machine())

2020-01-09 Thread Like Xu
On 2020/1/9 20:01, Paolo Bonzini wrote: On 09/01/20 12:23, Philippe Mathieu-Daudé wrote:     current_machine = MACHINE(object_new_with_class(OBJECT_CLASS(machine_class)));     object_property_add_child(object_get_root(), "machine",   OBJECT(current_machine), &err

[PATCH 09/15] device_tree: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace 'current_machine' by MACHINE(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- device_tree.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/device_tree.c b/device_tree.c index f8b46b3c73..665ea2f586 100

[PATCH 15/15] vl: Make current_machine a local variable

2020-01-09 Thread Philippe Mathieu-Daudé
Since we now only use current_machine in vl.c, stop exporting it as a global variable in "hw/board.h", and make it static to vl.c. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h | 2 -- vl.c| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/in

Re: [PATCH 2/2] hyperv/synic: Allocate as ram_device

2020-01-09 Thread Paolo Bonzini
On 09/01/20 14:22, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: >> On Thu, Jan 09, 2020 at 12:22:37PM +, Dr. David Alan Gilbert wrote: >>> Do we want a new memory_region_init for that or just to be able to add >>> a flag? >>> >> I think a flag API is preferable

[PATCH 06/15] migration/savevm: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace MACHINE_GET_CLASS(current_machine) by MACHINE_GET_CLASS(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- migration/savevm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/savevm.c b/m

[PATCH 07/15] hw/core/machine-qmp-cmds: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace MACHINE_GET_CLASS(current_machine) by MACHINE_GET_CLASS(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- hw/core/machine-qmp-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/machine-qmp-c

[PATCH 10/15] memory: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace 'current_machine' by MACHINE(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- memory.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/memory.c b/memory.c index d7b9bb6951..57e38b1f50 100644 --- a/memor

[PATCH 12/15] accel: Introduce the current_accel() method

2020-01-09 Thread Philippe Mathieu-Daudé
We want to remove the global current_machine. The accel/ code access few times current_machine->accelerator. Introduce the current_accel() method first, it will then be easier to replace 'current_machine' by MACHINE(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/ac

[PATCH 05/15] device-hotplug: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace MACHINE_GET_CLASS(current_machine) by MACHINE_GET_CLASS(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- device-hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device-hotplug.c b/device-hotplug.c

[PATCH 04/15] hw/ppc/spapr_rtas: Restrict variables scope to single switch case

2020-01-09 Thread Philippe Mathieu-Daudé
We only access these variables in RTAS_SYSPARM_SPLPAR_CHARACTERISTICS case, restrict their scope to avoid unnecessary initialization. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_rtas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc

[PATCH 02/15] hw/ppc/spapr_rtas: Use local MachineState variable

2020-01-09 Thread Philippe Mathieu-Daudé
Since we have the MachineState already available locally, ues it instead of the global current_machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_rtas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 8d8d8cdfcb..e8

[PATCH 08/15] target/arm/monitor: Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
As we want to remove the global current_machine, replace 'current_machine' by MACHINE(qdev_get_machine()). Signed-off-by: Philippe Mathieu-Daudé --- target/arm/monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/monitor.c b/target/arm/monitor.c index fa054f

[PATCH 03/15] hw/ppc/spapr_rtas: Access MachineState via SpaprMachineState argument

2020-01-09 Thread Philippe Mathieu-Daudé
We received a SpaprMachineState argument. Since SpaprMachineState inherits of MachineState, use it instead of calling qdev_get_machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_rtas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/s

[PATCH 01/15] target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported()

2020-01-09 Thread Philippe Mathieu-Daudé
KVMState is already accessible via CPUState::kvm_state, use it. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/kvm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index b87b59a02a..8d82889150 100644 --- a/target/arm/kvm.c +++ b/t

[PATCH 00/15] Replace current_machine by qdev_get_machine()

2020-01-09 Thread Philippe Mathieu-Daudé
Blurb from previous question [1]: "hw/boards.h" declare current_machine, and vl.c defines it: current_machine = MACHINE(object_new_with_class(OBJECT_CLASS(machine_class))); object_property_add_child(object_get_root(), "machine", OBJECT(current_machine), &e

Re: [PATCH v12 00/13] VIRTIO-IOMMU device

2020-01-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200109144319.15912-1-eric.au...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: Pre-Christmas meeting notes

2020-01-09 Thread Vladimir Sementsov-Ogievskiy
06.01.2020 20:15, Max Reitz wrote: > Misc > > > The Wiki’s TODO list is horribly outdated. What should we do about > it? Maybe archive it and start a new one? (Most of the things on the > current list are either done or we don’t want to do anymore.) May be, create block/TODO.txt instead?

[Bug 1859021] Re: qemu-system-aarch64 (tcg): cval + voff overflow not handled, causes qemu to hang

2020-01-09 Thread Alex Bennée
** Tags added: arm tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859021 Title: qemu-system-aarch64 (tcg): cval + voff overflow not handled, causes qemu to hang Status in QEMU: New Bug d

Re: [PATCH v11 Kernel 3/6] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-01-09 Thread Alex Williamson
On Thu, 9 Jan 2020 18:59:40 +0530 Kirti Wankhede wrote: > On 1/9/2020 3:59 AM, Alex Williamson wrote: > > On Thu, 9 Jan 2020 01:31:16 +0530 > > Kirti Wankhede wrote: > > > >> On 1/8/2020 3:32 AM, Alex Williamson wrote: > >>> On Wed, 8 Jan 2020 01:37:03 +0530 > >>> Kirti Wankhede wrote: > >

  1   2   3   >