[Bug 1656927] Re: Network (TCP) access regression

2020-01-10 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH 066/104] virtiofsd: passthrough_ll: add renameat2 support

2020-01-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:38:26PM +, Dr. David Alan Gilbert (git) wrote: > > From: Miklos Szeredi > > > > No glibc support yet, so use syscall(). > > It exists in glibc in my Fedora 31 install. > > Presumably this is related to an older

[Bug 1653577] Re: Ability to set umask for 9pfs

2020-01-10 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1653577 Title: Ability to set umask for 9pfs Status in QEMU: New Bug description: We

[Bug 1657010] Re: RFE: Please implement -cpu best or a CPU fallback option

2020-01-10 Thread Thomas Huth
As far as I can see, we have "-cpu max" now for x86, arm, ppc and s390x ... is that enough, so that we can close this bug now? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1832281] Re: tcg bug master / 4.0.0 v8 operation >>> and |=

2020-01-10 Thread Thomas Huth
Patch had been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=1e8a98b53867f61da9c ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list()

2020-01-10 Thread Laurent Vivier
Le 10/01/2020 à 10:41, Marc-André Lureau a écrit : > Hi > > On Fri, Jan 10, 2020 at 1:18 PM wrote: >> >> From: Pan Nengyuan >> >> fix a mismatch between g_strsplit and g_free >> >> Reported-by: Laurent Vivier >> Signed-off-by: Pan Nengyuan > > NACK, the elements are added to the returned

Re: Does ppc target support for MTTCG are stable?

2020-01-10 Thread Alex Bennée
罗勇刚(Yonggang Luo) writes: > I enabled it and working, but I don't know if there any other issue are > still not resolved.. Support for MTTCG for ppc64 guests has been enabled for a while. While there is a lot of shared infrastructure in target/ppc between the 32 and 64 bit implementations I'm

Re: [PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list()

2020-01-10 Thread Marc-André Lureau
Hi On Fri, Jan 10, 2020 at 1:18 PM wrote: > > From: Pan Nengyuan > > fix a mismatch between g_strsplit and g_free > > Reported-by: Laurent Vivier > Signed-off-by: Pan Nengyuan NACK, the elements are added to the returned list. > --- > Changes v2 to v1: > - fix a mismatch in qga/main.c > ---

[Bug 1657841] Re: QEMU Intel HAX Windows

2020-01-10 Thread Thomas Huth
Which version were you exactly using? Can you still reproduce the problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 0/2] fix mismatches between g_strsplit and g_free

2020-01-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200110091710.53424-1-pannengy...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] crypto: fix getter of a QCryptoSecret's property

2020-01-10 Thread Daniel P . Berrangé
On Thu, Jan 09, 2020 at 12:09:58PM -0800, Tong Ho wrote: > This fixes the condition-check done by the "loaded" property > getter, such that the property returns true even when the > secret is loaded by the 'file' option. > > Signed-off-by: Tong Ho > --- > Pre-existing getter returns true only

Re: [PATCH 04/15] hw/ppc/spapr_rtas: Restrict variables scope to single switch case

2020-01-10 Thread Philippe Mathieu-Daudé
On 1/9/20 6:43 PM, Greg Kurz wrote: On Thu, 9 Jan 2020 16:21:22 +0100 Philippe Mathieu-Daudé wrote: We only access these variables in RTAS_SYSPARM_SPLPAR_CHARACTERISTICS case, restrict their scope to avoid unnecessary initialization. I guess a decent compiler can be smart enough detect

Re: [PATCH 092/104] virtiofsd: add man page

2020-01-10 Thread Daniel P . Berrangé
On Thu, Jan 09, 2020 at 08:02:13PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:38:52PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: Stefan Hajnoczi > > > > > > Signed-off-by: Stefan Hajnoczi > > > --- > >

[PATCH] target/riscv: Set mstatus.DS & FS correctly

2020-01-10 Thread shihpo . hung
It was found that running libquantum on riscv-linux qemu produced an incorrect result. After investigation, FP registers are not saved during context switch due to incorrect mstatus.FS. Because ctx->mstatus_fs changes dynamically during runtime, we should remove the mstatus_fs check at the

[PATCH] migration/multifd: fix nullptr access in multifd_send_terminate_threads

2020-01-10 Thread Zhimin Feng
If the multifd_send_threads is not created when migration is failed, multifd_save_cleanup would be called twice. In this senario, the multifd_send_state is accessed after it has been released, the result is that the source VM is crashing down. Here is the coredump stack: Program received

[PATCH v2 1/2] vl: Don't mismatch g_strsplit()/g_free()

2020-01-10 Thread pannengyuan
From: Pan Nengyuan It's a mismatch between g_strsplit and g_free, it will cause a memory leak as follow: [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help Accelerators supported in QEMU binary: tcg kvm =

[PATCH v2 0/2] fix mismatches between g_strsplit and g_free

2020-01-10 Thread pannengyuan
From: Pan Nengyuan v1: fix a mismatch in vl.c v2: fix mismatch in vl.c and qga/main.c Pan Nengyuan (2): vl: Don't mismatch g_strsplit()/g_free() qga/main: Don't mismatch g_strsplit/g_free in split_list() qga/main.c | 2 +- vl.c | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list()

2020-01-10 Thread pannengyuan
From: Pan Nengyuan fix a mismatch between g_strsplit and g_free Reported-by: Laurent Vivier Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - fix a mismatch in qga/main.c --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index

Re: [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user)

2020-01-10 Thread Philippe Mathieu-Daudé
Le ven. 10 janv. 2020 09:36, Laurent Vivier a écrit : > Le 09/01/2020 à 16:39, Philippe Mathieu-Daudé a écrit : > > In some configuration (linux-user, tools) we can ignore building > > various objects (and the libfdt). > > > > Philippe Mathieu-Daudé (4): > > configure: Do not build libfdt is

Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO

2020-01-10 Thread Greg Kurz
On Thu, 9 Jan 2020 18:18:57 -0300 André Silva wrote: > Hi Greg, > Hi André, > Thanks for the commit info. > But I'm testing in this scenario, that is, a ppc64le host with a ppc64 > BE guest, and without my patch I can't get virtio to work. The patch What are the symptoms without your patch ?

[Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

2020-01-10 Thread Thomas Huth
Ok, thanks for the pointer to the other bug! So I'm closing this one now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1841491 Title:

Re: [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user)

2020-01-10 Thread Laurent Vivier
Le 09/01/2020 à 16:39, Philippe Mathieu-Daudé a écrit : > In some configuration (linux-user, tools) we can ignore building > various objects (and the libfdt). > > Philippe Mathieu-Daudé (4): > configure: Do not build libfdt is not required > Makefile: Clarify all the codebase requires qom/

Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

2020-01-10 Thread Thomas Huth
On 10/01/2020 09.25, Philippe Mathieu-Daudé wrote: > Le ven. 10 janv. 2020 09:18, Thomas Huth > a écrit : > > On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > > Restrict all the system emulation and tools objects with a > > Makefile IF (CONFIG_SOFTMMU OR

Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

2020-01-10 Thread Philippe Mathieu-Daudé
Le ven. 10 janv. 2020 09:18, Thomas Huth a écrit : > On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > > Restrict all the system emulation and tools objects with a > > Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. > > > > Using the same description over and over is not very helpful. > >

Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

2020-01-10 Thread Thomas Huth
On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > Restrict all the system emulation and tools objects with a > Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. > > Using the same description over and over is not very helpful. > Use it once, just before the if() block. > > Signed-off-by:

Re: [PATCH 2/4] Makefile: Clarify all the codebase requires qom/ objects

2020-01-10 Thread Thomas Huth
On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > QEMU user-mode also requires the qom/ objects, it is not only > used by "system emulation and qemu-img". As we will use a big > if() block, move it upper in the "Common libraries for tools > and emulators" section. > > Signed-off-by: Philippe

[PATCH 3/3] remove redundant check for fpu csr read and write interface

2020-01-10 Thread LIU Zhiwei
The read or write interface must be called after the predicate fs return 0. And the predicate will check (!env->debugger && !riscv_cpu_fp_enabled(env)), S0 no need to check again. Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 24 1 file changed, 24 deletions(-)

Re: [PATCH 4/4] Makefile: Remove unhelpful comment

2020-01-10 Thread Thomas Huth
On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > It is pointless to keep qapi/ object separate from the other > common-objects. Drop the comment. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Makefile.objs | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git

[PATCH 2/3] RISC-V: use FIELD macro to define tb flags

2020-01-10 Thread LIU Zhiwei
FIELD is more unified to define tb flags. It is easier to add new filed to tb flags. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h | 15 +-- target/riscv/translate.c | 5 +++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu.h

[PATCH 1/3] select gdb fpu xml by single or double float extension

2020-01-10 Thread LIU Zhiwei
There is no reason why RISCV32 can't use RVD extension, or RISCV64 can't just use RVF extension. And gdb will check flen according to RVD or RVF feature in elf header. Signed-off-by: LIU Zhiwei --- configure | 4 ++-- target/riscv/gdbstub.c | 14 ++ 2 files changed, 8

Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free()

2020-01-10 Thread Pan Nengyuan
On 1/10/2020 3:59 PM, Laurent Vivier wrote: > Le 10/01/2020 à 04:16, pannengy...@huawei.com a écrit : >> From: Pan Nengyuan >> >> It's a mismatch between g_strsplit and g_free, it will cause a memory leak >> as follow: >> >> [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help

Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free()

2020-01-10 Thread Laurent Vivier
Le 10/01/2020 à 04:16, pannengy...@huawei.com a écrit : > From: Pan Nengyuan > > It's a mismatch between g_strsplit and g_free, it will cause a memory leak as > follow: > > [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help > Accelerators supported in QEMU binary: > tcg > kvm

<    1   2   3