Re: [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-01-14 Thread Greg Kurz
On Fri, 10 Jan 2020 22:41:48 +0300 Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > Reviewed-by: Greg Kurz > CC: Cornelia Huck > CC: Eric Blake > CC: Kevin Wolf > CC: Max Reitz > CC: Greg Kurz > CC: Stefan Hajnoczi > CC: Stefano Stabellini > CC

Re: [PATCH] monitor: fix memory leak in monitor_fdset_dup_fd_find_remove

2020-01-14 Thread Marc-André Lureau
On Wed, Jan 15, 2020 at 11:21 AM wrote: > > From: Chen Qun > > When remove dup_fd in monitor_fdset_dup_fd_find_remove function, > we need to free mon_fdset_fd_dup. ASAN shows memory leak stack: > > Direct leak of 96 byte(s) in 3 object(s) allocated from: > #0 0xfffd37b033b3 in __interceptor_c

Re: [PATCH 1/3] target/i386: Renumber EXCP_SYSCALL

2020-01-14 Thread Philippe Mathieu-Daudé
On 1/14/20 10:09 PM, Richard Henderson wrote: We are not short of numbers for EXCP_*. There is no need to confuse things by having EXCP_VMEXIT and EXCP_SYSCALL overlap, even though the former is only used for system mode and the latter is only used for user mode. Signed-off-by: Richard Henderso

Re: [PATCH 2/3] linux-user/i386: Split out gen_signal

2020-01-14 Thread Philippe Mathieu-Daudé
On 1/14/20 10:09 PM, Richard Henderson wrote: This is a bit tidier than open-coding the 5 lines necessary to initialize the target_siginfo_t. In addition, this zeros the remaining bytes of the target_siginfo_t, rather than passing in garbage. Signed-off-by: Richard Henderson --- linux-user/i

[PATCH] monitor: fix memory leak in monitor_fdset_dup_fd_find_remove

2020-01-14 Thread kuhn.chenqun
From: Chen Qun When remove dup_fd in monitor_fdset_dup_fd_find_remove function, we need to free mon_fdset_fd_dup. ASAN shows memory leak stack: Direct leak of 96 byte(s) in 3 object(s) allocated from: #0 0xfffd37b033b3 in __interceptor_calloc (/lib64/libasan.so.4+0xd33b3) #1 0xfffd375c71

Re: [PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-14 Thread Laurent Desnogues
On Tue, Jan 14, 2020 at 10:09 PM Richard Henderson wrote: [...] > I vaguely remember someone (Paolo?) implementing something like > this many years ago, but clearly it never got merged. That was me back in 2009: https://lists.gnu.org/archive/html/qemu-devel/2009-07/msg00881.html Glad it will fi

Re: [PATCH v3 3/3] target/riscv: update mstatus.SD when FS is set dirty

2020-01-14 Thread Alistair Francis
On Wed, Jan 15, 2020 at 4:19 PM wrote: > > remove the check becuase SD bit should summarize FS and XS fields > unconditionally. > > Signed-off-by: ShihPo Hung > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/csr.c | 3 +-- > target/riscv/tra

Re: [PATCH v3 2/3] target/riscv: fsd/fsw doesn't dirty FP state

2020-01-14 Thread Alistair Francis
On Wed, Jan 15, 2020 at 4:18 PM wrote: > > Signed-off-by: ShihPo Hung > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn_trans/trans_rvd.inc.c | 1 - > target/riscv/insn_trans/trans_rvf.inc.c | 1 - > 2 files changed, 2 deletions(-) > > diff --

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Michael S. Tsirkin
Problem is IASL disassembler still doesn't work on all hosts we want to support. And its output isn't really stable enough to act as a golden master. Until we have a better tool, I propose the contributor just follows all steps 1-6. The reason they have been listed as maintainer action items is

Re: [PATCH v3 1/3] target/riscv: Fix tb->flags FS status

2020-01-14 Thread Alistair Francis
On Wed, Jan 15, 2020 at 4:18 PM wrote: > > It was found that running libquantum on riscv-linux qemu produced an > incorrect result. After investigation, FP registers are not saved > during context switch due to incorrect mstatus.FS. > > In current implementation tb->flags merges all non-disabled s

[PATCH v2] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks

2020-01-14 Thread pannengyuan
From: Pan Nengyuan Receive/transmit/event vqs forgot to cleanup in vhost_vsock_unrealize. This patch save receive/transmit vq pointer in realize() and cleanup vqs through those vq pointers in unrealize(). The leak stack is as follow: Direct leak of 21504 byte(s) in 3 object(s) allocated from:

[PATCH v3 3/3] target/riscv: update mstatus.SD when FS is set dirty

2020-01-14 Thread shihpo . hung
remove the check becuase SD bit should summarize FS and XS fields unconditionally. Signed-off-by: ShihPo Hung Reviewed-by: Richard Henderson --- target/riscv/csr.c | 3 +-- target/riscv/translate.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/target/riscv/csr.c b

[PATCH v3 1/3] target/riscv: Fix tb->flags FS status

2020-01-14 Thread shihpo . hung
It was found that running libquantum on riscv-linux qemu produced an incorrect result. After investigation, FP registers are not saved during context switch due to incorrect mstatus.FS. In current implementation tb->flags merges all non-disabled state to dirty. This means the code in mark_fs_dirty

[PATCH v3 2/3] target/riscv: fsd/fsw doesn't dirty FP state

2020-01-14 Thread shihpo . hung
Signed-off-by: ShihPo Hung Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvd.inc.c | 1 - target/riscv/insn_trans/trans_rvf.inc.c | 1 - 2 files changed, 2 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvd.inc.c b/target/riscv/insn_trans/trans_rvd.inc.c index 393fa

Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status

2020-01-14 Thread ShihPo Hung
On Tue, Jan 14, 2020 at 11:29 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 1/14/20 12:13 AM, shihpo.h...@sifive.com wrote: > > if (riscv_cpu_fp_enabled(env)) { > > -*flags |= TB_FLAGS_MSTATUS_FS; > > +*flags |= env->mstatus & MSTATUS_FS; > > } > > Note

Re: [PATCH v5 08/22] gdbstub: extend GByteArray to read register helpers

2020-01-14 Thread David Gibson
On Tue, Jan 14, 2020 at 03:09:39PM +, Alex Bennée wrote: > Instead of passing a pointer to memory now just extend the GByteArray > to all the read register helpers. They can then safely append their > data through the normal way. We don't bother with this abstraction for > write registers as we

Re: [PATCH V2] vhost-user-test: fix a memory leak

2020-01-14 Thread Pan Nengyuan
On 1/13/2020 10:32 AM, Pan Nengyuan wrote: > > > On 1/12/2020 6:39 PM, Thomas Huth wrote: >> On 10/01/2020 15.07, Thomas Huth wrote: >>> On 20/12/2019 02.26, pannengy...@huawei.com wrote: From: Pan Nengyuan Spotted by ASAN. Reported-by: Euler Robot Signed-off-by

RE: [PATCH RFC 01/12] migration: Add multiRDMA capability support

2020-01-14 Thread fengzhimin
Thanks for your review. I will fix these errors in the next version(V2). I hope you can busy schedule to find time to check other patches about Multi-RDMA. -Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday, January 14, 2020 12:27 AM To: fengzhimin ; quint...@re

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Guoheyi
Hi Peter, Michael, Have we come to conclusion on how to submit patches for ARM ACPI tables? Some rough thoughts: is it possible to use the disassembled ASL file as the 'golden master' data? One problem I can imagine is that this may introduce dependency on the version of iASL tool. If so, how

RE: [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter

2020-01-14 Thread fengzhimin
Thanks for your review. I will fix these errors in the next version(V2). -Original Message- From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Monday, January 13, 2020 11:35 PM To: fengzhimin Cc: quint...@redhat.com; dgilb...@redhat.com; ebl...@redhat.com; jemmy858...@gmail.com; q

RE: [PATCH RFC 01/12] migration: Add multiRDMA capability support

2020-01-14 Thread fengzhimin
Thanks for your review. I will change it in the next version(V2). -Original Message- From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Monday, January 13, 2020 11:30 PM To: fengzhimin Cc: quint...@redhat.com; dgilb...@redhat.com; ebl...@redhat.com; jemmy858...@gmail.com; qemu-dev

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

2020-01-14 Thread yuchenlin
Hi, Samuel This patch has been viewed by Daniel. Please see https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00264.html However, Daniel has not sent a PR which includes this patch. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [PATCH] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks

2020-01-14 Thread Pan Nengyuan
On 1/15/2020 12:59 AM, Stefano Garzarella wrote: > On Tue, Jan 14, 2020 at 5:45 PM Stefan Hajnoczi wrote: >> >> On Tue, Jan 14, 2020 at 03:52:29PM +0800, pannengy...@huawei.com wrote: >>> From: Pan Nengyuan >>> >>> Receive/transmit/event vqs forgot to cleanup in vhost_vsock_unrealize. This >>>

Re: [PATCH] virtio-9p-device: fix memleak in virtio_9p_device_unrealize

2020-01-14 Thread Pan Nengyuan
On 1/14/2020 10:17 PM, Christian Schoenebeck wrote: > On Dienstag, 14. Januar 2020 11:08:59 CET Christian Schoenebeck wrote: >> On Dienstag, 14. Januar 2020 08:40:20 CET pannengy...@huawei.com wrote: >>> From: Pan Nengyuan >>> >>> v->vq forgot to cleanup in virtio_9p_device_unrealize, the memor

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Guoheyi
在 2020/1/13 23:26, Andrew Jones 写道: On Mon, Jan 13, 2020 at 09:57:55PM +0800, Guoheyi wrote: 在 2020/1/13 20:08, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algo

Re: Semihosting, arm, riscv, ppc and common code

2020-01-14 Thread Benjamin Herrenschmidt
On Tue, 2020-01-14 at 09:59 +, Peter Maydell wrote: > Note that semihosting is not a "here's a handy QEMU feature" > thing. It's an architecture-specific API and ABI, which should > be defined somewhere in a standard external to QEMU. There is no such standard for powerpc today that I know of.

Re: Semihosting, arm, riscv, ppc and common code

2020-01-14 Thread Benjamin Herrenschmidt
On Tue, 2020-01-14 at 09:51 +, Alex Bennée wrote: > > Well, one of the LCA talks wasn't that interesting so I started > > doing > > it and am almost done :-) > > > > I'll look at doing something for arm, riscv and ppc and send > > patches > > once I get it working. > > Cool. Are you consideri

Re: [PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-14 Thread Paolo Bonzini
On 14/01/20 22:09, Richard Henderson wrote: > I vaguely remember someone (Paolo?) implementing something like > this many years ago, but clearly it never got merged. Nope, certainly not me. > In any case, this emulation has been missing for too long. > > > r~ > > > Richard Henderson (3): >

Re: [PATCH v28 22/22] qemu-doc.texi: Add RX section.

2020-01-14 Thread Aleksandar Markovic
On Sunday, January 12, 2020, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > qemu-doc.texi | 25 + > 1 file changed, 25 insertions(+) > > It would be nice if you provided an example of qemu command line invocation that btings RX machine up (see nanomips sec

Re: [PATCH v3 10/17] hw/arm/allwinner-h3: add Boot ROM support

2020-01-14 Thread Niek Linnenbank
On Tue, Jan 14, 2020 at 12:28 AM Philippe Mathieu-Daudé wrote: > On 1/8/20 9:00 PM, Niek Linnenbank wrote: > > A real Allwinner H3 SoC contains a Boot ROM which is the > > first code that runs right after the SoC is powered on. > > The Boot ROM is responsible for loading user code (e.g. a bootloa

Re: [PATCH v28 17/22] hw/rx: RX Target hardware definition

2020-01-14 Thread Aleksandar Markovic
On Sunday, January 12, 2020, Yoshinori Sato wrote: > rx62n - RX62N cpu. > rx-virt - RX QEMU virtual target. > > v23 changes. > Add missing includes. > > v21 changes. > rx_load_image move to rx-virt.c > > Hello, Yoshinori. These lines: > v23 changes. > Add missing includes. > > v21 changes. >

[Bug 1859713] Re: ARM v8.3a pauth not working

2020-01-14 Thread Richard Henderson
** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Richard Henderson (rth) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859713 Title: ARM v8.3

Re: [PATCH v3 06/17] hw/arm/allwinner: add CPU Configuration module

2020-01-14 Thread Niek Linnenbank
On Tue, Jan 14, 2020 at 12:14 AM Philippe Mathieu-Daudé wrote: > On 1/8/20 9:00 PM, Niek Linnenbank wrote: > > Various Allwinner System on Chip designs contain multiple processors > > that can be configured and reset using the generic CPU Configuration > > module interface. This commit adds suppo

Re: [PATCH v3 12/17] hw/arm/allwinner: add RTC device support

2020-01-14 Thread Niek Linnenbank
On Tue, Jan 14, 2020 at 11:52 PM Niek Linnenbank wrote: > Hi Philippe, > > On Mon, Jan 13, 2020 at 11:57 PM Philippe Mathieu-Daudé > wrote: > >> On 1/8/20 9:00 PM, Niek Linnenbank wrote: >> > Allwinner System-on-Chips usually contain a Real Time Clock (RTC) >> > for non-volatile system date and

Re: [PATCH v3 12/17] hw/arm/allwinner: add RTC device support

2020-01-14 Thread Niek Linnenbank
Hi Philippe, On Mon, Jan 13, 2020 at 11:57 PM Philippe Mathieu-Daudé wrote: > On 1/8/20 9:00 PM, Niek Linnenbank wrote: > > Allwinner System-on-Chips usually contain a Real Time Clock (RTC) > > for non-volatile system date and time keeping. This commit adds a generic > > Allwinner RTC device tha

[Bug 1859723] [NEW] Qemu ungrabs before cursor reaches border

2020-01-14 Thread Nils ANDRÉ-CHANG
Public bug reported: This was first reported https://bugzilla.redhat.com/show_bug.cgi?id=1285378 video: https://peertube.co.uk/videos/watch/fedaa432-79ef-4d30-bd0e- 26c806e48db0 version: QEMU emulator version 4.2.0 ** Affects: qemu Importance: Undecided Status: New -- You receiv

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-14 Thread Gavin Shan
On 12/19/19 3:06 PM, Gavin Shan wrote: This supports NMI injection for virtual machine and currently it's only supported on GICv3 controller, which is emulated by qemu or host kernel. The design is highlighted as below: * The NMI is identified by its priority (0x20). In the guest (linux)

Re: [PATCH] qcow2: Use a GString in report_unsupported_feature()

2020-01-14 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 1/14/20 7:08 PM, Alex Bennée wrote: >> Alberto Garcia writes: >> >>> This is a bit more efficient than having to allocate and free memory >>> for each item. >>> >>> The default size (60) is enough for all the existing incompatible >>> features. >>> >>> Sugg

[Bug 1859713] [NEW] ARM v8.3a pauth not working

2020-01-14 Thread Adrien Grassein
Public bug reported: Host: Ubuntu 19.10 - x86_64 machine QEMU version: 3a63b24a1bbf166e6f455fe43a6bbd8dea413d92 (master) ARMV8.3 pauth is not working well. With a test code containing two pauth instructions: - paciasp that sign LR with A key and sp as context; - autiasp that verify the s

Re: [PATCH 00/13] LUKS: encryption slot management using amend interface

2020-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200114193350.10830-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/13] LUKS: encryption slot management using amend interface Type: series Message-id: 20200114193

Re: [PATCH 00/13] LUKS: encryption slot management using amend interface

2020-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200114193350.10830-1-mlevi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

[PATCH 3/3] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-14 Thread Richard Henderson
Notice the magic page during translate, much like we already do for the arm32 commpage. At runtime, raise an exception to return cpu_loop for emulation. Signed-off-by: Richard Henderson --- target/i386/cpu.h | 1 + linux-user/i386/cpu_loop.c | 104

[PATCH 1/3] target/i386: Renumber EXCP_SYSCALL

2020-01-14 Thread Richard Henderson
We are not short of numbers for EXCP_*. There is no need to confuse things by having EXCP_VMEXIT and EXCP_SYSCALL overlap, even though the former is only used for system mode and the latter is only used for user mode. Signed-off-by: Richard Henderson --- target/i386/cpu.h | 5 ++--- 1 file chan

[PATCH 2/3] linux-user/i386: Split out gen_signal

2020-01-14 Thread Richard Henderson
This is a bit tidier than open-coding the 5 lines necessary to initialize the target_siginfo_t. In addition, this zeros the remaining bytes of the target_siginfo_t, rather than passing in garbage. Signed-off-by: Richard Henderson --- linux-user/i386/cpu_loop.c | 93 ++---

[PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-14 Thread Richard Henderson
The x86_64 abi has a legacy vsyscall page. The kernel folk have been trying to deprecate this since at least v3.1, but (1) We don't implement the vdso that replaces vsyscalls, (2) As of v5.5, the vsyscall page is still enabled by default. This lack is affecting Peter's linux-user testing. The d

Re: [PATCH] target/m68k: Allow movec only on 68010+

2020-01-14 Thread Laurent Vivier
Le 14/01/2020 à 21:13, BALATON Zoltan a écrit : > The movec opcode does not exist on 68000 and should raise an > exception. Fix the feature mask to only allow movec on newer 68k CPUs. > > Signed-off-by: BALATON Zoltan > --- > target/m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines

2020-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200114182735.5553-1-kw...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

[PATCH] target/m68k: Allow movec only on 68010+

2020-01-14 Thread BALATON Zoltan
The movec opcode does not exist on 68000 and should raise an exception. Fix the feature mask to only allow movec on newer 68k CPUs. Signed-off-by: BALATON Zoltan --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/

Re: [PATCH] tests: acpi: update path in rebuild-expected-aml

2020-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200114165138.15716-1-shameerali.kolothum.th...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] tests: acpi: update path in rebuild-expected-aml Type: series Message-id: 202001

[PATCH 08/13] iotests: filter few more luks specific create options

2020-01-14 Thread Maxim Levitsky
This allows more tests to be able to have same output on both qcow2 luks encrypted images and raw luks images Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/087.out | 6 +++--- tests/qemu-iotests/134.out | 2 +- tests/qemu-iotests/158.out | 4 ++-- tests/qemu-iotests/188

Re: [PATCH v2 0/3] block/io: serialising request clean up and locking fix

2020-01-14 Thread Paolo Bonzini
On 14/01/20 17:28, Stefan Hajnoczi wrote: > On Wed, Jan 08, 2020 at 03:55:53PM +0100, Paolo Bonzini wrote: >> Peter Lieven noticed that reqs->overlap_offset and reqs->overlap_bytes >> are written outside bs->reqs_lock. Patch 3 fixes it, while patches 1 >> and 2 are preparatory cleanups. >> >> v1->

[PATCH 09/13] qemu-iotests: qemu-img tests for luks key management

2020-01-14 Thread Maxim Levitsky
This commit adds two tests, which test the new amend interface of both luks raw images and qcow2 luks encrypted images. Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/300 | 207 + tests/qemu-iotests/300.out | 99 ++ tests/qemu-iotest

[PATCH 13/13] iotests: add tests for blockdev-amend

2020-01-14 Thread Maxim Levitsky
This commit adds two tests that cover the new blockdev-amend functionality of luks and qcow2 driver Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/302 | 284 + tests/qemu-iotests/302.out | 40 ++ tests/qemu-iotests/303 | 235

[PATCH 11/13] block/crypto: implement blockdev-amend

2020-01-14 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/crypto.c | 70 qapi/block-core.json | 14 - 2 files changed, 64 insertions(+), 20 deletions(-) diff --git a/block/crypto.c b/block/crypto.c index 081880bced..6836337863 100644 --- a/block/crypto.c

[PATCH 02/13] qcrypto-luks: implement encryption key management

2020-01-14 Thread Maxim Levitsky
Next few patches will expose that functionality to the user. Signed-off-by: Maxim Levitsky --- crypto/block-luks.c | 374 +++- qapi/crypto.json| 50 +- 2 files changed, 421 insertions(+), 3 deletions(-) diff --git a/crypto/block-luks.c b/crypto/b

[PATCH 06/13] block/crypto: implement the encryption key management

2020-01-14 Thread Maxim Levitsky
This implements the encryption key management using the generic code in qcrypto layer and exposes it to the user via qemu-img This code adds another 'write_func' because the initialization write_func works directly on the underlying file, and amend works on instance of luks device. This commit al

[PATCH 12/13] block/qcow2: implement blockdev-amend

2020-01-14 Thread Maxim Levitsky
Currently the implementation only supports amending the encryption options, unlike the qemu-img version Signed-off-by: Maxim Levitsky --- block/qcow2.c| 39 +++ qapi/block-core.json | 16 +++- 2 files changed, 54 insertions(+), 1 deletion(-

[PATCH 10/13] block: add generic infrastructure for x-blockdev-amend qmp command

2020-01-14 Thread Maxim Levitsky
blockdev-amend will be used similiar to blockdev-create to allow on the fly changes of the structure of the format based block devices. Current plan is to first support encryption keyslot management for luks based formats (raw and embedded in qcow2) Signed-off-by: Maxim Levitsky --- block/Makef

[PATCH 05/13] block/crypto: rename two functions

2020-01-14 Thread Maxim Levitsky
rename the write_func to create_write_func, and init_func to create_init_func. This is preparation for other write_func that will be used to update the encryption keys. No functional changes Signed-off-by: Maxim Levitsky Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 25

[PATCH 01/13] qcrypto: add generic infrastructure for crypto options amendment

2020-01-14 Thread Maxim Levitsky
This will be used first to implement luks keyslot management. block_crypto_amend_opts_init will be used to convert qemu-img cmdline to QCryptoBlockAmendOptions Signed-off-by: Maxim Levitsky --- block/crypto.c | 17 + block/crypto.h | 3 +++ crypto/block.c

[PATCH 00/13] LUKS: encryption slot management using amend interface

2020-01-14 Thread Maxim Levitsky
Hi! Here is the updated series of my patches, incorporating all the feedback I received. Patches are strictly divided by topic to 3 groups, and each group depends on former groups. * Patches 1,2 implement qcrypto generic amend interface, including definition of structs used in crypto.json an

[PATCH 04/13] block: amend: separate amend and create options for qemu-img

2020-01-14 Thread Maxim Levitsky
Some options are only useful for creation (or hard to be amended, like cluster size for qcow2), while some other options are only useful for amend, like upcoming keyslot management options for luks Since currently only qcow2 supports amend, move all its options to a common macro and then include i

[PATCH 07/13] qcow2: extend qemu-img amend interface with crypto options

2020-01-14 Thread Maxim Levitsky
Now that we have all the infrastructure in place, wire it in the qcow2 driver and expose this to the user. Signed-off-by: Maxim Levitsky --- block/qcow2.c | 101 +++--- 1 file changed, 79 insertions(+), 22 deletions(-) diff --git a/block/qcow2.c b/blo

[PATCH 03/13] block: amend: add 'force' option

2020-01-14 Thread Maxim Levitsky
'force' option will be used for some unsafe amend operations. This includes things like erasing last keyslot in luks based formats (which destroys the data, unless the master key is backed up by external means), but that _might_ be desired result. Signed-off-by: Maxim Levitsky Reviewed-by: Danie

Re: [PATCH v12 12/13] virtio-iommu: Support migration

2020-01-14 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:18PM +0100, Eric Auger wrote: > Add Migration support. We rely on recently added gtree and qlist > migration. We only migrate the domain gtree. The endpoint gtree > is re-constructed in a post-load operation. > > Signed-off-by: Eric Auger Acked-by: Peter Xu -- Pe

Re: [PATCH v12 09/13] virtio-iommu: Implement fault reporting

2020-01-14 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:15PM +0100, Eric Auger wrote: > The event queue allows to report asynchronous errors. > The translate function now injects faults when relevant. > > Signed-off-by: Eric Auger > > --- > > v11 -> v12: > - reporting the addr associated with the fault and set the > V

Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines

2020-01-14 Thread Kevin Wolf
Am 14.01.2020 um 19:45 hat Daniel P. Berrangé geschrieben: > On Tue, Jan 14, 2020 at 07:27:31PM +0100, Kevin Wolf wrote: > > Some QMP command handlers can block the main loop for a relatively long > > time, for example because they perform some I/O. This is quite nasty. > > Allowing such handlers t

Re: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks)

2020-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200114150953.27659-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks) Type: series Message-id: 2020011

Re: [PATCH v12 07/13] virtio-iommu: Implement map/unmap

2020-01-14 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:13PM +0100, Eric Auger wrote: > This patch implements virtio_iommu_map/unmap. > > Signed-off-by: Eric Auger Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH] hw/vfio: Move the IGD quirk code to a separate file

2020-01-14 Thread Philippe Mathieu-Daudé
On 1/14/20 7:47 PM, Alex Williamson wrote: On Tue, 14 Jan 2020 18:10:26 +0100 Philippe Mathieu-Daudé wrote: On 1/14/20 5:17 PM, Thomas Huth wrote: The IGD quirk code defines a separate device, the so-called "vfio-pci-igd-lpc-bridge" which shows up as a user-creatable device in all QEMU binari

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-14 Thread Peter Xu
On Tue, Jan 14, 2020 at 09:37:51AM +0100, Auger Eric wrote: > > In all cases, I see that virtio_iommu_mr() is introduced but not used. > > Would be good to put it into the patch where it's firstly used. > OK fair enough, I will put the helper in the same patch as the user as > you have requested th

Re: [PATCH] hw/vfio: Move the IGD quirk code to a separate file

2020-01-14 Thread Alex Williamson
On Tue, 14 Jan 2020 18:10:26 +0100 Philippe Mathieu-Daudé wrote: > On 1/14/20 5:17 PM, Thomas Huth wrote: > > The IGD quirk code defines a separate device, the so-called > > "vfio-pci-igd-lpc-bridge" which shows up as a user-creatable > > device in all QEMU binaries that include the vfio code. Th

Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines

2020-01-14 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 07:27:31PM +0100, Kevin Wolf wrote: > Some QMP command handlers can block the main loop for a relatively long > time, for example because they perform some I/O. This is quite nasty. > Allowing such handlers to run in a coroutine where they can yield (and > therefore release

Re: [PATCH] qcow2: Use a GString in report_unsupported_feature()

2020-01-14 Thread Philippe Mathieu-Daudé
On 1/14/20 7:08 PM, Alex Bennée wrote: Alberto Garcia writes: This is a bit more efficient than having to allocate and free memory for each item. The default size (60) is enough for all the existing incompatible features. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alberto Garcia -

[PATCH v2 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-14 Thread Kevin Wolf
This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher that the command handler is safe to be run in a coroutine. Signed-off-by: Kevin Wolf Reviewed-by: Marc-André Lureau --- tests/qapi-schema/qapi-schema-test.json | 1 + docs/devel/qapi-code-gen.txt

[PATCH v2 0/4] qmp: Optionally run handlers in coroutines

2020-01-14 Thread Kevin Wolf
Some QMP command handlers can block the main loop for a relatively long time, for example because they perform some I/O. This is quite nasty. Allowing such handlers to run in a coroutine where they can yield (and therefore release the BQL) while waiting for an event such as I/O completion solves th

[PATCH v2 4/4] block: Mark 'block_resize' as coroutine

2020-01-14 Thread Kevin Wolf
block_resize is safe to run in a coroutine, so use it as an example for the new 'coroutine': true annotation in the QAPI schema. Signed-off-by: Kevin Wolf Reviewed-by: Marc-André Lureau --- qapi/block-core.json | 3 ++- blockdev.c | 6 +++--- 2 files changed, 5 insertions(+), 4 deleti

[PATCH v2 2/4] vl: Initialise main loop earlier

2020-01-14 Thread Kevin Wolf
We want to be able to use qemu_aio_context in the monitor initialisation. Signed-off-by: Kevin Wolf Reviewed-by: Marc-André Lureau --- vl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 86474a55c9..4c79a00857 100644 --- a/vl.c +++ b/vl.c @@ -29

[PATCH v2 3/4] qmp: Move dispatcher to a coroutine

2020-01-14 Thread Kevin Wolf
This moves the QMP dispatcher to a coroutine and runs all QMP command handlers that declare 'coroutine': true in coroutine context so they can avoid blocking the main loop while doing I/O or waiting for other events. For commands that are not declared safe to run in a coroutine, the dispatcher dro

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-14 Thread Alex Bennée
** Tags added: testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859384 Title: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq Status in QEMU: Ne

Re: [PATCH] qcow2: Use a GString in report_unsupported_feature()

2020-01-14 Thread Alex Bennée
Alberto Garcia writes: > This is a bit more efficient than having to allocate and free memory > for each item. > > The default size (60) is enough for all the existing incompatible > features. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 24

Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers

2020-01-14 Thread Peter Xu
On Tue, Jan 14, 2020 at 09:51:59AM +0100, Auger Eric wrote: > Hi Peter, Hi, Eric, [...] > > > >> +{ > >> +VirtIOIOMMUEndpoint *ep; > >> + > >> +ep = g_tree_lookup(s->endpoints, GUINT_TO_POINTER(ep_id)); > >> +if (ep) { > >> +return ep; > >> +} > >> +if (!virtio_iommu

Re: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2020-01-14 Thread Roger Pau Monné
On Tue, Jan 14, 2020 at 09:41:46AM -0500, Jason Andryuk wrote: > On Tue, Jan 14, 2020 at 5:04 AM Roger Pau Monné wrote: > > > > On Mon, Jan 13, 2020 at 02:01:47PM -0500, Jason Andryuk wrote: > > > On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote: > > > > > > > > On Thu, Mar 21, 2019 at 11:09 P

Re: Priority of -accel

2020-01-14 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 06:49:45PM +0100, Christophe de Dinechin wrote: > > > > On 13 Jan 2020, at 17:25, Paolo Bonzini wrote: > > > > On 13/01/20 17:17, Markus Armbruster wrote: > >> Perfect opportunity to change the default to something more useful. > > > > I am not sure acutally if it's tha

Re: Priority of -accel

2020-01-14 Thread Christophe de Dinechin
> On 13 Jan 2020, at 17:25, Paolo Bonzini wrote: > > On 13/01/20 17:17, Markus Armbruster wrote: >> Perfect opportunity to change the default to something more useful. > > I am not sure acutally if it's that more useful, now that we have > sanctioned qemu-kvm as the fast alternative. OK, hal

Re: Making QEMU easier for management tools and applications

2020-01-14 Thread Christophe de Dinechin
I started cutting some stuff out. > On 14 Jan 2020, at 14:04, Markus Armbruster wrote: > > Prior art: > >Presentation >KVM Forum 2017: Towards a More Expressive and Introspectable QEMU >Command Line >https://www.youtube.com/watch?v=gtpOLQgnwug >https://www.linux-kvm.org/imag

Re: [PATCH] hw/vfio: Move the IGD quirk code to a separate file

2020-01-14 Thread Philippe Mathieu-Daudé
On 1/14/20 5:17 PM, Thomas Huth wrote: The IGD quirk code defines a separate device, the so-called "vfio-pci-igd-lpc-bridge" which shows up as a user-creatable device in all QEMU binaries that include the vfio code. This is a little bit unfortunate for two reasons: First, this device is completel

Re: [PATCH] tests: acpi: update path in rebuild-expected-aml

2020-01-14 Thread Thomas Huth
On 14/01/2020 17.51, Shameer Kolothum wrote: > Since commit 1e8a1fae7464("test: Move qtests to a separate > directory") qtests are now placed in a separate folder and > this breaks the script used to rebuild the expected ACPI > tables for bios-tables-test. Update the script with correct > path. >

Re: [PATCH] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks

2020-01-14 Thread Stefano Garzarella
On Tue, Jan 14, 2020 at 5:45 PM Stefan Hajnoczi wrote: > > On Tue, Jan 14, 2020 at 03:52:29PM +0800, pannengy...@huawei.com wrote: > > From: Pan Nengyuan > > > > Receive/transmit/event vqs forgot to cleanup in vhost_vsock_unrealize. This > > patch save receive/transmit vq pointer in realize() and

[PATCH] tests: acpi: update path in rebuild-expected-aml

2020-01-14 Thread Shameer Kolothum
Since commit 1e8a1fae7464("test: Move qtests to a separate directory") qtests are now placed in a separate folder and this breaks the script used to rebuild the expected ACPI tables for bios-tables-test. Update the script with correct path. Fixes: 1e8a1fae7464("test: Move qtests to a separate dire

Re: [PATCH] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks

2020-01-14 Thread Stefan Hajnoczi
On Tue, Jan 14, 2020 at 03:52:29PM +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Receive/transmit/event vqs forgot to cleanup in vhost_vsock_unrealize. This > patch save receive/transmit vq pointer in realize() and cleanup vqs > through those vq pointers in unrealize(). The leak s

Re: [PULL 0/2] Ui 20200114 patches

2020-01-14 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20200114-pull-request > > for you to fetch changes up to c4c00922cc948bb5e879bfae60764eba1f8745f3: > > display/gtk: get proper refreshrate (2020-01-14 07:26:36 +0100) > >

Re: [PATCH v5 05/20] linux-user: mips: Update syscall numbers to kernel 5.5 rc3 level

2020-01-14 Thread Laurent Vivier
Le 13/01/2020 à 21:34, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Update mips syscall numbers based on Linux kernel tag v5.5-rc3 > (commit 46cf053e). > > Signed-off-by: Aleksandar Markovic > --- > linux-user/mips/cpu_loop.c | 78 > +++

Re: [PATCH] vhost-user-blk: reset the device if supported

2020-01-14 Thread Stefan Hajnoczi
On Fri, Jan 10, 2020 at 08:22:03PM +0800, Yang Zhong wrote: > As the vhost-user-scsi did in f04724, if the vhost-user-blk backend > supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the > device can be reset when requested. > > If this feature is not supported, this reset will directly

Re: [PATCH 2/4] block: Mark 'block_resize' as coroutine

2020-01-14 Thread Stefan Hajnoczi
On Mon, Jan 13, 2020 at 06:10:09PM +0100, Kevin Wolf wrote: > Am 13.01.2020 um 17:56 hat Stefan Hajnoczi geschrieben: > > On Thu, Jan 09, 2020 at 07:35:43PM +0100, Kevin Wolf wrote: > > > block_resize is safe to run in a coroutine, so use it as an example for > > > the new 'coroutine': true annotat

Re: [PATCH v2 0/3] block/io: serialising request clean up and locking fix

2020-01-14 Thread Stefan Hajnoczi
On Wed, Jan 08, 2020 at 03:55:53PM +0100, Paolo Bonzini wrote: > Peter Lieven noticed that reqs->overlap_offset and reqs->overlap_bytes > are written outside bs->reqs_lock. Patch 3 fixes it, while patches 1 > and 2 are preparatory cleanups. > > v1->v2: fix comment in patch 2, commit message in pa

Re: PCIe device paththrough via vfio issue

2020-01-14 Thread Alex Williamson
On Tue, 14 Jan 2020 19:02:41 +0300 yurij wrote: > On 1/14/20 5:04 PM, Alex Williamson wrote: > > On Tue, 14 Jan 2020 17:14:33 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 14/01/2020 03:28, Alex Williamson wrote: > >>> On Mon, 13 Jan 2020 18:49:21 +0300 > >>> yurij wrote: > >>> >

[PATCH] hw/vfio: Move the IGD quirk code to a separate file

2020-01-14 Thread Thomas Huth
The IGD quirk code defines a separate device, the so-called "vfio-pci-igd-lpc-bridge" which shows up as a user-creatable device in all QEMU binaries that include the vfio code. This is a little bit unfortunate for two reasons: First, this device is completely useless in binaries like qemu-system-s3

Re: [BUG qemu 4.0] segfault when unplugging virtio-blk-pci device

2020-01-14 Thread Stefan Hajnoczi
On Tue, Jan 14, 2020 at 10:50:58AM +0800, Eryu Guan wrote: > On Mon, Jan 13, 2020 at 04:38:55PM +, Stefan Hajnoczi wrote: > > On Thu, Jan 09, 2020 at 12:58:06PM +0800, Eryu Guan wrote: > > > On Tue, Jan 07, 2020 at 03:01:01PM +0100, Julia Suvorova wrote: > > > > On Tue, Jan 7, 2020 at 2:06 PM E

Re: [PATCH 2/4] linux-user: Use `qemu_log' for strace

2020-01-14 Thread Paolo Bonzini
On 14/01/20 10:09, Laurent Vivier wrote: > Perhaps we can use flag LOG_TRACE? (cc Paolo) No, LOG_TRACE is for trace-events tracepoints. A new logging flag is definitely the way to go. Paolo

  1   2   3   4   5   >